profile
viewpoint
Wojtek Siudzinski suda Particle @particle-iot Valencia, Spain https://suda.pl Senior Software Engineer at Particle / Owner at @appsome / Founder at @gaia-green-tech

suda/bitbeam 3

Bitbeam = Lego + Grid Beam = Awesome

meal/makerland-meetup 2

Schemes and code for Makerland Meetup Arduino Yun workshops

suda/android-car-ui 2

Collection of Android app backups forming a nicer UI for use in cars

suda/ackee-chart 1

Helm Chart for Ackee self-hosted analytics tool

suda/airblip 1

Multiplatform client of Blip.pl

suda/as3bliplib 1

Action Script 3.0 library for Blip.pl (polish Twitter clone)

suda/bar 1

Another example repo for testing

suda/buzzlights 1

3D printed hexagonal lights with Neopixel LEDs

startedbenkehoe/aws-sso-util

started time in 3 hours

startedmortenbekditlevsen/SwiftGTKUI

started time in a day

startedMaxDesiatov/XCTestJSONObserver

started time in a day

issue commentsuda/tool-bar

Touch Bar integration broken (again)

I have the same issue too

jpcranford

comment created time in 2 days

startedmammaldiversity/mammaldiversity.github.io

started time in 2 days

startedsuda/tool-bar

started time in 2 days

created repositorychrisanthropic/LinuxMusicProduction

My personal notes for making music on Linux

created time in 3 days

fork hugovk/contributing

Guidelines and instructions for contributing to Fatiando a Terra, including authorship policies, maintenance, and code of conduct

fork in 3 days

startedsuda/k8s-ovpn-chart

started time in 3 days

startedottomated/CrewLink

started time in 3 days

created repositorynode-red/node-red-learn

created time in 3 days

startedjhuangtw/xg2xg

started time in 4 days

startedFenrirthviti/obs-virtual-cam

started time in 4 days

startedRasCarlito/sails-hook-next

started time in 5 days

starteddessant/lock-threads-app

started time in 5 days

fork hugovk/geojson

Python bindings and utilities for GeoJSON

https://pypi.python.org/pypi/geojson/

fork in 5 days

startedemacs-pe/docker-tramp.el

started time in 5 days

pull request commentsuda/tool-bar

Fix importing for touch-bar-manager

@aminya, do you have any preference regarding the remaining problem?

I'll take a look tonight. Sorry I missed this PR.

thatcomputerguy0101

comment created time in 7 days

pull request commentsuda/tool-bar

Fix importing for touch-bar-manager

I looked into a solution for the second part of this problem, and apparently, the activate method is supposed to be async compatible. That came from the Atom flight manual, where it says:

activate(state): This optional method is called when your package is activated. It is passed the state data from the last time the window was serialized if your module implements the serialize() method. Use this to do initialization work when your package is started (like setting up DOM elements or binding events). If this method returns a promise the package will be considered loading until the promise resolves (or rejects).

However, the relationship between a package being considered "loaded" and its service provider functions being called doesn't appear to be well defined, as provideToolBar would be called even when returning the promise from calling useTouchBar or making the whole activate function async. My understanding of Atom's current source code is that it doesn't do anything with the return value of the activate function. Looking at Atom's issues, it seems as if this may be related to atom/atom#18798, which makes it seem like this capability is still being evaluated for existing compatibility before it is implemented.

The solution that I settled on as a temporary measure for myself was to remove the conditional loading for the touch-bar-manager script and add the file to the primary imports at the top, which is essentially the first option from the original post.

thatcomputerguy0101

comment created time in 7 days

fork hanzz/eln-periodic

Periodic pipeline for ELN

fork in 8 days

startedGutek/fallacies-of-distributed-computing

started time in 8 days

starteddanilowoz/I-don-t-know-how-to-name-my-function

started time in 8 days

pull request commentsuda/tool-bar

Fix importing for touch-bar-manager

@aminya, do you have any preference regarding the remaining problem?

thatcomputerguy0101

comment created time in 8 days

startedfoxcpp/maddy

started time in 9 days

startedtimanovsky/subdir-heroku-buildpack

started time in 9 days

startedsuda/k8s-ovpn-chart

started time in 9 days

PR opened suda/tool-bar

Fix importing for touch-bar-manager

This fixes an error when importing the touch-bar-manager script where the module object was imported but the constructor function was not extracted.

However, there still exists a problem where provideToolBar can be called before useTouchBar returns, so something has to be done about that. One option to fix this is reverting the conditional loading of touch-bar-manager (the edits to tool-bar.js in d172cce). Another option would be to tie the provideToolBar function to the completion of the useTouchBar function, but I don't know how to do that without making provideToolBar async, which changes the API.

+1 -1

0 comment

1 changed file

pr created time in 10 days

fork hugovk/pip-tools

A set of tools to keep your pinned Python dependencies fresh.

fork in 10 days

fork App1905/k8s-ovpn-chart

Helm chart for a private OpenVPN server

fork in 11 days

more