profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/stickler-ci/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

Pull request review commentdimagi/commcare-hq

Data dictionary UI updates.

+# Generated by Django 2.2.24 on 2021-09-23 21:28++from django.db import migrations, models+++class Migration(migrations.Migration):++    dependencies = [+        ('data_dictionary', '0008_casepropertyallowedvalue'),+    ]++    operations = [+        migrations.AlterField(+            model_name='caseproperty',+            name='data_type',+            field=models.CharField(blank=True, choices=[('date', 'Date'), ('plain', 'Plain'), ('number', 'Number'), ('select', 'Multiple Choice'), ('barcode', 'Barcode'), ('gps', 'GPS'), ('phone_number', 'Phone Number'), ('password', 'Password'), ('', 'No Type Currently Selected')], default='', max_length=20),

E501 line too long (311 > 115 characters)

kmtracey

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentdimagi/commcare-hq

Data dictionary UI updates.

+# Generated by Django 2.2.24 on 2021-09-23 21:28++from django.db import migrations, models+++class Migration(migrations.Migration):++    dependencies = [+        ('data_dictionary', '0008_casepropertyallowedvalue'),+    ]++    operations = [+        migrations.AlterField(+            model_name='caseproperty',+            name='data_type',+            field=models.CharField(blank=True, choices=[('date', 'Date'), ('plain', 'Plain'), ('number', 'Number'), ('select', 'Multiple choice'), ('barcode', 'Barcode'), ('gps', 'GPS'), ('phone_number', 'Phone Number'), ('password', 'Password'), ('', 'No Type Currently Selected')], default='', max_length=20),

E501 line too long (311 > 115 characters)

kmtracey

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentdimagi/commcare-hq

Key/value widget updates for valid values editing

 hqDefine('hqwebapp/js/ui_elements/ui-element-key-val-list', [         this.translated_value = {};         this.edit = true;         this.modal_id = 'enumModal-' + guid;-        this.modal_title = modal_title;+        this.modal_title = modalTitle+        this.sub_title = subTitle ? '<p>' + subTitle + '</p>' : ''

Missing semicolon. (semi)

kmtracey

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentdimagi/commcare-hq

Key/value widget updates for valid values editing

 hqDefine('hqwebapp/js/ui_elements/ui-element-key-val-list', [         this.translated_value = {};         this.edit = true;         this.modal_id = 'enumModal-' + guid;-        this.modal_title = modal_title;+        this.modal_title = modalTitle+        this.sub_title = subTitle ? '<p>' + subTitle + '</p>' : ''+        this.max_display = maxDisplay

Missing semicolon. (semi)

kmtracey

comment created time in 2 days

Pull request review commentdimagi/commcare-hq

Key/value widget updates for valid values editing

 hqDefine('hqwebapp/js/ui_elements/ui-element-key-val-list', [         this.translated_value = {};         this.edit = true;         this.modal_id = 'enumModal-' + guid;-        this.modal_title = modal_title;+        this.modal_title = modalTitle

Missing semicolon. (semi)

kmtracey

comment created time in 2 days

Pull request review commentSciTools/cartopy

Add ability to specify custom bounds to Projections

 def test_projection__from_string():  def test_crs__from_pyproj_crs():     assert ccrs.CRS(pyproj.CRS("EPSG:4326")) == "EPSG:4326"+++@pytest.mark.parametrize(+    ("crs_input", "bounds", "transform_bounds", "exp_bounds", "exp_threshold"),+    [+        ("EPSG:4326", None, False, (-180.0, 180.0, -90.0, 90.0), 1.8),+        ("EPSG:4326", [-100.0, -90.0, 35.0, 45.0], False, (-100.0, -90.0, 35.0, 45.0), 0.1),+        ("EPSG:4326", [-100.0, -90.0, 35.0, 45.0], True, (-100.0, -90.0, 35.0, 45.0), 0.1),+        ("EPSG:6932", [-40000., 40000., -40000., 40000.], False, (-40000., 40000., -40000., 40000.), 800.0),+        ("EPSG:6932", [20.0, 25.0, -85.0, -78.0], True,+         (190942.4609561831, 565329.6096711607, 505972.06807129766, 1257011.612161974), 3743.871487149776),+        # Meteosat Second Generation (MSG) - SEVIRI - Flipped Geostationary+        ({'proj': 'geos', 'lon_0': 0.0, 'a': 6378169.00, 'b': 6356583.80, 'h': 35785831.00, 'units': 'm'},+         [5500000, -5500000, -5500000, 5500000], False, (5500000, -5500000, -5500000, 5500000), 110000.0),+        ({'proj': 'geos', 'lon_0': 0.0, 'a': 6378169.00, 'b': 6356583.80, 'h': 35785831.00, 'units': 'm'},+         [-10.0, 10.0, -10.0, 10.0], True,+         (-1084697.7494802547, 1084697.7494802547, -1093480.6233566382, 1093480.6233566382), 21693.954989605096),

E501 line too long (113 > 79 characters)

djhoese

comment created time in 2 days

Pull request review commentSciTools/cartopy

Add ability to specify custom bounds to Projections

 def test_projection__from_string():  def test_crs__from_pyproj_crs():     assert ccrs.CRS(pyproj.CRS("EPSG:4326")) == "EPSG:4326"+++@pytest.mark.parametrize(+    ("crs_input", "bounds", "transform_bounds", "exp_bounds", "exp_threshold"),+    [+        ("EPSG:4326", None, False, (-180.0, 180.0, -90.0, 90.0), 1.8),+        ("EPSG:4326", [-100.0, -90.0, 35.0, 45.0], False, (-100.0, -90.0, 35.0, 45.0), 0.1),+        ("EPSG:4326", [-100.0, -90.0, 35.0, 45.0], True, (-100.0, -90.0, 35.0, 45.0), 0.1),+        ("EPSG:6932", [-40000., 40000., -40000., 40000.], False, (-40000., 40000., -40000., 40000.), 800.0),+        ("EPSG:6932", [20.0, 25.0, -85.0, -78.0], True,+         (190942.4609561831, 565329.6096711607, 505972.06807129766, 1257011.612161974), 3743.871487149776),+        # Meteosat Second Generation (MSG) - SEVIRI - Flipped Geostationary+        ({'proj': 'geos', 'lon_0': 0.0, 'a': 6378169.00, 'b': 6356583.80, 'h': 35785831.00, 'units': 'm'},+         [5500000, -5500000, -5500000, 5500000], False, (5500000, -5500000, -5500000, 5500000), 110000.0),+        ({'proj': 'geos', 'lon_0': 0.0, 'a': 6378169.00, 'b': 6356583.80, 'h': 35785831.00, 'units': 'm'},

E501 line too long (106 > 79 characters)

djhoese

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentSciTools/cartopy

Add ability to specify custom bounds to Projections

 def test_projection__from_string():  def test_crs__from_pyproj_crs():     assert ccrs.CRS(pyproj.CRS("EPSG:4326")) == "EPSG:4326"+++@pytest.mark.parametrize(+    ("crs_input", "bounds", "transform_bounds", "exp_bounds", "exp_threshold"),+    [+        ("EPSG:4326", None, False, (-180.0, 180.0, -90.0, 90.0), 1.8),+        ("EPSG:4326", [-100.0, -90.0, 35.0, 45.0], False, (-100.0, -90.0, 35.0, 45.0), 0.1),+        ("EPSG:4326", [-100.0, -90.0, 35.0, 45.0], True, (-100.0, -90.0, 35.0, 45.0), 0.1),+        ("EPSG:6932", [-40000., 40000., -40000., 40000.], False, (-40000., 40000., -40000., 40000.), 800.0),+        ("EPSG:6932", [20.0, 25.0, -85.0, -78.0], True,+         (190942.4609561831, 565329.6096711607, 505972.06807129766, 1257011.612161974), 3743.871487149776),+        # Meteosat Second Generation (MSG) - SEVIRI - Flipped Geostationary+        ({'proj': 'geos', 'lon_0': 0.0, 'a': 6378169.00, 'b': 6356583.80, 'h': 35785831.00, 'units': 'm'},+         [5500000, -5500000, -5500000, 5500000], False, (5500000, -5500000, -5500000, 5500000), 110000.0),

E501 line too long (106 > 79 characters)

djhoese

comment created time in 2 days

Pull request review commentSciTools/cartopy

Add ability to specify custom bounds to Projections

 def test_projection__from_string():  def test_crs__from_pyproj_crs():     assert ccrs.CRS(pyproj.CRS("EPSG:4326")) == "EPSG:4326"+++@pytest.mark.parametrize(+    ("crs_input", "bounds", "transform_bounds", "exp_bounds", "exp_threshold"),+    [+        ("EPSG:4326", None, False, (-180.0, 180.0, -90.0, 90.0), 1.8),+        ("EPSG:4326", [-100.0, -90.0, 35.0, 45.0], False, (-100.0, -90.0, 35.0, 45.0), 0.1),+        ("EPSG:4326", [-100.0, -90.0, 35.0, 45.0], True, (-100.0, -90.0, 35.0, 45.0), 0.1),+        ("EPSG:6932", [-40000., 40000., -40000., 40000.], False, (-40000., 40000., -40000., 40000.), 800.0),+        ("EPSG:6932", [20.0, 25.0, -85.0, -78.0], True,+         (190942.4609561831, 565329.6096711607, 505972.06807129766, 1257011.612161974), 3743.871487149776),+        # Meteosat Second Generation (MSG) - SEVIRI - Flipped Geostationary+        ({'proj': 'geos', 'lon_0': 0.0, 'a': 6378169.00, 'b': 6356583.80, 'h': 35785831.00, 'units': 'm'},+         [5500000, -5500000, -5500000, 5500000], False, (5500000, -5500000, -5500000, 5500000), 110000.0),+    ]+)+def test_projection_with_bounds(crs_input, bounds, transform_bounds, exp_bounds, exp_threshold):+    pcrs = pyproj.CRS.from_user_input(crs_input)+    crs = ccrs.Projection(pcrs, bounds=bounds, transform_bounds=transform_bounds)

E501 line too long (81 > 79 characters)

djhoese

comment created time in 2 days

Pull request review commentSciTools/cartopy

Add ability to specify custom bounds to Projections

 def test_projection__from_string():  def test_crs__from_pyproj_crs():     assert ccrs.CRS(pyproj.CRS("EPSG:4326")) == "EPSG:4326"+++@pytest.mark.parametrize(+    ("crs_input", "bounds", "transform_bounds", "exp_bounds", "exp_threshold"),+    [+        ("EPSG:4326", None, False, (-180.0, 180.0, -90.0, 90.0), 1.8),+        ("EPSG:4326", [-100.0, -90.0, 35.0, 45.0], False, (-100.0, -90.0, 35.0, 45.0), 0.1),+        ("EPSG:4326", [-100.0, -90.0, 35.0, 45.0], True, (-100.0, -90.0, 35.0, 45.0), 0.1),+        ("EPSG:6932", [-40000., 40000., -40000., 40000.], False, (-40000., 40000., -40000., 40000.), 800.0),+        ("EPSG:6932", [20.0, 25.0, -85.0, -78.0], True,+         (190942.4609561831, 565329.6096711607, 505972.06807129766, 1257011.612161974), 3743.871487149776),+        # Meteosat Second Generation (MSG) - SEVIRI - Flipped Geostationary+        ({'proj': 'geos', 'lon_0': 0.0, 'a': 6378169.00, 'b': 6356583.80, 'h': 35785831.00, 'units': 'm'},

E501 line too long (106 > 79 characters)

djhoese

comment created time in 2 days

Pull request review commentSciTools/cartopy

Add ability to specify custom bounds to Projections

 def test_projection__from_string():  def test_crs__from_pyproj_crs():     assert ccrs.CRS(pyproj.CRS("EPSG:4326")) == "EPSG:4326"+++@pytest.mark.parametrize(+    ("crs_input", "bounds", "transform_bounds", "exp_bounds", "exp_threshold"),+    [+        ("EPSG:4326", None, False, (-180.0, 180.0, -90.0, 90.0), 1.8),+        ("EPSG:4326", [-100.0, -90.0, 35.0, 45.0], False, (-100.0, -90.0, 35.0, 45.0), 0.1),+        ("EPSG:4326", [-100.0, -90.0, 35.0, 45.0], True, (-100.0, -90.0, 35.0, 45.0), 0.1),+        ("EPSG:6932", [-40000., 40000., -40000., 40000.], False, (-40000., 40000., -40000., 40000.), 800.0),

E501 line too long (108 > 79 characters)

djhoese

comment created time in 2 days

Pull request review commentSciTools/cartopy

Add ability to specify custom bounds to Projections

 def test_projection__from_string():  def test_crs__from_pyproj_crs():     assert ccrs.CRS(pyproj.CRS("EPSG:4326")) == "EPSG:4326"+++@pytest.mark.parametrize(+    ("crs_input", "bounds", "transform_bounds", "exp_bounds", "exp_threshold"),+    [+        ("EPSG:4326", None, False, (-180.0, 180.0, -90.0, 90.0), 1.8),+        ("EPSG:4326", [-100.0, -90.0, 35.0, 45.0], False, (-100.0, -90.0, 35.0, 45.0), 0.1),

E501 line too long (92 > 79 characters)

djhoese

comment created time in 2 days

Pull request review commentSciTools/cartopy

Add ability to specify custom bounds to Projections

 def test_projection__from_string():  def test_crs__from_pyproj_crs():     assert ccrs.CRS(pyproj.CRS("EPSG:4326")) == "EPSG:4326"+++@pytest.mark.parametrize(+    ("crs_input", "bounds", "transform_bounds", "exp_bounds", "exp_threshold"),+    [+        ("EPSG:4326", None, False, (-180.0, 180.0, -90.0, 90.0), 1.8),+        ("EPSG:4326", [-100.0, -90.0, 35.0, 45.0], False, (-100.0, -90.0, 35.0, 45.0), 0.1),+        ("EPSG:4326", [-100.0, -90.0, 35.0, 45.0], True, (-100.0, -90.0, 35.0, 45.0), 0.1),

E501 line too long (91 > 79 characters)

djhoese

comment created time in 2 days

Pull request review commentSciTools/cartopy

Add ability to specify custom bounds to Projections

 def test_projection__from_string():  def test_crs__from_pyproj_crs():     assert ccrs.CRS(pyproj.CRS("EPSG:4326")) == "EPSG:4326"+++@pytest.mark.parametrize(+    ("crs_input", "bounds", "transform_bounds", "exp_bounds", "exp_threshold"),+    [+        ("EPSG:4326", None, False, (-180.0, 180.0, -90.0, 90.0), 1.8),+        ("EPSG:4326", [-100.0, -90.0, 35.0, 45.0], False, (-100.0, -90.0, 35.0, 45.0), 0.1),+        ("EPSG:4326", [-100.0, -90.0, 35.0, 45.0], True, (-100.0, -90.0, 35.0, 45.0), 0.1),+        ("EPSG:6932", [-40000., 40000., -40000., 40000.], False, (-40000., 40000., -40000., 40000.), 800.0),+        ("EPSG:6932", [20.0, 25.0, -85.0, -78.0], True,+         (190942.4609561831, 565329.6096711607, 505972.06807129766, 1257011.612161974), 3743.871487149776),+        # Meteosat Second Generation (MSG) - SEVIRI - Flipped Geostationary+        ({'proj': 'geos', 'lon_0': 0.0, 'a': 6378169.00, 'b': 6356583.80, 'h': 35785831.00, 'units': 'm'},+         [5500000, -5500000, -5500000, 5500000], False, (5500000, -5500000, -5500000, 5500000), 110000.0),+    ]+)+def test_projection_with_bounds(crs_input, bounds, transform_bounds, exp_bounds, exp_threshold):

E501 line too long (96 > 79 characters)

djhoese

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentSciTools/cartopy

Add ability to specify custom bounds to Projections

 def test_projection__from_string():  def test_crs__from_pyproj_crs():     assert ccrs.CRS(pyproj.CRS("EPSG:4326")) == "EPSG:4326"+++@pytest.mark.parametrize(+    ("crs_input", "bounds", "transform_bounds", "exp_bounds", "exp_threshold"),+    [+        ("EPSG:4326", None, False, (-180.0, 180.0, -90.0, 90.0), 1.8),+        ("EPSG:4326", [-100.0, -90.0, 35.0, 45.0], False, (-100.0, -90.0, 35.0, 45.0), 0.1),+        ("EPSG:4326", [-100.0, -90.0, 35.0, 45.0], True, (-100.0, -90.0, 35.0, 45.0), 0.1),+        ("EPSG:6932", [-40000., 40000., -40000., 40000.], False, (-40000., 40000., -40000., 40000.), 800.0),+        ("EPSG:6932", [20.0, 25.0, -85.0, -78.0], True,+         (190942.4609561831, 565329.6096711607, 505972.06807129766, 1257011.612161974), 3743.871487149776),

E501 line too long (107 > 79 characters)

djhoese

comment created time in 2 days

Pull request review commentdimagi/commcare-hq

sort enterprise users by column

 hqDefine("users/js/enterprise_users", [             self.toggleDeactivated();         }); +        self.sortBy = ko.observable('');++        self.ascending = ko.observable(false);++        self.sortByColumn = function (data, event) {+            var el = event.target;+            var column = el.getAttribute('name');+            var webUsers = [];+            var mobileWorkersMap = {};+            var allSortedUsers = [];+            // Change target el icon depending on self.ascending() and revert all other icons+            var resetColumnIcons = function (ascending) {+                var allColumns = $('[id=sort-icon]');+                allColumns.removeClass('glyphicon-sort-by-attributes glyphicon-sort-by-attributes-alt');+                allColumns.addClass('glyphicon-sort');+                $(el).addClass(ascending ? 'glyphicon-sort-by-attributes' : 'glyphicon-sort-by-attributes-alt');+            };++            var columnSort = function (userArr, ascending) {+                resetColumnIcons(ascending);+                userArr.sort(function (a, b) {+                    if (!a[column]) {+                        return 1+                    };

Unnecessary semicolon. (no-extra-semi)

Robert-Costello

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentdimagi/commcare-hq

sort enterprise users by column

 hqDefine("users/js/enterprise_users", [             self.toggleDeactivated();         }); +        self.sortBy = ko.observable('');++        self.ascending = ko.observable(false);++        self.sortByColumn = function (data, event) {+            var el = event.target;+            var column = el.getAttribute('name');+            var webUsers = [];+            var mobileWorkersMap = {};+            var allSortedUsers = [];+            // Change target el icon depending on self.ascending() and revert all other icons+            var resetColumnIcons = function (ascending) {+                var allColumns = $('[id=sort-icon]');+                allColumns.removeClass('glyphicon-sort-by-attributes glyphicon-sort-by-attributes-alt');+                allColumns.addClass('glyphicon-sort');+                $(el).addClass(ascending ? 'glyphicon-sort-by-attributes' : 'glyphicon-sort-by-attributes-alt');+            };++            var columnSort = function (userArr, ascending) {+                resetColumnIcons(ascending);+                userArr.sort(function (a, b) {+                    if (!a[column]) {+                        return 1

Missing semicolon. (semi)

Robert-Costello

comment created time in 2 days

Pull request review commentdimagi/commcare-hq

sort enterprise users by column

 hqDefine("users/js/enterprise_users", [             self.toggleDeactivated();         }); +        self.sortBy = ko.observable('');++        self.ascending = ko.observable(false);++        self.sortByColumn = function (data, event) {+            var el = event.target;+            var column = el.getAttribute('name');+            var webUsers = [];+            var mobileWorkersMap = {};+            var allSortedUsers = [];+            // Change target el icon depending on self.ascending() and revert all other icons+            var resetColumnIcons = function (ascending) {+                var allColumns = $('[id=sort-icon]');+                allColumns.removeClass('glyphicon-sort-by-attributes glyphicon-sort-by-attributes-alt');+                allColumns.addClass('glyphicon-sort');+                $(el).addClass(ascending ? 'glyphicon-sort-by-attributes' : 'glyphicon-sort-by-attributes-alt')+            }++            var columnSort = function (userArr, ascending) {+                resetColumnIcons(ascending);+                userArr.sort(function (a, b) {+                    if (!a[column]) return 1;+                    if (!b[column]) return -1;+                    return ascending ? a[column].localeCompare(b[column]) : b[column].localeCompare(a[column]);+                });++                return userArr;+            }

Missing semicolon. (semi)

Robert-Costello

comment created time in 2 days

Pull request review commentdimagi/commcare-hq

sort enterprise users by column

 hqDefine("users/js/enterprise_users", [             self.toggleDeactivated();         }); +        self.sortBy = ko.observable('');++        self.ascending = ko.observable(false);++        self.sortByColumn = function (data, event) {+            var el = event.target;+            var column = el.getAttribute('name');+            var webUsers = [];+            var mobileWorkersMap = {};+            var allSortedUsers = [];+            // Change target el icon depending on self.ascending() and revert all other icons+            var resetColumnIcons = function (ascending) {+                var allColumns = $('[id=sort-icon]');+                allColumns.removeClass('glyphicon-sort-by-attributes glyphicon-sort-by-attributes-alt');+                allColumns.addClass('glyphicon-sort');+                $(el).addClass(ascending ? 'glyphicon-sort-by-attributes' : 'glyphicon-sort-by-attributes-alt')+            }++            var columnSort = function (userArr, ascending) {+                resetColumnIcons(ascending);+                userArr.sort(function (a, b) {+                    if (!a[column]) return 1;+                    if (!b[column]) return -1;

Expected { after 'if' condition. (curly)

Robert-Costello

comment created time in 2 days

Pull request review commentdimagi/commcare-hq

sort enterprise users by column

 hqDefine("users/js/enterprise_users", [             self.toggleDeactivated();         }); +        self.sortBy = ko.observable('');++        self.ascending = ko.observable(false);++        self.sortByColumn = function (data, event) {+            var el = event.target;+            var column = el.getAttribute('name');+            var webUsers = [];+            var mobileWorkersMap = {};+            var allSortedUsers = [];+            // Change target el icon depending on self.ascending() and revert all other icons+            var resetColumnIcons = function (ascending) {+                var allColumns = $('[id=sort-icon]');+                allColumns.removeClass('glyphicon-sort-by-attributes glyphicon-sort-by-attributes-alt');+                allColumns.addClass('glyphicon-sort');+                $(el).addClass(ascending ? 'glyphicon-sort-by-attributes' : 'glyphicon-sort-by-attributes-alt')+            }

Missing semicolon. (semi)

Robert-Costello

comment created time in 2 days

Pull request review commentdimagi/commcare-hq

sort enterprise users by column

 hqDefine("users/js/enterprise_users", [             self.toggleDeactivated();         }); +        self.sortBy = ko.observable('');++        self.ascending = ko.observable(false);++        self.sortByColumn = function (data, event) {+            var el = event.target;+            var column = el.getAttribute('name');+            var webUsers = [];+            var mobileWorkersMap = {};+            var allSortedUsers = [];+            // Change target el icon depending on self.ascending() and revert all other icons+            var resetColumnIcons = function (ascending) {+                var allColumns = $('[id=sort-icon]');+                allColumns.removeClass('glyphicon-sort-by-attributes glyphicon-sort-by-attributes-alt');+                allColumns.addClass('glyphicon-sort');+                $(el).addClass(ascending ? 'glyphicon-sort-by-attributes' : 'glyphicon-sort-by-attributes-alt')

Missing semicolon. (semi)

Robert-Costello

comment created time in 2 days

Pull request review commentdimagi/commcare-hq

sort enterprise users by column

 hqDefine("users/js/enterprise_users", [             self.toggleDeactivated();         }); +        self.sortBy = ko.observable('');++        self.ascending = ko.observable(false);++        self.sortByColumn = function (data, event) {+            var el = event.target;+            var column = el.getAttribute('name');+            var webUsers = [];+            var mobileWorkersMap = {};+            var allSortedUsers = [];+            // Change target el icon depending on self.ascending() and revert all other icons+            var resetColumnIcons = function (ascending) {+                var allColumns = $('[id=sort-icon]');+                allColumns.removeClass('glyphicon-sort-by-attributes glyphicon-sort-by-attributes-alt');+                allColumns.addClass('glyphicon-sort');+                $(el).addClass(ascending ? 'glyphicon-sort-by-attributes' : 'glyphicon-sort-by-attributes-alt')+            }++            var columnSort = function (userArr, ascending) {+                resetColumnIcons(ascending);+                userArr.sort(function (a, b) {+                    if (!a[column]) return 1;

Expected { after 'if' condition. (curly)

Robert-Costello

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent