profile
viewpoint
Stefan Buck stefanbuck Brandwatch Stuttgart, Germany stefanbuck.com JavaScript dev @BrandwatchLtd. Creator of @OctoLinker

stefanbuck/awesome-browser-extensions-for-github 1986

A collection of awesome browser extensions for GitHub.

panacodalabs/D8 84

D8 - The next generation Date object for JavaScript

stefanbuck/Archive-Octo-Linker-Core 31

Links dependencies in a package or bower file to their GitHub page

mujo-code/puppeteer-headful 24

Github Action for puppeteer that is headful.

jprichardson/npm-latest 12

Quickly find the latest version of a package in npm.

panacodalabs/The-M-Docs 10

Documentation for The-M-Project

hano/csscomb-brackets 8

CSScomb Brackets plugin

stefanbuck/actionhero-auth-example 5

Authentication example with actionhero

issue closeddenoland/deno

xeval example doesn't work anymore

I just updated deno from version 1.0.1 to 1.4.2 and this seems to break the xeval example.

Before

$ deno --version
deno 1.0.1
v8 8.4.300
typescript 3.9.2

$ cat file.txt | deno run https://deno.land/std/examples/xeval.ts -- "console.log($, '🐈')"
foo 🐈
bar 🐈

After

$ deno --version
deno 1.4.2
v8 8.7.75
typescript 4.0.3

$ cat file.txt | deno run https://deno.land/std/examples/xeval.ts -- "console.log($, '🐈')"

Check https://deno.land/std/examples/xeval.ts
error: TS2345 [ERROR]: Argument of type 'string | URL' is not assignable to parameter of type 'string'.
  Type 'URL' is not assignable to type 'string'.
  return new URL(url).pathname
                 ~~~
    at https://deno.land/std/path/win32.ts:911:18

TS2345 [ERROR]: Argument of type 'string | URL' is not assignable to parameter of type 'string'.
  Type 'URL' is not assignable to type 'string'.
  return new URL(url).pathname;
                 ~~~
    at https://deno.land/std/path/posix.ts:433:18

Found 2 errors.

I also tried to run the example listed in the xeval.ts file, but this fails with the same error.

https://github.com/denoland/deno/blob/04f05d0d9db4f5e55b2f0205ba2e5ab1c320dbc6/std/examples/xeval.ts#L16

Please let me know if you need any further information.

closed time in 5 hours

stefanbuck

issue commentdenoland/deno

xeval example doesn't work anymore

Oh sweet, thanks for this lightning fast response. Should the example be updated or is this common sense in deno land?

stefanbuck

comment created time in 5 hours

issue openeddenoland/deno

xeval example doesn't work anymore

I just updated deno from version 1.0.1 to 1.4.2 and this seems to break the xeval example.

Before

$ deno --version
deno 1.0.1
v8 8.4.300
typescript 3.9.2

$ cat file.txt | deno run https://deno.land/std/examples/xeval.ts -- "console.log($, '🐈')"
foo 🐈
bar 🐈

After

$ deno --version
deno 1.4.2
v8 8.7.75
typescript 4.0.3

$ cat file.txt | deno run https://deno.land/std/examples/xeval.ts -- "console.log($, '🐈')"

Check https://deno.land/std/examples/xeval.ts
error: TS2345 [ERROR]: Argument of type 'string | URL' is not assignable to parameter of type 'string'.
  Type 'URL' is not assignable to type 'string'.
  return new URL(url).pathname
                 ~~~
    at https://deno.land/std/path/win32.ts:911:18

TS2345 [ERROR]: Argument of type 'string | URL' is not assignable to parameter of type 'string'.
  Type 'URL' is not assignable to type 'string'.
  return new URL(url).pathname;
                 ~~~
    at https://deno.land/std/path/posix.ts:433:18

Found 2 errors.

I also tried to run the example listed in the xeval.ts file, but this fails with the same error.

https://github.com/denoland/deno/blob/04f05d0d9db4f5e55b2f0205ba2e5ab1c320dbc6/std/examples/xeval.ts#L16

Please let me know if you need any further information.

created time in 5 hours

push eventOctoLinker/OctoLinker

Brian Surowiec

commit sha 492b64b4dc07640ddc96aebc5980fdcdc9e68272

Exclude urls from css imports (#1036)

view details

push time in a day

PR merged OctoLinker/OctoLinker

Exclude urls from css imports

Pull Request Badge<!-- PR-BADGE: PLEASE DO NOT REMOVE THIS COMMENT -->

<!-- Thanks for filing a pull request!

Please look at the following checklist to ensure that your PR can be accepted quickly: -->

Checklist:

  • [ ] If this PR is a new feature, please provide at least one example link
  • [x] Make sure all of the significant new logic is covered by tests

This is another thing I found while working on #905. I was trying to exclude things like url("https://...") so we didn't do needless lookups and it turns out the same thing happens with css imports. I'm sure this exists for LESS and SASS as well but didn't dig into those yet.

I'm wondering if there's a better way to handle this. Any ideas?

You can see an example of this here:

  • https://github.com/meninaveneno/ROCK-STORY/blob/f0c8d332517c70161420da49feeaf7c786d7fb40/ROCKing.css
+12 -2

0 comment

2 changed files

xt0rted

pr closed time in a day

PullRequestReviewEvent

Pull request review commentOctoLinker/OctoLinker

Exclude urls from css imports

 export const CSS_IMPORT = regex`   @import   \s   ((url|URL)\()?-  ${captureQuotedWord}+  ['"]                # beginning quote+  (?<$1>+    (?!https?:\/\/)   # exclude urls

Using a negative look ahead, is what I ended up doing for #1033 as well.

xt0rted

comment created time in a day

PullRequestReviewEvent

push eventstefanbuck/stefanbuck

Stefan Buck

commit sha b5ed5c6a223e2f26194def89e5c97fdfcfd856ae

Update README.md

view details

push time in a day

push eventstefanbuck/stefanbuck

Stefan Buck

commit sha 28c8e13708697feda55319cdcb2131ddac03f20a

Update README.md

view details

push time in a day

push eventstefanbuck/stefanbuck

Stefan Buck

commit sha 18d1ee084fbbda95cf1c5a70b74a785874c8d5fe

Update README.md

view details

push time in a day

push eventstefanbuck/stefanbuck

Stefan Buck

commit sha d4419b5be3ae1ca001351734ce6cfba247b41068

Update README.md

view details

push time in a day

push eventstefanbuck/stefanbuck

Stefan Buck

commit sha 41a4528324c4c994804a42bf2a869dde1be4d3a4

Update README.md

view details

push time in a day

push eventstefanbuck/stefanbuck

Stefan Buck

commit sha 7a137b21e81b8eca759c42c9b68f054684c71fb0

Update README.md

view details

push time in a day

push eventstefanbuck/stefanbuck

Stefan Buck

commit sha 06cda433fd1e58b5ec0ebc42e36de49b6347c2b9

Update README.md

view details

push time in a day

push eventstefanbuck/stefanbuck

Stefan Buck

commit sha eea08fb997cee711f876584c9f81fdc05f35ac2e

Update README.md

view details

push time in a day

push eventstefanbuck/stefanbuck

Stefan Buck

commit sha dc650366c7f1bb71b641f0117002eb8fa8ab7acf

Update README.md

view details

push time in a day

issue commentOctoLinker/OctoLinker

Support for R

I've been wondering what those classes are for.

You never asked 😉 I'm glad that this issue is spreading some knowledge. @xt0rted do you see value in having a better documentation of OctoLinker's core?

edavidaja

comment created time in a day

push eventstefanbuck/inihccuz

Deployment Bot (from Travis CI)

commit sha 503b306b666b7e733065b73d6c7a26fd2101c52c

Deploy stefanbuck/inihccuz to github.com/stefanbuck/inihccuz.git:master

view details

push time in a day

push eventstefanbuck/inihccuz

Deployment Bot (from Travis CI)

commit sha 13c45c8fd90dfea95146d41f1f945384b5fe1a73

Deploy stefanbuck/inihccuz to github.com/stefanbuck/inihccuz.git:master

view details

push time in a day

push eventstefanbuck/inihccuz

Deployment Bot (from Travis CI)

commit sha 384a5b3129af49f32ece4241f8ff716e4c47f3cd

Deploy stefanbuck/inihccuz to github.com/stefanbuck/inihccuz.git:master

view details

push time in a day

issue openedzeke/semantic-pull-requests

Improve error message

There is one error message which gets cut off in the status check and I wonder if there is something we can do about it.

Screenshot 2020-09-28 at 12 41 12

A few ideas:

  1. Come up with a shorter version
  2. Introduce error codes which allows us to document the error in more detail in the README of this repository.
  3. Add a comment with the error to the pull request. This comment should go away automatically if the issue has been addressed.

created time in 2 days

push eventstefanbuck/inihccuz

Deployment Bot (from Travis CI)

commit sha e461862e61727628fa8d5db6a8bd21ae725f0dd4

Deploy stefanbuck/inihccuz to github.com/stefanbuck/inihccuz.git:master

view details

push time in 2 days

push eventstefanbuck/inihccuz

Deployment Bot (from Travis CI)

commit sha 940b04835b7586b8d5060229453a72f0ebf4de8b

Deploy stefanbuck/inihccuz to github.com/stefanbuck/inihccuz.git:master

view details

push time in 2 days

push eventstefanbuck/inihccuz

Deployment Bot (from Travis CI)

commit sha 9131799c210aa95166fb7fabc346bd1ff98fa482

Deploy stefanbuck/inihccuz to github.com/stefanbuck/inihccuz.git:master

view details

push time in 2 days

push eventstefanbuck/inihccuz

Deployment Bot (from Travis CI)

commit sha 4074f4869e3fbaa8f3433b83cc92954c41a6571d

Deploy stefanbuck/inihccuz to github.com/stefanbuck/inihccuz.git:master

view details

push time in 2 days

push eventstefanbuck/inihccuz

Deployment Bot (from Travis CI)

commit sha 9c5376c1743e4e610faaa65ec79b9caf859f8089

Deploy stefanbuck/inihccuz to github.com/stefanbuck/inihccuz.git:master

view details

push time in 2 days

push eventstefanbuck/inihccuz

Deployment Bot (from Travis CI)

commit sha 21c1cdedf7f11f47d32bd5f157ef813ce547084d

Deploy stefanbuck/inihccuz to github.com/stefanbuck/inihccuz.git:master

view details

push time in 2 days

push eventstefanbuck/inihccuz

Deployment Bot (from Travis CI)

commit sha 0fe84fe2e756aa290c9287e2ec21a424b0fe5b72

Deploy stefanbuck/inihccuz to github.com/stefanbuck/inihccuz.git:master

view details

push time in 2 days

issue commentOctoLinker/OctoLinker

Support for R

As promised here are the steps to get support for R packages working.

1. Define regular expression

OctoLinker is using regular expressions to find code snippets in the DOM. All regular expressions are defined in helper-grammar-regex-collection. The file should be self-describing and it's just a matter of adding a new export.

To ensure the regular expression is working as expected, test cases can be added in the helper-grammar-regex-collection test-file. This file contains many test cases already.

2. Create a new plugin

This is best done by looking at an existing plugin for example the rust plugin. The public API of a plugin consists of three methods resolve, getPattern and getLinkRegexes.

The regular expression you defined earlier, needs to be returned by getLinkRegexes. This can be an array if you have more than one regular expression.

We use the return value from getPattern to figure out when to invoke a plugin. The pathRegexes is a regular expression which either matches file suffixes or entire file names. Feel free to set githubClasses to an empty array for now. This is being used to invoke plugins in Markdown files or issue comments if a code snippet is added.

The resolve method is called with the extracted value. We have a bunch of different resolvers, but in your case all you need is the liveResolverQuery. This is just a wrapper to expose a simple API when using OctoLinker API.

resolve(path, [target]) {
  return liveResolverQuery({ type: 'cran', target });
},

3. Register plugin

Add the new plugin to https://github.com/OctoLinker/OctoLinker/blob/3692335dbc3e348b5a2a1f59e271f0817a4ca859/packages/core/load-plugins.js

4. Add E2E tests

Please follow the E2E test guide to get an understanding how we use E2E test.

That's it. Once I added cran support to the OctoLinker API, your PR should turn green.

I hope this all make sense. Please let me know if you have any further questions.

edavidaja

comment created time in 2 days

issue commentOctoLinker/api

Add support for R packages (CRAN)

Ahh I see, that should simplify things a lot. I'm on my phone right now so hard to do proper research on this, but looks like URLs set in the URL field are separated by comma https://crandb.r-pkg.org/usethis. The current implementation does not support such a custom format.

I think it makes sense to split the work between you and me. I can look into the API side of things later this week. Once I'm back home tonight, I'll point you to the steps required to make the browser extension side happen.

stefanbuck

comment created time in 2 days

push eventstefanbuck/inihccuz

Deployment Bot (from Travis CI)

commit sha bc6844b47f64e1995fcb6187bbee62ccdbe1a340

Deploy stefanbuck/inihccuz to github.com/stefanbuck/inihccuz.git:master

view details

push time in 2 days

push eventstefanbuck/inihccuz

Deployment Bot (from Travis CI)

commit sha 7be5506687a4c6562e3e22fcb92e0a4d12e3c240

Deploy stefanbuck/inihccuz to github.com/stefanbuck/inihccuz.git:master

view details

push time in 2 days

push eventstefanbuck/inihccuz

Deployment Bot (from Travis CI)

commit sha f4d59659647e0c3b719df1d6588c59fd93dbdf86

Deploy stefanbuck/inihccuz to github.com/stefanbuck/inihccuz.git:master

view details

push time in 2 days

issue commentOctoLinker/api

Add support for R packages (CRAN)

https://www.r-pkg.org is using CouchDB and I wonder if this is a service we can / should rely on.

stefanbuck

comment created time in 2 days

starteddavestewart/todo-emojis

started time in 3 days

issue commentOctoLinker/OctoLinker

Support for R

Thanks for this very detailed explanation. Looks like you figured out the internals how OctoLinker works yourself already. I more than happy to guide you to this part in more detail, but first we need to make a change in another service. The OctoLinker API is a service responsible to resolve external packages. Adding support for a new package registry is super easy if we can call an API endpoint that returns a JSON document. For example, npm returns such a JSON document for react. We use XPath to find urls in the specified fields. The configuration for npm and other registries can be found in the config.json file. If CRAN doesn't have such a JSON endpoint it's a little bit more work, but overall still simple.

I opened an issue https://github.com/OctoLinker/api/issues/252 so we can continue in more detail there.

Once this is done, I'll walk you through the other changes required to land this feature.

edavidaja

comment created time in 3 days

issue openedOctoLinker/api

Add support for R packages (CRAN)

In https://github.com/OctoLinker/OctoLinker/issues/1037 @edavidaja offered help to get OctoLinker work with R.

R packages are hosted by Comprehensive R Archive Network (CRAN). A web version of each package manifest is available at the link: https://cran.r-project.org/package={package} (e.g. https://cran.r-project.org/package=flextable)

Packages with web pages list them in the URL field of the DESCRIPTION file; however, not all packages have a webpage. There is a GitHub Mirror of CRAN packages at https://github.com/cran, which has the source code, including the manifest, for any package on CRAN.

First we need to figure out wether or not CRAN has an endpoint that returns a JSON document so we can leverage our universal config which makes adding new registry support super easy.

So, does CRAN have such an endpoint @edavidaja ?

created time in 3 days

push eventstefanbuck/inihccuz

Deployment Bot (from Travis CI)

commit sha 2bab9749aee36af068990bc86c6b9106bd7bd17f

Deploy stefanbuck/inihccuz to github.com/stefanbuck/inihccuz.git:master

view details

push time in 4 days

push eventstefanbuck/inihccuz

Deployment Bot (from Travis CI)

commit sha 84cf90156f97066e0194b286287829db74eed048

Deploy stefanbuck/inihccuz to github.com/stefanbuck/inihccuz.git:master

view details

push time in 5 days

push eventstefanbuck/inihccuz

Deployment Bot (from Travis CI)

commit sha d21be4bf49ed3174ac0515cbb48dcf3ab6610d14

Deploy stefanbuck/inihccuz to github.com/stefanbuck/inihccuz.git:master

view details

push time in 5 days

issue commentredhat-developer/vscode-yaml

Latest version breaks auto-save formatting

I'm using the following .editorconfig file and saving a file auto-formats the file to 4 spaces.

[*.{yml,json}]
indent_size = 2
ekristen

comment created time in 5 days

push eventstefanbuck/action-playground

push time in 5 days

push eventstefanbuck/action-playground

Stefan Buck

commit sha 5b55bc795033e759fdea97702cf29632cc176cc3

wip

view details

push time in 5 days

push eventstefanbuck/action-playground

Stefan Buck

commit sha c55e87536a4343835de334518abd1614fccdba9e

wip

view details

push time in 5 days

push eventstefanbuck/action-playground

Stefan Buck

commit sha 3b0ee93150473f3c37938b68e7b24766438d07aa

wip

view details

push time in 5 days

push eventstefanbuck/action-playground

Stefan Buck

commit sha c15ccee63868cc3f3bf91b1f24863c0b93500b5c

wip

view details

push time in 5 days

push eventstefanbuck/action-playground

Stefan Buck

commit sha 2b3f04f62b88100060220e91ba922b8df0915761

wip

view details

push time in 5 days

push eventstefanbuck/action-playground

Stefan Buck

commit sha bc4fd9854edb0b3fdaa55839dc51a9d827c58aab

wip

view details

push time in 5 days

PR opened stefanbuck/action-playground

wip
+11 -6

0 comment

1 changed file

pr created time in 5 days

create barnchstefanbuck/action-playground

branch : test

created branch time in 5 days

push eventstefanbuck/inihccuz

Deployment Bot (from Travis CI)

commit sha 4a598527c50d2aea461ea93392b135f0ac1f72ed

Deploy stefanbuck/inihccuz to github.com/stefanbuck/inihccuz.git:master

view details

push time in 5 days

push eventstefanbuck/inihccuz

Deployment Bot (from Travis CI)

commit sha 0d7761f5e8383876dda8b0e0cdba10e82ed40641

Deploy stefanbuck/inihccuz to github.com/stefanbuck/inihccuz.git:master

view details

push time in 5 days

push eventstefanbuck/inihccuz

Deployment Bot (from Travis CI)

commit sha 24784eb46d44bbe11ee4657b62a3532df4941227

Deploy stefanbuck/inihccuz to github.com/stefanbuck/inihccuz.git:master

view details

push time in 5 days

push eventstefanbuck/inihccuz

Deployment Bot (from Travis CI)

commit sha 1838ec181b79e35881d386e176383ba9c9633e65

Deploy stefanbuck/inihccuz to github.com/stefanbuck/inihccuz.git:master

view details

push time in 5 days

push eventstefanbuck/inihccuz

Deployment Bot (from Travis CI)

commit sha bb2940ae8d54f39f1b6a1a0da22284e629bf0521

Deploy stefanbuck/inihccuz to github.com/stefanbuck/inihccuz.git:master

view details

push time in 5 days

Pull request review commentOctoLinker/OctoLinker

Add support for scriptcs, Cake, and FAKE

+import {+  FAKE_NUGET,+  NET_SCRIPT_FILE,+  NET_SCRIPT_NUGET,+} from '@octolinker/helper-grammar-regex-collection';+import nugetResolver from '@octolinker/resolver-nuget';+import relativeFile from '@octolinker/resolver-relative-file';++export default {+  name: 'DotNetScripting',++  resolve(path, [target]) {+    // this reference doesn't resolve to anything+    if (target === './.fake/build.fsx/intellisense.fsx') {+      return [];+    }++    return [relativeFile({ path, target }), nugetResolver({ target })];

The signature of the resolve handler is resolve(path, target, meta, regExp).

Side note: Meta defaults to an empty object and is used in the context of plugin-npm-manifest.

What I want to talk about is the fourth argument regExp which is the matching RegExp from line 29. In my PHP PR I make use of this to use different resolvers https://github.com/OctoLinker/OctoLinker/blob/87a137aa312f2a6e4b425f2e599744e2fa4f61f5/packages/plugin-php/index.js#L7-L13 maybe we can do something similar here. This allows use to be more specific and does reduce unnecessary look up in the OctoLinker API.

xt0rted

comment created time in 5 days

Pull request review commentOctoLinker/OctoLinker

Add support for scriptcs, Cake, and FAKE

+import {+  FAKE_NUGET,+  NET_SCRIPT_FILE,+  NET_SCRIPT_NUGET,+} from '@octolinker/helper-grammar-regex-collection';+import nugetResolver from '@octolinker/resolver-nuget';+import relativeFile from '@octolinker/resolver-relative-file';++export default {+  name: 'DotNetScripting',++  resolve(path, [target]) {+    // this reference doesn't resolve to anything+    if (target === './.fake/build.fsx/intellisense.fsx') {+      return [];

Just to share some insights, you can use undefined as a return value as well. Just saying, no need to change it.

xt0rted

comment created time in 5 days

Pull request review commentOctoLinker/OctoLinker

Add support for scriptcs, Cake, and FAKE

 describe('End to End tests', () => {   });    describe('single blob', () => {-    fixtures.forEach(({ url, content, lineNumber, targetUrl }) => {+    fixtures.forEach(({ url, file, content, lineNumber, targetUrl }) => {       it(`resolves ${content} to ${targetUrl}`, async () => {         if (lineNumber) {-          await executeTest(-            url,-            targetUrl,-            `#LC${lineNumber} .octolinker-link`,-          );+          try {+            await executeTest(+              url,+              targetUrl,+              `#LC${lineNumber} .octolinker-link`,+            );+          } catch (ex) {+            process.stdout.write(+              `\n::error file=${file},line=${lineNumber}::${ex.message}\n`,+            );

I think a console.log should work here too. That way you can get rid of the newline operator.

xt0rted

comment created time in 5 days

Pull request review commentOctoLinker/OctoLinker

Add support for scriptcs, Cake, and FAKE

 describe('End to End tests', () => {   });    describe('single blob', () => {-    fixtures.forEach(({ url, content, lineNumber, targetUrl }) => {+    fixtures.forEach(({ url, file, content, lineNumber, targetUrl }) => {       it(`resolves ${content} to ${targetUrl}`, async () => {         if (lineNumber) {-          await executeTest(-            url,-            targetUrl,-            `#LC${lineNumber} .octolinker-link`,-          );+          try {+            await executeTest(+              url,+              targetUrl,+              `#LC${lineNumber} .octolinker-link`,+            );+          } catch (ex) {+            process.stdout.write(+              `\n::error file=${file},line=${lineNumber}::${ex.message}\n`,+            );

😍

xt0rted

comment created time in 5 days

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentOctoLinker/OctoLinker

Add support for scriptcs, Cake, and FAKE

My other PR was failing as well for some odd reason. After rebasing it passed

xt0rted

comment created time in 5 days

push eventOctoLinker/OctoLinker

Stefan Buck

commit sha 87a137aa312f2a6e4b425f2e599744e2fa4f61f5

Add support fo " use function" statements

view details

push time in 5 days

Pull request review commentOctoLinker/OctoLinker

Add PHP manual support

   -  <link crossorigin="anonymous" media="all" integrity="sha512-InGiw0uqrfrV1EXLEoQR8zhoNQs4RhOXAZIoTEr+QaNPzbnLcqgPASwPZOSxhLC/ydy1tqek+nufQayviU4NRA==" rel="stylesheet" href="https://github.githubassets.com/assets/frameworks-c0ad6862340d6d1a2594b40111c17bf7.css" />-  <link crossorigin="anonymous" media="all" integrity="sha512-q0uE9UAtjRgctFaLFVvUGVtXC6ggCD9Qcg86uwRaLx2RdC7FIE+hPfB4YDaM8lCecPVMwsxDyvqkXI2XEKDCOA==" rel="stylesheet" href="https://github.githubassets.com/assets/site-d2ea9f95eb7121ca3a5f9571e0012f11.css" />-    <link crossorigin="anonymous" media="all" integrity="sha512-JedmoBWaUotKU3Fc6fDpBbcfTTMhoAiSb4IPTqwmqhD3pBHWUtHDyYYgVGuNwIKt08sVud5nLKZCb8DBdPvtNQ==" rel="stylesheet" href="https://github.githubassets.com/assets/github-0c16774092b1ce5288b91585e3d6617b.css" />+  <link crossorigin="anonymous" media="all" integrity="sha512-QLgu+HpQvHV00FunhsB3ueQCfgM7dkyMXKp1BrwCifVinFow2alu90jbiIbSdyn4/rXsaRo3otCqeYgmRmTCEA==" rel="stylesheet" href="https://github.githubassets.com/assets/frameworks-40b82ef87a50bc7574d05ba786c077b9.css" />

All changes made in this file are due to the fact that I added a new snipped to https://github.com/OctoLinker/testrepo/issues/2. I ran ./packages/blob-reader/scripts/update-fixtures.sh and committed only this file to keep the overall diff of this PR small. Interesting to see all the markup changes

stefanbuck

comment created time in 5 days

PullRequestReviewEvent

push eventOctoLinker/OctoLinker

Stefan Buck

commit sha cb90a852d3486b73c223cece547fbcbe8f88e521

Add xt0rted

view details

Stefan Buck

commit sha 2938dadb7c671300c65e6c59fb04ad2498ba608c

Update pr-badge.yml

view details

Brian Surowiec

commit sha 3692335dbc3e348b5a2a1f59e271f0817a4ca859

Support extensionless less imports (#1034) * Add css & less tests * Support extensionless less imports * Use single quotes & remove duplicate test

view details

Stefan Buck

commit sha 47c763b99c4926fd55cac96b71dfcafe1dc622a3

Add PHP manual support

view details

Stefan Buck

commit sha 19c6b788d2cacd5941c4dcd659d7e73ddeef9b21

Add support fo " use function" statements

view details

push time in 5 days

push eventOctoLinker/OctoLinker

push time in 5 days

push eventOctoLinker/OctoLinker

Stefan Buck

commit sha cb9f37fe17ffa4c5fe56bf466f535c57a3d82332

Add support for: use function

view details

push time in 5 days

PullRequestReviewEvent

pull request commentOctoLinker/OctoLinker

Add support for json config files

I pushed a test case to ensure links are not wrapped twice. This covers c6dd225

xt0rted

comment created time in 5 days

push eventxt0rted/OctoLinker

Stefan Buck

commit sha e16d0236fd25697bca04ae9d8c88d050b3b8b491

Add test to ensure links are not wrapped twice

view details

push time in 5 days

Pull request review commentOctoLinker/OctoLinker

Add support for scriptcs, Cake, and FAKE

+// @OctoLinkerResolve(https://www.nuget.org/packages/Cake.DotNetTool.Module)+#module nuget:?package=Cake.DotNetTool.Module&version=0.4.0++// @OctoLinkerResolve(https://www.nuget.org/packages/Cake.Coveralls)+#addin "nuget:https://api.nuget.org/v3/index.json?package=Cake.Coveralls&version=0.10.1"

This sounds similar to an issue I'm currently facing getting PHP / laravel support in.

<td>
  <span class="pl-k">use</span><span data-rgh-whitespace="space"> </span><span class="pl-v">Illuminate</span>\<span class="pl-v">Contracts</span>\<span class="pl-v">Container</span>\<span class="pl-v">Container</span>;
</td>

Yesterday, I spent two hours try to come up with a solution without luck. It's mainly a lack of support for such markup in https://github.com/padolsey/findAndReplaceDOMText which we use in the insert-link package.

I've noticed that refined-github is able to wrap the url in your case. If we find a solution we should make sure it doesn't conflict with refined-github which is a widely used extension as well.

Is this a blocker for you? Maybe best to ignore it for now and investigate into it separately.

xt0rted

comment created time in 5 days

PullRequestReviewEvent

push eventOctoLinker/OctoLinker

Brian Surowiec

commit sha 3692335dbc3e348b5a2a1f59e271f0817a4ca859

Support extensionless less imports (#1034) * Add css & less tests * Support extensionless less imports * Use single quotes & remove duplicate test

view details

push time in 5 days

PR merged OctoLinker/OctoLinker

Support extensionless less imports

Pull Request Badge<!-- PR-BADGE: PLEASE DO NOT REMOVE THIS COMMENT -->

<!-- Thanks for filing a pull request!

Please look at the following checklist to ensure that your PR can be accepted quickly: -->

Checklist:

  • [ ] If this PR is a new feature, please provide at least one example link
  • [x] Make sure all of the significant new logic is covered by tests

Found this while setting up tests for #905. This functionality is mentioned in the docs at http://lesscss.org/features/#import-atrules-feature.

The only issue with this change is once the url() support in #905 is added we end up adding an extra lookup since images & fonts don't end in .less. I could add an extra check for common image/font extensions if you'd like, or maybe move that to plugin-css-url.

+25 -1

1 comment

5 changed files

xt0rted

pr closed time in 5 days

pull request commentOctoLinker/OctoLinker

Support extensionless less imports

Amazing, time for a new release ;)

xt0rted

comment created time in 5 days

push eventstefanbuck/action-playground

Stefan Buck

commit sha d7ca62d3dfc0d7ad52a749bad3df6e5467fe2a59

Create matrix.yml

view details

push time in 6 days

push eventstefanbuck/action-playground

Stefan Buck

commit sha b5dcccc7fe77969bc23752910f70e3757b208667

Create matrix.yml

view details

push time in 6 days

pull request commentOctoLinker/OctoLinker

Add PHP manual support

If you want to test the feature, you have to checkout this PR and follow contribution guide. yarn chrome-open open is meant for development, so if you want to test the feature over a day or so I recommend doing a build as described here.

stefanbuck

comment created time in 6 days

push eventstefanbuck/inihccuz

Deployment Bot (from Travis CI)

commit sha 8046a1db6310065360ebe38db237b526e14074a5

Deploy stefanbuck/inihccuz to github.com/stefanbuck/inihccuz.git:master

view details

push time in 6 days

push eventstefanbuck/inihccuz

Deployment Bot (from Travis CI)

commit sha 17297e65dc47084415c28a68df37e7719cbc6a23

Deploy stefanbuck/inihccuz to github.com/stefanbuck/inihccuz.git:master

view details

push time in 6 days

push eventstefanbuck/inihccuz

Deployment Bot (from Travis CI)

commit sha 155e40430f26f42bcc9e73fa7c144ba475bf6a95

Deploy stefanbuck/inihccuz to github.com/stefanbuck/inihccuz.git:master

view details

push time in 6 days

push eventOctoLinker/OctoLinker

Stefan Buck

commit sha 2938dadb7c671300c65e6c59fb04ad2498ba608c

Update pr-badge.yml

view details

push time in 6 days

pull request commentOctoLinker/OctoLinker

Add PHP manual support

I added support for functions, but constants are tricky. Other than functions and classes, there is not dedicated page for every constant. For example: PREG_NO_ERROR is a return value of https://www.php.net/manual/en/function.preg-last-error.php. I wonder if this is just nice to have or actual useful?

stefanbuck

comment created time in 6 days

create barnchstefanbuck/OctoLinker

branch : phpdocs

created branch time in 6 days

Pull request review commentOctoLinker/OctoLinker

Support extensionless less imports

+/* @OctoLinkerResolve(<root>/css/import.css) */+@import 'import.css';++/* @OctoLinkerResolve(<root>/css/import.css) */+@import "import.css";

I think we can remove one of the test, since different quote marks are already covered in the RegExp test https://github.com/OctoLinker/OctoLinker/blob/main/packages/helper-grammar-regex-collection/test.js#L309-L310

xt0rted

comment created time in 6 days

PullRequestReviewEvent

Pull request review commentOctoLinker/OctoLinker

Support extensionless less imports

+/* @OctoLinkerResolve(<root>/less/import.less) */+@import "import";++/* @OctoLinkerResolve(<root>/less/import.less) */+@import "import.less";

Same as above

xt0rted

comment created time in 6 days

PullRequestReviewEvent

push eventstefanbuck/inihccuz

Deployment Bot (from Travis CI)

commit sha 6d097c88f1b144f1fcdcc86aa22958822a0d0bc1

Deploy stefanbuck/inihccuz to github.com/stefanbuck/inihccuz.git:master

view details

push time in 7 days

push eventstefanbuck/inihccuz

Deployment Bot (from Travis CI)

commit sha 2516c8b9e7b341f2215c3cb0f4886a799b7a6b68

Deploy stefanbuck/inihccuz to github.com/stefanbuck/inihccuz.git:master

view details

push time in 7 days

pull request commentOctoLinker/OctoLinker

Add PHP manual support

Thanks for the suggestion @staabm. This repo looks interesting, but I struggle to figure out how to use it for this use case. For example, ArrayAccess seems to be missing here. On the other hand, the current approach is quite nice, because we don't have to maintain a list. For Java package we crawl https://spring.io to generate such a mapping list, but this is quite tricky to maintain. The ping request is made from the OctoLinker API and cached on the server so performance wise it shouldn't make a big difference.

The overlay is an interesting idea, but we should stick to the current OctoLinker UX and don't overcomplicate things. If we decide to add such an overlay it should work for other languages too. Feel free to open a separate issue, but I can't promise anything.

There is no plan to support other linking beside the use and other import statements, mainly because GitHub is working on this with code navigation already.

stefanbuck

comment created time in 7 days

push eventstefanbuck/inihccuz

Deployment Bot (from Travis CI)

commit sha 1ae2bc0a89e13ea2f9ba0de6858b75745e81133b

Deploy stefanbuck/inihccuz to github.com/stefanbuck/inihccuz.git:master

view details

push time in 7 days

push eventstefanbuck/inihccuz

Deployment Bot (from Travis CI)

commit sha 81e23336b5f7b7cc4e99cf67bf3168a7cb0c380a

Deploy stefanbuck/inihccuz to github.com/stefanbuck/inihccuz.git:master

view details

push time in 7 days

push eventstefanbuck/inihccuz

Deployment Bot (from Travis CI)

commit sha d972c5917bb12ff7b9d41a3dd684517ddd0df9a2

Deploy stefanbuck/inihccuz to github.com/stefanbuck/inihccuz.git:master

view details

push time in 8 days

push eventstefanbuck/inihccuz

Deployment Bot (from Travis CI)

commit sha a6edd0180900f398835fd3d03b53f9632b180c4a

Deploy stefanbuck/inihccuz to github.com/stefanbuck/inihccuz.git:master

view details

push time in 8 days

push eventstefanbuck/inihccuz

Deployment Bot (from Travis CI)

commit sha be00af5746e7234be70df2dbe763e815659fb54f

Deploy stefanbuck/inihccuz to github.com/stefanbuck/inihccuz.git:master

view details

push time in 8 days

issue commentOctoLinker/OctoLinker

Support for PHP imports

PHP manual support is one the way #1033

Anahkiasen

comment created time in 8 days

Pull request review commentOctoLinker/OctoLinker

Add PHP manual support

+import { PHP } from '@octolinker/helper-grammar-regex-collection';+import liveResolverQuery from '@octolinker/resolver-live-query';++export default {+  name: 'PHP',++  resolve(path, [target]) {+    if (target.includes('\\')) {+      return;

I'm not a PHP developer, so I don't know if there is a case where core class contains a slash as well ... I'll investigate

stefanbuck

comment created time in 8 days

more