profile
viewpoint
Steven R. Loomis srl295 @srl295 San José, CA, USA https://srl295.github.io me? i18n and @unicode-org stuff

srl295/btest402 7

Basic test of ES402 Intl object in Javascript.

srl295/es-unicode-properties 4

Unicode properties in ES

DTownSMR/kibana-i18n 1

:bar_chart: Kibana analytics and search dashboard for Elasticsearch

srl295/.profile.d 1

*My* configuration files. Also a way to learn about git.

srl295/fa-docker-compose 1

FrontAccounting for Docker Compose

behnam/unicode-idna 0

Unicode IDNA Compatibility Processing Data

srl295/bent 0

Functional HTTP client for Node.js w/ async/await.

srl295/blackbox_exporter 0

Blackbox prober exporter

srl295/blue-messenger 0

i18n of blue-messanger

create barnchsrl295/icu-demos

branch : esmsg

created branch time in 19 hours

push eventsrl295/srl295-slides

Steven R. Loomis

commit sha b57433df03bee16034d968a98ebf7b71a205ff60

fix qr

view details

push time in a day

push eventsrl295/srl295-slides

Steven R. Loomis

commit sha 9241a1ec561c132f96390117d5cbe85e287ce166

ship it

view details

push time in a day

push eventsrl295/srl295-slides

Steven R. Loomis

commit sha b72828c0b7f8dfbb6bee69f847a1177ac95deca7

backlink

view details

push time in a day

push eventsrl295/srl295-slides

Steven R. Loomis

commit sha b43417a1b60feb00b5eaed26119343b37af22c33

checkpoint

view details

push time in a day

created tagunicode-org/icu-demos

tagiuc44

sample apps for ICU (formerly icuapps)

created time in a day

release unicode-org/icu-demos

iuc44

released time in a day

push eventunicode-org/icu-docker

Steven R. Loomis

commit sha dd38b2bbff1fa0c5bbb2e6d1af4df49c41e07977

sort out generated binaries into proper names may not work for all versions, etc. But it is a start. Fixes: https://github.com/unicode-org/icu-docker/issues/1

view details

Steven R. Loomis

commit sha 012aeff4d175772ca950b7b0c60afcf04ebfc3be

Merge pull request #17 from unicode-org/sort-out-dist sort out generated binaries into proper names

view details

Steven R. Loomis

commit sha 0eb36e7281dc3f6cb1f38ba434b71839517b53c5

docker: fix ubuntu Dockerfile .. so that it doesn't stall waiting for timezone selection (!) - also add git-lfs

view details

Steven R. Loomis

commit sha 819aa7b25dfbc50b96757ce34b3dd7a5ecc534c6

setup for building under coverity - also ignore tmp directories in VSCode

view details

Steven R. Loomis

commit sha 1d8b466876d538cc6878719ee08064424163926e

add icu4j

view details

Steven R. Loomis

commit sha 51902919e22c9f4feaceda69dc376cc84ac1e031

icu4j + coverity!

view details

Steven R. Loomis

commit sha 9a562f8de59b6c988cc23c0fb48f48dce160369d

fixup! icu4j + coverity!

view details

Steven R. Loomis

commit sha 743bc13c2368d946e4d8750ceedf646418bbe846

add maven and gpg

view details

push time in a day

push eventsrl295/srl295-slides

Steven R. Loomis

commit sha 883fecb9020acd3a6f83b47f7eebbe0471d2cc51

upd

view details

push time in 2 days

create barnchsrl295/srl295-slides

branch : 2020-10-14-iuc44-icuwork-s1t3

created branch time in 2 days

pull request commentunicode-org/icu-docker

docker: fix ubuntu Dockerfile

@markusicu thanks. this will simplify some instructions.

srl295

comment created time in 2 days

delete branch unicode-org/icu-docker

delete branch : fix-docker

delete time in 2 days

push eventunicode-org/icu-docker

Steven R. Loomis

commit sha 0eb36e7281dc3f6cb1f38ba434b71839517b53c5

docker: fix ubuntu Dockerfile .. so that it doesn't stall waiting for timezone selection (!) - also add git-lfs

view details

push time in 2 days

PR merged unicode-org/icu-docker

Reviewers
docker: fix ubuntu Dockerfile

.. so that it doesn't stall waiting for timezone selection (!)

need this for iuc44

+4 -0

0 comment

2 changed files

srl295

pr closed time in 2 days

push eventunicode-org/icu-docker

Steven R. Loomis

commit sha 95f2cbd961ece96f57d20da91977212ac298c623

docker: fix ubuntu Dockerfile .. so that it doesn't stall waiting for timezone selection (!) - also add git-lfs

view details

push time in 2 days

PR opened unicode-org/icu-docker

Reviewers
docker: fix ubuntu Dockerfile

.. so that it doesn't stall waiting for timezone selection (!)

need this for iuc44

+2 -0

0 comment

2 changed files

pr created time in 2 days

create barnchunicode-org/icu-docker

branch : fix-docker

created branch time in 2 days

PR opened unicode-org/cldr

Reviewers
CLDR-11585 tests

you can now run specific subtests with:

mvn test '-Dorg.unicode.cldr.unittest.web.testArgs=-f:TestMisc -n -q' '-Dorg.unicode.cldr.unittest.testArgs=-f:TestUntimedCounter -n -q' 

I was unable to get code coverage to work here, but it's just a config file change away.

+44 -15

0 comment

6 changed files

pr created time in 2 days

push eventsrl295/cldr

Steven R. Loomis

commit sha 1aadc44eb0ad97502188cb32cd88db538db16822

CLDR-11585 improve maven tests - You can run individual tests using testArgs properties. Example to run only one test from web and utils: mvn test '-Dorg.unicode.cldr.unittest.web.testArgs=-f:TestMisc -n -q' '-Dorg.unicode.cldr.unittest.testArgs=-f:TestUntimedCounter -n -q'

view details

push time in 2 days

create barnchsrl295/cldr

branch : test11585

created branch time in 2 days

Pull request review commentunicode-org/cldr

CLDR-13582 Make sure browser uses most recent JavaScript files for ST

 private synchronized void init() {         // The git version of the cldr.jar file embedded in cldr-apps.         survprops.put("CLDR_UTILITIES_HASH", getGitHashForSlug("CLDR-Tools"));         // The git version of the CLDR_DIR currently in use.-        survprops.put("CLDR_DATA_HASH", getGitHashForDir(survprops.getProperty("CLDR_DIR", null)));+        survprops.put("CLDR_DATA_HASH", CldrUtility.getGitHashForDir(survprops.getProperty("CLDR_DIR", null)));

There's no comnon init() for CLDRConfig, but if there were, this line could move there.

btangmu

comment created time in 2 days

Pull request review commentunicode-org/cldr

CLDR-13582 Make sure browser uses most recent JavaScript files for ST

 protected Environment getDefaultEnvironment() {     }      CLDRConfigImpl() {-        // TODO remove this after some time- just warn people about the old message

:+1: "some time" has passed, whatever it was :)

btangmu

comment created time in 2 days

Pull request review commentunicode-org/cldr

CLDR-13582 Make sure browser uses most recent JavaScript files for ST

 public void TestIsCoverageOrganization() {     }      public void TestGitHash() {-        final String appsVersion = CLDRConfigImpl.getGitHashForSlug("CLDR-Apps");-        assertNotNull("getting CLDR-Apps version", appsVersion);-        /*-         * TODO: fail if CLDRURLS.UNKNOWN_REVISION.equals(appsVersion))-         * and likewise for toolsVersion-         */-        // if (CLDRURLS.UNKNOWN_REVISION.equals(appsVersion)) {-        //    errln("❌ appsVersion = UNKNOWN_REVISION: " + appsVersion);-        // }--        final String toolsVersion = CLDRConfigImpl.getGitHashForSlug("CLDR-Tools");-        assertNotNull("getting CLDR-Tools version", toolsVersion);--        /*-         * TODO: add a regression test here for CLDR_DATA_HASH-         * Reference: https://unicode-org.atlassian.net/browse/CLDR-13582-         */-        // final String hash = CLDRConfig.getInstance().getProperty("CLDR_DATA_HASH");-        // assertNotNull("getting CLDR_DATA_HASH", hash);-        // if (hash != null && !hash.matches("[0-9a-f]+")) {-        //    errln("❌ CLDR_DATA_HASH is not hex: " + hash);-        // }+        final String hash = CldrUtility.getCldrBaseDirHash();+        assertNotNull("getCldrBaseDirHash", hash);+        if (hash != null) {+            if (!hash.matches("[0-9a-f]+")) {+                errln("❌ getCldrBaseDirHash is not hex: " + hash);+            } else if (hash.length() < 8) {+                errln("❌ getCldrBaseDirHash is shorter than 8 chars: " + hash);+            }+        }+        final String strings[] = {"CLDR-Apps", "CLDR-Tools"};+        for (String s : strings) {+            final String version = CLDRConfigImpl.getGitHashForSlug(s);+            assertNotNull("getting " + s + " version", version);+            /*+             * TODO: fail if CLDRURLS.UNKNOWN_REVISION.equals(version).+             * Currently they do equal CLDRURLS.UNKNOWN_REVISION, since SurveyMain.init isn't called for TestAll.

So, in a test environment, you definitely don't have cldr-apps.war and thus no manifest to read "CLDR-Apps" from. You also might not have cldr*.jar for its tools manifest, if the tests are run in eclipse let's say. So this might be a warning, but a challenge to get from the test environment.

I don't know if you can use a warfile as if it were a jar on the classpath? If so, we could have a post build step, something like: java -DCLDR_APPS_VERSION_TEST -classpath …:…:cldr*.jar:cldr-apps.war TestAll or something like that?

btangmu

comment created time in 2 days

Pull request review commentunicode-org/cldr

CLDR-13582 Make sure browser uses most recent JavaScript files for ST

 public void TestIsCoverageOrganization() {     }      public void TestGitHash() {-        final String appsVersion = CLDRConfigImpl.getGitHashForSlug("CLDR-Apps");-        assertNotNull("getting CLDR-Apps version", appsVersion);-        /*-         * TODO: fail if CLDRURLS.UNKNOWN_REVISION.equals(appsVersion))-         * and likewise for toolsVersion-         */-        // if (CLDRURLS.UNKNOWN_REVISION.equals(appsVersion)) {-        //    errln("❌ appsVersion = UNKNOWN_REVISION: " + appsVersion);-        // }--        final String toolsVersion = CLDRConfigImpl.getGitHashForSlug("CLDR-Tools");-        assertNotNull("getting CLDR-Tools version", toolsVersion);--        /*-         * TODO: add a regression test here for CLDR_DATA_HASH-         * Reference: https://unicode-org.atlassian.net/browse/CLDR-13582-         */-        // final String hash = CLDRConfig.getInstance().getProperty("CLDR_DATA_HASH");-        // assertNotNull("getting CLDR_DATA_HASH", hash);-        // if (hash != null && !hash.matches("[0-9a-f]+")) {-        //    errln("❌ CLDR_DATA_HASH is not hex: " + hash);-        // }+        final String hash = CldrUtility.getCldrBaseDirHash();+        assertNotNull("getCldrBaseDirHash", hash);+        if (hash != null) {

minor: it's already been asserted as not-null on the prior line, so this is an unnecessary ifdef.

btangmu

comment created time in 2 days

Pull request review commentunicode-org/cldr

CLDR-13582 Make sure browser uses most recent JavaScript files for ST

 public void TestIsCoverageOrganization() {     }      public void TestGitHash() {-        final String appsVersion = CLDRConfigImpl.getGitHashForSlug("CLDR-Apps");-        assertNotNull("getting CLDR-Apps version", appsVersion);-        /*-         * TODO: fail if CLDRURLS.UNKNOWN_REVISION.equals(appsVersion))-         * and likewise for toolsVersion-         */-        // if (CLDRURLS.UNKNOWN_REVISION.equals(appsVersion)) {-        //    errln("❌ appsVersion = UNKNOWN_REVISION: " + appsVersion);-        // }--        final String toolsVersion = CLDRConfigImpl.getGitHashForSlug("CLDR-Tools");-        assertNotNull("getting CLDR-Tools version", toolsVersion);--        /*-         * TODO: add a regression test here for CLDR_DATA_HASH-         * Reference: https://unicode-org.atlassian.net/browse/CLDR-13582-         */-        // final String hash = CLDRConfig.getInstance().getProperty("CLDR_DATA_HASH");-        // assertNotNull("getting CLDR_DATA_HASH", hash);-        // if (hash != null && !hash.matches("[0-9a-f]+")) {-        //    errln("❌ CLDR_DATA_HASH is not hex: " + hash);-        // }+        final String hash = CldrUtility.getCldrBaseDirHash();+        assertNotNull("getCldrBaseDirHash", hash);+        if (hash != null) {+            if (!hash.matches("[0-9a-f]+")) {+                errln("❌ getCldrBaseDirHash is not hex: " + hash);

it could be 'unknown' if git is missing or if the code was compiled from a source tarball?maybe this should be a warning?

btangmu

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

delete branch srl295/cldr

delete branch : cache11585

delete time in 3 days

push eventunicode-org/cldr

Steven R. Loomis

commit sha 880b4957a8b843fb1a36353bc4f7ca362ea6764e

CLDR-11585 cache maven dependencies (#738) - cache maven dependencies for build speedup and reliability - do not specify the maven central URL but let it default - update some action versions - do not run tests twice! - also, add a comment explaining a line in the ansible-lint.yml (from CLDR-13771 workaround ansible-lint failing (#729) )

view details

push time in 3 days

PR merged unicode-org/cldr

Reviewers
CLDR-11585 cache maven dependencies

the maven build is timing out sometimes… let's see if caching will help.

+12 -10

6 comments

3 changed files

srl295

pr closed time in 3 days

push eventunicode-org/icu-demos

Steven R. Loomis

commit sha a90b5bfd83bfd6dbd4fbcc7a4be9c64c04bbfbed

Iuc43 (#14) * ICU-13668 Rebase of iuc42 branch onto master - the "iuc42" branch b14a81fec744b553294d5d3d93c34d41dbfc19e8 is in this commit from last year. * ICU-13668 iuc43 updates for iuc43 - automated testing of C demos - delete old "icufacts" (from iuc37), add top level instruction * ICU-13668 iuc43 test J iucsamples too! * ICU-13668 iuc43 use travis mvn instead of docker * fixup! ICU-13668 iuc43 use travis mvn instead of docker * fixup! ICU-13668 iuc43 test J iucsamples too! * Update readme.txt * Match https://github.com/srl295/srl295-slides/commit/bc71356b44117386ee1be95e225cc78341cf0fe5 * iuc43 fixes - use '-e utf-8' to not default the genrb build - add an error for ICU4C<62.x API

view details

push time in 3 days

PR merged unicode-org/icu-demos

Iuc43

ICU-13668 - merge demos as presented at iuc43 into master

+757 -958

0 comment

82 changed files

srl295

pr closed time in 3 days

pull request commentunicode-org/icu

ICU-21269 ParagraphLayout complexTable: init & access based on actual values

scriptCodeCount is written by ScriptIDModuleWriter.java which should be run as a BRS task

markusicu

comment created time in 3 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentunicode-org/cldr

CLDR-11585 cache maven dependencies

 jobs:       with:         lfs: false # not needed for this job, as we don’t currently do a Java build     - name: Lint Ansible Playbook+      # the hash here is a specific version of that repo, since there is not a later commit.

@btangmu from your comment on #729

srl295

comment created time in 3 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventsrl295/cldr

Steven R. Loomis

commit sha d9f9c0970e8caf7c579ace92fc328c3df3915ce1

CLDR-11585 cache maven dependencies - cache maven dependencies for build speedup and reliability - do not specify the maven central URL but let it default - update some action versions - do not run tests twice! - also, add a comment explaining a line in the ansible-lint.yml (from CLDR-13771 workaround ansible-lint failing (#729) )

view details

push time in 3 days

push eventsrl295/cldr

Steven R. Loomis

commit sha 5f944ba2a176ba43e2ff4bf3d6ef43d8dcc19d70

CLDR-11585 cache maven dependencies - do not specify the maven central URL but let it default - update some action versions - do not run tests twice! - also, add a comment explaining a line in the ansible-lint.yml (from CLDR-13771 workaround ansible-lint failing (#729) )

view details

push time in 3 days

pull request commentunicode-org/cldr

CLDR-11585 cache maven dependencies

Also:

  • do not specify the maven central URL but let it default
  • update some action versions
srl295

comment created time in 3 days

pull request commentunicode-org/cldr

CLDR-11585 cache maven dependencies

results:

  • maven tests only run once, not once at build and once at test (oops)
  • cache+build = 26 seconds, where the maven build took 43 seconds before tests were added (that was fewer source files being compiled, so the savings are probably even greater)
  • More significantly, those 20 seconds are network traffic, which has been timing out recently.
srl295

comment created time in 3 days

push eventsrl295/cldr

Steven R. Loomis

commit sha 0e5f397ccf2c03f67be8cb5b426b2fd887679607

CLDR-11585 cache maven dependencies - do not specify the maven central URL but let it default - update some action versions - do not run tests twice!

view details

push time in 3 days

push eventsrl295/cldr

Steven R. Loomis

commit sha 8ab08e46a5a0d2a322dbf26c2291412d6ea1addc

CLDR-11585 cache maven dependencies - also, do not specify the maven central URL but let it default - also, update some action versions

view details

push time in 3 days

PR opened unicode-org/cldr

Reviewers
CLDR-11585 cache maven dependencies

the maven build is timing out sometimes… let's see if caching will help.

+7 -0

0 comment

1 changed file

pr created time in 3 days

push eventsrl295/cldr

Steven R. Loomis

commit sha 28b93a774327ca9479b0128117d1be396f6f9cfd

CLDR-11585 cache maven dependencies

view details

push time in 3 days

create barnchsrl295/cldr

branch : cache11585

created branch time in 3 days

startedelixir-cldr/cldr_units

started time in 3 days

pull request commentunicode-org/cldr

CLDR-14175 update JSON converter to handle compoundUnitPattern1

compoundUnitPattern1-gender-feminine-count-other-case-accusative is kind of a mouthful. But, it keeps it consistent with other unit related stuff.

srl295

comment created time in 3 days

pull request commentunicode-org/cldr

CLDR-14175 update JSON converter to handle compoundUnitPattern1

FYI @kipcole9

srl295

comment created time in 3 days

PR opened unicode-org/cldr

Reviewers
CLDR-14175 update JSON converter to handle compoundUnitPattern1

CLDR-14175

this was broken for, say, Amharic also. My first fix is this. From:

         "power2": {
           "compoundUnitPattern1": "{0}²",
           "compoundUnitPattern1": "{0}²",
           "compoundUnitPattern1": "{0}²"
         },
         "power2": {
           "compoundUnitPattern1": "{0}²",
           "compoundUnitPattern1-count-one": "{0}²",
           "compoundUnitPattern1-count-other": "{0}²"
         },

Now, for German a similar issue ensued. My fix outputs this:

          "power2": {
            "compoundUnitPattern1": "Quadrat{0}",
            "compoundUnitPattern1-count-one": "Quadrat{0}",
            "compoundUnitPattern1-count-one-case-accusative": "Quadrat{0}",
            "compoundUnitPattern1-count-one-case-dative": "Quadrat{0}",
            "compoundUnitPattern1-count-one-case-genitive": "Quadrat{0}",
            "compoundUnitPattern1-gender-feminine-count-one": "Quadrat{0}",
            "compoundUnitPattern1-gender-feminine-count-one-case-accusative": "Quadrat{0}",
            "compoundUnitPattern1-gender-feminine-count-one-case-dative": "Quadrat{0}",
            "compoundUnitPattern1-gender-feminine-count-one-case-genitive": "Quadrat{0}",
            "compoundUnitPattern1-gender-masculine-count-one": "Quadrat{0}",
            "compoundUnitPattern1-gender-masculine-count-one-case-accusative": "Quadrat{0}",
            "compoundUnitPattern1-gender-masculine-count-one-case-dative": "Quadrat{0}",
            "compoundUnitPattern1-gender-masculine-count-one-case-genitive": "Quadrat{0}",
            "compoundUnitPattern1-count-other": "Quadrat{0}",
            "compoundUnitPattern1-count-other-case-accusative": "Quadrat{0}",
            "compoundUnitPattern1-count-other-case-dative": "Quadrat{0}",
            "compoundUnitPattern1-count-other-case-genitive": "Quadrat{0}",
            "compoundUnitPattern1-gender-feminine-count-other": "Quadrat{0}",
            "compoundUnitPattern1-gender-feminine-count-other-case-accusative": "Quadrat{0}",
            "compoundUnitPattern1-gender-feminine-count-other-case-dative": "Quadrat{0}",
            "compoundUnitPattern1-gender-feminine-count-other-case-genitive": "Quadrat{0}",
            "compoundUnitPattern1-gender-masculine-count-other": "Quadrat{0}",
            "compoundUnitPattern1-gender-masculine-count-other-case-accusative": "Quadrat{0}",
            "compoundUnitPattern1-gender-masculine-count-other-case-dative": "Quadrat{0}",
            "compoundUnitPattern1-gender-masculine-count-other-case-genitive": "Quadrat{0}"
          },
+4 -0

0 comment

1 changed file

pr created time in 3 days

create barnchsrl295/cldr

branch : json14175

created branch time in 3 days

pull request commentunicode-org/cldr

CLDR-14116 Include TestLanguageGroup in TestAll, improve infra

Question, can we change the author in github? That way I'll see it on my plate.

You are now the only owner of the PR. The fix-grouptest branch is in the head fork (unicode-org) and so you can push any commits you want to it.

srl295

comment created time in 3 days

delete branch srl295/cldr

delete branch : fixpom-11585

delete time in 3 days

push eventunicode-org/cldr

Steven R. Loomis

commit sha 6adc82b6b6116bb67e046ec129adb66f4aa6aac4

CLDR-11585 fix pom.xml, add tests (#734) - fix pom.xml repository settings so that settings can be more minimal - basic test runner shim for web / java - build tests where they are - currently test code is included in cldr-apps.war (TODO) - currently, cldr-apps are tested against Derby (regression of CLDR-8383)

view details

push time in 3 days

PR merged unicode-org/cldr

Reviewers
CLDR-11585 Maven: Add tests, simplify pom setup

CLDR-11585

after this, then https://sites.google.com/site/cldr/development/maven instructions should work to use maven (from the command line, at least).


Rescoping this one to also include adding (via a shim) all tests (but not consolecheck).

+106 -19

9 comments

10 changed files

srl295

pr closed time in 3 days

issue openedunicode-org/unicodetools

util: 413 with very long input

I was trying to paste the CLDR zh exemplar set into the UnicodeSet tool, and got a 413. 4k of text expands to >8k of URI content.

The UnicodeSet submit button should detect that the input is above some threshhold, and submit the data as a POST. You won't be able to bookmark the link (as with other use of the tool), but at least the intended operation will actually work.

created time in 3 days

PullRequestReviewEvent

issue commentnodejs/i18n

Translate the main .md files of this repository into other languages.

@JoseJPR

doubts - English

The list in the i18n readme could have the language link in the native language also ("Spanish-español"). But I think the developer can navigate that far if they've already found the i18n repo.

1.- I don't see the need to add the last directory "nodejs/nodejs-es/tree/master/ i18n-guide/es", it would leave it like this "nodejs/nodejs-es/tree/master/i18n-guide". In my opinion it is redundant as it already has "nodejs-es" in the path.

A language group might be responsible for more than one language dialect/orthography. Maybe simplified and traditional Chinese are in the same group? I think the extra /es is worthwhile

JoseJPR

comment created time in 3 days

pull request commentunicode-org/icu

Wasm32 Architeture Port

@devsnek was also interested in this.

+1 for @devsnek

mabels

comment created time in 3 days

issue commenttc39/ecma402

DateTimeFormat: consider adding more timezone display options

perhaps id / locode should be 'getters' rather than format option in this case.

What does this mean (of be a getters)? could you show me some example JS code to express what you wish the API would do for that?

I'm not sure of the right API location. Maybe it would be part of resolvedOptions even, since it's not wall-time specific. Roughly:

const d = new Date(); // date for the zone info
const {locode, id} = fmt.zoneInfoFor(d);
=>  locode: 'uslax', id: 'America/Los_Angeles`

the date is needed because of historcial zones

jungshik

comment created time in 3 days

pull request commentunicode-org/cldr

CLDR-11585 fix pom.xml, also add tests

Oops. Need to exclude TestShim from ant!

fixed

srl295

comment created time in 3 days

push eventsrl295/cldr

Steven R. Loomis

commit sha 03244bdea16aafd6435156c791daf338f750596e

CLDR-11585 fix pom.xml, add tests - fix pom.xml repository settings so that settings can be more minimal - basic test runner shim for web / java - build tests where they are - currently test code is included in cldr-apps.war (TODO) - currently, cldr-apps are tested against Derby (regression of CLDR-8383)

view details

push time in 3 days

pull request commentunicode-org/cldr

CLDR-11585 fix pom.xml, also add tests

Oops. Need to exclude TestShim from ant!

srl295

comment created time in 3 days

push eventsrl295/cldr

Steven R. Loomis

commit sha 2a6245f7dac5015588d10a124ee7198d26277447

CLDR-11585 fix pom.xml, add tests - fix pom.xml repository settings so that settings can be more minimal - basic test runner shim for web / java - build tests where they are - currently test code is included in cldr-apps.war (TODO) - currently, cldr-apps are tested against Derby (regression of CLDR-8383)

view details

push time in 4 days

pull request commentunicode-org/cldr

CLDR-11585 fix pom.xml, also add tests

I'll do a more complete test integration, this simply sublaunches the entire CLDR test suite as a single junit test. It's also not configurable.

But, while 'ant' is still in the picture, i wanted to keep it simple.

srl295

comment created time in 4 days

push eventsrl295/cldr

Mark Davis

commit sha a063e7f15487b638ce2f4b1b7a0ca6126a940141

CLDR-14194 define the skeleton in unitPreferences more precisely (#728)

view details

Steven R. Loomis

commit sha 1fb7d3b36492cde5dd6cd7b740a859470cdb81b8

CLDR-13771 workaround ansible-lint failing (#729) - see https://github.com/ansible-collections/community.kubernetes/issues/135#issuecomment-661189940 - workaround by not setting a version

view details

Steven R. Loomis

commit sha df0c987cea8fc379c32e6ab8288d7b6a724d97bc

CLDR-11585 fix pom.xml, add tests - fix pom.xml repository settings so that settings can be more minimal - basic test runner shim for web / java - build tests where they are - currently test code is included in cldr-apps.war (TODO) - currently, cldr-apps are tested against Derby (regression of CLDR-8383)

view details

push time in 4 days

push eventsrl295/cldr

Steven R. Loomis

commit sha 01ffc642fd40d9e4d71afd8d3570c7166c130b00

CLDR-11585 fix pom.xml, add tests - fix pom.xml repository settings so that settings can be more minimal - basic test runner shim for web / java - build tests where they are - currently test code is included in cldr-apps.war (TODO) - currently, cldr-apps are tested against Derby (regression of CLDR-8383)

view details

push time in 4 days

pull request commentunicode-org/cldr

CLDR-11585 fix pom.xml so that a minimal settings.xml works

without this, users will have to add something like this to ~/.m2/settings.xml:

      <repositories>
        <repository>
          <id>githubicu</id>
          <name>GitHub unicode-org/icu Apache Maven Packages</name>
          <url>https://maven.pkg.github.com/unicode-org/icu</url>
        </repository>
      </repositories>
srl295

comment created time in 4 days

delete branch srl295/cldr

delete branch : fixlint-13771

delete time in 4 days

push eventunicode-org/cldr

Steven R. Loomis

commit sha 1fb7d3b36492cde5dd6cd7b740a859470cdb81b8

CLDR-13771 workaround ansible-lint failing (#729) - see https://github.com/ansible-collections/community.kubernetes/issues/135#issuecomment-661189940 - workaround by not setting a version

view details

push time in 4 days

PR merged unicode-org/cldr

CLDR-13771 workaround ansible-lint failing

CLDR-13771

  • see https://github.com/ansible-collections/community.kubernetes/issues/135#issuecomment-661189940
  • workaround by not setting a version
+3 -4

4 comments

1 changed file

srl295

pr closed time in 4 days

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentunicode-org/cldr

CLDR-11585 fix pom.xml so that a minimal settings.xml works

the githubicu URL was defined at the wrong level.

srl295

comment created time in 4 days

PR opened unicode-org/cldr

Reviewers
CLDR-11585 fix pom.xml so that a minimal settings.xml works

CLDR-11585

after this, then https://sites.google.com/site/cldr/development/maven instructions should work to use maven (from the command line, at least).

+8 -8

0 comment

2 changed files

pr created time in 4 days

create barnchsrl295/cldr

branch : fixpom-11585

created branch time in 4 days

startedkelseyhightower/nocode

started time in 4 days

push eventsrl295/icu

Erik Torres

commit sha a7a8cc38092d5ff21e8ae136c781f32d497e834b

ICU-20808 Add test for the C locale to default to en_US_POSIX

view details

Fredrik Roubert

commit sha 3a8e0a2fe9343f66b5509ef3c0e1ee97af935265

ICU-21035 Replace backward compatibility ulocimp_getLanguage() overload. By always calling the dynamic memory allocation implementation directly instead, the fixed memory buffer boundary gets pushed one step further towards the edges.

view details

Frank Tang

commit sha cde54fc5ba1581061cc31c158967ab6b074df3ab

ICU-21157 Fix incorrect null termination. See #1236

view details

Markus Scherer

commit sha 39da689d30512148dc47d2169910d6b7c1c09cd5

ICU-21184 rephrase docs/comments using the term grandfathered

view details

Markus Scherer

commit sha c8aa800735dc33bbc35784096a80a0c72812fdb5

ICU-21035 add & use CharString::extract(dest buffer) See #1253

view details

Hugo van der Merwe

commit sha 0387d1b988c0b410aca9941070e89774877d6cfe

ICU-21230 Add status to MaybeStackArray(int32_t newCapacity), plumb it through.

view details

Frank Tang

commit sha 3b188e46a49b65347a657b72f765fd8107aee85e

ICU-21157 Fix test code See #1256

view details

Fredrik Roubert

commit sha db3278a71e1a734f9989959d9e65c5ae64c38026

ICU-21035 Replace backward compatibility ulocimp_getScript() overload. By always calling the dynamic memory allocation implementation directly instead, the fixed memory buffer boundary gets pushed one step further towards the edges.

view details

Fredrik Roubert

commit sha e8f3d5c65700e53a235507f9e0882a6ca5fe2a71

ICU-21035 Replace backward compatibility ulocimp_getCountry() overload. By always calling the dynamic memory allocation implementation directly instead, the fixed memory buffer boundary gets pushed one step further towards the edges.

view details

Fredrik Roubert

commit sha d070fdddd128f43c321da11c27c47dbb6d7462ce

ICU-21035 Remove obsolete use of CharString::getAppendBuffer(). The complicated buffer allocation code is inherited from times past but no longer serves any purpose, it's now possible to instead simply call the CharString copy constructor.

view details

Shane F. Carr

commit sha 4767be7f4ff361612a5d62caa92884cfa9d8c224

ICU-21249 Updating double-conversion for ICU 68

view details

Fredrik Roubert

commit sha 05d49fd373021b40d191e2249118cc0ae97d3659

ICU-21035 Replace backward compatibility locale_getKeywords() function. By updating the last 3 callers to do dynamic memory allocation instead, the fixed memory buffer function becomes obsolete.

view details

David Beaumont

commit sha 95cd3904aa7512ce7ec8220cc6d6748e7a7dc52e

ICU-21028 Adding ICU version file generation to tools See #1248

view details

Shane F. Carr

commit sha 59cdbe1f53a0181c4092cb0584b9f483d7167306

ICU-21232 Improve performance of DecimalFormat#parse on long numbers

view details

Hugo van der Merwe

commit sha 66b2458a26c9b06181cfc6446a7d9cfd391baa16

ICU-21066 Copy includelist of CLDR testData with tools/cldr/build.xml

view details

David Beaumont

commit sha 9bcd35aee09c524dd2eae566422ce41f2c0473cd

ICU-21240 Removing unused makefile files and updating docs.

view details

Craig Cornelius

commit sha 408cd128fc07d7f87c20ce75bedb1964ef4a8adb

ICU-21242 rephrase documentation using term master See #1255

view details

Shane F. Carr

commit sha 0dbe1ae01315b516c4d0f1529d236f44d5619cd9

ICU-20927 Adding French narrow duration unit test.

view details

Hugo van der Merwe

commit sha 35eae09a7c7743ab5911c1934e6e5fda1b9340f1

ICU-21246 Handle kilogram SI prefix correctly Fix kilogram parsing: ignore 'kilogram' as a stem, we have 'gram'. Failures in the added unit test before the fix: withSIPrefix resulted in 'microkilogram', and kilogram's prefix was considered to be "ONE" (i.e. 10^0).

view details

Shane F. Carr

commit sha 0101e2632c34c05f2e0cf6baedf219389aa2fb8a

ICU-20164 Make NoUnit a zero-cost abstraction over MeasureUnit. See #1230

view details

push time in 4 days

delete branch srl295/cldr

delete branch : update-icu-11585

delete time in 4 days

push eventunicode-org/cldr

Steven R. Loomis

commit sha a3b5145ddb9ef8cc3e3cca56058c71adf8417b0c

CLDR-11585 update icu4j to 68.1-SNAPSHOT-cldr-2020-09-22 (#732) - switch settings from srl295 to unicode-org - parallel to b3254d3f3ca4fbc32e8c6e1fe14406edf793b5e3 / #731 - will update developer docs to explain how to configure maven

view details

push time in 4 days

PR merged unicode-org/cldr

Reviewers
CLDR-11585 update icu4j to 68.1-SNAPSHOT-cldr-2020-09-22

CLDR-11585 updates to the tag cldr/2020-09-22 from ICU

  • switch settings from srl295 to unicode-org
  • parallel to b3254d3f3ca4fbc32e8c6e1fe14406edf793b5e3 / #731
  • will update developer docs to explain how to configure maven
+14 -15

0 comment

4 changed files

srl295

pr closed time in 4 days

Pull request review commentunicode-org/cldr

CLDR-11585 update icu4j to 68.1-SNAPSHOT-cldr-2020-09-22

 		<maven.compiler.source>1.8</maven.compiler.source> 		<maven.compiler.target>1.8</maven.compiler.target> 		<!-- TODO: fix when https://github.com/unicode-org/icu/pull/1270 lands -->-		<icu4j.version>0.0.0-cldr-38-d00</icu4j.version>+		<icu4j.version>68.1-SNAPSHOT-cldr-2020-09-22</icu4j.version>

@pedberg-icu this will be the only line to change in the future! 🎉

srl295

comment created time in 4 days

PullRequestReviewEvent
PullRequestReviewEvent

PR opened unicode-org/cldr

Reviewers
CLDR-11585 update icu4j to 68.1-SNAPSHOT-cldr-2020-09-22

CLDR-11585 updates to the tag cldr/2020-09-22 from ICU

  • switch settings from srl295 to unicode-org
  • parallel to b3254d3f3ca4fbc32e8c6e1fe14406edf793b5e3 / #731
  • will update developer docs to explain how to configure maven
+14 -15

0 comment

4 changed files

pr created time in 4 days

create barnchsrl295/cldr

branch : update-icu-11585

created branch time in 4 days

push eventunicode-org/cldr

Peter Edberg

commit sha b3254d3f3ca4fbc32e8c6e1fe14406edf793b5e3

CLDR-14128 Update readme and ICU4J libs to Sep 22 (ICU tag cldr/2020-09-22) (#731)

view details

push time in 4 days

PR merged unicode-org/cldr

CLDR-14128 Update readme and ICU4J libs to Sep 22 (ICU tag cldr/2020-09-22)

<!-- Thank you for your pull request. Please see http://cldr.unicode.org/index/process for general information on contributing to CLDR.

You will be automatically asked to sign the contributors license before the PR is accepted.

  • sign: https://cla-assistant.io/unicode-org/cldr
  • license: http://www.unicode.org/copyright.html#License -->
Checklist
  • [x] Issue filed: https://unicode-org.atlassian.net/browse/CLDR-14128
  • [x] Updated PR title and link in previous line to include Issue number

Update ICU4J libs in CLDR to version in ICU at end-of-day 2020-09-22 (tagged in ICU as "cldr/2020-09-22"; ICU git hash 3d8ae5eb6...). Also update CLDR readme for beta.

+11 -11

1 comment

6 changed files

pedberg-icu

pr closed time in 4 days

pull request commentunicode-org/cldr

CLDR-14128 Update readme and ICU4J libs to Sep 22 (ICU tag cldr/2020-09-22)

@pedberg-icu by the way, the maven push needs a 'release' not just a tag. I've created one at https://github.com/unicode-org/icu/releases/tag/cldr%2F2020-09-22 from the tag. (You can go in and edit a tag and turn it into a release. )

On the 'create a release' page you can specify the tag, and check a box that says 'this is not production ready' (which I have done).

pedberg-icu

comment created time in 4 days

release unicode-org/icu

cldr/2020-09-22

released time in 4 days

PullRequestReviewEvent

issue commentansible/ansible-lint-action

override-deps from README not working

@mattwillsher For me I have no reason to pin to a pre 2.10.0 Ansible, so just letting the current get installed (from the package manager) was fine.

srl295

comment created time in 4 days

issue commenttc39/ecma402

DateTimeFormat: consider adding more timezone display options

Frank, It's probably unlikely among people that aren't too close to things.

uslax is also an input (-u extension) in CLDR.

Anyway, perhaps id / locode should be 'getters' rather than format option in this case. Would be great to have some access, even if it's not part of format.

jungshik

comment created time in 4 days

issue commentnodejs/node

Build the lightest node binary possible

14MB sounds about right. You can try building with "--without-intl " and compare the difference.

jsdario

comment created time in 4 days

pull request commentunicode-org/icu

ICU-21251 release icu4j.jar/utilities.jar to GH Maven

Thanks!

srl295

comment created time in 4 days

pull request commentunicode-org/cldr

CLDR-14184 further updates to statistics page

let's get our v38 stats from here, and then move to a new charting framework.

srl295

comment created time in 4 days

pull request commentunicode-org/cldr

CLDR-14184 further updates to statistics page

@macchiati when smoketest finishes updating to 56a784aa5dc15bed3133297cdf886322eb04cfba we can push to production.

srl295

comment created time in 4 days

delete branch srl295/cldr

delete branch : statter-13470

delete time in 4 days

push eventunicode-org/cldr

Steven R. Loomis

commit sha 56a784aa5dc15bed3133297cdf886322eb04cfba

CLDR-14184 further updates to statistics page (#726) - turn x axis label to reduce crowding - improve spacing along y axis - improve wording in legend to: - “Just New or changed votes in CLDR 38” - “Imported winning votes from previous releases”

view details

push time in 4 days

more