profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/sridhargaddam/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Sridhar Gaddam sridhargaddam Red Hat Bangalore

sridhargaddam/vpn-automation 2

VPN Automation (using VNF) POC

sridhargaddam/opnfv_os_ipv6_poc 1

This repo has configuration files for creating the OPNFV IPv6 service-vm as vRouter POC.

mangelajo/submariner 0

Connect all your Kubernetes clusters, no matter where they are in the world.

sridhargaddam/admiral 0

Admiral is the submariner API for integration with federation systems

sridhargaddam/cloud-prepare 0

Go library to prepare your cloud infrastructure via API for submariner to work on top

sridhargaddam/coastguard 0

Controller to facilitate network policing on a multi-cluster connected environments (proof-of-concept state)

sridhargaddam/configure-osp-for-subm 0

Configure Submariner Security Group Prerequisites for OpenStack Platform

sridhargaddam/console 0

The user interface for the cluster management portion of open-cluster-management.

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentsubmariner-io/submariner-charts

Update helm chart to 0.10.1 & Add missing variables to support AKS

 questions:     type: string     label: Submariner Operator Image Repository   - variable: operator.image.tag-    default: "0.7.0"+    default: "0.10.1"

thanks @vigohe

vigohe

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentsubmariner-io/submariner

Ignore endpoint events if processed already.

 func (kp *SyncHandler) RemoteEndpointUpdated(endpoint *submV1.Endpoint) error { func (kp *SyncHandler) RemoteEndpointRemoved(endpoint *submV1.Endpoint) error { 	kp.syncHandlerMutex.Lock() 	defer kp.syncHandlerMutex.Unlock()++	lastPorcessedTime, ok := kp.remoteEndpointTimeStamp[endpoint.Name]++	if ok && lastPorcessedTime.After(endpoint.CreationTimestamp.Time) {+		klog.Infof("Ingoring deleted remote %#v since a later endoint was already"++			"processed", endpoint)+		return nil

The exact problem that we noticed in OCP deployment was that a stale/old endpoint event coming after an updated event. Here we are skipping the old one, but what about deleting any resources (like iptables, routes etc) which point to the old endpoint? Can you please point me where we will handle it with this change?

aswinsuryan

comment created time in 3 days

Pull request review commentsubmariner-io/submariner

Ignore endpoint events if processed already.

 func (kp *SyncHandler) RemoteEndpointCreated(endpoint *submV1.Endpoint) error {  	kp.syncHandlerMutex.Lock() 	defer kp.syncHandlerMutex.Unlock()++	lastPorcessedTime, ok := kp.remoteEndpointTimeStamp[endpoint.Name]++	if ok && lastPorcessedTime.After(endpoint.CreationTimestamp.Time) {+		klog.Infof("Ingoring new remote %#v since a later endoint was already"+

Ideally, these events should happen only during migration and if there is out-of-order events. So, I would guess it should be less noisy.

aswinsuryan

comment created time in 3 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

pull request commentsubmariner-io/submariner-website

Quickstart for LB mode on GCP Cloud

@sridhargaddam were you able to test this successfully with GCP?

Yes @nyechiel

sridhargaddam

comment created time in 4 days

PullRequestReviewEvent

Pull request review commentsubmariner-io/shipyard

Default to Kubernetes 1.19, test 1.22, drop older

 jobs:           - project: submariner             cabledriver: wireguard             deploytool: operator-            k8s_version: '1.17'-          # Test multiple K8s versions only in submariner-operator, balancing coverage and jobs-          - project: submariner-operator-            k8s_version: '1.18'-          - project: submariner-operator             k8s_version: '1.19'+          # Test multiple K8s versions only in submariner-operator, balancing coverage and jobs           - project: submariner-operator             k8s_version: '1.20'+          - project: submariner-operator+            k8s_version: '1.22'

Just curious: Any specific reason we are skipping k8s version 1.21?

skitt

comment created time in 4 days

push eventsridhargaddam/submariner-website

Sridhar Gaddam

commit sha b1582fc8465c4c3a61d95ac13ad6ab06efca7cea

Quickstart for LB mode on GCP Cloud Submariner supports loadbalancer mode for gateway node, but currently this implementation on AWS is having some issues. The same functionality on GCP works fine. This PR updates the quick start guide to GCP cloud. Signed-Off-by: Sridhar Gaddam <sgaddam@redhat.com>

view details

push time in 4 days

PR opened submariner-io/submariner-website

Quickstart for LB mode on GCP Cloud

Submariner supports loadbalancer mode for gateway node, but currently this implementation on AWS is having some issues. The same functionality on GCP works fine. This PR updates the quick start guide to GCP cloud.

Signed-Off-by: Sridhar Gaddam sgaddam@redhat.com

+28 -7

0 comment

5 changed files

pr created time in 4 days

create barnchsridhargaddam/submariner-website

branch : gcp-lb

created branch time in 4 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventsridhargaddam/submariner-operator

Mike Kolesnik

commit sha 5ee9ba22522598df78a8d472e797e48181c077f5

Remove subctl release job Since v0.8.0 the subctl binaries are being released on [1] so there's no need to build and release them here as well. [1] https://github.com/submariner-io/releases/releases Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>

view details

Sridhar Gaddam

commit sha 1326edbe9fb8fb330e8d284af05b13dd112e260f

Include the node details as part of summary report Currently when subctl gather collects the information from the cluster, it does not store the node details which is sometimes necessary during debugging. This PR removes the following info and instead includes the node details Removed fields: ContainerRuntimeVersion KubeletVersion Added fields: Node InternalIP Node ExternalIP Node Name on which the Submariner pods are scheduled. Fixes issue: https://github.com/submariner-io/submariner-operator/issues/1623 Signed-Off-by: Sridhar Gaddam <sgaddam@redhat.com>

view details

push time in 5 days

push eventsridhargaddam/submariner-operator

Sridhar Gaddam

commit sha cadd0519d38d8ecdd1cfbd8b65b8768a08afd7aa

Include the node details as part of summary report Currently when subctl gather collects the information from the cluster, it does not store the node details which is sometimes necessary during debugging. This PR removes the following info and instead includes the node details Removed fields: ContainerRuntimeVersion KubeletVersion Added fields: Node InternalIP Node ExternalIP Node Name on which the Submariner pods are scheduled. Fixes issue: https://github.com/submariner-io/submariner-operator/issues/1623 Signed-Off-by: Sridhar Gaddam <sgaddam@redhat.com>

view details

push time in 5 days

PR opened submariner-io/submariner-operator

Include the node details as part of summary report

Currently when subctl gather collects the information from the cluster, it does not store the node details which is sometimes necessary during debugging. This PR removes the following info and instead includes the node details

Removed fields: ContainerRuntimeVersion KubeletVersion

Added fields: Node InternalIP Node ExternalIP Node Name on which the Submariner pods are scheduled.

Fixes issue: https://github.com/submariner-io/submariner-operator/issues/1623 Signed-Off-by: Sridhar Gaddam sgaddam@redhat.com

<!-- Thanks for sending a pull request! Here are some tips for you:

  1. If this is your first time, please read our developer guide: https://submariner.io/development/
  2. Ensure you have added the appropriate tests for your PR: https://submariner.io/development/code-review/#test-new-functionality
  3. Read the code review guide to ease the review process: https://submariner.io/development/code-review/
  4. If the PR is unfinished, mark it as a draft: https://submariner.io/development/code-review/#mark-work-in-progress-prs-as-drafts
  5. If you are using CI to debug, use your private fork: https://submariner.io/development/code-review/#use-private-forks-for-debugging-prs-by-running-ci
  6. Add labels to the PR as appropriate.

This template is based on the K8s/K8s template:

https://github.com/kubernetes/kubernetes/blob/master/.github/PULL_REQUEST_TEMPLATE.md -->

+38 -13

0 comment

4 changed files

pr created time in 5 days

create barnchsridhargaddam/submariner-operator

branch : issue-1623

created branch time in 5 days

issue openedsubmariner-io/submariner-operator

subctl gather should include the node details as part of summary report

Currently when subctl gather collects the information from the cluster, it does not store the node details which is sometimes necessary during debugging.

created time in 5 days

push eventsubmariner-io/submariner-operator

Sridhar Gaddam

commit sha b56ba05144d325b8213d8ddedf6f14468298c98d

Fix subctl diagnose intra-cluster vxlan issue Fixes issue: https://github.com/open-cluster-management/backlog/issues/17124 Signed-Off-by: Sridhar Gaddam <sgaddam@redhat.com>

view details

push time in 8 days

PR merged submariner-io/submariner-operator

Reviewers
Fix subctl diagnose intra-cluster vxlan issue ready-to-test

Fixes issue: https://github.com/open-cluster-management/backlog/issues/17124 Signed-Off-by: Sridhar Gaddam sgaddam@redhat.com

<!-- Thanks for sending a pull request! Here are some tips for you:

  1. If this is your first time, please read our developer guide: https://submariner.io/development/
  2. Ensure you have added the appropriate tests for your PR: https://submariner.io/development/code-review/#test-new-functionality
  3. Read the code review guide to ease the review process: https://submariner.io/development/code-review/
  4. If the PR is unfinished, mark it as a draft: https://submariner.io/development/code-review/#mark-work-in-progress-prs-as-drafts
  5. If you are using CI to debug, use your private fork: https://submariner.io/development/code-review/#use-private-forks-for-debugging-prs-by-running-ci
  6. Add labels to the PR as appropriate.

This template is based on the K8s/K8s template:

https://github.com/kubernetes/kubernetes/blob/master/.github/PULL_REQUEST_TEMPLATE.md -->

+2 -2

1 comment

1 changed file

sridhargaddam

pr closed time in 8 days