sourcegraph/javascript-typescript-langserver 800
JavaScript and TypeScript code intelligence through the Language Server Protocol
sorbo/tcpcrypt 219
Fast TCP encryption
codecov/sourcegraph-codecov 50
See code coverage information from Codecov on GitHub, Sourcegraph, and other tools.
Extended JSON parser and writer for Go
Generate Markdown documentation from a JSON Schema
(NOTE: This has been merged into Avro trunk, in lang/js. Use that code from now on.) Avro JSON validator and Javascript record builder
A small, fast, JavaScript-based JavaScript parser
Apache httpd + TLS-SRP
Avro flat map encoder and decoder (for storing nested Avro data structures in flat key-value stores)
counter
push eventsourcegraph/sourcegraph
commit sha ebae869f1fad2546822772e93694aa2bb6d2fd06
wip
commit sha 0e9295eea4f3b4971529e5e10d658e1b7888a4ba
fix issue preventing more than 1 theme cycle via keyboard shortcut The keyboard shortcut Option+T/Alt+T/Meta+T cycles between the light and dark themes. It was broken: it worked the first time after the page load, but it did not work on subsequent times. The issue is fixed by using a functional setter for the state value.
commit sha 6ba58057a536ae00fd77781246d6a56bf564ad14
wip
push time in 3 days
push eventsourcegraph/sourcegraph
commit sha ac6bee0763a5883e9cdb9054ca7965c2c7cba5ff
Add error handling for not found changesets from GitHub (#14771) * Make it work for GitHub * Add explicit import op in reconciler * Make code easier to understand * Fix build and cleanup * Add error handler for gitlab * Fix linter warning * Fix broken test * Remove dead code * Minor renames in reconciler Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
commit sha 34f42c199a4cbd8d51890ba210a813f92828da30
campaigns: fix icon display on navbars (#14967) * campaigns: fix icon display on navbars Both the global and namespace navbars were using subtly (or not so subtly) incorrect versions of the campaigns icon. This metaphorically aligns them with the intended versions, and also adds the required viewbox tweaks to literally align them with the other icons in their respective navbars. * Update snapshots.
commit sha ab28bccae088f54221c8bbcb588f6af72eeedbbf
perms: update test to cover no-update case (#14973)
commit sha 111805bd52694f0d91301d846207e3233e6cdf72
Fix how imported-but-not-found changesets are displayed (#14978) * Fix how imported-but-not-found changesets are displayed This changes the ExternalChangesetInfoCell to not show the `()` when the changeset couldn't be found. It also updates the story to include an imported-but-not-found changeset and makes them more accurate by setting `diff: null`. * Simplify check for import/import-failed * Fix lint warnings
commit sha f7608c1a479f4861da1f37f3bcd22bbc855cc950
Faster SetClonedRepos query (#14981) This PR improves and simplifies the SetClonedRepos query. It also removes the repoSetClonedBatchSize setting that was introduced in 3.21.0 and that is no longer necessary. Co-authored-by: Tomás Senart tomas@sourcegraph.com
commit sha f70a26d757257824c0ea0f44121248346a4f1de7
Handle clone situations where HEAD is invalid (#14962) Try to ensure a meaningful HEAD file after cloning. In some situations, it appears that empty repos may wind up with a truncated `HEAD` file on disk for reasons unknown. That breaks the repositories view (among other things), and is not easily recoverable within the Sourcegraph application (fixing the repository or deleting it and re-cloning are the current suggestions). To begin addressing that, this change: 1. Introduces an `ensureHead` function that will create a `HEAD` file with a default if the file is absent or blank. 2. Introduces a `testRepoCorrupter` that tests can use to inject repo-level faults. 3. Adds a number of tests to verify the overall clone behavior with and without protections. I wasn't able to trick git into cloning a repo that was truly busted, so I opted instead for fault injection. The repo is checked out to a temporary location first, and alongside the bad ref cleanup it will check `HEAD` presence and try to take a compensating action if necessary. fixes https://github.com/sourcegraph/customer/issues/116
commit sha 89600bf602242ef66a741589b5bf784e378e5ead
search: trigger suggestions on printable ASCII (#14982) We noticed that search suggestions were not triggering after spacebar. There are many useful suggestions (such as filters to use) that should appear. We should trigger suggestions on any character press. However, Monaco requires an explicit trigger list. So instead we include all printable ASCII characters, and most of the "extended ASCII table" (Latin-1). Co-authored-by: Erik Seliger <erik@sourcegraph.com>
commit sha ce3c397e5c4953b943f26c8ad951ea14b8249434
repo-updater: Use config value repoListUpdateInterval (#14983) This value was previously used to specify how frequently we would sync with code hosts so it makes sense to reuse it to set a lower bound on how often we sync now that we have backoff logic.
commit sha 23aa24b9a293ae00d8571d60294efa435afafdcf
update changelog for 3.21.1 (#14984)
commit sha 753d102d31b6316f50ce24cf5763b8d02a51caf1
Fix browser extension end-to-end tests (#14960)
commit sha 9934dd18cee4031c398cb21a336170fa6cec6247
Final fixes for the browser extension (#14958)
commit sha d6fd366811cd2a95629219f9ca9acd04062ace0d
update changelog for 3.21.1 (#14987)
commit sha 701f322074a9a94402caa8deeb0fda08655e8842
Fix externalURLs alert logic (#14980)
commit sha 75f3709f76d6ef59f7f4466472a3f459eaf2fbf7
Don't use truncate in gitserver tests (#14986) * Don't use truncate in gitserver tests. @unknwon pointed out that `truncate` is not guaranteed to be available (e.g macOS), so this swaps that out for a builtin redirection that will accomplish the same thing: $ echo 'hello' > hello.txt $ cat hello.txt hello $ : > hello.txt $ cat hello.txt ref https://github.com/sourcegraph/sourcegraph/pull/14962#discussion_r510291290 * Empty commit to nudge CI
commit sha 66018f2bebcfc9df8a28d25121d09ae1cb545284
Revert "destroy dangling vagrant boxes (#14961)" (#14988) This reverts commit 22f1692018c738089655b3e4cd48fc067ffc5dab.
commit sha 7aa392d7b7189eeee131be5c6c26dd1f660dfae7
fix: Fix server upgrade from 3.21.0 -> 3.21.1 (#14992)
commit sha 375db1f51bb6feb3083481c33d9b313f81506d96
update compose doc and handler version (#15000)
commit sha f539198477321adf4970863f6df74caadf7968d4
Update latest release to 3.21.1 (#15001)
commit sha 44004287a82809935a72a9ce76d2156900db4f11
doc: add redirects for code intel hover links (#15006)
commit sha ace3085772b2c092bb79d85f9af92ddbf8a1abc2
docs: make all search pages work on dark background (#14932)
push time in 3 days
push eventsourcegraph/sourcegraph
commit sha 57b0548033bdb686ec96bcf265bffead4f7f4d32
remove remaining component-specific theming (#14934)
push time in 5 days
PR merged sourcegraph/sourcegraph
Now, virtually all components use standard CSS vars for theme colors instead of defining their own arbitrary color choices for light and dark themes.
c2e01a8a1b (Quinn Slack, 34 minutes ago) remove unused DecoratedTextLines
d440784a68 (Quinn Slack, 35 minutes ago) remove unused CommitSearchResult
pr closed time in 5 days
Pull request review commentsourcegraph/sourcegraph
remove remaining component-specific theming
display: flex; } + // Custom icons are <img src> URLs. We can't use .icon-inline for these, because CSS can't style+ // SVGs included with <img src>. So, use CSS filters to make the icons light (in dark themes) and+ // dark (in light themes).
agreed
comment created time in 5 days
Pull request review commentsourcegraph/sourcegraph
remove remaining component-specific theming
min-width: 2rem; user-select: none; vertical-align: top;-- .theme-dark & {- color: $gray-18;- }- .theme-light & {- color: $gray-05;- }+ color: var(--text-muted-2);
No, that is not enough contrast, but I renamed this CSS var to --line-number-color.
comment created time in 5 days
Pull request review commentsourcegraph/sourcegraph
remove remaining component-specific theming
$text-muted: var(--text-muted); --color-bg-4: #{$gray-02}; --color-bg-5: #{$gray-13}; --text-muted: #6d727c;+ --text-muted-2: #{$gray-05};
This was only used in 1 place, so I just renamed it to --line-number-color.
comment created time in 5 days
push eventsourcegraph/sourcegraph
commit sha b9d8feb9e1353e97d72cd61bfdc4d15aa250333e
add --line-number-color CSS var
push time in 5 days
Pull request review commentsourcegraph/sourcegraph
remove remaining component-specific theming
bottom: 0; left: 0; - box-shadow: 0 0 0 6px rgba(36, 110, 51, 0.7);- opacity: 0; transition: opacity 500ms;++ .theme-light & {+ box-shadow: 0 0 0 6px rgba(199, 233, 205, 0.7);
I made this use $success and it appears indistinguishable to me and simplifies the CSS.
comment created time in 5 days
Pull request review commentsourcegraph/sourcegraph
remove remaining component-specific theming
} &--enabled {- background-color: rgba(36, 110, 51, 0.2);+ .theme-light & {+ background-color: rgba(199, 233, 205, 0.2);+ }+ .theme-dark & {+ background-color: rgba(36, 110, 51, 0.2);
The alert-success class is already applied on the element in TSX. The purpose of this CSS is to set the background-color opacity to 0.2 (and there is some color variation as well).
I did simplify this and the below using $success instead of the slightly different colors for dark and light themes.
comment created time in 5 days
push eventsourcegraph/sourcegraph
commit sha d8fa4dffa8634a99750b64cfc1b31fd65b941639
use $success
push time in 5 days
Pull request review commentsourcegraph/sourcegraph
remove remaining component-specific theming
.page-header { &__icon {- color: $gray-11;- .theme-light & {- color: $gray-13;- }+ opacity: 0.65; // slightly faded relative to header text
Added --header-icon-color CSS var
comment created time in 5 days
push eventsourcegraph/sourcegraph
commit sha 2b86e43937ed18d431f5c81e2ca69df65f87d2f1
add --header-icon-color CSS var
push time in 5 days
push eventsourcegraph/sourcegraph
commit sha 233f001383999c873133b1ef99e8f1ab8ef77b63
remove remaining component-specific theming Now, virtually all components use standard CSS vars for theme colors instead of defining their own arbitrary color choices for light and dark themes.
push time in 5 days
push eventsourcegraph/sourcegraph
commit sha 469f6110a6d12f1c8736fcb53bde74ef0bb6bd60
Design debt issue template (#14887) * Design debt issue template This template will make describing the design debt issues easier. When reviewing, please, pay attention to the comments in the template. * Typo fix Co-authored-by: Christina Forney <christina@sourcegraph.com> Co-authored-by: Christina Forney <christina@sourcegraph.com>
commit sha 1b8cbfe7e79d9c205463d5456a4cdc04c47ecf41
Typo fix (#14937)
commit sha 8b00824d13ce6a2fd03196c7fed4843596ff3ebc
Make stacking contexts explicit (#14854)
commit sha 80337369ac9b73a5452eaecbe19aefe5cf2b3251
chore: move up licensing package (#14940)
commit sha 2a4c4b45db94cc7df0df8a28b73499689e2d8139
Fix SetClonedRepos (#14944) The temporary table seems to make the query hang forever whenever we reach about 100k repos in it. This PR uses the previous query as it seems to not have this issue. This will fix the problem while we figure out what was wrong with the current query.
commit sha 732daaa6aa2d9d08479037e399817814d929f129
db: Drop repo.language (#14942) The column has been deprecated for a long time: https://github.com/sourcegraph/sourcegraph/issues/2586
commit sha 80d3ee154e6b6dd52367a53bbb5368ac3653da0c
secret: remove abandoned secret key file on start (#14948)
commit sha b49b1f0e1a4f12d3b10bef67ebf3f986a7c6ea5a
secret: only turn on encryption when the env var is explicitly specified (#14947)
commit sha b5ef7c1ad6ecd5e214816d57ff3d484e3e8343cd
Add missing mocks to search integration tests (#14951) Fixes #14869
commit sha a3e3dea7f601e0ead4870587da8fa18563e8371b
licensing: enforce repository permissions (#14943)
commit sha 587a4b8310b7657f3753c92d7aadce0432e7c3ce
Clean up `<code>` styles (#14817) Add a CSS var `--code-bg` that is used in CodeSnippet and Markdown code blocks. (Because it's used in 2 places, a CSS var is used instead of just `--color-bg-2`.) Also fix a bug where the CodeExcerpt style was not actually applied in the storybook because only the global stylesheet was being loaded.
commit sha d7745aba10cc3ed8c742d08b24a8a7189dcbd0eb
Remove batch functionality from sync-changeset subsystem (#14950) * Remove batch functionality from sync-changeset subsystem * Remove LoadPullRequests in favor of LoadPullRequest * Fix webhooks tests * Fix changeset counts test * Cleanup docs and error * Fix test properly * Fix fixture file Co-authored-by: Erik Seliger <erikseliger@me.com>
commit sha 26cd3ffc2a786d22d61fd99efc42a9475ffd50ce
Add meta tag for color-scheme (#14936)
commit sha a9cbad1d8608bc950a0e30371c1c53b8834f7780
pin latest version of build image (#14954)
commit sha dd34091ed7d0d59c2a8805f2b258fb61fffe2fe7
server: Fix upgrade from 3.20 -> 3.21 (#14953)
commit sha ab9da46eba5a630585b0769270777f429571ae52
Update browser extension icon state on private repositories (#14926)
commit sha 7b269de885c6939d6739484e5981d2cdcf8144d0
search: fix colon pattern in structural hole (#14931)
commit sha dd7faa4c27b9e69d7ada674a84c39f7fa6e9ca09
Update dependency @sourcegraph/eslint-config to ^0.20.12 (#14959) Co-authored-by: Renovate Bot <bot@renovateapp.com>
commit sha 22f1692018c738089655b3e4cd48fc067ffc5dab
destroy dangling vagrant boxes (#14961)
commit sha eceb1cd9065249fabf0b50936300a59e0de4cdb2
oauth: use service ID + client ID as the provider config ID (#14949)
push time in 5 days
Pull request review commentsourcegraph/sourcegraph
remove remaining component-specific theming
export const SearchPage: React.FunctionComponent<SearchPageProps> = props => { return ( <div className="web-content search-page d-flex flex-column align-items-center pb-5"> <BrandLogo className="search-page__logo" isLightTheme={props.isLightTheme} variant="logo" />- {props.isSourcegraphDotCom && <div className="search-page__cloud-tag-line">Search public code</div>}+ {!props.isSourcegraphDotCom && <div className="text-muted mt-3">Search public code</div>}
whooooooooops, the inversion was for testing, thanks for catching
comment created time in 5 days
push eventsourcegraph/sourcegraph
commit sha 95fee8bd48756f13dfe27fa7934a99ba16db2cfa
Add storybook for HierarchicalLocationsView, remove hardcoded theme colors (#14818)
push time in 5 days
PR merged sourcegraph/sourcegraph
<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->
pr closed time in 5 days
PR merged sourcegraph/sourcegraph
Add a CSS var --code-bg that is used in CodeSnippet and Markdown code blocks. (Because it's used in 2 places, a CSS var is used instead of just --color-bg-2.)
Also fix a bug where the CodeExcerpt style was not actually applied in the storybook because only the global stylesheet was being loaded.
<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->
pr closed time in 5 days
push eventsourcegraph/sourcegraph
commit sha 587a4b8310b7657f3753c92d7aadce0432e7c3ce
Clean up `<code>` styles (#14817) Add a CSS var `--code-bg` that is used in CodeSnippet and Markdown code blocks. (Because it's used in 2 places, a CSS var is used instead of just `--color-bg-2`.) Also fix a bug where the CodeExcerpt style was not actually applied in the storybook because only the global stylesheet was being loaded.
push time in 5 days
Pull request review commentsourcegraph/sourcegraph
$code-font-family: sfmono-regular, consolas, menlo, dejavu sans mono, monospace; $code-font-size: 12px; +.theme-dark {+ --code-bg: var(--color-bg-2);+}++.theme-light {+ --code-bg: var(--color-bg-2);+}
This is not possible. The var is not set on :root, only on .theme-light and .theme-dark, and the way that CSS custom properties work is to not carry "var references" forward to the point of evaluation.
comment created time in 5 days
push eventsourcegraph/sourcegraph
commit sha e4958b671babc04d515ab4dda52d0a6b4f1ab1c7
Elevate product areas in documentation (#14792)
commit sha 6483cb33d8381fb151f375bcc29584e2c6a7b92c
Implement `getText` for extension API (#14741) `getText` returns text within the provided range
commit sha 0d430eaf3389a2f9dda9fb31929982f96dd10988
web: add height and width to img allowlist (#14846)
commit sha 55a7744037f839d847465859bfa29e87d6c7a586
repo-updater: Remove deprecated Language field (#14801) The field has already been removed from types.Repo so it should be removed from repos.Repo too.
commit sha e452e2d17ed9dff65ea9afdb9bdfca456248fe68
chore: Fix typo in usage documentation (#14841)
commit sha 2701d1112c65d3ff14b50500a4c6b1b74a6f6947
internal: Add base configuration object (#14836)
commit sha 3e1d578c68937f730daedba5e42635d0d579d502
tracking-issue: Fix display of depriorized issues (#14815)
commit sha 50d72c8b6bda1f9c60794f2e1d47a99d7a66d963
codenotify: Update db package (#14842)
commit sha d19243f57d53bfe943f22403003a5f656f5d85f6
workerutil: Add SetLogContents to store (#14837)
commit sha 1cde9f90e65977419ff30fed909ae41128ddca7c
ensure we have commits locally before finding common merge-base (#14737) * ensure we have commits locally before finding common merge-base * Update cmd/frontend/graphqlbackend/repository_comparison.go Co-authored-by: Thorsten Ball <mrnugget@gmail.com> * fix broken test (adds mock for git.ResolveRevision) * remove unneeded code * formatting code * removing unused mock Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
commit sha cae57306fec2129806fcb3fd41cd7e04e221d1ef
docker-images: Install src-cli in ignite-ubuntu base image (#14839)
commit sha d4b31dcd92bd2a4673ac60c45c722aad8b8de0ed
workerutil: Add QueuedCount to store (#14838)
commit sha ade9cd29f182b0d33f42d1ef4d16e9ca0d3ccd5d
chore: Add additional utils for interacting with goroutines (#14840)
commit sha f882bb5a837ed5648d70ebce82369f0152ef3279
Make sure that global test DB is setup in campaigns integration test (#14859) The test makes use of the global test DB by calling `repos.List` etc. but it only worked when another test setup the global test database.
commit sha 85e8556adac3775e1f784a1c34f716073fc037f1
chore: Move handler out of workerutil options (#14861)
commit sha 61d1c607a892caeb3f799a0ecb9c29dbdef7fc0c
Fix build by bumping nginx in server image to 1.18.0-r1 (#14860) * Fix build by bumping nginx in server image to 1.18.0-r1 Build failure looks like 1.18.0-r0 has been bumped to 1.18.0-r1 in the alpine repository: https://buildkite.com/sourcegraph/sourcegraph/builds/76932#caad483b-e9b5-41dc-9077-cb091bd80769 * Update cmd/server/Dockerfile Co-authored-by: Gonzalo Peci <pecigonzalo@users.noreply.github.com> Co-authored-by: Gonzalo Peci <pecigonzalo@users.noreply.github.com>
commit sha ce7a84a52c041ca926f29d122a6f085fc7e8b896
search: shortcircuit on count for search expressions (#14816)
commit sha eba3d69aba0c28c123297b49c41196cf6fbfdc30
syntax highlighting: improve comment contrast, add GraphQL highlighting (#14814) * syntax highlighting: improve comment contrast, add GraphQL highlighting This updates syntect_server for two changes: - A change by @rrhyne to improve comment contrast (primarily in light theme): https://github.com/slimsag/syntect/pull/7 - An awesome change by @rvantonder - adding his new open-source GraphQL syntax: https://github.com/slimsag/Packages/pull/4 Helps https://github.com/sourcegraph/sourcegraph/issues/14546 Fixes https://github.com/sourcegraph/sourcegraph/issues/13935 * CHANGELOG update
commit sha 4b2fd9912f2bb92a94cfeb44f3437429a45763a0
Implement UI display and burndown chart calculation for GitHub draft mode (#14742) - Extends the ExternalChangesetState by DRAFT (plus UI representation) - Adds drafts to the calculation of historic changeset data - Exposes the number of drafts on the changesets.stats and on the changesetCountsOverTime fields
commit sha 6c2bfa9f7268bee61e59eee6eaca3eae80433d9a
codeintel: add envvars for code intel DB (#14873) * add envvars for code intel DB * enterprise: add envvars for codeitnel DB
push time in 5 days
Pull request review commentsourcegraph/sourcegraph
Add storybook for HierarchicalLocationsView, remove hardcoded theme colors
const parsePosition = (string: string): Position => { */ export function parseRepoURI(uri: RepoURI): ParsedRepoURI { const parsed = new URL(uri)- const repoName = parsed.hostname + parsed.pathname+ const repoName = parsed.hostname + parsed.pathname.replace(/^\/\//, '')
Ah, I forgot to extract this and deal with it separately. I will remove it from this PR.
In storybooks, there is no URL polyfill, so it treats git:// URIs as having a pathname of //example.com/foo and no hostname. In the main app, our URL polyfill (incorrectly per the spec) treats URIs of all schemes the same, so this is not needed. The reason I included this change here is that the storybook for this component would show the repo name as //github.com/foo/bar, which was weird. But this is a bigger change and should not be in this PR.
BTW, I think it would be good to completely remove these git:// URIs from this part of our app if possible (and probably even everywhere). What do you think?
comment created time in 5 days
pull request commentsourcegraph/sourcegraph
docs: update search assets to work on dark background
You could try using CSS filter: brightness(N%) and maybe hue-rotate(180deg) too to make a white-foreground PNG dark in the light theme, without needing to upload duplicate images.
comment created time in 6 days
PR opened sourcegraph/sourcegraph
Now, virtually all components use standard CSS vars for theme colors instead of defining their own arbitrary color choices for light and dark themes.
c2e01a8a1b (Quinn Slack, 34 minutes ago) remove unused DecoratedTextLines
d440784a68 (Quinn Slack, 35 minutes ago) remove unused CommitSearchResult
pr created time in 6 days
push eventsourcegraph/sourcegraph
commit sha d440784a680258b787ddfc3932b100bf4b3f18ea
remove unused CommitSearchResult
commit sha c2e01a8a1b89aba4e858c49d508a82c33336f716
remove unused DecoratedTextLines
commit sha 1a7f71894b07391d54f620dc6853eee289c44d2d
remove remaining component-specific theming Now, virtually all components use standard CSS vars for theme colors instead of defining their own arbitrary color choices for light and dark themes.
push time in 6 days
push eventsourcegraph/sourcegraph
commit sha b126254f05704fc81b689cd934c28f025da105de
Clean up code styles Add a CSS var `--code-bg` that is used in CodeSnippet and Markdown code blocks. (Because it's used in 2 places, a CSS var is used instead of just `--color-bg-2`.) Also fix a bug where the CodeExcerpt style was not actually applied in the storybook because only the global stylesheet was being loaded.
push time in 6 days
push eventsourcegraph/about
commit sha aa46cf14c6ffb1863d619b635bfaab6c9633fac3
add a space
push time in 6 days
push eventsourcegraph/about
commit sha b2437c680e1456c0e627a9aa35e3fefa2256e6f4
link to the new file
push time in 6 days
push eventsourcegraph/about
commit sha 630c1b8c430782cb5f4f0e14b6a1a930c9563d7c
add test_folder index.md
push time in 6 days
push eventsourcegraph/sourcegraph
commit sha 96eb24e5e0e52492f6e5236306002ba2ff4fac49
Clean up code styles Add a CSS var `--code-bg` that is used in CodeSnippet and Markdown code blocks. (Because it's used in 2 places, a CSS var is used instead of just `--color-bg-2`.) Also fix a bug where the CodeExcerpt style was not actually applied in the storybook because only the global stylesheet was being loaded.
push time in 6 days
push eventsourcegraph/sourcegraph
commit sha 3818d5806d558c7b2cfeae96aaedc02e6c802eb5
Clean up CSS border color styles (#14829) Previously, we had many ways of setting border colors: - Sometimes the hex color values would be used directly, and a component would define its own light and dark theme variants. This leads to inconsistent color usage, adds code complexity, and is mistake-prone. - We had `$color-border`, `$color-border-2`, `$border-color`, `--border-color`, etc. Now we just have `--border-color` and `--border-color-2` (dimmer, rarely used). Some components' borders will have slightly different colors after this change if they previously used a non-standard border color.
commit sha 0b47ecd167e27d6353c5cec921da379f60eedd20
monitoring: improve solutions formatting, add team information (#14878)
commit sha 3412c0ccdc716a8768570afe1334b849d8a5bdec
Enabling container scans with anchore (#14767) Co-authored-by: Chayim I. Kirshen <chayim@gnupower.net>
commit sha decd7defbffb0d65b48420240faec3ed8362d714
Fix integration test dispose() flakiness (#14872)
commit sha 1de0e27ae012c68e26f7bd3e55320261e5f4ce7f
Run paginated queries in SetClonedRepos (#14793)
commit sha de47c9d7f7585c67f8206c39580bc420934a1b7c
Add support for GitHub review webhooks (#14862) This PR adds support for the GitHub webhook events required to support real-time draft mode changes.
commit sha 6bc339d83cafddd571d9f1af37592bceeec15f94
Fix breadcrumbs file path truncation wrapping (#14855)
commit sha 80ae6ebeb4c8b35a316a5dcc3b7a30b10ce25e25
gitlab: wrap response error instead of swallow it (#14903)
commit sha 6ac24a64cba3abc80eca0f46a2256168eb2fc702
Configure better Percy widths (#14902)
commit sha 8f7192e30b90d75afe0fa1c1a023cea4a05e9912
repo-updater: Convert DBStore to basestore (#14901) * repo-updater: Convert DBStore to basestore * Remove outdated comment * Fixed deferred error
commit sha a2cdfe9f60cbaf994c488921834d2e007372a25d
workflows: add automerge workflow, set licenses updates to automerge (#14914)
commit sha c9a570a6cd9c34dd4ff64d22bed55d0618406693
extsvc: replace `http.DefaultClient` with `httpcli.ExternalDoer` (#14904)
commit sha 0d72a9491f5cf2de788b30a70eee60e1b43e0083
Clean up CSS text color styles (#14847)
commit sha a2f5f853b468048d284376a582c8e44e88499866
Update label-notify.yml (#14753)
commit sha 4f670539657358f4712142ba751764fa1e33acdb
Remove Campaigns beta flag (#14900) * Remove Campaigns beta flag This removes the beta flag from campaign. Yesterday, in a discussion with Chris, Quinn S., Christina and Rob we decided that we shouldn't keep pushing that "remove beta-flag"-milestone in front of us. We think the product is ready to be used by more customers and our primary goal is to grow adoption. That means it's no longer in beta. Of course we'll still iterate and refine and improve campaigns, that's out of the question. So, let's get rid of this artificial barrier and milestone and focus on the *actual goal*: getting campaigns into the hands of more customers. * Add PR number to changelog entry * Update client/web/src/enterprise/campaigns/list/CampaignListPage.tsx Co-authored-by: Erik Seliger <erikseliger@me.com> * Update snapshots Co-authored-by: Erik Seliger <erikseliger@me.com>
commit sha 90ff099f026a88b8ea45210c1438d06df38fc0fb
web: allow align attribute for markdown images (#14876)
commit sha 779b1210018bcad5074624a29a8219bbe089c0be
clean up UserArea, UserSettingsProfilePage, user header, updateUser mutation (#14397) * clean up UserArea, UserSettingsProfilePage, user header, updateUser mutation This is mostly a cleanup of tech debt. - Move the user event log tab into the user settings sidebar. Let's use the tabs (which are quite prominent) in the user area for things that users need in their usual workflow, not for site admin and audit stuff. - Make the GraphQL mutation `updateUser` return a `User` instead of `EmptyResponse` so the caller can get the newly updated user in the same query. This is how most of our other mutations work. - Clean up the UserArea code: make it a function component, remove needless props, etc. - Clean up the page for editing a user's profile. The GraphQL change is technically a breaking change, but I don't see any usage of the `updateUser` mutation outside of the app itself. The `src` CLI does not expose a command for `updateUser` either. * move event log from tabs to sidebar * remove old import Co-authored-by: TJ Kandala <kandalatj@gmail.com>
commit sha 36c6392063dd685a2ccc4788feeace63e14d9153
Add support for draft changesets in reconciler (#14807) * Implement publishDraft action in reconciler In this commit, I've done the plumbing necessary to make draft changeset publishing possible. It contains: - New method to determine if a codehost has a capability, and a config map that makes a global place to document them. - Introduce a DraftChangesetSource, so that only ChangesetSources that actually support Draft mode need to implement it. - Adds reconciler tests for publishDraft. - Adds more lightweight determineAction tests, that can assert the reconciler action has been determined correctly. * Implement undraft reconciler action This adds the second bit to the reconciler: Moving a changeset from being a draft to being fully published. In this chunk: - Extend the DraftChangesetSource by a UndraftChangeset method. This is implemented on the GitHub source and client. - Extend the reconciler integration tests and the newly added determineAction test suite. - Add a temporary undraft-update reconciler action. This will not stay, and will be gone in the next commit already. The main purpose of adding it here is to make it work, so I can validate it does what it's supposed to and can write tests, that should not break in the refactor in the next commit. This state is currently flawed and doesn't support all edge-cases where the changeset might need to be moved out of draft mode. Some of them are - attributes don't change (likely to happen) - reopen without update won't respect the update - does unnecessary updates to the changeset on the codehost, when only the published flag changed * Reorganize reconciler action handlers For the "undraft" action, I needed to create a lot of additional actionTypes, which led to a big bloat in the code. "reopenUpdraft", "updateUndraft", "undraft" all basically did the same, but needed to be separate actions. The new structure builds up a list of actions that need to be taken. Then, it orders them in an execution order that makes sense (ie. not sync before update, update before undraft, so the latest PR description, .. will go out in the notification emails). After that, all the actions are performed serially, but they don't all contain the upsert logic. After all actions are done, the changeset is either upserted, or synced with the codehost, depending on what makes the most sense. Moving this logic out of the handlers makes the separate actions more composable, so I could build things like {reopen, undraft}.
commit sha ba34bd2d4100848c9471a6a509ea9a9cfcc51692
Clean up CSS background color styles (#14852)
commit sha 63d0e5456bacbc5be6e0bb25b199fa914ec6f1e7
Update latest release to 3.21.0 (#14880)
push time in 6 days
push eventsourcegraph/sourcegraph
commit sha ba34bd2d4100848c9471a6a509ea9a9cfcc51692
Clean up CSS background color styles (#14852)
push time in 6 days
PR merged sourcegraph/sourcegraph
Standardizes how components declare background colors. No components declare their own custom theme colors for backgrounds anymore; now they use CSS custom properties that can change based on the user's selected theme.
There will be minor changes to the background colors used in various components, but no (intentional) major changes. If we want to tweak colors further, we'll just need to introduce more variables that themes define (which is super easy).
Similar to #14847 and #14829.
<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->
pr closed time in 6 days
push eventsourcegraph/sourcegraph
commit sha 779b1210018bcad5074624a29a8219bbe089c0be
clean up UserArea, UserSettingsProfilePage, user header, updateUser mutation (#14397) * clean up UserArea, UserSettingsProfilePage, user header, updateUser mutation This is mostly a cleanup of tech debt. - Move the user event log tab into the user settings sidebar. Let's use the tabs (which are quite prominent) in the user area for things that users need in their usual workflow, not for site admin and audit stuff. - Make the GraphQL mutation `updateUser` return a `User` instead of `EmptyResponse` so the caller can get the newly updated user in the same query. This is how most of our other mutations work. - Clean up the UserArea code: make it a function component, remove needless props, etc. - Clean up the page for editing a user's profile. The GraphQL change is technically a breaking change, but I don't see any usage of the `updateUser` mutation outside of the app itself. The `src` CLI does not expose a command for `updateUser` either. * move event log from tabs to sidebar * remove old import Co-authored-by: TJ Kandala <kandalatj@gmail.com>
push time in 6 days
PR merged sourcegraph/sourcegraph
This is mostly a cleanup of tech debt.
- Move the user event log tab into the user settings sidebar. Let's use the tabs (which are quite prominent) in the user area for things that users need in their usual workflow, not for site admin and audit stuff.
- Make the GraphQL mutation
updateUserreturn aUserinstead ofEmptyResponseso the caller can get the newly updated user in the same query. This is how most of our other mutations work. - Clean up the UserArea code: make it a function component, remove needless props, etc.
- Clean up the page for editing a user's profile.
The GraphQL change is technically a breaking change, but I don't see any usage of the updateUser mutation outside of the app itself. The src CLI does not expose a command for updateUser either.
<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->
pr closed time in 6 days
issue commentsourcegraph/sourcegraph
Active tab no longer underlined
@felixfbecker #14852 does not fix this. I think this problem is caused by something that's added in our production bundle and is not present in the dev bundle. The button's border-bottom-width is 3px in dev and 0px in the prod build.
In the dev build, the CSS for the element is:
In the prod build, the CSS is:
So perhaps there is some CSS minifier step that is changing the inheritance here?
comment created time in 6 days
push eventsourcegraph/sourcegraph
commit sha 4b46f7858d76c400bb22ad123a48714b8b332559
remove table hover bg
commit sha e16e0983c409888080feb021c9f13dd23046bfe9
use $gray-NN vars
push time in 6 days
push eventsourcegraph/sourcegraph
commit sha 74ed4b010ba4836a613ce6480ee4c4110179c047
fix active Tree bg
push time in 6 days
pull request commentsourcegraph/sourcegraph
Clean up CSS background color styles
- Fixed active tree row highlight colors
comment created time in 6 days
push eventsourcegraph/sourcegraph
commit sha d86af6496de5e55bbd7eac41f73c26e6ca9bc7d6
fix active Tree bg
push time in 6 days
push eventsourcegraph/sourcegraph
commit sha 0d430eaf3389a2f9dda9fb31929982f96dd10988
web: add height and width to img allowlist (#14846)
commit sha 55a7744037f839d847465859bfa29e87d6c7a586
repo-updater: Remove deprecated Language field (#14801) The field has already been removed from types.Repo so it should be removed from repos.Repo too.
commit sha e452e2d17ed9dff65ea9afdb9bdfca456248fe68
chore: Fix typo in usage documentation (#14841)
commit sha 2701d1112c65d3ff14b50500a4c6b1b74a6f6947
internal: Add base configuration object (#14836)
commit sha 3e1d578c68937f730daedba5e42635d0d579d502
tracking-issue: Fix display of depriorized issues (#14815)
commit sha 50d72c8b6bda1f9c60794f2e1d47a99d7a66d963
codenotify: Update db package (#14842)
commit sha d19243f57d53bfe943f22403003a5f656f5d85f6
workerutil: Add SetLogContents to store (#14837)
commit sha 1cde9f90e65977419ff30fed909ae41128ddca7c
ensure we have commits locally before finding common merge-base (#14737) * ensure we have commits locally before finding common merge-base * Update cmd/frontend/graphqlbackend/repository_comparison.go Co-authored-by: Thorsten Ball <mrnugget@gmail.com> * fix broken test (adds mock for git.ResolveRevision) * remove unneeded code * formatting code * removing unused mock Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
commit sha cae57306fec2129806fcb3fd41cd7e04e221d1ef
docker-images: Install src-cli in ignite-ubuntu base image (#14839)
commit sha d4b31dcd92bd2a4673ac60c45c722aad8b8de0ed
workerutil: Add QueuedCount to store (#14838)
commit sha ade9cd29f182b0d33f42d1ef4d16e9ca0d3ccd5d
chore: Add additional utils for interacting with goroutines (#14840)
commit sha f882bb5a837ed5648d70ebce82369f0152ef3279
Make sure that global test DB is setup in campaigns integration test (#14859) The test makes use of the global test DB by calling `repos.List` etc. but it only worked when another test setup the global test database.
commit sha 85e8556adac3775e1f784a1c34f716073fc037f1
chore: Move handler out of workerutil options (#14861)
commit sha 61d1c607a892caeb3f799a0ecb9c29dbdef7fc0c
Fix build by bumping nginx in server image to 1.18.0-r1 (#14860) * Fix build by bumping nginx in server image to 1.18.0-r1 Build failure looks like 1.18.0-r0 has been bumped to 1.18.0-r1 in the alpine repository: https://buildkite.com/sourcegraph/sourcegraph/builds/76932#caad483b-e9b5-41dc-9077-cb091bd80769 * Update cmd/server/Dockerfile Co-authored-by: Gonzalo Peci <pecigonzalo@users.noreply.github.com> Co-authored-by: Gonzalo Peci <pecigonzalo@users.noreply.github.com>
commit sha ce7a84a52c041ca926f29d122a6f085fc7e8b896
search: shortcircuit on count for search expressions (#14816)
commit sha eba3d69aba0c28c123297b49c41196cf6fbfdc30
syntax highlighting: improve comment contrast, add GraphQL highlighting (#14814) * syntax highlighting: improve comment contrast, add GraphQL highlighting This updates syntect_server for two changes: - A change by @rrhyne to improve comment contrast (primarily in light theme): https://github.com/slimsag/syntect/pull/7 - An awesome change by @rvantonder - adding his new open-source GraphQL syntax: https://github.com/slimsag/Packages/pull/4 Helps https://github.com/sourcegraph/sourcegraph/issues/14546 Fixes https://github.com/sourcegraph/sourcegraph/issues/13935 * CHANGELOG update
commit sha 4b2fd9912f2bb92a94cfeb44f3437429a45763a0
Implement UI display and burndown chart calculation for GitHub draft mode (#14742) - Extends the ExternalChangesetState by DRAFT (plus UI representation) - Adds drafts to the calculation of historic changeset data - Exposes the number of drafts on the changesets.stats and on the changesetCountsOverTime fields
commit sha 6c2bfa9f7268bee61e59eee6eaca3eae80433d9a
codeintel: add envvars for code intel DB (#14873) * add envvars for code intel DB * enterprise: add envvars for codeitnel DB
commit sha 348db0d6da558bb57570885dc8fdf045950ae672
campaigns: move validation code to campaignutils (#14791) Fixes #14249.
commit sha 3818d5806d558c7b2cfeae96aaedc02e6c802eb5
Clean up CSS border color styles (#14829) Previously, we had many ways of setting border colors: - Sometimes the hex color values would be used directly, and a component would define its own light and dark theme variants. This leads to inconsistent color usage, adds code complexity, and is mistake-prone. - We had `$color-border`, `$color-border-2`, `$border-color`, `--border-color`, etc. Now we just have `--border-color` and `--border-color-2` (dimmer, rarely used). Some components' borders will have slightly different colors after this change if they previously used a non-standard border color.
push time in 6 days
push eventsourcegraph/sourcegraph
commit sha 0d72a9491f5cf2de788b30a70eee60e1b43e0083
Clean up CSS text color styles (#14847)
push time in 6 days
PR merged sourcegraph/sourcegraph
Standardizes how components declare text colors. No components declare their own custom theme colors for text anymore; now they use CSS custom properties that can change based on the user's selected theme.
There will be minor changes to the text colors used in various components, but no (intentional) major changes. If we want to tweak colors further, we'll just need to introduce more variables that themes define (which is super easy).
Similar to #14829
<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->
pr closed time in 6 days
push eventsourcegraph/sourcegraph
commit sha 0d430eaf3389a2f9dda9fb31929982f96dd10988
web: add height and width to img allowlist (#14846)
commit sha 55a7744037f839d847465859bfa29e87d6c7a586
repo-updater: Remove deprecated Language field (#14801) The field has already been removed from types.Repo so it should be removed from repos.Repo too.
commit sha e452e2d17ed9dff65ea9afdb9bdfca456248fe68
chore: Fix typo in usage documentation (#14841)
commit sha 2701d1112c65d3ff14b50500a4c6b1b74a6f6947
internal: Add base configuration object (#14836)
commit sha 3e1d578c68937f730daedba5e42635d0d579d502
tracking-issue: Fix display of depriorized issues (#14815)
commit sha 50d72c8b6bda1f9c60794f2e1d47a99d7a66d963
codenotify: Update db package (#14842)
commit sha d19243f57d53bfe943f22403003a5f656f5d85f6
workerutil: Add SetLogContents to store (#14837)
commit sha 1cde9f90e65977419ff30fed909ae41128ddca7c
ensure we have commits locally before finding common merge-base (#14737) * ensure we have commits locally before finding common merge-base * Update cmd/frontend/graphqlbackend/repository_comparison.go Co-authored-by: Thorsten Ball <mrnugget@gmail.com> * fix broken test (adds mock for git.ResolveRevision) * remove unneeded code * formatting code * removing unused mock Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
commit sha cae57306fec2129806fcb3fd41cd7e04e221d1ef
docker-images: Install src-cli in ignite-ubuntu base image (#14839)
commit sha d4b31dcd92bd2a4673ac60c45c722aad8b8de0ed
workerutil: Add QueuedCount to store (#14838)
commit sha ade9cd29f182b0d33f42d1ef4d16e9ca0d3ccd5d
chore: Add additional utils for interacting with goroutines (#14840)
commit sha f882bb5a837ed5648d70ebce82369f0152ef3279
Make sure that global test DB is setup in campaigns integration test (#14859) The test makes use of the global test DB by calling `repos.List` etc. but it only worked when another test setup the global test database.
commit sha 85e8556adac3775e1f784a1c34f716073fc037f1
chore: Move handler out of workerutil options (#14861)
commit sha 61d1c607a892caeb3f799a0ecb9c29dbdef7fc0c
Fix build by bumping nginx in server image to 1.18.0-r1 (#14860) * Fix build by bumping nginx in server image to 1.18.0-r1 Build failure looks like 1.18.0-r0 has been bumped to 1.18.0-r1 in the alpine repository: https://buildkite.com/sourcegraph/sourcegraph/builds/76932#caad483b-e9b5-41dc-9077-cb091bd80769 * Update cmd/server/Dockerfile Co-authored-by: Gonzalo Peci <pecigonzalo@users.noreply.github.com> Co-authored-by: Gonzalo Peci <pecigonzalo@users.noreply.github.com>
commit sha ce7a84a52c041ca926f29d122a6f085fc7e8b896
search: shortcircuit on count for search expressions (#14816)
commit sha eba3d69aba0c28c123297b49c41196cf6fbfdc30
syntax highlighting: improve comment contrast, add GraphQL highlighting (#14814) * syntax highlighting: improve comment contrast, add GraphQL highlighting This updates syntect_server for two changes: - A change by @rrhyne to improve comment contrast (primarily in light theme): https://github.com/slimsag/syntect/pull/7 - An awesome change by @rvantonder - adding his new open-source GraphQL syntax: https://github.com/slimsag/Packages/pull/4 Helps https://github.com/sourcegraph/sourcegraph/issues/14546 Fixes https://github.com/sourcegraph/sourcegraph/issues/13935 * CHANGELOG update
commit sha 4b2fd9912f2bb92a94cfeb44f3437429a45763a0
Implement UI display and burndown chart calculation for GitHub draft mode (#14742) - Extends the ExternalChangesetState by DRAFT (plus UI representation) - Adds drafts to the calculation of historic changeset data - Exposes the number of drafts on the changesets.stats and on the changesetCountsOverTime fields
commit sha 6c2bfa9f7268bee61e59eee6eaca3eae80433d9a
codeintel: add envvars for code intel DB (#14873) * add envvars for code intel DB * enterprise: add envvars for codeitnel DB
commit sha 348db0d6da558bb57570885dc8fdf045950ae672
campaigns: move validation code to campaignutils (#14791) Fixes #14249.
commit sha 3818d5806d558c7b2cfeae96aaedc02e6c802eb5
Clean up CSS border color styles (#14829) Previously, we had many ways of setting border colors: - Sometimes the hex color values would be used directly, and a component would define its own light and dark theme variants. This leads to inconsistent color usage, adds code complexity, and is mistake-prone. - We had `$color-border`, `$color-border-2`, `$border-color`, `--border-color`, etc. Now we just have `--border-color` and `--border-color-2` (dimmer, rarely used). Some components' borders will have slightly different colors after this change if they previously used a non-standard border color.
push time in 7 days
push eventsourcegraph/sourcegraph
commit sha 3818d5806d558c7b2cfeae96aaedc02e6c802eb5
Clean up CSS border color styles (#14829) Previously, we had many ways of setting border colors: - Sometimes the hex color values would be used directly, and a component would define its own light and dark theme variants. This leads to inconsistent color usage, adds code complexity, and is mistake-prone. - We had `$color-border`, `$color-border-2`, `$border-color`, `--border-color`, etc. Now we just have `--border-color` and `--border-color-2` (dimmer, rarely used). Some components' borders will have slightly different colors after this change if they previously used a non-standard border color.
push time in 7 days
PR merged sourcegraph/sourcegraph
Previously, we had many ways of setting border colors:
- Sometimes the hex color values would be used directly, and a component would define its own light and dark theme variants. This leads to inconsistent color usage, adds code complexity, and is mistake-prone.
- We had
$color-border,$color-border-2,$border-color,--border-color, etc.
Now we just have --border-color and --border-color-2 (dimmer, rarely used). Some components' borders will have slightly different colors after this change if they previously used a non-standard border color.
<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->
pr closed time in 7 days
Pull request review commentsourcegraph/sourcegraph
Clean up CSS border color styles
@import 'bootstrap/scss/tables'; .theme-light {- .table {- th,- td {- border-top: $table-border-width solid $table-border-color-light;- }-- thead th {- border-bottom: (2 * $table-border-width) solid $table-border-color-light;- }-- tbody + tbody {- border-top: (2 * $table-border-width) solid $table-border-color-light;- }- }-
This was just redundant. We define the Bootstrap SCSS var $table-border-color: var(--border-color); and then it just works in both themes. Really, this CSS should just be setting the border-{top/bottom}-color, but someone duplicated the entire border declaration, thus the confusion.
comment created time in 7 days
Pull request review commentsourcegraph/sourcegraph
Clean up CSS border color styles
flex: 1; } - border-bottom-color: $color-bg-3;-+ &--inactive {+ border-bottom-color: var(--border-color);+ } &, &:hover { text-decoration: none !important; // override .btn-link:focus } &:hover { opacity: 1;- border-bottom-color: $color-border-hover;+ border-bottom-color: var(--link-color);
The border here functions kinda like an underline for the name of the tab:
So I think it is semantically "ok" to pin this to the link color.
comment created time in 7 days
push eventsourcegraph/sourcegraph
commit sha e4958b671babc04d515ab4dda52d0a6b4f1ab1c7
Elevate product areas in documentation (#14792)
commit sha 6483cb33d8381fb151f375bcc29584e2c6a7b92c
Implement `getText` for extension API (#14741) `getText` returns text within the provided range
commit sha 0d430eaf3389a2f9dda9fb31929982f96dd10988
web: add height and width to img allowlist (#14846)
commit sha 55a7744037f839d847465859bfa29e87d6c7a586
repo-updater: Remove deprecated Language field (#14801) The field has already been removed from types.Repo so it should be removed from repos.Repo too.
commit sha e452e2d17ed9dff65ea9afdb9bdfca456248fe68
chore: Fix typo in usage documentation (#14841)
commit sha 2701d1112c65d3ff14b50500a4c6b1b74a6f6947
internal: Add base configuration object (#14836)
commit sha 3e1d578c68937f730daedba5e42635d0d579d502
tracking-issue: Fix display of depriorized issues (#14815)
commit sha 50d72c8b6bda1f9c60794f2e1d47a99d7a66d963
codenotify: Update db package (#14842)
commit sha d19243f57d53bfe943f22403003a5f656f5d85f6
workerutil: Add SetLogContents to store (#14837)
commit sha 1cde9f90e65977419ff30fed909ae41128ddca7c
ensure we have commits locally before finding common merge-base (#14737) * ensure we have commits locally before finding common merge-base * Update cmd/frontend/graphqlbackend/repository_comparison.go Co-authored-by: Thorsten Ball <mrnugget@gmail.com> * fix broken test (adds mock for git.ResolveRevision) * remove unneeded code * formatting code * removing unused mock Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
commit sha cae57306fec2129806fcb3fd41cd7e04e221d1ef
docker-images: Install src-cli in ignite-ubuntu base image (#14839)
commit sha d4b31dcd92bd2a4673ac60c45c722aad8b8de0ed
workerutil: Add QueuedCount to store (#14838)
commit sha ade9cd29f182b0d33f42d1ef4d16e9ca0d3ccd5d
chore: Add additional utils for interacting with goroutines (#14840)
commit sha f882bb5a837ed5648d70ebce82369f0152ef3279
Make sure that global test DB is setup in campaigns integration test (#14859) The test makes use of the global test DB by calling `repos.List` etc. but it only worked when another test setup the global test database.
commit sha 85e8556adac3775e1f784a1c34f716073fc037f1
chore: Move handler out of workerutil options (#14861)
commit sha 61d1c607a892caeb3f799a0ecb9c29dbdef7fc0c
Fix build by bumping nginx in server image to 1.18.0-r1 (#14860) * Fix build by bumping nginx in server image to 1.18.0-r1 Build failure looks like 1.18.0-r0 has been bumped to 1.18.0-r1 in the alpine repository: https://buildkite.com/sourcegraph/sourcegraph/builds/76932#caad483b-e9b5-41dc-9077-cb091bd80769 * Update cmd/server/Dockerfile Co-authored-by: Gonzalo Peci <pecigonzalo@users.noreply.github.com> Co-authored-by: Gonzalo Peci <pecigonzalo@users.noreply.github.com>
commit sha ce7a84a52c041ca926f29d122a6f085fc7e8b896
search: shortcircuit on count for search expressions (#14816)
commit sha eba3d69aba0c28c123297b49c41196cf6fbfdc30
syntax highlighting: improve comment contrast, add GraphQL highlighting (#14814) * syntax highlighting: improve comment contrast, add GraphQL highlighting This updates syntect_server for two changes: - A change by @rrhyne to improve comment contrast (primarily in light theme): https://github.com/slimsag/syntect/pull/7 - An awesome change by @rvantonder - adding his new open-source GraphQL syntax: https://github.com/slimsag/Packages/pull/4 Helps https://github.com/sourcegraph/sourcegraph/issues/14546 Fixes https://github.com/sourcegraph/sourcegraph/issues/13935 * CHANGELOG update
commit sha 4b2fd9912f2bb92a94cfeb44f3437429a45763a0
Implement UI display and burndown chart calculation for GitHub draft mode (#14742) - Extends the ExternalChangesetState by DRAFT (plus UI representation) - Adds drafts to the calculation of historic changeset data - Exposes the number of drafts on the changesets.stats and on the changesetCountsOverTime fields
commit sha 6c2bfa9f7268bee61e59eee6eaca3eae80433d9a
codeintel: add envvars for code intel DB (#14873) * add envvars for code intel DB * enterprise: add envvars for codeitnel DB
push time in 7 days
Pull request review commentsourcegraph/sourcegraph
.code-snippet {- &__container {- background-color: $color-bg-2;- }-}--.theme-light {- .code-snippet {- &__container {- background-color: $color-light-bg-2;- }- }+ background-color: var(--code-bg);
Good idea. Will do.
comment created time in 7 days
PR opened sourcegraph/sourcegraph
Standardizes how components declare background colors. No components declare their own custom theme colors for backgrounds anymore; now they use CSS custom properties that can change based on the user's selected theme.
There will be minor changes to the background colors used in various components, but no (intentional) major changes. If we want to tweak colors further, we'll just need to introduce more variables that themes define (which is super easy).
Similar to #14847 and #14829.
<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->
pr created time in 8 days
push eventsourcegraph/sourcegraph
commit sha 9695662b243213cc2e769c531ce1b07d8cfbd9f6
Clean up CSS text color styles Standardizes how components declare text colors. No components declare their own custom theme colors for text anymore; now they use CSS custom properties that can change based on the user's selected theme. There will be minor changes to the text colors used in various components, but no (intentional) major changes. If we want to tweak colors further, we'll just need to introduce more variables that themes define (which is super easy). Similar to #14829
push time in 8 days
PR opened sourcegraph/sourcegraph
Standardizes how components declare text colors. No components declare their own custom theme colors for text anymore; now they use CSS custom properties that can change based on the user's selected theme.
There will be minor changes to the text colors used in various components, but no (intentional) major changes. If we want to tweak colors further, we'll just need to introduce more variables that themes define (which is super easy).
Similar to #14829
<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->
pr created time in 8 days
push eventsourcegraph/sourcegraph
commit sha e4958b671babc04d515ab4dda52d0a6b4f1ab1c7
Elevate product areas in documentation (#14792)
commit sha 6483cb33d8381fb151f375bcc29584e2c6a7b92c
Implement `getText` for extension API (#14741) `getText` returns text within the provided range
commit sha cdb7573db7e91264e96e27a442963c91a74536e7
Clean up CSS border color styles Previously, we had many ways of setting border colors: - Sometimes the hex color values would be used directly, and a component would define its own light and dark theme variants. This leads to inconsistent color usage, adds code complexity, and is mistake-prone. - We had `$color-border`, `$color-border-2`, `$border-color`, `--border-color`, etc. Now we just have `--border-color` and `--border-color-2` (dimmer, rarely used). Some components' borders will have slightly different colors after this change if they previously used a non-standard border color.
push time in 8 days
pull request commentsourcegraph/sourcegraph
clean up UserArea, UserSettingsProfilePage, user header, updateUser mutation
@tjkandala Thanks! Just updated this PR branch with your changes and rebased.
comment created time in 8 days
delete branch sourcegraph/sourcegraph
delete branch : tj/user-area-tab-to-sidebar
delete time in 8 days
push eventsourcegraph/sourcegraph
commit sha 5ec6c99a9991d91b2dc48f898e92187208b8ade3
Documentation reorg: Development docs (#14509)
commit sha 9994f30fcb240a244351f9590c91fa6205620d44
release: remove rc-announce, add release:status (#14473)
commit sha 99a93a8d5267c6a349da16b96eee0d7b75d84972
Update dependency @types/react-router-dom to v5.1.6
commit sha 471fd16aa4706543c4213224c219a98f2995a4b7
Update dependency @types/recharts to v1.8.16
commit sha f040476a9359d3ab002b08044bbba03638f7f68f
Fix missing page title in search language docs (#14514) I noticed this when shamelessly copying the custom-style-in-docs stuff from this page. With `<style>` being the first line, the page title is lost:
commit sha a10d7ea1d862397ba12bd7fe7cdedfc73552affb
Turn 'Hello World' campaign into quickstart (#14483) * Turn 'Hello World' campaign into quickstart * More steps and screenshots * Fix note about changing query * Mention code host configuration in campaigns quickstart * Add another explanatory sentence to quickstart * Add helper to username question * Update doc/user/campaigns/quickstart.md Co-authored-by: Chris Pine <chrispine@sourcegraph.com> * Move assets to google bucket * Fix broken docs link Co-authored-by: Chris Pine <chrispine@sourcegraph.com>
commit sha 048f49eef3c998a7c44d2d5f3d88d66e5e82dcb9
doc: Add instructions for user added code hosts (#14516) * doc: Add instructions for user added code hosts * Remove SQL and mention it is private beta
commit sha 85f198b04ca79be31f49d2f60c47594e4ac4df3e
Move shared branded code to branded/ (#14515)
commit sha a6ef9e2a0562911ea4fd27368351ca8284f79254
codeintel: Lower number of goroutines during SQLite -> Postgres migration (#14520)
commit sha b07eab8cb194a70fc497b10bce322f724d1ec4be
Remove unnecessary check if campaigns are enabled (#14522) This can only be retrieved on a campaign, and when you cannot query a campaign node, this method will also not be exposed.
commit sha 3aef058811484be7ce05d2b2c331e755272d7e33
dev: Disable indexing CNCF repositories locally (#14506)
commit sha 5f87df4353026afa56b010a3f49cfd633a8b46fa
dev: Do not crash startup script on unbound PG variables (#14491)
commit sha dfa48b41523599a69881fefb9bb3a504c2cdc283
search: match repos concurrently (#14512) * search repos concurrently * add benchmark Co-authored-by: Keegan Carruthers-Smith <keegan.csmith@gmail.com>
commit sha e1a3d374ab99dd3bc378e0b7be59ca2933099e25
Add missing Close call to diff iterator (#14524) The docs state this should always be done so it seems like this is missing.
commit sha 21c3df2355753fc16b192dbca70af4df2ca69f02
Fix recording of ListRepos errors (#14518)
commit sha 320870aca21f1194446e0e9c034a8843c553ed22
monitoring: add more panels to Grafana repo-updater dashboard (#14269) Improves the repo-updater Grafana dashboard with many new panels as well as observing more of repo-updater's internal state. * monitoring: add more panels to Grafana repo-updater dashboard * Remove comment and fix typo * Add dashboard panels for external_service_sync_jobs state * Increase alert threshold * Remove duplicate metrics schedKnownRepos and schedHeapCount were measuring the same thing in different ways and the old version of schedKnownRepos was assuming a single syncer. Remove the old version of schedKnowRepos and use schedHeapCount instead. * Observe the number of repos queued for update * Fix observable name * Observe when a sync was started Grouped by sync "family" and external service id * Improve metric name * Don't tag metrics with external service id This could increase the cardinality of our metrics too much * Observe the time since the oldest sync * Simplify function Co-authored-by: Ryan Slade <ryanslade@gmail.com>
commit sha 6a40f28f0abcc2296b00e119d274e083405615ed
enable e2e testing in vagrant for main branch (#14533) enable e2e testing in vagrant for main branch
commit sha f3e2e203f4092c88d7d0d57e5464051b489e9cce
increase timeout for testing in vagrant box (#14534)
commit sha 1fb9c9a9a67e903e6328c92117964508106bb7f0
codeintel: De-multiply writes during SQLite -> Postgres migration (#14536)
commit sha db295150333de25ec0120317de3f0b1e6d7355cd
codeintel: Clean up bundle files after SQLite -> Postgres migration (#14537)
push time in 8 days
PR closed sourcegraph/sourcegraph
pr closed time in 8 days
pull request commentsourcegraph/sourcegraph
Move event log from tabs to sidebar
thanks - I cherry-picked these commits into the base PR
comment created time in 8 days
push eventsourcegraph/sourcegraph
commit sha 9c8ebd3cf98648568bf556cb126d896d3fbbb267
Clean up CSS border color styles Previously, we had many ways of setting border colors: - Sometimes the hex color values would be used directly, and a component would define its own light and dark theme variants. This leads to inconsistent color usage, adds code complexity, and is mistake-prone. - We had `$color-border`, `$color-border-2`, `$border-color`, `--border-color`, etc. Now we just have `--border-color` and `--border-color-2` (dimmer, rarely used). Some components' borders will have slightly different colors after this change if they previously used a non-standard border color.
push time in 8 days
push eventsourcegraph/sourcegraph
commit sha 4809aa5fec73f10daeb1d545d6611340c437cc61
Clean up code styles Add a CSS var `--code-bg` that is used in CodeSnippet and Markdown code blocks. (Because it's used in 2 places, a CSS var is used instead of just `--color-bg-2`.) Also fix a bug where the CodeExcerpt style was not actually applied in the storybook because only the global stylesheet was being loaded.
push time in 8 days
PR opened sourcegraph/sourcegraph
Previously, we had many ways of setting border colors:
- Sometimes the hex color values would be used directly, and a component would define its own light and dark theme variants. This leads to inconsistent color usage, adds code complexity, and is mistake-prone.
- We had
$color-border,$color-border-2,$border-color,--border-color, etc.
Now we just have --border-color and --border-color-2 (dimmer, rarely used). Some components' borders will have slightly different colors after this change if they previously used a non-standard border color.
<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->
pr created time in 8 days
issue openedsourcegraph/sourcegraph
Capitalization problems in search homepage copy
- "api" should be capitalized ("API")
- "Explore and Extend" should be sentence-case, not title case (https://about.sourcegraph.com/handbook/communication/content_guidelines/style_and_mechanics#capitalization), so "Explore and extend"
created time in 8 days
PR opened sourcegraph/sourcegraph
<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->
pr created time in 9 days
PR opened sourcegraph/sourcegraph
Add a CSS var --code-bg that is used in CodeSnippet and Markdown code blocks. (Because it's used in 2 places, a CSS var is used instead of just --color-bg-2.)
Also fix a bug where the CodeExcerpt style was not actually applied in the storybook because only the global stylesheet was being loaded.
<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->
pr created time in 9 days
pull request commentsourcegraph/sourcegraph
fix issue preventing more than 1 theme cycle via keyboard shortcut
@felixfbecker i was puzzled. Couldn’t figure out why. Can you take a look?
comment created time in 11 days
push eventsourcegraph/sourcegraph
commit sha d807558c4e8d49a3c41754f74630c0d9e44f5e15
doc/dev: Update architecture diagram (#14633)
commit sha f050d8a8cb543781e967a7bcd72480c9d9b664ac
search: enable onboarding tour for everyone (#14636) * search: enable onboarding tour for everyone * Modified changelog
commit sha 680984194b585ca235308f3b2b55a23af15d0f3d
dbutil: Extract and reuse postgres batch inserter (#14637)
commit sha 59de4f190d5454961de03ee8d0c1097f1e47f002
dbconn: Add postgres bulk insertion mode for tracing (#14624)
commit sha 6aff7d529e120d3cb55b01f14b4311a2fa0f420e
codeintel: Rewrite janitor to focus on postgres data (#14641)
commit sha 4f5a2c55d4dfb0f3d4f14f1c7d754b5bfcd19b5b
go.mod: update golang.org/x/oauth2 (#14607)
commit sha e12f28911c5f60335730a185d6cf085b856edee4
Add missing bg-4 class (#14656)
commit sha 0475ef5ae1a7ef2d665f26be9eec5f00d352efbd
Show form feedback on input (#14655)
commit sha 64bbf82b146d223917b4ab800424f5e335efee89
codeintel: Stop invalid GetState queries from being executed (#14677)
commit sha a1bdb9106d2605110d0698fb12a588e31949494d
search: sync access `calledSearchFilesInRepos` mock (#14674) We call searchFilesInRepos twice in a normal search request. Once for files and once for file contents. This means the mocks we use in tests need to protect against concurrent access. CI picked up a test having race condition. This PR switches us to using an atomic value. Commit was created as a series of comby refactors: 'calledSearchFilesInRepos := :[[a]]' 'calledSearchFilesInRepos := atomic.NewBool(:[a])' 'calledSearchFilesInRepos = :[[a]]' 'calledSearchFilesInRepos.Store(:[a])' 'if :[a~!?]calledSearchFilesInRepos' 'if :[a]calledSearchFilesInRepos.Load()' Note: Technically we should validate which searchFilesInRepos we are calling (ie for file paths or not). However, these sort of conditions are somewhat low value. So rather than doing a bigger change I just fixed the race condition.
commit sha edc9c13074d903ff62ecc6aeb9c61782f01529ba
docs: Update upgrading docs (#14635)
commit sha b8fdf6861b57e1c8a85551926aff98b5cb78776d
default SRC_LOG_LEVEL=warn in production deployments (#14460) * default SRC_LOG_LEVEL=warn in production deployments Prior to this change `SRC_LOG_LEVEL=dbug` was the default which meant many customers would have several GB of logs for just a few days that are mostly useless debug logs. e.g. https://github.com/sourcegraph/customer/issues/49 `sourcegraph/server` defaults to `SRC_LOG_LEVEL=warn`, in contrast to Docker Compose and Kubernetes deployments that used the default `dbug` level. This PR changes the default `SRC_LOG_LEVEL=warn` except in dev environments, which already specify `dbug` as the level explicitly. Helps sourcegraph/customer#49
commit sha fead4b16ec6e88f588d726cfe872bffccf75961c
campaigns: update preview icons (#14678)
commit sha 2c469e13614204ba0bcc662db6db62c13563029e
Updates old instructions in our troubleshooting docs (#14680)
commit sha 971b13e6fa729f2f510ade3a0c26c756cce32a3f
client/web/src/regression: update regression test docs (#14553) This updates the regression test docs to clarify how to run these tests - these docs were really outdated / broken, I had to do a fair amount of digging. I added a 1password note with the `.envrc` file I got from Uwe, because you need to set like ~15 env vars in order to run these tests. I also removed the comments about wanting customers in the future to run this test suite - I don't think we want that anymore and that experience would not be good as running this test suite requires a working Sourcegraph dev env. The `src validate` command Uwe added to src-cli seems a lot better from a customer POV: https://github.com/sourcegraph/src-cli/pull/200
commit sha 1399c5a0c9ffafe9bff937574af2567085cd65ca
monitoring: CODENOTIFY @slimsag (#14682) I want to get notified for any changes to monitoring.
commit sha 2ed65b630879113069bfae9b3392042f782a46bb
search: add homepage footer with links to extensibility (#14676)
commit sha 4126255e1e4655b248e2b9d3532933e600d186c9
src-cli: increment minimum version (#14687)
commit sha fb06c927fc901a0aeec781341f893a76b9cecaf5
Fix wrong state calculated for empty check suites (#14523) Empty completed checksuites become stale at some point and then will be considered "UNKNOWN", but they don't contribute to the overall state displayed by GitHub.
commit sha 10c365ab2d8154b4bdf5f9fcc54c5db9dd29e6d1
Organizing search docs into explanations, tutorials, how-tos, and references (#14640)
push time in 12 days