profile
viewpoint
Santiago Pastorino spastorino @wyeworks & @futurewei-tech Montevideo, Uruguay https://santiagopastorino.com @wyeworks co-founder, @rust-lang compiler team contributor and @rails core team alumni. Sponsored to work on the @rust-lang compiler by @futurewei-tech.

http-rs/surf 1196

Fast and friendly HTTP client framework for async Rust

rust-lang/rustc-dev-guide 948

A guide to how rustc works and how to contribute to it.

rust-lang/compiler-team 232

A home for compiler team planning documents, meeting minutes, and other such things.

rust-lang/cargo-bisect-rustc 100

Bisects rustc, either nightlies or CI artifacts

rust-lang/triagebot 80

Triage Bot

spastorino/coffee-rails 18

rails/coffee-rails is the official repo

nikomatsakis/rust 7

A work-in-progress programming language; not yet suitable for users

spastorino/bundler 2

Gemfiles are fun

spastorino/arel 1

A Relational Algebra

pull request commentrust-lang/rust

Cleanup: Eliminate ConstnessAnd

I'm not sure how perf labelling works really but seems like we have perf-regression left from the first perf run, but the second shows mixed results. Should we manually remove perf-regression label? if that's the case maybe it's nice if the perf tooling automatically does that in the second run.

cc @rust-lang/wg-compiler-performance

fee1-dead

comment created time in 8 hours

pull request commentrust-lang/rust

Cleanup: Eliminate ConstnessAnd

I think this now should be good to merge. @fee1-dead if you consider this ready too, feel free to bors=me.

fee1-dead

comment created time in a day

pull request commentrust-lang/rust

Actually instantiate the opaque type when checking bounds

@bors r+

oli-obk

comment created time in a day

PullRequestReviewEvent

Pull request review commentrust-lang/rust

Cleanup: Eliminate ConstnessAnd

 impl<'a, 'tcx> WfPredicates<'a, 'tcx> {          let extend = |obligation: traits::PredicateObligation<'tcx>| {             let mut cause = cause.clone();-            if let Some(parent_trait_ref) = obligation.predicate.to_opt_poly_trait_ref() {+            if let Some(parent_trait_ref) = obligation.predicate.to_opt_poly_trait_pred() {                 let derived_cause = traits::DerivedObligationCause {-                    parent_trait_ref: parent_trait_ref.value,+                    // TODO: sus

This is making tidy fail

fee1-dead

comment created time in a day

PullRequestReviewEvent

push eventspastorino/rust

Santiago Pastorino

commit sha 535ce2d739da7b7926f247b10bf6518d48db7bfa

Make associated type name be the name of the function

view details

push time in 2 days

push eventspastorino/rust

Santiago Pastorino

commit sha 14a41fc530bc663b650eb0afa887e87342906977

Make associated type name be the name of the function

view details

push time in 2 days

push eventspastorino/rust

Santiago Pastorino

commit sha 29e51474dcaf23fd527effecabe03fa6f59478ef

Make associated type name be the name of the function

view details

push time in 2 days

push eventspastorino/rust

Santiago Pastorino

commit sha 228fdbdca94d9b4cf9cf66e4896ece8f2bfbc2eb

Make associated type name be the name of the function

view details

push time in 2 days

push eventspastorino/rust

Santiago Pastorino

commit sha 3ccb5eb00d7261c1faacc6af897a9ddaff88f90a

Make associated type name be the name of the function

view details

push time in 2 days

push eventspastorino/rust

Santiago Pastorino

commit sha 071b3091bade91ce8cb26bbf780d257f831a08c9

Handle lifetimes for RPITIT

view details

push time in 2 days

push eventspastorino/rust

Santiago Pastorino

commit sha c1be2bf1b12b3110bf87799bc6ac83a9e671a8fa

Make the assoc type anonymous

view details

Santiago Pastorino

commit sha 925a78e1f491f7bf009562160cb18a273448c05b

Add RPITIT test with associated type

view details

Santiago Pastorino

commit sha a57d22fcb13ea4abdfa3351eb5fa34f34be50617

Correctly handle generics for RPITIT

view details

Santiago Pastorino

commit sha f6dcedd54d139d6f10b5ffc1b0491f35abad086f

Handle lifetimes for RPITIT

view details

push time in 2 days

push eventspastorino/rust

Santiago Pastorino

commit sha 979ed1bf9262e1b448e57deb9b4ff13e37a31e54

Handle bounds for impl trait in traits

view details

Santiago Pastorino

commit sha ef002b9766ba04d920d698ec3feba9d7bfe8b7c1

Make the assoc type anonymous

view details

Santiago Pastorino

commit sha 1909773007e93b644e00c61f5bb5b41a5ab22f80

Add RPITIT test with associated type

view details

Santiago Pastorino

commit sha 7eaf07059b542ce034a4c1b917f91516d4e1d721

Correctly handle generics for RPITIT

view details

Santiago Pastorino

commit sha 40b20f21e890dbd03f289ad263adc396f604dc9b

Handle lifetimes for RPITIT

view details

push time in 2 days

push eventspastorino/rust

Santiago Pastorino

commit sha 11b1bd16e028be58fae0c0c88276731f16a9eb53

Correctly handle generics for RPITIT

view details

Santiago Pastorino

commit sha 0942b8259e6cf2027566a1f09d3e73707d0e380d

Handle lifetimes for RPITIT

view details

push time in 3 days

push eventspastorino/rust

Santiago Pastorino

commit sha 61ac1d7af6eb3d5579eda23f43afb5d71ff4950e

Correctly handle generics and lifetimes for RPITIT

view details

Santiago Pastorino

commit sha 8603dce1ecb69980ad1c085bf6a7085e917453e9

Handle Lifetimes

view details

push time in 3 days

push eventspastorino/rust

Santiago Pastorino

commit sha 219ff79e635ce2e8bc0d376722f3979b2f45c755

Correctly handle generics and lifetimes for RPITIT

view details

push time in 3 days

push eventspastorino/rust

Santiago Pastorino

commit sha 060549015016d3cc203b7dddaf182b1bf8acdbcb

Make generics_of think that the parent of the assoc type of RPITIT is the function

view details

Santiago Pastorino

commit sha 3c4266af79c8ef1b4ea00494719650279e151043

Follow up, see what's about

view details

Santiago Pastorino

commit sha c07a4a34edafd4b2dc7482fefc436eabe49ba80b

Correctly handle generics and lifetimes for RPITIT

view details

push time in 3 days

push eventspastorino/rust

Santiago Pastorino

commit sha 0d455733ef0e438b74a083fe70afc0c95b8f90e9

Make generics_of think that the parent of the assoc type of RPITIT is the function

view details

Santiago Pastorino

commit sha e59588a680c4ab61ce46b44b5778a789d7e57b4d

Follow up, see what's about

view details

Santiago Pastorino

commit sha 82ca740acb5f034b65806c512523430b21b7befc

Correctly handle generics and lifetimes for RPITIT

view details

push time in 3 days

push eventspastorino/rust

Santiago Pastorino

commit sha 9d820f37b31bda55ffe1667e12a9006fab8514a3

Make generics_of think that the parent of the assoc type of RPITIT is the function

view details

Santiago Pastorino

commit sha fece8ad7201f4d7e61718ea462bcaa18526763de

Follow up, see what's about

view details

Santiago Pastorino

commit sha 56a1319c8b438dd80479c5e0de19262ecdf985cb

Correctly handle generics and lifetimes for RPITIT

view details

push time in 3 days

push eventspastorino/rust

Santiago Pastorino

commit sha e5f16508e29f3f35b8a089ab70b191d35e9ff11e

Create definition for the return position impl trait associated type

view details

Santiago Pastorino

commit sha 02d674e03f3a7a6ea3467ef8f0759fed79624697

Use type to represent trait/impl trait context

view details

Santiago Pastorino

commit sha 3dfd94271fac7cc23707969043d8e66fafe34667

Detect a function that returns an impl trait inside a trait but do nothing for now

view details

Santiago Pastorino

commit sha d4095b16b829b319507d80a9f9207d568dcf3bc9

Lower impl traits in traits for simple cases

view details

Santiago Pastorino

commit sha e763fc29f3c6ad126aded8c8604db7b5d7f297e4

Add ImplTraitContext::ReturnPositionInTrait

view details

Santiago Pastorino

commit sha 924326a45d333e5f087bb622f505dd0ba3cb41ff

Handle bounds for impl trait in traits

view details

Santiago Pastorino

commit sha fb0c62873f11132e5612d88e703e3ccbd700ee50

Make the assoc type anonymous

view details

Santiago Pastorino

commit sha 721d7911774ee63a874bb3becd4f4dfaf3ce75be

Add RPITIT test with associated type

view details

Santiago Pastorino

commit sha 6a187c00472ae1f77f0d3385bf6c29ea0372b38d

Follow up, see what's about

view details

Santiago Pastorino

commit sha e4a1996252805b5eea40dfbc68c2924843bff72d

Make generics_of think that the parent of the assoc type of RPITIT is the function

view details

Santiago Pastorino

commit sha ffae8376e08ca4e5cecf800ca78e6f54642e4664

Correctly handle generics and lifetimes for RPITIT

view details

push time in 3 days

push eventspastorino/rust

Santiago Pastorino

commit sha d0e85e8d3d20c54c6c1626c236fcb15137767c40

Follow up, see what's about

view details

Santiago Pastorino

commit sha 5f08ff64ec31af78162e6602ddbc51b0405b3d2d

Make the assoc type anonymous

view details

Santiago Pastorino

commit sha 968d31e5f0ca1b7c625a9f75a44877851ed2c1c9

Add RPITIT test with associated type

view details

Santiago Pastorino

commit sha 423a28a1c776eb811e2ec6fc7dde2e9fab4efddb

Make generics_of think that the parent of the assoc type of RPITIT is the function

view details

Santiago Pastorino

commit sha c1de6b82cbe2c97e3a49297e49139dee59820efd

Use DefPathData::TypeNs

view details

Santiago Pastorino

commit sha 7a7957a13e0c5a421edc7f7a93e8bb07d7de94df

Correctly handle generics and lifetimes for RPITIT

view details

push time in 3 days

push eventspastorino/rust

Santiago Pastorino

commit sha 132c07f3c69d702c62bc49db879669ffbdb6ac50

Lower impl traits in traits for simple cases

view details

Santiago Pastorino

commit sha 37d2ab4ba24543f256e56389c1d3225b412602c3

Add ImplTraitContext::ReturnPositionInTrait

view details

Santiago Pastorino

commit sha d83a86967b588e24ef041981f452cbbc3feeb9b1

Handle bounds for impl trait in traits

view details

Santiago Pastorino

commit sha f4868ab8cfee73ee8c52dab04a29b232fea07cde

Follow up, see what's about

view details

Santiago Pastorino

commit sha ac36d5f459326276494c6a26d627138de9441998

Make the assoc type anonymous

view details

Santiago Pastorino

commit sha bcbf2d76f23e3a5f99fa7209ba739491a0ad45a8

Add RPITIT test with associated type

view details

Santiago Pastorino

commit sha aba4272a187a2ea52b5ea5b2f5976a83f2a51403

Make generics_of think that the parent of the assoc type of RPITIT is the function

view details

Santiago Pastorino

commit sha c5d080c62dcbdac1d7768b978804dc4cdeab3640

Use DefPathData::TypeNs

view details

Santiago Pastorino

commit sha a149ad3bcf0e68b026c821dbe4beac076ed854fd

Correctly handle generics and lifetimes for RPITIT

view details

push time in 3 days

push eventspastorino/rust

Santiago Pastorino

commit sha 26e2dd704bc0e2ffc25121ade490e49e67202c47

Correctly handle generics and lifetimes for RPITIT

view details

push time in 3 days

pull request commentrust-lang/rust

Cleanup: Eliminate ConstnessAnd

@fee1-dead ohh great. I've promised @oli-obk that I was going to take this over but had some stuff on my plate and couldn't yet. If you're going ahead please do, otherwise I'd take it over probably this week.

oli-obk

comment created time in 3 days

push eventspastorino/rust

Santiago Pastorino

commit sha c807fe83584fc227bbdac73e82e2b2c048cab64b

Correctly handle generics and lifetimes for RPITIT

view details

push time in 5 days

push eventspastorino/rust

Santiago Pastorino

commit sha 2f0aaceee9701e1d13cd416375f9443d370393a5

Add RPITIT test with associated type

view details

Santiago Pastorino

commit sha 737d6ce96e4b9d38b33cb18b4ab3e689d9848c2e

Make generics_of think that the parent of the assoc type of RPITIT is the function

view details

Santiago Pastorino

commit sha 8a6230de4248a4da5e59022d9f36168426a53cb4

Use DefPathData::TypeNs

view details

Santiago Pastorino

commit sha d42ac63b4a1673e15f5c115e9cf3397bad1aeb65

Correctly handle generics and lifetimes for RPITIT

view details

push time in 5 days

push eventspastorino/rust

Santiago Pastorino

commit sha 655bd2999bb9cce2f41949c98d16fa0593c38004

Lower impl traits in traits for simple cases

view details

Santiago Pastorino

commit sha ef9ff5a8e9ab2b41986cdec07c447862c2606de4

Handle bounds for impl trait in traits

view details

Santiago Pastorino

commit sha 7317e344dcbded32524ac8e7a0062283d242f9da

Make the assoc type anonymous

view details

push time in 8 days

push eventspastorino/rust

Santiago Pastorino

commit sha 497f48c45b0a4018e4434c5fe7f2c6a1b014ea1a

Add an optional trait parent def id to ImplTraitContext::Existential

view details

Santiago Pastorino

commit sha 7a0d5f3f449d861ed8cfe8fa0863d2b03036172a

Create impl trait definition with containing trait being parent

view details

Santiago Pastorino

commit sha 14d5b987f172ab8942ad0dd42e80011903e129b4

Create definition for the return position impl trait associated type

view details

Santiago Pastorino

commit sha 717ecbcc2435734cb5c5d2c949c53a565c619ff5

Use type to represent trait/impl trait context

view details

Santiago Pastorino

commit sha 524177e3f16785276501b84bbeca7b272a219d7c

Detect a function that returns an impl trait inside a trait but do nothing for now

view details

Santiago Pastorino

commit sha cfa6c102203098d24641f5362880e78c2ddaf6b6

Lower impl traits in traits for simple cases

view details

Santiago Pastorino

commit sha 5291ba3df5b24dee63d0fb3683dc5d30587aa940

Make node ids usages more meaningful

view details

Santiago Pastorino

commit sha a41e04eb4d392519e3a1f153e3cf19fd88be8080

Handle bounds for impl trait in traits

view details

Santiago Pastorino

commit sha 30a9f32709284f492d1ace1734d647d67f3958c4

Make the assoc type anonymous

view details

push time in 8 days

push eventspastorino/rust

Santiago Pastorino

commit sha 5de7b7503135b5cc7fbad5db68f726c35fb48e87

Handle bounds for impl trait in traits

view details

Santiago Pastorino

commit sha aca3b090f831be944add249751391ae0a082370e

Make the assoc type anonymous

view details

push time in 9 days

more