profile
viewpoint
Santiago Pastorino spastorino @wyeworks Montevideo, Uruguay https://santiagopastorino.com @wyeworks co-founder, @rust-lang compiler team contributor, @rustlatam organizer and @rails core team alumni.

http-rs/surf 889

Fast and friendly HTTP client framework for async Rust

rust-lang/rustc-dev-guide 694

A guide to how rustc works and how to contribute to it.

rust-lang/compiler-team 169

A home for compiler team planning documents, meeting minutes, and other such things.

rust-lang/cargo-bisect-rustc 65

Bisects rustc, either nightlies or CI artifacts

spastorino/coffee-rails 18

rails/coffee-rails is the official repo

spastorino/exceptron 9

Exceptron comes from the future to make your exceptions rock!

nikomatsakis/rust 7

A work-in-progress programming language; not yet suitable for users

spastorino/bundler 2

Gemfiles are fun

spastorino/arel 1

A Relational Algebra

spastorino/dalli 1

High performance memcached client for Ruby

pull request commentrust-lang/triagebot

Add RFCs for T-compiler

r? @Mark-Simulacrum

apiraino

comment created time in a day

PullRequestReviewEvent

Pull request review commentrust-lang/triagebot

Add RFCs for T-compiler

 Review the [Lang team project board](https://github.com/rust-lang/lang-team/proj  ## Nominated RFCs -{{-issues::render(issues=nominated_rfcs, indent="  ", empty="No nominated RFCs this time.")}}+{{-issues::render(issues=nominated_rfcs_t_lang, indent="  ", empty="No nominated RFCs this time.")}}

Wouldn't change this file either

apiraino

comment created time in 2 days

Pull request review commentrust-lang/triagebot

Add RFCs for T-compiler

 pub fn lang<'a>() -> Box<dyn Action> {      //https://github.com/rust-lang/rfcs/pulls?q=is%3Aopen+is%3Apr+label%3AI-nominated+label%3AT-lang     queries.push(QueryMap {-        name: "nominated_rfcs",+        name: "nominated_rfcs_t_lang",

I wouldn't change this one because it doesn't belong to prioritization wg.

apiraino

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventspastorino/rust

Santiago Pastorino

commit sha 03321b8cca91cd5d1f9c82a447add69329e52cea

Add inline const to INCOMPLETE_FEATURES

view details

push time in 3 days

push eventspastorino/rust

nasso

commit sha 45f67625291af6432c42b99a3b68b2b77fb8ad9c

Add a setting to use the system theme

view details

nasso

commit sha 3a6437cd985f11c978da5fa15c5dea7a9d0393c2

Remove unnecessary refs

view details

nasso

commit sha db7c8f4c3c181b14cc1d12ee1a5a17e249dbc65b

Coding style fixes

view details

Tomasz Miąsko

commit sha db547520822eaa8cde18be0788cbad144c67b636

Create a single source scope for promoteds A promoted inherits all scopes from the parent body. At the same time, almost all statements and terminators inside the promoted body so far refer only to one of those scopes: the outermost one. Instead of inheriting all scopes, inherit only a single scope corresponding to the location of the promoted, making sure that there are no references to other scopes.

view details

Dániel Buga

commit sha 52ff31a7ebfab8d0b1f5d28fab917150a5f3814d

Arena: Copy cold_path and remove rustc_data_structures dependency

view details

nasso

commit sha 59f9cf2ac1872866a9a2d4b83f56b96f131a6a5e

Set preferred-dark-theme to the last dark theme If the user doesn't have a preferred dark theme but is already using a dark theme, set the preferred dark theme to be that theme

view details

bors

commit sha 9bd740a8f17d75168b683bcfb077b6e450047df5

Auto merge of #77947 - tmiasko:promoted-scope, r=oli-obk Create a single source scope for promoteds A promoted inherits all scopes from the parent body. At the same time, almost all statements and terminators inside the promoted body so far refer only to one of those scopes: the outermost one. Instead of inheriting all scopes, inherit only a single scope corresponding to the location of the promoted, making sure that there are no references to other scopes.

view details

Mara Bos

commit sha b8dcd2fbce4550b1ef46d270546bd8480098cdca

Take sys/vxworks/mutex from sys/unix instead.

view details

Mara Bos

commit sha f3f30c7132c20825833074044b00c7e02016ca25

Take sys/vxworks/condvar from sys/unix instead.

view details

Mara Bos

commit sha f875c8be5ddfc734558a1f5d4cb9800477c3f1a1

Take sys/vxworks/rwlock from sys/unix instead.

view details

Mara Bos

commit sha d1947628b568c1d59048288486e68d917709f4d4

Take sys/vxworks/time from sys/unix instead.

view details

Mara Bos

commit sha c8628f43bfe9df8b06283fdc1d8acb4643f74194

Take sys/vxworks/stack_overflow from sys/unix instead.

view details

Mara Bos

commit sha 5d526f6eee0e700084a28dad482b66891038a8f5

Take sys/vxworks/thread from sys/unix instead.

view details

Mara Bos

commit sha 4853a6e78e7ad6ec2ad63c3f23929ed027255b3f

Take sys/vxworks/stdio from sys/unix instead.

view details

Mara Bos

commit sha 678d078950b1a6a822545db44fe3f87ac302f8f3

Take sys/vxworks/thread_local_key from sys/unix instead.

view details

Mara Bos

commit sha 66c9b04e947996c9ac3c573228ed2a641fb6f249

Take sys/vxworks/alloc from sys/unix instead.

view details

Mara Bos

commit sha c909ff957752104e1c52d20d7e0e98cf50781a25

Add weak macro to vxworks.

view details

Mara Bos

commit sha a489c33bebaee645efa8be0c9455bed89ef6dd41

Take sys/vxworks/ext/* from sys/unix instead.

view details

Mara Bos

commit sha dce405ae3dd5996a3f97f13f40f87f23261f8ccd

Take sys/vxworks/net from sys/unix instead.

view details

Mara Bos

commit sha 08bcaac0913a8efe0a6b21255d9c850dc1229894

Take sys/vxworks/memchar from sys/unix instead.

view details

push time in 3 days

push eventspastorino/rust

Mateusz Mikuła

commit sha 0ad3da06843089c0bf10d6caa3fbbc72fa67787a

Enable ASLR for windows-gnu

view details

Tim Nielens

commit sha 390a13b06c79d4177b829097b06453e38188081f

needless-lifetime - fix nested elision site FPs

view details

Tim Nielens

commit sha a60e5de90c7370d4fb3e6561d3cb55495cda2e2a

needless-lifetime / nested elision sites / PR remarks

view details

Tim Nielens

commit sha c8e9e52303da6dff4bc5cc4db3021d608fca6c70

needless-lifetime / add test cases for nested elision sites

view details

Takayuki Nakata

commit sha 1778a1ec4615a42a8ba9497006b07859186c08a1

Restrict `same_item_push` to suppress false positives It emits a lint when the pushed item is a literal, a constant and an immutable binding that are initialized with those.

view details

Takayuki Nakata

commit sha 0117ea2b016133145f9e02e27421ac3672b42f57

Refactoring: use inner function

view details

Takayuki Nakata

commit sha b80576fba633e1fc214c9f6900d7ca3424bda6d0

Some refactoring

view details

Takayuki Nakata

commit sha 14faebe20ea82392f393c3ff5efaab7250e51989

Add some tests to `same_item_push` Add tests in which the variable is initialized with a match expression and function call

view details

Takayuki Nakata

commit sha 2972ad3ef661071531a61ec8999b668a6b734b74

Refactoring: tests in `same_item_push`

view details

Takayuki Nakata

commit sha 730ca457f580247667ed0cd5965bc08752ebc0b3

Address `items_after_statement`

view details

Nathan West

commit sha a02014280586b53997622c501db00398376967a8

Refactor io/buffered.rs into submodules

view details

Nathan West

commit sha 96229f02402e82914ec6100b28ad2cbdd273a0d4

move buffered.rs to mod.rs

view details

Dylan MacKenzie

commit sha 72b402ed38f0c71461038aef8a49a02e49280788

Add pass names to some common dataflow analyses

view details

Nathan West

commit sha 6d75cdfc9ed9e6987bd23add6cf3954d2499dce2

Added updated compiler diagnostic

view details

Amjad Alsharafi

commit sha da700cba08a2b194d19e63d3c51ebadce96fe46b

Stabilize move_ref_pattern

view details

Amjad Alsharafi

commit sha afb9eeb1b9ea16ca65e38673a0ef3e7be81d7252

Disabled error `E0007` from rustc_error_codes

view details

Nathan West

commit sha c4280af8285c61b367a87c8f6eef9876011a8150

Retry fix error reporting suggestions

view details

Aaron Hill

commit sha cfe07cd42a92610219d6ffc1ae5eefef42f5254a

Use llvm::computeLTOCacheKey to determine post-ThinLTO CGU reuse During incremental ThinLTO compilation, we attempt to re-use the optimized (post-ThinLTO) bitcode file for a module if it is 'safe' to do so. Up until now, 'safe' has meant that the set of modules that our current modules imports from/exports to is unchanged from the previous compilation session. See PR #67020 and PR #71131 for more details. However, this turns out be insufficient to guarantee that it's safe to reuse the post-LTO module (i.e. that optimizing the pre-LTO module would produce the same result). When LLVM optimizes a module during ThinLTO, it may look at other information from the 'module index', such as whether a (non-imported!) global variable is used. If this information changes between compilation runs, we may end up re-using an optimized module that (for example) had dead-code elimination run on a function that is now used by another module. Fortunately, LLVM implements its own ThinLTO module cache, which is used when ThinLTO is performed by a linker plugin (e.g. when clang is used to compile a C proect). Using this cache directly would require extensive refactoring of our code - but fortunately for us, LLVM provides a function that does exactly what we need. The function `llvm::computeLTOCacheKey` is used to compute a SHA-1 hash from all data that might influence the result of ThinLTO on a module. In addition to the module imports/exports that we manually track, it also hashes information about global variables (e.g. their liveness) which might be used during optimization. By using this function, we shouldn't have to worry about new LLVM passes breaking our module re-use behavior. In LLVM, the output of this function forms part of the filename used to store the post-ThinLTO module. To keep our current filename structure intact, this PR just writes out the mapping 'CGU name -> Hash' to a file. To determine if a post-LTO module should be reused, we compare hashes from the previous session. This should unblock PR #75199 - by sheer chance, it seems to have hit this issue due to the particular CGU partitioning and optimization decisions that end up getting made.

view details

rail

commit sha 5e393c7747d081c45414060f81016e9ea3cb961f

Fix a FP in `explicit_counter_loop` Fix a false positive in `explicit_counter_loop` where the loop counter is used after incremented, adjust the test so that counters are incremented at the end of the loop and add the test for this false positive.

view details

Eduardo Broto

commit sha 3e294b22a43be349262405715cf4885296c284ba

Revert "or_fn_call: ignore nullary associated const fns" This reverts commit 7a66e6502dc3c7085b3f4078c01d4957d96175ed.

view details

push time in 3 days

Pull request review commentrust-lang/rust

Implement const expressions and patterns (RFC 2920)

 impl<'a> Parser<'a> {             let pat = self.parse_pat_with_range_pat(false, None)?;             self.sess.gated_spans.gate(sym::box_patterns, lo.to(self.prev_token.span));             PatKind::Box(pat)+        } else if self.check_keyword(kw::Const) {

I was thinking about that at some point, went ahead tried out and yeah, the test is now fixed.

spastorino

comment created time in 3 days

PullRequestReviewEvent

push eventspastorino/rust

Santiago Pastorino

commit sha 829b784bb7c9dcd396bf48103974ba68a3ebdd86

Parse inline const expressions

view details

Santiago Pastorino

commit sha f963de474f6f00d0beaa4fe9f3d91ee09ee09964

Parse inline const patterns

view details

Santiago Pastorino

commit sha a6ddd6929f80340cc4b10da047fb8311078ddd3b

Lower inline const's AST to HIR

view details

Santiago Pastorino

commit sha 6f1d227e79c868151056906b671fc7cf632eb653

Lower inline const down to MIR

view details

Santiago Pastorino

commit sha c2a4d560cad9dd028ca9452a30d4d78829b07623

Typeck inline consts

view details

Santiago Pastorino

commit sha 661a40c9ba8526cbe0a3be0eef9e1d007d9f16f2

Add inline const tests

view details

Santiago Pastorino

commit sha 5b63cceac48a062107961038745c28b881df5e8f

Handle ExprKind::ConstBlock on clippy

view details

Santiago Pastorino

commit sha 7fec7a27801bad01d80d27d4b19cf724678b3348

Add check_generic_arg early pass

view details

Santiago Pastorino

commit sha 176b79078e268bc1f2f6d7316fc1b3be1bb17508

Do not check unused braces on inline consts

view details

push time in 3 days

issue commentrust-lang/compiler-team-prioritization

Automatically accept/reject beta/stable nominations

Btw there is no beta-rejected label. The procedure is "add beta-accepted (without removing beta-nominated) if accepted, or remove beta-nominated if rejected.

ah good point, didn't know that. Are you referring to this documentation? In my opinion, not as clear as you wrote it here. Worth a small PR to clarify the wording?

I think @LeSeulArtichaut refers to our wg procedure document, I think there it's clear or at least should :).

spastorino

comment created time in 4 days

issue commentrust-lang/compiler-team

Don't build tools by default with `x.py build`

You meant that this was accepted but then rejected and it's not going to be implemented? or why would you remove major-change-accepted?

jyn514

comment created time in 4 days

PR opened rust-lang/team

Remove spastorino from cleanup crew

I've added myself to this group at the very beginning as a way to test things out and never removed myself, so here I am :).

+0 -1

0 comment

1 changed file

pr created time in 4 days

create barnchspastorino/team

branch : remove-me-from-cleanup

created branch time in 4 days

pull request commentrust-lang/rust

Fix trait solving ICEs

If this needs "high priority", over rollups, it needs at least p=6: priorities 1 to 5 can be skipped by rollups

I'm not sure if we have a policy but I'd make this kind of PR higher priority than rollups, yeah.

matthewjasper

comment created time in 4 days

create barnchspastorino/blog.rust-lang.org

branch : fix-url-typo

created branch time in 4 days

issue commentrust-lang/rust

ICE: Expected module, found DefId

@rustbot ping cleanup

This needs mcve and bisection

matthiaskrgr

comment created time in 4 days

pull request commentrust-lang/rust

Fix trait solving ICEs

@bors p=1

When this is merged it needs high priority because it fixes P-critical issues.

matthewjasper

comment created time in 4 days

pull request commentrust-lang/rust

Do not ICE with TraitPredicates containing [type error]

discussed in T-compiler meeting, declined to backport.

@rustbot modify labels: -stable-nominated

estebank

comment created time in 4 days

pull request commentrust-lang/rust

Do not ICE with TraitPredicates containing [type error]

discussed in T-compiler meeting.

@rustbot modify labels: beta-accepted

estebank

comment created time in 4 days

pull request commentrust-lang/rust

Update crossbeam-channel to avoid UB

discussed in T-compiler meeting.

@rustbot modify labels: beta-accepted

mati865

comment created time in 4 days

pull request commentrust-lang/rust

rustc_parse: More precise spans for `tuple.0.0`

discussed in T-compiler meeting.

@rustbot modify labels: beta-accepted

petrochenkov

comment created time in 4 days

issue closedrust-lang/compiler-team

Integration of the Cranelift backend with rustc

<!--

Directions

If you'd like to propose a major change to rustc, you've come to the right place! To do so, please write-up your proposal using this template.

Describe your major change in a sentence or two under the TL;DR section.

If available, add links and more descriptions in the "Links and Details" section. Note: it is not expected that you write a fully fleshed out proposal there. Just add any information you think is important.

List people already mentoring you on this change or reviewing this change in the "Mentors or Reviewers" section If there are none, you can also add people that you think would be a good fit. You can look at the experts map for ideas. You can leave this empty if you don't know or are unsure about who to put into the list.

Oh, and please delete this section before you open the issue -- but keep the others! -->

TL;DR

  • Bring my Cranelift based codegen backend in tree using git subtree and gate PR's on it building.
  • Extend the testing infrastructure to annotate tests as being specific for a single backend and annotate all LLVM specific tests.

Links and Details

This will first use git subtree to integrate the cg_clif repo. Then changes to bootstrap and compiletest are needed to be able to build and test it. Next CI will need to gate PR's on cg_clif building. CI will not run any tests for cg_clif. Finally all add a way to annotate tests as requiring a specific backend and annotate all LLVM specific tests as such.

  • The Cranelift backend: https://github.com/bjorn3/rustc_codegen_cranelift
  • Design meeting proposal: #257
  • Pre-meeting details: https://hackmd.io/@bjorn3/HJL5ryFS8
  • Meeting notes: https://github.com/rust-lang/compiler-team/pull/269
  • Complete discussion: https://zulip-archive.rust-lang.org/131828tcompiler/01241designmeeting20200403compilerteam257.html

Mentors or Reviewers

Maybe @Mark-Simulacrum for bootstrap changes?

closed time in 5 days

bjorn3

issue commentrust-lang/compiler-team

`ty.kind()` -> `ty.data()`

@nikomatsakis how should we proceed here? maybe remove final-comment-period and have somebody seconding this again when there are no more concerns?.

nikomatsakis

comment created time in 5 days

push eventspastorino/vinimum

Santiago Pastorino

commit sha 5b34dcfca74acf1ae95e41f9e2e7548f4db87653

Fix RUST_SRC_PATH directory

view details

Santiago Pastorino

commit sha 5f003f34bfcde3412bbe923016af4eef0b549775

Search for tags in root/.tags

view details

Santiago Pastorino

commit sha a43a8e1ada87c2048e3eaf0baa669ee6cd75bcb7

Add maps to navigate errors

view details

push time in 6 days

issue commentrust-lang/compiler-team-prioritization

Automatically accept/reject beta/stable nominations

Perhaps would you like something more like in this comment?

:+1:, we should just fire that comment that also does the labelling adjustments.

spastorino

comment created time in 7 days

issue commentrust-lang/rust

Tracking issue for renaming crates inside compiler directory

Should we label as S-waiting-on-team? or if not maybe we should nominate so this is discussed on next compiler meeting.

Dylan-DPC

comment created time in 7 days

pull request commentrust-lang/rust

Update `changelog-seen` in config.toml.example

@bors r+ rollup=always

jyn514

comment created time in 9 days

pull request commentrust-lang/rust

Use separate sysroot directories for `check` and `build`

:+1: but, what happens if you run check twice or build twice?. Maybe a solution like this one is a pragmatic enough one anyway?.

jyn514

comment created time in 9 days

Pull request review commentrust-lang/rust

Add regression issue template

+---+name: Regression+about: Report a regression in Rust.+labels: C-bug+---+<!--+Thank you for filing a bug report! 🐛 Please provide a short summary of the bug,+along with any information you feel relevant to replicating the bug.+-->++### Code++I tried this code:++```rust+<code>+```+I expected to see this happen: *explanation*++Instead, this happened: *explanation*++### Version it worked on++<!--+Provide the most recent version this worked on, for example:++It most recently worked on: Rust 1.47+-->++It most recently worked on: <!-- version -->++### Version with regression++<!--+Provide the version you are using that has the regression.+-->++`rustc --version --verbose`:+```+<version>+```++<!--+Did the compiler crash? If so, please provide a backtrace.+-->++### Backtrace+<!--+Include a backtrace in the code block by setting `RUST_BACKTRACE=1` in your+environment. E.g. `RUST_BACKTRACE=1 cargo build`.+-->+<details><summary>Backtrace</summary>+<p>++```+<backtrace>+```++</p>+</details>++<!--+Please change `nightly` to the release channel you found this regression in (stable, beta, or nightly).+-->++@rustbot modify labels: regression-from-stable-to-nightly

By the way, I've noticed as @Mark-Simulacrum points out that from time to time we've things tagged as nightly regressions that are beta regressions. As part of @rust-lang/wg-prioritization effort, I've been checking the ones that we track for the compiler weekly meeting.

I wonder if we could make a process on Triage WG and/or Prioritization WG and even automate some stuff to more actively check that the regressions are correctly labelled.

camelid

comment created time in 9 days

PullRequestReviewEvent

Pull request review commentrust-lang/blog.rust-lang.org

Add post about using regression labels

+---+layout: post+title: "Marking issues as regressions"+description: "Now anyone can mark issues as regressions!"+author: Camelid+team: the release team <https://www.rust-lang.org/governance/teams/operations#release>+---++If you've contributed to Rust before, you have likely used a command like this+to [set labels][rustbot-labeling-docs]:++> @**rustbot** modify labels: A-typesystem C-enhancement

why don't we just do @rustbot modify ... which is what the user writes?

camelid

comment created time in 9 days

PullRequestReviewEvent

pull request commentrust-lang/rust

[WIP] Do not make local copies of inline fns in debug mode

@crlf0710 will be working on this soon :).

spastorino

comment created time in 10 days

pull request commentrust-lang/rustc-dev-guide

Recommend setting up `check_line_lengths` as a pre-commit script

I should've read what this was about :joy:, I thought it was a script to check Rust source files length before commit, that's why I was thinking about ignoring those. Anyway, nevermind.

jyn514

comment created time in 10 days

PullRequestReviewEvent

pull request commentrust-lang/blog.rust-lang.org

Add post about using regression labels

This is great!!! :+1:

camelid

comment created time in 10 days

pull request commentrust-lang/rust

Implement const expressions and patterns (RFC 2920)

I think this is now ready for a final review. It may be worth adding more tests and I'd like to hear from you what kind of test cases should we add.

cc also @eddyb

spastorino

comment created time in 10 days

push eventspastorino/rust

Santiago Pastorino

commit sha 8bd9db572695c6cad48608e6f158ec951255493b

Add check_generic_arg early pass

view details

Santiago Pastorino

commit sha 3909660e0f3557235bfb8d4fadcc82d9d4e94cf3

Do not check unused braces on inline consts

view details

push time in 10 days

push eventspastorino/rust

Santiago Pastorino

commit sha db5c8d2b9771c61e533172f0dea3bf247af6c58f

Do not check unused braces on inline consts

view details

push time in 10 days

push eventspastorino/rust

Santiago Pastorino

commit sha 9dd71eded7014df0a63a3a82ccc8df4c62aa8e7d

Fix lints

view details

push time in 10 days

push eventspastorino/rust

Santiago Pastorino

commit sha b6536136e25e3a323495f4935c572c8eb6772a3f

Fix lints

view details

push time in 10 days

push eventspastorino/rust

Santiago Pastorino

commit sha cf5210c0479fda02c360a9d56ae5cf3ebd7dacd6

Add inline const tests

view details

Santiago Pastorino

commit sha 4fdf5be7fd18b9b1084cac5a42dc165e02a7481e

Handle ExprKind::ConstBlock on clippy

view details

Santiago Pastorino

commit sha 60a8ae331bdf2a83c20c3c57bf86c4c2a4f8779c

Fix lints

view details

push time in 10 days

push eventspastorino/rust

Hanif Bin Ariffin

commit sha dc655b28424549a4775bc2e8c9021d44482bccb1

Prevent stackoverflow

view details

Stein Somers

commit sha 3b051d0171b4e15aff4d2ecacf7659f7278e8e09

BTreeMap: comment why drain_filter's size_hint is somewhat pessimistictid

view details

Dylan MacKenzie

commit sha 29e5e6e766a6aab504b01697f8670f72ec10e8ad

Use MIR dump interface for dataflow

view details

Dylan MacKenzie

commit sha 3b873987381cd8236b6f6e8129ad5c3570cbae68

Print to `stderr` when a graphviz file can't be written `warn` prints nothing by default

view details

Joshua Nelson

commit sha 2a41342e9ceabc72ec591a64fefb165729b5fbdc

Make src/bootstrap/CHANGELOG.md more helpful

view details

Guillaume Gomez

commit sha 0e45ad890dc1dcbc1d19ce0647e5f3d07284e7b2

Fix tooltip text display

view details

Steve Manuel

commit sha 56b51a9751600dd65ad4bbda5c0f3d7b8c6db970

(docs): make mutex error comment consistent with codebase

view details

Simon Vandel Sillesen

commit sha e231c47aa608b15aa427bc7a8859d87a022c1cfd

perf: UninhabitedEnumBranching void n^2 Avoid n² complexity. This showed up in a profile for match-stress-enum that has 8192 variants

view details

Esteban Küber

commit sha e5f83bcd04e85b8ae5f04d2d95dd9af774d422e2

Detect blocks that could be struct expr bodies This approach lives exclusively in the parser, so struct expr bodies that are syntactically correct on their own but are otherwise incorrect will still emit confusing errors, like in the following case: ```rust fn foo() -> Foo { bar: Vec::new() } ``` ``` error[E0425]: cannot find value `bar` in this scope --> src/file.rs:5:5 | 5 | bar: Vec::new() | ^^^ expecting a type here because of type ascription error[E0214]: parenthesized type parameters may only be used with a `Fn` trait --> src/file.rs:5:15 | 5 | bar: Vec::new() | ^^^^^ only `Fn` traits may use parentheses error[E0107]: wrong number of type arguments: expected 1, found 0 --> src/file.rs:5:10 | 5 | bar: Vec::new() | ^^^^^^^^^^ expected 1 type argument ``` If that field had a trailing comma, that would be a parse error and it would trigger the new, more targetted, error: ``` error: struct literal body without path --> file.rs:4:17 | 4 | fn foo() -> Foo { | _________________^ 5 | | bar: Vec::new(), 6 | | } | |_^ | help: you might have forgotten to add the struct literal inside the block | 4 | fn foo() -> Foo { Path { 5 | bar: Vec::new(), 6 | } } | ``` Partially address last part of #34255.

view details

Kazantcev Andrey

commit sha 141544a903d4eb049d0611cbe6c7d248d3f5d425

Remove unnecessary lamda on emitter map.

view details

bors

commit sha 91a79fb29ac78d057d04dbe86be13d5dcc64309a

Auto merge of #76985 - hbina:clone_check, r=estebank Prevent stack overflow in deeply nested types. Related issue #75577 (?) Unfortunately, I am unable to test whether this actually solves the problem because apparently, 12GB RAM + 2GB swap is not enough to compile the (admittedly toy) source file.

view details

Joshua Nelson

commit sha 8b22d079bfff6c534398a4e2b91787a2ae929125

Upgrade to tracing 0.2.13 The primary motivation is to get the changes from https://github.com/tokio-rs/tracing/pull/990. Example output: ``` $ RUSTDOC_LOG=debug rustdoc +rustc2 warning: some trace filter directives would enable traces that are disabled statically | `debug` would enable the DEBUG level for all targets = note: the static max level is `info` = help: to enable DEBUG logging, remove the `max_level_info` feature ``` - Remove useless test This was testing for an ICE when passing `RUST_LOG=rustc_middle`. I noticed it because it started giving the tracing warning (because tests are not run with debug-logging enabled). Since this bug seems unlikely to re-occur, I just removed it altogether.

view details

bors

commit sha e055f87cdfcac1f4da6c518a547dee459de0aa26

Auto merge of #77597 - simonvandel:uninhabited-hashset, r=jonas-schievink perf: UninhabitedEnumBranching avoid n^2 Avoid n² complexity. This showed up in a profile for match-stress-enum that has 8192 variants I have only profiled locally against `match-stress-enum`, so we should have it perf tested to make sure it does not regress other crates.

view details

Joshua Nelson

commit sha f4989494bf21636763ba3ad5f9181c363b399257

Unset GIT_DIR in pre-commit hook Works around https://github.com/rust-lang/rust/issues/77620

view details

Mark Rousskov

commit sha d8c035abbf534d5e4101c2d4fb804a9e26dd6ccd

Bump to 1.48 bootstrap compiler

view details

est31

commit sha 7367cfef598acb81a5e09b3bb28f55d01e35b4a3

Use shorter path for std::hash::Hash

view details

bors

commit sha d9985fc1081849532546d74c35a276694833c09d

Auto merge of #75470 - estebank:bare-type-expr, r=davidtwco Detect blocks that could be struct expr bodies This approach lives exclusively in the parser, so struct expr bodies that are syntactically correct on their own but are otherwise incorrect will still emit confusing errors, like in the following case: ```rust fn foo() -> Foo { bar: Vec::new() } ``` ``` error[E0425]: cannot find value `bar` in this scope --> src/file.rs:5:5 | 5 | bar: Vec::new() | ^^^ expecting a type here because of type ascription error[E0214]: parenthesized type parameters may only be used with a `Fn` trait --> src/file.rs:5:15 | 5 | bar: Vec::new() | ^^^^^ only `Fn` traits may use parentheses error[E0107]: wrong number of type arguments: expected 1, found 0 --> src/file.rs:5:10 | 5 | bar: Vec::new() | ^^^^^^^^^^ expected 1 type argument ``` If that field had a trailing comma, that would be a parse error and it would trigger the new, more targetted, error: ``` error: struct literal body without path --> file.rs:4:17 | 4 | fn foo() -> Foo { | _________________^ 5 | | bar: Vec::new(), 6 | | } | |_^ | help: you might have forgotten to add the struct literal inside the block | 4 | fn foo() -> Foo { Path { 5 | bar: Vec::new(), 6 | } } | ``` Partially address last remaining part of #34255.

view details

bors

commit sha cc662cd4540c6d3b8cb14cf535fa023699503dff

Auto merge of #77683 - jyn514:git-hook, r=Mark-Simulacrum Unset GIT_DIR in pre-commit hook Works around https://github.com/rust-lang/rust/issues/77620. This won't help any other hooks you write manually, but hopefully people won't feel the need to do that now there's an 'official' one. r? `@Mark-Simulacrum` cc `@caass`

view details

est31

commit sha 8b8e706008111fa3865e8da76eeddabfbf9851f0

Simplify some code in rustc_llvm/build.rs now that LLVM 8 is required LLVM 8 is required since 8506bb006040cf8e8cb004202706c81e62ddacee so this is safe to do.

view details

Joshua Nelson

commit sha fa1b15f6279a95923b8a19046f45f27f243d49d2

Preserve the parent module of `DocFragment`s - Add `parent_module` to `DocFragment` - Require the `parent_module` of the item being inlined - Preserve the hir_id for ExternCrates so rustdoc can find the parent module later - Take an optional `parent_module` for `build_impl` and `merge_attrs`. Preserve the difference between parent modules for each doc-comment. - Support arbitrarily many re-exports in from_ast. In retrospect this is probably not used and could be simplified to a single `Option<(Attrs, DefId)>`. - Don't require the parent_module for all `impl`s, just inlined items In particular, this will be `None` whenever the attribute is not on a re-export. - Only store the parent_module, not the HirId When re-exporting a re-export, the HirId is not available. Fortunately, `collect_intra_doc_links` doesn't actually need all the info from a HirId, just the parent module.

view details

push time in 10 days

push eventspastorino/rust

Santiago Pastorino

commit sha 676c2375b946954352721ce42449d2b5059befaa

Fix lints

view details

push time in 10 days

push eventspastorino/rust

Santiago Pastorino

commit sha 4f1811a6f13f372c20871b245e58b10d4d713847

Parse inline const expressions

view details

Santiago Pastorino

commit sha 8312587e84e78aff9611f75d26753b48e327111b

Parse inline const patterns

view details

Santiago Pastorino

commit sha 7dbd852ff3cd0f9674bf9461f4dba1dd54e28260

Lower inline const's AST to HIR

view details

Santiago Pastorino

commit sha 4f238f256df5d4d6546a42569a7ba8c0c481e77e

Lower inline const down to MIR

view details

Santiago Pastorino

commit sha 23c0492f4f6ece4116164a08c40997e9eebaa2c9

Typeck inline consts

view details

Santiago Pastorino

commit sha e1290fa8669b23b8c2f971c503a7ea7ac8d12450

Add inline const tests

view details

Santiago Pastorino

commit sha 3e5e180506f19a9718325c7555e9ce8e6e570af7

Handle ExprKind::ConstBlock on clippy

view details

push time in 11 days

pull request commentrust-lang/rust-forge

Explain a bit more about Prioritization summaries

I'm all for helping the team acquiring a context about the issue, but I'm afraid that adding more prose, such as a "digest" meant to be really meaningful, could end up having an agenda with wall of texts which (imo) would be opposite of the indent here.

Agree with this, we can also close the PR and open a new one approaching a different strategy. But :+1: that the idea with the summaries is to help and having something short, that gives hints that go right to the point is the most desirable thing to do, rather than have walls of texts around.

spastorino

comment created time in 11 days

Pull request review commentrust-lang/rust-forge

Explain a bit more about Prioritization summaries

 We will have checkins from *WG-X* and *WG-Y*  ### Add details to the Agenda +In order to summaries issues take into account that is important to add+details that make the meeting be more effective and faster. For that+consider mentioning important actors, important details like is a+regression and when it has regressed or if it already has a PR.+Properly read the issue to summarize it and also process the+Prioritization WG stream topic related to the issue to extract other+useful information.

Yeah agree, maybe writing in a more general way would be better. I guess we should merge this and keep improving the text in separate PRs.

spastorino

comment created time in 11 days

PullRequestReviewEvent

pull request commentrust-lang/rust-forge

Explain a bit more about Prioritization summaries

I think this section helps understanding why we do summaries, so +1 I personally find the wording a bit unclear sometimes but that could be improved in a separate PR.

Yeah, please do fix my wording here :heart:

spastorino

comment created time in 11 days

pull request commentrust-lang/rust-forge

Explain a bit more about Prioritization summaries

We could probably add an example for a "perfect" summary or add a few basic facts that are important to add (like regressed PR / commit, Author, etc)

Agree about the example, maybe we should merge this and if someone can work on an example about it it would be great.

spastorino

comment created time in 11 days

push eventspastorino/rust-forge

Santiago Pastorino

commit sha 6bfc8eb22308f81f778398213512e61d48dda260

Update src/compiler/prioritization/procedure.md Co-authored-by: Jeremy Lempereur <jeremy.lempereur@gmail.com>

view details

push time in 11 days

push eventspastorino/rust-forge

Santiago Pastorino

commit sha 035f4801df38dc5248c02f1e182cfff31b17bb47

Update src/compiler/prioritization/procedure.md Co-authored-by: Jeremy Lempereur <jeremy.lempereur@gmail.com>

view details

push time in 11 days

push eventspastorino/rust-forge

Santiago Pastorino

commit sha 2061b8d470663319bcb745e19d4f003f3b79fcc4

Update src/compiler/prioritization/procedure.md Co-authored-by: Jeremy Lempereur <jeremy.lempereur@gmail.com>

view details

push time in 11 days

push eventspastorino/rust-forge

Santiago Pastorino

commit sha e9845a7d5e2e8d4d9b839fa8eb2247a857c2c4f6

Update src/compiler/prioritization/procedure.md Co-authored-by: Jeremy Lempereur <jeremy.lempereur@gmail.com>

view details

push time in 11 days

push eventrust-lang/rust-forge

apiraino

commit sha 4980dcde8be3b55991b6cf919c30dbbbbc4f3b4a

fix typo

view details

Santiago Pastorino

commit sha eb8f938c88b4a8375af68edf9e63c423b6df0250

Merge pull request #453 from apiraino/patch-1 fix typo

view details

push time in 11 days

PR merged rust-lang/rust-forge

fix typo

@spastorino just a typo that blocks reaching the referred paragraph

+1 -1

0 comment

1 changed file

apiraino

pr closed time in 11 days

PullRequestReviewEvent

push eventrust-lang/compiler-team

Santiago Pastorino

commit sha 7c6471d8bda510eeb7f6e61efada0ea0010752d0

Show dates starting on day of weekly meeting

view details

Santiago Pastorino

commit sha bc21ffeb9a8fa045041359ebc66b643b2bb48dba

Adjust magic number after changing the number of working groups to keep the same checkins order

view details

push time in 11 days

push eventrust-lang/compiler-team

apiraino

commit sha 686b088caa977e2b23076d82a4968a32f45a2d7f

Remove WG-prioritization from compiler meetings checkins

view details

apiraino

commit sha acf3be4d34eb4f09a310b1209391270c11adcd7c

Fix a small rendering issue, update README

view details

Santiago Pastorino

commit sha 88e78309a9a1e030c51b76bf111c65ebe10f4666

Merge pull request #367 from apiraino/remove-wgprio-checkin Remove WG-prioritization checkin

view details

push time in 11 days

PR merged rust-lang/compiler-team

Remove WG-prioritization checkin

Discussed this with @spastorino on Zulip.

The WG-prioritization does not usually report during the compiler meeting (only when it is needed), so we can remove it from the regular scheduling.

Notice: due to the way the checkins are rotated, to avoid duplicated checkins from other WG, this PR should not be merged before Friday October, 9th 2020

Unrelated small changes:

  • add a notice in the README to use the extended Hugo version for local testing
  • fix a minor typo in the markdown
+2 -4

0 comment

3 changed files

apiraino

pr closed time in 11 days

pull request commentrust-lang/rust

Update RLS and Rustfmt

discussed in T-compiler meeting.

@rustbot modify labels: beta-accepted

Xanewok

comment created time in 11 days

pull request commentrust-lang/rust

Move `EarlyOtherwiseBranch` to mir-opt-level 2

discussed in T-compiler meeting.

@rustbot modify labels: beta-accepted

ecstatic-morse

comment created time in 11 days

PR opened rust-lang/rust-forge

Explain a bit more about Prioritization summaries

r? @XAMPPRocky but wait for someone else from @rust-lang/wg-prioritization to approve in particular @apiraino

+8 -0

0 comment

1 changed file

pr created time in 11 days

create barnchspastorino/rust-forge

branch : prioritization-summaries

created branch time in 11 days

push eventspastorino/rust

Matt Brubeck

commit sha b4b383981abac7ca8aa180c7ae3e28876615b887

Add PartialEq impls for Vec <-> slice

view details

Cassandra Fridkin

commit sha a009e2838b25df2761093d727d322a59f69d8f68

There isn't a way to pass --remove yet, but you can rm if u like

view details

Alexis Bourget

commit sha 492826ac144666c75d68bc0a0121453ecc08561f

Add a note about the panic behavior of math operations on time objects

view details

LingMan

commit sha a6ff925f8b5598a1f6d84964525baa1d4a08fd63

Reduce boilerplate with the matches! macro Replaces simple bool `match`es of the form match $expr { $pattern => true _ => false } and their inverse with invocations of the matches! macro.

view details

David Wood

commit sha 9ef68f53e1f882afb63f824a10ff33ccd2c4764b

resolve: improve "try using the enum's variant" This commit improves the "try using the enum's variant" suggestion: - Variants in suggestions would not result in more errors (e.g. use of a struct variant is only suggested if the suggestion can trivially construct that variant). Therefore, suggestions are only emitted for variants that have no fields (since the suggestion can't know what value fields would have). - Suggestions include the syntax for constructing the variant. If a struct or tuple variant is suggested, then it is constructed in the suggestion - unless in pattern-matching or when arguments are already provided. - A help message is added which mentions the variants which are no longer suggested. Signed-off-by: David Wood <david@davidtw.co>

view details

Guillaume Gomez

commit sha e6027a42e109fef10f4fc27ebede50d1b3d203f0

Add `unclosed_html_tags` lint

view details

Guillaume Gomez

commit sha 5fcbf4668ecab0ff798ea076757e27760c90aff5

Add doc for invalid_html_tag lint

view details

Guillaume Gomez

commit sha bc6ec6fe36c5c902da900fea67cba30fad4b0b6b

Add test for unclosed_html_tag lint

view details

Guillaume Gomez

commit sha 6271a0a46dedd5eaf3eb26afb6ae536939496cd7

Improve invalid_html_tags lint span

view details

Guillaume Gomez

commit sha f9a65afb27e0093b56053f810952efcba3e718e5

Make invalid_html_tags lint only run on nightly and being allowed by default

view details

Guillaume Gomez

commit sha 4a3746e67b06bfd3bd11c8cae1c3acab944211bf

Fix visitor for invalid_html_tag lint

view details

Guillaume Gomez

commit sha 6163d892248a2af02b36a0121bb5bf02a5566d2b

Improve code

view details

Guillaume Gomez

commit sha b2321bb8da18c753fe3b9b71937a368ae42b8c4b

Add test for invalid_html_tag lint in deny(rustdoc)

view details

Guillaume Gomez

commit sha 30cabfd215f374b855f6d6473b00a55c3511c3e2

Don't warn if the tag is nested inside a <script> or inside a <style>

view details

Guillaume Gomez

commit sha 5bc148957efc0bf4640d3d6b3e1824c00f1156e8

Correctly handle unicode characters and tags being open just before the end of the doc comment

view details

Guillaume Gomez

commit sha ca199b16e5c06c28b3d35de79ffaaff81bd0d43f

Use char_indices() instead of chars() to prevent more than one-byte characters issue

view details

Guillaume Gomez

commit sha d3b7b7e23a58e772194677b54672ff118ecc9093

Enforce closing HTML tags to have a ">" character

view details

Felix S. Klock II

commit sha b4e77d21bcf8b15ef7d873005382ba8ca309faf5

rewrite old test so that its attributes are consistent with what we want in the language. (Note that the fact this test existed is a slight sign that we may need a crater run on this bugfix...)

view details

Tamir Duberstein

commit sha 9601724b11bbd9081b1bee6f7e478a5d2b9ace41

Avoid unchecked casts in net parser

view details

Tamir Duberstein

commit sha f78a7ade61c1c218eead76854abb7d83bb6c6f75

Inline "eof" methods

view details

push time in 12 days

push eventspastorino/rust

push time in 12 days

pull request commentrust-lang/rustc-dev-guide

Recommend setting up `check_line_lengths` as a pre-commit script

Just in case, I was referring to // ignore-tidy-linelength which we use mainly in tests like in https://github.com/rust-lang/rust/blob/master/src/test/ui/stability-attribute/generics-default-stability.rs#L1. I was guessing (didn't read the code) that this pre-commit hook would check that the to be committed files do not have more than 100 length lines but for this to be correct we would need to ignore the ones that use that directive.

jyn514

comment created time in 12 days

push eventspastorino/rust-forge

Santiago Pastorino

commit sha e6e035ed8a5d91e899b86eebe1170401c8e5c6e5

Do not mention working groups twice

view details

push time in 12 days

PR opened rust-lang/rust-forge

Remove wg checkins text from notify team section

r? @XAMPPRocky

+0 -1

0 comment

1 changed file

pr created time in 12 days

create barnchspastorino/rust-forge

branch : remove-wg-check-ins

created branch time in 12 days

issue commentrust-lang/rust

[ICE] Encountered errors resolving bounds after type-checking

@rustbot ping cleanup

Would be nice to find the regression and an MCVE.

lzutao

comment created time in 12 days

issue commentrust-lang/rust

ICE: Projection bound ... was applicable to ... but now is not

@Julian-Wollersberger you need to run it with --regress=ice

tavianator

comment created time in 12 days

PR opened rust-lang/team

Add Joshua Nelson as a Rustc Dev Guide WG lead

cc @jyn514 @mark-i-m

+1 -1

0 comment

1 changed file

pr created time in 12 days

create barnchspastorino/team

branch : add-jyn514-as-guide-lead

created branch time in 12 days

pull request commentrust-lang/rustc-dev-guide

Recommend setting up `check_line_lengths` as a pre-commit script

@jyn514 :+1:, does the script check files when the ignore directive is used?.

jyn514

comment created time in 12 days

issue commentrust-lang/rust

Optimisation-caused UB during cross-crate compilation

@Aaron1011 do you know in which LLVM version is this going to be included?

inikulin

comment created time in 12 days

push eventspastorino/rust

Santiago Pastorino

commit sha 1594e4b9c6e40154f07fa5f7cd8d16a012153940

Add inline const tests

view details

Santiago Pastorino

commit sha 871d98f091a73f8fdf59c7eecfd3987520f83e95

Handle ExprKind::ConstBlock on clippy

view details

Santiago Pastorino

commit sha ef2ee38619d13e81eb0348f2fee07db4c06990bf

Fix lints

view details

push time in 13 days

Pull request review commentrust-lang/rust

Implement const expressions and patterns (RFC 2920)

 impl<'a> Parser<'a> {             let pat = self.parse_pat_with_range_pat(false, None)?;             self.sess.gated_spans.gate(sym::box_patterns, lo.to(self.prev_token.span));             PatKind::Box(pat)+        } else if self.eat_keyword(kw::Const) {

Ohh right, I forgot about changing this. Will do.

spastorino

comment created time in 13 days

PullRequestReviewEvent

push eventspastorino/rust

Santiago Pastorino

commit sha c62d0fa50263f1bd88e73afe0df3dadaf1a1f2b3

Add inline_const feature flag

view details

Santiago Pastorino

commit sha f39ca6054b70ed14c6fa0aeaccbfec65b88faf85

Parse inline const expressions

view details

Santiago Pastorino

commit sha e7d91a7362efb31bc3be7b369fde650c1b2e87d9

Parse inline const patterns

view details

Santiago Pastorino

commit sha bf3942217cea40946b588fdccc6026fb51948474

Lower inline const's AST to HIR

view details

Santiago Pastorino

commit sha cc41c31ac582f9729f0682e2cfc6eba421a775df

Lower inline const down to MIR

view details

Santiago Pastorino

commit sha b1b9c6088a89eb7667406ff280e57bb683ff1934

Typeck inline consts

view details

Santiago Pastorino

commit sha 0c8a25b24a8d7c68639be425c854221ce47b2e2f

Add inline const tests

view details

Santiago Pastorino

commit sha 25d0f9080235b71c5bbfa146b8affe7c22a7ec33

Handle ExprKind::ConstBlock on clippy

view details

Santiago Pastorino

commit sha 6a4f656e7ec37dde2a00fb26c3c57b0e51a74f7f

Fix lints

view details

push time in 13 days

push eventspastorino/rust

Santiago Pastorino

commit sha e9b816ab47e7d35c75e61ef4294f3d7746448002

Handle ExprKind::ConstBlock on clippy

view details

Santiago Pastorino

commit sha 9af38b093cd4c973155072a02c7cfe61e6ddf4aa

Fix lints

view details

push time in 13 days

push eventspastorino/rust

Santiago Pastorino

commit sha b00499bc1f06432ba399ce371de66451a43f4d9a

Lower inline const's AST to HIR

view details

Santiago Pastorino

commit sha 5715969ca7448d0ddc374f3c4ec0c1f0bbf33a4d

Lower inline const down to MIR

view details

Santiago Pastorino

commit sha b1f30914ab7612b1f664434ebc3dcce080bcc66f

Typeck inline consts

view details

Santiago Pastorino

commit sha 426834c891f978ecf6f672276262b11a21d23a87

Add inline const tests

view details

Santiago Pastorino

commit sha 39e8252d3f00a92c0ae81d8772cb737a0743abdc

Fix lints

view details

push time in 13 days

Pull request review commentrust-lang/rust

Implement const expressions and patterns (RFC 2920)

 use rustc_ast::ptr::P; use rustc_ast::token::{self, DelimToken, Token, TokenKind}; use rustc_ast::tokenstream::{self, DelimSpan, TokenStream, TokenTree, TreeAndJoint}; use rustc_ast::DUMMY_NODE_ID;-use rustc_ast::{self as ast, AttrStyle, AttrVec, Const, CrateSugar, Extern, Unsafe};-use rustc_ast::{Async, MacArgs, MacDelimiter, Mutability, StrLit, Visibility, VisibilityKind};+use rustc_ast::{self as ast, AnonConst, AttrStyle, AttrVec, Const, CrateSugar, Extern, Unsafe};+use rustc_ast::{+    Async, ExprKind, MacArgs, MacDelimiter, Mutability, StrLit, Visibility, VisibilityKind,+};

Just in case, what do you exactly mean here?. I don't like in the way things were before modifying the code but I've tried lo leave things as close as similar as they were. I'm happy to fix all this as a drive by but I'm not sure if you want me to join those two last imports into one use, or if you want to avoid { } or even merge all the five previous use there. I think I'd merge the last three lines that are use statements in the root path and do not bother with rustc_ast::tokenstream and the rest.

spastorino

comment created time in 13 days

PullRequestReviewEvent

push eventspastorino/rust

Santiago Pastorino

commit sha aa61e2696481ee1b15f282be33f29368d7e8ca4d

Lower inline const down to MIR

view details

Santiago Pastorino

commit sha f18daa028b67597d3d770ba0492b08c56bf122c6

Fix lints

view details

push time in 14 days

push eventspastorino/rust

Santiago Pastorino

commit sha dae1721a5731b5e02774ddaffdf81d4b036a6257

WIP

view details

Santiago Pastorino

commit sha 86c9bdc57085e57c6c5bcd3151e6172100fbdd7b

Fix lints

view details

push time in 14 days

push eventspastorino/rust

Santiago Pastorino

commit sha 9b391569f1165a2dd1a7d5c7537c9f6d9e6a5a52

Parse inline const expressions

view details

Santiago Pastorino

commit sha 195b8cde3bd693cf8231b2ab9272784953678751

Parse inline const patterns

view details

Santiago Pastorino

commit sha a4a9bb03bc3e1ea226d0249e10bc7ab55c79df56

Refactor: extract parse_anon_const fn

view details

Santiago Pastorino

commit sha 22132fd8448ce4365d3858fd1d40bbda0b0be68d

WIP

view details

Santiago Pastorino

commit sha a4ef1ae31e64991175ba452d12016a0adf14381b

WIP 2

view details

Santiago Pastorino

commit sha e9c5b5c4d9802747ca6541d10353212cf98e8c61

Fix lints

view details

push time in 14 days

push eventspastorino/rust

Nazım Can Altınova

commit sha a313abe3ba989ba4b6c041627c903488886f8559

Manually implement Debug for BTreeMap::{IntoKeys,IntoValues} structs

view details

Nazım Can Altınova

commit sha 456738e3d1ad7dadffaed287d3055ca38b5fa375

Only print values in the Debug of HashMap::ValuesMut struct

view details

Nazım Can Altınova

commit sha c346e89db8a57e15111daa35685a2542d3be7c77

Manually implement Debug for BTreeMap::ValuesMut struct Deriving debug prints all the values including keys. But ValuesMut struct should only print the values.

view details

Nazım Can Altınova

commit sha 8faf550e5f7211188bc9560ae459c155fb1aafdf

Remove the unused bounds from Debug impl of HashMap::{IntoKeys,IntoValues}

view details

kadmin

commit sha 8894b366fdb976a703fe76010f6e56c591cada1f

Remove error message in specific case In the case that a trait is not implemented for an ADT with type errors, cancel the error.

view details

CAD97

commit sha 728938346b02a9688c44253c19b15baa7551fd80

Adjust rc::Weak::from_raw to support unsized T

view details

CAD97

commit sha 0c61ce2cf0560577923abafab2e5bfce14516525

?Sized bounds for rc::Weak::as_ptr and friends

view details

CAD97

commit sha 5e7406c9569dce75a042ce079918cf03cfca842a

Adjust sync::Weak::from_raw to support unsized T

view details

CAD97

commit sha 9d9903c5a50bb1f5b5fc3045b86172279eff7d30

Allow Weak::as_ptr and friends for unsized T

view details

CAD97

commit sha 3d07108d3600dff50e564f57dd390337dbe14d55

Add tests for weak into/from raw

view details

Jubilee Young

commit sha 247b73939a619ea4dcb2affbe1c285d20d93a0b8

Move Wrapping<T> ui tests into library

view details

Jubilee Young

commit sha 797cb9526a627c37b9bb9f6be6d3b54789b67c26

Fix to libstd test

view details

Jubilee Young

commit sha ac96f5b39ca7d9fad8571595c476c2db0bce8438

Test and reject out-of-bounds shuffle vectors

view details

Mara Bos

commit sha 84ef603c8400db203fefd714de963c88e5523424

Fix 'FIXME' about using NonZeroU32 instead of u32. It was blocked by #58732 (const fn NonZeroU32::new), which is fixed now.

view details

Pietro Albini

commit sha 0917b2123fff6cf5357b5edd5db6d675313ab8bd

build-manifest: move PkgType into the versions module

view details

Pietro Albini

commit sha 3bddfea7e23341f788526f8b303b9a27038511e3

build-manifest: stop receiving release numbers from bootstrap

view details

Without Boats

commit sha 82f5928ca68acceb1d1bd9e2b09554744e4a1dfe

Make RawFd implement the RawFd traits

view details

Without Boats

commit sha acc136ce0a665a32ddf1a16544b6f6d7a7153c30

fix typos

view details

Without Boats

commit sha 3fe279fc658450a3e3140f014554139493674217

spend another CI build to delete a double newline

view details

Without Boats

commit sha 35b30e29bffe8c4aa896ce53ded67c54401f7643

try again to appease tidy

view details

push time in 14 days

push eventspastorino/rust

Santiago Pastorino

commit sha e7e03ecfdb40edc6a37dfd8fc192c676cd5b0496

WIP 2

view details

Santiago Pastorino

commit sha dc7637c9ae36622f272ecd83864aceb2964279c1

Fix lints

view details

Santiago Pastorino

commit sha 5b5089828539128577bfbc40b672f2f942629c12

Add parse_constness comment

view details

push time in 14 days

Pull request review commentrust-lang/rust

Implement const expressions and patterns (RFC 2920)

 impl<'a> Parser<'a> {             let pat = self.parse_pat_with_range_pat(false, None)?;             self.sess.gated_spans.gate(sym::box_patterns, lo.to(self.prev_token.span));             PatKind::Box(pat)+        } else if self.eat_keyword(kw::Const) {+            // Parse `const pat`+            PatKind::ConstBlock(self.parse_anon_const(lo.to(self.token.span))?)

Yeah, I've changed this a while ago but haven't pushed yet.

spastorino

comment created time in 14 days

PullRequestReviewEvent

Pull request review commentrust-lang/rust

Implement const expressions and patterns (RFC 2920)

 // This file was auto-generated using 'src/etc/generate-keyword-tests.py const' -fn main() {-    let const = "foo"; //~ error: expected identifier, found keyword `const`
error: expected `{`, found `=`
 --> src/test/ui/parser/keyword-const-as-identifier.rs:4:15
  |
4 |     let const = "foo"; //~ error: expected identifier, found keyword `const`
  |               ^ expected `{`

spastorino

comment created time in 14 days

PullRequestReviewEvent

issue closedrust-lang/rust

regression: get_unchecked resolves to unstable feature use

  • https://crater-reports.s3.amazonaws.com/beta-1.47-1/beta-2020-08-29/reg/algebraics-0.2.0/log.txt

Unclear if this is a genuine regression or something else is going on, but seems like at least plausibly some change to resolution is involved.

closed time in 18 days

Mark-Simulacrum
more