profile
viewpoint
Maciej Szulik soltysh Red Hat, Inc Poland Kubernout/OpenShifter by day, Pythonista by night, open source enthusiast and amateur photographer.

ericsnowcurrently/multi-core-python 177

Enabling CPython multi-core parallelism via subinterpreters.

python/core-workflow 55

Issue tracker for CPython's workflow

openshift/cluster-kube-descheduler-operator 12

An operator to run descheduler on OpenShift.

python/bpo-builder 4

bugs.python.org builder image & other deployment artifacts

mfojtik/bugzilla-operator 1

DevOperator that automate Bugzilla workflow for OpenShift engineering team

ncdc/origin 1

OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes

clamoriniere1A/kubernetes 0

Production-Grade Container Scheduling and Management

soltysh/api 0

Canonical location of the OpenShift API definition.

pull request commentopenshift/api

Remove description line about namespaced ClusterRoleBinding

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

yuvalk

comment created time in 10 hours

issue commentopenshift/client-go

Create Security Context using the openshift golang Client

@openshift-bot: Closing this issue.

<details>

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. </details>

prateek1192

comment created time in 10 hours

issue closedopenshift/client-go

Create Security Context using the openshift golang Client

I am trying to create SCC using OC client in golang. I see that the documentation is very sparse for it. I am trying to consume "github.com/openshift/client go/security/clientset/versioned/typed/security/v1" amd creating a scc using this like scclient.SecurityContextConstraints().Create(). Is there a way I can pass yaml to it ?

Can we have some examples regarding this in the docs ?

closed time in 10 hours

prateek1192

issue commentopenshift/client-go

Create Security Context using the openshift golang Client

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

prateek1192

comment created time in 10 hours

issue commentopenshift/cluster-kube-apiserver-operator

add TCP connection status label

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

sanchezl

comment created time in 16 hours

issue commentopenshift/cluster-kube-apiserver-operator

outage calculation in upgrade looks incorrect. See

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

sanchezl

comment created time in 16 hours

push eventopenshift/api

Predrag Knezevic

commit sha c1778345bb43efec360c6f30ca7e8abd2a61c321

Add `disabled` field to `HelmChartRepository` The default Red Hat repo is delivered as a part of console operator payload: https://github.com/openshift/console-operator/blob/master/manifests/01-helm.yaml and since these resource are monitored by CVO, it is not possible to remove the default configuration, and many customers are asking for exactly that. In order to solve the customer request, `disabled` field is added to `HelmChartRepository`. If set to true, that repo will be ignored/skipped in all relevant Helm operations. At the same time, other cluster components (e.g. console UI) might use the new flag to enable/disable some parts of UI.

view details

OpenShift Merge Robot

commit sha be133974637435eb4c1de5d9ab2e404a360b602e

Merge pull request #795 from pedjak/helm-disabled-field Add `disabled` field to `HelmChartRepository`

view details

push time in 17 hours

push eventopenshift/api

Predrag Knezevic

commit sha c1778345bb43efec360c6f30ca7e8abd2a61c321

Add `disabled` field to `HelmChartRepository` The default Red Hat repo is delivered as a part of console operator payload: https://github.com/openshift/console-operator/blob/master/manifests/01-helm.yaml and since these resource are monitored by CVO, it is not possible to remove the default configuration, and many customers are asking for exactly that. In order to solve the customer request, `disabled` field is added to `HelmChartRepository`. If set to true, that repo will be ignored/skipped in all relevant Helm operations. At the same time, other cluster components (e.g. console UI) might use the new flag to enable/disable some parts of UI.

view details

OpenShift Merge Robot

commit sha be133974637435eb4c1de5d9ab2e404a360b602e

Merge pull request #795 from pedjak/helm-disabled-field Add `disabled` field to `HelmChartRepository`

view details

push time in 17 hours

push eventopenshift/api

Predrag Knezevic

commit sha c1778345bb43efec360c6f30ca7e8abd2a61c321

Add `disabled` field to `HelmChartRepository` The default Red Hat repo is delivered as a part of console operator payload: https://github.com/openshift/console-operator/blob/master/manifests/01-helm.yaml and since these resource are monitored by CVO, it is not possible to remove the default configuration, and many customers are asking for exactly that. In order to solve the customer request, `disabled` field is added to `HelmChartRepository`. If set to true, that repo will be ignored/skipped in all relevant Helm operations. At the same time, other cluster components (e.g. console UI) might use the new flag to enable/disable some parts of UI.

view details

OpenShift Merge Robot

commit sha be133974637435eb4c1de5d9ab2e404a360b602e

Merge pull request #795 from pedjak/helm-disabled-field Add `disabled` field to `HelmChartRepository`

view details

push time in 18 hours

PR merged openshift/api

Reviewers
Add `disabled` field to `HelmChartRepository` approved lgtm

The default Red Hat repo is delivered as a part of console operator payload:

https://github.com/openshift/console-operator/blob/master/manifests/01-helm.yaml

and since these resource are monitored by CVO, it is not possible to remove the default configuration, and many customers are asking for exactly that.

In order to solve the customer request, disabled field is added to HelmChartRepository. If set to true, that repo will be ignored/skipped in all relevant Helm operations. At the same time, other cluster components (e.g. console UI) might use the new flag to enable/disable some parts of UI.

+7 -0

3 comments

2 changed files

pedjak

pr closed time in 18 hours

pull request commentopenshift/api

Add `disabled` field to `HelmChartRepository`

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: <a href="https://github.com/openshift/api/pull/795#pullrequestreview-539970107" title="LGTM">jhadvig</a>, <a href="https://github.com/openshift/api/pull/795#" title="Author self-approved">pedjak</a>, <a href="https://github.com/openshift/api/pull/795#issuecomment-734830474" title="Approved">sttts</a>

The full list of commands accepted by this bot can be found here.

The pull request process is described here

<details > Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":[]} -->

pedjak

comment created time in 18 hours

pull request commentopenshift/api

Add `disabled` field to `HelmChartRepository`

/approve

pedjak

comment created time in 18 hours

Pull request review commentopenshift/api

Add `disabled` field to `HelmChartRepository`

 type HelmChartRepositoryList struct { // Helm chart repository exposed within the cluster type HelmChartRepositorySpec struct { +	// If set to true, disable the repo usage in the cluster

that's the default already https://github.com/openshift/api/blob/master/helm/v1beta1/doc.go#L5

pedjak

comment created time in 18 hours

pull request commentopenshift/api

Add `disabled` field to `HelmChartRepository`

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: <a href="https://github.com/openshift/api/pull/795#pullrequestreview-539970107" title="LGTM">jhadvig</a>, <a href="https://github.com/openshift/api/pull/795#" title="Author self-approved">pedjak</a> To complete the pull request process, please assign knobunc after the PR has been reviewed. You can assign the PR to them by writing /assign @knobunc in a comment when ready.

The full list of commands accepted by this bot can be found here.

<details open> Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":["knobunc"]} -->

pedjak

comment created time in 18 hours

Pull request review commentopenshift/api

Add `disabled` field to `HelmChartRepository`

 type HelmChartRepositoryList struct { // Helm chart repository exposed within the cluster type HelmChartRepositorySpec struct { +	// If set to true, disable the repo usage in the cluster

kubebuilder:validation:Optional can be specified only on package: https://book.kubebuilder.io/reference/markers/crd-validation.html

pedjak

comment created time in 19 hours

Pull request review commentopenshift/api

Add `disabled` field to `HelmChartRepository`

 type HelmChartRepositoryList struct { // Helm chart repository exposed within the cluster type HelmChartRepositorySpec struct { +	// If set to true, disable the repo usage in the cluster
	// If set to true, disable the repo usage in the cluster
	// +kubebuilder:validation:Optional
	// +optional
pedjak

comment created time in 20 hours

pull request commentopenshift/api

Add `disabled` field to `HelmChartRepository`

Looks formally fine. Needs somebody from console or helm team to lgtm. @jhadvig ?

pedjak

comment created time in 20 hours

pull request commentopenshift/api

Add `disabled` field to `HelmChartRepository`

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: <a href="https://github.com/openshift/api/pull/795#" title="Author self-approved">pedjak</a> To complete the pull request process, please assign knobunc after the PR has been reviewed. You can assign the PR to them by writing /assign @knobunc in a comment when ready.

The full list of commands accepted by this bot can be found here.

<details open> Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":["knobunc"]} -->

pedjak

comment created time in 20 hours

PR opened openshift/api

Add `disabled` field to `HelmChartRepository`

The default Red Hat repo is delivered as a part of console operator payload:

https://github.com/openshift/console-operator/blob/master/manifests/01-helm.yaml

and since these resource are monitored by CVO, it is not possible to remove the default configuration, and many customers are asking for exactly that.

In order to solve the customer request, disabled field is added to HelmChartRepository. If set to true, that repo will be ignored/skipped in all relevant Helm operations. At the same time, other cluster components (e.g. console UI) might use the new flag to enable/disable some parts of UI.

+6 -0

0 comment

2 changed files

pr created time in 20 hours

pull request commentopenshift/api

[release-4.3] Bug 1816486: fix(codegen): add missing client tag to operatorhub config type

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-cherrypick-robot

comment created time in a day

Pull request review commentopenshift/api

CONSOLE-2376: Dynamic plugins for Console

+package v1++import metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"++// +genclient+// +genclient:nonNamespaced+// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object++// ConsolePlugin is an extension for customizing OpenShift web console by+// dynamically loading code from another service running on the cluster.+type ConsolePlugin struct {+	metav1.TypeMeta   `json:",inline"`+	metav1.ObjectMeta `json:"metadata"`++	Spec ConsolePluginSpec `json:"spec"`+}++// ConsolePluginSpec is the desired plugin configuration.+type ConsolePluginSpec struct {+	// displayName is the display name of the plugin.+	DisplayName string `json:"displayName"`+	// service is a Kubernetes Service that exposes the plugin using a+	// deployment with an HTTP server. The Service must use HTTPS and+	// service serving certificate. The console backend will proxy the+	// plugins assets from the Service using the service CA bundle.+	Service ConsolePluginService `json:"service"`+}++// ConsolePluginService holds informations on service that is serving+// dynamic plugin for the console.+type ConsolePluginService struct {+	// name of Service that is serving the plugin.+	Name string `json:"name"`+	// namespace of Service that is serving the plugin.+	Namespace string `json:"namespace"`+	// port on which the Service that is serving the plugin is listening to.+	Port int32 `json:"port"`+	// manifest is the path to the plugin manifest. The manifest is a JSON+	// document that contains metadata about the plugin and the extensions.+	Manifest string `json:"manifest"`

The name of Console dynamic plugin manifest file (plugin-manifest.json) is fixed.

In the above data structure, name + namespace + port are used to resolve the plugin service URL address. Console web application refers to this address as "plugin base URL".

Given the above, I think that the manifest field is redundant.

jhadvig

comment created time in a day

Pull request review commentopenshift/api

CONSOLE-2376: Dynamic plugins for Console

 type ConsoleSpec struct { 	// If not specified, default route will be used. 	// +optional 	Route ConsoleConfigRoute `json:"route"`+	// plugins defines a list of enabled console plugins.+	// +optional+	Plugins []string `json:"plugins,omitempty"`

Console web application deals with two dynamic plugin lists:

  1. all plugins detected on the cluster, detection based on ConsolePlugin resources which are contributed by operators
  2. plugins currently enabled for the cluster, detection based on Console resource representing the Console operator config

Console operator should ensure that currently enabled plugins list is a subset of all plugins, e.g. when the list of installed operators changes, remove enabled plugin entries for which a plugin is currently not available.

The list of currently enabled plugins will be injected into Console HTML page via SERVER_FLAGS global JS object.

pluginBaseURLs: string[];

Upon its startup, Console web application will read this list and start loading the given dynamic plugins.

jhadvig

comment created time in 2 days

Pull request review commentopenshift/api

CONSOLE-2376: Dynamic plugins for Console

+package v1++import metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"++// +genclient+// +genclient:nonNamespaced+// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object++// ConsolePlugin is an extension for customizing OpenShift web console by+// dynamically loading code from another service running on the cluster.+type ConsolePlugin struct {+	metav1.TypeMeta   `json:",inline"`+	metav1.ObjectMeta `json:"metadata"`++	Spec ConsolePluginSpec `json:"spec"`+}++// ConsolePluginSpec is the desired plugin configuration.+type ConsolePluginSpec struct {+	// displayName is the display name of the plugin.+	DisplayName string `json:"displayName"`+	// service is a Kubernetes Service that exposes the plugin using a+	// deployment with an HTTP server. The Service must use HTTPS and+	// service serving certificate. The console backend will proxy the+	// plugins assets from the Service using the service CA bundle.+	Service ConsolePluginService `json:"service"`+}++// ConsolePluginService holds informations on service that is serving+// dynamic plugin for the console.
// console dynamic plugin assets.
jhadvig

comment created time in 2 days

Pull request review commentopenshift/api

CONSOLE-2376: Dynamic plugins for Console

 type ConsoleSpec struct { 	// If not specified, default route will be used. 	// +optional 	Route ConsoleConfigRoute `json:"route"`+	// plugins defines a list of enabled console plugins.

We have a constraint where Console web application disallows loading multiple dynamic plugins with the same name.

I think we should implement an equivalent constraint when installing an operator, so that we don't end up with duplicates in the "enabled plugins" list.

jhadvig

comment created time in 2 days

Pull request review commentopenshift/api

CONSOLE-2376: Dynamic plugins for Console

+package v1++import metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"++// +genclient+// +genclient:nonNamespaced+// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object++// ConsolePlugin is an extension for customizing OpenShift web console by+// dynamically loading code from another service running on the cluster.+type ConsolePlugin struct {+	metav1.TypeMeta   `json:",inline"`+	metav1.ObjectMeta `json:"metadata"`++	Spec ConsolePluginSpec `json:"spec"`+}++// ConsolePluginSpec is the desired plugin configuration.+type ConsolePluginSpec struct {+	// displayName is the display name of the plugin.+	DisplayName string `json:"displayName"`+	// service is a Kubernetes Service that exposes the plugin using a+	// deployment with an HTTP server. The Service must use HTTPS and+	// service serving certificate. The console backend will proxy the+	// plugins assets from the Service using the service CA bundle.+	Service ConsolePluginService `json:"service"`+}++// ConsolePluginService holds informations on service that is serving
// ConsolePluginService holds information on service that is serving
jhadvig

comment created time in 2 days

Pull request review commentopenshift/api

CONSOLE-2376: Dynamic plugins for Console

 type ConsoleSpec struct { 	// If not specified, default route will be used. 	// +optional 	Route ConsoleConfigRoute `json:"route"`+	// plugins defines a list of enabled console plugins.
	// plugins defines a list of enabled console plugin names.
jhadvig

comment created time in 2 days

Pull request review commentopenshift/api

CONSOLE-2376: Dynamic plugins for Console

 type ConsoleSpec struct { 	// If not specified, default route will be used. 	// +optional 	Route ConsoleConfigRoute `json:"route"`+	// plugins defines a list of enabled console plugins.+	// +optional+	Plugins []string `json:"plugins,omitempty"`

I'd suggest naming this field enabledPlugins to better reflect its purpose.

	Plugins []string `json:"enabledPlugins,omitempty"`
jhadvig

comment created time in 2 days

issue commentopenshift/client-go

Creating a clientset for (egress)network policy throw error

@openshift-bot: Closing this issue.

<details>

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. </details>

lupindeterd

comment created time in a day

issue closedopenshift/client-go

Creating a clientset for (egress)network policy throw error

What do I need to create a client for OpenShift added resource(s)? I encounter a problem when import the openshift/client-go/network package and create a clientset from it. The client-go/kubernetes resource(networkpolicy) works fine.

`package main

import ( "k8s.io/client-go/informers" "k8s.io/client-go/kubernetes" "k8s.io/client-go/tools/cache" "k8s.io/client-go/tools/clientcmd" egressnetv1 "github.com/openshift/client-go/network/informers/externalversions/network/v1" egressnetclient "github.com/openshift/client-go/network/clientset/versioned/typed/network/v1" ) var logger *zap.Logger

func main() { logger, _ = zap.NewProduction() defer logger.Sync() logger.Info("The pod watcher/logger started") kubeconfig := os.Getenv("KUBECONFIG") config, err := clientcmd.BuildConfigFromFlags("", kubeconfig) if err != nil { logger.Panic(err.Error()) os.Exit(1) } // clientset for NetworkPolicy clientset, err := kubernetes.NewForConfig(config) // clientset for EgressNetworkPolicy egressclientset, err := egressnetclient.NewForConfig(config) if err != nil { panic(err) }

`

I get the following error:

github.com/user/podwatcher/vendor/github.com/openshift/client-go/network/clientset/versioned/typed/network/v1 vendor/github.com/openshift/client-go/network/clientset/versioned/typed/network/v1/clusternetwork.go:54:5: not enough arguments in call to c.client.Get().Resource("clusternetworks").Name(name).VersionedParams(&options, scheme.ParameterCodec).Do have () want (context.Context)

closed time in a day

lupindeterd

issue commentopenshift/client-go

Creating a clientset for (egress)network policy throw error

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

lupindeterd

comment created time in a day

more