profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/smowafy/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Sherif Mowafy smowafy Hive Logistics Berlin, Germany

maged918/tagaware-rec-sys 3

Repo containging all supporting codes for the tag-aware recommendation system for the GUC research group

smowafy/rlwe-kex-go 1

An implementation of an unauthenticated key exchange algorithm based on the ring-learning-with-errors problem.

hosamhany/PokemonGo-Agent 0

Implementing an artificially intelligent agent to play a game with the same concept of PokemonGo.

hosamhany/PokemonGo-Logic 0

The same approach of the pokemon go agent but using first order logic.

mohamed-essam/murder-of-crows 0

Miniature extendable queue orchestration system

push eventsmowafy/nerdctl

Sherif

commit sha aaf6ac4610fbc98da868b1e0a5cf84fc5ea7e462

add `nerdctl run --cidfile <FILE>` Signed-off-by: Sherif <sherif.mowafy@gmail.com>

view details

push time in 2 months

Pull request review commentcontainerd/nerdctl

add `nerdctl run --cidfile <FILE>`

 var runCommand = &cli.Command{ 			Name:  "label-file", 			Usage: "Read in a line delimited file of labels", 		},+		&cli.StringFlag{+			Name:  "cidfile",+			Usage: "Write the container ID to the file",+		},

Added

smowafy

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentcontainerd/nerdctl

add `nerdctl run --cidfile <FILE>`

 func TestRunExitCode(t *testing.T) { 	assert.Equal(base.T, "exited", inspect123.State.Status) 	assert.Equal(base.T, 123, inspect123.State.ExitCode) }++func TestRunCIDFile(t *testing.T) {

Replaced by just asserting failure if the file exists. Is that enough or should it be more specific?

smowafy

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentcontainerd/nerdctl

add `nerdctl run --cidfile <FILE>`

 func propagateContainerdLabelsToOCIAnnotations() oci.SpecOpts { 		return oci.WithAnnotations(c.Labels)(ctx, oc, c, s) 	} }++func writeCIDFile(path, id string) error {+	if _, err := os.Stat(path); err == nil {+		return errors.Errorf("container ID file found, make sure the other container isn't running or delete %s", path)+	}+	f, err := os.Create(path)

I added returning other errors, please check if this way makes sense. Also I used errors.Is according to https://golang.org/pkg/os/#IsExist

smowafy

comment created time in 2 months

PullRequestReviewEvent

push eventsmowafy/nerdctl

Sherif

commit sha ee61d1fc63d72bdadbc63b834bca7b726616560b

add `nerdctl run --cidfile <FILE>` Signed-off-by: Sherif <sherif.mowafy@gmail.com>

view details

push time in 2 months

Pull request review commentcontainerd/nerdctl

add `nerdctl run --cidfile <FILE>`

 var runCommand = &cli.Command{ 			Name:  "label-file", 			Usage: "Read in a line delimited file of labels", 		},+		&cli.StringFlag{+			Name:  "cidfile",+			Usage: "Write the container ID to the file",+		},

To which category though?

smowafy

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentcontainerd/nerdctl

add `nerdctl run --cidfile <FILE>`

 func propagateContainerdLabelsToOCIAnnotations() oci.SpecOpts { 		return oci.WithAnnotations(c.Labels)(ctx, oc, c, s) 	} }++func writeCIDFile(path, id string) error {+	if _, err := os.Stat(path); err == nil {+		return errors.Errorf("Container ID file found, make sure the other container isn't running or delete %s", path)+	}+	f, err := os.Create(path)+	defer f.Close()+	if err != nil {+		return errors.Errorf("Failed to create the container ID file: %s", err)

The error message was inspired from https://github.com/docker/cli/blob/master/cli/command/container/create.go#L180, changed it to lowercase though

smowafy

comment created time in 2 months

PullRequestReviewEvent

push eventsmowafy/nerdctl

Sherif

commit sha 48d5d0679eab42aa0e7d7b7fa16ca05cd3ce2c20

add `nerdctl run --cidfile <FILE>` Signed-off-by: Sherif <sherif.mowafy@gmail.com>

view details

push time in 2 months

PR opened containerd/nerdctl

add `nerdctl run --cidfile <FILE>`

First flag in the list in https://github.com/containerd/nerdctl/issues/215

One thing I'm not sure about is the category of this flag

+42 -0

0 comment

2 changed files

pr created time in 2 months

push eventsmowafy/nerdctl

Sherif

commit sha 28bef4c4043839a1e774a7309d3ad180da39809b

add `nerdctl run --cidfile <FILE>` Signed-off-by: Sherif <sherif.mowafy@gmail.com>

view details

push time in 2 months

push eventsmowafy/nerdctl

Sherif

commit sha 79cd0ca833d260ed259a1a4613698e65b89c7614

add `nerdctl run --cidfile <FILE>` Signed-off-by: Sherif <sherif.mowafy@gmail.com>

view details

push time in 2 months

fork smowafy/nerdctl

Docker-compatible CLI for containerd, with support for Compose

fork in 2 months

startedcontainerd/nerdctl

started time in 2 months

startedldsec/lattigo

started time in 3 months