profile
viewpoint
Stuart Lang slang25 Somerset, United Kingdom https://stu.dev

shouldly/shouldly 1627

Should testing for .NET - the way Asserting *Should* be!

shaynevanasperen/Magneto 27

A library for implementing the Command Pattern, providing of a set of base classes and an invoker class. Useful for abstracting data access and API calls as either queries (for read operations) or commands (for write operations).

justeat/JustSaying 12

A light-weight message bus on top of AWS services (SNS and SQS).

FSharpBristol/FSharpTurtleTutorial 9

101 Workshop for F#, building a Logo Turtle

shaynevanasperen/Code 7

A collection of source-only NuGet packages containing tiny bits of utility code that don't belong together in a monolithic library.

payman81/custom-activity-deskapi-node 0

Journey Builder custom activity creates a new desk.com case.

slang25/acubot 0

Mini Suave Workshop Runner

pull request commentdaveaglick/Buildalyzer

Handle self-contained apps

@daveaglick It might be worth comparing notes with the OmniSharp folk, they are solving roughly the same problem. I'm betting there will be a lot of cross-over in terms of issues reporting in both repos.

https://github.com/OmniSharp/omnisharp-roslyn/blob/b4042a7389a5492ce5a892576a8df91d31488367/src/OmniSharp.MSBuild/ProjectLoader.cs#L29-L71

psfinaki

comment created time in 3 days

push eventslang25/dotnet-playwright-tests

Martin Costello

commit sha 5ebdeda92a9513f3322b5b212942dd2eae1b7cb6

Support BrowserStack Automate (#34) * Support BrowserStack Automate Add support for BrowserStack Automate. * Add concurrency to CI build Add concurrency to try and prevent multiple CI jobs from tripping over the BrowserStack Automate API parallelism limits. * Remove concurrency Remove the concurrency as it hasn't fixed anything. * Only test Chrome Temporarily only test Chrome to see if the build passes. * Revert browser changes Revert 0be180c3610a590891173ecd01f4cf470b6c0fbc. * Add project name Also pass a project name through to BrowserStack. * Add default project and build in CI Use GitHub Actions environment variables to automatically set the build number and project in CI. * Run all browsers with BrowserStack If BrowserStack is being used, use all of the browser combinations. * Turn up dotnet test logging Turn up the logging level for dotnet test to try and find the hanging test(s). * Add test timeout Add a timeout to the tests to try and help diagnose the Linux and macOS issue. * Only use BrowserStack in Windows CI All the BrowserStack tests seem to hang when running in GitHub Actions, except for Windows. * Increase test timeout Increase the test timeout to 45 seconds. * Fix BrowserStack skipping Fix BrowserStack not being skipped correctly in CI. * Turn down logging level Turn down the logging level now it's known it's just completely broken on macOS and Linux. * Fix UseBrowserStack Fix the UseBrowserStack not returning the correct value. * Try another fix for UseBrowserStack Try another fix by computing it every time, rather than once. * Rename variables Drop the prefix. * Comment-out workaround Comment-out the workaround to see if BrowserStack is used again. * Change the condition Change the condition to see if that fixes it so Windows uses BrowserStack and Linux and macOS don't. * Update pwsh shebang * Test debugging Add some output logs to try and work out why BrowserStack isn't being used. * Log some more things Log a few more things to verify a hunch. * Explicitly set environment variables Explicitly set environment variables when build.ps1 is invoked. * Fix syntax Dollars in the wrong place... * Use pwsh to set environment variable Set the environment variables through pwsh rather than bash. * Remove debug logging Credentials are fixed, so now just the hang to solve. * Do not capture videos with BrowserStack If using BrowserStack, do not capture video. This is just to see if that's what's causing the timeouts. * Allow BrowserStack on all CI operating systems Allow BrowserStack to be used on all operating systems in CI. Then hang appears to be related to capturing video which is skipped since 7351311bfd29c7941aa7f128ca746864f0850af4. * Add comment about video hang Add a comment about why videos are disabled with BrowserStack. * Only configure secrets for me Only configure secrets in my own PRs. * Make parameter required Make the testName parameter required so it's always set as the test, not the internals. Co-authored-by: Stuart lang <stuart.b.lang@gmail.com>

view details

Martin Costello

commit sha 645a5bdf20afda1cf0a061037cee97659abe0595

Update README Update .NET version and add BrowserStack note.

view details

Martin Costello

commit sha 648d0f9ad0235a952fa0fc935ff038b1a833f30b

Support videos in BrowserStack (#37) * Support videos in BrowserStack BrowserStack does not stop the video until the session ends, so any attempt to save the video while the browser is connected will just hang indefinitely. Instead, get the video URL from the BrowserStack context and then download it after the browser session has ended. * Create the video directory Create the directory to put the videos in if it doesn't already exist. * Increase test timeout Increase the test timeout to account for the additional time trying to download the videos from BrowserStack. * Remove the timeout Now the hang has been resolved, just let it take as long as it takes.

view details

martincostello

commit sha 309a1758ab64cb16febc001fa34c3e0063e7fee5

Add Solution Items Add Solutions Items to the solution.

view details

martincostello

commit sha 1d9e765b7821089bb4b0195276b3ed5d48339ebc

Add .vscode Add configuration files for Visual Studio Code.

view details

martincostello

commit sha c21b81e99cc0f020f2cb55d7c5d7ddb7d7485e9a

Support Codespaces Add configuration files to support GitHub Codespaces.

view details

martincostello

commit sha fded97bb1a9e11d95a0702e8f923c052651af699

Add .devcontainer Add the files for Codespaces to the solution file.

view details

martincostello

commit sha deddfb2b98c39a2269e7b658346bb17abc13e93d

Set BrowserStack test status Use setSessionStatus via Page.EvaluateAsync() to set the status of tests in BrowserStack Automate, rather than leaving them as "unmarked".

view details

martincostello

commit sha 92524a680f3ca40739b64fdd58c6dc440adf6073

Update README Add more content to the README, highlighting the sample's features.

view details

push time in 3 days

push eventslang25/JustSaying

Stuart lang

commit sha 5420fd65cceea3191110283f5d704b84324964f0

Revert "Try the new provider" This reverts commit ca21348e0942ad2c54ba0298c10201e15b104a19.

view details

push time in 3 days

push eventslang25/JustSaying

Stuart lang

commit sha ca21348e0942ad2c54ba0298c10201e15b104a19

Try the new provider

view details

push time in 3 days

push eventslang25/JustSaying

Stuart lang

commit sha b222943194501674b069ea4de61c744a664d0a70

Use quiet flag for docker pull

view details

push time in 3 days

PR opened justeat/JustSaying

Update localstack
+3 -3

0 comment

1 changed file

pr created time in 3 days

push eventslang25/JustSaying

dependabot[bot]

commit sha e4ea935aabf69893dfbbd89f144fe605f3ae15be

Bump MartinCostello.Logging.XUnit from 0.1.2 to 0.2.0 Bumps [MartinCostello.Logging.XUnit](https://github.com/martincostello/xunit-logging) from 0.1.2 to 0.2.0. - [Release notes](https://github.com/martincostello/xunit-logging/releases) - [Commits](https://github.com/martincostello/xunit-logging/compare/v0.1.2...v0.2.0) --- updated-dependencies: - dependency-name: MartinCostello.Logging.XUnit dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

view details

dependabot[bot]

commit sha 869bb34076dbf1fcca9486a6d18e09b13539966c

Merge pull request #939 from justeat/dependabot/nuget/MartinCostello.Logging.XUnit-0.2.0

view details

dependabot[bot]

commit sha 24f4bf3837305c3b17dfe4725a021d78d7cd8fd4

Bump Swashbuckle.AspNetCore from 6.2.2 to 6.2.3 Bumps [Swashbuckle.AspNetCore](https://github.com/domaindrivendev/Swashbuckle.AspNetCore) from 6.2.2 to 6.2.3. - [Release notes](https://github.com/domaindrivendev/Swashbuckle.AspNetCore/releases) - [Commits](https://github.com/domaindrivendev/Swashbuckle.AspNetCore/compare/v6.2.2...v6.2.3) --- updated-dependencies: - dependency-name: Swashbuckle.AspNetCore dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

view details

Martin Costello

commit sha ffe57a95abf8eff1b925815d50c08da04dfac3d8

Merge pull request #940 from justeat/dependabot/nuget/Swashbuckle.AspNetCore-6.2.3

view details

Stuart Lang

commit sha 4a665e7b650829a9cf9dac39525c44e17dc34968

Merge pull request #938 from slang25/update-localstack Upgrade to localstack 0.12.19

view details

dependabot[bot]

commit sha 4c6766f88976b823369b8275cbee2049e691cecd

Bump Microsoft.NET.Test.Sdk from 16.11.0 to 17.0.0 Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.11.0 to 17.0.0. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](https://github.com/microsoft/vstest/compare/v16.11.0...v17.0.0) --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

view details

Stuart Lang

commit sha fddf2ded612cfdb679dbf7426602b2ef160f1d90

Merge pull request #941 from justeat/dependabot/nuget/Microsoft.NET.Test.Sdk-17.0.0 Bump Microsoft.NET.Test.Sdk from 16.11.0 to 17.0.0

view details

dependabot[bot]

commit sha 4653b8c8184520610214c665c8ece330b060129e

Bump Serilog.Extensions.Logging from 3.0.1 to 3.1.0 Bumps [Serilog.Extensions.Logging](https://github.com/serilog/serilog-extensions-logging) from 3.0.1 to 3.1.0. - [Release notes](https://github.com/serilog/serilog-extensions-logging/releases) - [Commits](https://github.com/serilog/serilog-extensions-logging/compare/v3.0.1...v3.1.0) --- updated-dependencies: - dependency-name: Serilog.Extensions.Logging dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

view details

Martin Costello

commit sha c752f6de61d071ecc400b790a901ad6015030b10

Merge pull request #946 from justeat/dependabot/nuget/Serilog.Extensions.Logging-3.1.0

view details

stuart.lang@just-eat.com

commit sha 6643a72e866812487866de456d5ad2d69064c2aa

Use SDK version 6.0.100

view details

stuart.lang@just-eat.com

commit sha 6c9930cd5bccbb7f12052db89d9ac1f2954e1597

Add implicit usings

view details

stuart.lang@just-eat.com

commit sha c5287d49175b3c311ebc186b615c145a4490d4a0

Use file-scoped namespaces

view details

stuart.lang@just-eat.com

commit sha 7e9a4acfb5750a6daf906cde90328cad5f17e0cf

Update project TFMs and library versions

view details

stuart.lang@just-eat.com

commit sha 48fb32c07263b9e98e72f0ac81b2a75f7c3096f9

Top-level statements

view details

stuart.lang@just-eat.com

commit sha c976c894d30ff3d5762f808a13ea5af72e5dd63b

Add some global usings for test projects

view details

stuart.lang@just-eat.com

commit sha 47a26b0afc7616f848b5266e61fa3db1aec984ca

Use minimal APIs

view details

Stuart Lang

commit sha 6802ac1b0e5823fa9780f9358836068a634f8974

Update samples/src/JustSaying.Sample.Restaurant.OrderingApi/Program.cs Co-authored-by: Martin Costello <martin@martincostello.com>

view details

stuart.lang@just-eat.com

commit sha a7efe7fbdc39ceb0af0277ab135a97e510a68573

Update .editorconfig

view details

stuart.lang@just-eat.com

commit sha 8653efca46b2ee95bc020be203880fb5ad2ce488

Update .editorconfig

view details

stuart.lang@just-eat.com

commit sha cafac5e91a51d3f9fc5010a68c1911eea0f780d0

Update libraries

view details

push time in 3 days

create barnchslang25/dotnet-playwright-tests

branch : update-build-script

created branch time in 5 days

pull request commentdaveaglick/Buildalyzer

Handle self-contained apps

Thanks @psfinaki & @daveaglick, my original PR was a misstep, I had no idea the VS design-time behaviour was so involved, I just thought it was a few magic properties 😆

@daveaglick what's the VS extension that shows the MSBuild magic there?

psfinaki

comment created time in 6 days

issue commentCZEMacLeod/MSBuild.SDK.SystemWeb

Support for C# 10?

That brings back some bad memories. I think this SO answer might help: https://stackoverflow.com/a/51424880/2225808

Bouke

comment created time in 6 days

issue commentaws/aws-lambda-dotnet

Solution using Amazon.Lambda.Annotations fails to compile with AWSLambda0001 error

It looks like it expects the following package to be referenced:

<PackageReference Include="Amazon.Lambda.APIGatewayEvents" Version="2.4.0" />
martincostello

comment created time in 7 days

pull request commentdaveaglick/Buildalyzer

Handle self-contained apps

I could be wrong, but I think the way Stryker is using Buildalyzer falls under the DesignTime = false scenario, as you are looking actually build the thing, in a way that it needs to output and run.

Thinking back, another time I've ran into Buildalyzer "clobbering" existing properties is the SolutionDir property that is present in mega-old projects, before NuGet was better integrated into MSBuild, it would be a calculated property. However when doing a design-time build or not, Buildalyzer will try to set it.

I'm thinking rather than baking in lots of smarts around detecting when to set a property, or handing back explicit control over the value, perhaps there should be a configure list of properties you want Buildalyzer to "leave alone". I think this could reduce complexity in the long run, and solve the OP issue. I could remove some workarounds in my projects too.

psfinaki

comment created time in 7 days

startedjusteattakeaway/Genything

started time in 8 days

startedionide/KeepAChangelog

started time in 11 days

pull request commentdaveaglick/Buildalyzer

Revert "Disable AppHost Creation"

The change wasn't I initially intended as an optimization, I was getting errors where the apphost wasn't found. Buildalyzer will perform a design time build, which shouldn't be trying to copy native dependencies required for running the app.

Is there a particular issue you are facing?

psfinaki

comment created time in 12 days

push eventslang25/MSBuildStructuredLog

Stuart Lang

commit sha e31164720c18f850825cf9740d25c856faebb045

Remove spaces from macOS artifacts

view details

push time in 13 days

issue commentJiXiaomai/SMM2LevelViewer

Command line edition for saving images

I have ported this locally to C#, using ImageSharp so that it is cross platform (I'm on a mac) as a .NET 6 command line tool. I'd like it to run in web assembly too so that it can be hosted on Netlify for free.

It's currently partly functional, I've not quite got it drawing everything, but I'll be back at some point when I get it working to a reasonable standard.

burritosoftware

comment created time in 14 days

issue commentKirillOsenkov/MSBuildStructuredLog

I can't find release artifacts for Avalonia.

You can grab the macOS per-architecture builds from the CI artifacts here: https://ci.appveyor.com/project/KirillOsenkov/msbuildstructuredlog/builds/42050519/artifacts

I'm still interested in adding GitHub Actions as I think it would be easier to build on macOS/linux for the mac build, that way the user won't need to chmod +x the executable before it's usable.

There are a few outstanding things I'd need to solve/understand

  • The version number today is dictated by AppVeyor, if we wanted to move the build, or build on both platforms (I think that would be a good stepping-stone) then we might need to adopt something like GitVersion or MinVer
  • What's the integration process with SignPath, is that just for the Windows build, and what happens after the webhook is triggered? If it is Windows only then we can defer this while moving the macOS build to GitHub Actions.
mfilippov

comment created time in 15 days

issue commentdotnet/fsharp

F# project does not work with NuGet lockfile

The problem we have is that as soon as you add a Directory.Packages.props file and start using features like centrally managed package versions, it is incompatible with the implicit FSharp.Core reference, and the error message doesn't help point you to the fix, which is to follow the instructions in the OP here.

I think the NuGet NU1008 warning should be aware of this special case, or there be some other metadata flowed through to help identify this scenario.

Ultimately we need something that indicates to the inner NuGet machinery & VS UI that this package is implicitly defined by default, but you can change the package version in the VS UI, which should result in disabling the implicit reference and add a local explicit one (i.e. not use Update="FSharp.Core").

That would suggest to me that the best place to address this would be in the VS UI, and to add IsImplicitlyDefined as started here.

purkhusid

comment created time in 15 days

startedbadamczewski/PowerUp

started time in 16 days

issue openedmicrosoft/playwright-dotnet

`RouteAsync` doesn't take async delegates

Feature request

RouteAsync currently accepts an Action<IRoute>, however it is expected we call methods on the IRoute instance such as route.FulfillAsync(). As a .NET developer, it seems like I should await the result of FulfillAsync, but the delegate we are in is synchronous.

We could not await it, like in the tests, or make the delegate async, which would feel wrong because we cannot assume the implementation will know to handle a sync vs async delegate.

It seems to me that the methods on IRoute should be synchronous to match their usage in the tests: https://github.com/microsoft/playwright-dotnet/blob/bf25fc707bbf54746134b7de78edfe08bf67d01b/src/Playwright.Tests/PageRouteTests.cs#L628-L640

Can you clarify?

created time in 20 days

issue openedlynn/hello-wordl

Thank you!

I've been playing this for the last hour and it's awesome, thanks for taking the time to build it 🙂

created time in 20 days

startedlynn/hello-wordl

started time in 20 days

PullRequestReviewEvent

Pull request review commentaws/aws-lambda-dotnet

Adding SQSBatchResponse class to support partial success for SQS batches

+using System.Collections.Generic;++namespace Amazon.Lambda.SQSEvents+{+    /// <summary>+    /// Simle Queue Service response

I'm not great with wording, but something like this

jon-armen

comment created time in 25 days

PullRequestReviewEvent

Pull request review commentaws/aws-lambda-dotnet

Adding SQSBatchResponse class to support partial success for SQS batches

+using System.Collections.Generic;++namespace Amazon.Lambda.SQSEvents+{+    /// <summary>+    /// Simle Queue Service response
    /// This class can be used as the return type for Lambda functions that have partially succeeded by supplying a list of message IDs that have failed to process.
    /// https://docs.aws.amazon.com/lambda/latest/dg/with-sqs.html#services-sqs-batchfailurereporting
jon-armen

comment created time in 25 days

more