profile
viewpoint
Erki skull132 @Aurorastation https://aurorastation.org/ The Head Developer and project lead for @Aurorastation , a popular fork for an open source 2d game. A Mechatronics Engineering bachelor student.

Aurorastation/A.S.S.-RPC-protobuffs 1

gRPC templates for the Aurora Server System.

Aurorastation/A.S.S.-DM-api 0

DM API and C++ library for communication between DreamDaemon and the Aurora Server System.

Karolis2011/Aurora.3 0

The code for Aurorastation's new base, forked from Baystation12.

skull132/Aurora 0

For Aurorastation to use on SS13, forked from Baystation12.

skull132/Aurora.3 0

The code for Aurorastation's new base, forked from Baystation12.

skull132/AuroraCore 0

A bare-bones BYOND project with StonedMC and other controllers from Aurora.

skull132/Baystation12 0

The code for Baystation12's branch of SS13

Pull request review commentAurorastation/Aurora.3

Fixes nanopaste not using charge for surgery.

 				var/obj/item/organ/internal/brain/sponge = target.internal_organs_by_name[BP_BRAIN] 				if(sponge && istype(I, sponge)) 					target.cure_all_traumas()+				if(istype(tool, /obj/item/stack/nanopaste))+					var/obj/item/stack/nanopaste/nanopaste = tool+					nanopaste.use(1)

This isn't addressed. Do this in the can_use proc above.

	if (istype(tool, /obj/item/stack/nanopaste))
		var/obj/item/stack/nanopaste/NP = tool
		if (NP.uses_charge < 1)
			to_chat(user, span("notice", "[NP] is empty and cannot be used for this surgery."))
			return SURGERY_FAILURE
BoryaTheSlayer

comment created time in 15 hours

Pull request review commentAurorastation/Aurora.3

Various pAI Tweaks + Sound Tweaks

  	if(!check_rights(R_ADMIN)) 		return--	if (!mob)+	if(!mob) 		return -	var/turf/t = get_turf(mob)+	var/turf/T = get_turf(mob) 	var/pai_key 	var/name = input(mob, "", "What will the pAI's name be?") as text|null-	if (!name)+	if(!name) 		return  	if(!pai_key) 		var/client/C = input("Select client") as null|anything in clients-		if(!C) return+		if(!C)+			return 		pai_key = C.key -	log_and_message_admins("made a pAI with key=[pai_key] at ([t.x],[t.y],[t.z])")-	var/obj/item/device/paicard/card = new(t)+	log_and_message_admins("made a pAI with key=[pai_key] at ([T.x],[T.y],[T.z])")
	log_and_message_admins("made a pAI with key=[pai_key]")
Geevies

comment created time in 15 hours

Pull request review commentAurorastation/Aurora.3

Various pAI Tweaks + Sound Tweaks

  	return hear +/proc/get_turfs_in_view(var/R, var/atom/source)+	var/turf/start_point = get_turf(source)+	var/list/hear_turfs = list()++	if(!start_point)+		return hear_turfs++	var/list/range = hear(R, start_point)+	for(var/turf/T in range)

This is technically a fuck-up. view() != range(). The proc's name is a lie.

Geevies

comment created time in 15 hours

Pull request review commentAurorastation/Aurora.3

Various pAI Tweaks + Sound Tweaks

  	if(!check_rights(R_ADMIN)) 		return--	if (!mob)+	if(!mob) 		return -	var/turf/t = get_turf(mob)+	var/turf/T = get_turf(mob) 	var/pai_key 	var/name = input(mob, "", "What will the pAI's name be?") as text|null-	if (!name)+	if(!name) 		return  	if(!pai_key) 		var/client/C = input("Select client") as null|anything in clients-		if(!C) return+		if(!C)+			return 		pai_key = C.key -	log_and_message_admins("made a pAI with key=[pai_key] at ([t.x],[t.y],[t.z])")-	var/obj/item/device/paicard/card = new(t)+	log_and_message_admins("made a pAI with key=[pai_key] at ([T.x],[T.y],[T.z])")

Coords unnecessary. They're added automatically based on usr.

Geevies

comment created time in 15 hours

Pull request review commentAurorastation/Aurora.3

Adding admin verb to load templates(maps) during runtime.

 				if(holder.throw_atom) 					holder.throw_atom.throw_at(object, 10, 1) 					log_admin("[key_name(usr)] threw [holder.throw_atom] at [object]",admin_key=key_name(usr))++/verb/load_template_verb()+	set name = "Load Template"+	set category = "Special Verbs"+	if(!usr)+		return+	load_template(usr)++/proc/load_template(var/mob/user)+	if(!user)+		return++	if(!check_rights(R_SPAWN))+		return++	var/list/templates+	try+		templates = json_decode(return_file_text("config/templates_list.json"))+	catch(var/exception/ej)+		log_debug("Warning: Could not load the templates config as templates_list.json is missing - [ej]")+		return++	if(!templates || !templates["templates_list"] || templates["templates_folder"] == "")+		return++	var/turf/T = get_turf(user)+	var/name = input(user, "Which template would you like to load?", "Load Template", null) as null|anything in templates["templates_list"]+	+	if (!name || !T)+		return++	var/datum/map_template/maploader = new (templates["templates_folder"] + name, name)+	if (!maploader)+		log_debug("Error, unable to load maploader in proc load_template!")+		return++	var/centered = input(user, "Do you want template to load as center or Edge?", "Load Template", null) as null|anything in list("Center", "Edge")+	maploader.load(T, centered == "Center" ? TRUE : FALSE)+	log_and_message_admins("[key_name_admin(user)] has loaded template [name] at the coordinates [T.x], [T.y], [T.z].", user, T)

psure the coords are already logged with log_and_message_admins when you pass T.

Sindorman

comment created time in 17 hours

push eventAurorastation/Aurora.3

mikomyazaki

commit sha 8d5757bb076aed760f87ae1fad280ec7c57ae6f7

Adds unique bantypes to a bunch of antag roles. (#8033) Bunch of antag roles didn't have a unique bantype defined, so banning for one of them banned for all of them. This will cause people who are banned from one of these roles to no longer be banned from those roles. So it will require some tweaking of bans by admins. Hopefully not too many people hold antag bans -- Here is the fix if anyone wants to go through that effort, anyway. Fixes #7462

view details

push time in 2 days

PR merged Aurorastation/Aurora.3

Reviewers
Adds unique bantypes to a bunch of antag roles Awaiting Merge Bugfix Sprites

Bunch of antag roles didn't have a unique bantype defined, so banning for one of them banned for all of them.

This will cause people who are banned from one of these roles to no longer be banned from those roles. So it will require some tweaking of bans by admins. Hopefully not too many people hold antag bans -- Here is the fix if anyone wants to go through that effort, anyway.

Fixes #7462

+16 -0

4 comments

7 changed files

mikomyazaki

pr closed time in 2 days

issue closedAurorastation/Aurora.3

Antag Ban panel issues. (Staff related bug)

You can't ban someone solely from the malf role. It decides to choose other roles as well for some reason. unknown

closed time in 2 days

SonicGotNuked

pull request commentAurorastation/Aurora.3

Renovates the Consular Officer office on the Odin

The office is. Empty. Very empty. And IMO that's not a good look for this.

Leudoberct1

comment created time in 3 days

push eventAurorastation/Aurora.3

skull132

commit sha 982c5e808e057a07c1cd2584eefd3791e4ce2ab9

Fix rust_g.dll

view details

push time in 3 days

Pull request review commentAurorastation/Aurora.3

Reimplements old Unathi devour with some miscellaneous improvements.

+ #define PPM 9	//Protein per meat, used for calculating the quantity of protein in an animal++/**+ *  Attempt to devour victim+ *+ *  Returns TRUE on success, FALSE on failure+ */+/mob/living/carbon/human/proc/devour(atom/movable/victim)+	var/can_eat = can_devour(victim)+	if(!can_eat)+		return FALSE++	var/eat_speed = 100+	if(can_eat == DEVOUR_FAST)+		eat_speed = 30+	if(species?.gluttonous & GLUT_MESSY && ismob(victim))
	if((species?.gluttonous & GLUT_MESSY) && ismob(victim))

Convention is to guard binary ops with parens.

NonQueueingMatt

comment created time in 3 days

Pull request review commentAurorastation/Aurora.3

Undislocation Tweaks

 	set desc = "Pop a joint back into place. Extremely painful." 	set src in view(1) -	if(!isliving(usr) || !usr.canClick())+	if(use_check_and_message(usr, USE_ALLOW_INCAPACITATED)) 		return -	usr.setClickCooldown(20)--	if(usr.stat > 0)-		to_chat(usr, "You are unconcious and cannot do that!")-		return--	if(usr.restrained())-		to_chat(usr, "You are restrained and cannot do that!")+	if(!usr.canClick())+		to_chat(usr, span("warning", "You cannot do this so soon!")) 		return+	usr.setClickCooldown(20) -	var/mob/S = src+	var/mob/living/carbon/human/S = src 	var/mob/U = usr

Both of these vars are pointless. Remove.

Geevies

comment created time in 3 days

Pull request review commentAurorastation/Aurora.3

Undislocation Tweaks

 proc/GaussRandRound(var/sigma,var/roundto) 	if (progbar) 		qdel(progbar) -/proc/do_after(mob/user as mob, delay as num, needhand = TRUE, atom/movable/act_target = null, use_user_turf = FALSE, display_progress = TRUE, datum/callback/extra_checks)

No it isn't. as X syntax only applies to verbs and procs-as-verbs.

Geevies

comment created time in 3 days

pull request commentAurorastation/Aurora.3

Strip Menu Additions

Not making this VueUI based

smh.

Geevies

comment created time in 3 days

Pull request review commentAurorastation/Aurora.3

Reworking and optimizing buttons

 Class Procs: 	var/has_special_power_checks = FALSE	// If true, call auto_use_power instead of doing it all in SSmachinery. 	var/clicksound //played sound on usage 	var/clickvol = 40 //volume+	var/listener/button_sig_listener+	var/id = null+	var/button_control = FALSE

I'm not sold on this variable. Two reasons. First, in order to make something listener controllable you now have to modify TWO variables. ID AND this. Is there ever a case where you'd make ID be not-null but leave this as FALSE?

Sindorman

comment created time in 3 days

Pull request review commentAurorastation/Aurora.3

Reworking and optimizing buttons

 won't update every console in existence) but it's more of a hassle to do. Also, 	var/obj/machinery/r_n_d/circuit_imprinter/linked_imprinter = null	//Linked Circuit Imprinter  	var/screen = 1.0	//Which screen is currently showing.-	var/id = 0			//ID of the computer (for server restrictions).+	id = 0			//ID of the computer (for server restrictions).

Bad default value.

Sindorman

comment created time in 3 days

Pull request review commentAurorastation/Aurora.3

Reworking and optimizing buttons

 	density = 1 	use_power = 1 	idle_power_usage = 250-	var/id = 0+	id = 0

Bad default value.

Sindorman

comment created time in 3 days

Pull request review commentAurorastation/Aurora.3

Reworking and optimizing buttons

 	var/last_pos = -1			// last direction setting 	var/operated = 1			// true if just operated -	var/id = "" 				// must match conveyor IDs to control them+	id = "" 				// must match conveyor IDs to control them

Bad default value.

Sindorman

comment created time in 3 days

Pull request review commentAurorastation/Aurora.3

Reworking and optimizing buttons

 	use_power = 0 	idle_power_usage = 0 	active_power_usage = 0-	var/id = 0+	id = 0

Bad default value.

Sindorman

comment created time in 3 days

Pull request review commentAurorastation/Aurora.3

Reworking and optimizing buttons

 	var/reversed		// se to 1 if the belt is reversed  	var/list/affecting	// the list of all items that will be moved this ptick-	var/id = ""			// the control ID	- must match controller ID+	id = ""			// the control ID	- must match controller ID

Bad default value.

Sindorman

comment created time in 3 days

Pull request review commentAurorastation/Aurora.3

Reworking and optimizing buttons

 var/global/list/obj/machinery/telecomms/telecomms_list = list() 	var/traffic = 0 // value increases as traffic increases 	var/netspeed = 5 // how much traffic to lose per tick (50 gigabytes/second * netspeed) 	var/list/autolinkers = list() // list of text/number values to link with-	var/id = "NULL" // identification string+	id = "NULL" // identification string

Bad default value.

Sindorman

comment created time in 3 days

Pull request review commentAurorastation/Aurora.3

Reworking and optimizing buttons

 	density = 1 	var/obj/machinery/compressor/compressor 	var/list/obj/machinery/door/blast/doors-	var/id = 0+	id = 0

Bad default value.

Sindorman

comment created time in 3 days

Pull request review commentAurorastation/Aurora.3

Reworking and optimizing buttons

 	density = 1 	use_power = 0 -	var/id = 0+	id = 0

Bad default value.

Sindorman

comment created time in 3 days

Pull request review commentAurorastation/Aurora.3

Reworking and optimizing buttons

 	req_access = list(access_brig) 	anchored = 1.0    		// can't pick it up 	density = 0       		// can walk through it.-	var/id = null     		// id of door it controls.+	     		// id of door it controls.
Sindorman

comment created time in 3 days

Pull request review commentAurorastation/Aurora.3

Reworking and optimizing buttons

 	icon = 'icons/obj/terminals.dmi' 	icon_state = "ringer" 	anchored = TRUE-	var/id = ""+	id = ""

Bad default value.

Sindorman

comment created time in 3 days

Pull request review commentAurorastation/Aurora.3

Reworking and optimizing buttons

 	active = 1 	update_icon() -	var/list/same_id = list()--	for(var/obj/machinery/door/blast/M in SSmachinery.all_machines)-		if (M.id == src.id)-			same_id += M-			INVOKE_ASYNC(M, /obj/machinery/door/blast/open)+	for (var/i in get_listeners_by_type("machinebtn_[id]", /obj/machinery/door/blast))+		var/obj/machinery/door/blast/M = i+		if(!M)+			continue+		INVOKE_ASYNC(M, /obj/machinery/door/blast/open)  	sleep(20) -	for(var/obj/machinery/mass_driver/M in SSmachinery.all_machines)-		if(M.id == src.id)-			M.drive()+	for (var/i in get_listeners_by_type("machinebtn_[id]", /obj/machinery/mass_driver))+		var/obj/machinery/mass_driver/M = i+		if(!M)+			continue+		INVOKE_ASYNC(M, /obj/machinery/mass_driver/proc/drive)  	sleep(50) -	for(var/mm in same_id)-		INVOKE_ASYNC(mm, /obj/machinery/door/blast/close)+	for (var/i in get_listeners_by_type("machinebtn_[id]", /obj/machinery/door/blast))+		var/obj/machinery/door/blast/M = i+		if(!M)

Unnecessary, get_listeners_by_type checks by type and thus against null.

Sindorman

comment created time in 3 days

Pull request review commentAurorastation/Aurora.3

Reworking and optimizing buttons

 	active = 1 	update_icon() -	var/list/same_id = list()--	for(var/obj/machinery/door/blast/M in SSmachinery.all_machines)-		if (M.id == src.id)-			same_id += M-			INVOKE_ASYNC(M, /obj/machinery/door/blast/open)+	for (var/i in get_listeners_by_type("machinebtn_[id]", /obj/machinery/door/blast))+		var/obj/machinery/door/blast/M = i+		if(!M)

Unnecessary, get_listeners_by_type checks by type and thus against null.

Sindorman

comment created time in 3 days

Pull request review commentAurorastation/Aurora.3

Reworking and optimizing buttons

 	active = 1 	update_icon() -	var/list/same_id = list()--	for(var/obj/machinery/door/blast/M in SSmachinery.all_machines)-		if (M.id == src.id)-			same_id += M-			INVOKE_ASYNC(M, /obj/machinery/door/blast/open)+	for (var/i in get_listeners_by_type("machinebtn_[id]", /obj/machinery/door/blast))+		var/obj/machinery/door/blast/M = i+		if(!M)+			continue+		INVOKE_ASYNC(M, /obj/machinery/door/blast/open)  	sleep(20) -	for(var/obj/machinery/mass_driver/M in SSmachinery.all_machines)-		if(M.id == src.id)-			M.drive()+	for (var/i in get_listeners_by_type("machinebtn_[id]", /obj/machinery/mass_driver))+		var/obj/machinery/mass_driver/M = i+		if(!M)

Unnecessary, get_listeners_by_type checks by type and thus against null.

Sindorman

comment created time in 3 days

Pull request review commentAurorastation/Aurora.3

Reworking and optimizing buttons

 	*/  /obj/machinery/button/remote/airlock/trigger()-	for(var/obj/machinery/door/airlock/D in SSmachinery.processing_machines)-		if(D.id_tag == src.id)-			if(specialfunctions & OPEN)-				if (D.density)-					spawn(0)-						D.open()-						return-				else-					spawn(0)-						D.close()-						return-			if(desiredstate == 1)-				if(specialfunctions & IDSCAN)-					D.set_idscan(0)-				if(specialfunctions & BOLTS)-					D.lock()-				if(specialfunctions & SHOCK)-					D.electrify(-1)-				if(specialfunctions & SAFE)-					D.set_safeties(0)+	for (var/i in get_listeners_by_type("machinebtn_[id]", /obj/machinery/door/airlock))+		var/obj/machinery/door/airlock/D = i+		if(!D)

Unnecessary, get_listeners_by_type checks by type and thus against null.

Sindorman

comment created time in 3 days

Pull request review commentAurorastation/Aurora.3

Reworking and optimizing buttons

 	desc = "It controls blast doors, remotely."  /obj/machinery/button/remote/blast_door/trigger()-	for(var/obj/machinery/door/blast/M in SSmachinery.all_machines)-		if(M.id == src.id)-			if(M.density)-				spawn(0)-					M.open()-					return-			else-				spawn(0)-					M.close()-					return+	for (var/i in get_listeners_by_type("machinebtn_[id]", /obj/machinery/door/blast))+		var/obj/machinery/door/blast/M = i+		if(!M)

Unnecessary, get_listeners_by_type checks by type and thus against null.

Sindorman

comment created time in 3 days

Pull request review commentAurorastation/Aurora.3

Reworking and optimizing buttons

 	desc = "It controls emitters, remotely."  /obj/machinery/button/remote/emitter/trigger(mob/user as mob)-	for(var/obj/machinery/power/emitter/E in SSmachinery.all_machines)-		if(E.id == src.id)-			spawn(0)-				E.activate(user)-				return+	for (var/i in get_listeners_by_type("machinebtn_[id]", /obj/machinery/power/emitter))+		var/obj/machinery/power/emitter/E = i+		if(!E)

Unnecessary. get_listeners_by_type already type checks.

Sindorman

comment created time in 3 days

Pull request review commentAurorastation/Aurora.3

Reworking and optimizing buttons

 	light_color = LIGHT_COLOR_ORANGE 	req_access = list(access_armory) 	circuit = /obj/item/circuitboard/prisoner-	var/id = 0.0+	id = 0.0

Bad default value.

Sindorman

comment created time in 3 days

Pull request review commentAurorastation/Aurora.3

Reworking and optimizing buttons

 	icon_screen = "command" 	light_color = "#00b000" 	circuit = /obj/item/circuitboard/pod-	var/id = 1.0+	id = 1.0

wat. Remove?

Sindorman

comment created time in 3 days

Pull request review commentAurorastation/Aurora.3

Reworking and optimizing buttons

 	active_power_usage = 100000	//100 kW ~ 135 HP  	var/global/gid = 1-	var/id = 0+	id = 0

bad idea/unnecessary?

Sindorman

comment created time in 3 days

push eventAurorastation/Aurora.3

Erki

commit sha 63bf0030f647096c048fb71fb545557a08c727d9

Fixes async HTTP for getting pins (#8073) A few issues: Async response enums were bad. Async requests didn't handle an unforeseen error properly. Get pins were sending an input which would cause a crash of the DLL. (DLL is now fixed to not crash due to this.)

view details

push time in 4 days

PR merged Aurorastation/Aurora.3

Fixes async HTTP for getting pins Awaiting Merge Bugfix Changelog Required High Priority

A few issues:

  • Async response enums were bad.
  • Async requests didn't handle an unforeseen error properly.
  • Get pins were sending an input which would cause a crash of the DLL. (DLL is now fixed to not crash due to this.)
+13 -6

0 comment

4 changed files

skull132

pr closed time in 4 days

push eventskull132/rust-g

skull132

commit sha 0e25a5e9801c6ac11862a5d0c7c626141177c923

No more unwrap

view details

push time in 5 days

push eventskull132/Aurora.3

skull132

commit sha 4743fcffed70a9d7d36fefb23a3333605c76d9a3

Rustg fixes and remove debug

view details

push time in 5 days

PR opened Aurorastation/Aurora.3

Fixes async HTTP for getting pins Bugfix High Priority Review Required

A few issues:

  • Async response enums were bad.
  • Async requests didn't handle an unforeseen error properly.
  • Get pins were sending an input which would cause a crash of the DLL. (DLL is now fixed to not crash due to this.)
+15 -6

0 comment

4 changed files

pr created time in 5 days

create barnchskull132/Aurora.3

branch : bugfix/async_http

created branch time in 5 days

push eventAurorastation/Aurora.3

mikomyazaki

commit sha 3b3ee395f6f51dde3a4825e4aa19f4a008ded9a4

Dead people don't have a pulse. (#8053) Sets pulse to zero when the owner is dead, so we don't get weird readings on medical scans of the recently deceased. Fixes #7720

view details

mikomyazaki

commit sha b7d73932b62a93fe394de6c6c8eed36a930d60c6

Limits guest pass name length to 26. (#8048) It's currently 1024. Someone used the wrong sanitize() Fixes #7852

view details

ParadoxSpace

commit sha a48d883d4b87091211d6951f161024f2b2b131d6

Department Jacket Tweaks (#7893) Adds zippers to every single jacket's open sprite. Adds NT logo to back of Security jackets. Adds Service jacket. Makes descriptions slightly funnier.

view details

mikomyazaki

commit sha 25fa737038a89686636d713682d2d29e01e6bc76

Fixes diona regeneration bug. (#8046) Opening a new PR because I closed my first one accidentally trying to figure out why Travis was being upset. Previous PR Diona regen was depending on a health value calculated from brain damage, which they never had. Therefore it wouldn't trigger properly when the Diona sustained damage. Fixes #7655

view details

mikomyazaki

commit sha e21fc07997e956907fbf4f789ba493e89d607675

Latespawn AI will have their eye spawn in the correct location. (#8056)

view details

fernerr

commit sha b8c9dd8177ae54f3f97c90160e03f91bcd92a347

Some small mapfixes and tweaks (#8059)

view details

Yonnimer

commit sha 5e1d77647665521925b1936ff6b7c0984b16e199

Allows dionae to join younger then 17. (#8054) * Allows dionae to be younger then 17 on station. * changelog * grammar nazi Co-Authored-By: mikomyazaki <47489928+mikomyazaki@users.noreply.github.com> Co-authored-by: mikomyazaki <47489928+mikomyazaki@users.noreply.github.com>

view details

ParadoxSpace

commit sha 823083255bcb1d72120e57ba9a6999dba953846c

Fixes Unathi Claw Markings (#8062)

view details

AuroraBuildBot

commit sha 2ec11d0d96bbc19732b354f83395e216a9e27cf6

"[ci skip] Automatic Build - 2020.01.22.19.06.00"

view details

push time in 5 days

create barnchAurorastation/Aurora.3

branch : support/temp_working

created branch time in 6 days

pull request commentAurorastation/Aurora.3

Diona Consuming Air

Can we have a real big think about this for just a moment.

Diona can form massive exo-planets. They can survive in a setting without air, or any atmosphere for that matter. At which point, them getting "nutrition" or energy via light makes sense. Adding "Air" as a source of nutriment seems arbitrary, surely, if not inconsistent.

ParadoxSpace

comment created time in 7 days

push eventAurorastation/Aurora.3

Erki

commit sha 92c51c47c98f756f09f6d16e880a9d1fdc51c257

Asynchronous (& synchronous) HTTP (#7989) Implements Rust-g based HTTP requests. Removes old curl-based C library. Features: Adjustable method, body, headers. Support for both HTTP and HTTPS. Supports blocking (synchronous) operations, and non-blocking (asynchronous) operations.

view details

push time in 7 days

PR merged Aurorastation/Aurora.3

Asynchronous (& synchronous) HTTP Awaiting Merge Changelog Required

DEPENDS UPON RUSTG: https://github.com/Aurorastation/rust-g/pull/6

Implements Rust-g based HTTP requests. Removes old curl-based C library.

Features:

  • Adjustable method, body, headers.
  • Support for both HTTP and HTTPS.
  • Supports blocking (synchronous) operations, and non-blocking (asynchronous) operations.

TODO:

  • [x] Remove old curl-based library and dependencies (DLLs).
  • [x] Convert old requests to new ones, async if possible. (Specially discord and webhooks.)
  • [ ] ???
+184 -435

1 comment

11 changed files

skull132

pr closed time in 7 days

push eventAurorastation/Aurora.3

Erki

commit sha 9b2cec5988d0de9fdcdb8e3eefbc4036727d6583

Update BYOND in Travis (#8063)

view details

push time in 7 days

PR merged Aurorastation/Aurora.3

Maybe fix travis Changelog Required High Priority Waiting Period
+1 -1

0 comment

1 changed file

skull132

pr closed time in 7 days

PR opened Aurorastation/Aurora.3

Maybe fix travis
+1 -1

0 comment

1 changed file

pr created time in 7 days

create barnchskull132/Aurora.3

branch : support/testies

created branch time in 7 days

push eventAurorastation/Aurora.3

skull132

commit sha 3d058d65e1d743991aa2bd6720fa0b7ae6058162

Fix dynamic maps

view details

push time in 14 days

push eventAurorastation/Aurora.3

skull132

commit sha 4f60ae8fe399cd52264471a3b242148612e6d882

test

view details

push time in 14 days

push eventAurorastation/Aurora.3

skull132

commit sha dbd4359eb106b0e85c9bc992bc4d23822ae43aaa

fuck you TGS

view details

push time in 14 days

pull request commentAurorastation/Aurora.3

Makes Reishi More Easily Obtainable

!review

furrycactus

comment created time in 15 days

push eventAurorastation/Aurora.3

skull132

commit sha fade390565a61296552a7e340b5404bbf61db5de

Space ruins now static

view details

push time in 15 days

push eventAurorastation/Aurora.3

Erki

commit sha 5d64c39f053e8f5878fd3e4f1380e9f3d043df75

Quick round of fail2topic fixes (#7998) Fixes one case where rate-limit allows one too many tries pass. Adjusts max content length to handle things like faxes and admin announces better.

view details

push time in 15 days

PR merged Aurorastation/Aurora.3

Reviewers
Quick round of fail2topic fixes Awaiting Merge Bugfix Changelog Required
  • Fixes one case where rate-limit allows one too many tries pass.
  • Adjusts max content length to handle things like faxes and admin announces better.
+3 -2

0 comment

2 changed files

skull132

pr closed time in 15 days

PR opened Aurorastation/Aurora.3

Reviewers
Quick round of fail2topic fixes Bugfix Review Required
  • Fixes one case where rate-limit allows one too many tries pass.
  • Adjusts max content length to handle things like faxes and admin announces better.
+3 -2

0 comment

2 changed files

pr created time in 15 days

create barnchskull132/Aurora.3

branch : bugfix/fail2topic_fixes

created branch time in 15 days

pull request commentAurorastation/Aurora.3

FIB escort fixes.

lmao

NonQueueingMatt

comment created time in 15 days

pull request commentAurorastation/Aurora.3

Asynchronous (& synchronous) HTTP

!review

skull132

comment created time in 15 days

push eventskull132/Aurora.3

skull132

commit sha f5325661c546a5922bc4695360b213958915f4a9

Aand out with the old

view details

push time in 15 days

push eventAurorastation/Aurora.3

Matt Atlas

commit sha ca18d4f4879d026f0e12889c33a776b8a5338b09

Renegades now have their guns put in their backpack. (#7982) Renegades now have their guns put in their backpack.

view details

push time in 15 days

PR merged Aurorastation/Aurora.3

Renegades now have their guns put in their backpack. Awaiting Merge Bugfix

Title.

+44 -4

1 comment

2 changed files

NonQueueingMatt

pr closed time in 15 days

Pull request review commentAurorastation/Aurora.3

Various pAI Tweaks + Sound Tweaks

  	return hear +/proc/get_turfs_in_view(var/R, var/atom/source)+	var/turf/start_point = get_turf(source)+	var/list/hear = list()++	if(!start_point)+		return hear++	var/list/range = hear(R, start_point)+	for(var/turf/T in range)+		hear += T

use an assoc list instead. hear[T] = TRUE

Geevies

comment created time in 15 days

Pull request review commentAurorastation/Aurora.3

Various pAI Tweaks + Sound Tweaks

 var/list/footstepfx = list("defaultstep","concretestep","grassstep","dirtstep"," 			M.playsound_to(source_turf, S, use_random_freq = use_random_freq, use_pressure = use_pressure, modify_environment = modify_environment)  /proc/playsound_lineofsight(atom/source, sound/S, use_random_freq = FALSE, use_pressure = TRUE, modify_environment = TRUE, required_preferences = 0, required_asfx_toggles = 0)-	var/list/mobs = get_mobs_or_objects_in_view(world.view, source, include_objects = FALSE)-+	var/list/turf/sound_turfs = get_turfs_in_view(world.view, source) 	var/turf/source_turf = get_turf(source) -	for (var/MM in mobs)-		var/mob/M = MM-		if (!M.sound_can_play(required_preferences, required_asfx_toggles))+	for(var/mob/M in player_list)+		if(!M.sound_can_play(required_preferences, required_asfx_toggles))+			continue+		if(!(get_turf(M) in sound_turfs))

Once you refactor to assoc list, you simply do if (!sound_turfs[get_turf(M)])

Geevies

comment created time in 15 days

Pull request review commentAurorastation/Aurora.3

Various pAI Tweaks + Sound Tweaks

  	return hear +/proc/get_turfs_in_view(var/R, var/atom/source)+	var/turf/start_point = get_turf(source)+	var/list/hear = list()++	if(!start_point)+		return hear++	var/list/range = hear(R, start_point)

hear is declared as a list in this function. What you're doing here is. Weird? You're not calling the function hear(), that's for sure.

Geevies

comment created time in 15 days

PR opened Aurorastation/Aurora.3

Asynchronous (& synchronous) HTTP

DEPENDS UPON RUSTG: https://github.com/Aurorastation/rust-g/pull/6

Implements Rust-g based HTTP requests. Removes old curl-based C library.

Features:

  • Adjustable method, body, headers.
  • Support for both HTTP and HTTPS.
  • Supports blocking (synchronous) operations, and non-blocking (asynchronous) operations.
+118 -0

0 comment

4 changed files

pr created time in 16 days

PR closed Aurorastation/rust-g

Async HTTP(S)

Done:

  • DLL init/deinit.
  • Query construction.
  • Query initiation.

TODO:

  • Any kind of error handling.
  • DM <-> DLL interface using JSON.
  • Fetching of a request's contents
  • Disposing of a request
+1372 -33

1 comment

4 changed files

skull132

pr closed time in 16 days

pull request commentAurorastation/rust-g

Async HTTP(S)

haha no.

skull132

comment created time in 16 days

create barnchskull132/Aurora.3

branch : feature/async_http

created branch time in 16 days

push eventskull132/rust-g

skull132

commit sha 6d0f1f6bf0cba5aa3ff33fbad9d0b2dc4f2411fa

Minor patches and fixes

view details

push time in 16 days

PR opened Aurorastation/rust-g

HTTP requests
+1718 -190

0 comment

7 changed files

pr created time in 16 days

push eventskull132/rust-g

Erki

commit sha f83d7ac0f15ca356f7ba52b8b61e737dd9b2377a

UDP Shipper for rust-g (#5) UDP socket is configured into non-blocking mode, so really, the only time we should be waiting on the socket would be while copying strings over. I need to run an associated PR on #Aurorastation/Aurora.3 to update the dll.

view details

skull132

commit sha 8b0eba61b0a82cb727bf1112a5c5f45a7e424276

Merge branch 'master' into feature/async_http_v2 # Conflicts: # Cargo.lock # Cargo.toml # build.rs # src/lib.rs

view details

skull132

commit sha 293a3b93292629e3a857d4a3770a10b16fcc84ed

new lock file

view details

push time in 16 days

create barnchskull132/rust-g

branch : feature/async_http_v2

created branch time in 16 days

push eventAurorastation/Aurora.3

Erki

commit sha 18e03e0a02dcdd7d0813c9a765cc81b18d2c4e8b

rustg for UDP shipping (#7897) The C++ UDP logging library has been swapped out with a rustg implementation. The rustg library uses non-blocking IO mode, and hopefully has less trouble than the C++ one. Though we'll have to see. It should error when the call is supposed to block. The old library has been removed.

view details

push time in 16 days

PR merged Aurorastation/Aurora.3

rustg for UDP shipping Review Required

COMPLEMENTARY RUSTG PR: https://github.com/Aurorastation/rust-g/pull/5

The C++ UDP logging library has been swapped out with a rustg implementation. The rustg library uses non-blocking IO mode, and hopefully has less trouble than the C++ one. Though we'll have to see. It should error when the call is supposed to block.

The old library has been removed.

+65 -137

1 comment

9 changed files

skull132

pr closed time in 16 days

push eventAurorastation/rust-g

Erki

commit sha f83d7ac0f15ca356f7ba52b8b61e737dd9b2377a

UDP Shipper for rust-g (#5) UDP socket is configured into non-blocking mode, so really, the only time we should be waiting on the socket would be while copying strings over. I need to run an associated PR on #Aurorastation/Aurora.3 to update the dll.

view details

push time in 16 days

PR merged Aurorastation/rust-g

UDP Shipper for rust-g

Needs a quick round of testing, but this should be it.

UDP socket is configured into non-blocking mode, so really, the only time we should be waiting on the socket would be while copying strings over. I need to run an associated PR on #Aurorastation/Aurora.3 to update the dll.

+37 -2

0 comment

5 changed files

skull132

pr closed time in 16 days

pull request commentAurorastation/Aurora.3

Jetpack Expectation Fix

what matt said.

Geevies

comment created time in 17 days

Pull request review commentAurorastation/Aurora.3

Adds borer as its own gamemode. Switches some psionics around.

 var/datum/antagonist/xenos/borer/borers 				continue 			if(H.mind?.special_role) 				continue+			if(!MODE_BORER in H.client.prefs.be_special_role) //Don't draft people that don't have the borer pref on.
			if(!(MODE_BORER in H.client.prefs.be_special_role)) //Don't draft people that don't have the borer pref on.
NonQueueingMatt

comment created time in 17 days

pull request commentAurorastation/Aurora.3

Adds sanity checks to hair styling

!bugfix

Arturlang

comment created time in 18 days

pull request commentAurorastation/Aurora.3

Fixes bluespace borg phase out typos

!bugfix

Arturlang

comment created time in 18 days

pull request commentAurorastation/Aurora.3

Rename Emergency Physician to Trauma Physician

!review

SierraKomodo

comment created time in 19 days

push eventAurorastation/Aurora.3

Geeves

commit sha edc71dd1c7a0e53f44fbb8366ee32d6cfd0b5e53

Fixes HoP laptop not spawning with Card Slot (#7954)

view details

push time in 19 days

PR merged Aurorastation/Aurora.3

Reviewers
Fixes HoP laptop not spawning with Card Slot Awaiting Merge Bugfix
+24 -14

2 comments

2 changed files

Geevies

pr closed time in 19 days

push eventAurorastation/Aurora.3

Erki

commit sha 4e913b613bbcf00023d149a380074ec8e87c469c

Projectiles will no longer lag the server to death (#7960) About 1.1 million instances of this runtime. This fixes all of them. In a somewhat sane manner. There was currently no mechanic which made projectiles stop if they reached the end of the map. This makes them qdel themselves.

view details

push time in 19 days

PR merged Aurorastation/Aurora.3

Projectiles will no longer lag the server to death Awaiting Merge Bugfix High Priority

https://media.discordapp.net/attachments/131489773268238336/664528067372384280/unknown.png?width=763&height=684

About 1.1 million instances of this runtime. This fixes all of them. In a somewhat sane manner. There was currently no mechanic which made projectiles stop if they reached the end of the map. This makes them qdel themselves.

+16 -1

0 comment

2 changed files

skull132

pr closed time in 19 days

push eventskull132/Aurora.3

skull132

commit sha 2ac3a1f81a46ad389097a5671100602020643183

compiler to the rescue

view details

push time in 19 days

push eventskull132/Aurora.3

skull132

commit sha ea3c004bccd8db615219d16af57adf41605043d8

Stop multiple calls to it while qdeleted

view details

push time in 19 days

PR opened Aurorastation/Aurora.3

Projectiles will no longer lag the server to death Bugfix High Priority

https://media.discordapp.net/attachments/131489773268238336/664528067372384280/unknown.png?width=763&height=684

About 1.1 million instances of this runtime. This fixes all of them. In a somewhat sane manner. There was currently no mechanic which made projectiles stop if they reached the end of the map. This makes them qdel themselves.

+10 -0

0 comment

2 changed files

pr created time in 19 days

create barnchskull132/Aurora.3

branch : bugfix/projectiles_kill_server

created branch time in 19 days

push eventAurorastation/Aurora.3

Matt Atlas

commit sha ddf87828330d7daf49b52927f3a28afef72f11a9

Removes Bedhead 5. (#7901)

view details

push time in 20 days

PR merged Aurorastation/Aurora.3

Removes Bedhead 5. Awaiting Merge Sprites

Meme goon hairstyle that is essentially flb 2.

+41 -7

2 comments

3 changed files

NonQueueingMatt

pr closed time in 20 days

push eventAurorastation/Aurora.3

Geeves

commit sha e2681ea33b8ea292faa61f0d77306a73a21a88a5

More Kataphract Stuff (#7909) Gave the Kataphracts a new backpack, the Hegemony Satchel, which has slightly more than normal storage space. Tweaked the Kataphract oxygen tank and magboots to fit the aesthetic some more. Tweaked the colours of the underclothes the Kataphracts spawn with to be more easy on the eye. Gave the Kataphract Klax a set of magboots.

view details

push time in 20 days

PR merged Aurorastation/Aurora.3

More Kataphract Stuff Awaiting Merge Sprites
  • Gave the Kataphracts a new backpack, the Hegemony Satchel, which has slightly more than normal storage space.
  • Tweaked the Kataphract oxygen tank and magboots to fit the aesthetic some more.
  • Tweaked the colours of the underclothes the Kataphracts spawn with to be more easy on the eye.
  • Gave the Kataphract Klax a set of magboots.
+42 -19

1 comment

9 changed files

Geevies

pr closed time in 20 days

PR merged Aurorastation/Aurora.3

Character set up issues for IPC's bugfix Awaiting Merge Bugfix

As a result of my recent PR. Assigning body types had unforseen changes towards the character set up, namely that bishops had access to hair and that zeng-hu would start with the baseline monitor options.

Changes the way bishop restriction for voidsuit/hardsuit usage.

1- Adds bishops as species_restricted for both voidsuits and hardsuits. 2- Does the same for Zeng-Hu, temporarily the human version. 3- Adjusts bodytype accordingly.

This originally had code for Zeng-Hu usage of machine version of voidsuit/hardsuit, but as I won't be around for a bit, I'll do the bugfix in two phases as I intend to find a less hackey method of fixing this issue. So it changes Zeng-Hu usage of machine version hardsuit/voidsuit for the time being as human version.

+47 -4

2 comments

4 changed files

Aboshedab

pr closed time in 20 days

push eventAurorastation/Aurora.3

Aboshedab

commit sha e89a3646767bc5b2fcae5d8d7249d54ea24341c8

Character set up issues for IPC's bugfix (#7926) As a result of my recent PR. Assigning body types had unforseen changes towards the character set up, namely that bishops had access to hair and that zeng-hu would start with the baseline monitor options. Changes the way bishop restriction for voidsuit/hardsuit usage. 1- Adds bishops as species_restricted for both voidsuits and hardsuits. 2- Does the same for Zeng-Hu, temporarily the human version. 3- Adjusts bodytype accordingly. This originally had code for Zeng-Hu usage of machine version of voidsuit/hardsuit, but as I won't be around for a bit, I'll do the bugfix in two phases as I intend to find a less hackey method of fixing this issue. So it changes Zeng-Hu usage of machine version hardsuit/voidsuit for the time being as human version.

view details

push time in 20 days

push eventAurorastation/Aurora.3

Karolis

commit sha 45528c644463e1aee211b11aeac40bb83f7e61ab

Fixes suit sensor monitor not auto updating. (#7936)

view details

push time in 20 days

PR merged Aurorastation/Aurora.3

Reviewers
Fixes suit sensor monitor not auto updating. Awaiting Merge Bugfix
+9 -1

1 comment

2 changed files

Karolis2011

pr closed time in 20 days

push eventAurorastation/Aurora.3

Alberyk

commit sha ebd8640a52e313126fe2609d3b62b416b48e9612

Fixes age restrictions not working when jobs were restricted by species (#7931) - fixes #7928

view details

push time in 21 days

more