profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/skitt/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Stephen Kitt skitt Red Hat Lyon, France

open-cluster-management/submariner-addon 10

An addon of submariner in ocm to provide network connectivity and service discovery among clusters.

dfarrell07/submariner 0

Connect all your Kubernetes clusters, no matter where they are in the world.

skitt/admiral 0

Admiral is the submariner API for integration with federation systems

skitt/AntennaPod 0

A podcast manager for Android

skitt/artwork 0

🎨CNCF-related logos and artwork

skitt/bstone 0

A source port of Blake Stone

skitt/build-machinery-go 0

Shared location for Makefiles, helper scripts, and other common build machinery

skitt/Chess 0

Personnal project to implement chess game with Python

skitt/Chipmunk2D 0

A fast and lightweight 2D game physics library.

PullRequestReviewEvent

push eventsubmariner-io/submariner-website

pengli

commit sha 9a61157433d532e0b0b1a801511dc7e29637f84a

fix typo Signed-off-by: pengli <justdoit.pli@gmail.com>

view details

push time in 2 days

PR merged submariner-io/submariner-website

Reviewers
Fix typo

should be two cluster : )

+1 -1

2 comments

1 changed file

vincent-pli

pr closed time in 2 days

PullRequestReviewEvent

push eventskitt/shipyard

Mike Kolesnik

commit sha e407fa0047aafb4bccf4aebb5ee489fa377419d5

Rename job so it won't shard on stable branches Right now auto release logic updates `devel` to the stable branch name when creating stable branches. This leads to this job "sharding" into multiple jobs, and messes up branch protections. To keep things simple, the main job name will remain the same so that there's no "PR targets X" and "PR targets Y" jobs, just the one "PR targets branch" job Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>

view details

Stephen Kitt

commit sha 28e7ef051570ff55ec7b190b9f2e4717ecfbbd73

Merge branch 'devel' into update-k8s-versions

view details

push time in 2 days

pull request commentopen-cluster-management/submariner-addon

Enable golangci-lint godot linter, fix errors

/lgtm /approve

dfarrell07

comment created time in 2 days

push eventskitt/admiral

Stephen Kitt

commit sha 7c6c1a0cd308bd71b80abf364c42b3809fdb29a6

Enable gocritic hugeParam, fix issues This avoids copying large data structures. In many cases, we still pass by copy instead of by reference, in particular to match K8s API practice (e.g. for DeleteOptions). In such cases, the linter is disabled with // nolint:gocritic; to limit the scope of the nolint comment, it is placed inline, and where possible the affected parameter is isolated. (It doesn't seem to be possible to only disable hugeParam, and we still want hugeParam to process any additional parameter in future anyway.) Signed-off-by: Stephen Kitt <skitt@redhat.com>

view details

push time in 2 days

push eventskitt/admiral

Stephen Kitt

commit sha f8d45fdf4b184db0d18422c5c4b8e8fe3f97d168

Enable gocritic hugeParam, fix issues This avoids copying large data structures. Signed-off-by: Stephen Kitt <skitt@redhat.com>

view details

push time in 2 days

PullRequestReviewEvent

push eventskitt/admiral

Mike Kolesnik

commit sha 79a1277a59143b3f42b9fda6b6dec8fdeb2a4921

Rename job so it won't shard on stable branches Right now auto release logic updates `devel` to the stable branch name when creating stable branches. This leads to this job "sharding" into multiple jobs, and messes up branch protections. To keep things simple, the main job name will remain the same so that there's no "PR targets X" and "PR targets Y" jobs, just the one "PR targets branch" job Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>

view details

Stephen Kitt

commit sha 0b5ac826e6b21efcb1bcf75fdb5786274db5771a

Enable gocritic hugeParam, fix issues This avoids copying large data structures. Signed-off-by: Stephen Kitt <skitt@redhat.com>

view details

push time in 3 days

PullRequestEvent

PR closed submariner-io/admiral

Reviewers
Enable gocritic hugeParam, fix issues

This avoids copying large data structures.

Signed-off-by: Stephen Kitt skitt@redhat.com

<!-- Thanks for sending a pull request! Here are some tips for you:

  1. If this is your first time, please read our developer guide: https://submariner.io/development/
  2. Ensure you have added the appropriate tests for your PR: https://submariner.io/development/code-review/#test-new-functionality
  3. Read the code review guide to ease the review process: https://submariner.io/development/code-review/
  4. If the PR is unfinished, mark it as a draft: https://submariner.io/development/code-review/#mark-work-in-progress-prs-as-drafts
  5. If you are using CI to debug, use your private fork: https://submariner.io/development/code-review/#use-private-forks-for-debugging-prs-by-running-ci
  6. Add labels to the PR as appropriate.

This template is based on the K8s/K8s template:

https://github.com/kubernetes/kubernetes/blob/master/.github/PULL_REQUEST_TEMPLATE.md -->

+24 -13

4 comments

9 changed files

skitt

pr closed time in 3 days

push eventskitt/admiral

Stephen Kitt

commit sha 4fcc9dbef1945b443590c3e0d46f0c45b23190bc

Enable gocritic hugeParam, fix issues This avoids copying large data structures. Signed-off-by: Stephen Kitt <skitt@redhat.com>

view details

push time in 3 days

Pull request review commentsubmariner-io/admiral

Enable gocritic hugeParam, fix issues

 func GetAuthorizedRestConfig(apiServer, apiServerToken, caData string, tls rest. 	return } -func BuildRestConfig(apiServer, apiServerToken, caData string, tls rest.TLSClientConfig) (*rest.Config, error) {+func BuildRestConfig(apiServer, apiServerToken, caData string, tls *rest.TLSClientConfig) (*rest.Config, error) {

This needs to check for nil.

skitt

comment created time in 3 days

PullRequestReviewEvent

push eventskitt/admiral

Stephen Kitt

commit sha 0f3e7a75961d6fdcb2f1fd816a9cc6296f0e18de

Enable gocritic hugeParam, fix issues This avoids copying large data structures. Signed-off-by: Stephen Kitt <skitt@redhat.com>

view details

push time in 3 days

PullRequestEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent