profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/skitt/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Stephen Kitt skitt Red Hat Lyon, France

dfarrell07/submariner 0

Connect all your Kubernetes clusters, no matter where they are in the world.

skitt/admiral 0

Admiral is the submariner API for integration with federation systems

skitt/AntennaPod 0

A podcast manager for Android

skitt/artwork 0

🎨CNCF-related logos and artwork

skitt/bstone 0

A source port of Blake Stone

skitt/Chipmunk2D 0

A fast and lightweight 2D game physics library.

skitt/clipboard-files 0

Cut, copy and paste files from the clipboard in a Linux terminal

skitt/cloud-prepare 0

Go library to prepare your cloud infrastructure via API for submariner to work on top

skitt/coastguard 0

Controller to facilitate network policing on a multi-cluster connected environments (proof-of-concept state)

PullRequestReviewEvent
PullRequestReviewEvent

push eventskitt/coastguard

snyk-bot

commit sha 7ddba365aada8ef369a5686194d3974c77305a75

fix: Dockerfile.dapper to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-UBUNTU1604-BASH-542609 - https://snyk.io/vuln/SNYK-UBUNTU1604-SYSTEMD-346739 - https://snyk.io/vuln/SNYK-UBUNTU1604-SYSTEMD-346739 - https://snyk.io/vuln/SNYK-UBUNTU1604-SYSTEMD-346739 - https://snyk.io/vuln/SNYK-UBUNTU1604-SYSTEMD-346739

view details

push time in 6 days

create barnchskitt/coastguard

branch : snyk-fix-beeede577aadb9d756e83552d2091ef6

created branch time in 6 days

pull request commentdosemu2/install-freedos

Bump Standards-Version to 4.1.5

But the main problem is that dosemu2 searches these scripts in a wrong libexec dir. So should the same be done in dosemu2? Also perhaps in install-otherdos too.

Ah! So perhaps the source of truth should be dosemu2 then ;-). If dosemu2 expects things in a certain directory, other packages should be able to query it for what that directory is...

skitt

comment created time in 9 days

delete branch skitt/install-freedos

delete branch : policy-4.1.5

delete time in 9 days

issue commentdosemu2/install-freedos

wrong libexecdir on ubuntu

OK, I see what you mean: that I need to set compat to 12 in dosemu2 and touch nothing in install-freedos, and then dh_auto_configure won't matter when talking about libexec (but my question was about all such paths, eg I don't like the hard-coded prefix too - I'd better get it from where dh_auto_configure gets it).

Debian isn’t Fedora (and yes, some aspects of RPM macros are nice, I’m not saying one is better than the other). It’s fine to have hard-coded paths in debian/rules etc., because the reference isn’t any build tool, it’s Policy. So we declare we comply with a certain version of Policy, using the Standards-Version field in debian/control; and that (Policy) is the source of truth.

Again, debhelper is only a helper, not a source of truth.

stsp

comment created time in 9 days

PR opened dosemu2/install-freedos

Bump Standards-Version to 4.1.5

The package installs files in /usr/libexec, which is allowed since Policy 4.1.5.

+1 -1

0 comment

1 changed file

pr created time in 9 days

create barnchskitt/install-freedos

branch : policy-4.1.5

created branch time in 9 days

PullRequestReviewEvent

pull request commentsubmariner-io/cloud-prepare

Remove project-specific gitlint configuration

This project doesn't have the dependent issues GHA.

Yup, see https://github.com/submariner-io/cloud-prepare/issues/68

skitt

comment created time in 9 days

Pull request review commentsubmariner-io/submariner

Fix OVN route-agent plugin IPtables handling

 func InsertUnique(ipt Interface, table, chain string, position int, ruleSpec []s  	return nil }++// UpdateChainRules ensures that the rules in the list are the ones in rules, without any preference for the order,+// any stale rules will be removed from the chain, and any missing rules will be added.+func UpdateChainRules(ipt Interface, table, chain string, rules [][]string) error {

This deserves a unit test ;-)

mangelajo

comment created time in 9 days

PullRequestReviewEvent
PullRequestReviewEvent

issue openedsubmariner-io/submariner-charts

The submariner-charts project isn’t configured for dependencies

The submariner-charts project doesn’t support “Depends on” etc. It would be nice to have this, as in other Submariner projects.

created time in 9 days

issue openedsubmariner-io/cloud-prepare

The cloud-prepare project isn’t configured for dependencies

The cloud-prepare project doesn’t support “Depends on” etc. It would be nice to have this, as in other Submariner projects.

created time in 9 days

PR closed submariner-io/submariner-operator

Reviewers
Allow long URLs in commit messages ready-to-test

This changes the gitlint configuration to allow long URLs in commit messages, as long as they are on their own line; for example https://kubernetes.io/docs/reference/using-api/deprecation-guide/#rbac-resources-v122 or http://kubernetes.io/docs/reference/using-api/deprecation-guide/#rbac-resources-v122

Signed-off-by: Stephen Kitt skitt@redhat.com

<!-- Thanks for sending a pull request! Here are some tips for you:

  1. If this is your first time, please read our developer guide: https://submariner.io/development/
  2. Ensure you have added the appropriate tests for your PR: https://submariner.io/development/code-review/#test-new-functionality
  3. Read the code review guide to ease the review process: https://submariner.io/development/code-review/
  4. If the PR is unfinished, mark it as a draft: https://submariner.io/development/code-review/#mark-work-in-progress-prs-as-drafts
  5. If you are using CI to debug, use your private fork: https://submariner.io/development/code-review/#use-private-forks-for-debugging-prs-by-running-ci
  6. Add labels to the PR as appropriate.

This template is based on the K8s/K8s template:

https://github.com/kubernetes/kubernetes/blob/master/.github/PULL_REQUEST_TEMPLATE.md -->

+4 -0

3 comments

1 changed file

skitt

pr closed time in 9 days

pull request commentsubmariner-io/submariner-operator

Allow long URLs in commit messages

Dropped in favour of https://github.com/submariner-io/submariner-operator/pull/1494

skitt

comment created time in 9 days

PR opened submariner-io/submariner-operator

Remove project-specific gitlint configuration

We now use Shipyard's gitlint configuration everywhere.

Depends on https://github.com/submariner-io/shipyard/pull/603 Signed-off-by: Stephen Kitt skitt@redhat.com

<!-- Thanks for sending a pull request! Here are some tips for you:

  1. If this is your first time, please read our developer guide: https://submariner.io/development/
  2. Ensure you have added the appropriate tests for your PR: https://submariner.io/development/code-review/#test-new-functionality
  3. Read the code review guide to ease the review process: https://submariner.io/development/code-review/
  4. If the PR is unfinished, mark it as a draft: https://submariner.io/development/code-review/#mark-work-in-progress-prs-as-drafts
  5. If you are using CI to debug, use your private fork: https://submariner.io/development/code-review/#use-private-forks-for-debugging-prs-by-running-ci
  6. Add labels to the PR as appropriate.

This template is based on the K8s/K8s template:

https://github.com/kubernetes/kubernetes/blob/master/.github/PULL_REQUEST_TEMPLATE.md -->

+0 -9

0 comment

1 changed file

pr created time in 9 days

create barnchskitt/submariner-operator

branch : remove-gitlint-config

created branch time in 9 days

PR opened submariner-io/submariner-charts

Remove project-specific gitlint configuration

We now use Shipyard's gitlint configuration everywhere.

Depends on https://github.com/submariner-io/shipyard/pull/603 Signed-off-by: Stephen Kitt skitt@redhat.com

<!-- Thanks for sending a pull request! Here are some tips for you:

  1. If this is your first time, please read our developer guide: https://submariner.io/development/
  2. Ensure you have added the appropriate tests for your PR: https://submariner.io/development/code-review/#test-new-functionality
  3. Read the code review guide to ease the review process: https://submariner.io/development/code-review/
  4. If the PR is unfinished, mark it as a draft: https://submariner.io/development/code-review/#mark-work-in-progress-prs-as-drafts
  5. If you are using CI to debug, use your private fork: https://submariner.io/development/code-review/#use-private-forks-for-debugging-prs-by-running-ci
  6. Add labels to the PR as appropriate.

This template is based on the K8s/K8s template:

https://github.com/kubernetes/kubernetes/blob/master/.github/PULL_REQUEST_TEMPLATE.md -->

+0 -9

0 comment

1 changed file

pr created time in 9 days

create barnchskitt/submariner-charts

branch : remove-gitlint-config

created branch time in 9 days

PR opened submariner-io/submariner

Remove project-specific gitlint configuration

We now use Shipyard's gitlint configuration everywhere.

Depends on https://github.com/submariner-io/shipyard/pull/603 Signed-off-by: Stephen Kitt skitt@redhat.com

<!-- Thanks for sending a pull request! Here are some tips for you:

  1. If this is your first time, please read our developer guide: https://submariner.io/development/
  2. Ensure you have added the appropriate tests for your PR: https://submariner.io/development/code-review/#test-new-functionality
  3. Read the code review guide to ease the review process: https://submariner.io/development/code-review/
  4. If the PR is unfinished, mark it as a draft: https://submariner.io/development/code-review/#mark-work-in-progress-prs-as-drafts
  5. If you are using CI to debug, use your private fork: https://submariner.io/development/code-review/#use-private-forks-for-debugging-prs-by-running-ci
  6. Add labels to the PR as appropriate.

This template is based on the K8s/K8s template:

https://github.com/kubernetes/kubernetes/blob/master/.github/PULL_REQUEST_TEMPLATE.md -->

+0 -9

0 comment

1 changed file

pr created time in 9 days

create barnchskitt/submariner

branch : remove-gitlint-config

created branch time in 9 days

PR opened submariner-io/lighthouse

Remove project-specific gitlint configuration

We now use Shipyard's gitlint configuration everywhere.

Depends on https://github.com/submariner-io/shipyard/pull/603 Signed-off-by: Stephen Kitt skitt@redhat.com

<!-- Thanks for sending a pull request! Here are some tips for you:

  1. If this is your first time, please read our developer guide: https://submariner.io/development/
  2. Ensure you have added the appropriate tests for your PR: https://submariner.io/development/code-review/#test-new-functionality
  3. Read the code review guide to ease the review process: https://submariner.io/development/code-review/
  4. If the PR is unfinished, mark it as a draft: https://submariner.io/development/code-review/#mark-work-in-progress-prs-as-drafts
  5. If you are using CI to debug, use your private fork: https://submariner.io/development/code-review/#use-private-forks-for-debugging-prs-by-running-ci
  6. Add labels to the PR as appropriate.

This template is based on the K8s/K8s template:

https://github.com/kubernetes/kubernetes/blob/master/.github/PULL_REQUEST_TEMPLATE.md -->

+0 -9

0 comment

1 changed file

pr created time in 9 days

create barnchskitt/lighthouse

branch : remove-gitlint-config

created branch time in 9 days

PR opened submariner-io/coastguard

Remove project-specific gitlint configuration

We now use Shipyard's gitlint configuration everywhere.

Depends on https://github.com/submariner-io/shipyard/pull/603 Signed-off-by: Stephen Kitt skitt@redhat.com

<!-- Thanks for sending a pull request! Here are some tips for you:

  1. If this is your first time, please read our developer guide: https://submariner.io/development/
  2. Ensure you have added the appropriate tests for your PR: https://submariner.io/development/code-review/#test-new-functionality
  3. Read the code review guide to ease the review process: https://submariner.io/development/code-review/
  4. If the PR is unfinished, mark it as a draft: https://submariner.io/development/code-review/#mark-work-in-progress-prs-as-drafts
  5. If you are using CI to debug, use your private fork: https://submariner.io/development/code-review/#use-private-forks-for-debugging-prs-by-running-ci
  6. Add labels to the PR as appropriate.

This template is based on the K8s/K8s template:

https://github.com/kubernetes/kubernetes/blob/master/.github/PULL_REQUEST_TEMPLATE.md -->

+0 -9

0 comment

1 changed file

pr created time in 9 days

create barnchskitt/coastguard

branch : remove-gitlint-config

created branch time in 9 days

PR opened submariner-io/cloud-prepare

Remove project-specific gitlint configuration

We now use Shipyard's gitlint configuration everywhere.

Depends on https://github.com/submariner-io/shipyard/pull/603 Signed-off-by: Stephen Kitt skitt@redhat.com

<!-- Thanks for sending a pull request! Here are some tips for you:

  1. If this is your first time, please read our developer guide: https://submariner.io/development/
  2. Ensure you have added the appropriate tests for your PR: https://submariner.io/development/code-review/#test-new-functionality
  3. Read the code review guide to ease the review process: https://submariner.io/development/code-review/
  4. If the PR is unfinished, mark it as a draft: https://submariner.io/development/code-review/#mark-work-in-progress-prs-as-drafts
  5. If you are using CI to debug, use your private fork: https://submariner.io/development/code-review/#use-private-forks-for-debugging-prs-by-running-ci
  6. Add labels to the PR as appropriate.

This template is based on the K8s/K8s template:

https://github.com/kubernetes/kubernetes/blob/master/.github/PULL_REQUEST_TEMPLATE.md -->

+0 -9

0 comment

1 changed file

pr created time in 9 days