profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/skeller1/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

skeller1/extr 6

Extr is a Rails 3.x and 4.x compatible version of Ext Direct Router with some additional features

meiser/vbscript 3

Collection for used vbscripts

meiser/denso 1

App for printing Bartender labels with mobile scanners

meiser/meiser-rails 1

Extracted functionality to work with Rails and Meiser ERP Baan

meiser/waage 1

C++ Programm zur Erfassung von Gewichten

meiser/zincify 1

Rails app for galvanization company

skeller1/fuss 1

get soccer results

meiser/intramei 0

Collection of useful programs

meiser/meiser-essen-client 0

Essenbestellung vom PC aus

meiser/meiserauth 0

Authentification for Rails and Active Directory

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

push eventskeller1/sale-workflow

Stephan Keller

commit sha eb811f42f10fb3422c69f6d7306eebb40a81a26f

[IMP] sale_order_type: add sale order type to sales and invoice analysis reports

view details

push time in a month

push eventskeller1/sale-workflow

Stephan Keller

commit sha 5daaf276ddc8b17fa98451a48c9bd35a22fe8fb8

[IMP] sale_order_type: add sale order type to sales and invoice analysis reports

view details

push time in a month

push eventskeller1/sale-workflow

Stephan Keller

commit sha ce1bbff0fbe6e3a33b5f467e6462541c7de064f0

[IMP] sale_order_type: add sale order type to sales and invoice analysis reports

view details

push time in a month

push eventskeller1/sale-workflow

Stephan Keller

commit sha 16169374d943bf0dd5116af9c906ecfb1223f205

[IMP] sale_order_type: add sale order type to sales and invoice analysis reports

view details

push time in 2 months

push eventskeller1/sale-workflow

Stephan Keller

commit sha 866ad6709aef7a79d763d6894ef14321b584e344

[IMP] sale_order_type: add sale order type to sales and invoice analysis reports

view details

push time in 2 months

push eventskeller1/sale-workflow

Stephan Keller

commit sha f474392f58417fd2d462858472650784843ed5b2

[IMP] sale_order_type: add sale order type to sales and invoice analysis reports

view details

push time in 2 months

PR opened OCA/sale-workflow

[14.0][IMP] sale_order_type: add sale order type to sales and invoice analysis reports
  • add sale order type field to account invoice and sale order report
  • add sale order type as group filter to account invoice report and sale order report view (pivot,graph)

grafik

grafik

+88 -0

0 comment

7 changed files

pr created time in 2 months

push eventskeller1/sale-workflow

Stephan Keller

commit sha f4162eb99d9252c9642c73bb6f571af3e04fd56b

[IMP] sale_order_type: add sale order type to sales and invoice analysis reports

view details

push time in 2 months

create barnchskeller1/sale-workflow

branch : 14.0-imp-sale_order_type_report

created branch time in 2 months

create barnchskeller1/sale-workflow

branch : 14.0

created branch time in 2 months

delete branch skeller1/project

delete branch : 13.0-imp-project_parent_task_filter

delete time in 2 months

PullRequestReviewEvent

PR opened odoo/odoo

14.0 imp website google maps message

Description of the issue/feature this PR addresses:

This commit remove the unclear message from the 'Contact Us' page, as it could only appear when the google map option is not enabled.

closes #73738

-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

+17 -7

0 comment

2 changed files

pr created time in 2 months

push eventskeller1/odoo

Stephan Keller

commit sha 7556ff52bee350260fc7edad4da2441000003d0d

[CLA] Signature for skeller1

view details

push time in 2 months

create barnchskeller1/odoo

branch : 14.0-imp-website-google-maps-message

created branch time in 2 months

push eventskeller1/odoo

Guillaume (guva)

commit sha 97e3115bce518cd9d98fe2454e341077077a79a8

[FIX] web : dark purple color doesn't work Step to reproduce - go to planning app - configuration > roles - set the color of a role to dark purple - schedule > by role The dark purple is not set, instead of that, #3daec3 is displayed. opw-2601898 closes odoo/odoo#74174 X-original-commit: ee38f8e393e937c5694e6b75cd05b8a35d4f1624 Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com> Signed-off-by: guva-odoo <guva-odoo@users.noreply.github.com>

view details

Odoo Translation Bot

commit sha d6cf58ae6fbb32c2d1dae1f308e430d4aa4488d5

[I18N] Update translation terms from Transifex

view details

Julien Banken

commit sha 602d0a580d6c8d0e48658b20315e4307964200bf

[FW][FIX] slides: prevent the # anchors of the PDF controllers from triggering a scroll jump PURPOSE Currently, the PDF viewer is loaded from an iframe and the PDF controllers contains empty anchor links. When the user clicks on one of these links, the browsers based on Chromium will trigger a "scroll jump" and the iframe will be placed at the top of the browser window. When the PDF document is larger than the viewport, this behavior can be quite annoying: The user will have to scroll the browser window to see the controllers each time they click on a controller (-> link) as (1) the controllers triggers a scroll jump and (2) the controllers are below the document that does not fit entirely on screen. To avoid that, we will add an event listener that returns false on each controller. The controllers will then no longer trigger a scroll jump. SPECS - Add an event listener on the PDF controllers links to prevent a scroll jump. LINKS Task id: 2500574 closes odoo/odoo#73943 X-original-commit: 912acb7329759ef63f8f457a65347f9e5e9f1cc6 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

view details

Julien Banken

commit sha 7e9949b9c1e2e98a4d5059de695dbed95751b8b5

[FW][FIX] slides: Do not show a traceback when the user provides an invalid video link PURPOSE: When the user creates a new content for a course and specify an invalid video link, the system will display a traceback when the 'onchange' hook of the field is triggered (i.e: when the user unfocus the field). Instead of displaying a traceback with the 'Warning' function, we will rather use the 'UserError' function which is more user-friendly and does not provide any debugging information. SPECS: - Replace the 'Warning' function call with 'UserError'. LINKS Task id: 2607238 closes odoo/odoo#73954 X-original-commit: 66dafc0bf750661145ee1ce821fd11b928844a7b Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

view details

Florent de Labarre

commit sha d5355037545fb8366675b792f8cc5ed30ecca1bf

[FW][FIX] survey: avoid retrospective computation - Create a survey with passing score at 80 point - Some user complete the quizz with 85 point, the quizz is "passed" - If you update the passing score at 90, the quizz completed by user are now "unpassed". This PR avoid to recompute quizz_passed. closes odoo/odoo#74116 X-original-commit: 7dde9adadf09bc0b23551fd384e5985c122849c1 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

view details

Xavier-Do

commit sha c9d3120689b6fbe9ac901076f219862217b5211d

[REM] codeowner: remove github codeowner Github codeowner is replaced with a runbot version of codeowners for multiple reason: - github codeowners is difficult to maintain, the precedence rule will sometimes remove teams from some file because of a more specific rule added by another team. - github codeowner does not support version specific rules, especially the "all except master" rule. For this use case teams needs to adapt the new codeowner when freezing a new version. - github will trigger codeowner on failed rebase, and add almost all teams as reviewer. Runbot has specific commit and file limit to avoid this problem. - runbot codeowner is centralised and does not need to be managed cross repo/version - runbot codeowner works for enterprise Any mofification on codeowner should be requested to runbot team. closes odoo/odoo#74127 X-original-commit: 305a42f5fc97bd6a438dd818756c64553de67bff Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>

view details

Adrien Widart

commit sha 8d362af654c1905535d78fbf8d73677633b65d63

[FIX] fleet: use services dates in report start date computation When adding some services to a vehicle that does not have any immatriculation date, the costs report does not consider these services. To reproduce the error: (DB without any demo data) 1. Create a vehicle V - Remove the Immatriculation Date 2. Add a service for V - The category of the service type does not matter - Cost > 0 - Date: today 3. Fleet > Reporting > Costs Error: Costs Analysis is empty, the service is not considered In the SQL view, the date used as start point is the oldest immatriculation date. Therefore, if the vehicle doesn't have this date, the report lines won't be generated. OPW-2477004

view details

Adrien Widart

commit sha 7ea6300f951bd426c94d721bb56e6ad85a58bd30

[FIX] fleet: always include current month in costs report When consulting the costs reports, if the beginning of the dates range has a day greater than the day of today (e.g., start date: 2021/02/25, today: 2021/07/10 => 25 > 10), the costs of the current month won't be include in the report. To reproduce the issue: (DB without any demo data. Let X be the day of the month for today) 1. Create a vehicle V 2. Add a service S1 for V - The category of the service type does not matter - Cost: 500 - Date: today 3. Add a second service S2 for V - Same service type - Cost: 250 - Date: Last month with a day > X (so if today is 2021/07/26, date could be 2021/06/27) 4. Fleet > Reporting > Costs Error: The report does not include S1 When generating the dates range, the current date is used as the end of the interval. Since the interval step is '1 month', it will lead to an issue in the above case: Suppose today is 2021/07/26, the interval starts on 2021/06/27. Then, if we add one month to this date, we have 2021/07/27, which is after the end of the interval (2021/07/26), so the date is ignored. As a result, current month won't be included in the report. Note: A similar issue can happen with the contracts OPW-2477004 closes odoo/odoo#74219 Signed-off-by: Kevin Baptiste <kba@odoo.com>

view details

Hardik Prajapati

commit sha a145e1242118d3e539790327221486e1bd94e59a

[FIX] web: resize list in form view overflows Currently, When the One2many list contains a large amount of fields and the user clicks or resizes the header, list takes table width as its initial width and because of this list to overflows outside of the form view. Issue raised after commit: d58edef12aab50fcd4494ba3b276e7d9d58d4d56 after this commit, clicking or resizing the list header does not impact the width of the list. TaskID-2388582 closes odoo/odoo#69024 Signed-off-by: Simon Genin (ges@odoo) <ges@odoo.com>

view details

Xavier-Do

commit sha 4f68396857b2c2467813204da0f5ac970de7c3bc

[FIX] *: add explicit license to all manifest The license is missing in most enterprise manifest so the decision was taken to make it explicit in all cases. When not defined, a warning will be triggered starting from 14.0 when falling back on the default LGPL-3. closes odoo/odoo#74231 Related: odoo/enterprise#19850 Related: odoo/design-themes#43 Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>

view details

Andrea Grazioso (agr-odoo)

commit sha d783ab83c5420e988ccd62691fc8a800978dcac8

[FIX] web: fix property assignment in pivot view Sales > Reporting > Sales Select the measure "Customer (count)" TypeError: Cannot add property group_operator, object is not extensible As the object is immutable we need to workaround the assignment. The previous fix 35967fabd54f596fa75fb2db7fbb1cfc5d7c8da9 will be moved in the `documents_spreadsheet` code opw-2606424 closes odoo/odoo#74211 Related: odoo/enterprise#19859 Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

view details

Swapnesh Shah

commit sha e8c5302e5cb11f185d1d5b1ef43ab641b2be6f76

[FIX] website: do not allow to create/edit views Before this commit, User was allowed to create new records from form view through Graph view' action. Since we do not have a way to prevent opening form view from Graph and also we should not Introduce new form view on stable version. With this commit, we are disabling create/edit/copy from action. closes odoo/odoo#70820 Signed-off-by: Romain Derie <rdeodoo@users.noreply.github.com>

view details

Anh Thao Pham (pta)

commit sha fb13be1bcdc0731d56eb1d1d22a05584ca7e3d68

[FIX] hr_timesheet: fix incorrect company on timesheet report - Create 2 companies (i.e. Company A & Company B) - Create user with access to both companies and default company set to Company B - Log with created user - Switch to Company A - Go to Project and create a new Project (i.e. Project X) - Go to Timesheets and add a line for Project X - Display all timesheets in list view - Select created timesheet and print "Timesheet Entries" Logo and address printed on timesheet report are from Company B. Company used for timesheet report is default company of current user. This fix will use company linked to the project if it is unique. Otherwise, it will use current company. opw-2502182 opw-2509463 closes odoo/odoo#74265 X-original-commit: 0812641544d49746d111ca4bb88a2091bf0dd6c8 Signed-off-by: LTU-Odoo <IT-Ideas@users.noreply.github.com>

view details

Ivan Yelizariev

commit sha ce487c920c777735e5e7e46ee131cb18dfc5c9fc

[FIX] product: speed up _get_possible_combinations Excluding non-active records decreases number of combinations generated in _cartesian_product. The excluded combinations have to be rejected anyway [1], so don't waste time on it. STEPS: * activate "Product Configurator" * create a product with many attributes * make some `product.template.attribute.value` inactive (ptav_active = False): ** create a sale order with that value (e.g. color "Black" in "Customizable Desk (CONFIG)") ** delete that value in `product.template` form (tab "Variants") * add the product to a sale order * RESULT: `_cartesian_product` doesn't generates combination with archived attribute [1] https://github.com/odoo/odoo/blob/f9d26509a714ecd290c42e1d58e416bb01268447/addons/product/models/product_template.py#L839-L841 --- opw-2540675 closes odoo/odoo#74119 Signed-off-by: Ivan Yelizariev // IEL <yelizariev@users.noreply.github.com>

view details

Laurent Smet

commit sha 49d1dbbb74ea97e4337fe1af3b8074dc9146143c

[FIX] account: Fix tag_ids when refunding an invoice with tax affecting base A tax line affecting the base of subsequent taxes is a line having some values in 'tax_ids' & 'tag_ids'. When creating a refund, tags was wrongly computed in this case. closes odoo/odoo#74223 Issue: 2596368 X-original-commit: 97ac9d1c8f6af3cfc43ca117b2b0359dd8233ad4 Signed-off-by: William André (wan) <wan@odoo.com> Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

view details

Achraf (abz)

commit sha 7fd4dea0af1917b82bc92d77c641672a8fc799f4

[FIX] account: Add layout to action send and print When sending the same invoice from Invoices > list view > select an invoice > action > Send and print, the email received by the client does not contain the header and the link to the invoice This PR adds the custom_layout attribute to the context of "Send & Print" action opw-2544654 closes odoo/odoo#74250 Signed-off-by: Josse Colpaert <jco@openerp.com>

view details

wan

commit sha 56f7afb253da6560cddae121f5b6cdab3e3b1c6e

[IMP] account: warn when the sequence format changed Explain the situation when a manual change has been done to the sequence of `account.move`. This was needed because some user didn't realize that they changed the sequence, and when they realized it, it had polluted multiple numbers after that. closes odoo/odoo#70941 Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

view details

Gorash

commit sha c29060c80e987edcfbeeaa7824540583de88f8ed

[FIX] web: avoid a scrollbar when a carousel is added in pages On Chrome, the browser displayed an horizontal scrollbar because the sr-only item inside the 'next' arrow was positioned absolutely, outside of the arrow, and thus outside of the window. This happened for the website carousel snippet when added in pages for instance. opw-2585526 closes odoo/odoo#74306 X-original-commit: 5bb454521f272fd2b4dd670eb2e9bf7173aa6b28 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

view details

Andrea Grazioso (agr-odoo)

commit sha ac9975d0eb50f39c6e42bc7a94761c4e34e92085

[FIX] mrp: fix recursive procurement handling in orderpoint Have 3 products: - Product A, manufactured from Product B, RR min 20 max 200 - Product B, manufactured from Product C, RR min 20 max 200 - Product C, stored, not manufactured, RR min 20 max 200 1. When triggering the scheduler, reordering rule are evaluated in batch, so procurements will be generated both for A and B. 2. The manufacture orders are created from procurement values: 2.A When manufacturing A, B is needed: the RR is triggered again and will evaluate again ALL the quantity needed for B (400, including the quantity already processed at step 1, but not yet written in a MO) 2.B Manufacture order for B is created from procurement values at step1, creating a MO for another 200 units We end up manufacturing 600 instead of 400 of Product B Fix by partially backporting bf5e1debf9c684c1bbf3ca440a87001fd7faf9fa along with a test opw-2509399 closes odoo/odoo#74314 Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

view details

Pierre Masereel

commit sha 7504dd34557968b0ecfea0d5d2b0025516d1dda5

[FIX] pos_restaurant: don't mark order as printed When the final receipt of an order is printed, the order is marked as printed, as it can be then removed, and nothing can be added to it anymore. When the Bill is printed, we should not mark it as printed, as there can be some modifications made after the bill is printed. So as the bill receipt is an inherited object from the final receipt, we have to change the behavior for the bill receipt to not mark the order as printed. OPW-2555272 closes odoo/odoo#74317 Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

view details

push time in 2 months

push eventskeller1/odoo

prro-odoo

commit sha 173cc43ca222a8a3e4eddb8c8a8c21782848dd7e

[FIX] sale_timesheet: fix amount computed for other_revenue How to reproduce the problem: - Install sale_timesheet. - Create 2 service products: one with "Create a task in sales order's project" (e.g. Product X), and the other with "Don't create task" (e.g. Product Y), in the Service Tracking field. Both with "Milestones" as Service Invoicing Policy. - Create a Sale Order with these 2 products (with e.g. quantity of 10 for both). Confirm the SO. - Edit the SO. Put 5 in the "Delivered" column of the Product Y. Create Invoice and confirm it. - Go to the Project app -> Overview (of the newly created project). - The "Other Revenues" is missing/not correctly filled Cause of the problem : the query to fetch the value would not take the invoiced Product Y into account, it should now work correctly. opw-2540624 closes odoo/odoo#74191 X-original-commit: 59b5667665124e8db51caa94039e33b5f718718d Signed-off-by: LTU-Odoo <IT-Ideas@users.noreply.github.com>

view details

Guillaume (guva)

commit sha b2f24c3ea06ba06ebfe6624db6334494f951b7b8

[FIX] web : dark purple color doesn't work Step to reproduce - go to planning app - configuration > roles - set the color of a role to dark purple - schedule > by role The dark purple is not set, instead of that, #3daec3 is displayed. opw-2601898 closes odoo/odoo#74185 X-original-commit: ee38f8e393e937c5694e6b75cd05b8a35d4f1624 Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com> Signed-off-by: guva-odoo <guva-odoo@users.noreply.github.com>

view details

Samuel Degueldre

commit sha 1eeab1e4184dd2634cb8e9c39442e3a422eae60e

[REF] web: remove legacy rainbowman The frontend code was still using the legacy RainbowMan, with the wowl webclient, we rewrote this RainbowMan and started using that one instead, but because the frontend code had no access to the wowl environment, the legacy version was still used in the frontend. Since the frontend now has access to the wowl environment, the old code can be removed and the calls can go through the new effect service. closes odoo/odoo#74148 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

view details

push time in 2 months

pull request commentOCA/project

[14.0][IMP] project_parent_task_filter: Activate subtasks on installation

@dreispt: Maybe you would like to merge these 2 Backport PR's for project_parent_task_filter for Odoo 12.0 and 13.0. This would be great. Thank you.

#750 #747

skeller1

comment created time in 2 months

push eventskeller1/odoo

Florent de Labarre

commit sha b3f67772dd029c0349302970315ece420f44340c

[FIX] crm_livechat : prevent lead without stage When you use /lead in the livechat the created lead have no user, no team and no stage_id. closes odoo/odoo#72883 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

view details

Goffin Simon

commit sha 2da20136988afaa93f472da4726091452c61cd37

[FIX] point_of_sale: Language not in en_US When the user is not in en_US language, unit_name is always different of Unit opw:2581462 closes odoo/odoo#73075 Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

view details

Daniel Blanco

commit sha 2b500c12c2540e593f3a243bf80de28bd335b7be

[FIX] l10n_cl: modifications to report invoice to show tax included in boletas [ADD] l10n_cl: add method to invoice report to format the vat dotted closes odoo/odoo#72231 Related: odoo/enterprise#18432 Signed-off-by: Josse Colpaert <jco@openerp.com>

view details

Adrien Widart

commit sha f5b23781cdf8a9e50c9a1fcd38ec704d4a4513fb

[FIX] point_of_sale: extract UID from POS reference When using another language than English, the UID of a POS order may be incorrect To reproduce the error: 1. Open a POS's configuration and enable "Manage Orders" 2. In Settings > Languages, add ans switch to: - French (BE) / Français (BE) 3. Start a POS session 4. Process an order 5. Open the orders managers Error: the processed order is named "Commande de 00001-001-0001", the "de" in the middle shouldn't be present This is the combination of "Commande" and the UID of the order. The latter is extract from the POS reference, which looks like "Commande 00001-001-0001" by removing the first 6 characters. It's ok in English: from "Order 00001-001-0001", we have "00001-001-0001". But this won't work in all other languages (specially for RTL languages) The unique identifier of an order is a sequence of 12 digits: https://github.com/odoo/odoo/blob/3e8d921318e86631b73c8c92c2e462fd0d761582/addons/point_of_sale/static/src/js/models.js#L2865-L2868 Knowing this, we can easily extract the UID from a POS reference OPW-2538645 closes #71181 closes #71182 closes odoo/odoo#73777 Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

view details

Ajroo

commit sha 9f411818ff5700042bb739d7751fa6bcd8e5bef9

[CLA] Sign CLA Ajroo - Kasper Declercq closes odoo/odoo#73788 X-original-commit: 092c92631071aaf207e1756d258d2021fab0a0c8 Signed-off-by: Olivier Dony (odo) <odo@openerp.com>

view details

Amin Cheloh

commit sha 66bf02ba89ebc5b6d3f07e6716d060794cf62b6b

[CLA] Signature for amincheloh closes odoo/odoo#71767 Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

view details

Mashanz

commit sha e8ef346d574a5f2e0525282d96d39390e13115dc

[CLA] Signature for mashanz

view details

Mashanz

commit sha 454c42612f6370fa029b0e917f0bd920f967fdce

[FIX] base: typo on class label closes odoo/odoo#72671 Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

view details

kerteszgergo

commit sha 0a11e597d933e5b159c18752ef1b6a040dc23256

[CLA] signature for kerteszgergo closes odoo/odoo#73330 Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

view details

Benjamin Frantzen (bfr)

commit sha 86aa7507b0d86bd13dba303c75821048d420f647

[FIX] l10n_it_edi: fixed zip code check for the buyer If the buyer is Italian, it must have a zip code of length 5. If the buyer is not Italian, the zip code is optional closes odoo/odoo#73817 Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

view details

Alvaro Fuentes

commit sha 728a6f753656246ae48219c08d32f679a1567009

[FIX] web: fix web_read_group total groups count Fetching all the groups from the DB causes MemoryError on some DBs Example Accounting > Accounting > Journals > Miscellaneous menu: ``` Traceback (most recent call last): File "/tmp/tmpbnah9jtp/migrations/base/tests/test_mock_crawl.py", line 176, in crawl_menu self.mock_action(action_vals) File "/tmp/tmpbnah9jtp/migrations/base/tests/test_mock_crawl.py", line 267, in mock_action mock_method(model, view, fields_list, domain, group_by) File "/tmp/tmpbnah9jtp/migrations/base/tests/test_mock_crawl.py", line 380, in mock_view_tree self.mock_web_read_group(model, view, domain, group_by, fields_list, limit_group=5) File "/tmp/tmpbnah9jtp/migrations/base/tests/test_mock_crawl.py", line 425, in mock_web_read_group data = model.web_read_group(domain, fields_list, group_by, limit=limit)["groups"] File "/home/odoo/src/odoo/14.0/addons/web/models/models.py", line 96, in web_read_group all_groups = self.read_group(domain, ['display_name'], groupby, lazy=True) File "/home/odoo/src/odoo/14.0/odoo/models.py", line 2248, in read_group result = self._read_group_raw(domain, fields, groupby, offset=offset, limit=limit, orderby=orderby, lazy=lazy) File "/home/odoo/src/odoo/14.0/odoo/models.py", line 2387, in _read_group_raw result = [self._read_group_format_result(d, annotated_groupbys, groupby, domain) for d in data] File "/home/odoo/src/odoo/14.0/odoo/models.py", line 2387, in <listcomp> result = [self._read_group_format_result(d, annotated_groupbys, groupby, domain) for d in data] MemoryError ``` This issue was observed during the upgrade requests upg-18830, target 14.0; and upg-61934 (legacy), target 13.0 The issue can be reproduced on a clean DB with just account_accountant installed and ~2 millions account moves on a Misc journal. closes odoo/odoo#73823 X-original-commit: a9b3d9cf9bfd2bf4c9b0904059f1606ad6e04ee4 Signed-off-by: Christophe Simonis <chs@odoo.com>

view details

Florent de Labarre

commit sha 7a92eade1dd1871c6bf5dc90a117ab011e9cac87

[FIX] point_of_sale : show correctly UserError Before this commit UserError, ValidationError are not correctly show. Get the same behaviour of V12. closes odoo/odoo#73649 Signed-off-by: pimodoo <pimodoo@users.noreply.github.com> Co-authored-by: Joseph Caburnay (jcb) <caburnay.joseph@gmail.com>

view details

Florent de Labarre

commit sha 08583840604e71f18f3b98b6dc8d4fa04f502689

[FIX] point_of_sale : ticket is save in DB If you use electronic terminal, electronic ticket is not save in database. I you want reprint the ticket, electronic ticket is not present in the reprint ticket. closes odoo/odoo#72777 Signed-off-by: agr-odoo <agr-odoo@users.noreply.github.com>

view details

Andrea Grazioso (agr-odoo)

commit sha 7ab0ac3e56949e5015bb2dcfd2af34b56dee92c8

[FIX] mrp: merge SFP for 2 different MO Set the warehouse with manufacturing 3 steps Create a BoM with a Components that use a Sub BoM Set Both product MTO + Manufacture Create a MO You have only 2 picking for the first MO with the SFP that contains both the finished product and the intermediate component. However they are created and moved at two different times since you could not create the finished product withtout the component, so there is no meaning to put them both in the same picking. It happens because the _assign_picking will merge moves with the same procurement group. In our case, it's the wanted behavior to have the 2 differents SFP linked to the same MO. The idea between the fix is: - We want to have the pick components picking merged. - We want to have the store components split since they come from different MO So we create the different procurement groups during the _run_pull with the picking type of store finished product. This way the pickings won't be merged during _assign_picking We will also propagate those groups to the newly created MO in order to keep the picking type sequence and correct name. FW PORT of https://github.com/odoo/odoo/commit/bcfa03821b92bf52675db0e3b54d3cb19dfe3087 opw-2585525 closes odoo/odoo#73248 Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

view details

Matthieu Méquignon

commit sha f0f60413cf34950a0274145f92f15458b7c54272

[CLA] Add Matthieu Mequignon to C2C CLA closes odoo/odoo#73842 X-original-commit: bc916ec3f27a9ea2275e80402bd6aa17bf5a1bf9 Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

view details

Florent de Labarre

commit sha e4ee7018ba549530ebddc98c36d7bc06d43feafa

[FIX] point_of_sale : translate error messages closes odoo/odoo#72762 Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

view details

prro-odoo

commit sha 41828bc22b5cf663b96196371f412ad2bfbbfb22

[FIX] fleet: display only current companies' fleet How to reproduce the problem: - Install the Fleet app. - Create a user that has access to 2 or more companies (e.g. Mitchell Admin). - Log in as this user. Go to fleet -> Vehicles -> Vehicles Costs/Contracts/Fuel Logs/Services Logs - Uncheck one of your companies. - The user still has access to the fleet of the other companies, even if they are unchecked. Cause of the problem : missing record rules Solution : added multi-companies rules opw-2518188 closes odoo/odoo#73654 X-original-commit: ad62f877c174d56b90ec516cf24494d751383db9 Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com> Signed-off-by: prro-odoo <proose@users.noreply.github.com>

view details

Robin Conjour

commit sha 229f14c04d53e713af30a4a1077c954d284ff51d

[CLA] signature for demolium Closes odoo/odoo#69217 closes odoo/odoo#73829 Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

view details

Odoo Translation Bot

commit sha 3007fb8dd177afcf2fba584c187177be7e21704d

[I18N] Update translation terms from Transifex

view details

Xavier Morel

commit sha 5d1674f33bc6ea4dd378f7e68e9aabb369ce3b8c

[IMP] core: mitigate possible deadlock on module installation When installing some modules, if an other action is undertaken around the same time it is possible for the two to deadlock, leading to the two workers being killed by the wallclock limit watcher. This should only be an issue on the *threaded* server, workers should not be affected, meaning the issue is not reproducible on runbot. A relatively reliable way to trigger this issue manually is to create an empty database, on the "apps" kanban view install the "sales" application, and as soon as the UI gets unblocked install the "CRM" application. An other method (also reliable but not really doable by hand) is to simultanously log in and install the sales application (`sale_management` module). The core of the issue seems to be in `_button_immediate_function`: 1. `Other` has an env ready for use and has accessed various models (so has pretty shallow locks on the tables e.g. ACCESS SHARE). 2. `Install` takes the registry lock to create the new registry. 3. `Install` needs to update one of the tables `other` has touched, starts waiting on the `ACCESS EXCLUSIVE` lock (the only one `ACCESS SHARE` conflicts with) in order to execute DDL (most `ALTER TABLE` forms require exclusive access to the table). 4. `Other` needs a new environment (e.g. `sudo()`, `with_user`, `with_context`, ...), starts waiting on the registry lock. At this point the two threads are deadlocked, `other` waits on the registry lock which `install` holds, while `install` waits on a table lock which `other` holds. Since one of the waits is on the application side, Postgres' deadlock detector can not notice the issue. That one of the locks is on the Python side is why only the threaded server *should* be affected. An initial seemingly promising mitigation attempt was to LOCK res_partner IN ACCESS EXCLUSIVE MODE in the prelude of `_button_immediate_function` as `res.partner` is one of the most commonly modified models, this would force `_button_immediate_function` to wait until all existing requests have completed and prevent later requests from progressing. This turns out to be unreliable, as later requests could already have acquired an environment and would race ahead as soon as the transaction is committed if the scheduler lets them. Trying to lock the registries earlier doesn't work as the locking is interleaved in normal operation and we'd just deadlock there. The commit is because `load_modules` does not take an externally provided cursor and instead creates its own (thus its own connection and transaction). And because of its lack of atomicity the issue might occur regardless. An alternate mitigation is instead to set (or drastically reduce) the lock wait delay during module installation, installation should normally be entirely uncontended (or infeasible in production with large traffic) so there is limited reason it'd be waiting several seconds on a lock. Conveniently, this means instead of the thread being killed entirely, the install request gets aborted *and retried*, so it can succeed a little more slowly if that allows the other request to complete and no other concurrent request causes the same issue. Other alternate mitigation which got discarded: reusing registries when creating new environments (from existing ones) if the database is the same, that works for some case of switching environments, it doesn't work for other where we actually fetch a registry e.g. assets generation calls `get_modules_order` which calls `module_boot` which calls `module_installed_bypass_session` which gets a registry. `get_modules_order` is the last place we know we have an existing registry. Though maybe we could strip out the entire thing and call `module_installed(self.env)` directly? Issue 2581648 closes odoo/odoo#73866 X-original-commit: ab84d970dcf1a9dbd5697b6600930cd1bcba3634 Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

view details

push time in 2 months

push eventskeller1/odoo

Samuel Degueldre

commit sha d368be985c151a20ec54a1e50b3f6475d972671e

[REF] web: make RPCErrorDialog inherit from ErrorDialog For some reason, the RPCErrorDialog reimplements all the behaviour of the ErrorDialog instead of inheriting from it. Part of #72675

view details

Samuel Degueldre

commit sha 13e0808b1fe77e3db7e757648d33337405174e87

[REF] web, website: convert some legacy odoo modules to ES modules This is in preparation for work on these modules Part of #72675

view details

Samuel Degueldre

commit sha f9cc4281b6a080a67cf81cfedf08862e84619441

[REF] web, website: convert public widget registry to core registry With the introduction of the new webclient, we introduced a new way to create and interact with registry using categories. This alleviates the need to explicitly export and import registries. This commit converts the public root widget's custom registry to use the new registry to avoid code duplication and having multiple diverging implementations Part of #72675

view details

Samuel Degueldre

commit sha 838a1daef3e7a8f563d9bb009981453971c72c4f

[REF] web: factor out MainComponentsContainer for use in frontend

view details

Samuel Degueldre

commit sha db7b485d984e50fae5a52308634166460e5fc908

[REF] web, website, *: make wowl services available in frontend *: http_routing When rewriting the webclient, a new environment was created, as well as a new type of service and a new mechanism to start those services. This environment and the services that go with it were not made available in the frontend however. This commit adapts the setup code for the frontend's root widget (and the website specific equivalent, WebsiteRoot) so that the new environment exists, and some of the calls to the legacy services are redirected to the new services. The point is to allow removing some legacy services whose code is currently only needed by the frontent because of the lack of availability of this new env and services Part of #72675

view details

Samuel Degueldre

commit sha 08afc0af8f8a9e562b6fc7b2ddb3c329be1bf7bb

[REF] *: remove use of legacy notifications from tests When writing the new webclient, the notification service was rewritten, and all of its uses in production code were changed to use the new services, however, some tests were still reliant on the old notification service. This commit removes references to the legacy notification service so that we can be one step closer to removing it from the code base. Part of #72675

view details

Samuel Degueldre

commit sha 95504aa0e1556be391754caa85267a8e164dc7ee

[REF] web: remove legacy notification service In previous commits, all references to the legacy notifications and notification service have been removed, this commit removes the now unused legacy notification and notification service Part of #72675

view details

Samuel Degueldre

commit sha 57ba855b66f2ff1d393f639bbc18dd444e2afa8f

[REF] web, website, website_forum, *: remove crash manager from frontend *: test_website In a previous commit, the new services and environment were made available in the frontend. This now allows errors to be handled by the new error service, and makes the legacy crash manager redundant. This commit removes it. Part of #72675 Related: odoo/enterprise#19258 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

view details

Mathieu Duckerts-Antoine

commit sha 5225b75a934743053f0672d4d1cdf010890dfeee

[IMP] web: search view for "Schedule activity" dialog Before this commit, click on "Schedule activity" in the activity view would open a dialog in which the search view is the default one on the current activity view model. With this commit, we make the dialog use the same search view as the activity view. Done to help with the task 2502339 closes odoo/odoo#73697 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

view details

Samuel Degueldre

commit sha 61dd61b6eb0e17fa4e709b4db9fd6aef340c015d

[FIX] web: avoid pushing state when ActionAdapter is in dialog Previously, push_state events triggered from withing window actions inside dialogs would bubble push their state into the URL even while within a dialog, this is undesirable as this can cause the URL to become invalid (eg by pushing the id of a record from an entirely different model) This commit fixes that by simply checking whether we are in a dialog within the adapter before calling pushState. task-2602458 closes odoo/odoo#73720 Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>

view details

Arnold Moyaux

commit sha ae0012ef3ee0c7fe2df5b1516d362c738c232e71

[FIX] stock: replenish report in 3 months Currently the replenishment report look for forecasted quantity of product today. It means that for a product if the delivery is planned for today the forecast will be -1, at j-1 it will be 0. However for the majority of use case, products take days to order and arrive. Example: - Product A, purchase delivery time 5 days. - You are the 01-01-2021 and create a SO for 10-01-2021 Currently: - Product will appear in the replenishment report the 10-01-2021 and you will receive it the 15-01-2021. So you are late to deliver your customer. Desired behavior: - Product appear in the replenishment report the 05-01-2021 and if you order it directly you will receive it the 10-01-2021. If you want to have more time to deliver than one day, security lead time are there for it. However the usecase like: Product arrive in 2 months and you receive it in 3 days, the product won't appear in the replenish report anymore since the forecast in 3months is 0 It could happens that more product are missing in 3 months than today, so the system could have more delivery lead times and forecast at date to compute -> be slower. In that case a parameter could be added to skip the delivery times computation for each product/warehouse and just display the forecast in 3 months and let user compute their schedule themself. closes odoo/odoo#73737 X-original-commit: f988b7629f8f54e8e3f48bf76e6af9d97b4f47da Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

view details

Touati Djamel (otd)

commit sha deb7b0dfc2afb3c72ef9c34bb27e4bd7d8fa5b25

[FIX] l10n_pe: add zip to Peru address format Steps to reproduce the bug: - Install eCommerce and l10n_pe - Go as website visitor - Add anything to your cart - Continue with checkout to go to the address page - Select country Peru and fill in all the required fields - Validate - You will get an error message telling you that you forgot to fill in a required field. Problem: You cannot validate the address because zip code is not displayed, but required. This field is based on the country format address to be displayed before or after the `" City "` field and is not displayed if `" zip "` is not present in the country format address. https://github.com/odoo/odoo/blob/b1107cba38e296f17d03d9919be67e6789a407be/addons/website_sale/views/templates.xml#L1208-L1223 https://github.com/odoo/odoo/blob/15fe3d43b4b925a32b42eb46048a33987e10336b/openerp/addons/base/res/res_country.py#L77 Solution: "zip" is required for the Peru country, so it must be added in the address format opw-2600526 closes odoo/odoo#73763 X-original-commit: 996260c04a52055a7000ede7be87460707f3990f Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com> Signed-off-by: Djamel Touati <DjamelTouati@users.noreply.github.com>

view details

Kamen Zhekov

commit sha 22a76c230bb22dfa42333b544f69cc72d8921a31

[IMP] website: clarify drag&drop zones for website edit mode When using drag&drop for adding elements to a product's page through the website edit mode, users sometimes find the feature confusing to use. Two examples of said confusion can be seen here: - https://dashboard.userbrain.net/shared/qwl65bqlk6jg?t=404 - https://dashboard.userbrain.net/shared/k796mnj95pow?t=258 The suggestion for improvement was to reduce height and opacity for the top and bottom droppable zones (available on all products), and make any element not explicitly dropped in those zones go to the zone below the product, available only on the product's own page. This behaviour is extended to be more generic and is applied when a dropzone has the class oe_structure_not_nearest, which excludes it from the nearest search, unless the element is dropped explicitly in a zone that has the class oe_structure_not_nearest. task-2581641 closes odoo/odoo#73580 Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

view details

Laurent Smet

commit sha e2fdac55f6a66b733f4966d5f8a1d2f2f4fd8796

[FIX] payment: Fix payment access rights for not admin users The journal needs to access the payment acquirers to determine with payment method is still available. Since the acquirers can't be accessed only for admin users, an accountant doesn't any right to read them, and then, an access error was raised when opening the journal form view. Also, the 'payment.acquirer' was accessed from the 'account' module instead of being overridden in 'payment'. closes odoo/odoo#73761 X-original-commit: 7b4580c3756657c902eceb9840984dde76429dcd Signed-off-by: William André (wan) <wan@odoo.com> Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

view details

Jeremy Kersten

commit sha 4d3b29c7b7f41aaa1d297a1f3147f41373a8cf10

[IMP] web, product: reintroduce _get_placeholder_filename on model Re-introduce after discussion with AL the function that allow to specify a custom placeholder for a specific model. It has been removed because no more used since we use avatar mixin for res.users and res.company. But it doesn't means that each model should add his own mixin and controller and ... Keep it simple! Use it for product and product template to have a default placeholder more representative of the model. Courtesy of xlu-odoo for this design opw-2513801 closes odoo/odoo#73576 Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

view details

Jeremy Kersten

commit sha 3dd891ed6e61ae288602c1e9309e8726e20b8bd3

[FIX] http, web: support type URL as location Despite that Werkzeug documentation specify: 'location (str) – the location the response should redirect to.' Werkzeug support URL as location. So now Odoo will support URL for request.redirect as argument too. This commit closes #73729

view details

Jeremy Kersten

commit sha b290bceada5a90ec203803412b3681bf254a101f

[FIX] http_routing: is_frontend can be unset on request AttributeError: 'HttpRequest' object has no attribute 'is_frontend' e.g.: when we call request.redirect in ensure_db(), before that the _dispatch method check if it is a is_frontend route or not. closes odoo/odoo#73759 Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

view details

Jérôme Vanhaudenard

commit sha f63fed5caf40e0fbc3bd7c008a046b0c12bbb1e2

[FIX] point_of_sale: Don't reconcile already reconciled lines At the closing of the POS, we try to reconcile all lines involved in the closing. If for any reason, a line is already reconciled (I.E. Debit=0 and Credit=0 is considered as reconciled), the closing fails because we cannot reconcile an already reconciled line. OPW-2602410 closes odoo/odoo#73783 X-original-commit: 4fd374b3f97eee1e706842ce1e28d0ad7a50315a Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>

view details

Jigar Vaghela

commit sha 18a823e379ba023c176299c4034b3b28d09c2336

[FIX] l10n_in: HSN report not have right quantity and UOM This is already there before refactoring in saas-12.4 you can check here https://github.com/odoo/odoo/blob/saas-12.3/addons/l10n_in/models/account_invoice.py\#L73 also add id in group by becouse if there is invoice line have same product,qty and uom then qty is wrong. For example: we have there is the same product with the same quantity and UOM like ``` Product | quantity | UOM ========================= Mobile | 2 | Unit Mobile | 2 | Unit ``` then tax line is not split so report count qty is 2 opw-2563120 closes odoo/odoo#73803 X-original-commit: 49e6bc9c499a511d479282dc67c1560e1c6bae5b Signed-off-by: Josse Colpaert <jco@openerp.com> Signed-off-by: Jigar Vaghela <jva-odoo@users.noreply.github.com>

view details

Anh Thao Pham (pta)

commit sha 23ebf96cb6ca3dfc65cbed00cf3eb32a127ad7fe

[FIX] account: fix account resequence for "other" lines Linked to commit https://github.com/odoo/odoo/commit/3e6b7dfd4854069724dde2df43ab2eb7d850e9b5 Resequence wizard will not show if "other" lines are generated to reduce the set to display in preview, because those lines don't have "id" to be used as t-key in the resequence template. opw-2590273 opw-2581306 closes odoo/odoo#73811 X-original-commit: 70baff1aac1ab39c4e27f8078d404e8fdfa325db Signed-off-by: William André (wan) <wan@odoo.com> Signed-off-by: Anh Thao PHAM <kitan191@users.noreply.github.com>

view details

push time in 2 months

push eventskeller1/odoo

Géry Debongnie

commit sha d9834e65ee57511f4850fa2d74287eb0b67087b9

[FIX] web: properly apply onchange in some cases A previous commit (8dbd1efef899fb637acca3c318ae99cb23838b8f) fixed a part of the basicmodel that used _.each to iterate on an object with field names as keys, which does not work when a field is named "length". To fix it, I simply used a native for ... in statement. However, I missed the fact that there was a second 'return' statement in the body of the closure given to _.each, so the onchange method returned prematurely. The fix is to simply use the continue statement in that case. closes odoo/odoo#67228 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

view details

Goffin Simon

commit sha 7144321c3fd13f83241ae7e4be71a9a4d576a871

[FIX] account_fleet: Field vehicle_id unavailable on vendor refund The fleet vehicle_id must be visible on vendor refund opw:2471784 closes odoo/odoo#67130 Signed-off-by: William André (wan) <wan@odoo.com>

view details

Benjamin Vray

commit sha 0bbae314ede2d7112a32954f06a8d541932caac9

[FIX] website: fix showcase snippet images stretched Before this commit, if we replaced an icon of the showcase snippet with an image, this image was streched depending on title size (if too long and on 2 lines). Its because the align-self default value of a flex item is strech. task-2447087 closes odoo/odoo#67234 Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

view details

Nicolas Lempereur

commit sha f8e4e98d9fba2d399efa4ca48f8d15d620fec9c7

[FIX] l10n_id_efaktur: filter invoice lines on display_type (bis) Missing line in 24c32607 forward-port (only for 14.0). opw-2451571 closes odoo/odoo#67240 Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

view details

Carlos Roca

commit sha e5697dcfa7def73bd55ec908a165bec56229c284

[CLA] update Tecnativa signature closes odoo/odoo#67237 X-original-commit: 42291b957ba4f33640c99097be73f16aa9e06d47 Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

view details

Christophe Monniez

commit sha 54b6a7a97e574249c22f16ea2756989e4bd4fac3

[FIX] packaging: remove dead code that prevent rpm build Since 9c2ce1f12c2, more files are included in packaging. The rpm build failed because shebang lines of packaged files must not use `/usr/bin/env` [0] [1] [2]. As it seems that those old files are not of any use anymore, this commit removes them. [0] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shebang_lines [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#Multiple_Python_Runtimes [2] https://pagure.io/packaging-committee/issue/738 closes odoo/odoo#67258 X-original-commit: d2a6ed1b2709eb0f1ea8a38818bd669e6d990cd8 Signed-off-by: Raphael Collet (rco) <rco@openerp.com> Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

view details

nie

commit sha 46de40dc54d04139b2319b342a7f0c7cb9318e84

[FIX] payment: link transaction to invoice with payment link Steps: - Install account,payment - Go to Invoicing - Create an invoice - Click Actions > Generate a Payment Link - Follow the generated link - Pay Bug: The transaction is not linked to the sale order in the link table `account_invoice_transaction_rel` Explanation: This fix is broadly mimicking the behavior of the sales module regarding the link of an order to a transaction, adding `invoice_id`s where they are needed throughout the payment process in order to link the transaction to the invoice. opw:2451534 closes odoo/odoo#67289 X-original-commit: 7c6d06fa5858f79f3b22cdeaf74cdc26a642742f Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com> Signed-off-by: backspac <backspac@users.noreply.github.com>

view details

Benjamin Vray

commit sha ea72517730dfcfc5d6eefeef0195e61468b66b57

[FIX] website: state not saved for accordion snippet Before this commit, the states (collapsed/not collapsed) of the tabs of the accordion snippet were not saved if it was the only changement in edit mode. After this commit, we trigger a content change when the states of the tabs is changed. task-2442237 closes odoo/odoo#67252 X-original-commit: 18af2ecade9482b5243059aefbfa79410ebf59a6 Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

view details

Jeremy Kersten

commit sha f344c4aea642a902ee244390621a35d7b649d923

[FIX] website_sale: we don't support rounding uom in ecommerce We only support int, following #c9edca7896e3096289936f5399a82f08a59b60ce opw-2456796 closes odoo/odoo#67279 X-original-commit: a05a34366f6dc8c70b39c15c3441beaf6bbb72d2 Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

view details

Benoit Socias

commit sha 439a7568b5b1e7d0aa53c63c7332dd22e3d6fc04

[FIX] website: remove save snippet button for cookie bar Before this commit the save snippet button appeared for the cookie bar. But this makes no sense because the cookie bar is implicitly saved. After this commit the save snippet button is not available for the cookie bar. task-2464233 https://github.com/odoo/odoo/pull/67217

view details

Benoit Socias

commit sha 2f920e0023d29545d2957e5d6ca1619068af893b

[FIX] website: avoid duplication of cookie policy page Before this commit a cookie policy page was created every time the website settings were saved with the "Cookies Bar" option enabled. After this commit the policy page is created only if it does not already exist for the website. task-2454424 https://github.com/odoo/odoo/pull/67217 closes odoo/odoo#67217 Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

view details

Jorge Pinna Puissant

commit sha 9f03a4ef1ed2076f38ff50de61074301a277d7ef

[FIX] sale_coupon: fiscal position for promotion product line create a SO; Add a fiscal position; Add a promotion of fixed amount kind. Before this commit, the taxes of the promotion are the one of the promotion product and not the one of the fiscal position. Now, the taxes will be computed taken into account the fiscal position. opw-2467966 closes odoo/odoo#67306 X-original-commit: 16dab7df5bb966219fa8798b77743149ad129572 Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>

view details

Jeremy Kersten

commit sha 19ef4f1b318b979bf2c6e89ad9962a50e6684dc9

[FIX] website: typo in drop snippet tour task-2466754 closes odoo/odoo#67317 Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

view details

xO-Tx

commit sha 1d483ab5e2f9bba0fd86c6fe4595a9959b2f125d

[FIX] web_editor: fix parent element selection When a block is removed, the parent will be activated. If the parent element is empty and removable: 1) It will be removed too. 2) In '_activateSnippet' method, we look for the right element to be selected using the block's parent (removed from the DOM...). The goal of this commit is to fix this behaviour by computing the selected element before parent removal. task-2431506 closes odoo/odoo#65428 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

view details

Djamel (otd)

commit sha 3f54c1c7556c5d06759bf5ec74dd83872f0d24d2

[FIX] base: fix the customer search by vat number Steps to follow to reproduce the bug: -Go to sales -Add a vat number with a '-' like: "123456789-5" to any customer -Create a new SO -Search the customer by entering their VAT number Problem : When the VAT number contains the character '-' you cannot find the customer with his VAT number. The problem is the same if the vat number contains a '.' Because, the "_name_search" method before creating the query to search clients by VAT number, removes all the special characters from user input Solution : Do not remove the characters '-' and '.' from the user input for the customer search by vat number. opw-2457692 closes odoo/odoo#67277 Signed-off-by: Anh Thao PHAM <kitan191@users.noreply.github.com>

view details

Adrien Widart

commit sha b810e5ff72b892983c52b24ca7efe5025c8a7142

[FIX] mrp: generate all stock picking If the company uses multi-step routes, when duplicating a MO, if the user changes the BoM, one stock picking will be missing. To reproduce the error: 1. In Settings, enable "Multi-Step Routes" 2. Go to Inventory > Configuration > Warehouse Management > Warehouses 3. Edit the warehouse "YourCompany" 4. Set Manufacture to "Pick components, [...] products (3 steps)" 5. Create a storable product SP 6. Create two non-empty BoM (BoM01 and BoM02) for SP - (Hint: set a different reference for each BoM) 7. Create a MO - Product: SP - BoM: BoM01 8. Save, Mark as Todo - (As you can see, 2 transfers have been created: one from WH/Stock to WH/Pre-Production, and a second one from from WH/Post-Production to WH/Stock) 9. Duplicate the MO 10. Set BoM to BoM02 11. Save, Mark as Todo Error: Only one transfer has been generated. The transfer from WH/Stock to WH/Pre-Production is missing. (The duplication step is used to compare the result. If the user saves a new MO, and then edits this MO to change the BoM, the same problem will occur). When confirming the MO, the module runs both pull and push rules. When running the pull rule, the modules assigns a stock picking to a stock move. To do so, it checks if one stock picking already exists: https://github.com/odoo/odoo/blob/7d9264c56ac725c8d19aebad55d5668df2a8c814/addons/stock/models/stock_move.py#L863-L873 Since such a stock picking does not exist, the module creates a new one: https://github.com/odoo/odoo/blob/7d9264c56ac725c8d19aebad55d5668df2a8c814/addons/stock/models/stock_move.py#L887-L900 When changing the BoM, an `onchange` method is raised, deletes the stock moves linked to the first BoM and creates some new ones. However, since `group_id` is not a field required by the view `view_stock_move_raw_tree`, this field will not be included in the `onchange` response. As a result, when saving the new MO, the `write` request does not contain the `group_id` field, so the new stock moves do not have this information. Therefore, when running `_search_picking_for_assignation`, the module finds a picking and does not create a new one. OPW-2444235 closes odoo/odoo#67311 X-original-commit: 653578e885f5977ccf65effbbbe383cf2e7f8d2c Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>

view details

Nasreddin (bon)

commit sha dfe1a6af4b7b740540270d38581f64aa37616222

[FIX] website_event_track: allow removing favicon Issue - Install 'website_event_track' module - Go to settings and remove website favicon - Save Traceback is raised. Cause Trying to create image from favicon for app_icon, but favicon not set anymore. Solution If no website.favicon, set website.app_icon to False. opw-2451934 closes odoo/odoo#67298 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

view details

Humberto Arocha

commit sha 5bcfe64d5f270fd012c4d9def23c3992f500b2ab

[FIX] l10n_mx: Fixing Repartition account for refund Main - [FIX] l10n_mx: Repartition account for refund must be the same than invoice's one. Explanation - Current Behavior = Purchase Tax (16%) - |field|value |-|- |Transition Account|Transtion Tax |Invoice Repartition|Paid Tax |Refund Repartition|Transtion Tax |CABA Base|Base Account Invoice - |account|debit|credit| |-|-:|-:| |Expense|1000|| |Transtion Tax|160|| |Payables||1160| Payment - |account|debit|credit| |-|-:|-:| |Payables|580|| |Bank||580| CABA on Payment - |account|debit|credit| |-|-:|-:| |Base Account|500|| |Base Account||500| |Paid Tax|80|| |Transtion Tax||80| Refund - |account|debit|credit| |-|-:|-:| |Payables|290|| |Discounts||250| |Transtion Tax||40| CABA on Refund - |account|debit|credit| |-|-:|-:| |Base Account|250|| |Base Account||250| |Paid Tax|40|| |Transtion Tax||40| |Base Account|250|| |Base Account||250| |Transtion Tax|40|| |Transtion Tax (*)||40| (*)Wrong Entry Line Trail Balance - |account|debit|credit|balance| |-|-:|-:|-:| |Bank|0|580|-580| |Base Account|1000|1000|0| |Discounts|0|250|-250| |Expense|1000|0|1000| |Paid Tax|120|0|120| |Payables|870|1160|-290| |Transtion Tax|200|200|0| |Total Sum|3190|3190|0| Expected Behavior = Purchase Tax (16%) - |field|value |-|- |Transition Account|Transtion Tax |Invoice Repartition|Paid Tax |Refund Repartition|Paid Tax |CABA Base|Base Account Invoice - |account|debit|credit| |-|-:|-:| |Expense|1000|| |Transtion Tax|160|| |Payables||1160| Payment - |account|debit|credit| |-|-:|-:| |Payables|580|| |Bank||580| CABA on Payment - |account|debit|credit| |-|-:|-:| |Base Account|500|| |Base Account||500| |Paid Tax|80|| |Transtion Tax||80| Refund - |account|debit|credit| |-|-:|-:| |Payables|290|| |Discounts||250| |Transtion Tax||40| CABA on Refund - |account|debit|credit| |-|-:|-:| |Base Account|250|| |Base Account||250| |Paid Tax|40|| |Transtion Tax||40| |Base Account|250|| |Base Account||250| |Transtion Tax|40|| |Paid Tax (*)||40| (*)Right Entry Line Trail Balance - |account|debit|credit|balance| |-|-:|-:|-:| |Bank|0|580|-580| |Base Account|1000|1000|0| |Discounts|0|250|-250| |Expense|1000|0|1000| |Paid Tax|120|40|80| |Payables|870|1160|-290| |Transtion Tax|200|160|40| |Total Sum|3190|3190|0| Tax Review = It is expected that Payables for 290 divided by 1.16 (100% + tax) yields the tax base equal to 250 Given that tax base of 250 multiplied by 0.16 (tax) should yield the Outstanding Transition Tax. Transition Tax must be 40. Currently it is 0. Paid Tax must be 80. Currently is it 120. Refund must cancel out 40 in Paid Tax because Refund is not an actual Cash Flow. closes odoo/odoo#67323 X-original-commit: 18f9cbea59b4a9bcacb5eee237c531a666b1dc46 Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>

view details

Andrea Grazioso (agr-odoo)

commit sha b870e448851e7f2fdd97e6509934ea3a6bad4bb3

[FIX] l10n_it_edi: include discount in invoice line Followup of 71cc7212b1c1abad5d37e29f3a1f33f6e6cd2a81 When the line featuring a 0% tax has also a discount this will be ignored, thus failing the e-invoice validation opw-2461496

view details

Andrea Grazioso (agr-odoo)

commit sha 7fe465c42ec4c7a9a10026ad0b2719050bf85602

[FIX] l10n_it_edi: send only 'out_invoice' to SDI PEC server For each move post the system send a PEC. This should not occur, as only outgoing invoice should be registered in the EDI system as e-invoice opw-2461496 closes odoo/odoo#67338 Signed-off-by: Josse Colpaert <jco@openerp.com>

view details

push time in 2 months

push eventskeller1/odoo

Daniel Duque

commit sha bec158627024f3ff6e7352cc8d4e91be9d807540

[CLA] FactorLibre X-original-commit: af3970603437e88797ccef4e519c4303497c3b83

view details

Daniel Duque

commit sha b83dfaa2c9bcc6bc7f8df19ed0e442554816709b

[FIX] core: missing default values with inherits Consider some model A that "_inherits" from model B, which itself "_inherits" from model C. Also consider a field F on model C, which is inherited by both models B and A. Now create a record from model A, with a given record for model C, no record for model B, and a default value for field F. This should create a record in A, connected to a new record in B, connected to the given record in C, and the default value should be ignored, as a record from C is given. Before this commit, the given record in C is modified with the default value for F. The default value is considered because no record is given for B, and that value is used to modify the given record in C. The fix consists in discarding default values by considering potential ancestor records when parent records are not given. closes odoo/odoo#61128 X-original-commit: dfce8a614be9e2091f4561ff65ca9592239165cd Signed-off-by: Raphael Collet (rco) <rco@openerp.com> Co-authored-by: Raphael Collet <rco@odoo.com>

view details

nans

commit sha 766abb28e7a44188f375fbad17374dbe67be6574

[IMP] product: extract pricelist item price computation into its model The pricelist item model (product.pricelist.item) has a compute_price field, and the necessary fields to be able to compute the price of a product. However, these fields are never used into the model itself; the parent model (product.pricelist) actually makes the computation, embedded into _compute_price_rule. Because of this, it's not possible to inherit pricelist items. It's also a better design, on object principles. Last, it lighten a method that is still 130+ lines long. opw 2368733 X-original-commit: 9cd0bf740706a64e49599111304a6fb5ec6d7287

view details

nans

commit sha 354567acbcdf55481306f0e9850416b7ed9686d5

[FIX] product: remove unused confusing variable This variable has been unused since commit f3d6a54e36a. opw 2368733 closes odoo/odoo#61129 X-original-commit: 563253a8303723e3eb4217005bf518fdf6b3f9e3 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

view details

Goffin Simon

commit sha 832cf1eeec4eef39d9ef64f8550691d9ee3439b5

[FIX] purchase: Smart button in contact view form Steps to reproduce the bug: - Let's consider a company contact C with two children CH1 and CH2 - Create a purchase order for CH1 and a purchase order for CH2 - Archive CH1 and CH2 Bug: The count of purchase orders in C was displaying 0 instead of 2 Same issue for the vendor bills opw:2360155 closes odoo/odoo#61150 Related: odoo/enterprise#14523 Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

view details

IEL

commit sha cbf6fd596dd87b3ad453e76957cd4c6ea8d57d80

[FIX] pad: make it work in multi-company environment STEPS: * install pad * switch to a company different from res.users::company_id (Default Company for user) * set credentials for that company * Open a form with pad, e.g. project.task BEFORE: it doesn't work, pad_generate_url returns empty values AFTER: it works WHY: Since Odoo 13.0, current company is computed by context values provided by company swither, while user.company_id is default value https://github.com/odoo/odoo/blob/d6d26ea8ac0c160b1fa12f86083965a087aedc75/odoo/addons/base/models/res_users.py#L245-L246 https://github.com/odoo/odoo/blob/5c79992f1f0f1b5a8ac4c1f464347abc10a6d8d8/odoo/api.py#L555-L562 --- bug is founding during work on opw-2369677 closes odoo/odoo#61141 Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

view details

IEL

commit sha 45acaa006253ea2ee404ad94e36b139d7747d326

[FIX] website_gengo: correct current company WHY: * Since Odoo 13.0, current company is computed by context values, while user.company_id is default value https://github.com/odoo/odoo/blob/112cf9088190606b85f60b420d50fbd1100e1f38/addons/website/models/ir_http.py#L211-L215 https://github.com/odoo/odoo/blob/d6d26ea8ac0c160b1fa12f86083965a087aedc75/odoo/addons/base/models/res_users.py#L245-L246 https://github.com/odoo/odoo/blob/5c79992f1f0f1b5a8ac4c1f464347abc10a6d8d8/odoo/api.py#L555-L562 * website_gengo was partly updated in https://github.com/odoo/odoo/commit/a5b6f31cf28e5381e1c85f66730bcdb55998e643 and https://github.com/odoo/odoo/commit/f5dfe4727c086c7577da2aef12c2d3548ba938a3 closes odoo/odoo#61142 Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

view details

Nicolas Martinelli

commit sha b6b248cc21a06455e085f201cdf32f1793f3f518

[FIX] sale: down payment translation - Set a customer language to a different language, e.g. French - Create a SO, add a product and validate - Create a down payment The down payment invoice is partially translated in French. This was first solved in fc659d3f78cb3c42e742a but broken in 0e73eca1364c8e0df93cd. opw-2365982 closes odoo/odoo#61154 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

view details

Goffin Simon

commit sha fa3262ff4f0566a350a9c33b52345b659c1aa185

[FIX] stock: Creating a serial number from a repair order Steps to reproduce the bug: - Let's consider a user U in one company C (Multi companies = False) - Let's consider a storable product P tracked by serial number - Create a repair order RO for P with U - Try to create a serial number Bug: U was not allowed to created a serial number because the required company_id field was not in the view. opw:2365836 closes odoo/odoo#60874 Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

view details

Martin Trigaux

commit sha 3898ccd9e4e89ba25c4e4f73f90dcad6bbed6805

[FIX] sale: revert cfc9abe14689d Revert "[FIX] sale: correct _get_to_invoice_qty depends" This reverts commit cfc9abe14689db82acf1872fa8d358662fc7e123. While the field is indeed in the list of records, it's a big change of behaviour. Retroactively changing the invoicable lines of sale.order that are closed is dangerous and can lead on unexpected behaviours. Performances can also be bad when changing the product configuration on a database with a lot of sale orders. Changing the product configuration should only apply to future orders, not past. closes odoo/odoo#61149 X-original-commit: be13bc94c2ff51b99a4399be44a765d0b28202eb Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

view details

Arnold Moyaux

commit sha 64d6f19d19d36128cad4d28addd91752dd7f37df

[FIX] stock: perf run scheduler multi company Usecase to reproduce: - 10 company having 10 000 moves in state 'confirmed', 'partially_available' - Run scheduler manually (without cron) It will takes a huge amount of time. It happens because the run scheduler wizard will call run_scheduler as sudo for each company (passing company as arg). run_scheduler will try to assign move that could be reserved. However the domain in order to search move do not include the company_id and search for every company. Following upper usecase: Instead of running action_assign 10 times on 10 000 moves, it will run action_assign 10 times on 100 000 moves. Databases with multi companies and having a lot of stock will have a scheduler speedup from this patch. Thanks "Rémy Voet <ryv@odoo.com>" for finding this issue. opw-2328707 closes odoo/odoo#61163 X-original-commit: a21f9876b5b9d01380d03d638deb48cd091f26e7 Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

view details

Achraf (abz)

commit sha f1a1cf87efc184dfe8f266729e5923994d224ce5

[FIX] sale_stock: resize quantity widget Issue - Use runbot with all modules/duplicate DB-all - Open a sale order randomly and enable every columns on Order Lines - Press "CREATE" button - Add "[E-COM11] Cabinet with Doors" to the products The widget is not visible Cause There are too many columns Solution Increase the width of the widget opw-2342149 closes odoo/odoo#61182 Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

view details

IEL

commit sha 7c55efa88b72bd1f3f0f32f7f738e2fda5aa4abd

[FIX] *: fix image parsing error on saving res config WHAT: apply 93a7695f65baf00d1f82481d6a2a97e6c11940a8 for all res.config.settings menus WHY: the same reason as in 93a7695f65baf00d1f82481d6a2a97e6c11940a8: When saving, a read is called. By default, read has bin_size to true to avoid performances issues. It will return the image size instead of the content it may lead to image dissapearing or "Incorrect padding" error HOW: find . -iname "*.xml"|xargs grep "\"context\".*'module'" -l | xargs sed -i "s/\(\"context\".*'module'.*\)\}/\1, 'bin_size': False}/" git checkout -- addons/base_setup/views/res_config_settings_views.xml --- PR for General Settings: https://github.com/odoo/odoo/pull/47297 opw-2346644 closes odoo/odoo#61037 Related: odoo/enterprise#14495 Signed-off-by: Ivan Yelizariev // IEL <yelizariev@users.noreply.github.com>

view details

Laurent Smet

commit sha 556da083344f472057833f9ecbf4bbbe1a35ae84

[FIX] l10n_hu: Fix typo in account.account.template.csv X-original-commit: f40b2483e170abca20349a21613b762b0b88b660

view details

Laurent Smet

commit sha 23063cab93a5dd3f347b2e8a3d837cf90d7dadf8

[FIX] l10n_de_skr04: Fix typo in account.account.template.csv closes odoo/odoo#61179 X-original-commit: 1a8913aa6830618fd973e753d16f2392d0c30d85 Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com> Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

view details

nie

commit sha 42d2195bc1fd7fd968149640560dc41ccacbbdd2

[FIX] sale: Sale order note line is not present in generated invoice Steps to reproduce the bug: - Create a sale order with a product and a note line - Confirm it - Add the delivered quantity - Click "Create invoice" Bug: The note line is not present in the generated invoice. Inspired by: https://github.com/odoo/odoo/blob/bc8856baaa97ac386ce6115919c49d28fd2aab73/addons/sale/models/sale.py#L657-L659 opw:2362321 closes odoo/odoo#61225 X-original-commit: ff4f1eafd222555b6c13503a9d7253403899bcee Signed-off-by: backspac <backspac@users.noreply.github.com>

view details

Laurent Smet

commit sha 5f3b8108888d019b0a66b47472b98c04889d343b

[FIX] point_of_sale: Always use VAT account for tax lines As the POS doesn't manage CABA entries, don't use the temporary CABA account. closes odoo/odoo#61164 X-original-commit: 11bc14c34bcd089400a9fa066293672c3c47e275 Signed-off-by: Josse Colpaert <jco@openerp.com> Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

view details

Julian Roussieau

commit sha 3e3b1b335ced1ff20129172e6a7b2b0dcbe1a20d

[FIX] stock_dropshipping: singleton in dropshipping rules When you want to obtain `dropship_picking_type`, it is possible to have several results. This will lead to an error when doing `dropship_picking_type.id`. ``` dropship_picking_type = self.env['stock.picking.type'].search([ ('company_id', '=', company.id), ('default_location_src_id.usage', '=', 'supplier'), ('default_location_dest_id.usage', '=', 'customer'), ]) ``` The fix ensures that `dropship_picking_type` contains only one element. closes odoo/odoo#61232 Signed-off-by: Denis Ledoux (dle) <dle@odoo.com>

view details

Xavier Dubuc

commit sha 3f3b06c8fb4f0e2b12e2d861d4511d5617a14e01

[FIX] mail: handle traceback on need_moderation=false filter in discuss Changed ValueError to UserError and return to raise so the user get a popup to explain that this filter value is not supported instead of a traceback task-2352688 closes odoo/odoo#61159 X-original-commit: 2d086755e869216e3f088fc840fa78aefc5d519e Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

view details

Wolfgang Taferner

commit sha 540d527ac2b9b3319b117284b670c79c98e46d5f

[FIX] account: key error if related partner is false later and unknown Missing the default list before trying to access the dictionary with a missing key closes odoo/odoo#61204 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>

view details

push time in 2 months

push eventskeller1/odoo

Stephan Keller

commit sha 563c63f91cee43c4a19dfdd542ecd6dfa1bbb794

[IMP] product: validate date_start and date_end for pricelist items

view details

Stephan Keller

commit sha bffe02dbcaa09b5fb0b7e0104b0d9286de2a562d

[CLA] Signature for skeller1

view details

push time in 2 months

pull request commentodoo/odoo

[IMP] product: validate start and end date for pricelist items

Sorry for the noise, changed the target branch to master.

skeller1

comment created time in 2 months

push eventskeller1/odoo

Thibault Delavallée

commit sha dce3fa2fecdbd01f3442c822e66edd8f4b9ff37e

[FW][FIX] mass_mailing: correctly update list subscriptions when updating contacts There is a missing depends on subscription_ids fields, meaning it is not correctly refreshed when contacts are updated. When dealing with m2m using the o2m model as relational table, depends have to be specified on field itself to allow recomputing the fields. Task ID-2431217 COM PR odoo/odoo#71140 X-Original-Commit odoo/odoo@11ffeddf23f6e40012e4a4a664d48193ec134ce3 X-original-commit: 37bad522bcaf9a6db2f676286fb9ceb1a188dcab

view details

Thibault Delavallée

commit sha a274f4a443aeb9497b86d9f2522a102d4ff7b171

[FW][IMP] test_mail_full: add test for SMS mailing default domain and optout Purpose is to test specific behavior of opt-out for SMS marketing. This is currently not tested and working a bit strangely, as they are flagged as blacklist. This will soon be updated in another task but at least current behavior is logged somewhere. We also update some test models in order to reflect potential strange and non-default behavior, notably partner_id field used as contact field. It will be used soon when cleaning some opt-out behavior. Tests are added to check phone sanitized is correctly taken into account in default domains when inheriting from the phone blacklist mixin. Some counters notes are also updated next to some last updates. Task ID-2431217 COM PR odoo/odoo#71140 X-Original-Commit odoo/odoo@3ba3054f0aabd7307545712519594e9273dc7f28 X-original-commit: a9ac2582eb508daa21fd0d3a5a551261ecc18f8b

view details

Thibault Delavallée

commit sha b1c90b96e1c5be1f5b39de48a39a39130ca6e727

[FW][FIX] sale, mass_mailing_sms, test_mail_full: correctly support partner-only records When performing an sms marketing on a model having only a ``partner_id`` field available (aka no ``phone`` or ``mobile``) it crashes due to seen list computation (aka already contacted recipients). This is due to an SQL query not taking into account those models as it works only for those with a phone field. We fix it as done in ``mass_mailìng`` app, aka fetching information on the related partner if available. Some tests for models using a 2many relationships towards recipients are added. Note that this kind of model does not really support complete SMS notification, as only the first found partner is notified. Mass SMS on this kind of model is currently not possible as seen list is not supported. There is no standard use case of this in Odoo codebase. Correctly support sms marketing on sale model by defining the necessary methods. As sale order has only a partner_id field available we have to correctly override phone related methods for SMS. LINKS Task ID-2431217 COM PR odoo/odoo#71140 X-Original-Commit odoo/odoo@987d974ccb8c75c6eca899adb5be50fe48c8eb2c closes odoo/odoo#71178 closes odoo/odoo#71205 X-original-commit: 642816d0a819bf74927ed5aa11b6843cbb97d4df Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

view details

Alvaro Fuentes

commit sha 14036869c7b7eebea339d51f0b8abbe143e244b1

[FIX] core: fix filtered_domain for hierarchical terms The method filtered_domain() is broken for domains with hierarchical terms ('child_of'/'parent_of'). To see *one* of the ways the implementation is broken, let `A` be a model with `parent_id` pointing to `A`, and `a1` a record of model `A` without parent (`a1.parent_id` is `False`), then this fails: assert a1 in a1.filtered_domain([("parent_id", "child_of", a1.id)]) The reason it fails is that on https://github.com/odoo/odoo/blob/f5519586d214a9b34ad24683a7f97c47802a3bad/odoo/models.py#L5377-L5380 `data` is empty since `a1` has no parent, thus https://github.com/odoo/odoo/blob/f5519586d214a9b34ad24683a7f97c47802a3bad/odoo/models.py#L5403-L5404 fails, therefore the result of `filtered_domain` is empty. Note: the implementation of the hierarchical operators is full of quirks that are hard to emulate otherwise than by reusing the original code. As a consequence, the current implementation may be broken in more than one way. Let's see another way the implementation is broken: let `B` be a model without a `parent_id` field and with a `friend_id` field pointing to `B`, and let `b1` be a record of model `B`. Then b1.filtered_domain([("friend_id", "child_of", b1.id)]) throws an exception of the form shown below: ValueError: Invalid field 'parent_id' in leaf "<osv.ExtendedLeaf: ('parent_id', 'child_of', 1) ... Meanwhile the following code is still valid and returs b1: B.search([("friend_id", "child_of", b1.id)]) closes odoo/odoo#71237 X-original-commit: e7a5ba95d8b7df5bbf545ef8afe0a1f5d0f70272 Signed-off-by: Raphael Collet (rco) <rco@openerp.com>

view details

Thibault Delavallée

commit sha 3ffd6acc023617944d997f079c44aa34ac4221d7

[IMP] mail: concatenate all Base class code in a single override Merge two overrides of Base into the same file. Just moving code to clean module, nothing changes functionally or technically. LINKS Task ID-2431217 COM PR odoo/odoo#67322 ENT PR odoo/enterprise#16876 UPG PR odoo/upgrade#2236

view details

Thibault Delavallée

commit sha ed508ee1bd56847e235a4f8e487e827cc34e3a87

[REF] mass_mailing: move mailing capability on model PURPOSE Remove hardcoded list of models on which mailing is possible. Indeed it is not modular and not really smart with enterprise code not being reachable in community. SPECIFICATIONS Replace hardcoded list of models on which mailing (both mail or sms) is possible by a computed searchable field on ``ir.model`` based on a class attribute. It allows to cleanly define models having mass mailing capabilities and add this attribute in bridge modules (when existing) or directly on base model definition to avoid bridge modules. In this commit we introduce a basic ``_mailing_enabled`` class attribute activating mailing on model. Mailing models may also have a ``_mailing_get_default_domain`` method allowing to define a custom default domain when sending a marketing mailing on records on this class. Mailing models can now define a ``_mailing_get_opt_out_list(_sms)`` method allowing to define custom behavior to fetch opt-outed records. Instead of defining a model-based behavior on Mailing itself, it now calls the model defined one. We still have two methods, one for mailing and one for SMS opt out computation as it relies on different underlying models and fields. LINKS Task ID-2431217 COM PR odoo/odoo#67322 ENT PR odoo/enterprise#16876 UPG PR odoo/upgrade#2236

view details

Thibault Delavallée

commit sha 500b845b8aefe93ab25ece9316af659786f3632f

[IMP] mass_mailing_{event/event_track/sale}: add default mailing domains When performing an email or SMS mailing on functional models a default domain is a good start to avoid sending notifications to dead records, aka * canceled registrations; * canceled tracks; * canceled sale orders; Task ID-2431217 COM PR odoo#67322 ENT PR odoo/enterprise#16876 UPG PR odoo/upgrade#2236 closes odoo/odoo#67322 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

view details

sofiagvaladze

commit sha 95daf9d28c9a82c4ed84971e0f573de43b38d7ba

[IMP] hr: Create activity a month before Work Permit Expiration Date Add boolean field to upload work permit Task - 2442648 closes odoo/odoo#65899 Related: odoo/upgrade#2173 Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

view details

newtratip

commit sha 519535febfb3c0f9284484b1c9d959c3ef8d0be9

[IMP] purchase_requisition: Add archived in purchase agreement types closes odoo/odoo#71254 Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

view details

Dhruv Patel

commit sha 885a642a9bc785154d802f2b170cee3c77656b3a

[FIX] mail: chat window should remain folded on new message If the chat window was initially folded and when a new message is received the chat window automatically unfolds. it is annoying having a window that pops up each time a new message is coming while having folded it once. So, It should remain folded when a new message is received if the chat window is already folded. Task : 2522141 closes odoo/odoo#71258 X-original-commit: 6e84914a3691735e9c97084cc8d55788babd2ad9 Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

view details

wan

commit sha b063473363eb8d4a5a42afdc5895aabc93052584

[FIX] l10n_cl: module category Localization modules need to be `Accounting/Localizations/Account Charts` Because this will install `l10n_generic_coa` otherwise https://github.com/odoo/odoo/blob/36a9e761c8d6c1c6e9611cc410ecca82ff2b1659/addons/account/__init__.py#L28 closes odoo/odoo#71261 X-original-commit: 2efe50bafbb79a9fc6b53c06c456313fa9b3b5bc Signed-off-by: Josse Colpaert <jco@openerp.com>

view details

Tiffany Chang (tic)

commit sha e8881ca029c8648501ead0a115232128b8370b05

[FIX] stock: don't show "Set Quantities" button when immediate transfer "Set Quantities" button does not make sense to show for immediate transfers since there are no quantities to reserve, therefore we hide it. Task: 2492994

view details

Tiffany Chang (tic)

commit sha f46392707d4a1d178523f934972226143ff066d1

[FIX] stock: fix multi-step immediate transfer receipts Steps to reproduce: 1. activate routes setting + multi-step incoming shipments (2 or 3, doesn't matter) 2. create an immediate transfer receipt 3. add a done quantity (optional: validate) 4. open corresponding 2nd step internal transfer Expected result: - amount done in immediate transfer receipt will be demand of internal transfer Actual result: - demand (and all other values) will be 0 closes odoo/odoo#68885 Task: 2492994 Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

view details

Mohammed Shekha

commit sha d25459e6cbfc1dbe92350bc5b17bb33062ac4f12

[IMP] mail,web: add many2many_avatar_user widget to open chat with this commit, we adds many2many_avatar_user widget to have same behaviour as many2one_avatar_user where clicking on avatar image opens chat box, so to have same feature on many2many_tags which is related to res.users we adds many2many_avatar_user widget. task-2451204

view details

Mohammed Shekha

commit sha 8962edf4924edeed981a755751f34a3d2337542f

[FIX] web: do not show cursor pointer on m2m badge without color before this commit: when many2mnay_tags widget does not have color_field in options still hovering over many2many_tags badge shows cursor pointer, while it should display default cursor and if there is color field given in options then cursor should be pointer. after this commit: cursor pointer will be displayed only when color field is given in options else shod cursor default. task-2451204

view details

Mohammed Shekha

commit sha ffe768f28e9fb46ec443ee535a1f76ce59ac630c

[IMP] hr: support many2many_avatar_employee widget closes odoo/odoo#67515 Related: odoo/enterprise#17081 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

view details

nounoubensebia

commit sha 24d5c789f1096a28f8d22158159ed3bf796c0226

[IMP] mail_plugin, crm_mail_plugin: add translation support for email plugins In mail_plugin module, add a method which returns translatable modules, this method will be overridden in the other modules to add their module names. Translations are prepared via the _prepare_translations method which uses the get_translations_for_webclient method, this way we can easily fetch translations without having to write python code. We also add xml files in "static/", these files contain terms to be translated, for each plugin we create a separate xml file so that we can easily update each plugin separately. This implementation will allow having translations handled by Odoo, which has several advantages: - existing system, nothing to develop - it will use transifex and the terms will be translated by the community - forces that mail_client implementations to have the same logic (consistency) - compared to other solutions which rely on python code to return translations, this solution is more robust as it avoids having to type the string to translate twice Task-2480075 closes odoo/odoo#69118 Ent-pr: https://github.com/odoo/enterprise/pull/17626 Plugin-pr: https://github.com/odoo/mail-client-extensions/pull/6 Related: odoo/enterprise#17626 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

view details

Habib (ayh)

commit sha a684c3e89cbf8e5106eeab22823e9d84c14d8ca0

[IMP] account: usability and traceability of journal entries - improve traceability of duplicated journal entries by logging a message in the chatter to trace back to its origin was task 2478537

view details

Habib (ayh)

commit sha 4f437d119e8939f4911ca79d2ab0ef1cd39cda4a

[IMP] account: usability of journal form view navigation from a journal to its entries improved by adding a smart button part of task 2478537

view details

Habib (ayh)

commit sha 6454de7af4cdc66bdf55732dbbaaf2ae8edbe891

[IMP] account: improve display name of cancelled journal entries The display name of cancelled entries is "/" This provides no information to the user - especially when the duplication message is logged. This aims to improve the display_name of account.move so draft and cancelled entries display the id as a reference closes odoo/odoo#70764 Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>

view details

push time in 2 months

push eventskeller1/odoo

Géry Debongnie

commit sha 580456b6ab36d16195eae9ffd776ff245ecd936e

[FIX] web: prevent traceback when pressing TAB in color_picker widget The color_picker widget, that can be seen for example in the track form view for event tracks, had an issue: if the user clicked on it, then pressed TAB, a traceback was displayed. The problem comes from the fact that the color picker widget inherits from FieldInput, but is not a fieldinput, so many expectations made by the FieldInput code do not hold, such as the code run when handling navigation (by TAB and such keypress). Because of that, the code in _onNavigationMove crashed, because it expected an input. Since this is a bug fix, I simply disabled the navigation in that case, so no crash happens. Sadly, this widget has still a big issue: it clearly does not work as most users would expect: pressing TAB or arrows should update the selection. But this would be a more complicated refactoring, for a bug which is clearly not critical, therefore this commit implements the simple and safe solution. Also, we disable the focus outline to minimize the wrong expectation. Seeing them kind of implied that one could update the selection with the keyboard. Note that the widget color_picker was moved from another addon to web/, without any tests nor documentation. OPW 2467369 closes odoo/odoo#67174 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

view details

Goffin Simon

commit sha 1314abba00b3791a73a6fcc73963be2c28d12129

[FIX] sale: Wrong untaxed_amount_to_invoice Steps to reproduce the bug: - Let's consider an included tax T (10%) and a product P (11€) with invoicing policy based on delivery - Create a sale order SO with one line L with 2 P and T - Confirm SO and deliver it Bug: The untaxed_amount_to_invoice was 40€ on L instead 20€ opw:2457660 closes odoo/odoo#67181 X-original-commit: 56d92277f20566d5b652ce713551970d0b7784c0 Signed-off-by: Simon Goffin (sig) <sig@openerp.com>

view details

Kairis

commit sha bd33f283a1fa39815481ca28918c65ac7b48d641

[IMP] Expense, Timesheets: toast feedback to user Display notification to give feedback to user. And reload the view with the params "next". closes odoo/odoo#59274 Taskid: 2344276 Related: odoo/enterprise#13846 Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

view details

aaj-odoo

commit sha fa7db335922780709216ea50559f818a5b50beeb

[FIX] mass_mailing: hide action buttons in 'sending' state Before this commit: In a mass mailing, the action buttons such as 'put_in_queue' (Send) and 'action_schedule_date' (Schedule) are visible in 'sending' state, which is not correct because users should not be able re-launch it in sending state. After this commit: We hide those action button in 'sending' state to prevent user from re-launching mass mailing when it's already in queue. Task-Id : 2469352 closes odoo/odoo#67031 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

view details

Benjamin Frantzen (bfr)

commit sha 22edc603cc8fd0ac29fbbc074b25ce31a5b7e270

[IMP] account_edi: visual improvements on account.move and account.invoice.send - don't show Electronic Invoicing field on account.move view if no EDI require web-service Backport of https://github.com/odoo/odoo/pull/64493 (TASK ID: 2439258) - don't show account_edi_format field on account_invoice_send closes odoo/odoo#67049 Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

view details

Laurent Smet

commit sha 86e2c6b7126e2e73f5acfc7ebfee490808a70df7

[REV] account: Revert "set memo to ref if not payment_reference" This reverts commit a59f255ef33c47449d028930e15c5390c62e39ed. github issue: 67098 closes odoo/odoo#67179 X-original-commit: 882a6b2ab85753b05fab1687ebc310005be9cdab Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com> Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

view details

Florian Gilbert

commit sha 97fb335e3f70a55b18685b9b6b08fe0162e1a17b

[FIX] account_fleet: Adding vehicle_id for in_refund. Field vehicle_id is missing on the account.move.line view of refunds. This fix updates the domain to make visible the field in in_refund. Task ID: #2466914 closes odoo/odoo#66892 Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>

view details

Géry Debongnie

commit sha d9834e65ee57511f4850fa2d74287eb0b67087b9

[FIX] web: properly apply onchange in some cases A previous commit (8dbd1efef899fb637acca3c318ae99cb23838b8f) fixed a part of the basicmodel that used _.each to iterate on an object with field names as keys, which does not work when a field is named "length". To fix it, I simply used a native for ... in statement. However, I missed the fact that there was a second 'return' statement in the body of the closure given to _.each, so the onchange method returned prematurely. The fix is to simply use the continue statement in that case. closes odoo/odoo#67228 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

view details

Goffin Simon

commit sha 7144321c3fd13f83241ae7e4be71a9a4d576a871

[FIX] account_fleet: Field vehicle_id unavailable on vendor refund The fleet vehicle_id must be visible on vendor refund opw:2471784 closes odoo/odoo#67130 Signed-off-by: William André (wan) <wan@odoo.com>

view details

Benjamin Vray

commit sha 0bbae314ede2d7112a32954f06a8d541932caac9

[FIX] website: fix showcase snippet images stretched Before this commit, if we replaced an icon of the showcase snippet with an image, this image was streched depending on title size (if too long and on 2 lines). Its because the align-self default value of a flex item is strech. task-2447087 closes odoo/odoo#67234 Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

view details

Nicolas Lempereur

commit sha f8e4e98d9fba2d399efa4ca48f8d15d620fec9c7

[FIX] l10n_id_efaktur: filter invoice lines on display_type (bis) Missing line in 24c32607 forward-port (only for 14.0). opw-2451571 closes odoo/odoo#67240 Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>

view details

Carlos Roca

commit sha e5697dcfa7def73bd55ec908a165bec56229c284

[CLA] update Tecnativa signature closes odoo/odoo#67237 X-original-commit: 42291b957ba4f33640c99097be73f16aa9e06d47 Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>

view details

Christophe Monniez

commit sha 54b6a7a97e574249c22f16ea2756989e4bd4fac3

[FIX] packaging: remove dead code that prevent rpm build Since 9c2ce1f12c2, more files are included in packaging. The rpm build failed because shebang lines of packaged files must not use `/usr/bin/env` [0] [1] [2]. As it seems that those old files are not of any use anymore, this commit removes them. [0] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shebang_lines [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#Multiple_Python_Runtimes [2] https://pagure.io/packaging-committee/issue/738 closes odoo/odoo#67258 X-original-commit: d2a6ed1b2709eb0f1ea8a38818bd669e6d990cd8 Signed-off-by: Raphael Collet (rco) <rco@openerp.com> Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

view details

nie

commit sha 46de40dc54d04139b2319b342a7f0c7cb9318e84

[FIX] payment: link transaction to invoice with payment link Steps: - Install account,payment - Go to Invoicing - Create an invoice - Click Actions > Generate a Payment Link - Follow the generated link - Pay Bug: The transaction is not linked to the sale order in the link table `account_invoice_transaction_rel` Explanation: This fix is broadly mimicking the behavior of the sales module regarding the link of an order to a transaction, adding `invoice_id`s where they are needed throughout the payment process in order to link the transaction to the invoice. opw:2451534 closes odoo/odoo#67289 X-original-commit: 7c6d06fa5858f79f3b22cdeaf74cdc26a642742f Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com> Signed-off-by: backspac <backspac@users.noreply.github.com>

view details

Benjamin Vray

commit sha ea72517730dfcfc5d6eefeef0195e61468b66b57

[FIX] website: state not saved for accordion snippet Before this commit, the states (collapsed/not collapsed) of the tabs of the accordion snippet were not saved if it was the only changement in edit mode. After this commit, we trigger a content change when the states of the tabs is changed. task-2442237 closes odoo/odoo#67252 X-original-commit: 18af2ecade9482b5243059aefbfa79410ebf59a6 Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

view details

Jeremy Kersten

commit sha f344c4aea642a902ee244390621a35d7b649d923

[FIX] website_sale: we don't support rounding uom in ecommerce We only support int, following #c9edca7896e3096289936f5399a82f08a59b60ce opw-2456796 closes odoo/odoo#67279 X-original-commit: a05a34366f6dc8c70b39c15c3441beaf6bbb72d2 Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

view details

Benoit Socias

commit sha 439a7568b5b1e7d0aa53c63c7332dd22e3d6fc04

[FIX] website: remove save snippet button for cookie bar Before this commit the save snippet button appeared for the cookie bar. But this makes no sense because the cookie bar is implicitly saved. After this commit the save snippet button is not available for the cookie bar. task-2464233 https://github.com/odoo/odoo/pull/67217

view details

Benoit Socias

commit sha 2f920e0023d29545d2957e5d6ca1619068af893b

[FIX] website: avoid duplication of cookie policy page Before this commit a cookie policy page was created every time the website settings were saved with the "Cookies Bar" option enabled. After this commit the policy page is created only if it does not already exist for the website. task-2454424 https://github.com/odoo/odoo/pull/67217 closes odoo/odoo#67217 Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

view details

Jorge Pinna Puissant

commit sha 9f03a4ef1ed2076f38ff50de61074301a277d7ef

[FIX] sale_coupon: fiscal position for promotion product line create a SO; Add a fiscal position; Add a promotion of fixed amount kind. Before this commit, the taxes of the promotion are the one of the promotion product and not the one of the fiscal position. Now, the taxes will be computed taken into account the fiscal position. opw-2467966 closes odoo/odoo#67306 X-original-commit: 16dab7df5bb966219fa8798b77743149ad129572 Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>

view details

Jeremy Kersten

commit sha 19ef4f1b318b979bf2c6e89ad9962a50e6684dc9

[FIX] website: typo in drop snippet tour task-2466754 closes odoo/odoo#67317 Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>

view details

push time in 2 months

push eventskeller1/odoo

Florent de Labarre

commit sha ee2ee1ee6de70c9626904b84020d15d837e1f1c1

[FIX] l10n_fr_pos_cert: hash doesn't appear in ticket during reprint - Create a pos order, pay and valide - Close Pos - reopen pos - search this order - click print ticket --> Issue the hash doesn't appear on the ticket closes odoo/odoo#71217 X-original-commit: 40adcce221ab882d034b2f4ed2987a234ba434f5 Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>

view details

Thibault Delavallée

commit sha dce3fa2fecdbd01f3442c822e66edd8f4b9ff37e

[FW][FIX] mass_mailing: correctly update list subscriptions when updating contacts There is a missing depends on subscription_ids fields, meaning it is not correctly refreshed when contacts are updated. When dealing with m2m using the o2m model as relational table, depends have to be specified on field itself to allow recomputing the fields. Task ID-2431217 COM PR odoo/odoo#71140 X-Original-Commit odoo/odoo@11ffeddf23f6e40012e4a4a664d48193ec134ce3 X-original-commit: 37bad522bcaf9a6db2f676286fb9ceb1a188dcab

view details

Thibault Delavallée

commit sha a274f4a443aeb9497b86d9f2522a102d4ff7b171

[FW][IMP] test_mail_full: add test for SMS mailing default domain and optout Purpose is to test specific behavior of opt-out for SMS marketing. This is currently not tested and working a bit strangely, as they are flagged as blacklist. This will soon be updated in another task but at least current behavior is logged somewhere. We also update some test models in order to reflect potential strange and non-default behavior, notably partner_id field used as contact field. It will be used soon when cleaning some opt-out behavior. Tests are added to check phone sanitized is correctly taken into account in default domains when inheriting from the phone blacklist mixin. Some counters notes are also updated next to some last updates. Task ID-2431217 COM PR odoo/odoo#71140 X-Original-Commit odoo/odoo@3ba3054f0aabd7307545712519594e9273dc7f28 X-original-commit: a9ac2582eb508daa21fd0d3a5a551261ecc18f8b

view details

Thibault Delavallée

commit sha b1c90b96e1c5be1f5b39de48a39a39130ca6e727

[FW][FIX] sale, mass_mailing_sms, test_mail_full: correctly support partner-only records When performing an sms marketing on a model having only a ``partner_id`` field available (aka no ``phone`` or ``mobile``) it crashes due to seen list computation (aka already contacted recipients). This is due to an SQL query not taking into account those models as it works only for those with a phone field. We fix it as done in ``mass_mailìng`` app, aka fetching information on the related partner if available. Some tests for models using a 2many relationships towards recipients are added. Note that this kind of model does not really support complete SMS notification, as only the first found partner is notified. Mass SMS on this kind of model is currently not possible as seen list is not supported. There is no standard use case of this in Odoo codebase. Correctly support sms marketing on sale model by defining the necessary methods. As sale order has only a partner_id field available we have to correctly override phone related methods for SMS. LINKS Task ID-2431217 COM PR odoo/odoo#71140 X-Original-Commit odoo/odoo@987d974ccb8c75c6eca899adb5be50fe48c8eb2c closes odoo/odoo#71178 closes odoo/odoo#71205 X-original-commit: 642816d0a819bf74927ed5aa11b6843cbb97d4df Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

view details

Alvaro Fuentes

commit sha 14036869c7b7eebea339d51f0b8abbe143e244b1

[FIX] core: fix filtered_domain for hierarchical terms The method filtered_domain() is broken for domains with hierarchical terms ('child_of'/'parent_of'). To see *one* of the ways the implementation is broken, let `A` be a model with `parent_id` pointing to `A`, and `a1` a record of model `A` without parent (`a1.parent_id` is `False`), then this fails: assert a1 in a1.filtered_domain([("parent_id", "child_of", a1.id)]) The reason it fails is that on https://github.com/odoo/odoo/blob/f5519586d214a9b34ad24683a7f97c47802a3bad/odoo/models.py#L5377-L5380 `data` is empty since `a1` has no parent, thus https://github.com/odoo/odoo/blob/f5519586d214a9b34ad24683a7f97c47802a3bad/odoo/models.py#L5403-L5404 fails, therefore the result of `filtered_domain` is empty. Note: the implementation of the hierarchical operators is full of quirks that are hard to emulate otherwise than by reusing the original code. As a consequence, the current implementation may be broken in more than one way. Let's see another way the implementation is broken: let `B` be a model without a `parent_id` field and with a `friend_id` field pointing to `B`, and let `b1` be a record of model `B`. Then b1.filtered_domain([("friend_id", "child_of", b1.id)]) throws an exception of the form shown below: ValueError: Invalid field 'parent_id' in leaf "<osv.ExtendedLeaf: ('parent_id', 'child_of', 1) ... Meanwhile the following code is still valid and returs b1: B.search([("friend_id", "child_of", b1.id)]) closes odoo/odoo#71237 X-original-commit: e7a5ba95d8b7df5bbf545ef8afe0a1f5d0f70272 Signed-off-by: Raphael Collet (rco) <rco@openerp.com>

view details

Thibault Delavallée

commit sha 3ffd6acc023617944d997f079c44aa34ac4221d7

[IMP] mail: concatenate all Base class code in a single override Merge two overrides of Base into the same file. Just moving code to clean module, nothing changes functionally or technically. LINKS Task ID-2431217 COM PR odoo/odoo#67322 ENT PR odoo/enterprise#16876 UPG PR odoo/upgrade#2236

view details

Thibault Delavallée

commit sha ed508ee1bd56847e235a4f8e487e827cc34e3a87

[REF] mass_mailing: move mailing capability on model PURPOSE Remove hardcoded list of models on which mailing is possible. Indeed it is not modular and not really smart with enterprise code not being reachable in community. SPECIFICATIONS Replace hardcoded list of models on which mailing (both mail or sms) is possible by a computed searchable field on ``ir.model`` based on a class attribute. It allows to cleanly define models having mass mailing capabilities and add this attribute in bridge modules (when existing) or directly on base model definition to avoid bridge modules. In this commit we introduce a basic ``_mailing_enabled`` class attribute activating mailing on model. Mailing models may also have a ``_mailing_get_default_domain`` method allowing to define a custom default domain when sending a marketing mailing on records on this class. Mailing models can now define a ``_mailing_get_opt_out_list(_sms)`` method allowing to define custom behavior to fetch opt-outed records. Instead of defining a model-based behavior on Mailing itself, it now calls the model defined one. We still have two methods, one for mailing and one for SMS opt out computation as it relies on different underlying models and fields. LINKS Task ID-2431217 COM PR odoo/odoo#67322 ENT PR odoo/enterprise#16876 UPG PR odoo/upgrade#2236

view details

Thibault Delavallée

commit sha 500b845b8aefe93ab25ece9316af659786f3632f

[IMP] mass_mailing_{event/event_track/sale}: add default mailing domains When performing an email or SMS mailing on functional models a default domain is a good start to avoid sending notifications to dead records, aka * canceled registrations; * canceled tracks; * canceled sale orders; Task ID-2431217 COM PR odoo#67322 ENT PR odoo/enterprise#16876 UPG PR odoo/upgrade#2236 closes odoo/odoo#67322 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

view details

sofiagvaladze

commit sha 95daf9d28c9a82c4ed84971e0f573de43b38d7ba

[IMP] hr: Create activity a month before Work Permit Expiration Date Add boolean field to upload work permit Task - 2442648 closes odoo/odoo#65899 Related: odoo/upgrade#2173 Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>

view details

newtratip

commit sha 519535febfb3c0f9284484b1c9d959c3ef8d0be9

[IMP] purchase_requisition: Add archived in purchase agreement types closes odoo/odoo#71254 Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

view details

Dhruv Patel

commit sha 885a642a9bc785154d802f2b170cee3c77656b3a

[FIX] mail: chat window should remain folded on new message If the chat window was initially folded and when a new message is received the chat window automatically unfolds. it is annoying having a window that pops up each time a new message is coming while having folded it once. So, It should remain folded when a new message is received if the chat window is already folded. Task : 2522141 closes odoo/odoo#71258 X-original-commit: 6e84914a3691735e9c97084cc8d55788babd2ad9 Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

view details

wan

commit sha b063473363eb8d4a5a42afdc5895aabc93052584

[FIX] l10n_cl: module category Localization modules need to be `Accounting/Localizations/Account Charts` Because this will install `l10n_generic_coa` otherwise https://github.com/odoo/odoo/blob/36a9e761c8d6c1c6e9611cc410ecca82ff2b1659/addons/account/__init__.py#L28 closes odoo/odoo#71261 X-original-commit: 2efe50bafbb79a9fc6b53c06c456313fa9b3b5bc Signed-off-by: Josse Colpaert <jco@openerp.com>

view details

Tiffany Chang (tic)

commit sha e8881ca029c8648501ead0a115232128b8370b05

[FIX] stock: don't show "Set Quantities" button when immediate transfer "Set Quantities" button does not make sense to show for immediate transfers since there are no quantities to reserve, therefore we hide it. Task: 2492994

view details

Tiffany Chang (tic)

commit sha f46392707d4a1d178523f934972226143ff066d1

[FIX] stock: fix multi-step immediate transfer receipts Steps to reproduce: 1. activate routes setting + multi-step incoming shipments (2 or 3, doesn't matter) 2. create an immediate transfer receipt 3. add a done quantity (optional: validate) 4. open corresponding 2nd step internal transfer Expected result: - amount done in immediate transfer receipt will be demand of internal transfer Actual result: - demand (and all other values) will be 0 closes odoo/odoo#68885 Task: 2492994 Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

view details

Mohammed Shekha

commit sha d25459e6cbfc1dbe92350bc5b17bb33062ac4f12

[IMP] mail,web: add many2many_avatar_user widget to open chat with this commit, we adds many2many_avatar_user widget to have same behaviour as many2one_avatar_user where clicking on avatar image opens chat box, so to have same feature on many2many_tags which is related to res.users we adds many2many_avatar_user widget. task-2451204

view details

Mohammed Shekha

commit sha 8962edf4924edeed981a755751f34a3d2337542f

[FIX] web: do not show cursor pointer on m2m badge without color before this commit: when many2mnay_tags widget does not have color_field in options still hovering over many2many_tags badge shows cursor pointer, while it should display default cursor and if there is color field given in options then cursor should be pointer. after this commit: cursor pointer will be displayed only when color field is given in options else shod cursor default. task-2451204

view details

Mohammed Shekha

commit sha ffe768f28e9fb46ec443ee535a1f76ce59ac630c

[IMP] hr: support many2many_avatar_employee widget closes odoo/odoo#67515 Related: odoo/enterprise#17081 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

view details

nounoubensebia

commit sha 24d5c789f1096a28f8d22158159ed3bf796c0226

[IMP] mail_plugin, crm_mail_plugin: add translation support for email plugins In mail_plugin module, add a method which returns translatable modules, this method will be overridden in the other modules to add their module names. Translations are prepared via the _prepare_translations method which uses the get_translations_for_webclient method, this way we can easily fetch translations without having to write python code. We also add xml files in "static/", these files contain terms to be translated, for each plugin we create a separate xml file so that we can easily update each plugin separately. This implementation will allow having translations handled by Odoo, which has several advantages: - existing system, nothing to develop - it will use transifex and the terms will be translated by the community - forces that mail_client implementations to have the same logic (consistency) - compared to other solutions which rely on python code to return translations, this solution is more robust as it avoids having to type the string to translate twice Task-2480075 closes odoo/odoo#69118 Ent-pr: https://github.com/odoo/enterprise/pull/17626 Plugin-pr: https://github.com/odoo/mail-client-extensions/pull/6 Related: odoo/enterprise#17626 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

view details

Habib (ayh)

commit sha a684c3e89cbf8e5106eeab22823e9d84c14d8ca0

[IMP] account: usability and traceability of journal entries - improve traceability of duplicated journal entries by logging a message in the chatter to trace back to its origin was task 2478537

view details

Habib (ayh)

commit sha 4f437d119e8939f4911ca79d2ab0ef1cd39cda4a

[IMP] account: usability of journal form view navigation from a journal to its entries improved by adding a smart button part of task 2478537

view details

push time in 2 months