profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/skeeey/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Wei Liu skeeey Red Hat Xi‘an, China

IBMSpectrumComputing/cwlexec 35

A new open source tool to run CWL workflows on LSF

skeeey/addon-framework 0

addon apis

skeeey/ci-tools 0

DPTP Tooling

skeeey/cloud-prepare 0

Go library to prepare your cloud infrastructure via API for submariner to work on top

push eventskeeey/cluster-proxy-addon

liuwei

commit sha 3fe4a6f28f30ab3027f741ceed4128c50c4f7f32

update addonframework Signed-off-by: liuwei <liuweixa@redhat.com>

view details

push time in 3 days

pull request commentopen-cluster-management/cluster-proxy-addon

update addonframework

/retest

skeeey

comment created time in 3 days

pull request commentopen-cluster-management/cluster-proxy-addon

update addonframework

refer to https://github.com/open-cluster-management/backlog/issues/17406

skeeey

comment created time in 3 days

create barnchskeeey/cluster-proxy-addon

branch : update-addonframework

created branch time in 3 days

pull request commentopen-cluster-management-io/addon-framework

if manged cluster is deleting, dont recover addon's manifestwork

refer to https://github.com/open-cluster-management/backlog/issues/17406

skeeey

comment created time in 3 days

create barnchskeeey/addon-framework

branch : spoke-deletion

created branch time in 3 days

issue openedopen-cluster-management-io/community

Supporting managed clusters to communicate in the proxy environment

Currently, we use x509 client cert to build mTLS between hub and spoke clusters, but in some scenarios, there may be some proxies between the hub and spoke clusters, and for these proxies, they may need a complex configuration to support proxy cert or cannot support to proxy the cert. We may consider a way to establish the communication in these network environment

created time in 5 days

push eventskeeey/registration

liuwei

commit sha c83485af345de9d84a12820bac7293c42fb3f142

add change log for v0.5 Signed-off-by: liuwei <liuweixa@redhat.com>

view details

push time in 8 days

pull request commentopen-cluster-management-io/registration

add change log for v0.5

/assign @elgnay

skeeey

comment created time in 8 days

pull request commentopen-cluster-management-io/registration

add change log for v0.5

/assign @qiujian16

skeeey

comment created time in 8 days

create barnchskeeey/registration

branch : changelog-0.5

created branch time in 8 days

push eventskeeey/managedcluster-import-controller

liuwei

commit sha 30b5417f3106b8ea28535659eb514ac94ea2d6e6

customizing secret event sources Signed-off-by: liuwei <liuweixa@redhat.com>

view details

push time in 10 days

PullRequestReviewEvent

Pull request review commentopen-cluster-management/managedcluster-import-controller

WIP: Customizing secret and manifestwork event sources

+// Copyright (c) Red Hat, Inc.+// Copyright Contributors to the Open Cluster Management project++package source++import (+	"context"+	"fmt"++	corev1 "k8s.io/api/core/v1"+	"k8s.io/apimachinery/pkg/types"+	"k8s.io/client-go/tools/cache"+	"k8s.io/client-go/util/workqueue"+	"k8s.io/klog/v2"++	"sigs.k8s.io/controller-runtime/pkg/client"+	"sigs.k8s.io/controller-runtime/pkg/event"+	"sigs.k8s.io/controller-runtime/pkg/handler"+	"sigs.k8s.io/controller-runtime/pkg/predicate"+	"sigs.k8s.io/controller-runtime/pkg/reconcile"+	"sigs.k8s.io/controller-runtime/pkg/source"+)++var _ source.SyncingSource = &SecretSource{}++// SecretSource is the event source of specified secrets+type SecretSource struct {+	secretInformer cache.SharedIndexInformer+}++// NewImportSecretSource return a SecretSource only for import secrets+func NewImportSecretSource(secretInformer cache.SharedIndexInformer) *SecretSource {+	return &SecretSource{secretInformer: secretInformer}+}++// NewAutoImportSecretSource return a SecretSource only for auto import secrets+func NewAutoImportSecretSource(secretInformer cache.SharedIndexInformer) *SecretSource {

Just use different name to distinguish different informer

skeeey

comment created time in 10 days

Pull request review commentopen-cluster-management/managedcluster-import-controller

WIP: Customizing secret and manifestwork event sources

 func (r *ReconcileAutoImport) Reconcile(ctx context.Context, request reconcile.R 		return reconcile.Result{}, err 	} -	autoImportSecret := &corev1.Secret{}-	err = r.client.Get(ctx, types.NamespacedName{-		Namespace: managedClusterName,-		Name:      constants.AutoImportSecretName,-	}, autoImportSecret)+	autoImportSecret, err := r.kubeClient.CoreV1().Secrets(managedClusterName).Get(ctx, constants.AutoImportSecretName, metav1.GetOptions{})

yeah, we should consider it, I will add a TODO firstly

skeeey

comment created time in 10 days

PullRequestReviewEvent

pull request commentopen-cluster-management/managedcluster-import-controller

fix hive create-via annotation

/assign @zhiweiyin318

skeeey

comment created time in 10 days

pull request commentopen-cluster-management/managedcluster-import-controller

fix hive create-via annotation

refer to https://github.com/open-cluster-management/backlog/issues/17177

skeeey

comment created time in 10 days

create barnchskeeey/managedcluster-import-controller

branch : create-via

created branch time in 10 days

PR closed open-cluster-management/managedcluster-import-controller

check cert and token for import config dco-signoff: yes

Ref to: https://github.com/open-cluster-management/backlog/issues/16871 Signed-off-by: zhujian jiazhu@redhat.com

+97 -2

5 comments

2 changed files

zhujian7

pr closed time in 10 days

pull request commentopen-cluster-management/managedcluster-import-controller

check cert and token for import config

@zhujian7 the pr #88 should cover this case, so I closed this pr, thanks

zhujian7

comment created time in 10 days