profile
viewpoint

skdltmxn/kakaobot 2

Kakaotalk bot for mac

skdltmxn/deno-hash 1

Deno hash implementation in WASM for Deno project

skdltmxn/atom-language-rust 0

Rust language support in Atom

skdltmxn/deno 0

A secure JavaScript and TypeScript runtime

skdltmxn/fiar 0

Automatic Four In a Row(Connect 4) playing artificial intelligence

skdltmxn/kuicsstone 0

KuicsStone CTF Webpage

push eventskdltmxn/deno

Ryan Dahl

commit sha 30702e2678200b6e21ba142347d2d213b86e9c6d

move js unit tests to cli/tests (#5678)

view details

Marcos Casagrande

commit sha 47b089ffa8c6dc06638b3cf0d240817a744108eb

fix: streams hwm validation (#5681)

view details

Marcos Casagrande

commit sha 11e3d70c851b0ae9f8c022810be00a26afa08d30

Remove duplicate test (#5687)

view details

Maple Miao

commit sha 9fdc6dc435b4282a0f222ae9308ab12dfde6d97e

docs: fix test glob pattern (#5661)

view details

Ryan Dahl

commit sha 6f52ad9052a02f354011d2727b2ad4a3d73b08d5

Move std/fmt/sprintf.ts to std/fmt/printf.ts (#4567)

view details

JavaScriptDude

commit sha 0f1c66cb6da7b45ff98e6eda060537ea4510a3ea

docs: update permissions docs (#5426)

view details

Chris Schepman

commit sha bebb8c029fff56f3a6e653b757583ab5c1d4b11f

docs: Update debugger.md (#5615)

view details

Bartek Iwańczuk

commit sha 5f9c1c7da6047ee8612e71f8ef4ca9c950b3a699

fix: disallow http imports for modules loaded over https (#5680)

view details

Colin Harrington

commit sha aea5b12baedd5156850fd97bf2b5085da0927b00

ci: Errors in benchmarks should fail CI (#5422)

view details

Bhumij Gupta

commit sha 88e8c32652873be1f230c31cad26e93efbfca0d6

docd: Replace obsolete Deno.homeDir() with Deno.dir('home') (#5708)

view details

Bartek Iwańczuk

commit sha f98cc34c405aefd1c46fe5c6b5e0051e1a502f64

docs: add entry for 'deno info' (#5703)

view details

skdltmxn

commit sha 49c85a2c2396d6d010296503faf0b0b8712e9cd0

feat(std/hash): add md5 (#5719)

view details

Khang Dinh

commit sha 65f4e5912293bea5c59e2923cabfa8c0373a05a7

typos (#5713)

view details

moyinzi

commit sha 8d8a2f573f32e0b2680eb114739902c5953f7b99

fix(std/http): file_server's target directory (#5695)

view details

Bartek Iwańczuk

commit sha 491feb859f30f56bc25d6afc730a1c709a0bb807

fix: --inspect flag working like --inspect-brk (#5697)

view details

David Sherret

commit sha ee710994925e8840ea387e1853d9c15f3eb73149

fix(fmt): Do not panic on new expr with no parens. (#5734) Closes #5567

view details

Bartek Iwańczuk

commit sha f9e45114b9c423b72e9c44c4a8aef90f5c3b44d6

fix: redirects handling in module analysis (#5726) This commit fixes a bug introduced in #5029 that caused bad handling of redirects during module analysis. Also ensured that duplicate modules are not downloaded.

view details

Chris Knight

commit sha 4b06e357655e5e4e1aba6d9591eeb7ca269850ed

doc: clarify and warn on Deno.read/write behaviour (#5743)

view details

Bartek Iwańczuk

commit sha e191c70989a1dbf29b095bf6c2f7b62b90de012a

fix: ts type imports (#5733)

view details

Bartek Iwańczuk

commit sha 960f9ccb2e700332dc576163b62c518120c73f15

fix: SWC lexer settings and silent errors (#5752) This commit changes how error occurring in SWC are handled. Changed lexer settings to properly handle TS decorators. Changed output of SWC error to annotate with position in file.

view details

push time in 2 months

delete branch skdltmxn/deno

delete branch : std-hash-wasm

delete time in 2 months

pull request commentdenoland/deno

feat(std/hash): reimplement all hashes in WASM

@ry All fixed!

skdltmxn

comment created time in 2 months

push eventskdltmxn/deno

skdltmxn

commit sha 10171de5966aa9dc3aa8f7ed65a2f2232372478d

feat(std/hash): reimplement all hashes in WASM

view details

push time in 2 months

pull request commentdenoland/deno

feat(std/hash): reimplement all hashes in WASM

@ry Removed Terser from WASM build script.

I'm still not sure whether it is better to include WASM project into root Cargo.toml or not since we don't have to build WASM everytime and building WASM is done using deno itself.

skdltmxn

comment created time in 2 months

push eventskdltmxn/deno

skdltmxn

commit sha 784896bc9495cc8dec2275df92d9cdd9b8568c5d

feat(std/hash): reimplement all hashes in WASM

view details

push time in 2 months

push eventskdltmxn/deno

Bartek Iwańczuk

commit sha b1893e65f20cf92585f59415eb23e709e32149b6

fix(compiler): JSX compilation and provide better error message (#6300)

view details

Kitson Kelly

commit sha 490d2a5ca1acff12ca0f47db8d654848046e3149

fix: MuxAsyncIterator throws muxed errors (#6295) Fixes #5260

view details

Dan

commit sha f7d0e39892c511208e46c4b0a3e182c2843293ae

minor grammar fix (#6299) noun -> verb

view details

Mandeep Singh

commit sha 9e8ecedfea44ee0c76a48d29e166d05ae01ec49e

docs: added autocompletion example for zsh (#6298)

view details

Peter Evers

commit sha fc850b11e5ef760278363b7a35c5a48102d919c3

unixpacket should also return byte length on send (#6291)

view details

Ryan Dahl

commit sha c54dec85760d1fe7f90a4d7e5df96fd2118d2af4

Fix DENO_DIR docs (#6271)

view details

Bartek Iwańczuk

commit sha b8872cd303584b28c0d6250184e4a1205bf2ad9b

fix(cache): apply redirection limit for cached files (#6308)

view details

skdltmxn

commit sha ed75d6c62ed3414e9d9a708d244e5aa581c0d881

feat(std/hash): reimplement all hashes in WASM

view details

skdltmxn

commit sha fa34a5f82312de67f824e6aaf4eeb8fb8b74bd9b

improve benchmark

view details

skdltmxn

commit sha 83b46a401c51914207988d8874f99e150ef72146

copy deno-hash source code into std

view details

skdltmxn

commit sha 32340c3836547318c5bc40e2e8da6ba29fb47b4f

minify

view details

skdltmxn

commit sha cb0b7a847337b8d65c85cf7c77db5a17275907cd

ignore wasm

view details

skdltmxn

commit sha 5975b663c74e5c354c76e076a5555d3fa6261f62

remove Terser from build script

view details

push time in 2 months

Pull request review commentdenoland/deno

feat(std/hash): reimplement all hashes in WASM

+// Copyright 2018-2020 the Deno authors. All rights reserved. MIT license.++import { encode as base64Encode } from "../../encoding/base64.ts";+import Terser from "https://cdn.pika.dev/terser@^4.7.0";

I will remove minifier :)

skdltmxn

comment created time in 2 months

Pull request review commentdenoland/deno

feat(std/hash): reimplement all hashes in WASM

 members = [   "deno_typescript",   "test_plugin" ]+exclude = [+  "std/hash/_wasm"+]

I thought we don't need to build wasm everytime we build deno. Do you think we have to?

skdltmxn

comment created time in 2 months

pull request commentdenoland/deno

feat(std/hash): reimplement all hashes in WASM

@ry I have copied deno-hash repo into std/hash/_wasm. Please check README for build!

skdltmxn

comment created time in 2 months

Pull request review commentdenoland/deno

feat(std/hash): reimplement all hashes in WASM

+// Copyright 2018-2020 the Deno authors. All rights reserved. MIT license.++import init, {+  source,+  create_hash as createHash,+  update_hash as updateHash,+  digest_hash as digestHash,+  DenoHash,+} from "./wasm.js";++import * as hex from "../../encoding/hex.ts";+import * as base64 from "../../encoding/base64.ts";+import { Hasher, Message, OutputFormat } from "../hasher.ts";++await init(source);++const TYPE_ERROR_MSG = "hash: `data` is invalid type";++export class Hash implements Hasher {+  #hash: DenoHash;+  #digested: boolean;++  constructor(algorithm: string) {

In architectural point of view, I think Hash class doesn't need to know about SupportedAlgorithm since it is just an interface for WASM. SupportedAlgorithm would do enough of its job for guarding algorithm for createHash defined in mod.ts.

skdltmxn

comment created time in 2 months

push eventskdltmxn/deno

skdltmxn

commit sha f8669c4214761cb2b51007c1f73d4117824c6af5

ignore wasm

view details

push time in 2 months

Pull request review commentdenoland/deno

feat(std/hash): reimplement all hashes in WASM

+// Copyright 2018-2020 the Deno authors. All rights reserved. MIT license.++import init, {+  source,+  create_hash as createHash,+  update_hash as updateHash,+  digest_hash as digestHash,+  DenoHash,+} from "./wasm.js";++import * as hex from "../../encoding/hex.ts";+import * as base64 from "../../encoding/base64.ts";+import { Hasher, Message, OutputFormat } from "../hasher.ts";++await init(source);++const TYPE_ERROR_MSG = "hash: `data` is invalid type";++export class Hash implements Hasher {+  #hash: DenoHash;+  #digested: boolean;++  constructor(algorithm: string) {

In order to use SupportedAlgorithm in hash.ts, I have to import mod.ts. But mod.ts is also importing hash.ts, so I thought it would make cycle. Do you think it would be okay?

skdltmxn

comment created time in 2 months

push eventskdltmxn/deno

skdltmxn

commit sha 657ec35d3a648a9175203709bbb35e1b4917f1a7

minify

view details

push time in 2 months

push eventskdltmxn/deno

skdltmxn

commit sha b59bab30b2c06be8d14086ac202bd52e3ffb1fc2

copy deno-hash source code into std

view details

push time in 2 months

pull request commentdenoland/deno

feat(std/hash): reimplement all hashes in WASM

@ry Sure. That's a good idea. Would it be okay to copy whole repo into std/hash/_wasm?

skdltmxn

comment created time in 2 months

pull request commentdenoland/deno

feat(std/hash): reimplement all hashes in WASM

@caspervonb Thank you for the tips! New benchmark for pure computation actually shows that WASM version is pretty fast!

10mb

Algorithm JS Rust WASM
md5 199 75 35
sha1 196 76 75
sha224 352 105 116
sha256 328 101 115
sha512 281 84 88
sha3-224 213 88 110
sha3-256 223 91 115
sha3-384 274 101 150
sha3-512 352 118 191

100mb

Algorithm JS Rust WASM
md5 1539 299 329
sha1 1819 309 721
sha224 3180 555 1120
sha256 3127 553 1151
sha512 2584 382 855
sha3-224 1794 439 1038
sha3-256 1884 453 1089
sha3-384 2337 546 1384
sha3-512 3188 721 1930
skdltmxn

comment created time in 2 months

push eventskdltmxn/deno

skdltmxn

commit sha eb8bcab946dcc9e311adfcac37b505a4a7f58fa3

improve benchmark

view details

push time in 2 months

push eventskdltmxn/deno-hash

skdltmxn

commit sha 74af20038a9f8741cc6771489c2b3798a1e50521

update

view details

push time in 2 months

pull request commentdenoland/deno

feat(std/hash): reimplement all hashes in WASM

Benchmark shows that WASM version is slower than native Rust but is faster than JS version.

10mb

Algorithm JS Rust WASM
md5 227 75 125
sha1 256 76 162
sha224 400 105 202
sha256 392 101 203
sha512 339 84 174
sha3-224 273 88 197
sha3-256 282 91 201
sha3-384 328 101 239
sha3-512 418 118 281

100mb

Algorithm JS Rust WASM
md5 1751 299 501
sha1 1961 309 904
sha224 3368 555 1301
sha256 3338 553 1298
sha512 2697 382 1026
sha3-224 1938 439 1275
sha3-256 2009 453 1338
sha3-384 2480 546 1546
sha3-512 3324 721 2250
skdltmxn

comment created time in 2 months

PR closed denoland/deno

feat(std/hash): reimplement all hashes in rust cli feat public API

This PR reimplements all hash algorithms in std/hash in rust (Rust Crypto). Also I have defined a new interface Hasher ensuring all hash algorithms have uniform API structure. I believe we should deprecate existing hashes that don't implement Hasher interface.

All supported hash algorithms are as below.

  • md2
  • md4
  • md5
  • ripemd160
  • ripemd320
  • sha1
  • sha224
  • sha256
  • sha384
  • sha512
  • sha3-224
  • sha3-256
  • sha3-384
  • sha3-512
  • keccak224
  • keccak256
  • keccak384
  • keccak512
+1365 -3

12 comments

28 changed files

skdltmxn

pr closed time in 2 months

pull request commentdenoland/deno

feat(std/hash): reimplement all hashes in rust

Closing PR in favor of #6292

skdltmxn

comment created time in 2 months

PR opened denoland/deno

feat(std/hash): reimplement all hashes in WASM

This PR is renewal of #6046. WASM implementation is at https://github.com/skdltmxn/deno-hash

+768 -41

0 comment

8 changed files

pr created time in 2 months

create barnchskdltmxn/deno-hash

branch : master

created branch time in 2 months

created repositoryskdltmxn/deno-hash

Deno hash implementation in WASM for Deno project

created time in 2 months

create barnchskdltmxn/deno

branch : std-hash-wasm

created branch time in 2 months

pull request commentdenoland/deno

feat(std/hash): reimplement all hashes in rust

@ry Can you please elaborate about WASM? I'm not clear on the best practice of using WASM in this case.

Thanks!

skdltmxn

comment created time in 2 months

pull request commentdenoland/deno

feat(std/hash): reimplement all hashes in rust

I will leave full raw data for reference

Algorithm JS-512b Rust-512b JS-1kb Rust-1kb JS-10kb Rust-10kb JS-100kb Rust-100kb JS-1mb Rust-1mb JS-10mb Rust-10mb JS-100mb Rust-100mb
md5 49 46 49 49 52 48 62 49 81 52 227 75 1751 299
sha1 49 49 50 48 59 49 68 49 85 52 256 76 1961 309
sha224 49 49 49 48 59 47 69 49 105 53 400 105 3368 555
sha256 49 49 50 49 59 49 69 49 111 55 392 101 3338 553
sha512 51 49 52 49 69 49 80 49 104 53 339 84 2697 382
sha3-224 50 47 52 49 89 48 91 49 113 52 273 88 1938 439
sha3-256 49 49 52 49 84 47 89 49 111 53 282 91 2009 453
sha3-384 51 49 52 49 85 49 88 49 111 55 328 101 2480 546
sha3-512 52 49 53 47 95 51 88 52 121 55 418 118 3324 721
skdltmxn

comment created time in 2 months

pull request commentdenoland/deno

feat(std/hash): reimplement all hashes in rust

@ry Here's comparison with JS version of hashes. I've tested by hashing files with various sizes. The values are the execution time in ms.

100kb

Algorithm JS Rust
md5 62 49
sha1 68 49
sha224 69 49
sha256 69 49
sha512 80 49
sha3-224 91 49
sha3-256 89 49
sha3-384 88 49
sha3-512 88 52

image

10mb

Algorithm JS Rust
md5 227 75
sha1 256 76
sha224 400 105
sha256 392 101
sha512 339 84
sha3-224 273 88
sha3-256 282 91
sha3-384 328 101
sha3-512 418 118

image

100mb

Algorithm JS-100mb Rust-100mb
md5 1751 299
sha1 1961 309
sha224 3368 555
sha256 3338 553
sha512 2697 382
sha3-224 1938 439
sha3-256 2009 453
sha3-384 2480 546
sha3-512 3324 721

image

skdltmxn

comment created time in 2 months

push eventskdltmxn/deno

skdltmxn

commit sha b5cb6c4ede40bcb4849a752e569a188f754f9b3a

lint

view details

push time in 2 months

push eventskdltmxn/deno

skdltmxn

commit sha 8ec69006c4c1c6a68b34565655330b8c738dfc89

feat(std/hash): reimplement all hashes in rust

view details

push time in 2 months

push eventskdltmxn/deno

Ryan Dahl

commit sha b7b6e0674f5bd6fed3e9b7ae5f32f95f1784753b

Remove unused check-only feature (#6035)

view details

Ryan Dahl

commit sha 23dc9c13db110d25df22fb9813910b8d9a278953

Fix REPL BorrowMutError panic (#6055)

view details

Szalay Kristóf

commit sha 1db98f10b804129d965daa18de6d528e592a3c0f

feat(std/testing): benching progress callback (#5941)

view details

Nayeem Rahman

commit sha aaa2ed5a6450572d90fdb3fc2f0000759599d46f

fix(std/testing/asserts): Format values in assertArrayContains() (#6060)

view details

Marcos Casagrande

commit sha a1915a0d4fd7d760c234e209967d842f851628d5

fix(fetch): Support 101 status code (#6059)

view details

timonson

commit sha 9a97e61b78fcec4ac9bb3da3e49afd0a2f849b9a

feat(std/encoding): add base64url module (#5976)

view details

Ryan Dahl

commit sha 041ccb6a0d658a7ba393b2cfe86579b2dc4945b7

Remove dead code (#6066)

view details

David Sherret

commit sha 445e44199b3ce4edb4468176a317aafdaae15517

Update to dprint 0.19.1 and swc_ecma_parser 0.24.3 (#6068)

view details

Ryan Dahl

commit sha a90d9fbd348db922c33f45af834bd3b89574b4a9

fix: dynamic import BorrowMutError (#6065)

view details

Ryan Dahl

commit sha aa39dfc62f8fc88ebb3dfb01fbc979f30557ca9a

upgrade: rusty_v8 0.5.0 (#6070)

view details

Ryan Dahl

commit sha 515d19d901e7e5dbc04670807a2bd1cea237e9e8

v1.0.5

view details

Szalay Kristóf

commit sha 4ef38bad4340b5c8100ec2522264c57f0522aa2d

docs: benchmarking (#6075)

view details

Szalay Kristóf

commit sha cab273476a4ff725d53a8e41bf3f8a90060236d4

fix(std/testing/bench): clock assertions without --allow-hrtime (#6069)

view details

Chris Knight

commit sha 1ebd33092779edc630e8f809f72bcef2656b8185

doc: complete unstable documentation and make consistent (#6074)

view details

matheus

commit sha 94bf551ead0ab5dc922cb61d13b3141896d5a8ae

fix(std/http/file_server): args handling only if invoked directly (#5989)

view details

David Sherret

commit sha fcae2fec879caf26ebe7af17b30a3bce6322b85d

Upgrade to swc_ecma_parser 0.24.5 (#6077)

view details

uki00a

commit sha 9bd5c08d5a2a9cdd2649dd24a4d6b26d9af2a4c4

feat(doc): handle detail output for enum (#6078)

view details

Nayeem Rahman

commit sha 97d876f6db55f5f32ac06155dcb4823e1c636215

fix(std/http): Don't use assert() for user input validation (#6092)

view details

Szalay Kristóf

commit sha 42a04ea08a09e29417518524cbe2245c165e6f55

refactor(std/testing/bench): Remove differentiating on runs count (#6084)

view details

Ryan Dahl

commit sha e3cc3db20fc86d9adb19bb472e8c96ae5f7c77c0

Revert "feat: format deno bundle output (#5139)" (#6085) This reverts commit 93cf3bd5341d5985201ea0905280082d5a3310f9.

view details

push time in 2 months

pull request commentdenoland/deno

feat(std/hash): reimplement all hashes in rust

@halvardssm Thank you :) I have a plan to add ciphers as well when this PR gets merged :)

skdltmxn

comment created time in 2 months

delete branch skdltmxn/deno

delete branch : std_hash_sha3

delete time in 2 months

push eventskdltmxn/deno

skdltmxn

commit sha 20ead8580bc986bbdbd97c71ee1f13b1249c212f

better error handling

view details

push time in 2 months

push eventskdltmxn/deno

skdltmxn

commit sha 93907489180e731be4960872b7adada4a0a5a30c

fix format

view details

push time in 2 months

pull request commentdenoland/deno

feat(std/hash): reimplement all hashes in rust

@ry Here's the benchmark result!

  • CPU: i7-8700
  • RAM: 32G
  • Deno 1.0.4 release
Algorithm Time
md2 292ms
md4 240ms
md5 233ms
ripemd160 237ms
ripemd320 249ms
sha1 241ms
sha224 242ms
sha256 256ms
sha384 260ms
sha512 272ms
sha3-224 252ms
sha3-256 248ms
sha3-384 263ms
sha3-512 264ms
keccak224 250ms
keccak256 250ms
keccak384 257ms
keccak512 264ms
skdltmxn

comment created time in 2 months

push eventskdltmxn/deno

skdltmxn

commit sha 7f5b6f3ab1c5cdde0f0459c6a9796ccc92387464

add hash benchmark

view details

push time in 2 months

PR opened denoland/deno

feat(std/hash): reimplement all hashes in rust

This PR reimplements all hash algorithms in std/hash in rust (Rust Crypto). Also I have defined a new interface Hasher ensuring all hash algorithms have uniform API structure. I believe we should deprecate existing hashes that don't implement Hasher interface.

All supported hash algorithms are as below.

  • md2
  • md4
  • md5
  • ripemd160
  • ripemd320
  • sha1
  • sha224
  • sha256
  • sha384
  • sha512
  • sha3-224
  • sha3-256
  • sha3-384
  • sha3-512
  • keccak224
  • keccak256
  • keccak384
  • keccak512
+1214 -3

0 comment

25 changed files

pr created time in 2 months

create barnchskdltmxn/deno

branch : std-hash

created branch time in 2 months

delete branch skdltmxn/deno

delete branch : std-encoding-base64

delete time in 2 months

PR opened denoland/deno

feat(std/encoding): add base64

This PR adds base64 encoding APIs. These APIs are actually wrappers for window.btoa and window.atob that will help users to work with binary data.

+88 -0

0 comment

2 changed files

pr created time in 2 months

create barnchskdltmxn/deno

branch : std-encoding-base64

created branch time in 2 months

push eventskdltmxn/makao

skdltmxn

commit sha d386624ce1dac530448c3a61fa59cddbb86bfe07

add kakaolink service

view details

push time in 2 months

delete branch skdltmxn/deno

delete branch : std-hash-md5

delete time in 2 months

PR opened denoland/deno

feat(std): add md5 hash

This PR implements Md5 hash. Please refer #5558 for API design rationale.

+305 -0

0 comment

2 changed files

pr created time in 2 months

create barnchskdltmxn/deno

branch : std-hash-md5

created branch time in 2 months

push eventskdltmxn/deno

Amen

commit sha 38e253e377626289538e3e59fe5af0c7e54f5bef

Add allow-read to file-server debugger example (#5282)

view details

Bartek Iwańczuk

commit sha 55d2c6bd103879263c115fa5697f3cf3101158f4

v1.0.0

view details

Manikandan Sundararajan

commit sha d397b86c6cea1517342dfa92055d8ed00c564ee1

Fix broken links to manual web page in README.md (#5284) The old link to the manual web page includes the `.html` extension but this leads to a 404. Removing the `.html` leads to the right webpage.

view details

Shohei YOSHIDA

commit sha 45ec10535a797d96571d41a3753c9db16bafc15b

docs: add 'ts' tag to code blocks in manual/examples/os_signals.md (#5297) This should enable syntax highlighting on the website.

view details

Dante Calderón

commit sha c3a205bae854edc02f10bcaa292b0e2694baabc8

Fix typos across the repo (#5295) Corrections made: * cli/js/tests/README.md:44:7: corrected "discoveres" to "discovers" * cli/js/tests/chown_test.ts:111:37: corrected "priviledge" to "privilege" * cli/worker.rs:231:56: corrected "decendants" to "descendants" * deno_typescript/lib.rs:136:50: corrected "emmited" to "emitted" * core/es_isolate.rs:492:67: corrected "registerd" to "registered" * core/isolate.rs:103:28: corrected "initalize" to "initialize" * docs/runtime.md:29:14: corrected "ect" to "etc" * docs/tools/debugger.md:122:16: corrected "implementes" to "implements" * std/encoding/_yaml/dumper/dumper_state.ts:57:63: corrected "everwhere" to "everywhere" * std/encoding/csv.ts:37:43: corrected "referal" to "referral" * std/fmt/sprintf.ts:209:20: corrected "unusuable" to "unusable" * std/fmt/README.md:21:40: corrected "Alternativly" to "Alternatively" * std/fmt/README.md:35:68: corrected "seperated" to "separated" * std/fmt/README.md:179:59: corrected "provded" to "provided" * std/mime/multipart.ts:581:46: corrected "writen" to "written" * std/path/_globrex.ts:19:52: corrected "equivelant" to "equivalent" * std/node/events_test.ts:447:9: corrected "asyncronous" to "asynchronous" * std/node/events_test.ts:475:9: corrected "asyncronous" to "asynchronous" * std/node/events_test.ts:500:29: corrected "asyncronous" to "asynchronous" * std/node/events_test.ts:530:40: corrected "asyncronous" to "asynchronous" * std/node/events_test.ts:555:9: corrected "asyncronous" to "asynchronous" * tools/deno_tcp_proxy.ts:1:42: corrected "perfromance" to "performance" * std/node/module.ts:1003:18: corrected "existend" to "existed"

view details

Peter Indiola

commit sha 21a4e9cc58aeed55cb597d2f986cca56f0aec819

Fix small typo in the docs (#5310)

view details

Kevin (Kun) "Kassimo" Qian

commit sha 7de86ab605ee94fdbce351c7f3031816c935c393

cli: don't panic on Deno.close invalid argument (#5320)

view details

Thomas Steiner

commit sha b60cde4c0a3e2a14e543ac0436c2147b43bdfb24

Avoid unfortunate ASCII arrow splitting (#5325)

view details

Marcos Casagrande

commit sha 524b1547b7c291763d6ca066ce8e10ae6398190b

std/node fs.readFile should take string as option (#5316)

view details

Bartek Iwańczuk

commit sha c474d383543708fc636c06dd2e4a9100495f45c5

std/0.51.0 (#5336)

view details

Bert Belder

commit sha 676be6632c113b61d95e9a0897c4810d63e479b2

Fix flakiness in std file_server tests (#5306) Fixes: #5275

view details

Kerollos Magdy

commit sha a2ba5a31a5ec8e011bb78baf531e29de4428b32e

Remove extra dollar sign from docs (#5361)

view details

Mike Nikles

commit sha 0cbd432dc79bb37604815746f95cb1e6bad50570

Add .css to the MEDIA_TYPES. (#5367)

view details

Evan Hahn

commit sha 6f7e74d69455869e00394628f3efd68a2e387e53

[std/node]: remove execute permissions from fs.ts (#5363)

view details

Stu Finn

commit sha 8a5068f2b433491c0ae8103016ddb8a2b4aa5351

Fix grammar (#5399)

view details

Valentin Anger

commit sha 5b76f7a838bf869872811c52c26c9ee9f01585b6

Remove debug prints introduced in e18aaf49c (#5356)

view details

André Vargas

commit sha 750a3413a0db067a83697f8e8059a2bc69bd11c6

docs: Fix typo in OS Signals example (#5413)

view details

Juan Julián Merelo Guervós

commit sha f2e431c2b07135c0deab442a60f267324882d0b8

shorten example (#5448)

view details

Anil Seervi

commit sha 3e07e0b01d91a5ea428719ca99bc732c0ee1be94

Fix typos (#5441)

view details

Chris Knight

commit sha 8c45d3a06d90bd0ab13d38b6a1f892f67e80f78e

doc: add stream api (#5418)

view details

push time in 3 months

push eventskdltmxn/deno

skdltmxn

commit sha f7cf7e2d4825702db349a5f633125af7832df361

fix import type

view details

push time in 3 months

pull request commentdenoland/deno

feat: add sha3 hash

@bartlomieju Great! Thanks :)

skdltmxn

comment created time in 3 months

push eventskdltmxn/deno

skdltmxn

commit sha 678347f24e6d15b2050209b03d0e0c96f15b1948

reset CI

view details

push time in 3 months

pull request commentdenoland/deno

feat: add sha3 hash

@kitsonk Could you take a look on the tests?

skdltmxn

comment created time in 3 months

pull request commentdenoland/deno

feat: add sha3 hash

It looks like the test is just cancelled?

skdltmxn

comment created time in 3 months

pull request commentdenoland/deno

feat: add sha3 hash

I modified surface APIs like existing SHA1 and SHA256 with some minor changes as below.

  • digest returns ArrayBuffer instead of number[]
  • removed array in favor of digest
  • removed arrayBuffer in favor of digest
  • removed hex in favor of toString
skdltmxn

comment created time in 3 months

push eventskdltmxn/deno

skdltmxn

commit sha a3151c121f64b2f9fb22dd4b2c154412975fd392

feat: add sha3 hash

view details

push time in 3 months

pull request commentdenoland/deno

feat: add sha3 hash

@kitsonk I cannot agree more with you about the APIs. I will fix my implementation to go with existing APIs.

Just minor questions though...

  1. Should there be array method when we already have digest? It just returns this.digest();. Would there be any symantic reason?
  2. Should we treat number[] when there is ArrayBuffer?
skdltmxn

comment created time in 3 months

pull request commentdenoland/deno

feat: add sha3 hash

@kitsonk The major reason I separated the implementation into different files is because SHA-3 has many variants unlike SHA1 and SHA256. I thought it would be natural to put each algorithm into its own file, Keccaks into keccak.ts, Shakes into shake.ts.

I will fix surface APIs to match Sha1 and Sha256, and apply eslint ignore code comments :)

Thank you!

skdltmxn

comment created time in 3 months

pull request commentdenoland/deno

feat: add sha3 hash

@ry Do you mean .eslintignore?

skdltmxn

comment created time in 3 months

pull request commentdenoland/deno

feat: add sha3 hash

@bartlomieju I've searched prior arts and it looks like most of them are using underscore conventions except Go which uses its unique interface.

  • Rust
use sha3::{Digest, Sha3_256};

let mut hasher = Sha3_256::new();
// ...
  • Node
import { sha3_512 } from 'js-sha3';
sha3_512('Message to hash');
  • Python
# python3.6 and up
import hashlib
h = hashlib.sha3_256()
h.update('blahblah')
skdltmxn

comment created time in 3 months

pull request commentdenoland/deno

feat: add sha3 hash

@bartlomieju yes lint is failing due to Sha3 class names e.g. Sha3-256. But I cannot come up with good alternatives to both satisfy lint and usability. Should I ignore Sha3 classes from lint?

skdltmxn

comment created time in 3 months

PR opened denoland/deno

feat: add sha3 hash

This PR implements following hash algorithms

  • SHA3-224
  • SHA3-256
  • SHA3-385
  • SHA3-512
  • Keccak-224
  • Keccak-256
  • Keccak-384
  • Keccak-512
  • SHAKE-128
  • SHAKE-256

eslint keeps complaining that SHA3 class names are not in camel case. I cannot come up with a good alternative for 'Sha3-224' and its kinds. If anyone has better idea, I will fix it.

+1520 -0

0 comment

7 changed files

pr created time in 3 months

create barnchskdltmxn/deno

branch : std_hash_sha3

created branch time in 3 months

delete branch skdltmxn/deno

delete branch : std_fnv

delete time in 3 months

PR opened denoland/deno

Add fnv hash

This PR implements fnv32/fnv32a/fnv64/fnv64a hash algorithms

+408 -0

0 comment

6 changed files

pr created time in 3 months

push eventskdltmxn/deno

skdltmxn

commit sha b475723418b158ed9da14dfe74571a543e0129d1

Add fnv hash

view details

push time in 3 months

create barnchskdltmxn/deno

branch : std_fnv

created branch time in 3 months

push eventskdltmxn/deno

Ryan Dahl

commit sha 60dfd911de693263157e28e58e4307d6eb4a3476

ci: don't fail-fast on tag build (#5189)

view details

Nayeem Rahman

commit sha e74a83a7152fc5d1f6dace1fac49062d331f1cac

fix(std/encoding/yaml): Correct exports (#5191)

view details

Bartek Iwańczuk

commit sha 0d148c6e80583dfe029d5362f61b92334a22341a

fix: remove default --allow-read perm for deno test (#5208)

view details

Bartek Iwańczuk

commit sha 32aeec9630dc91162f0408b95dd86e1c26e4c1d3

refactor: check permissions in SourceFileFetcher (#5011) This PR hot-fixes permission escapes in dynamic imports, workers and runtime compiler APIs. "permissions" parameter was added to public APIs of SourceFileFetcher and appropriate permission checks are performed during loading of local and remote files.

view details

Kitson Kelly

commit sha d16c7394cb052928d1ff9ae63cbb13811f264727

fix: Expose ErrorEvent globally (#5222)

view details

Edward Elric

commit sha b2da8f3d4e8e93d2a593f93963bc8e15d95c54d2

doc: fix typo in std/node/README.md (#4819)

view details

Ryan Dahl

commit sha fb7d7f40ed805eab5a0388f04e96224163973624

Merge std_tests.rs into integration_tests.rs.rs (#5228) * Remove usage of url_to_filename from integration_tests * Make test ports not conflict with each other

view details

Bartek Iwańczuk

commit sha a3f82c3d5ec3caad1d4ec74f49ef11adc45807d6

fix: worker benchmarks (#5227)

view details

Bert Belder

commit sha 3cccadcf0fbfc7ff4e7dd37299a65bea1cf0eab0

Change plugin interface to prevent segfaults when unloading plugin (#5210) Fixes: #3473 Closes: #5193

view details

Ryan Dahl

commit sha 73d8fa74c656841703b51bf8d52d46acf3b97cc9

BREAKING: There is no public Rust API for the CLI (#5226)

view details

Bartek Iwańczuk

commit sha d062ffc1baeccca8bf168dc1ce4e94b929478142

fix: source maps in inspector (#5223) This commit fixes problems with source maps in Chrome Devtools by substituting source map URL generated by TS compiler with actual file URL pointing to DENO_DIR. Dummy value of "source_map_url" has been removed from "ScriptOrigin". Also fixes lock file which used compiled source code to generate lock hash; it now uses source code of the file that is being compiled.

view details

Haobo Zhao

commit sha c912ffde11fc6eeb5552fce660787aa80ab2a0a9

doc: fix typo (remove redundant 'from') in first_steps.md (#5199)

view details

Lucas Machado

commit sha eec085573707d1df2bb5fbec88b9a3240613ca1f

fix(std): fix broken style guide link (#5211)

view details

Ryan Dahl

commit sha f193dde4a922131ff06f274d85351de616626704

docs: Fix style guide link (#5236)

view details

Bartek Iwańczuk

commit sha 35e8bc8de65b523e082d446dc25f114ed81264a8

v1.0.0-rc3

view details

Ryan Dahl

commit sha 593c3aa857bec2992aba7b7ec588dc031e379572

Clean up core/shared_queue.js (#5237)

view details

Bartek Iwańczuk

commit sha 053c568c8cba41ae8e296c5bc346db6e75d7816f

fix: source maps in inspector for local files (#5245) This commit changes handling of source maps by setting proper file URLs for "file" and "sources" fields in the source map.

view details

A.E Clarence

commit sha e90c95b465e361a0f06016ad0f16582e7f9a54a6

fix example of readTextFile (#5247)

view details

Bert Belder

commit sha e34a3b61f449cf6197b6d701770a85d9205c2a7b

Make --inspect-brk pause on the first line of _user_ code (#5250)

view details

Nugine

commit sha bc7817e1610faf0abe3c8629fc8163fdcb36b75f

doc: fix typo in workers.md (#5256)

view details

push time in 3 months

fork skdltmxn/v8

The official mirror of the V8 Git repository

https://chromium.googlesource.com/v8/v8.git

fork in 3 months

fork skdltmxn/deno

A secure JavaScript and TypeScript runtime

https://deno.land/

fork in 3 months

more