profile
viewpoint
TJ Miller sixlive @sixlabs @internationalbancard Metro Detroit https://www.tjmiller.me Full stack capable, backend developer. 💚 Laravel, Vue, React, Docker, Node

startedspatie/laravel-resource-links

started time in 6 days

issue commenthoneybadger-io/honeybadger-php

Bump monolog to 1.25

There was some reason by it was pinned to 1.24 can't recall why though. Will check it out.

stympy

comment created time in 14 days

created taghoneybadger-io/honeybadger-laravel

tagv2.0.1

PHP/Laravel library for reporting errors to Honeybadger.io :elephant: :zap:

created time in 15 days

release honeybadger-io/honeybadger-laravel

v2.0.1

released time in 15 days

create barnchsixlive/honeybadger-laravel

branch : 1.x

created branch time in 15 days

push eventhoneybadger-io/honeybadger-laravel

sixlive

commit sha 0f3dadd7f993868d64b636214029a19ad359ea10

Version

view details

push time in 15 days

push eventhoneybadger-io/honeybadger-laravel

TJ Miller

commit sha 2efe2320e259a026ea6d3bf0aa5961877976e711

Fix route action for lumen (#42)

view details

push time in 15 days

PR merged honeybadger-io/honeybadger-laravel

Fix route action for lumen

Description

Fixes route action and component for Lumen.

Needs to be back ported to 1.x with a patch as well as 6.0.x

Resolves https://github.com/honeybadger-io/honeybadger-laravel/issues/39

Todos

  • [ ] Tests
  • [ ] Documentation
  • [ ] Changelog Entry (unreleased)

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.

> git pull --prune
> git checkout <branch>
> vendor/bin/phpunit
+41 -6

0 comment

3 changed files

sixlive

pr closed time in 15 days

issue closedhoneybadger-io/honeybadger-laravel

Call to undefined method Laravel\Lumen\Routing\Router::getCurrentRoute()

What are the steps to reproduce this issue?

  1. Install Lumen 6 app
  2. Enable Lumen integration with Identifying Users
  3. Visit any route

What happens?

[2019-09-19 09:12:54] local.ERROR: Symfony\Component\Debug\Exception\FatalThrowableError: Call to undefined method Laravel\Lumen\Routing\Router::getCurrentRoute() in /var/www/vendor/illuminate/support/Facades/Facade.php:239
Stack trace:
#0 /var/www/vendor/honeybadger-io/honeybadger-laravel/src/Middleware/HoneybadgerContext.php(43): Illuminate\Support\Facades\Facade::__callStatic('getCurrentRoute', Array)
#1 /var/www/vendor/honeybadger-io/honeybadger-laravel/src/Middleware/HoneybadgerContext.php(35): Honeybadger\HoneybadgerLaravel\Middleware\HoneybadgerContext->setRouteActionContext()
#2 /var/www/vendor/illuminate/pipeline/Pipeline.php(171): Honeybadger\HoneybadgerLaravel\Middleware\HoneybadgerContext->handle(Object(Laravel\Lumen\Http\Request), Object(Closure))
#3 [internal function]: Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Laravel\Lumen\Http\Request))
#4 /var/www/vendor/laravel/lumen-framework/src/Routing/Pipeline.php(32): call_user_func(Object(Closure), Object(Laravel\Lumen\Http\Request))
#5 /var/www/vendor/illuminate/pipeline/Pipeline.php(105): Laravel\Lumen\Routing\Pipeline->Laravel\Lumen\Routing\{closure}(Object(Laravel\Lumen\Http\Request))
#6 /var/www/vendor/laravel/lumen-framework/src/Concerns/RoutesRequests.php(413): Illuminate\Pipeline\Pipeline->then(Object(Closure))
#7 /var/www/vendor/laravel/lumen-framework/src/Concerns/RoutesRequests.php(171): Laravel\Lumen\Application->sendThroughPipeline(Array, Object(Closure))
#8 /var/www/vendor/laravel/lumen-framework/src/Concerns/RoutesRequests.php(108): Laravel\Lumen\Application->dispatch(NULL)
#9 /var/www/public/index.php(28): Laravel\Lumen\Application->run()
#10 {main} {"exception":"[object] (Symfony\\Component\\Debug\\Exception\\FatalThrowableError(code: 0): Call to undefined method Laravel\\Lumen\\Routing\\Router::getCurrentRoute() at /var/www/vendor/illuminate/support/Facades/Facade.php:239)

What were you expecting to happen?

No exception

Any other comments?

Looks like Lumen is using nikic/fast-route package and not Illuminate one. I made quick three changes in HoneybadgerContext class:

  • Pass $request variable to setRouteActionContext() function,
  • Route::getCurrentRoute() -> app()->router->getRoutes()[$request->method() . $request->getPathInfo()],
  • Route::getCurrentRoute()->getActionName() -> app()->router->getRoutes()[$request->method() . $request->getPathInfo()]['action']['uses']

And then it's working. What would be perfect solution for this problem?

  1. Create new Middleware for Lumen with above changes?
  2. Somehow detect if a user is using Laravel or Lumen integration and use the correct function?

What versions are you using?

Package Version: 1.7.2

closed time in 15 days

pjona

Pull request review commenthoneybadger-io/honeybadger-laravel

Fix route action for lumen

 private function setRouteActionContext()      private function setUserContext($request)     {-        if ($request->user()) {-            $this->honeybadger->context(-                'user_id',-                $request->user()->getAuthIdentifier()-            );+        try {+            if ($request->user()) {+                $this->honeybadger->context(+                    'user_id',+                    $request->user()->getAuthIdentifier()+                );+            }+        } catch (\InvalidArgumentException $e) {+            // swallow

This helps avoid issues in Lumen where the auth driver and service provider are not registered by default.

sixlive

comment created time in 15 days

push eventsixlive/honeybadger-laravel

sixlive

commit sha 0d4e38c6b8403666104caba9e6f3e2229ffe0cfd

wip

view details

push time in 16 days

push eventsixlive/honeybadger-laravel

sixlive

commit sha 8a2662c7c4fc88893e0fff610fbc00f6e468a5ba

wip

view details

push time in 16 days

push eventsixlive/honeybadger-laravel

sixlive

commit sha bad1c42bf2a0c755afff824227c2034e5ef619b4

Swallow exception when user guards aren't defined

view details

push time in 16 days

push eventsixlive/honeybadger-laravel

sixlive

commit sha 411784c78544ce8a6a8adf7c27e55fa1af6f7804

Patches through testing

view details

push time in 16 days

push eventsixlive/honeybadger-laravel

sixlive

commit sha 356e373b66491dd0cb6c1fed1efb5dd16dd1db06

Styles

view details

push time in 17 days

push eventsixlive/honeybadger-laravel

sixlive

commit sha 44633d9621137f01371dcae1abf5ce97b89aff89

Styles

view details

push time in 17 days

startedaungwinthant/apilogger

started time in 19 days

issue commenthoneybadger-io/honeybadger-php

Reporting an exception fails because of recursive reference in the payload

I do like your suggestion with JSON_PARTIAL_OUTPUT_ON_ERROR but I would also like to see if we can get to the root of the issue and wotk around/with what is attempting to get encoded.

bgraf-zlab

comment created time in 22 days

issue commenthoneybadger-io/honeybadger-php

Reporting an exception fails because of recursive reference in the payload

Is there any additional context you can provide that led up to the error? This would help me figure out what JSON is attempted to be encoded.

bgraf-zlab

comment created time in 22 days

issue commenthoneybadger-io/honeybadger-laravel

Call to undefined method Laravel\Lumen\Routing\Router::getCurrentRoute()

Tracking https://github.com/honeybadger-io/honeybadger-laravel/pull/42 for this fix. Just want to do some more testing. Will cut a patch for it today.

pjona

comment created time in 24 days

PR opened honeybadger-io/honeybadger-laravel

Fix route action for lumen

Description

Fixes route action and component for Lumen.

Needs to be back ported to 1.x with a patch as well as 6.0.x)

Resolves https://github.com/honeybadger-io/honeybadger-laravel/issues/39

Todos

  • [ ] Tests
  • [ ] Documentation
  • [ ] Changelog Entry (unreleased)

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.

> git pull --prune
> git checkout <branch>
> vendor/bin/phpunit
+24 -1

0 comment

2 changed files

pr created time in 24 days

push eventsixlive/honeybadger-laravel

sixlive

commit sha d2578d33326f6db70733a1cfe813f1b68e920b48

wip

view details

push time in 24 days

create barnchsixlive/honeybadger-laravel

branch : fix-route-action-for-lumen

created branch time in 24 days

issue closedhoneybadger-io/honeybadger-laravel

Fix Laravel 6 monolog support

Installation fails with Laravel 6.

$ composer require honeybadger-io/honeybadger-laravel
Using version ^1.7 for honeybadger-io/honeybadger-laravel
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for monolog/monolog (locked at 2.0.0) -> satisfiable by monolog/monolog[2.0.0].
    - honeybadger-io/honeybadger-laravel v1.7.0 requires honeybadger-io/honeybadger-php ^1.7 -> satisfiable by honeybadger-io/honeybadger-php[v1.7.0].
    - honeybadger-io/honeybadger-laravel v1.7.1 requires honeybadger-io/honeybadger-php ^1.7 -> satisfiable by honeybadger-io/honeybadger-php[v1.7.0].
    - honeybadger-io/honeybadger-laravel v1.7.2 requires honeybadger-io/honeybadger-php ^1.7 -> satisfiable by honeybadger-io/honeybadger-php[v1.7.0].
    - Conclusion: don't install honeybadger-io/honeybadger-php v1.7.0
    - Installation request for honeybadger-io/honeybadger-laravel ^1.7 -> satisfiable by honeybadger-io/honeybadger-laravel[v1.7.0, v1.7.1, v1.7.2].


Installation failed, reverting ./composer.json to its original content.

closed time in 24 days

wassim

issue commenthoneybadger-io/honeybadger-laravel

Fix Laravel 6 monolog support

Support for Laravel 6 and monolog 2 has been added in release 2.0 https://github.com/honeybadger-io/honeybadger-laravel/releases/tag/v2.0.0

wassim

comment created time in 24 days

created taghoneybadger-io/honeybadger-laravel

tagv2.0.0

PHP/Laravel library for reporting errors to Honeybadger.io :elephant: :zap:

created time in 24 days

release honeybadger-io/honeybadger-laravel

v2.0.0

released time in 24 days

push eventhoneybadger-io/honeybadger-laravel

sixlive

commit sha cf8fe50088a08dc9b4b754fcc03d1ed387da0496

Version

view details

push time in 24 days

create barnchhoneybadger-io/honeybadger-laravel

branch : 1.x

created branch time in 24 days

created taghoneybadger-io/honeybadger-laravel

tagv1.7.3

PHP/Laravel library for reporting errors to Honeybadger.io :elephant: :zap:

created time in 24 days

release honeybadger-io/honeybadger-laravel

v1.7.3

released time in 24 days

delete branch sixlive/honeybadger-laravel

delete branch : version-two-base-changes

delete time in 24 days

PR merged honeybadger-io/honeybadger-laravel

Version two base changes

Description

Version 2 base changes

  • Update dependency minimum version
    • Laravel/Illuminate
    • Honeybadger PHP
  • Removed support for PHP 7.1
  • Removed support for Laravel/Illuminate 5.x
  • Update Travis config to reflect new support

Related PRs

Depends on

  • https://github.com/honeybadger-io/honeybadger-laravel/pull/40
  • https://github.com/honeybadger-io/honeybadger-php/pull/91

Todos

  • [x] Tests
  • [ ] Documentation
  • [x] Changelog Entry (unreleased)

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.

> git pull --prune
> git checkout <branch>
> vendor/bin/phpunit
+9 -23

1 comment

2 changed files

sixlive

pr closed time in 24 days

push eventhoneybadger-io/honeybadger-laravel

TJ Miller

commit sha 7742671ec38f2f6452b4fe0a349ba1d8af39b4e5

Version 2 base changes (#41) - Update dependency minimum version - Laravel/Illuminate - Honeybadger PHP - Removed support for PHP 7.1 - Removed support for Laravel/Illuminate 5.x - Update Travis config to reflect new support

view details

push time in 24 days

push eventsixlive/honeybadger-laravel

TJ Miller

commit sha e084eda97051341808095447c1560377b01c3086

Remove Laravel 6 Support (#40) Laravel 6 has a minimum version for Monolog which is incompatible with honeybadger-io/honeybadger-php. This library will need to utilize honeybadger-php:^2.0 to allow support for Laravel 6.

view details

sixlive

commit sha 97c4ddbd2eede1aeabb8134219632192756787f6

Version 2 base changes - Update dependency minimum version - Laravel/Illuminate - Honeybadger PHP - Removed support for PHP 7.1 - Removed support for Laravel/Illuminate 5.x - Update Travis config to reflect new support

view details

push time in 24 days

push eventhoneybadger-io/honeybadger-laravel

TJ Miller

commit sha e084eda97051341808095447c1560377b01c3086

Remove Laravel 6 Support (#40) Laravel 6 has a minimum version for Monolog which is incompatible with honeybadger-io/honeybadger-php. This library will need to utilize honeybadger-php:^2.0 to allow support for Laravel 6.

view details

push time in 25 days

PR merged honeybadger-io/honeybadger-laravel

Remove Laravel 6 Support

Description

Laravel 6 has a minimum version for Monolog which is incompatible with honeybadger-io/honeybadger-php. This library will need to utilize honeybadger-php:^2.0 to allow support for Laravel 6.

Related PRs

List related PRs against other branches:

  • https://github.com/honeybadger-io/honeybadger-php/pull/91

Todos

  • [ ] Tests
  • [ ] Documentation
  • [ ] Changelog Entry (unreleased)

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.

> git pull --prune
> git checkout <branch>
> vendor/bin/phpunit
+4 -5

0 comment

3 changed files

sixlive

pr closed time in 25 days

create barnchhoneybadger-io/honeybadger-php

branch : 1.x

created branch time in 25 days

created taghoneybadger-io/honeybadger-php

tagv2.0.0

PHP library for reporting errors to Honeybadger.io :elephant: :zap:

created time in 25 days

release honeybadger-io/honeybadger-php

v2.0.0

released time in 25 days

push eventhoneybadger-io/honeybadger-php

sixlive

commit sha f42b86e105a9ec82418a1521e203779ec4e63819

Version

view details

push time in 25 days

delete branch sixlive/honeybadger-php

delete branch : update-monolog-support

delete time in 25 days

push eventhoneybadger-io/honeybadger-php

TJ Miller

commit sha 45595fdc2982db39b3ca35b92170e84125ddc330

Update monolog support (#91) * Update monolog 2.0 * Remove PHP 7.1 support

view details

push time in 25 days

PR merged honeybadger-io/honeybadger-php

Update monolog support

Description

Updates monolog support for monolog@2.0. Fixes issues related to Laravel 6 (https://github.com/honeybadger-io/honeybadger-laravel/issues/38). Removes support for PHP 7.1

Todos

  • [x] Tests
  • [ ] Documentation
  • [ ] Changelog Entry (unreleased)

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.

> git pull --prune
> git checkout <branch>
> vendor/bin/phpunit
+8 -6

3 comments

5 changed files

sixlive

pr closed time in 25 days

PR opened honeybadger-io/honeybadger-laravel

Version two base changes

Description

Version 2 base changes

  • Update dependency minimum version
    • Laravel/Illuminate
    • Honeybadger PHP
  • Removed support for PHP 7.1
  • Removed support for Laravel/Illuminate 5.x
  • Update Travis config to reflect new support

Related PRs

Depends on

  • https://github.com/honeybadger-io/honeybadger-laravel/pull/40
  • https://github.com/honeybadger-io/honeybadger-php/pull/91

Todos

  • [x] Tests
  • [ ] Documentation
  • [x] Changelog Entry (unreleased)

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.

> git pull --prune
> git checkout <branch>
> vendor/bin/phpunit
+10 -25

0 comment

3 changed files

pr created time in a month

create barnchsixlive/honeybadger-laravel

branch : version-two-base-changes

created branch time in a month

push eventsixlive/honeybadger-php

sixlive

commit sha 843173b06f63f8af4aff98d53b7b4d364946cbdc

wip

view details

push time in a month

PR opened honeybadger-io/honeybadger-laravel

Remove Laravel 6 Support

Description

Laravel 6 has a minimum version for Monolog which is incompatible with honeybadger-io/honeybadger-php. This library will need to utilize honeybadger-php:^2.0 to allow support for Laravel 6.

Related PRs

List related PRs against other branches:

  • https://github.com/honeybadger-io/honeybadger-php/pull/91

Todos

  • [ ] Tests
  • [ ] Documentation
  • [ ] Changelog Entry (unreleased)

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.

> git pull --prune
> git checkout <branch>
> vendor/bin/phpunit
+4 -5

0 comment

3 changed files

pr created time in a month

create barnchsixlive/honeybadger-laravel

branch : drop-laravel-six-support

created branch time in a month

push eventsixlive/honeybadger-php

sixlive

commit sha 3a7cd5c792adad341689fdbbfc577e4fefce942d

wip

view details

push time in a month

push eventsixlive/honeybadger-php

sixlive

commit sha f8726a3bbe9d4ae22d6395d5d844c019c45d41c3

wip

view details

push time in a month

issue commenthoneybadger-io/honeybadger-laravel

Call to undefined method Laravel\Lumen\Routing\Router::getCurrentRoute()

Thank you for the thorough report. I will address this today.

pjona

comment created time in a month

pull request commenthoneybadger-io/honeybadger-php

Update monolog support

OK, cool. I need to work through version implications with the laravel package and versions over there.

sixlive

comment created time in a month

pull request commenthoneybadger-io/honeybadger-php

Update monolog support

Working out this one, trying to find a way to keep backward support but I'm not sure if I can.

sixlive

comment created time in a month

issue commenthoneybadger-io/honeybadger-php

Undefined index: args, line 93 BacktraceFactory.php

Tagged in https://github.com/honeybadger-io/honeybadger-php/releases/tag/v1.7.1

drbyte

comment created time in a month

release honeybadger-io/honeybadger-php

v1.7.1

released time in a month

created taghoneybadger-io/honeybadger-php

tagv1.7.1

PHP library for reporting errors to Honeybadger.io :elephant: :zap:

created time in a month

push eventhoneybadger-io/honeybadger-php

sixlive

commit sha be829b9934401dd7252df2ebd745aad06fc5d1fe

Fixed typos in changelog

view details

push time in a month

push eventhoneybadger-io/honeybadger-php

sixlive

commit sha 8694b5567fe7add127dadec0842a0e2aef10edd5

Version

view details

push time in a month

delete branch sixlive/honeybadger-php

delete branch : fix-backtrace-factory-without-args

delete time in a month

push eventhoneybadger-io/honeybadger-php

TJ Miller

commit sha 2615ab953a3e9491f1ef699428e8594676034d20

Default args to an empty array (#92)

view details

push time in a month

PR merged honeybadger-io/honeybadger-php

Default args to an empty array

Description

Default backtrace args to an empty array if not defined.

Fixes #90

Todos

  • [x] Tests
  • [ ] Documentation
  • [ ] Changelog Entry (unreleased)

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.

> git pull --prune
> git checkout <branch>
> vendor/bin/phpunit
+1 -1

0 comment

1 changed file

sixlive

pr closed time in a month

issue closedhoneybadger-io/honeybadger-php

Undefined index: args, line 93 BacktraceFactory.php

Missing arg parameter throws error:

"Undefined index: args", "/vendor/honeybadger-io/honeybadger-php/src/BacktraceFactory.php", 93

Found during Laravel Forge deployments since updating to honeybadger-laravel 1.7.2 Seems to be related to calling artisan commands, although I haven't been able to narrow it to one specifically.

Ref: https://github.com/honeybadger-io/honeybadger-php/pull/89#discussion_r322827823 Ref: Faults 54680936 and 54680937

Package versions: honeybadger-io/honeybadger-laravel v1.7.2 honeybadger-io/honeybadger-php v1.7.0

closed time in a month

drbyte

PR opened honeybadger-io/honeybadger-php

Default args to an empty array

Description

Default backtrace args to an empty array if not defined.

Fixes #90

Todos

  • [x] Tests
  • [ ] Documentation
  • [ ] Changelog Entry (unreleased)

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.

> git pull --prune
> git checkout <branch>
> vendor/bin/phpunit
+1 -1

0 comment

1 changed file

pr created time in a month

create barnchsixlive/honeybadger-php

branch : fix-backtrace-factory-without-args

created branch time in a month

push eventsixlive/honeybadger-php

sixlive

commit sha 50f59fdb9125297261a3686e8bb8b45b0a8dc521

wip

view details

push time in a month

issue commenthoneybadger-io/honeybadger-laravel

Fix Laravel 6 monolog support

Going to be trackign https://github.com/honeybadger-io/honeybadger-php/pull/91 for this fix. Will continue progress later today/tomorrow morning.

wassim

comment created time in a month

PR opened honeybadger-io/honeybadger-php

Update monolog support

Description

Updates monolog support for monolog@2.0. Fixes issues related to Laravel 6 (https://github.com/honeybadger-io/honeybadger-laravel/issues/38)

Todos

  • [x] Tests
  • [ ] Documentation
  • [ ] Changelog Entry (unreleased)

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.

> git pull --prune
> git checkout <branch>
> vendor/bin/phpunit
+4 -4

0 comment

3 changed files

pr created time in a month

create barnchsixlive/honeybadger-php

branch : update-monolog-support

created branch time in a month

issue commenthoneybadger-io/honeybadger-laravel

Add Laravel 6 support

Hmm, I think this is actually an issue back to the php lib. I'll look at it tonight. – https://github.com/honeybadger-io/honeybadger-php/blob/master/composer.json#L26

wassim

comment created time in a month

issue commenthoneybadger-io/honeybadger-php

Undefined index: args, line 93 BacktraceFactory.php

Thanks!! Like I said, I'll path this later today

drbyte

comment created time in a month

Pull request review commenthoneybadger-io/honeybadger-php

Change backtrace arguments to use class name rather than full object

 private function formatBacktrace(array $backtrace) : array              return array_merge($context, [                 'method' => $frame['function'] ?? null,-                'args' => $frame['args'] ?? null,

I'll push a patch today, could you open an issue for it?

sixlive

comment created time in a month

PR opened usefathom/fathom

Update README.md

Remove broken link to DO docs removed in https://github.com/usefathom/fathom/commit/b683d5606c144ab20b0369987de14d57319a09d7

+0 -1

0 comment

1 changed file

pr created time in a month

push eventsixlive/fathom

TJ Miller

commit sha 361b301a2b30b3459d68023a0bbd4be2b324efeb

Update README.md Remove broken link to DO docs removed in https://github.com/usefathom/fathom/commit/b683d5606c144ab20b0369987de14d57319a09d7

view details

push time in a month

fork sixlive/fathom

Fathom. Simple, privacy-focused website analytics. Built with Golang & Preact.

https://usefathom.com/

fork in a month

created taghoneybadger-io/honeybadger-laravel

tagv1.7.2

PHP/Laravel library for reporting errors to Honeybadger.io :elephant: :zap:

created time in a month

release honeybadger-io/honeybadger-laravel

v1.7.2

released time in a month

push eventhoneybadger-io/honeybadger-laravel

sixlive

commit sha 2b5209a7df12bf09393174cc663146e5ad516d2a

Version

view details

push time in a month

delete branch sixlive/honeybadger-laravel

delete branch : fix-component-without-action

delete time in a month

push eventhoneybadger-io/honeybadger-laravel

TJ Miller

commit sha 913a03979542afcd86039e0568a309e324022a33

Fix component without action (#37) * Fixes an issue with the context middleware We needed to split up the checks for the component and the action. Laravel will set the component to 'Closure' for closure routes and will send the controller name for invokables.

view details

push time in a month

PR merged honeybadger-io/honeybadger-laravel

Fix component without action

Description

We needed to split up the checks for the component and the action. Laravel will set the component to 'Closure' for closure routes and will send the controller name for invokables.

Resolves #36

Todos

  • [x] Tests
  • [ ] Documentation
  • [x] Changelog Entry (unreleased)

Steps to Test or Reproduce

> git pull --prune
> git checkout <branch>
> vendor/bin/phpunit
+48 -6

0 comment

5 changed files

sixlive

pr closed time in a month

issue closedhoneybadger-io/honeybadger-laravel

Undefined offset: 1 in HoneybadgerContext.php line 46

New error, after updating to 1.7.1

HoneybadgerContext.php  46 handleError(8, "Undefined offset: 1", 
"/vendor/honeybadger-io/honeybadger-laravel/src/Middleware/HoneybadgerContext.php", 46)

See rest of context in #34 and https://github.com/honeybadger-io/honeybadger-laravel/pull/35/files#r321220902

closed time in a month

drbyte

push eventsixlive/honeybadger-laravel

sixlive

commit sha 120a123bd2ee8a871b7b5a4263f9cdc977267460

wip

view details

push time in a month

issue commenthoneybadger-io/honeybadger-laravel

Undefined offset: 1 in HoneybadgerContext.php line 46

Have a fix here https://github.com/honeybadger-io/honeybadger-laravel/pull/37. Waiting on CI, will tag shortly

drbyte

comment created time in a month

PR opened honeybadger-io/honeybadger-laravel

Fix component without action

Description

We needed to split up the checks for the component and the action. Laravel will set the component to 'Closure' for closure routes and will send the controller name for invokables.

Resolves #36

Todos

  • [x] Tests
  • [ ] Documentation
  • [x] Changelog Entry (unreleased)

Steps to Test or Reproduce

> git pull --prune
> git checkout <branch>
> vendor/bin/phpunit
+48 -6

0 comment

5 changed files

pr created time in a month

push eventsixlive/honeybadger-laravel

sixlive

commit sha 6f97c4867e7f012a6a3cb3a33978371edc5b8a54

wip

view details

push time in a month

create barnchsixlive/honeybadger-laravel

branch : fix-component-without-action

created branch time in a month

issue commenthoneybadger-io/honeybadger-laravel

Undefined offset: 1 in HoneybadgerContext.php line 46

I was assuming that was a problem. I'm about to push the patch

drbyte

comment created time in a month

issue commenthoneybadger-io/honeybadger-laravel

Undefined offset: 1 in HoneybadgerContext.php line 46

UGH. Give me an hour

drbyte

comment created time in a month

issue commenthoneybadger-io/honeybadger-laravel

Argument 1 passed to Honeybadger\Honeybadger::setAction() must be of the type string, null given

@drbyte @jessarcher gosh, really sorry about this one shouldn't have happened. Just tagged the fix in 1.7.1

drbyte

comment created time in a month

created taghoneybadger-io/honeybadger-laravel

tagv1.7.1

PHP/Laravel library for reporting errors to Honeybadger.io :elephant: :zap:

created time in a month

release honeybadger-io/honeybadger-laravel

v1.7.1

released time in a month

push eventsixlive/honeybadger-laravel

TJ Miller

commit sha db67b5ddb1122b22174b717476cb5ddd6d3a1412

Add a check to ensure component and action are set (#35) * Add a check to ensure context and action are set

view details

sixlive

commit sha d9e29e7519f6062e5a39461eaa1e3b3d9cbd7118

Version

view details

push time in a month

push eventhoneybadger-io/honeybadger-laravel

TJ Miller

commit sha db67b5ddb1122b22174b717476cb5ddd6d3a1412

Add a check to ensure component and action are set (#35) * Add a check to ensure context and action are set

view details

push time in a month

PR merged honeybadger-io/honeybadger-laravel

Add a check to ensure component and action are set

Description

Fixes an issue introduced with 1.7.0 with request component and action. This ensures that they are present before attempting to set them. Defaults to string if it slips through per the contract.

Resolves https://github.com/honeybadger-io/honeybadger-laravel/issues/34

Todos

  • [x] Tests
  • [ ] Documentation
  • [x] Changelog Entry (unreleased)

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.

> git pull --prune
> git checkout <branch>
> vendor/bin/phpunit
+64 -2

0 comment

4 changed files

sixlive

pr closed time in a month

issue closedhoneybadger-io/honeybadger-laravel

Argument 1 passed to Honeybadger\Honeybadger::setAction() must be of the type string, null given

What are the steps to reproduce this issue?

  1. Install 1.7.0 of this package, on Laravel 5.8.35
  2. Visit a bad URL on the site

What happens?

500 error, and log message:

Argument 1 passed to Honeybadger\Honeybadger::setAction() 
must be of the type string, null given, 
called in /vendor/honeybadger-io/honeybadger-laravel/src/Middleware/HoneybadgerContext.php
 on line 47

What versions are you using?

Package Version: 1.7.0

Seems to be related to https://github.com/honeybadger-io/honeybadger-laravel/pull/31

closed time in a month

drbyte

issue commenthoneybadger-io/honeybadger-laravel

Argument 1 passed to Honeybadger\Honeybadger::setAction() must be of the type string, null given

Just opened #35 to resolve this issue. Will tag as soon as CI is complete.

drbyte

comment created time in a month

PR opened honeybadger-io/honeybadger-laravel

Add a check to ensure component and action are set

Description

Fixes an issue introduced with 1.7.0 with request component and action. This ensures that they are present before attempting to set them. Defaults to string if it slips through per the contract.

Todos

  • [x] Tests
  • [ ] Documentation
  • [x] Changelog Entry (unreleased)

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.

> git pull --prune
> git checkout <branch>
> vendor/bin/phpunit
+64 -2

0 comment

4 changed files

pr created time in a month

push eventsixlive/honeybadger-laravel

sixlive

commit sha 8d79accd1db9159a4500015b9e8199ff331d8609

wip

view details

push time in a month

create barnchsixlive/honeybadger-laravel

branch : fix-context-action

created branch time in a month

more