profile
viewpoint
Sindre Sorhus sindresorhus https://sindresorhus.com Full-Time Open-Sourcerer. Wants more empathy & kindness in open source. Focuses on Swift & JavaScript. Makes macOS apps, CLI tools, npm packages. Likes unicorns

addyosmani/critical 8665

Extract & Inline Critical-path CSS in HTML pages

addyosmani/a11y 1657

Accessibility audit tooling for the web (beta)

addyosmani/tmi 1654

TMI (Too Many Images) - discover your image weight on the web

bcoe/awesome-cross-platform-nodejs 880

:two_men_holding_hands: A curated list of awesome developer tools for writing cross-platform Node.js code

avajs/ava-docs 447

Localized docs for AVA

avajs/awesome-ava 318

Awesome AVA resources

fregante/github-issue-link-status 242

Colorize issue and PR links to see their status (open, closed, merged)

avajs/eslint-plugin-ava 207

ESLint rules for AVA

download-directory/download-directory.github.io 153

Web App: Download just a sub directory from a GitHub repo.

fregante/delegate-it 153

DOM event delegation, in <1KB

Pull request review commentsindresorhus/np

Show files added since the last release and not part of the package

 Host *  If you're running into other issues when using SSH, please consult [GitHub's support article](https://help.github.com/articles/connecting-to-github-with-ssh/). +### Ignore strategy+The [ignore strategy](https://docs.npmjs.com/files/package.json#files) either maintained in the `files`-property (`package.json`) or in the `.npmignore`-file should minify your packages.

"minify" means something else. It's more about "reducing" the size of the package.

bunysae

comment created time in 2 hours

Pull request review commentsindresorhus/np

Show files added since the last release and not part of the package

 Host *  If you're running into other issues when using SSH, please consult [GitHub's support article](https://help.github.com/articles/connecting-to-github-with-ssh/). +### Ignore strategy+The [ignore strategy](https://docs.npmjs.com/files/package.json#files) either maintained in the `files`-property (`package.json`) or in the `.npmignore`-file should minify your packages.+To ensure package consistency `np` reports all new files added to git, which are not published. Test files and other [obvious stuff](https://docs.npmjs.com/files/package.json#files) isn't considered.

We don't show new files to ensure package consistency. We show them to prevent publishing a broken package.

bunysae

comment created time in 2 hours

Pull request review commentsindresorhus/np

Show files added since the last release and not part of the package

 Host *  If you're running into other issues when using SSH, please consult [GitHub's support article](https://help.github.com/articles/connecting-to-github-with-ssh/). +### Ignore strategy
### Ignore strategy

bunysae

comment created time in 2 hours

Pull request review commentsindresorhus/np

Show files added since the last release and not part of the package

 Host *  If you're running into other issues when using SSH, please consult [GitHub's support article](https://help.github.com/articles/connecting-to-github-with-ssh/). +### Ignore strategy+The [ignore strategy](https://docs.npmjs.com/files/package.json#files) either maintained in the `files`-property (`package.json`) or in the `.npmignore`-file should minify your packages.+To ensure package consistency `np` reports all new files added to git, which are not published. Test files and other [obvious stuff](https://docs.npmjs.com/files/package.json#files) isn't considered.+`np` assumes either a standard directory layout or a customized layout depict in the `directories` property (`package.json`).

I still don't think this text is good enough. Also, please run text through something like https://app.grammarly.com/.

bunysae

comment created time in 2 hours

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentsindresorhus/map-obj

map-obj deep only for certain keys

The readme docs should also be in sync with the index.d.ts docs.

I meant this literally. Everything in the readme docs should be in the TS type file, including examples.

fohletex

comment created time in 2 hours

Pull request review commentsindresorhus/map-obj

map-obj deep only for certain keys

 Type: `object`  ##### deep -Type: `boolean`<br>+Type: `boolean | Function`<br> Default: `false` -Recurse nested objects and objects in arrays.+Recursing behaviour for nested objects and objects in arrays++Deep Value can be boolean:++- If `true`, it recurses all nested objects and objects in arrays.++Or a `DeepKeyFilter` function which has the following properties:++- It has signature `deepKeyFilter(sourceKey: string)`.

The signature does not have a name.

fohletex

comment created time in 2 hours

Pull request review commentsindresorhus/map-obj

map-obj deep only for certain keys

 Type: `object`  ##### deep -Type: `boolean`<br>+Type: `boolean | Function`<br> Default: `false` -Recurse nested objects and objects in arrays.+Recursing behaviour for nested objects and objects in arrays++Deep Value can be boolean:++- If `true`, it recurses all nested objects and objects in arrays.++Or a `DeepKeyFilter` function which has the following properties:++- It has signature `deepKeyFilter(sourceKey: string)`.+- It must return a `boolean`. Returning `true` states the value related to the currently iterated `sourceKey`+    shall be recursed if it is a nested object, false otherwise.+

I still think the above text could be written more succinctly.

fohletex

comment created time in 2 hours

Pull request review commentsindresorhus/map-obj

map-obj deep only for certain keys

 declare namespace mapObject {+	/**+	Function which can be optionally used to indicate by returning true, if the value related to the given+	 	`sourceKey` shall be recursed (in case it is a nested object), false otherwise.+	*/+	type DeepKeyFilter = (sourceKey: string) => boolean;
	type DeepKeyFilter = (objectKey: string) => boolean;
fohletex

comment created time in 2 hours

Pull request review commentsindresorhus/map-obj

map-obj deep only for certain keys

 Type: `object`  ##### deep -Type: `boolean`<br>+Type: `boolean | Function`<br> Default: `false` -Recurse nested objects and objects in arrays.+Recursing behaviour for nested objects and objects in arrays++Deep Value can be boolean:++- If `true`, it recurses all nested objects and objects in arrays.++Or a `DeepKeyFilter` function which has the following properties:

DeepKeyFilter means nothing in JS as the type is not available there.

fohletex

comment created time in 2 hours

Pull request review commentsindresorhus/map-obj

map-obj deep only for certain keys

 Type: `object`  ##### deep -Type: `boolean`<br>+Type: `boolean | Function`<br> Default: `false` -Recurse nested objects and objects in arrays.+Recursing behaviour for nested objects and objects in arrays++Deep Value can be boolean:

Not sure why this is capitalized.

fohletex

comment created time in 2 hours

Pull request review commentsindresorhus/map-obj

map-obj deep only for certain keys

 Type: `object`  ##### deep -Type: `boolean`<br>+Type: `boolean | Function`<br> Default: `false` -Recurse nested objects and objects in arrays.+Recursing behaviour for nested objects and objects in arrays
Recursing behavior for nested objects and objects in arrays.
fohletex

comment created time in 2 hours

Pull request review commentsindresorhus/map-obj

map-obj deep only for certain keys

 Type: `object`  ##### deep -Type: `boolean`<br>+Type: `boolean | Function`<br> Default: `false` -Recurse nested objects and objects in arrays.+Recursing behaviour for nested objects and objects in arrays++Deep Value can be boolean:++- If `true`, it recurses all nested objects and objects in arrays.++Or a `DeepKeyFilter` function which has the following properties:++- It has signature `deepKeyFilter(sourceKey: string)`.+- It must return a `boolean`. Returning `true` states the value related to the currently iterated `sourceKey`+    shall be recursed if it is a nested object, false otherwise.++Example:++```js+const mapObject = require('map-obj');+const newObject = mapObject(+    {foo: {bar: 42}, lorem: {ipsum: 'dolor'}},+    (key, value) => [key.toUpperCase(), value],+    {deep: key => key === 'foo'} // Recurses only on nested objects of key "foo"

Use-tab indentation.

fohletex

comment created time in 2 hours

Pull request review commentsindresorhus/map-obj

map-obj deep only for certain keys

 Type: `object`  ##### deep -Type: `boolean`<br>+Type: `boolean | Function`<br> Default: `false` -Recurse nested objects and objects in arrays.+Recursing behaviour for nested objects and objects in arrays++Deep Value can be boolean:++- If `true`, it recurses all nested objects and objects in arrays.++Or a `DeepKeyFilter` function which has the following properties:++- It has signature `deepKeyFilter(sourceKey: string)`.+- It must return a `boolean`. Returning `true` states the value related to the currently iterated `sourceKey`+    shall be recursed if it is a nested object, false otherwise.

Don't hard-wrap.

fohletex

comment created time in 2 hours

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentsindresorhus/map-obj

map-obj deep only for certain keys

 test('deep option', t => { 		] 	}; +	const expectedDeepFalse = {+		one: 2,+		object: {+			two: 2,+			three: 3+		},+		array: [+			{+				four: 4+			},+			5+		]+	};++	const expectedDeepFunction = {+		one: 2,+		object: {+			two: 2,+			three: 3+		},+		array: [+			{+				four: 8+			},+			5+		]+	};+ 	const mapper = (key, value) => [key, typeof value === 'number' ? value * 2 : value];-	const actual = mapObject(object, mapper, {deep: true});-	t.deepEqual(actual, expected);+	const actualDeepTrue = mapObject(object, mapper, {deep: true});+	const actualDeepFalse = mapObject(object, mapper, {deep: false});+	const actualDeepFunction = mapObject(object, mapper, {deep: k => k !== 'object'});
	const actualDeepFunction = mapObject(object, mapper, {deep: key => key !== 'object'});
fohletex

comment created time in 2 hours

push eventfohletex/map-obj

Sindre Sorhus

commit sha c3f70fbff5582eda82680ea29edc64c4bcc6fac8

Update index.d.ts

view details

push time in 2 hours

push eventfohletex/map-obj

Sindre Sorhus

commit sha 43d7909c864102e9d3ff668e2683450eb48513ea

Update readme.md

view details

push time in 2 hours

pull request commentsindresorhus/fkill

Make .EXE extension optional in windows

Bump

netrules

comment created time in 2 hours

pull request commentsindresorhus/dot-prop

Changes the way to check property for enumerability, fixes #46

Remove the enumerability checks.

stroncium

comment created time in 2 hours

PR closed sindresorhus/awesome-nodejs

add LIVR to data validation

LIVR - Is a ightweight JavaScript validator supporting Language Independent Validation Rules Specification

+3 -0

1 comment

12 changed files

wakeupmh

pr closed time in 2 hours

pull request commentsindresorhus/awesome-nodejs

add LIVR to data validation

Thanks for the suggestion, however, the project doesn't have any changelog. You also included a lot of unrelated changes.

wakeupmh

comment created time in 2 hours

PullRequestReviewEvent

Pull request review commentsindresorhus/electron-debug

Add devtron via preload script

 Values: `'undocked'` `'right'` `'bottom'` `'previous'` `'detach'`  The dock state to open DevTools in. +##### preloads++Type: `(string) => string[]`\+Default: `(devtronPreloadFile) => [devtronPreloadFile]`++Factory to provide scripts to set via `session#setPreloads`.

Maybe the naming should be more general too, in case we can to include other things in the preload script in the future.

JanMalch

comment created time in 2 hours

push eventJanMalch/electron-debug

Sindre Sorhus

commit sha e6b58034b2c3adb5c2368137691da4c822bdb747

Update index.d.ts

view details

push time in 2 hours

Pull request review commentsindresorhus/electron-debug

Add devtron via preload script

 Values: `'undocked'` `'right'` `'bottom'` `'previous'` `'detach'`  The dock state to open DevTools in. +##### preloads++Type: `(string) => string[]`\+Default: `(devtronPreloadFile) => [devtronPreloadFile]`++Factory to provide scripts to set via `session#setPreloads`.

Actually, I think it would be better to do it the other way around and expose our preload thing, so the user could include it if they call setPreloads themselves.

JanMalch

comment created time in 2 hours

PullRequestReviewEvent

Pull request review commentsindresorhus/electron-debug

Add devtron via preload script

 Values: `'undocked'` `'right'` `'bottom'` `'previous'` `'detach'`  The dock state to open DevTools in. +##### preloads++Type: `(string) => string[]`\+Default: `(devtronPreloadFile) => [devtronPreloadFile]`++Factory to provide scripts to set via `session#setPreloads`.

This needs to explain why the option exists and why the user should not call setPreloads themselves.

JanMalch

comment created time in 2 hours

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentsindresorhus/cpy

Implement recursive and flat copy

Yes, I can do a major release.

Idered

comment created time in 5 hours

pull request commentsindresorhus/cpy

Implement recursive and flat copy

@Idered Still interested in finishing this?

Idered

comment created time in 5 hours

PR closed sindresorhus/awesome-electron

Add electron-alert

https://github.com/rocketlaunchr/electron-alert

+1 -0

1 comment

1 changed file

pjebs

pr closed time in 5 hours

pull request commentsindresorhus/awesome-electron

Add electron-alert

Thanks for the suggestion. I'm going to pass on this. I think it's better to just use SweetAlert2 directly in the browser process and use the native dialog for stuff in the main process.

pjebs

comment created time in 5 hours

Pull request review commentsindresorhus/cli-spinners

Added new styles

 			"βββββρβ", 			"ββββββρ" 		]+	},+		"fish": {+		"interval": 150,+		"frames": [+			">))'>",+			"<'((<"

I don't think this is clear enough as being as fish when animated. To me, it just looks like noise. I would drop this one.

Geshii

comment created time in 6 hours

Pull request review commentsindresorhus/cli-spinners

Added new styles

 			"βββββρβ", 			"ββββββρ" 		]+	},+		"fish": {+		"interval": 150,+		"frames": [+			">))'>",+			"<'((<"+		]+	},+			"futurebar": {

I think it would be better to use a descriptive name.

Geshii

comment created time in 6 hours

Pull request review commentsindresorhus/cli-spinners

Added new styles

 			"βββββρβ", 			"ββββββρ" 		]+	},+		"fish": {+		"interval": 150,+		"frames": [+			">))'>",+			"<'((<"+		]+	},+			"futurebar": {
	"futurebar": {
Geshii

comment created time in 6 hours

Pull request review commentsindresorhus/cli-spinners

Added new styles

 			"βββββρβ", 			"ββββββρ" 		]+	},+		"fish": {+		"interval": 150,+		"frames": [+			">))'>",+			"<'((<"+		]+	},+			"futurebar": {+		"interval": 80,+		"frames": [+			"▰▱▱▱▱▱▱",+			"▰▰▱▱▱▱▱",+			"▰▰▰▱▱▱▱",+			"▰▰▰▰▱▱▱",+			"▰▰▰▰▰▱",

This is missing a square.

Geshii

comment created time in 6 hours

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentsindresorhus/awesome

Lint with awesome-lint via GitHub Actions

@Richienb Are you interested in finishing this or should I close?

Richienb

comment created time in 6 hours

pull request commentsindresorhus/awesome

Lint with awesome-lint via GitHub Actions

I do not see a reason why it will not pass. What issues do you anticipate will happen when merged? As far as I know, actions/checkout@v2 had a breaking change, but that was taken care by setting the fetch-depth to 0.

I think I explained it pretty clearly in the linked comment. The readme here does not pass all the awesome-lint rules.

Richienb

comment created time in 6 hours

PR closed sindresorhus/awesome

Add Topological Data Analysis

This's #1703 closed pull request.

<!-- Congrats on creating an Awesome list! 🎉 -->

<!-- Please fill in the below placeholders -->

topological data analysis (TDA) is an approach to the analysis of datasets using techniques from topology. This list is handy for those who want to know more about TDA's theory and Tools in both mathematics and computer science.

PRs Reviewed: #1701 #1684 #1792

By submitting this pull request I confirm I've read and complied with the below requirements 🖖

Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

Requirements for your pull request

  • Don't waste my time. Do a good job, adhere to all the guidelines, and be responsive.
  • You have to review at least 2 other open pull requests. Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.
  • You have read and understood the instructions for creating a list.
  • This pull request has a title in the format Add Name of List.
    • Add Swift
    • Add Software Architecture
    • Update readme.md
    • Add Awesome Swift
    • Add swift
    • Adding Swift
    • Added Swift
  • Your entry here should include a short description about the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.
    • - [iOS](…) - Mobile operating system for Apple phones and tablets.
    • - [Framer](…) - Prototyping interactive UI designs.
    • - [iOS](…) - Resources and tools for iOS development.
    • - [Framer](…)
    • - [Framer](…) - prototyping interactive UI designs
  • Your entry should be added at the bottom of the appropriate category.
  • The suggested Awesome list complies with the below requirements.

Requirements for your Awesome list

  • Has been around for at least 30 days.<br>That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
  • Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it.
  • Run awesome-lint on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.
  • The default branch should be named main, not master.
  • Includes a succinct description of the project/theme at the top of the readme. (Example)
    • Mobile operating system for Apple phones and tablets.
    • Prototyping interactive UI designs.
    • Resources and tools for iOS development.
    • Awesome Framer packages and tools.
  • It's the result of hard work and the best I could possibly produce. If you have not put in considerable effort into your list, your pull request will be immediately closed.
  • The repo name of your list should be in lowercase slug format: awesome-name-of-list.
    • awesome-swift
    • awesome-web-typography
    • awesome-Swift
    • AwesomeWebTypography
  • The heading title of your list should be in title case format: # Awesome Name of List.
    • # Awesome Swift
    • # Awesome Web Typography
    • # awesome-swift
    • # AwesomeSwift
  • Non-generated Markdown file in a GitHub repo.
  • The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
  • Not a duplicate. Please search for existing submissions.
  • Only has awesome items. Awesome lists are curations of the best, not everything.
  • Does not contain items that are unmaintained, has archived repo, deprecated, or missing docs. If you really need to include such items, they should be in a separate Markdown file.
  • Includes a project logo/illustration whenever possible.
    • Either centered, fullwidth, or placed at the top-right of the readme. (Example)
    • The image should link to the project website or any relevant website.
    • The image should be high-DPI. Set it to maximum half the width of the original image.
  • Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
  • Includes the Awesome badge.
    • Should be placed on the right side of the readme heading.
      • Can be placed centered if the list has a centered graphics header.
    • Should link back to this list.
  • Has a Table of Contents section.
    • Should be named Contents, not Table of Contents.
    • Should be the first section in the list.
    • Should only have one level of nested lists, preferably none.
  • Has an appropriate license.
    • We strongly recommend the CC0 license, but any Creative Commons license will work.
      • Tip: You can quickly add it to your repo by going to this URL: https://github.com/<user>/<repo>/community/license/new?branch=master&template=cc0-1.0 (replace <user> and <repo> accordingly).
    • A code license like MIT, BSD, Apache, GPL, etc, is not acceptable. Neither are WTFPL and Unlicense.
    • Place a file named license or LICENSE in the repo root with the license text.
    • Do not add the license name or text to the readme. GitHub already shows the license name at the top of the repo.
    • To verify that you've read all the guidelines, please comment on your pull request with just the word unicorn.
  • Has contribution guidelines.
    • The file should be named contributing.md. Casing is up to you.
  • Has consistent formatting and proper spelling/grammar.
    • The link and description are separated by a dash. <br>Example: - [AVA](…) - JavaScript test runner.
    • The description starts with an uppercase character and ends with a period.
    • Consistent and correct naming. For example, Node.js, not NodeJS or node.js.
  • Doesn't include a Travis badge.<br>You can still use Travis for list linting, but the badge has no value in the readme.
  • Doesn't include an Inspired by awesome-foo or Inspired by the Awesome project kinda link at the top of the readme. The Awesome badge is enough.

Go to the top and read it again.

+1 -0

12 comments

1 changed file

FatemehTarashi

pr closed time in 6 hours

pull request commentsindresorhus/awesome

Add Topological Data Analysis

I'm going to close this for now as the list is not close to being added and there's no progress. I would recommend reading through the guidelines more closely, work more on the list, and try submitting again sometime in the future (after at least 3 months).

FatemehTarashi

comment created time in 6 hours

pull request commentsindresorhus/awesome

Add Topological Data Analysis

There are still many things that are not followed:


Includes a succinct description of the project/theme at the top of the readme. (Example)


Entries have a description, unless the title is descriptive enough by itself. It rarely is though.


And more.

FatemehTarashi

comment created time in 6 hours

pull request commentsindresorhus/awesome

Add Astronomy

https://github.com/sindresorhus/awesome/pull/1802#issuecomment-654365940 is still not done. Please do a good effort on that before commenting back here. Look at other awesome lists for inspiration.

biesiadamich

comment created time in 6 hours

Pull request review commentsindresorhus/awesome

Add Astronomy

 - [Naming](https://github.com/gruhn/awesome-naming#readme) - Naming things in computer science done right. - [Biomedical Information Extraction](https://github.com/caufieldjh/awesome-bioie#readme) - How to extract information from unstructured biomedical data and text. - [Web Archiving](https://github.com/iipc/awesome-web-archiving#readme) - An effort to preserve the Web for future generations.+- [Astronomy](https://github.com/mbiesiad/awesome-astronomy#readme) - Astronomy, astronomical phenomenons and celestial mechanics.

Looks weird when you repeat "astronomy" in the description.

biesiadamich

comment created time in 6 hours

PullRequestReviewEvent

pull request commentsindresorhus/awesome

Add Awesome Ansible

Ansible is an open source toolkit, written in Python, it is used for Configuration Management, Application Deployment, Continuous Delivery, IT infrastructure automation and automation in general.

This should not be titled-cased.

KeyboardInterrupt

comment created time in 6 hours

pull request commentsindresorhus/awesome

Add Awesome Ansible

Entry descriptions should not be in title-case. Same with the section descriptions.

KeyboardInterrupt

comment created time in 6 hours

pull request commentsindresorhus/awesome

Add Awesome Ansible

The image should link to the project website or any relevant website.

KeyboardInterrupt

comment created time in 6 hours

pull request commentsindresorhus/awesome

Add Awesome Ansible

Linkify Ansible in Ansible is an open source toolkit, written in Python to its website.

KeyboardInterrupt

comment created time in 6 hours

pull request commentsindresorhus/awesome

Add Awesome Ansible

The PR title is incorrect.

KeyboardInterrupt

comment created time in 6 hours

push eventKeyboardInterrupt/awesome

Sindre Sorhus

commit sha 85aff7ca71ba852e2f451db35f7a2d180ce507f5

Update readme.md

view details

push time in 6 hours

PR closed sindresorhus/pageres

Improve docs
+1 -1

0 comment

1 changed file

satyendra911

pr closed time in 6 hours

pull request commentsindresorhus/awesome

Add Biological Visualizations

❯ awesome-lint https://github.com/keller-mark/awesome-biological-visualizations
✖ Linting

  README.md:91:3
  ✖  91:3  Invalid list item link URL  remark-lint:awesome-list-item

  1 error

https://github.com/sindresorhus/awesome-lint

keller-mark

comment created time in 6 hours

pull request commentsindresorhus/awesome

Add Biological Visualizations

I think it would be useful if your list had a more verbose description of its purpose below the current tagline. Something like:

Web-based biology-related visualization tools are often scattered across the internet and difficult to discover. They may be found on GitHub, Twitter, or linked from scientific papers. These tools can be very useful to scientists looking to visualize biological data in the context of diseased or healthy humans or model organisms.

keller-mark

comment created time in 6 hours

pull request commentsindresorhus/awesome-nodejs

add Garn-validator

How is this different/better than all the other validation packages already in the list?

jupegarnica

comment created time in 6 hours

pull request commentsindresorhus/awesome-nodejs

add Garn-validator

Please follow the contribution guidelines: https://github.com/sindresorhus/awesome-nodejs/blob/master/contributing.md

jupegarnica

comment created time in 6 hours

PR closed sindresorhus/awesome-npm

Add my-npm-stats

Hey, I recently built a stats tool for NPM that shows the weekly downloads as of npmjs.org and also the number of dependents (which is an indicator for the popularity of the package). So it might fit in the list of already-existing npm stat tools.

https://my-npm-stats.org/

+1 -0

4 comments

1 changed file

dword-design

pr closed time in 6 hours

pull request commentsindresorhus/awesome-npm

Add my-npm-stats

Also, it's npm, not NPM.

dword-design

comment created time in 6 hours

pull request commentsindresorhus/awesome-npm

Add my-npm-stats

I think you should find some users, get some feedback, iterate, and then submit again at a later point when the site is more mature and you've figured it more out.

dword-design

comment created time in 6 hours

Pull request review commentsindresorhus/awesome-npm

Add my-npm-stats

 - [npm-top](https://gist.github.com/bcoe/dcc961b869bbf6685002) - npm users by downloads. - [npm semver calculator](http://semver.npmjs.com) - Visually explore what versions of a package a semver range matches. - [npm-stats](http://www.npm-stats.com) - Displays metrics about packages.+- [my-npm-stats](https://my-npm-stats.org) - Package stats and dependents for NPM authors.

You're asking the wrong person as I'm not your target audience.

dword-design

comment created time in 6 hours

PullRequestReviewEvent

PR closed sindresorhus/awesome-npm

Introduce handpick

@sindresorhus Please consider adding handpick as it become more stable and feature-rich. People at mozilla-it start using it and I had lot of success with clients to speed-up their pipelines. Check out the examples to get an idea how it works.

+1 -0

2 comments

1 changed file

redaxmedia

pr closed time in 6 hours

pull request commentsindresorhus/awesome-npm

Introduce handpick

There's also a new guideline that requires 40 stars (to make sure submitted entries are things that are actually used by users): https://github.com/sindresorhus/awesome-npm/blob/master/contributing.md

redaxmedia

comment created time in 6 hours

pull request commentsindresorhus/awesome-npm

Introduce handpick

The project readme should clearly describe what it is and what problems it solves.

redaxmedia

comment created time in 6 hours

push eventsindresorhus/awesome-nodejs

Wojciech Krysiak

commit sha 296f58821e403e28b20e1be2606db851e1dcead5

Add AdminBro (#1063)

view details

push time in 6 hours

PR merged sindresorhus/awesome-nodejs

Add AdminBro

It was inspired by tools like django admin, railsadmin and active admin. It reached 2k stars this weekend so I decided that this is the right moment to post it here.

By submitting this pull request, I promise I have read the contribution guidelines twice and ensured my submission follows it. I realize not doing so wastes the maintainers' time that they could have spent making the world better. 🖖

⬆⬆⬆⬆⬆⬆⬆⬆⬆⬆

+1 -0

0 comment

1 changed file

wojtek-krysiak

pr closed time in 6 hours

pull request commentsindresorhus/awesome

Add Social Enterprise

The description starts with an uppercase character and ends with a period.

RayBB

comment created time in 6 hours

pull request commentsindresorhus/awesome

Add Web Monetization

Bump

thomasbnt

comment created time in 6 hours

PR closed sindresorhus/awesome

Add Illustrations

Add Awesome Illustrations: A curated list of awesome illustrations & tools ✨ https://github.com/MrPeker/awesome-illustrations#readme

It's a list of design resources specifically for illustrations. I think it's a great collection of illustrations.

By submitting this pull request I confirm I've read and complied with the below requirements 🖖

Reviewed PRs:

  • #1803
  • #1802
**Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.**
## Requirements for your pull request

- **Don't waste my time.** Do a good job, adhere to all the guidelines, and be responsive.
- **You have to review at least 2 other [open pull requests](https://github.com/sindresorhus/awesome/pulls?q=is%3Apr+is%3Aopen).**
	Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.
- You have read and understood the [instructions for creating a list](create-list.md).
- This pull request has a title in the format `Add Name of List`.
	- ✅ `Add Swift`
	- ✅ `Add Software Architecture`
	- ❌ `Update readme.md`
	- ❌ `Add Awesome Swift`
	- ❌ `Add swift`
	- ❌ `Adding Swift`
	- ❌ `Added Swift`
- Your entry here should include a short description about the project/theme of the list. **It should not describe the list itself.** The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb.
	- ✅ `- [iOS](…) - Mobile operating system for Apple phones and tablets.`
	- ✅ `- [Framer](…) - Prototyping interactive UI designs.`
	- ❌ `- [iOS](…) - Resources and tools for iOS development.`
	- ❌ `- [Framer](…)`
	- ❌ `- [Framer](…) - prototyping interactive UI designs`
- Your entry should be added at the bottom of the appropriate category.
- The suggested Awesome list complies with the below requirements.

## Requirements for your Awesome list

- **Has been around for at least 30 days.**<br>That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
- Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it.
- Run [`awesome-lint`](https://github.com/sindresorhus/awesome-lint) on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please [report it](https://github.com/sindresorhus/awesome-lint/issues/new).
- The default branch should be named [`main`, not `master`](https://www.zdnet.com/article/github-to-replace-master-with-alternative-term-to-avoid-slavery-references/).
- **Includes a succinct description of the project/theme at the top of the readme.** [(Example)](https://github.com/willempienaar/awesome-quantified-self)
	- ✅ `Mobile operating system for Apple phones and tablets.`
	- ✅ `Prototyping interactive UI designs.`
	- ❌ `Resources and tools for iOS development.`
	- ❌ `Awesome Framer packages and tools.`
- It's the result of hard work and the best I could possibly produce.
	**If you have not put in considerable effort into your list, your pull request will be immediately closed.**
- The repo name of your list should be in lowercase slug format: `awesome-name-of-list`.
	- ✅ `awesome-swift`
	- ✅ `awesome-web-typography`
	- ❌ `awesome-Swift`
	- ❌ `AwesomeWebTypography`
- The heading title of your list should be in [title case](https://capitalizemytitle.com/) format: `# Awesome Name of List`.
	- ✅ `# Awesome Swift`
	- ✅ `# Awesome Web Typography`
	- ❌ `# awesome-swift`
	- ❌ `# AwesomeSwift`
- Non-generated Markdown file in a GitHub repo.
- The repo should have `awesome-list` & `awesome` as [GitHub topics](https://help.github.com/articles/about-topics). I encourage you to add more relevant topics.
- Not a duplicate. Please search for existing submissions.
- Only has awesome items. Awesome lists are curations of the best, not everything.
- Does not contain items that are unmaintained, has archived repo, deprecated, or missing docs. If you really need to include such items, they should be in a separate Markdown file.
- Includes a project logo/illustration whenever possible.
	- Either centered, fullwidth, or placed at the top-right of the readme. [(Example)](https://github.com/sindresorhus/awesome-electron)
	- The image should link to the project website or any relevant website.
	- **The image should be high-DPI.** Set it to maximum half the width of the original image.
- Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
- Includes the [Awesome badge](awesome.md#awesome-badge).
	- Should be placed on the right side of the readme heading.
		- Can be placed centered if the list has a centered graphics header.
	- Should link back to this list.
- Has a Table of Contents section.
	- Should be named `Contents`, not `Table of Contents`.
	- Should be the first section in the list.
	- Should only have one level of [nested lists](https://commonmark.org/help/tutorial/10-nestedLists.html), preferably none.
- Has an appropriate license.
	- **We strongly recommend the [CC0 license](https://creativecommons.org/publicdomain/zero/1.0/), but any [Creative Commons license](https://creativecommons.org/choose/) will work.**
		- Tip: You can quickly add it to your repo by going to this URL: `https://github.com/<user>/<repo>/community/license/new?branch=master&template=cc0-1.0` (replace `<user>` and `<repo>` accordingly).
	- A code license like MIT, BSD, Apache, GPL, etc, is not acceptable. Neither are WTFPL and [Unlicense](https://unlicense.org).
	- Place a file named `license` or `LICENSE` in the repo root with the license text.
	- **Do not** add the license name or text to the readme. GitHub already shows the license name at the top of the repo.
	- To verify that you've read all the guidelines, please comment on your pull request with just the word `unicorn`.
- Has [contribution guidelines](awesome.md#include-contribution-guidelines).
	- The file should be named `contributing.md`. Casing is up to you.
- Has consistent formatting and proper spelling/grammar.
	- The link and description are separated by a dash. <br>Example: `- [AVA](…) - JavaScript test runner.`
	- The description starts with an uppercase character and ends with a period.
	- Consistent and correct naming. For example, `Node.js`, not `NodeJS` or `node.js`.
- Doesn't include a Travis badge.<br>You can still use Travis for list linting, but the badge has no value in the readme.
- Doesn't include an `Inspired by awesome-foo` or `Inspired by the Awesome project` kinda link at the top of the readme. The Awesome badge is enough.

**Go to the top and read it again.**
+2 -0

4 comments

1 changed file

MrPeker

pr closed time in 6 hours

pull request commentsindresorhus/awesome

Add Illustrations

Closing for lack of response.

MrPeker

comment created time in 6 hours

Pull request review commentsindresorhus/awesome-nodejs

Add Tinyhttp to the list of Web frameworks

 - [Nest](https://github.com/nestjs/nest) - Angular-inspired framework for building efficient and scalable server-side apps. - [Zeronode](https://github.com/sfast/zeronode) - Minimal building block for reliable and fault-tolerant microservices. - [TypeGraphQL](https://github.com/19majkel94/type-graphql) - Modern framework for creating GraphQL APIs with TypeScript, using classes and decorators.+- [Tinyhttp](https://github.com/talentlessguy/tinyhttp) - Modern Express-like web framework compiled to native ESM and written in TypeScript that uses a bare minimum amount of dependencies trying to avoid legacy hell.

The description is too verbose. Try to focus on what matters.

talentlessguy

comment created time in 6 hours

PullRequestReviewEvent

pull request commentwulkano/aperture-node

Add `filePath` option

Bump

karaggeorge

comment created time in 6 hours

delete branch wulkano/aperture-node

delete branch : fix-delay

delete time in 6 hours

push eventwulkano/aperture-node

Sindre Sorhus

commit sha 10d447cb4f57b9053215f24100cbf232f6ff3300

Remove delay before recording starts (#12)

view details

push time in 6 hours

PR merged wulkano/aperture-node

Reviewers
Remove delay before recording starts

Turns out the recording actually starts right when we call recorder.start(). The .onStart event is emitted 2-3 seconds later. So the fix is to simply not wait for that event. I'm suspecting that even is when the recording starts writing to the file on disk, not when the actual recording starts.

Fixes #1 Related https://github.com/wulkano/Kap/issues/850#issuecomment-642127662

+34 -8

16 comments

5 changed files

sindresorhus

pr closed time in 6 hours

issue closedwulkano/aperture-node

Recording starts before resolving promise

I'm recording the screen because I need to show some visualizations over a video I'm reproducing. I need to know when the recording starts so I can then play the video at the same time. Now the video it's playing almost a second after it has started recording. I'm still trying to figure out if there's a problem on my code causing this but I see one of the comments on the code says // R is printed by Swift when the recording **actually** starts like if the "actually" has air quotes or something.

So, is there a know lapse of time that passes from when the recording starts until the promise resolves? Can I do something about this?

Thanks!

closed time in 6 hours

limoragni

pull request commentsindresorhus/modern-normalize

Add link to usage with styled-components

Closing in favor of https://github.com/sindresorhus/modern-normalize/issues/44.

sergeysova

comment created time in 7 hours

issue openedsindresorhus/modern-normalize

Built-in support for CSS-inJS

See https://github.com/sindresorhus/modern-normalize/pull/31#issuecomment-502339135

created time in 7 hours

pull request commentsindresorhus/modern-normalize

Add link to usage with styled-components

If the proposal here is just to provide the template string, then it doesn't need to have any mention of styled-components, could use a more generic name as other CSS-in-JS packages like Linaria could use it too afaik.

Correct

sergeysova

comment created time in 7 hours

push eventubergesundheit/ky

Seth Holladay

commit sha fcb80099254362b30a5c8c722f1df32d0be536c4

Fix the NormalizedOptions.headers type (#243)

view details

Kumar McMillan

commit sha d5e1233c3e170187cc77820c85a35661f9d8e9e5

Ensure HTTPError always has a defined message (#249)

view details

Sindre Sorhus

commit sha e4e820c4ba94651a795a4e23f79e4bdc4afd10c1

0.19.1

view details

Daniel Andrei

commit sha 70826b2c56aac6ca59518d88907ffb6ddbff6f9a

Add ability to remove headers using `ky.extend()` (#235) Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com> Co-authored-by: Szymon Marczak <36894700+szmarczak@users.noreply.github.com>

view details

Sindre Sorhus

commit sha 588f45331a4e98872e74d628a04deeeb7bd601e0

Meta tweaks

view details

Sindre Sorhus

commit sha 2c5d6dda8ac889048408a337c3f5d068769981b2

0.20.0

view details

Thierry Goettelmann

commit sha b9dbd19a533fd61fbadaa44b1803995dc782e839

Add `Request` to `TimeoutError` (#267)

view details

Sindre Sorhus

commit sha f67304ee71ab2cc675a5590e414c2daf695b337d

0.21.0

view details

Seth Holladay

commit sha 71a8d59dc500102ce94030ec88b28f0288fd6b9e

Fix headers construction in old browsers (#270) * Fix headers construction in old browsers * Add headers test

view details

Kirill Groshkov

commit sha 95e7fd7cec8bed8bbeaf300e4fd1b6fb521ca145

Add `parseJson` option (#272) * feat: Options.parseJson fixes https://github.com/sindresorhus/ky/issues/254 * Update index.d.ts * Update readme.md * Support parseJson option with response.json() * docs: remove the limitation clause * Update index.js Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com> Co-authored-by: Seth Holladay <me@seth-holladay.com>

view details

Seth Holladay

commit sha c9e52061a40396ae1408ef9177ea9fd94a36f98f

Add support for relative URLs and searchParams even in non-browsers (#271)

view details

Sindre Sorhus

commit sha 6e0294035bb32675e92bd471176e0543b63e774e

0.22.0

view details

Skayo

commit sha ccda3b98935ac26ffee70fb24d8e9fb28f89bbeb

Add option for custom `fetch` implementation (#273) * Overwrite globals.fetch when a 'fetch' option was provided * Fixed bug that wouldn't let me overwrite globals' properties * Fixed bug where 'this' referenced to the wrong object * Added basic documentation * Overwriting globals.fetch affects all other ky calls, therefore switched to this._options.fetch * Added basic tests * Formatting * More Formatting * Update index.d.ts * Update readme.md * Use shorthand syntax for passing fetch function in examples * Added more assertions to the test and removed .serial() * Added note that the user-defined fetch function has to be compatible with the standard * Fixed test * Plan for 12 assertions because every call for fetch is another assertion * Remove trailing comma * Remove configurable setting as it's not needed anymore Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com> Co-authored-by: Seth Holladay <me@seth-holladay.com>

view details

Seth Holladay

commit sha d52981efa5985f771e1ede166f11ac053db7a15e

Clarify `throwHttpErrors` and redirect interaction (#274)

view details

Sindre Sorhus

commit sha 9076dbcdb59e756b943a3b405edf7aec7ce6e6a2

0.23.0

view details

Kim Røen

commit sha 59dbd1dd2ce68848bc371605df5c7b45049870bd

Fix readme typo (#278) Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>

view details

Seth Holladay

commit sha 9876da129c216b99ad9f5760d38ba0ed1876d20e

Fix handling of network errors for `beforeRetry` hook (#276)

view details

Sindre Sorhus

commit sha 1f593943b954d7279b2fef6f62549548b1eef80e

0.24.0

view details

Sindre Sorhus

commit sha e812e661893e942c5e765133cc08b77dc8194ce6

Merge branch 'master' into add-type-and-exports-to-package-json

view details

push time in 7 hours

PR closed sindresorhus/eslint-formatter-pretty

Add TypeScript definition

Trivial declaration file for typescript so VS Code won't yell while editing webpack config file...

+31 -2

6 comments

3 changed files

sovcik

pr closed time in 7 hours

pull request commentsindresorhus/eslint-formatter-pretty

Add TypeScript definition

https://github.com/sindresorhus/eslint-formatter-pretty/issues/52

sovcik

comment created time in 7 hours

issue openedsindresorhus/eslint-formatter-pretty

Add TypeScript definition

If anyone wants to work on this, see the initial attempt and feedback in https://github.com/sindresorhus/eslint-formatter-pretty/pull/50.

created time in 7 hours

pull request commentsindresorhus/meow

Generate help by flag descriptions

Bump

ybiquitous

comment created time in 7 hours

pull request commentsindresorhus/html-tags

Add TypeScript types as union type for another .d.ts

Closing for lack of response.

sergeysova

comment created time in 7 hours

pull request commentsindresorhus/map-obj

Add new stopRecursion option (Suggested in #23)

Bump

magicmark

comment created time in 7 hours

Pull request review commentsindresorhus/is-stream

Add support for return the `type` of stream

 declare const isStream: { 	``` 	*/ 	transform(input: unknown): input is stream.Transform;++	/**+	@returns Returns a `string` to tell the [`type of stream`](https://nodejs.org/api/stream.html#stream_types_of_streams): `readable`, `writable`, `duplex`, `transform` or `undefined` for unknown stream type and non streams.

You're writing "return" twice.

robertoentringer

comment created time in 7 hours

PullRequestReviewEvent

pull request commentsindresorhus/is-stream

Add support for return the `type` of stream

Bump

robertoentringer

comment created time in 7 hours

pull request commentsindresorhus/mem

Infer `cacheKey` arguments type

Can you add a type test to index.test-d.ts?

wzhkobe2408

comment created time in 7 hours

push eventsindresorhus/ow

Deployment Bot (from Travis CI)

commit sha 43909a933a8eee94ad2b4a42314b279124d8e571

Deploy sindresorhus/ow to github.com/sindresorhus/ow.git:gh-pages

view details

push time in 7 hours

more