profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/shish/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

shish/context2 70

Golang flame chart viewer

calaldees/KaraKara 24

Karaoke Event System - Attendees can view and queue tracks from their mobile phones

shish/devtools-py 15

A Python client for Chrome's DevTools protocol / a headless chrome control library

shish/cview3 12

AJAX comic viewer

shish/eve-mlp 12

Mobile Launch Platform for EVE Online

shish/clearskies-gui 9

A simple GUI for clearskies

shish/apache2rrd 7

Makes pretty graphs out of apache (or similar) log files

shish/csb 4

A curses-based browser for SQL databases

shish/context-apis 3

A collection of libraries for creating .ctxt files

calaldees/MultiPong 1

A multi screen distributed Pong game

startedcoding-horror/basic-computer-games

started time in 2 hours

startedshish/shimmie2

started time in a day

GollumEvent

fork Diftraku/traefik-rpm

RPM package for traefik

fork in a day

pull request commentfacebook/TestSlide

improve coroutinevalueerror error message, resolve #284

Pull Request Test Coverage Report for Build 605316411

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 94.129%

Changes Missing Coverage Covered Lines Changed/Added Lines %
testslide/lib.py 2 3 66.67%
<!-- Total: 2 3
Totals Coverage Status
Change from base Build 596460370: -0.03%
Covered Lines: 2549
Relevant Lines: 2708

💛 - Coveralls
deathowl

comment created time in a day

PR opened facebook/TestSlide

improve coroutinevalueerror error message, resolve #284

Improve Coroutine Value Error error message

  • [X] Added tests, if you've added code that should be tested
  • [X] Updated the documentation, if you've changed APIs
  • [X] Ensured the test suite passes
  • [X] Made sure your code lints
  • [X] Completed the Contributor License Agreement ("CLA")
+4 -1

0 comment

1 changed file

pr created time in a day

starteddiscordjs/discord.js

started time in 3 days

startedbrowserslist/browserslist

started time in 4 days

issue closedfacebook/TestSlide

Create pytest-testslide

Add TestSlide support for pytest:

  • Create the PyPI package.
  • Add integration tests to Makefile for building, installing and using it.
  • Add documentation at doc/ regarding pytest integration.

StrictMock can be used simply by importing it, just document it.

Patching tools require special pytest integration, which can be done with @pytest.fixture. Naming the fixture testslide makes sense:

def test_something(testslide):
  testslide.mock_callable(...)

but this contrasts with its usage at TestSlide's DSL and Python's Unittest, which access them via self.mock_callable(...), so this is TBD.

The fixture implementation can be copy / pasta from testslide.TestCase.

closed time in 4 days

fornellas

pull request commentfacebook/TestSlide

Fix master

@fornellas merged this pull request in facebook/TestSlide@90a314ae72f5d7c729eea8f926f9c5b9c946fafa.

fornellas

comment created time in 4 days

push eventfacebook/TestSlide

Fabio Pugliese Ornellas

commit sha 90a314ae72f5d7c729eea8f926f9c5b9c946fafa

Fix master (#287) Summary: The tests were correctly breaking after a clowny change in master (guilty!). This PR fixes the object used in the test, so it passes. Pull Request resolved: https://github.com/facebook/TestSlide/pull/287 Reviewed By: macisamuele Differential Revision: D26633691 Pulled By: fornellas fbshipit-source-id: 509644c2e755e016525f82e6574c9818c2173a18

view details

push time in 4 days

PR closed facebook/TestSlide

Reviewers
Fix master CLA Signed

The tests were correctly breaking after a clowny change in master (guilty!). This PR fixes the object used in the test, so it passes.

+5 -4

0 comment

2 changed files

fornellas

pr closed time in 4 days

PR opened facebook/TestSlide

Reviewers
Fix master

The tests were correctly breaking after a clowny change in master (guilty!). This PR fixes the object used in the test, so it passes.

+5 -4

0 comment

2 changed files

pr created time in 4 days

create barnchfacebook/TestSlide

branch : fix_master

created branch time in 4 days

delete branch facebook/TestSlide

delete branch : fix_doc

delete time in 4 days

pull request commentfacebook/TestSlide

Fix typo

@fornellas merged this pull request in facebook/TestSlide@c2ea8df183a746aead79fc31f827fd6069361dc5.

fornellas

comment created time in 4 days

push eventfacebook/TestSlide

Fabio Pugliese Ornellas

commit sha c2ea8df183a746aead79fc31f827fd6069361dc5

Fix typo (#286) Summary: Ditto. Pull Request resolved: https://github.com/facebook/TestSlide/pull/286 Reviewed By: macisamuele Differential Revision: D26632814 Pulled By: fornellas fbshipit-source-id: 3877e6f9833ac42dba9981878dc534307e0c9c3a

view details

push time in 4 days

PR closed facebook/TestSlide

Reviewers
Fix typo CLA Signed

Ditto.

+2 -2

0 comment

1 changed file

fornellas

pr closed time in 4 days

PR opened facebook/TestSlide

Reviewers
Fix typo

Ditto.

+2 -2

0 comment

1 changed file

pr created time in 4 days

create barnchfacebook/TestSlide

branch : fix_doc

created branch time in 4 days

startedWerWolv/ImHex

started time in 5 days

startedqeeqbox/social-analyzer

started time in 5 days

startedtherealsreehari/Learn-Data-Science-For-Free

started time in 5 days

startedshish/pyge

started time in 6 days

Pull request review commentfacebook/TestSlide

Ensure that type validation is executed for StrictMock instances as well

 def _wrap_signature_and_type_validation(      skip_first_arg = _skip_first_arg(template, attr_name) +    # Add this so docstrings and method name are not altered by the mock+    @wraps(callable_template)

The idea here is that I would like to prevent as much as possible to have

<function _wrap_signature_and_type_validation.<locals>.with_sig_and_type_validation at 0x10ee343b0>

as information of the wrapped function.

Doing so makes debugging very very hard (at least I had a particularly hard time to identify the mocked function in mock_callable_testslide.py due to the function name).

With this change the function would look like

<function Client.sync_function at 0x102386ef0>

I can see your point of preserving the information of "this is a mock", in this case we might want to have something like

<function TestSldeValidation(_wrap_signature_and_type_validation) at 0x105c17560>

If you might like this idea I can update the PR

macisamuele

comment created time in 6 days

push eventfacebook/TestSlide

Fabio Pugliese Ornellas

commit sha d205f9c8a1068c73fb0746d88bd57abc41976f9f

TestSlide: Fix setting private attributes for StrictMock Summary: Ditto Reviewed By: deathowl Differential Revision: D26546996 fbshipit-source-id: 1f1147ec193913a53f4b286e601058845f058080

view details

push time in 6 days

pull request commentfacebook/TestSlide

Ensure that type validation is executed for StrictMock instances as well

LGTM \o/ Thanks for fixing this totally overseen case!

macisamuele

comment created time in 6 days

Pull request review commentfacebook/TestSlide

Ensure that type validation is executed for StrictMock instances as well

 def _wrap_signature_and_type_validation(      skip_first_arg = _skip_first_arg(template, attr_name) +    # Add this so docstrings and method name are not altered by the mock+    @wraps(callable_template)

Hum... I do understand the idea here, though I'm weighting if letting it explicit "this is a mock", with new name and docstring would be better than "implicit" and keeping the old names... Not strongly opinionated either way though.

macisamuele

comment created time in 6 days

Pull request review commentfacebook/TestSlide

Ensure that type validation is executed for StrictMock instances as well

 endif .PHONY: all all: tests coverage_report docs sdist -# .PHONY does not work for implicit rules, so we FORCE them-FORCE:-

Things are indeed worknig now, thanks for cleaning this up!

macisamuele

comment created time in 6 days

delete branch facebook/TestSlide

delete branch : typerror_logging_newtry

delete time in 6 days