profile
viewpoint
Masashi Hirano shisama @cybozu Japan https://shisama.dev he/him Node.js Core Collaborator in Japan.

nkgrnkgr/markRestIcon-kintone-chrome-extention 3

休みの人のアイコンにはお休みマークを付ける

shisama/axios_sample 1

sample of axios and async/await

akihito-takeuchi/levelmeup 0

Level Me Up Scotty! An intro to Node.js databases via a set of self-guided workshops.

shisama/babel-handbook 0

:blue_book: A guided handbook on how to use Babel and how to create plugins for Babel.

shisama/closure-templates 0

A client- and server-side templating system that helps you dynamically build reusable HTML and UI elements

shisama/create-react-app 0

Create React apps with no build configuration.

delete branch kintone/dts-gen

delete branch : renovate/typescript-eslint-monorepo

delete time in a day

push eventkintone/dts-gen

renovate[bot]

commit sha d2359f4733a8bfd2438e82982521b6c15f243d73

chore(deps): update dependency @typescript-eslint/parser to ^2.34.0 (#287) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in a day

PR merged kintone/dts-gen

Reviewers
chore(deps): update dependency @typescript-eslint/parser to ^2.34.0 renovate

This PR contains the following updates:

Package Type Update Change
@typescript-eslint/parser devDependencies minor ^2.33.0 -> ^2.34.0

Release Notes

<details> <summary>typescript-eslint/typescript-eslint</summary>

v2.34.0

Compare Source

Bug Fixes
  • typescript-estree: fix handling of range/loc removal (#​2028) (ce344d9)
Features
  • eslint-plugin: [no-invalid-void-type] allow union of void and allowInGenericTypeArguments (#​1960) (1bc105a)
  • eslint-plugin: [restrict-template-expressions] improve error message (#​1926) (1af59ba)
  • experimental-utils: add suggestion property for rule modules (#​2033) (f42a5b0)

</details>


Renovate configuration

:date: Schedule: "after 9pm,before 9am" in timezone Asia/Tokyo.

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+6 -65

0 comment

2 changed files

renovate[bot]

pr closed time in a day

pull request commentkintone/js-sdk

feat: support `garoon.connect.kintone.getRequestToken()` of Garoon JavaScript API

@gorohash

Thank you for your efforts. We added the description of this feature into README.

gorohash

comment created time in 3 days

push eventgorohash/js-sdk

shisama

commit sha 41a9033eca0ebbd6fee93cccfb8f8674ecd05f49

docs: Add session auth about garoon customize int README

view details

push time in 3 days

Pull request review commentkintone/js-sdk

feat: support `garoon.connect.kintone.getRequestToken()` of Garoon JavaScript API

 export class KintoneRequestConfigBuilder implements RequestConfigBuilder {     this.headers = this.buildHeaders(basicAuth);     this.clientCertAuth = clientCertAuth;     this.proxy = proxy;+    this.requestToken = "";

Either this.requestToken; or this.requestToken = null; is OK. But we prefer to set the initial value explicitly with null.

gorohash

comment created time in 3 days

startedKyome22/menubar_runcat

started time in 4 days

startedkuroppe1819/flexbox-cheat-site

started time in 5 days

push eventkintone/js-sdk

chick-p(piyo)

commit sha 4e1313a11eef4fd6d879aa02c2ddcf5052e1a6ad

chore: fix emoji (#244)

view details

push time in 5 days

delete branch kintone/js-sdk

delete branch : fix-issue-template-emoji

delete time in 5 days

PR merged kintone/js-sdk

Reviewers
chore: fix emoji
+2 -2

0 comment

2 changed files

chick-p

pr closed time in 5 days

push eventkintone/js-sdk

push time in 5 days

push eventkintone/js-sdk

shisama

commit sha 4c96db713b14414973988cfef35ea9f881b94457

fix: error Reference Error require on ES Modules

view details

push time in 5 days

pull request commentkintone/js-sdk

feat: Support Node.js Native ES Modules

I made this to draft because I am wondering whether I should use rollup or add index.mjs using `module.createRequire for Node.js native ESM.

shisama

comment created time in 6 days

pull request commentkintone/js-sdk

feat: Support Node.js Native ES Modules

@koba04 I added them to check easily if rest-api-client can be used from CJS/ESM in Node.js environment.

shisama

comment created time in 6 days

push eventkintone/js-sdk

Renovate Bot

commit sha c2e8c8ffc3d38ccadd51a7605a4664df69a9b2ec

fix(deps): update dependency qs to ^6.9.4

view details

renovate[bot]

commit sha b24e3d13dd64e02f39f48375e39460fa2626f920

chore(deps): update dependency jest to ^25.5.4 (#210) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha c093d7ac890fb742d252c97ff11313e83971d918

chore(deps): update dependency ts-node to ^8.10.1 (#211) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Renovate Bot

commit sha 7122d9ea4aa06e49dcd5c592b3408f46ac527732

chore(deps): update dependency @types/qs to ^6.9.2

view details

Renovate Bot

commit sha ac8d5d89b8c5e20b4729835a96743efd1d20a011

chore(deps): update dependency @types/node to ^13.13.5

view details

shintaroNagata

commit sha 4ddc6ea068d136586ac90f77d6bdb058f52dab41

feat: add type definitions for field properties (#199) * feat: add type definitions for field properties * chore: remove a comment * refactor: Field -> FieldProperty Co-authored-by: Shingo Yamazaki <shingoyamazaki00@gmail.com>

view details

shintaroNagata

commit sha b135e72f3cb92ea68f264e3f109446334936a9ce

feat: add type definitions for field layout (#221) * feat: add type definitions for field layout * refactor: modify the type definition for GroupLayout

view details

shintaroNagata

commit sha 52afe14bbb07e0f4e17f591d1f08dadbfbd53761

build: add `lint:ts` to rest-api-client-demo (#220) * chore: fix type errors * build: add `lint:ts` to rest-api-client-demo Co-authored-by: Shingo Yamazaki <shingoyamazaki00@gmail.com>

view details

Toru Kobayashi

commit sha 21e36a03ee45dd4963ea685947ecf09d59a62021

chore: add CODEOWNERS (#222)

view details

Renovate Bot

commit sha 9a9eb5fc62d38eaa38331b492bbb7a662acc8e83

chore(deps): update dependency ts-loader to ^7.0.3

view details

Masashi Hirano

commit sha a859fdb74e225ef58d65baaff1ad094819414f5d

feat: Add User-Agent header for Node.js (#213) * feat: Add User-Agent request header for Node.js * refactor: rename local variables * feat: modify the User-Agent string * test: User-Agent in Node.js environment * test: refactor a test for UserAgent string * test: User-Agent in browser environment Co-authored-by: shintaroNagata <cybozu.nagata@gmail.com> Co-authored-by: Toru Kobayashi <koba0004@gmail.com> Co-authored-by: chick-p <chick.p.1120@gmail.com>

view details

Renovate Bot

commit sha 089c0fc575d5d2f5d938eaff80033d401f095c28

chore(deps): update dependency ts-loader to ^7.0.4

view details

renovate[bot]

commit sha 5cde246ad65659b519fcd74d879a94efe46cb2da

chore(deps): update dependency typescript to ^3.9.2 (#227) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Renovate Bot

commit sha ca708190b920504200af8b64b2d433e0bdd92395

chore(deps): update dependency @types/node to ^13.13.6

view details

Renovate Bot

commit sha b1df5a8fa25e2a4374db5cc7d52c557ff32b742f

chore(deps): update dependency @types/jest to ^25.2.2

view details

renovate[bot]

commit sha 71eab055c0db1aaaaa03e402f1e8f8a20d9356fd

fix(deps): update dependency meow to v7 (#224)

view details

Shingo Yamazaki

commit sha 883214883655fdb13cf6f036b6b9aef8a1e11fd0

Publish - @kintone/rest-api-client-demo@1.0.1 - @kintone/customize-uploader@3.0.4 - @kintone/rest-api-client@1.3.0

view details

Renovate Bot

commit sha 538f4c16da3cd62631337299c11ec6a826166eee

chore(deps): update dependency @types/jest to ^25.2.3

view details

Renovate Bot

commit sha e459889b19ba183c71f5e014b87a984087154a74

chore(deps): update dependency @types/qs to ^6.9.3

view details

Renovate Bot

commit sha af3d9f6d8f8f09160d9a65ff64cbc238a5366157

chore(deps): update dependency @types/node to ^13.13.8

view details

push time in 6 days

push eventshisama/xss-test

Masashi Hirano

commit sha 8acdad5136ffb709663efea709099620719f011f

fix: TrustedTypes -> trustedTypes

view details

push time in 7 days

push eventkintone/js-sdk

Masashi Hirano

commit sha 3bc0d55968b6057a295839239994a41ea674532c

refactor: move functions which create request config to KintoneRequestConfigBuilder (#216)

view details

push time in 9 days

delete branch kintone/js-sdk

delete branch : refactor-KintoneRequestConfigBuilder

delete time in 9 days

PR merged kintone/js-sdk

Reviewers
refactor: move functions which create request config to KintoneRequestConfigBuilder

move 'buildAuth', 'buildHeader', 'buildParams' from KintoneRestAPIClient to KintoneRequestConfigBuilder.

+555 -330

0 comment

8 changed files

shisama

pr closed time in 9 days

push eventkintone/js-sdk

shisama

commit sha b7f726c824da853a26eb05459e3f94ad767724f1

refactor: use arrow function in KintoneRestAPIClient.ts

view details

push time in 9 days

push eventkintone/js-sdk

shisama

commit sha f6ae2751059783aba298742f846223f5fddce808

test: fix tests for User-Agent in Node.js environment

view details

push time in 9 days

delete branch kintone/plugin-uploader

delete branch : renovate/puppeteer-2.x

delete time in 9 days

push eventkintone/plugin-uploader

renovate[bot]

commit sha b526f25d66da9c00583eaf9bb5a7780dd5e00301

chore(deps): update dependency @types/puppeteer to ^2.1.1 (#294)

view details

push time in 9 days

PR merged kintone/plugin-uploader

Reviewers
chore(deps): update dependency @types/puppeteer to ^2.1.1 renovate

This PR contains the following updates:

Package Type Update Change
@types/puppeteer devDependencies minor ^2.0.1 -> ^2.1.1

Renovate configuration

:date: Schedule: "after 9pm,before 9am" in timezone Asia/Tokyo.

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [x] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+4 -4

0 comment

2 changed files

renovate[bot]

pr closed time in 9 days

delete branch kintone/plugin-uploader

delete branch : renovate/typescript-3.x

delete time in 9 days

push eventkintone/plugin-uploader

renovate[bot]

commit sha e040196ec4e3f9f5b1700cb9929cf4d3871a6b22

chore(deps): update dependency typescript to ^3.9.3 (#295)

view details

push time in 9 days

PR merged kintone/plugin-uploader

Reviewers
chore(deps): update dependency typescript to ^3.9.3 renovate

This PR contains the following updates:

Package Type Update Change
typescript (source) devDependencies minor ^3.8.3 -> ^3.9.3

Release Notes

<details> <summary>Microsoft/TypeScript</summary>

v3.9.3

Compare Source

This release contains bug fixes in type-checking, APIs, emit, and editor scenarios.

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

v3.9.2

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

</details>


Renovate configuration

:date: Schedule: "after 9pm,before 9am" in timezone Asia/Tokyo.

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+4 -4

0 comment

2 changed files

renovate[bot]

pr closed time in 9 days

startedTheAlgorithms/Javascript

started time in 10 days

push eventkintone/js-sdk

Renovate Bot

commit sha c2e8c8ffc3d38ccadd51a7605a4664df69a9b2ec

fix(deps): update dependency qs to ^6.9.4

view details

renovate[bot]

commit sha b24e3d13dd64e02f39f48375e39460fa2626f920

chore(deps): update dependency jest to ^25.5.4 (#210) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha c093d7ac890fb742d252c97ff11313e83971d918

chore(deps): update dependency ts-node to ^8.10.1 (#211) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Renovate Bot

commit sha 7122d9ea4aa06e49dcd5c592b3408f46ac527732

chore(deps): update dependency @types/qs to ^6.9.2

view details

Renovate Bot

commit sha ac8d5d89b8c5e20b4729835a96743efd1d20a011

chore(deps): update dependency @types/node to ^13.13.5

view details

shintaroNagata

commit sha 4ddc6ea068d136586ac90f77d6bdb058f52dab41

feat: add type definitions for field properties (#199) * feat: add type definitions for field properties * chore: remove a comment * refactor: Field -> FieldProperty Co-authored-by: Shingo Yamazaki <shingoyamazaki00@gmail.com>

view details

shintaroNagata

commit sha b135e72f3cb92ea68f264e3f109446334936a9ce

feat: add type definitions for field layout (#221) * feat: add type definitions for field layout * refactor: modify the type definition for GroupLayout

view details

shintaroNagata

commit sha 52afe14bbb07e0f4e17f591d1f08dadbfbd53761

build: add `lint:ts` to rest-api-client-demo (#220) * chore: fix type errors * build: add `lint:ts` to rest-api-client-demo Co-authored-by: Shingo Yamazaki <shingoyamazaki00@gmail.com>

view details

Toru Kobayashi

commit sha 21e36a03ee45dd4963ea685947ecf09d59a62021

chore: add CODEOWNERS (#222)

view details

Renovate Bot

commit sha 9a9eb5fc62d38eaa38331b492bbb7a662acc8e83

chore(deps): update dependency ts-loader to ^7.0.3

view details

Masashi Hirano

commit sha a859fdb74e225ef58d65baaff1ad094819414f5d

feat: Add User-Agent header for Node.js (#213) * feat: Add User-Agent request header for Node.js * refactor: rename local variables * feat: modify the User-Agent string * test: User-Agent in Node.js environment * test: refactor a test for UserAgent string * test: User-Agent in browser environment Co-authored-by: shintaroNagata <cybozu.nagata@gmail.com> Co-authored-by: Toru Kobayashi <koba0004@gmail.com> Co-authored-by: chick-p <chick.p.1120@gmail.com>

view details

Renovate Bot

commit sha 089c0fc575d5d2f5d938eaff80033d401f095c28

chore(deps): update dependency ts-loader to ^7.0.4

view details

renovate[bot]

commit sha 5cde246ad65659b519fcd74d879a94efe46cb2da

chore(deps): update dependency typescript to ^3.9.2 (#227) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Renovate Bot

commit sha ca708190b920504200af8b64b2d433e0bdd92395

chore(deps): update dependency @types/node to ^13.13.6

view details

Renovate Bot

commit sha b1df5a8fa25e2a4374db5cc7d52c557ff32b742f

chore(deps): update dependency @types/jest to ^25.2.2

view details

renovate[bot]

commit sha 71eab055c0db1aaaaa03e402f1e8f8a20d9356fd

fix(deps): update dependency meow to v7 (#224)

view details

Shingo Yamazaki

commit sha 883214883655fdb13cf6f036b6b9aef8a1e11fd0

Publish - @kintone/rest-api-client-demo@1.0.1 - @kintone/customize-uploader@3.0.4 - @kintone/rest-api-client@1.3.0

view details

Renovate Bot

commit sha 538f4c16da3cd62631337299c11ec6a826166eee

chore(deps): update dependency @types/jest to ^25.2.3

view details

Renovate Bot

commit sha e459889b19ba183c71f5e014b87a984087154a74

chore(deps): update dependency @types/qs to ^6.9.3

view details

shisama

commit sha 219bb278ea5332ffdb2b794c0e1bb0bdf3eb1219

refactor: move buildXXX to KintoneRequestConfigBuilder move 'buildAuth', 'buildHeader', 'buildParams' from KintoneRestAPIClient to KintoneRequestConfigBuilder.

view details

push time in 10 days

issue openedmozilla-japan/translation

Intl.RelativeTimeFormat の翻訳

こちらの翻訳をします。 https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/RelativeTimeFormat

created time in 12 days

push eventkintone/js-sdk

shisama

commit sha 7f7ed0561a02001cfee66ee0f87d802aee1c7f5b

deps: remove type-fest from rest-api-client devDeps

view details

push time in 13 days

issue commentkintone/js-sdk

Feature request: fileUpload supports Stream

@TakashiAihara Thank you for your proposal. We will release this as a new feature in a few months.

TakashiAihara

comment created time in 13 days

push eventkintone/plugin-packer

renovate[bot]

commit sha 0ff1900974d944dea980d615cc06a4e71829c4e1

fix(deps): update dependency meow to v7 (#516)

view details

push time in 16 days

delete branch kintone/plugin-packer

delete branch : renovate/meow-7.x

delete time in 16 days

PR merged kintone/plugin-packer

Reviewers
fix(deps): update dependency meow to v7 renovate

This PR contains the following updates:

Package Type Update Change
meow dependencies major ^6.1.1 -> ^7.0.1

Release Notes

<details> <summary>sindresorhus/meow</summary>

v7.0.1

Compare Source

v7.0.0

Compare Source

Breaking
Improvements

</details>


Renovate configuration

:date: Schedule: "after 9pm,before 9am" in timezone Asia/Tokyo.

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+16 -4

0 comment

2 changed files

renovate[bot]

pr closed time in 16 days

delete branch kintone/js-sdk

delete branch : renovate/meow-7.x

delete time in 16 days

push eventkintone/js-sdk

renovate[bot]

commit sha 71eab055c0db1aaaaa03e402f1e8f8a20d9356fd

fix(deps): update dependency meow to v7 (#224)

view details

push time in 16 days

PR merged kintone/js-sdk

Reviewers
fix(deps): update dependency meow to v7 renovate

This PR contains the following updates:

Package Type Update Change
meow dependencies major ^6.1.1 -> ^7.0.1

Release Notes

<details> <summary>sindresorhus/meow</summary>

v7.0.1

Compare Source

v7.0.0

Compare Source

Breaking
Improvements

</details>


Renovate configuration

:date: Schedule: "after 9pm,before 9am" in timezone Asia/Tokyo.

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+17 -5

0 comment

2 changed files

renovate[bot]

pr closed time in 16 days

push eventkintone/js-sdk

shisama

commit sha 9323cabb58f701dddaaebcd99e3f8ae9a2e39fe8

test: User-Agent in Node.js environment

view details

push time in 23 days

push eventkintone/js-sdk

Toru Kobayashi

commit sha 21e36a03ee45dd4963ea685947ecf09d59a62021

chore: add CODEOWNERS (#222)

view details

push time in 23 days

delete branch kintone/js-sdk

delete branch : add-codeowners

delete time in 23 days

PR merged kintone/js-sdk

chore: add CODEOWNERS
+2 -0

0 comment

1 changed file

koba04

pr closed time in 23 days

pull request commentprettier/prettier

JS: Keep the position of end-of-line comments in binary expressions

I don't know any issue related to this PR. I think there aren't.

shisama

comment created time in 24 days

Pull request review commentprettier/prettier

JS: Keep the position of end-of-line comments in binary expressions

 const unstableTests = new Map(     "class_comment/comments.js",     ["comments/dangling_array.js", (options) => options.semi === false],     ["comments/jsx.js", (options) => options.semi === false],+    "comments/binary-expressions-single-comments.js",

I agree. I have ideas.

  1. Unstable test files have // Flag: unstable test comment on the top.
  2. Make tests/unstable directory and move unstable test files into it.
  3. Move this list to another file. (e.g. unstable_tests.json) This is easiest to implement.

Do you have any ideas?

shisama

comment created time in 24 days

push eventshisama/prettier

shisama

commit sha bc33687dab83475ea05e7641bfbe929fe36933e5

Divide and rename test files for handleBinaryExpression()

view details

push time in 25 days

pull request commentprettier/prettier

JS: Keep the position of end-of-line comments in binary expressions

@thorn0 Thanks for your review. I fixed them. Please take a look again.

shisama

comment created time in 25 days

Pull request review commentprettier/prettier

JS: Keep the position of end-of-line comments in binary expressions

 function handleTSMappedTypeComments(   return false; } +function handleEndOfLineBlockComments(+  text,+  enclosingNode,+  followingNode,+  comment,+  options+) {+  if (+    enclosingNode &&+    (enclosingNode.type === "LogicalExpression" ||+      enclosingNode.type === "BinaryExpression") &&+    followingNode &&+    isBlockComment(comment) &&+    privateUtil.hasNewline(text, options.locEnd(comment))

That's exactly. This is fixed on https://github.com/prettier/prettier/pull/7787/commits/a6dabaf7d0a05b023225be76307104f2a361d282.

shisama

comment created time in 25 days

push eventshisama/prettier

shisama

commit sha 59297087e019523bf85fd415e24e0e8af7c20832

Divide and rename test files for handleBinaryExpression()

view details

push time in 25 days

push eventkintone/js-sdk

Masashi Hirano

commit sha ee6a99c423bb6cbdceeb2d56a0d30f478ce901ab

fix: remove unnecessary comments

view details

push time in 25 days

push eventshisama/prettier

shisama

commit sha a6dabaf7d0a05b023225be76307104f2a361d282

Refactor handleBinaryExpression to remove unneed condition & params

view details

push time in 25 days

Pull request review commentprettier/prettier

JS: Keep the position of end-of-line comments in binary expressions

 function handleTSMappedTypeComments(   return false; } +function handleLogicalExpression(+  text,+  enclosingNode,+  precedingNode,+  followingNode,+  comment,+  options+) {+  if (enclosingNode && enclosingNode.type === "LogicalExpression") {+    if (+      followingNode &&+      isBlockComment(comment) &&+      privateUtil.hasNewline(text, options.locEnd(comment))+    ) {+      addLeadingComment(followingNode, comment);+      return true;+    }+  }+  return false;+}++function handleBinaryExpression(+  text,

Thanks. I fixed on https://github.com/prettier/prettier/pull/7787/commits/3f743fd26274e3cddd97aa223c5e5524d5dddd38.

shisama

comment created time in 25 days

push eventshisama/prettier

shisama

commit sha 3f743fd26274e3cddd97aa223c5e5524d5dddd38

Rename handleEndOfLineBlockComments to handleBinaryExpression

view details

push time in 25 days

PR opened kintone/js-sdk

refactor: move buildXXX to KintoneRequestConfigBuilder

move 'buildAuth', 'buildHeader', 'buildParams' from KintoneRestAPIClient to KintoneRequestConfigBuilder.

+188 -179

0 comment

4 changed files

pr created time in 25 days

create barnchkintone/js-sdk

branch : refactor-KintoneRequestConfigBuilder

created branch time in 25 days

Pull request review commentprettier/prettier

JS: Keep the position of end-of-line comments in binary expressions

 function handleTSMappedTypeComments(   return false; } +function handleLogicalExpression(+  text,+  enclosingNode,+  precedingNode,+  followingNode,+  comment,+  options+) {+  if (enclosingNode && enclosingNode.type === "LogicalExpression") {+    if (+      followingNode &&+      isBlockComment(comment) &&+      privateUtil.hasNewline(text, options.locEnd(comment))+    ) {+      addLeadingComment(followingNode, comment);+      return true;+    }+  }+  return false;+}++function handleBinaryExpression(+  text,

@thorn0 OK, I fixed it on https://github.com/prettier/prettier/pull/7787/commits/51f1b50df4ce5b5f2da8211aad77c3d210628fe8 Though I named the function handleEndOfLineBlockComments, I am worrying if it is suitable for it. Would you give me some advice if you have any idea?

shisama

comment created time in 25 days

push eventshisama/node

shisama

commit sha 44dea356f512f812d68174b4260c29fecde3f799

test: fix dns/promises test

view details

push time in 25 days

push eventshisama/node

shisama

commit sha 7889666ee119b6d6660b532d91c2b4b6f50cabff

test: fix dns/promises test

view details

push time in 25 days

push eventshisama/prettier

shisama

commit sha 51f1b50df4ce5b5f2da8211aad77c3d210628fe8

fix: make two functions one 'handleEndOfLineBlockComments'

view details

push time in 25 days

PR opened kintone/js-sdk

feat: Support Node.js Native ES Modules

Node.js has already supported ES Modules. see https://nodejs.org/api/esm.html

However, Node.js ESM is still experimental.

+53 -0

0 comment

4 changed files

pr created time in a month

create barnchkintone/js-sdk

branch : nodejs-native-esm

created branch time in a month

PR opened kintone/js-sdk

feat: Add User-Agent request header for Node.js

fix #204

+21 -1

0 comment

4 changed files

pr created time in a month

create barnchkintone/js-sdk

branch : nodejs-useragent

created branch time in a month

issue closedmozilla-japan/translation

Intl.DisplayNames の翻訳

表題のとおり Intl.DisplayNames の翻訳を行いました。レビューしていただけると幸いです。

https://wiki.developer.mozilla.org/ja/docs/Web/JavaScript/Reference/Global_Objects/Intl/DisplayNames

closed time in a month

shisama

issue commentmozilla-japan/translation

Intl.DisplayNames の翻訳

ありがとうございます。タグの付加は次回から気をつけます。

shisama

comment created time in a month

pull request commentprettier/prettier

JS: Keep the position of end-of-line comments in binary expressions

sencond format tests failed. So, tests for this are added to unstable tests (ref: https://github.com/prettier/prettier/pull/7565/ ).

// original
a = b || // TODO this is a very very very very long comment that makes it go > 80 columns
c;

// first format
a =
  b || c; // TODO this is a very very very very long comment that makes it go > 80 columns

// second format
a = b || c; // TODO this is a very very very very long comment that makes it go > 80 columns
shisama

comment created time in a month

pull request commentprettier/prettier

JS: Keep the position of end-of-line comments in binary expressions

I rebased this and resolved the problem of the extra spaces after comment.

shisama

comment created time in a month

push eventshisama/prettier

shisama

commit sha 3713f43fb5efbd8167a4889c4a0e76c9238c9014

test: add comments/binary-expressions-trailing-space.js

view details

push time in a month

push eventshisama/prettier

shisama

commit sha 8cfecc716aba0186b1e2bb28aa5e71e6f3f58b8c

test: logical-expression.js as unstable tests

view details

push time in a month

push eventshisama/prettier

fisker Cheung

commit sha 82676f6308322496d71d8ea43853190e710e678f

Keep object key with escape sequence as it is (#8160)

view details

fisker Cheung

commit sha 4c4d044fbb4b785552d600849f881498a78d8d11

Bump `eslint-plugin-unicorn` to v19 (#8158)

view details

dependabot-preview[bot]

commit sha 868973b3347fa25a83ba1a43ed29fa15e28e3538

Bump terser-webpack-plugin from 2.3.5 to 2.3.6 (#8167) Bumps [terser-webpack-plugin](https://github.com/webpack-contrib/terser-webpack-plugin) from 2.3.5 to 2.3.6. - [Release notes](https://github.com/webpack-contrib/terser-webpack-plugin/releases) - [Changelog](https://github.com/webpack-contrib/terser-webpack-plugin/blob/master/CHANGELOG.md) - [Commits](https://github.com/webpack-contrib/terser-webpack-plugin/compare/v2.3.5...v2.3.6) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha 1cae1175cc3bb54567f0372fc89eac3ec8d80695

Bump concurrently from 5.1.0 to 5.2.0 in /website (#8166) Bumps [concurrently](https://github.com/kimmobrunfeldt/concurrently) from 5.1.0 to 5.2.0. - [Release notes](https://github.com/kimmobrunfeldt/concurrently/releases) - [Commits](https://github.com/kimmobrunfeldt/concurrently/compare/v5.1.0...v5.2.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha 43cba5d31c6290c759c3335cb62b222ef8bac753

Bump @typescript-eslint/typescript-estree from 2.29.0 to 2.30.0 (#8176) Bumps [@typescript-eslint/typescript-estree](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-estree) from 2.29.0 to 2.30.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/typescript-estree/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v2.30.0/packages/typescript-estree) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha d7f95709b03ace622c49c512e43468d655d82821

Bump rollup from 2.7.2 to 2.7.3 (#8174)

view details

dependabot-preview[bot]

commit sha d344bed4180ed933ecb3638505d04d301f2d93a3

Bump @glimmer/syntax from 0.51.0 to 0.51.1 (#8175) Bumps [@glimmer/syntax](https://github.com/glimmerjs/glimmer-vm) from 0.51.0 to 0.51.1. - [Release notes](https://github.com/glimmerjs/glimmer-vm/releases) - [Changelog](https://github.com/glimmerjs/glimmer-vm/blob/master/CHANGELOG.md) - [Commits](https://github.com/glimmerjs/glimmer-vm/compare/v0.51.0...v0.51.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

fisker Cheung

commit sha c0dab6bb7c1b69e4b8334510411147a0fdfcc678

Remove outdated script (#8163)

view details

fisker Cheung

commit sha 14f5f8589f4a2a9825e0b5a47270a5a27978d1fb

Less: parser `:extend` as selector (#8178)

view details

dependabot-preview[bot]

commit sha e245f325985d74a661d0243949995ced54cc00f9

Bump rollup from 2.7.3 to 2.7.5 (#8189) Bumps [rollup](https://github.com/rollup/rollup) from 2.7.3 to 2.7.5. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](https://github.com/rollup/rollup/compare/v2.7.3...v2.7.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha a34a95d051ddd05341ee134bc9305df879e0d92a

Bump @babel/core from 7.9.0 to 7.9.6 (#8188) Bumps [@babel/core](https://github.com/babel/babel) from 7.9.0 to 7.9.6. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](https://github.com/babel/babel/compare/v7.9.0...v7.9.6) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

fisker Cheung

commit sha 0dee55c534bf6f9855a52bb7353d08608f943258

Add missing peer dependency `tslib` (#8161)

view details

dependabot-preview[bot]

commit sha b1664af318356ea2e33af7da7f60a95d58b6b0c3

Bump @babel/preset-env from 7.9.5 to 7.9.6 in /website (#8197) Bumps [@babel/preset-env](https://github.com/babel/babel) from 7.9.5 to 7.9.6. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](https://github.com/babel/babel/compare/v7.9.5...v7.9.6) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha 31a7672bd7400bc92528a89a16e0bed753678f67

Bump @babel/parser from 7.9.4 to 7.9.6 (#8186) Bumps [@babel/parser](https://github.com/babel/babel) from 7.9.4 to 7.9.6. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](https://github.com/babel/babel/compare/v7.9.4...v7.9.6) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha 88104372d3ac87e98bb529f0f054a6a83c11c997

Bump @babel/preset-env from 7.9.5 to 7.9.6 (#8187) Bumps [@babel/preset-env](https://github.com/babel/babel) from 7.9.5 to 7.9.6. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](https://github.com/babel/babel/compare/v7.9.5...v7.9.6) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha 69d5c55da91cfbb281b2291b547a31e4c3272dc6

Bump rollup from 2.7.5 to 2.7.6 (#8199) Bumps [rollup](https://github.com/rollup/rollup) from 2.7.5 to 2.7.6. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](https://github.com/rollup/rollup/compare/v2.7.5...v2.7.6) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

shisama

commit sha c0a8cc74ecc0bba6704e74e0d6866d6951902193

JS: block comments with LogicalExpression

view details

shisama

commit sha b9f6fd1cd7c2fee2415fbb33b548d0b916b46063

Add changelog_unreleased for #7787

view details

shisama

commit sha ee5578ce59aa29bfa27925fbdfd5a65b56ae2057

Add handleBinaryExpression in comments.js

view details

shisama

commit sha 6ec0da092fc156416b904718d6f721919288c09d

Refactor comments.js to use isBlockComment

view details

push time in a month

push eventkintone/config-helper

renovate[bot]

commit sha d02bb229ebe24384d4791705dbfb65f8a0818e65

chore(deps): update dependency tslint-plugin-prettier to ^2.3.0 (#27)

view details

push time in a month

delete branch kintone/config-helper

delete branch : renovate/tslint-plugin-prettier-2.x

delete time in a month

PR merged kintone/config-helper

Reviewers
chore(deps): update dependency tslint-plugin-prettier to ^2.3.0 renovate

This PR contains the following updates:

Package Type Update Change
tslint-plugin-prettier devDependencies minor ^2.2.0 -> ^2.3.0

Release Notes

<details> <summary>prettier/tslint-plugin-prettier</summary>

v2.3.0

Compare Source

Features

</details>


Renovate configuration

:date: Schedule: "after 9pm,before 9am" in timezone Asia/Tokyo.

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+1 -1

0 comment

1 changed file

renovate[bot]

pr closed time in a month

PR opened zeit/next-plugins

doc: add preact-render-to-string in installation

preact/compat needs preact-render-to-string for server-side. see: https://github.com/preactjs/preact/blob/master/compat/server.js

+2 -2

0 comment

1 changed file

pr created time in a month

push eventshisama/next-plugins

Masashi Hirano

commit sha cf0e0e0d3e77d2411bcbb62714c7a515fb48e0df

doc: add preact-render-to-string in installation preact/compat needs preact-render-to-string for server-side.

view details

push time in a month

fork shisama/next-plugins

Official Next.js plugins

fork in a month

issue closedpaulmillr/readdirp

Update Node.js minimum required version.

According to package.json, this package seems to support Node.js v8. https://github.com/paulmillr/readdirp/blob/d9c72137579b439fe0f8bb8d668f6b6846c75c45/package.json#L21

However, Node.js v8 has already been end-of-life on Dec 31, 2019.

https://github.com/nodejs/Release

If it is Node.js v10.13, fs.promises can be used. It is available to use fs.Dirent too, which is faster than fs.stat to check whether an entry is a file or a directory.

Another idea is that the minimum required version will be Node.js v12 for #105 . Node.js v12 has already been LTS.

If minimum required Node.js version is updated, it will be a breaking change.

Are you planning to update Node.js minimum required version?

closed time in a month

shisama

issue commentpaulmillr/readdirp

Update Node.js minimum required version.

Thank you for your reply. I did not know this has already used Dirent. I should have read code more carefully. I understood what you wrote. So I will close this issue. Thank you for your great works.

shisama

comment created time in a month

issue openedpaulmillr/readdirp

Update Node.js minimum required version.

According to package.json, this package seems to support Node.js v8. https://github.com/paulmillr/readdirp/blob/d9c72137579b439fe0f8bb8d668f6b6846c75c45/package.json#L21

However, Node.js v8 has already been end-of-life. If it is Node.js v10.13, fs.promises can be used. It is available to use fs.Dirent too, which is faster than fs.stat to check whether an entry is a file or a directory.

Another idea is that the minimum required version will be Node.js v12 for #105 . Node.js v12 has already been LTS.

Are you planning to update Node.js minimum required version?

created time in a month

pull request commentnodejs/node

dns: Add dns/promises alias

@addaleax Thank you. I added setServers() into 'dns/promises'.

shisama

comment created time in a month

push eventshisama/node

shisama

commit sha 4bfbeffec25bccd5ebb96e6f6d3055e8810be3be

dns: Add setServers into 'dns/promises'

view details

push time in a month

issue openedmozilla-japan/translation

Intl.DisplayNames の翻訳

表題のとおり Intl.DisplayNames の翻訳を行いました。レビューしていただけると幸いです。

https://wiki.developer.mozilla.org/ja/docs/Web/JavaScript/Reference/Global_Objects/Intl/DisplayNames

created time in a month

push eventshisama/prettier

fisker Cheung

commit sha c0cd681af05404827e5cb9a399692d29ad5d2f06

Run tests on Node.js v14 (#8126)

view details

fisker Cheung

commit sha f83eb9d5efe5bb017679635ecdbf00d06588552e

Preserve non-ASCII whitespace characters in HTML (#8137) * Add html whitespace tests * `U+0005` -> `U+2005` * Update tests * Fix whitespace * Add changelog * Another space * Restore `non-breaking` check * Add space between tests * Extract all space related codes to utils * Fix indent detect * Update changelog * Another space * Rename * Rename * Rename * Use `htmlTrimFirstLine` and `htmlTrimEnd` * Assert with output * `htmlTrimPreserveIndentation` * Update changelog * Fix another space

view details

fisker Cheung

commit sha e69e90f067ee234d3da2c9c430958e6159a0896c

Fix object trailing commas that last property is ignored (#8111) * Add failed tests * Fix trailing commas when last property is ignored * Add changelog * Add nested tests * changelog title

view details

fisker Cheung

commit sha 99b0fae7e1c0a8ead2b56c3ea037489a7b82915a

Add `ObjectPattern` tests for #8111 (#8155)

view details

shisama

commit sha fb19fc5ee8559edccf2a96c9bcb4922534a00456

JS: block comments with LogicalExpression

view details

shisama

commit sha 05d0f9d2970a237b009f14c59a13e497114b78b4

Add changelog_unreleased for #7787

view details

shisama

commit sha c22239d4922f34baff8d9af499d84eabdbdf19ce

Add handleBinaryExpression in comments.js

view details

shisama

commit sha 7acc3dd72b5f6132fec6465463ed3f1d8559bb03

Refactor comments.js to use isBlockComment

view details

Georgii Dolzhykov

commit sha d9f9d8b713703bf0a325bcf28f6b18896a0fa2e2

Update pr-7787.md

view details

Georgii Dolzhykov

commit sha d752e8c0807c3449cae6d8f2709064d9b5f46ca1

Update pr-7787.md

view details

shisama

commit sha 3b1aa3fddb2abe97cc582db0727d0cd9eb06fac4

test: regenerate snapshot for comments/logical-expression

view details

push time in a month

push eventshisama/shisama.github.io

Masashi Hirano

commit sha e4ac5855ff284304de78487a42fd1529c442dd2f

Delete package.json~

view details

push time in a month

push eventcybozu/eslint-config

renovate[bot]

commit sha 2167655823ed46ac9d727713a97a036b5442967a

fix(deps): update typescript-eslint monorepo to ^2.29.0 (#266) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in a month

PR merged cybozu/eslint-config

Reviewers
fix(deps): update typescript-eslint monorepo to ^2.29.0 (minor) renovate

This PR contains the following updates:

Package Type Update Change
@typescript-eslint/eslint-plugin dependencies minor ^2.28.0 -> ^2.29.0
@typescript-eslint/parser dependencies minor ^2.28.0 -> ^2.29.0

Release Notes

<details> <summary>typescript-eslint/typescript-eslint</summary>

v2.29.0

Compare Source

Bug Fixes
  • eslint-plugin: [no-base-to-string] soft remove ignoreTaggedTemplateExpressions option (#​1916) (369978e)
Features
  • eslint-plugin: [no-floating-promise] add option to ignore IIFEs (#​1799) (cea51bf)
  • eslint-plugin: [restrict-template-expressions] add support for intersection types (#​1803) (cc70e4f)
  • eslint-plugin: add extension rule init-declarations (#​1814) (b01f5e7)
  • eslint-plugin: add extension rule keyword-spacing (#​1739) (c5106dd)

</details>


Renovate configuration

:date: Schedule: "after 9pm,before 9am" in timezone Asia/Tokyo.

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about these updates again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+18 -18

0 comment

2 changed files

renovate[bot]

pr closed time in a month

push eventshisama/prettier

Vrq

commit sha 7c1d06399f0a2122b6039048f6e565e8fd83065f

Adding SwissDev DevOps Jobs to users (#7769) * Add SwissDev DevOps Jobs logo * Add SwissDev Jobs

view details

dependabot[bot]

commit sha aa0eebe1ed4db42a58441aa239145623fb84d4c8

Bump minimist from 1.2.0 to 1.2.2 (#7774) Bumps [minimist](https://github.com/substack/minimist) from 1.2.0 to 1.2.2. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.0...1.2.2) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

dependabot[bot]

commit sha 94a487f19c0ca47d09c59da6d8b0191d245a5669

Bump acorn from 5.7.3 to 5.7.4 (#7767) Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](https://github.com/acornjs/acorn/compare/5.7.3...5.7.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

Hugo Locurcio

commit sha 43aaef6cdf4b350f84d263e109215cd67dee47da

Fix broken HTML anchor in the Rationale documentation (#7783) The italic Markdown formatting is included in the automatically generated ID, so it must be present in the references as well.

view details

dependabot[bot]

commit sha bbf4f6ef0dc498f4f12cb04c8708aeda1b79b203

Bump acorn from 6.3.0 to 6.4.1 in /website (#7768) Bumps [acorn](https://github.com/acornjs/acorn) from 6.3.0 to 6.4.1. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](https://github.com/acornjs/acorn/compare/6.3.0...6.4.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

dependabot[bot]

commit sha 29b9f6b9e9e2885666cdb712c45e2347b679b477

Bump minimist from 1.2.0 to 1.2.2 in /scripts/release (#7776) Bumps [minimist](https://github.com/substack/minimist) from 1.2.0 to 1.2.2. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.0...1.2.2) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha 0836ee181170460ce3a70edba91780f486e74bf2

Bump rollup from 2.0.6 to 2.1.0 (#7789) Bumps [rollup](https://github.com/rollup/rollup) from 2.0.6 to 2.1.0. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](https://github.com/rollup/rollup/compare/v2.0.6...v2.1.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

fisker Cheung

commit sha c82ce657e3f78571776120bd1e97f72d3684e009

Run verify test on disabled `babel-ts` tests (#7786)

view details

dependabot-preview[bot]

commit sha 24766d9cfb24329656ce293df9a5bee4554523a1

Bump flow-parser from 0.120.1 to 0.121.0 (#7793) Bumps [flow-parser](https://github.com/facebook/flow) from 0.120.1 to 0.121.0. - [Release notes](https://github.com/facebook/flow/releases) - [Changelog](https://github.com/facebook/flow/blob/master/Changelog.md) - [Commits](https://github.com/facebook/flow/compare/v0.120.1...v0.121.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

Georgii Dolzhykov

commit sha 1ad13d74200199f61be3213196f09440d60d7bc7

Ultimate fix for Closure-style type casts (#7791)

view details

Evilebot Tnawi

commit sha 4602bb6b95a37eb38f423df0fd7ef19ae5ee2f58

refactor css comments (#7021) * refactor css comments * workarounds for postcss-less location bugs * improve replaceQuotesInInlineComments * update changelog * fix comments in selectors * fix comments in values * use \ufffe instead of \0 because that's what these characters are for see http://www.unicode.org/faq/private_use.html#nonchar6 * fix quoted urls Co-authored-by: Georgii Dolzhykov <thorn.mailbox@gmail.com>

view details

Georgii Dolzhykov

commit sha b3008f2cafc7543b7553565c53054152e1ed9245

Merge remote-tracking branch 'remotes/upstream/master' into next

view details

dependabot-preview[bot]

commit sha 12d0be9874b5d5c3aac26ba9b7696f68afe14645

Bump react from 16.13.0 to 16.13.1 in /website (#7801) Bumps [react](https://github.com/facebook/react/tree/HEAD/packages/react) from 16.13.0 to 16.13.1. - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/master/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/v16.13.1/packages/react) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

fisker Cheung

commit sha 71b2d35d59a3573c7ad8cc9f2dee047e75824035

Test second format (#7565)

view details

Sosuke Suzuki

commit sha 20c7a5ab9a6ff29d7622a4126d6dd215ece1ec35

Support type only import/export via `babel-ts` (#7804)

view details

Georgii Dolzhykov

commit sha 6d0607cebfffba6ab4d8a0419fd317bb1af79715

Update release script

view details

Georgii Dolzhykov

commit sha 262423a0f9fcb80436f3f04a85de7dd2ff70eb10

run yarn-deduplicate

view details

Georgii Dolzhykov

commit sha 5b3028e220983b7b9bcccc0329b0cc6fb0999bcd

Release 2.0.0

view details

Georgii Dolzhykov

commit sha 9dad95b35f935edce4c3d6cfa45c79a0b9c82b9f

Bump Prettier dependency to 2.0.0

view details

Georgii Dolzhykov

commit sha 8334610aa26f6391a30dd285121692ae23700e7a

Blog post for 2.0 (#7417) * add a script that concatenates changelog_unreleased into a blog post draft * syntax highlighting issues * generate post draft * Copy edit, remove error stacks * Update 2020-00-00-2.0.0.md * Update changelog source files * edit entries, regenerate the post * add lost file in versioned_docs Co-authored-by: Jed Fox <git@twopointzero.us>

view details

push time in a month

Pull request review commentprettier/prettier

JS: Fix end-of-line comments if followed by trailing whitespace

 // Do not trim trailing whitespace from this source file!  // There is some space here ->                        ++var a = { /* extra whitespace --> */  +  b };+var a = { /* no whitespace --> */+  b };

Thanks. I created a new test file. Please check it.

shisama

comment created time in a month

push eventshisama/prettier

shisama

commit sha 960ecb469c0cf6342226661b606fb1028c7e3e2f

test: Add trailing-extra-space.js

view details

push time in a month

push eventshisama/prettier

shisama

commit sha d29f77faf67dd19e22461d23180d8b91f3fff347

test: Add trailing-extra-space.js

view details

push time in a month

push eventshisama/prettier

fisker Cheung

commit sha e1a6a7a6a1471d97113ddb68889957469ce5c280

Fix less `:extend` format (#7984)

view details

fisker Cheung

commit sha 2a9f65104d0800e9c1222471b7f5cb2391ac1f49

Enable GitHub Actions for a patch-release branch (#8024) Co-authored-by: Georgii Dolzhykov <thorn.mailbox@gmail.com>

view details

Georgii Dolzhykov

commit sha 1bfef8120622bf64ee8cce12e087a91303133a83

Fix unexpected GitHub Actions failures (#7980)

view details

fisker Cheung

commit sha 118b79f0c9e80223f32ba1ed41f7ddcb3f275c35

Refactor production tests (#8073)

view details

fisker Cheung

commit sha be094b8886b64c7a6f7c5777381823c619848a79

Simplify production tests (#8075)

view details

dependabot-preview[bot]

commit sha 34f77e5649399e8963c14449fa2e3246ef37d205

Bump @glimmer/syntax from 0.50.3 to 0.50.4 (#8070) Bumps [@glimmer/syntax](https://github.com/glimmerjs/glimmer-vm) from 0.50.3 to 0.50.4. - [Release notes](https://github.com/glimmerjs/glimmer-vm/releases) - [Changelog](https://github.com/glimmerjs/glimmer-vm/blob/master/CHANGELOG.md) - [Commits](https://github.com/glimmerjs/glimmer-vm/compare/v0.50.3...v0.50.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

fisker Cheung

commit sha be56c725c05c5ef44ae7447379cc32e890a2ddc2

Show options in test title (#7785) * Show options in test title * Update snapshots

view details

fisker Cheung

commit sha 0f3967b5ab66f68b9b3c6a29eae5735140174ef3

Correct `standalone test` environment variable (#8080)

view details

Georgii Dolzhykov

commit sha 58905cdf579bde69610c45d4b3cfaf939c664d47

chore: update .gitignore and tsconfig.json - I often find myself testing formatting on more than one test file, so now files like `test2.js` in the root are ignored. - Coverage reports contain JS files. `tsc` should ignore them.

view details

fisker Cheung

commit sha 71fbd6149a00c304202c2f29937fffceaf06eb56

Refactor production tests (#8073) # Conflicts: # scripts/test-dist.js

view details

fisker Cheung

commit sha fc5f5462eaa2cb4bec49e6fb44ba1c48b071afaf

Simplify production tests (#8075)

view details

fisker Cheung

commit sha eaca5dbe2683d0eca21e6ac57c42cd57f4085397

Correct `standalone test` environment variable (#8080)

view details

Georgii Dolzhykov

commit sha b66f4af4d8a848b89fe01d7b306a464807ba5902

playground: fix how ranges are rendered (#8086)

view details

dependabot-preview[bot]

commit sha c4e10dd1119183312e07f703b72740668292bcb7

Bump jest from 25.3.0 to 25.4.0 (#8090) Bumps [jest](https://github.com/facebook/jest) from 25.3.0 to 25.4.0. - [Release notes](https://github.com/facebook/jest/releases) - [Changelog](https://github.com/facebook/jest/blob/master/CHANGELOG.md) - [Commits](https://github.com/facebook/jest/compare/v25.3.0...v25.4.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha a9365e9925e4fd65ccb35924fc74fff1a858f495

Bump cspell from 4.0.56 to 4.0.57 (#8093) Bumps [cspell](https://github.com/streetsidesoftware/cspell) from 4.0.56 to 4.0.57. - [Release notes](https://github.com/streetsidesoftware/cspell/releases) - [Commits](https://github.com/streetsidesoftware/cspell/compare/cspell@4.0.56...cspell@4.0.57) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha ea8330a22fb944bb6a0ccb0ec1546d842db7a97f

Bump @rollup/plugin-json from 4.0.2 to 4.0.3 (#8091) Bumps [@rollup/plugin-json](https://github.com/rollup/plugins) from 4.0.2 to 4.0.3. - [Release notes](https://github.com/rollup/plugins/releases) - [Commits](https://github.com/rollup/plugins/compare/url-v4.0.2...json-v4.0.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

Georgii Dolzhykov

commit sha 299f2cad583cce07e6ba56893ef9c75670391cb5

chore: ignore test*.js in eslint and ts configs

view details

fisker Cheung

commit sha cfb28d632caf539d68cbbea89a5c2f241f681707

Use `resolve` if `require.resolve` is overridden (#8072)

view details

fisker Cheung

commit sha 3a373074bcce194f5a9c6470ac545f366f0dd5f0

Run tests on snippets instead of files (#8088) Co-authored-by: Georgii Dolzhykov <thorn.mailbox@gmail.com>

view details

dependabot-preview[bot]

commit sha 9ad12ac49ceb340d32caa3e06b00eb64940f79ad

Bump resolve from 1.16.0 to 1.16.1 (#8099) Bumps [resolve](https://github.com/browserify/resolve) from 1.16.0 to 1.16.1. - [Release notes](https://github.com/browserify/resolve/releases) - [Commits](https://github.com/browserify/resolve/compare/v1.16.0...v1.16.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

push time in a month

push eventshisama/prettier

shisama

commit sha f06e95166ce43fcb0ff61393da147b5133250039

test: Add trailing-extra-space.js

view details

push time in a month

push eventcybozu/duck

Toru Kobayashi

commit sha 7bcf5e731112525350f430075ea1a189c6af4f58

deps: fix missing nan as a dependency (#444)

view details

push time in a month

delete branch cybozu/duck

delete branch : fix-missing-nan

delete time in a month

PR merged cybozu/duck

Reviewers
deps: fix missing nan as a dependency

Currently, npm ci is failing because of "Cannot find module 'nan'", so I've reinstalled faastjs to fix this.

+64 -48

1 comment

1 changed file

koba04

pr closed time in a month

push eventshisama/prettier

shisama

commit sha 2acadf37acdd3134c2b9737806503b760dc24672

test: Add test for comments with trailing space

view details

push time in a month

pull request commentnodejs/node

dns: Add dns/promises alias

OK. According to https://github.com/nodejs/node/pull/31553#issuecomment-580529376 , this seems semver-major as well as fs/promises.

shisama

comment created time in a month

issue commentnodejs/node

Can’t import fs Promises API with ECMAScript Modules

#32953 is the PR for dns/promises.

dieulot

comment created time in a month

PR opened nodejs/node

dns: Add dns/promises alias

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

This adds dns/promises alias to dns.promises. fs/promises has already been added. (#31553)

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ ] tests and/or benchmarks are included
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+25 -1

0 comment

5 changed files

pr created time in a month

create barnchshisama/node

branch : dns-slash-promises

created branch time in a month

more