profile
viewpoint
Mishal Shah shahmishal @apple Bay Area (California) swift.org Swift @ 

apple/swift-docker 1118

Docker Official Image packaging for Swift

shahmishal/calabash-checklist 2

Check if the system is setup correctly to start automating in calabash framework.

shahmishal/appurify-ruby 0

Ruby wrapper for Appurify API

shahmishal/docs 0

Documentation for Docker Official Images in docker-library

shahmishal/license-checker-demo 0

Fork this repository to your personal account to test your licence-checker GitHub App

shahmishal/official-images 0

Primary source of truth for the Docker "Official Images" program

push eventapple/swift

Mike Ash

commit sha c673c13548bfadb03a37eedd833766e3b4892ffa

[Runtime] #ifdef __clang__ on printf __attribute__ in Portability.h

view details

Saleem Abdulrasool

commit sha 8b5869ce6217b1f0bdf076b81a2fb83e0502adee

Merge pull request #35566 from mikeash/whoops-i-did-it-again [Runtime] #ifdef __clang__ on printf __attribute__ in Portability.h

view details

swift-ci

commit sha c12be942b1f2622b1c32bc7d2a7685fb130a8d7f

Merge remote-tracking branch 'origin/main' into rebranch

view details

push time in 15 minutes

push eventapple/swift

Mike Ash

commit sha c673c13548bfadb03a37eedd833766e3b4892ffa

[Runtime] #ifdef __clang__ on printf __attribute__ in Portability.h

view details

Saleem Abdulrasool

commit sha 8b5869ce6217b1f0bdf076b81a2fb83e0502adee

Merge pull request #35566 from mikeash/whoops-i-did-it-again [Runtime] #ifdef __clang__ on printf __attribute__ in Portability.h

view details

push time in 28 minutes

PR merged apple/swift

[Runtime] #ifdef __clang__ on printf __attribute__ in Portability.h

I broke the Windows build again.

+4 -1

1 comment

1 changed file

mikeash

pr closed time in 28 minutes

push eventapple/swift

Konrad `ktoso` Malawski

commit sha 80ee936a72662da1200c07934b708b25e668a5a5

Revert "[Concurrency] isCanceled spelling to follow guidance"

view details

Konrad `ktoso` Malawski

commit sha ad33889b67f0022411e3c3f172d16f2ad5f36f63

Merge pull request #35564 from apple/revert-35549-wip-task-canceled-spelling

view details

swift-ci

commit sha de35df23135499049b08b0a190c91a1225b2c375

Merge remote-tracking branch 'origin/main' into rebranch

view details

push time in 35 minutes

push eventapple/swift

Konrad `ktoso` Malawski

commit sha 80ee936a72662da1200c07934b708b25e668a5a5

Revert "[Concurrency] isCanceled spelling to follow guidance"

view details

Konrad `ktoso` Malawski

commit sha ad33889b67f0022411e3c3f172d16f2ad5f36f63

Merge pull request #35564 from apple/revert-35549-wip-task-canceled-spelling

view details

push time in an hour

delete branch apple/swift

delete branch : revert-35549-wip-task-canceled-spelling

delete time in an hour

PR merged apple/swift

Revert "[Concurrency] isCanceled spelling to follow guidance"

Reverts apple/swift#35549

+48 -48

1 comment

13 changed files

ktoso

pr closed time in an hour

push eventapple/swift-distributed-tracing-baggage

Konrad `ktoso` Malawski

commit sha e1bff92dfd49128dab151b29c9d146f5b3a8037c

docs script (#7)

view details

push time in an hour

PR merged apple/swift-distributed-tracing-baggage

Reviewers
docs script

Same change as in https://github.com/apple/swift-distributed-tracing-baggage-core/pull/4

I did more detailed comments in https://github.com/apple/swift-distributed-tracing-baggage-core/pull/4

+122 -100

0 comment

3 changed files

ktoso

pr closed time in an hour

push eventapple/swift-distributed-tracing-baggage-core

Konrad `ktoso` Malawski

commit sha a856e7dc23a6ef518b1d0cba28dd1dfa8df561d5

docs script (#4)

view details

push time in an hour

pull request commentapple/swift

[Test] Ran some execution tests on more platforms.

Build failed Swift Test OS X Platform Git Sha - d94ae1d44589a8fb0ea9f8a400a4bb17f869d746

nate-chandler

comment created time in an hour

issue commentapple/turicreate

> 50 GB memory footprint while training style transfer model

Okay I’ll try that. But other frameworks (say, PyTorch) consume constant memory during training regardless of the size of dataset. I don’t understand why memory keeps increasing continuously over time until program crashes here in Turicreate. 🤔 This looks like a bug.

rahulbhalley

comment created time in an hour

pull request commentapple/swift-package-manager

[Collections] API changes to support signed collections

@swift-ci please smoke test

yim-lee

comment created time in an hour

pull request commentapple/swift

[CodeCompletion][Sema] Don't filter out any viable solutions when solving for code completion

Build failed Swift Test Linux Platform Git Sha - 7d8b4858ea8ecb5ee0f7a41caa540655acab5210

nathawes

comment created time in an hour

push eventapple/swift-package-manager

Yim Lee

commit sha d08a0198d2124b8d8967a43df7714d501e37f6b8

Move package collection JSON models to a separate module (#3199) Motivation: Some publishers may opt to generate package collections on their own, which will require the JSON models. It might not be desirable to pull in all the dependencies that come with PackageCollections module. Modifications: Move PackageCollections/JSONModel into its own PackageCollectionsModel module and make it a product. Result: Package collection JSON models can be used with minimal dependencies.

view details

push time in an hour

PR merged apple/swift-package-manager

Reviewers
Move package collection JSON models to a separate module next

Motivation: Some publishers may opt to generate package collections on their own, which will require the JSON models. It might not be desirable to pull in all the dependencies that come with PackageCollections module.

Modifications: Move PackageCollections/JSONModel into its own PackageCollectionJSONModel module and make it a product.

Result: Package collection JSON models can be used with minimal dependencies.

+599 -417

7 comments

11 changed files

yim-lee

pr closed time in an hour

push eventapple/swift

Michael Gottesman

commit sha 47f76f175cf6dd8f81711146e6845006c1912c2f

[sil] Add a variant of SmallSetVector that uses SmallPtrSet internally instead of SmallDenseSet.

view details

Michael Gottesman

commit sha f39df1d73b169d728a3cccd8c1ebe9ee9b0a9734

[sil-combine] Address comments from post-commit review of cd7c9e97e46a0141e37f10fbfb74c094e0576ff3.

view details

Michael Gottesman

commit sha 90b23a6990f17d975640166eb97aef7e6675d13d

[sil] Replace a thinko in getNextInstruction(). We were using std::next on the pointer, not the iterator meaning we were accessing bad memory.

view details

Michael Gottesman

commit sha 1e039cce38201adcdd909089def60bd06aff8043

Merge pull request #35563 from gottesmm/pr-cd7c9e97e46a0141e37f10fbfb74c094e0576ff3-followups [ownership] cd7c9e97e46a0141e37f10fbfb74c094e0576ff3 followups

view details

swift-ci

commit sha d303fac16e663ea1a99acbc01b4b9108c1662e22

Merge remote-tracking branch 'origin/main' into rebranch

view details

push time in an hour

push eventapple/swift

Michael Gottesman

commit sha 47f76f175cf6dd8f81711146e6845006c1912c2f

[sil] Add a variant of SmallSetVector that uses SmallPtrSet internally instead of SmallDenseSet.

view details

Michael Gottesman

commit sha f39df1d73b169d728a3cccd8c1ebe9ee9b0a9734

[sil-combine] Address comments from post-commit review of cd7c9e97e46a0141e37f10fbfb74c094e0576ff3.

view details

Michael Gottesman

commit sha 90b23a6990f17d975640166eb97aef7e6675d13d

[sil] Replace a thinko in getNextInstruction(). We were using std::next on the pointer, not the iterator meaning we were accessing bad memory.

view details

Michael Gottesman

commit sha 1e039cce38201adcdd909089def60bd06aff8043

Merge pull request #35563 from gottesmm/pr-cd7c9e97e46a0141e37f10fbfb74c094e0576ff3-followups [ownership] cd7c9e97e46a0141e37f10fbfb74c094e0576ff3 followups

view details

push time in an hour

PR merged apple/swift

Reviewers
[ownership] cd7c9e97e46a0141e37f10fbfb74c094e0576ff3 followups

Fixes stuff from #35522.

+114 -29

3 comments

4 changed files

gottesmm

pr closed time in an hour

pull request commentapple/swift

[Test] Ran some execution tests on more platforms.

Build failed Swift Test Linux Platform Git Sha - d94ae1d44589a8fb0ea9f8a400a4bb17f869d746

nate-chandler

comment created time in an hour

PR opened apple/foundationdb

Encapsulate PacketWriter methods

Encapsulates serializeBytesAcrossBoundary and nextBuffer methods.

Style

  • [x] All variable and function names make sense.
  • [x] The code is properly formatted (consider running git clang-format).

Performance

  • [x] ~All CPU-hot paths are well optimized.~
  • [x] ~The proper containers are used (for example std::vector vs VectorRef).~
  • [x] ~There are no new known SlowTask traces.~

Testing

  • [x] ~The code was sufficiently tested in simulation.~
  • [x] ~If there are new parameters or knobs, different values are tested in simulation.~
  • [x] ~ASSERT, ASSERT_WE_THINK, and TEST macros are added in appropriate places.~
  • [x] ~Unit tests were added for new algorithms and data structure that make sense to unit-test~
  • [x] ~If this is a bugfix: there is a test that can easily reproduce the bug.~
+3 -3

0 comment

1 changed file

pr created time in 2 hours

push eventapple/swift

Mike Ash

commit sha 216e555ad6e60ad651e53ea29462e87f5359301e

[Runtime] Mark swift_asprintf with __attribute__((__format__)) This gives us build-time warnings about format string mistakes, like we would get if we called the built-in asprintf directly. Make TypeLookupError's format string constructor a macro instead so that its callers can get these build-time warnings. This reveals various mistakes in format strings and arguments in the runtime, which are now fixed. rdar://73417805

view details

tbkka

commit sha 35dad1161a7c825dea48d9eb93a5d0a654354671

Fix reflection_Optional_Any to support non-Apple platforms (#35546) * Fix reflection_Optional_Any to support non-Apple platforms Apple and non-Apple platforms happen to use different number of extra inhabitants in 64-bit pointers. This is already supported by the test framework, we just need to fill it in properly for this one test. * Remove OS= restriction

view details

Mike Ash

commit sha 4988127e997b20af58aa6dadf762ad00296a3a05

Merge pull request #35525 from mikeash/swift_asprintf-static-checking [Runtime] Mark swift_asprintf with __attribute__((__format__))

view details

swift_jenkins

commit sha 81b22f3330ac4f13b7c0767121663e1a79ebab87

Merge remote-tracking branch 'origin/main' into next

view details

push time in 2 hours

pull request commentapple/swift

Support SILBoxWithLayout in TypeDecoder

@swift-ci test

adrian-prantl

comment created time in 2 hours

pull request commentapple/swift

Add debug info support for boxed arguments in async functions.

@swift-ci test

adrian-prantl

comment created time in 2 hours

pull request commentapple/swift

Fix two issues with the SwiftGlibc module map

@drodriguez, no problem, I figured you were busy. If we get this modulemap change in first, we may not need to modify that C++ test in the NDK pull, so I will try to get this working first.

martinboehme

comment created time in 2 hours

Pull request review commentapple/swift

[Runtime] #ifdef __clang__ on printf __attribute__ in Portability.h

 size_t _swift_strlcpy(char *dst, const char *src, size_t maxlen); #ifdef SWIFT_RUNTIME_ATTRIBUTE_ALWAYS_INLINE SWIFT_RUNTIME_ATTRIBUTE_ALWAYS_INLINE #endif-__attribute((__format__(__printf__, 2, 3))) inline static int+#ifdef __clang__

Yeah, we could, but at that point, its probably better to introduce a bigger wrapper like the SWIFT_RUNTIME_ATTRIBUTE_ALWAYS_INLINE.

mikeash

comment created time in 2 hours

pull request commentapple/swift

Fix reflection_Optional_Any test to work on non-Apple platforms

Ooops. I already submitted and merged this.

tbkka

comment created time in 2 hours

PR closed apple/swift

Reviewers
Fix reflection_Optional_Any test to work on non-Apple platforms

This fixes up the new reflection_Optional_Any test to correctly work on Linux and other non-Apple platforms.

Background: Apple reserves 4G at the beginning of the address space for 64-bit processes to catch 32-bit errors in software. As a result, any 64-bit pointer with value < 4G is invalid, which allowed Swift to allocate 2G invalid pointer values as "extra inhabitants" for enum coding. But many other platforms reserve only a 4K initial page, so Swift for non-Apple platforms has standardized on 4K "extra inhabitants" for such.

We put in some infrastructure to account for this difference, this PR just adapts this new test to use that infrastructure.

+19 -20

0 comment

1 changed file

tbkka

pr closed time in 2 hours

Pull request review commentapple/swift

[Runtime] #ifdef __clang__ on printf __attribute__ in Portability.h

 size_t _swift_strlcpy(char *dst, const char *src, size_t maxlen); #ifdef SWIFT_RUNTIME_ATTRIBUTE_ALWAYS_INLINE SWIFT_RUNTIME_ATTRIBUTE_ALWAYS_INLINE #endif-__attribute((__format__(__printf__, 2, 3))) inline static int+#ifdef __clang__

Per Config.h, couldn't you just check __has_attribute(format)?

mikeash

comment created time in 2 hours

more