profile
viewpoint
Dmitry Sharshakov sh7dm @vuetifyjs Russia Web, Node.js, Vue and TypeScript developer. Learning Go and Rust. For donations: https://www.donationalerts.com/r/sh7dm

sh7dm/bright-night 4

Accessible and bright dark theme. Ideal for night coders

ElijahKotyluk/onyx 2

A Javascript testing framework

sh7dm/OpenSpeechToolkit 1

OpenST is open-source Python 3 library for speech recognition and synthesis

sh7dm/ava 0

:rocket: Futuristic JavaScript test runner

sh7dm/blockchain 0

A simple, small blockchain. Made with Node.js

sh7dm/boulder 0

An ACME-based CA, written in Go.

sh7dm/brotlihandler 0

Go middleware to compress HTTP responses using Brotli Gzip. Based on https://github.com/gorilla/handlers/blob/master/compress.go

sh7dm/cli 0

The GitHub CLI

sh7dm/create-nuxt-app 0

Create Nuxt.js App in seconds.

startedadi1090x/dynamic-wallpaper

started time in 7 days

push eventvuetifyjs/vuetify

Dmitry Sharshakov

commit sha ff6ff3c11c85f7dec50857e4d462ce0bc559635c

test(VTooltip): add more tests Signed-off-by: Dmitry Sharshakov <d3dx12.xx@gmail.com>

view details

push time in 7 days

startedadi1090x/CustomArch

started time in 7 days

issue commenttermux/termux-packages

Include libfido2

Not only NFC, but also USB OTG connection should work, just as libusb patch by Termux.

nicoduck

comment created time in 8 days

starteddelvedor/find-my-way

started time in 9 days

starteddeepjyoti30/QuickWall

started time in 10 days

create barnchsh7dm/Layan-Manjaro-gtk-theme

branch : manjaro-theme

created branch time in 10 days

startedvinceliuice/Layan-gtk-theme

started time in 10 days

issue commentpop-os/shell

Pop Shell makes Gnome unresponsive after login [Appears to be Wayland only]

If it's support issue (no support for Wayland), extension should auto-disable on Wayland but not crash the OS. So I think first thing to do is prevent hangs, then that fix will get removed when somebody implements Wayland support,

ccwky11

comment created time in 14 days

push eventvuetifyjs/vuetify

Dmitry Sharshakov

commit sha 729f818676567df9a8dea3ea55c5a25529bee4b2

test(VStepperStep): add more tests

view details

push time in 14 days

push eventvuetifyjs/vuetify

Dmitry Sharshakov

commit sha 137490363477ed8548624a04a9983fd8835a8688

test(VCalendar): add test for 4day view Signed-off-by: Dmitry Sharshakov <d3dx12.xx@gmail.com>

view details

push time in 14 days

Pull request review commentonyxjs/onyx

build(deps): bump deps and fix vulnerabilities

-export { default as matchers, AnyMatchers, extendMatchers, onyx } from './matchers';+export { matchers, AnyMatchers, extendMatchers, onyx } from './matchers';

Is it related to the scope of the PR?

ElijahKotyluk

comment created time in 14 days

push eventvuetifyjs/vuetify

Dmitry Sharshakov

commit sha acf941f7c44ee64e0f09f19abb44c46f63fa1794

test(VColorPickerCanvas): add more tests Signed-off-by: Dmitry Sharshakov <d3dx12.xx@gmail.com>

view details

push time in 14 days

push eventvuetifyjs/vuetify

Dmitry Sharshakov

commit sha b3dfdb30f2a7db90ddd21cb9af015eabc3c6f684

test(VColorPickerPreview): add tests Signed-off-by: Dmitry Sharshakov <d3dx12.xx@gmail.com>

view details

push time in 14 days

push eventvuetifyjs/vuetify

Dmitry Sharshakov

commit sha 31318f2932baa59ce0e0ce1168356d8650d390ce

test(VBottomNavigation): cover 100% Signed-off-by: Dmitry Sharshakov <d3dx12.xx@gmail.com>

view details

push time in 14 days

startedpaperwm/PaperWM

started time in 15 days

startedPapyElGringo/material-shell

started time in 15 days

issue commentpop-os/shell

Pop Shell makes Gnome unresponsive after login [Appears to be Wayland only]

Can confirm this (Manjaro Gnome 3.36). When a window is opened in Wayland session with auto-tiling enabled, VM freezes

ccwky11

comment created time in 15 days

startedsonictruth/vr-dos

started time in 16 days

Pull request review commentvuetifyjs/vuetify

feat(v-data-table): add item-class property

       "headersLength": "Can be used in combination with `hide-default-header` to specify the number of columns in the table to allow expansion rows and loading bar to function properly",       "height": "Set an explicit height of table",       "hideDefaultHeader": "Hide the default headers",+      "itemClass": "Function that takes item as argument and returns the list of classes to add to the row of the item",

Ah, I was wrong.

florealcab

comment created time in 20 days

Pull request review commentvuetifyjs/vuetify

feat(v-data-table): add item-class property

 export type DataItemsPerPageOption = (number | {   text: string   value: number });++export type RowClassFunction = (item: any) => null|undefined|string|string[]|Record<string, boolean>
export type RowClassFunction = (item: any) => null | undefined | string | string[] | Record<string, boolean>
florealcab

comment created time in 20 days

Pull request review commentvuetifyjs/vuetify

feat(v-data-table): add item-class property

       "headersLength": "Can be used in combination with `hide-default-header` to specify the number of columns in the table to allow expansion rows and loading bar to function properly",       "height": "Set an explicit height of table",       "hideDefaultHeader": "Hide the default headers",+      "itemClass": "Function that takes item as argument and returns the list of classes to add to the row of the item",

Not sure, but this text may be better. @vuetifyjs/core-team thoughts?

florealcab

comment created time in 20 days

Pull request review commentvuetifyjs/vuetify

feat(v-data-table): add item-class property

       "headersLength": "Can be used in combination with `hide-default-header` to specify the number of columns in the table to allow expansion rows and loading bar to function properly",       "height": "Set an explicit height of table",       "hideDefaultHeader": "Hide the default headers",+      "itemClass": "Function that takes item as argument and returns the list of classes to add to the row of the item",
      "itemClass": "Function that takes item as argument and returns the list of classes to add to the item",
florealcab

comment created time in 20 days

startedpuxplaying/mutter-x11-scaling

started time in 21 days

startedpop-os/shell

started time in 21 days

startedandriisharshakov/kanban-board

started time in 22 days

startedevanw/esbuild

started time in 24 days

Pull request review commentvuetifyjs/vuetify

feat(VSheet): move outlined functionality to v-sheet

 export default mixins(   name: 'v-card',    props: {-    flat: Boolean,

why removing this?

johnleider

comment created time in 24 days

issue openednagisa/msi-rgb

Pre-built binaries

Could you please release pre-compiled executables to run this without rustc and cargo installed? You can use GitHub actions for builds and releasing. Thank you for this awesome utility!

created time in a month

Pull request review commentvuetifyjs/vuetify

refactor: mergeClasses, mergeStyles, mergeListeners

+import { mergeClasses, mergeListeners, mergeStyles } from '../mergeData'

Hmm, sounds interesting. This can help cleaning up the file and simplifying adding new tests to it.

jacekkarczmarczyk

comment created time in a month

Pull request review commentvuetifyjs/vuetify

refactor: mergeClasses, mergeStyles, mergeListeners

 describe('mergeStyles', () => {   it('should merge styles', () => {     const cUndefined = undefined     const cEmptyString = ''-    const cString = 'foo: bar; fizz-buzz: 10px'-    const cObject = { foo: 'bar', fizzBuzz: '10px' }+    const cString = 'foo: bar; fizz-buzz: 10px; background: var(--background)'+    const cObject = { foo: 'bar', fizzBuzz: '10px', background: 'var(--background)' }

This is good, but I meant defining them too

jacekkarczmarczyk

comment created time in a month

Pull request review commentvuetifyjs/vuetify

refactor: mergeClasses, mergeStyles, mergeListeners

+import { mergeClasses, mergeListeners, mergeStyles } from '../mergeData'++describe('mergeClasses', () => {+  it('should merge classes', () => {+    const cUndefined = undefined+    const cEmptyString = ''+    const cString = 'foo bar'+    const cArray = ['foo', 'bar']+    const cObject = { foo: true, bar: false }++    expect(mergeClasses(cUndefined, cUndefined)).toBeUndefined()+    expect(mergeClasses(cUndefined, cObject)).toBe(cObject)+    expect(mergeClasses(cEmptyString, cUndefined)).toBe(cEmptyString)+    expect(mergeClasses(cUndefined, cObject)).toBe(cObject)+    expect(mergeClasses(cString, cUndefined)).toBe(cString)+    expect(mergeClasses(cString, cEmptyString)).toBe(cString)+    expect(mergeClasses(cString, cString)).toStrictEqual([cString, cString])+    expect(mergeClasses(cString, cArray)).toStrictEqual([cString, ...cArray])+    expect(mergeClasses(cString, cObject)).toStrictEqual([cString, cObject])+    expect(mergeClasses(cArray, cUndefined)).toBe(cArray)+    expect(mergeClasses(cArray, cEmptyString)).toBe(cArray)+    expect(mergeClasses(cArray, cString)).toStrictEqual([...cArray, cString])+    expect(mergeClasses(cArray, cArray)).toStrictEqual([...cArray, ...cArray])+    expect(mergeClasses(cArray, cObject)).toStrictEqual([...cArray, cObject])+    expect(mergeClasses(cObject, cUndefined)).toBe(cObject)+    expect(mergeClasses(cObject, cEmptyString)).toBe(cObject)+    expect(mergeClasses(cObject, cString)).toStrictEqual([cObject, cString])+    expect(mergeClasses(cObject, cArray)).toStrictEqual([cObject, ...cArray])+    expect(mergeClasses(cObject, cObject)).toStrictEqual([cObject, cObject])+  })+})++describe('mergeStyles', () => {+  it('should merge styles', () => {+    const cUndefined = undefined+    const cEmptyString = ''+    const cString = 'foo: bar; fizz-buzz: 10px'+    const cObject = { foo: 'bar', fizzBuzz: '10px' }++    expect(mergeStyles(cUndefined, cUndefined)).toBeUndefined()+    expect(mergeStyles(cUndefined, cObject)).toBe(cObject)+    expect(mergeStyles(cEmptyString, cUndefined)).toBeUndefined()+    expect(mergeStyles(cUndefined, cObject)).toBe(cObject)+    expect(mergeStyles(cString, cUndefined)).toBe(cString)+    expect(mergeStyles(cString, cEmptyString)).toBe(cString)+    expect(mergeStyles(cString, cString)).toStrictEqual([cObject, cObject])+    expect(mergeStyles(cString, cObject)).toStrictEqual([cObject, cObject])+    expect(mergeStyles(cObject, cUndefined)).toBe(cObject)+    expect(mergeStyles(cObject, cEmptyString)).toBe(cObject)+    expect(mergeStyles(cObject, cString)).toStrictEqual([cObject, cObject])+    expect(mergeStyles(cObject, cObject)).toStrictEqual([cObject, cObject])+  })+})++describe('mergeListeners', () => {+  it('should merge styles', () => {
  it('should merge listeners', () => {
jacekkarczmarczyk

comment created time in a month

Pull request review commentvuetifyjs/vuetify

refactor: mergeClasses, mergeStyles, mergeListeners

+import { mergeClasses, mergeListeners, mergeStyles } from '../mergeData'++describe('mergeClasses', () => {+  it('should merge classes', () => {+    const cUndefined = undefined+    const cEmptyString = ''+    const cString = 'foo bar'+    const cArray = ['foo', 'bar']+    const cObject = { foo: true, bar: false }++    expect(mergeClasses(cUndefined, cUndefined)).toBeUndefined()+    expect(mergeClasses(cUndefined, cObject)).toBe(cObject)+    expect(mergeClasses(cEmptyString, cUndefined)).toBe(cEmptyString)+    expect(mergeClasses(cUndefined, cObject)).toBe(cObject)+    expect(mergeClasses(cString, cUndefined)).toBe(cString)+    expect(mergeClasses(cString, cEmptyString)).toBe(cString)+    expect(mergeClasses(cString, cString)).toStrictEqual([cString, cString])+    expect(mergeClasses(cString, cArray)).toStrictEqual([cString, ...cArray])+    expect(mergeClasses(cString, cObject)).toStrictEqual([cString, cObject])+    expect(mergeClasses(cArray, cUndefined)).toBe(cArray)+    expect(mergeClasses(cArray, cEmptyString)).toBe(cArray)+    expect(mergeClasses(cArray, cString)).toStrictEqual([...cArray, cString])+    expect(mergeClasses(cArray, cArray)).toStrictEqual([...cArray, ...cArray])+    expect(mergeClasses(cArray, cObject)).toStrictEqual([...cArray, cObject])+    expect(mergeClasses(cObject, cUndefined)).toBe(cObject)+    expect(mergeClasses(cObject, cEmptyString)).toBe(cObject)+    expect(mergeClasses(cObject, cString)).toStrictEqual([cObject, cString])+    expect(mergeClasses(cObject, cArray)).toStrictEqual([cObject, ...cArray])+    expect(mergeClasses(cObject, cObject)).toStrictEqual([cObject, cObject])+  })+})++describe('mergeStyles', () => {+  it('should merge styles', () => {+    const cUndefined = undefined+    const cEmptyString = ''+    const cString = 'foo: bar; fizz-buzz: 10px'+    const cObject = { foo: 'bar', fizzBuzz: '10px' }

maybe a test with CSS variable will be useful too

jacekkarczmarczyk

comment created time in a month

startedbrimsec/brim

started time in a month

startedaristocratos/bashtop

started time in a month

startedadi1090x/plymouth-themes

started time in a month

startedjdan/98.css

started time in a month

push eventsh7dm/generator-node-next

snyk-bot

commit sha 58758df6b41003e2a4fad1f7b96f0027ef626011

fix: package.json, package-lock.json & .snyk to reduce vulnerabilities The following vulnerabilities are fixed with a Snyk patch: - https://snyk.io/vuln/SNYK-JS-LODASH-567746

view details

push time in a month

push eventsh7dm/generator-node-next

snyk-bot

commit sha 51f2f82b241a26461a7fdd22a306ebc096fe727a

fix: package.json, package-lock.json & .snyk to reduce vulnerabilities The following vulnerabilities are fixed with a Snyk patch: - https://snyk.io/vuln/SNYK-JS-LODASH-567746

view details

push time in a month

push eventsh7dm/generator-node-next

snyk-bot

commit sha 071225897d3f903571d2b58474c1084d2ee357aa

fix: package.json, package-lock.json & .snyk to reduce vulnerabilities The following vulnerabilities are fixed with a Snyk patch: - https://snyk.io/vuln/SNYK-JS-LODASH-567746

view details

push time in a month

push eventsh7dm/docker-panel-reborn

snyk-bot

commit sha d82f8d975a740a120688f81abbcd1d5edb7731b8

fix: package.json, package-lock.json & .snyk to reduce vulnerabilities The following vulnerabilities are fixed with a Snyk patch: - https://snyk.io/vuln/SNYK-JS-LODASH-567746

view details

push time in a month

push eventsh7dm/docker-panel-reborn

snyk-bot

commit sha 953e70843bb694ea5748127197f55b1b035ec580

fix: package.json, package-lock.json & .snyk to reduce vulnerabilities The following vulnerabilities are fixed with a Snyk patch: - https://snyk.io/vuln/SNYK-JS-LODASH-567746

view details

push time in a month

push eventsh7dm/docker-panel-reborn

snyk-bot

commit sha b65be43758b9f5b65ed1ccf24ffec4db880746aa

fix: package.json, package-lock.json & .snyk to reduce vulnerabilities The following vulnerabilities are fixed with a Snyk patch: - https://snyk.io/vuln/SNYK-JS-LODASH-567746

view details

push time in a month

push eventsh7dm/vuetify-nuxt-example

snyk-bot

commit sha 84265147f04375650856c889b5e7886c04d79da2

fix: package.json, package-lock.json & .snyk to reduce vulnerabilities The following vulnerabilities are fixed with a Snyk patch: - https://snyk.io/vuln/SNYK-JS-LODASH-567746

view details

push time in a month

push eventsh7dm/vuetify-nuxt-example

snyk-bot

commit sha 515693231e9422911f3279b524eee527ecae6c6f

fix: package.json, package-lock.json & .snyk to reduce vulnerabilities The following vulnerabilities are fixed with a Snyk patch: - https://snyk.io/vuln/SNYK-JS-LODASH-567746

view details

push time in a month

push eventsh7dm/vuetify-nuxt-example

snyk-bot

commit sha 3aa9c7845c467de57c4cc076b3b48c451e3c48b2

fix: package.json, package-lock.json & .snyk to reduce vulnerabilities The following vulnerabilities are fixed with a Snyk patch: - https://snyk.io/vuln/SNYK-JS-LODASH-567746

view details

push time in a month

startedclaudiodangelis/qrcp

started time in a month

startedgofiber/fiber

started time in a month

Pull request review commentvuetifyjs/vuetify

chore(package.json): update packages / resolve dependency issues

   },   "devDependencies": {     "@babel/cli": "^7.5.5",-    "@babel/core": "^7.5.5",+    "@babel/core": "^7.0.0-0",

Unsure about this downgrade too

johnleider

comment created time in a month

Pull request review commentvuetifyjs/vuetify

chore(package.json): update packages / resolve dependency issues

     "webfontloader": "^1.6.28"   },   "devDependencies": {-    "@babel/core": "^7.5.5",+    "@babel/core": "^7.0.0-0",

Why downgrading here?

johnleider

comment created time in a month

startedtianocore/edk2

started time in a month

startedBash-it/bash-it

started time in a month

startedshellhub-io/shellhub

started time in a month

issue commentmicrosoft/vscode

Separate terminal history per editor/folder/project

I'm not sure, but I heard about this zsh plugin, you can use it with oh-my-zsh. Shell keeps history, so this is a solution probably.

martindanielson

comment created time in a month

startedguangie88/ghafs

started time in a month

startedrfjakob/gocryptfs

started time in a month

startedviatsko/awesome-vscode

started time in a month

startedvuejs/vite

started time in a month

pull request commentgravitational/teleport

Use cluster name for TOTP account name

@russjones Thank you a lot!

sh7dm

comment created time in a month

pull request commentgravitational/teleport

Use cluster name for TOTP account name

I'm sorry but what issues are stated in that discussion? What do I need to fix?

sh7dm

comment created time in a month

issue commenteclipse-theia/theia

Emojis cause incorrect displaying of the terminal

hmm, I found no way to connect it to zsh, but it's zsh-dependant.

sh7dm

comment created time in a month

issue commenteclipse-theia/theia

Emojis cause incorrect displaying of the terminal

ok. will try in Codepen.

sh7dm

comment created time in a month

issue commenteclipse-theia/theia

Emojis cause incorrect displaying of the terminal

What can I check? Xterm.js?

sh7dm

comment created time in a month

issue commenteclipse-theia/theia

Emojis cause incorrect displaying of the terminal

In VS Code there isn't such issue.

sh7dm

comment created time in a month

issue commenteclipse-theia/theia

Emojis cause incorrect displaying of the terminal

@kittaakos do you use oh-my-zsh too? if so, it can be their issue.

sh7dm

comment created time in a month

issue commenteclipse-theia/theia

Emojis cause incorrect displaying of the terminal

It looks like there isn't :(. Maybe it should be reported to Xterm.js, if they can't do anything report to Zsh.

sh7dm

comment created time in a month

push eventsh7dm/theia

Dmitry Sharshakov

commit sha 27b94738405d36fec4ac9b7a06f0f7d9c882c19b

Use breakpoint activate icon from codicons Signed-off-by: Dmitry Sharshakov <d3dx12.xx@gmail.com>

view details

push time in a month

pull request commenteclipse-theia/theia

Use codicons in debug extension and enable theming for them

@akosyakov could you please explain about context menu. It didn't work in Firefox before. In which browser are you?

sh7dm

comment created time in a month

push eventsh7dm/theia

Dmitry Sharshakov

commit sha a97a9c974d1ff801e402291a1bd257947ddf1128

Use codicons and theme colors for stackframes Signed-off-by: Dmitry Sharshakov <d3dx12.xx@gmail.com>

view details

Dmitry Sharshakov

commit sha c72a89013dd0d4360588a0d07a846b6875574dc0

Use codicons in all debug UI Signed-off-by: Dmitry Sharshakov <d3dx12.xx@gmail.com>

view details

push time in a month

pull request commenteclipse-theia/theia

Use codicons in debug extension and enable theming for them

TODO:

  • [ ] Context menu to edit breakpoints in the editor does not work anymore (@akosyakov elaborate please)
  • [ ] Stackframes (need help on how to update codicons font)
  • [ ] Activate Breakpoints and other icons from view
sh7dm

comment created time in a month

push eventsh7dm/theia

Dmitry Sharshakov

commit sha 66534d3712bd194bb6682c30d8a7dcff212b8caf

Fix breakpoint alignment in view Signed-off-by: Dmitry Sharshakov <d3dx12.xx@gmail.com>

view details

push time in a month

pull request commenteclipse-theia/theia

Use codicons in debug extension and enable theming for them

context menu to edit breakpoints in the editor does not work anymore

It didn't work for me before too. Not sure why. @akosyakov What do you think about codicon (stackframe)?

sh7dm

comment created time in a month

pull request commenteclipse-theia/theia

Use codicons in debug extension and enable theming for them

Question to maintainers: where is Codicon font being imported? I couldn't find that place and it seems that the font is a bit outdated, icons like codicon-debug-stackframe and codicon-debug-stackframe-dot don't work, so probably the font needs an update.

sh7dm

comment created time in a month

issue commenteclipse-theia/theia

Timeline API

TODO for converting History to Timeline (@ maintainers feel free to update):

  • [ ] Add icons support
  • [ ] Add VS Code compatible API More actions me be required too.
sh7dm

comment created time in a month

issue closedeclipse-theia/theia

Better welcome page

Description

  1. Welcome page looks incomplete, at least for me. I think it should have multi-column design like VS Code has, with more space between items.
  2. There isn't a placeholder on empty screen: image vs image It'll be great if there were some keybindings to get started with, like there are in VS Code.

Reproduction Steps

See Description

OS and Theia version: Doesn't matter

Diagnostics: <!-- Provide logs and any other relevant diagnostic information -->

closed time in a month

sh7dm

issue commenteclipse-theia/theia

Better welcome page

You're right. Let the users customize that.

sh7dm

comment created time in a month

issue commenteclipse-theia/theia

Better welcome page

Nothing really "wrong", but something can be improved. Theia Browser/Electron Example should be a useable IDE, it is a usable IDE.

sh7dm

comment created time in a month

issue commenteclipse-theia/theia

Better welcome page

I know about that. Theia should provide better defaults while preserving the ability to change them.

sh7dm

comment created time in a month

issue openedeclipse-theia/theia

Better welcome page

Description

  1. Welcome page looks incomplete, at least for me. I think it should have multi-column design like VS Code has, with more space between items.
  2. There isn't a placeholder on empty screen: image vs image It'll be great if there were some keybindings to get started with, like there are in VS Code.

Reproduction Steps

See Description

OS and Theia version: Doesn't matter

Diagnostics: <!-- Provide logs and any other relevant diagnostic information -->

created time in a month

issue commentgo-gitea/gitea

[Idea] Web IDE using theia

For "editor" you don't need Theia as far as I know, you need Monaco editor, which is main editor of Theia.

Th3Whit3Wolf

comment created time in a month

issue commentgo-gitea/gitea

[Idea] Web IDE using theia

@lunny it's a set of npm packages. To create an IDE out of core, Theia extensions and VS Code ones, you need to create a package.json as in examples of Theia apps, define extensions and plugins there and build using their CLI. VS Code extensions can be loaded later using builtin Open-VSX registry. Security is bigger problem than you thought, there're a lot of functions relying on terminal. Probably it won't be safe to use without Docker.

Th3Whit3Wolf

comment created time in a month

issue commentgo-gitea/gitea

[Idea] Web IDE using theia

@lunny I experimented with Theia before, for the last (git integration) you can install GitLens VS Code extension, it's compatible, at least 70% of its main fuctions work. The most problem is security, as Theia exposes console.

Th3Whit3Wolf

comment created time in a month

startedmicrosoft/TypeScript

started time in a month

startedgo-gitea/gitea

started time in a month

Pull request review commenteclipse-theia/theia

Use codicons in debug extension and enable theming for them

 .monaco-editor .theia-debug-breakpoint-column.theia-debug-breakpoint-column.debug-top-stack-frame-column { 	background: url('current-and-breakpoint.svg') center center no-repeat; }+.monaco-editor .theia-debug-top-stack-frame.theia-debug-breakpoint::before,+.monaco-editor .theia-debug-breakpoint-column.theia-debug-breakpoint-column.debug-top-stack-frame-column::before {+	content: '' !important;

I found that! They use debug-stackframe-dot instead of big breakpoint!

sh7dm

comment created time in a month

Pull request review commenteclipse-theia/theia

Use codicons in debug extension and enable theming for them

 .monaco-editor .theia-debug-breakpoint-column.theia-debug-breakpoint-column.debug-top-stack-frame-column { 	background: url('current-and-breakpoint.svg') center center no-repeat; }+.monaco-editor .theia-debug-top-stack-frame.theia-debug-breakpoint::before,+.monaco-editor .theia-debug-breakpoint-column.theia-debug-breakpoint-column.debug-top-stack-frame-column::before {+	content: '' !important;

Hard to screenshot it now, but I'll explain. That's stackframe icon overlapped by breakpoint one. Yellow arrow and red circle over it. Circle is too big, bigger than it should.

Possibly the same icon in VS Code?

There is, maybe we can try to find it.

sh7dm

comment created time in a month

issue commenteclipse-theia/theia

Add "Inspect TM scopes" command

Isn't the line on the bottom the TM scopes line? image The missing in Theia thing is contrast ratio, that is really useful for theme developers.

sh7dm

comment created time in a month

Pull request review commenteclipse-theia/theia

Use codicons in debug extension and enable theming for them

 .monaco-editor .theia-debug-breakpoint-column.theia-debug-breakpoint-column.debug-top-stack-frame-column { 	background: url('current-and-breakpoint.svg') center center no-repeat; }+.monaco-editor .theia-debug-top-stack-frame.theia-debug-breakpoint::before,+.monaco-editor .theia-debug-breakpoint-column.theia-debug-breakpoint-column.debug-top-stack-frame-column::before {+	content: '' !important;

They are consistent, but we need breakpoint's dot to be inside an arrow.

sh7dm

comment created time in a month

issue closedeclipse-theia/theia

Add "Inspect TM scopes" command

Description

Add "Inspect TM scopes" for debugging themes and editor like in VS Code.

Reproduction Steps

  1. Open quick menu
  2. Try to find Inspect TM scopes command

OS and Theia version: OS: Ubuntu 19.10 Theia: master

Diagnostics: <!-- Provide logs and any other relevant diagnostic information -->

closed time in a month

sh7dm

issue commenteclipse-theia/theia

Add "Inspect TM scopes" command

It is. Sorry for spam.

sh7dm

comment created time in a month

Pull request review commenteclipse-theia/theia

Use codicons in debug extension and enable theming for them

 .monaco-editor .theia-debug-breakpoint-column.theia-debug-breakpoint-column.debug-top-stack-frame-column { 	background: url('current-and-breakpoint.svg') center center no-repeat; }+.monaco-editor .theia-debug-top-stack-frame.theia-debug-breakpoint::before,+.monaco-editor .theia-debug-breakpoint-column.theia-debug-breakpoint-column.debug-top-stack-frame-column::before {+	content: '' !important;

It's because of size issue, when using stackframe+breakpoint. We need to hide codicon to let SVG display.

sh7dm

comment created time in a month

issue commenteclipse-theia/theia

Timeline API

@akosyakov Looks like existing History View is good for it, maybe with some changes.

sh7dm

comment created time in a month

issue openedeclipse-theia/theia

Add "Inspect TM scopes" command

Description

Add "Inspect TM scopes" for debugging themes and editor like in VS Code.

Reproduction Steps

  1. Open quick menu
  2. Try to find Inspect TM scopes command

OS and Theia version: OS: Ubuntu 19.10 Theia: master

Diagnostics: <!-- Provide logs and any other relevant diagnostic information -->

created time in a month

pull request commenteclipse-theia/theia

Use codicons in debug extension and enable theming for them

Stackframes and arrows are still in SVG due to case of arrow + breakpoint. This is because of breakpoint codicon is too big to use along with arrow or stackframe.

sh7dm

comment created time in a month

PR opened eclipse-theia/theia

Use codicons in debug extension and enable theming for them

<!-- Thank you for your Pull Request. Please provide a description and review the requirements below.

Contributors guide: https://github.com/theia-ide/theia/blob/master/CONTRIBUTING.md -->

What it does

<!-- Include relevant issues and describe how they are addressed. --> Fixes #6794

How to test

<!-- Explain how a reviewer can reproduce a bug, test new functionality or verify performance improvements. --> Add those colors to theme

Review checklist

  • [x] as an author, I have thoroughly tested my changes and carefully followed the review guidelines Known issues:
  • Stackframes and arrows are still in SVG due to case of arrow + breakpoint.

Reminder for reviewers

+105 -218

0 comment

39 changed files

pr created time in a month

create barnchsh7dm/theia

branch : debug-icons-theme

created branch time in a month

more