profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/sfc-gh-tclinkenbeard/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Trevor Clinkenbeard sfc-gh-tclinkenbeard Snowflake Bellevue, WA

apple/foundationdb 10727

FoundationDB - the open source, distributed, transactional key-value store

sfc-gh-etschannen/foundationdb 0

FoundationDB - the open source, distributed, transactional key-value store

sfc-gh-tclinkenbeard/azure-storage-cpplite 0

Lite version of C++ Client Library for Microsoft Azure Storage

sfc-gh-tclinkenbeard/CppCoreGuidelines 0

The C++ Core Guidelines are a set of tried-and-true guidelines, rules, and best practices about coding in C++

sfc-gh-tclinkenbeard/foundationdb 0

FoundationDB - the open source, distributed, transactional key-value store

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentapple/foundationdb

Add first stage of rollback and rollforward to ConfigNode

 class ConfigNodeImpl { 		return Void(); 	} +	ACTOR static Future<Void> rollback(ConfigNodeImpl* self, ConfigFollowerRollbackRequest req) {+		state ConfigGeneration generation = wait(getGeneration(self));+		if (req.version < generation.committedVersion) {+			Standalone<VectorRef<VersionedConfigMutationRef>> versionedMutations =+			    wait(getMutations(self, req.version + 1, generation.committedVersion));+			self->kvStore->clear(KeyRangeRef(versionedMutationKey(req.version + 1, 0),+			                                 versionedMutationKey(generation.committedVersion + 1, 0)));+			self->kvStore->clear(KeyRangeRef(versionedAnnotationKey(req.version + 1),+			                                 versionedAnnotationKey(generation.committedVersion + 1)));++			generation.committedVersion = req.version;+			self->kvStore->set(KeyValueRef(currentGenerationKey, BinaryWriter::toValue(generation, IncludeVersion())));+			wait(self->kvStore->commit());+		}+		req.reply.send(Void());+		return Void();+	}++	ACTOR static Future<Void> rollforward(ConfigNodeImpl* self, ConfigFollowerRollforwardRequest req) {+		ConfigGeneration currentGeneration = wait(getGeneration(self));+		if (req.lastKnownCommitted != currentGeneration.committedVersion) {+			++self->failedCommits;+			req.reply.sendError(not_committed());+			return Void();+		}+		ASSERT(req.mutations[0].version > currentGeneration.committedVersion);
		ASSERT_GT(req.mutations[0].version, currentGeneration.committedVersion);
sfc-gh-ljoswiak

comment created time in 10 days

Pull request review commentapple/foundationdb

Add first stage of rollback and rollforward to ConfigNode

 class ConfigNodeImpl { 		return Void(); 	} +	ACTOR static Future<Void> commitMutations(ConfigNodeImpl* self,+	                                          Standalone<VectorRef<VersionedConfigMutationRef>> mutations,+	                                          Standalone<VectorRef<VersionedConfigCommitAnnotationRef>> annotations,+	                                          Version commitVersion) {+		Version latestVersion = 0;+		int index = 0;+		for (const auto& mutation : mutations) {+			if (mutation.version > commitVersion) {+				continue;+			}+			// Mutations should be in ascending version order.+			ASSERT(mutation.version >= latestVersion);
			ASSERT_GE(mutation.version, latestVersion);
sfc-gh-ljoswiak

comment created time in 10 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

push eventsfc-gh-tclinkenbeard/foundationdb

Chaoguang Lin

commit sha 389e7051af635e914d8948619afa7b523a797568

Remove using the RYWTransaction object in fdbcli

view details

Chaoguang Lin

commit sha 7168594ae4c16e7683047e91a2d74a7338643d3d

Refactor status command

view details

Chaoguang Lin

commit sha feb4e48f206eff1108d46123209c6d2cb31bd47b

Merge branch 'master' of github.com:apple/foundationdb into refactor-fdbcli

view details

Chaoguang Lin

commit sha 9b148c6c63586ca983a2c62d01b9233b09f12921

Adding code to hold the threadfuture of ITransaction::get; other fixes for using external clients

view details

Chaoguang Lin

commit sha 99cc042d9cedcaebb47cfb2804cea3d44f6eda27

Fix ProfileCommand.actor.cpp, using the correct way to read from global config

view details

Chaoguang Lin

commit sha af5643c998408fa12fec229bed27128d2205c082

Fix the issue in CheckStatus where it stuck as we cannot talk to any of the coordinators

view details

Chaoguang Lin

commit sha 8cef044a8bccdd04786827e17ef407e040f66e3c

Remove commented code; simplify code

view details

Chaoguang Lin

commit sha 84a2672a33ac400f28e07bc0e0f32e9c5aa9af01

Merge branch 'master' of github.com:apple/foundationdb into refactor-fdbcli

view details

Chaoguang Lin

commit sha 8cc3f3f49d0cef3d05cd2780f67ba80ee3b11f88

Code format

view details

Chaoguang Lin

commit sha ab29bf05af5f53b2b0f92a5f7989d76d8a8d4f5b

Solve PR comments

view details

Lukas Joswiak

commit sha 30e7469b1921dd620ff916d2edb925cc69c9bd69

Update fdbclient/MultiVersionTransaction.actor.cpp

view details

Chaoguang Lin

commit sha 9df392f4478e764dc66b8fa307ccd628399e5901

Merge pull request #5528 from sfc-gh-clin/refactor-fdbcli Refactor fdbcli, get rid of RYWTransaction, refactor status command

view details

Neethu Haneesha Bingi

commit sha 627ef2e739c688e7931c91e2aa87c8197a2dd35b

Enable rocksdb storage in simulation with some simulation fixes.

view details

Kao Makino

commit sha f7c7a31478e40608397b0b80905d67c492467701

Disable clang-format on flow/aarch64/asmdefs.h

view details

Xiaoge Su

commit sha ecca4edeb48046bdefb0bb6013be4140066ebdb0

Create TagPartitionedLogSystem.actor.h TagPartitionedLogSystem.actor.h contains the struct of TagPartitionedLogSystem.

view details

Xiaoge Su

commit sha 067c1cc55b588bb180d735ce09b97ea53d6bda1b

Extract methods in LogSystem.h to corresponding cpp file

view details

Xiaoge Su

commit sha 909a5ff73a9e4d8198a423cca7f8a9a6aec1394e

Extract methods in LogSystemConfig.h to corresponding cpp file

view details

Xiaoge Su

commit sha 40648dbb3116143ea3f15ce3c54c284b3da06315

fixup! Update code per comment Also fix the issue that TagPartitionedLogSystem.actor.cpp should include TagPartitionedLogSystem.actor.h

view details

Xiaoge Su

commit sha c32c3b6ec4af1cd299d248b3e4caabca35739f6e

fixup! Reformat the code per github's requirement

view details

Trevor Clinkenbeard

commit sha 87ee42890147c1656496ea86afce551d4addb167

Merge branch 'master' into fix-typos

view details

push time in 12 days

PullRequestReviewEvent

create barnchsfc-gh-tclinkenbeard/foundationdb

branch : const-iclosable-onerror

created branch time in 14 days

Pull request review commentapple/foundationdb

Add fix for KillWorker unit test

 class OnDemandStore : NonCopyable { 	IKeyValueStore* get(); 	bool exists() const; 	IKeyValueStore* operator->();-	Future<Void> getError() const;++	Future<Void> getError();+	Future<Void> onClosed();+	void dispose();+	void close();
	Future<Void> getError() override;
	Future<Void> onClosed() override;
	void dispose() override;
	void close() override;
sfc-gh-ljoswiak

comment created time in 14 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventsfc-gh-tclinkenbeard/foundationdb

A.J. Beamon

commit sha 2d6fb93316dfba79df5a50932b1e327b3ebbc4dc

Compute a burstiness score based on the max busyness interval in a measurement period.

view details

A.J. Beamon

commit sha 2fa97f60fe27f62952e1ab6ee0895d30693857cc

Update fdbclient/NativeAPI.actor.cpp Co-authored-by: Trevor Clinkenbeard <trevor.clinkenbeard@snowflake.com>

view details

A.J. Beamon

commit sha afd8df4bb942734efa310a4494b7fc129005635e

Merge commit '7f2b6c2c7ec2efcd7339e3c6531e4906322477c3' into network-thread-busyness-burstiness-score

view details

A.J. Beamon

commit sha f7002e2a66e7919806b4efa29c088f12e15db4cb

Merge pull request #5495 from sfc-gh-ajbeamon/network-thread-busyness-burstiness-score Busyness API incorporates a burstiness score based on the max busyness interval in a measurement period

view details

Chaoguang Lin

commit sha 2aa0a5cf5872c32f417a089ec7ea78ebd703d624

The lock special key has the lock UID as the value

view details

Chaoguang Lin

commit sha b9e4bb72172aad2ff7215d4acb04a6b94d6edd80

Fix reading the disableTss option

view details

Chaoguang Lin

commit sha 56ed0f3b9c02d9d9c7a863c1d20f87181b01e70a

Return if no available binary in the given range

view details

Chaoguang Lin

commit sha 97050ac33f1378fee87e43c40ae0ef75e5d5eaf8

Merge pull request #5536 from sfc-gh-clin/change-lock-special-key The lock special key has the lock UID as the value

view details

Chaoguang Lin

commit sha 87b001ef7b4b1c948d2aa730c50f541fbf356237

Merge pull request #5538 from sfc-gh-clin/fix-disableTss-master Fix reading the disableTss option

view details

Chaoguang Lin

commit sha 0d1382eebad9744892bb3fb829f95918d9cdc95f

Add comments for the change

view details

Chaoguang Lin

commit sha d6e7617043d8b8321f30102e3c5b66db47c2a3f5

Merge pull request #5540 from sfc-gh-clin/fix-where-old-binary-not-present Return if no available old binary in the given range

view details

Aaron Molitor

commit sha c07c0ac4fcf8f3c2fbe900b3e5bcc9995855bdd0

put upper bound on setuptools version

view details

Meng Xu

commit sha 52a2f56fe25d7a4bb376ecc1648d4253980c0839

Merge pull request #5553 from apple/documentation_setuptoolz put upper bound on setuptools version

view details

sfc-gh-tclinkenbeard

commit sha 820b1790be4d539615333d7340434cd60e1f0ec5

s/subcription/subscription

view details

sfc-gh-tclinkenbeard

commit sha 834257c8fd4f7af78fe6bd87e273ea9e37f62fc3

Fixed commit_proxy_failed error message

view details

sfc-gh-tclinkenbeard

commit sha b08621fc46ff46b95393ad634c4b5894ef8d40a7

Fixed grv_proxy_failed error message

view details

push time in 16 days

issue closedapple/foundationdb

Resolver should die if it cannot make progress for a long time

If the resolver is unable to serve resolution requests from proxies for a very long time, this will not necessarily cause a recovery, so the cluster can indefinitely remain in a state where commits fail (until a manual recovery is forced). Instead, the resolver should automatically detect that it is unhealthy, and trigger a recovery itself. We should also improve availability testing in simulation to ensure that this case is covered.

closed time in 17 days

sfc-gh-tclinkenbeard

issue commentapple/foundationdb

Resolver should die if it cannot make progress for a long time

This is addressed by https://github.com/apple/foundationdb/pull/5231.

sfc-gh-tclinkenbeard

comment created time in 17 days

PullRequestReviewEvent
PullRequestReviewEvent

PR opened apple/foundationdb

Fix typos

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • [ ] The PR has a description, explaining both the problem and the solution.
  • [ ] The description mentions which forms of testing were done and the testing seems reasonable.
  • [ ] Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • [ ] This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or master if this is the youngest branch)
  • [ ] There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)
+16 -16

0 comment

3 changed files

pr created time in 21 days

create barnchsfc-gh-tclinkenbeard/foundationdb

branch : fix-typos

created branch time in 21 days

PullRequestReviewEvent
PullRequestReviewEvent