profile
viewpoint

sethwklein/gobert 9

BERT serialization library for Go

sethwklein/errutil 4

Provides things for working with multiple errors and correctly handling errors from deferred calls in Go.

sethwklein/goerrors 2

Deprecated. Please use http://sethwklein.net/go/errutil instead. It provides the same features, but without the duplication of the standard errors package.

llimllib/caportland 1

caportland.me website

sethwklein/docker-work 1

A Docker image for doing exploratory work

sethwklein/mkl.darkbulb 1

https://github.com/BigRoomStudios/mkl.lytebulb-api

sethwklein/aws-keychain 0

CLI manager for AWS IAM access keys in Mac OS X keychain

sethwklein/bin2go 0

Converts binary files to Go source code

sethwklein/compiler 0

Compiler for Elm, a functional language for reliable webapps.

sethwklein/cordova-plugin-splashscreen 0

Mirror of Apache Cordova Plugin splashscreen

push eventgolang/proposal

Keith Randall

commit sha 217dd4e7ebc3becaefdb5043b557bb01cdb6dd12

design: add GC shape hybrid design doc for the generics implementation Change-Id: I04ca517644779d011fb28e57ec54c4b7de91fe2c Reviewed-on: https://go-review.googlesource.com/c/proposal/+/258539 Trust: Keith Randall <khr@golang.org> Reviewed-by: Keith Randall <khr@golang.org>

view details

push time in 2 months

push eventgolang/proposal

Ian Lance Taylor

commit sha ba1fd06b14ac178b716d5cd542eb23032bfc3884

design: type parameters: use square brackets in NewPair declaration Change-Id: If892a757cd45ca3baa9b1008e9b7d950dad9f809 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/256303 Trust: Ian Lance Taylor <iant@golang.org> Reviewed-by: Robert Griesemer <gri@golang.org>

view details

push time in 2 months

startedsethwklein/gobert

started time in 2 months

push eventgolang/proposal

Keith Randall

commit sha 09d93231f660644433bd4a683f349dc36df26aed

design: add generics implementation design docs Change-Id: I33c636fce2e96677a9c81b15fa574ac136c22402 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/255797 Reviewed-by: Keith Randall <khr@golang.org>

view details

push time in 2 months

PR closed golang/proposal

fix typo: method receiver should contain type arguments, not parameters cla: yes

From what I understand, type parameters can only be used in a type or a function declaration. Thus, in a method receiver, one can only find type arguments. Having *Iterator[K, V any] there looks like a little typo to me. The go2go Playground seems to agree with me: before there's a parse error while there's no after.

+1 -1

7 comments

1 changed file

artspb

pr closed time in 2 months

pull request commentgolang/proposal

fix typo: method receiver should contain type arguments, not parameters

This PR is being closed because golang.org/cl/253819 has been merged.

artspb

comment created time in 2 months

pull request commentgolang/proposal

fix typo: method receiver should contain type arguments, not parameters

Message from Ian Lance Taylor:

Patch Set 1: Code-Review+2

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/253819. After addressing review feedback, remember to publish your drafts!

artspb

comment created time in 2 months

push eventgolang/proposal

Artem Khvastunov

commit sha 4baf1137216239075bbc0d7b6128c9a7446e3d48

fix typo: method receiver should contain type arguments, not parameters From what I understand, type parameters can only be used in a type or a function declaration. Thus, in a method receiver, one can only find type arguments. Having `*Iterator[K, V any]` there looks like a little typo to me. The go2go Playground seems to agree with me: [before](https://go2goplay.golang.org/p/dekNQ6Xy8XM) there's a parse error while there's no [after](https://go2goplay.golang.org/p/4B8iTq2AeET). Change-Id: I53e36fca75d3573f56bdb89fbc48bf4284502ffd GitHub-Last-Rev: 4f80c8e8b0c06a9c5457c1cdbe6c2cbfbb515a84 GitHub-Pull-Request: golang/proposal#27 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/253819 Reviewed-by: Ian Lance Taylor <iant@golang.org>

view details

push time in 2 months

pull request commentgolang/proposal

fix typo: method receiver should contain type arguments, not parameters

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: A maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/253819. After addressing review feedback, remember to publish your drafts!

artspb

comment created time in 2 months

pull request commentgolang/proposal

fix typo: method receiver should contain type arguments, not parameters

This PR (HEAD: 4f80c8e8b0c06a9c5457c1cdbe6c2cbfbb515a84) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/proposal/+/253819 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

artspb

comment created time in 2 months

pull request commentgolang/proposal

fix typo: method receiver should contain type arguments, not parameters

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

<!-- ok -->

artspb

comment created time in 2 months

pull request commentgolang/proposal

fix typo: method receiver should contain type arguments, not parameters

@googlebot I signed it!

artspb

comment created time in 2 months

pull request commentgolang/proposal

fix typo: method receiver should contain type arguments, not parameters

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

<!-- need_sender_cla -->

artspb

comment created time in 2 months

PR opened golang/proposal

fix typo: method receiver should contain type arguments, not parameters

From what I understand, type parameters can only be used in a type or a function declaration. Thus, in a method receiver, one can only find type arguments. Having *Iterator[K, V any] there looks like a little typo to me. The go2go Playground seems to agree with me: before there's a parse error while there's no after.

+1 -1

0 comment

1 changed file

pr created time in 2 months

push eventgolang/proposal

Ian Lance Taylor

commit sha 052dc08f85e77907e2e7d193bb549bf5f13aba3b

design: type parameters: pointer methods, clarifications Change-Id: Id99fed0f8a980003139581fd5830a89b9a85f401 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/253817 Reviewed-by: Robert Griesemer <gri@golang.org>

view details

push time in 3 months

PR closed golang/proposal

design: update issue link for gopls-workspaces cla: yes

Now the discussion is moved to the original feature request issue.

+3 -1

3 comments

1 changed file

hyangah

pr closed time in 3 months

pull request commentgolang/proposal

design: update issue link for gopls-workspaces

This PR is being closed because golang.org/cl/253697 has been merged.

hyangah

comment created time in 3 months

push eventgolang/proposal

Hyang-Ah Hana Kim

commit sha 7b5357b6075e8446a9e8d74c3078adb2772e8887

design: update issue link for gopls-workspaces Now the discussion is moved to the original feature request issue. Change-Id: Ibbe8c06ee6ab25f005e229fb690996c68c98815f GitHub-Last-Rev: ff469c86da08535bd4cfdc11587e1dd3e68752a3 GitHub-Pull-Request: golang/proposal#26 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/253697 Reviewed-by: Rebecca Stambler <rstambler@golang.org>

view details

push time in 3 months

pull request commentgolang/proposal

design: update issue link for gopls-workspaces

Message from Rebecca Stambler:

Patch Set 1: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/253697. After addressing review feedback, remember to publish your drafts!

hyangah

comment created time in 3 months

pull request commentgolang/proposal

design: update issue link for gopls-workspaces

This PR (HEAD: ff469c86da08535bd4cfdc11587e1dd3e68752a3) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/proposal/+/253697 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

hyangah

comment created time in 3 months

PR opened golang/proposal

design: update issue link for gopls-workspaces

Now the discussion is moved to the original feature request issue.

+3 -1

0 comment

1 changed file

pr created time in 3 months

push eventgolang/proposal

Ian Lance Taylor

commit sha c024b226e094dd510e72126d0a7d245afadb1f5e

design: type parameters: don't request Go formatting It's inconsistent. Change-Id: I33836847ec994d41ec367264df9231495268ea83 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/252157 Reviewed-by: Robert Griesemer <gri@golang.org>

view details

push time in 3 months

push eventgolang/proposal

Ian Lance Taylor

commit sha 9d511e4c6ea0413d2a2662562d0d41d8da93e6fc

design: type parameters: promote embedded methods from constraint Change-Id: If4be0f74932c1ec504833549fb01a047dcf8335f Reviewed-on: https://go-review.googlesource.com/c/proposal/+/251444 Reviewed-by: Robert Griesemer <gri@golang.org>

view details

push time in 3 months

push eventgolang/proposal

Ian Lance Taylor

commit sha c480748687a2d694c8725fd6011ac0c9ddbecd92

design: type parameters: type parameter lists require names Change-Id: Ib3cb641176ccd1c8dfb30558f7e0b7a228193de5 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/251560 Reviewed-by: Robert Griesemer <gri@golang.org>

view details

push time in 3 months

push eventgolang/proposal

Ian Lance Taylor

commit sha 352759f90dada5d5f8e78cd1d0edd63b3a6e6b7e

design: type parameters: various cleanups Also drop the idea that we implicitly pass a type parameter to a parameterized type constraint. We can use an interface type literal to get a similar effect. Change-Id: Iebabb9669d5fcd88a79e0c5388f74c4c1d9c0325 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/251137 Reviewed-by: Robert Griesemer <gri@golang.org>

view details

push time in 3 months

push eventgolang/proposal

Ian Lance Taylor

commit sha 4342550cab41e960d12348ece6e3eb655bb66da5

design: type parameters: various minor cleanups Change-Id: I54e8a55d392d16650a575826b55417a341830c51 Reviewed-on: https://go-review.googlesource.com/c/proposal/+/250519 Reviewed-by: Robert Griesemer <gri@golang.org>

view details

push time in 3 months

push eventgolang/proposal

Ian Lance Taylor

commit sha eb38a3580cbb12e243aeca3216bf236c143549f0

design: type parameters: type lists don't imply methods Change-Id: If45d9b9b75ca2cda1feb4a9ba645648b2e35763e Reviewed-on: https://go-review.googlesource.com/c/proposal/+/250377 Reviewed-by: Robert Griesemer <gri@golang.org>

view details

push time in 3 months

push eventgolang/proposal

Ian Lance Taylor

commit sha bfd574d8f661ae0dc41427d0fafe364dc0eaf57e

design: type parameter: tweak type list matching rule Change-Id: Ie9cffcd7a3133981a40947c0a3127d4bb83bb4bd Reviewed-on: https://go-review.googlesource.com/c/proposal/+/250317 Reviewed-by: Robert Griesemer <gri@golang.org>

view details

push time in 3 months

more