profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/sergiocampama/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

sergiocampama/Launchpad 33

Launchpad mini projects. Includes mspgcc installation instructions for Ubuntu

sergiocampama/bazel-msp430 6

Skylark integration of the MSP430 toolchain for bazel.

sergiocampama/pesto 4

Pesto - Bazel Dependency Management System

sergiocampama/GpsExample 1

GPS Background monitoring Service for Android Apps, designed to be almost Plug n Play.

sergiocampama/BazelRemoteCache 0

Remote Cache Server for Bazel written in Swift

sergiocampama/servel_scrapper 0

Scrapper for Servel website, gets all Chileans voter information.

sergiocampama/structures 0

Basic Structures

sergiocampama/swift-llbuild2 0

A fresh take on a low-level build system API.

sergiocampama/swift-protobuf 0

Plugin and runtime library for using protobuf with Swift

pull request commentapple/swift-driver

PrebuiltModuleGen: add an option for skipping the job execution

@swift-ci please test

nkcsgexi

comment created time in 8 hours

push eventapple/swift-driver

Artem Chikin

commit sha 631d7eb931d5b1d9af87bded3efc99869d866aa2

Update `isSDKTooOld` to be compatible with older compilers. 5.3 and ealier compilers may hit: ``` swift-driver/Sources/SwiftDriver/Driver/Driver.swift:2044:15: error: definition conflicts with previous value guard let sdkInfo = sdkInfo else { ```

view details

Artem Chikin

commit sha cd5bfdc30d2f2a41ea58116cd07191c4bc42d109

Merge pull request #609 from artemcm/OldCompilersNeedHelp Update `isSDKTooOld` to be compatible with older compilers.

view details

push time in 8 hours

PR merged apple/swift-driver

Reviewers
Update `isSDKTooOld` to be compatible with older compilers.

5.3 and ealier compilers may hit:

swift-driver/Sources/SwiftDriver/Driver/Driver.swift:2044:15: error: definition conflicts with previous value
    guard let sdkInfo = sdkInfo else {

e.g. https://ci.swift.org/job/swift-PR-toolchain-osx/949/console

+2 -2

1 comment

1 changed file

artemcm

pr closed time in 8 hours

pull request commentapple/swift-driver

Update `isSDKTooOld` to be compatible with older compilers.

@swift-ci please test

artemcm

comment created time in 9 hours

PR opened apple/swift-driver

Reviewers
Update `isSDKTooOld` to be compatible with older compilers.

5.3 and ealier compilers may hit:

swift-driver/Sources/SwiftDriver/Driver/Driver.swift:2044:15: error: definition conflicts with previous value
    guard let sdkInfo = sdkInfo else {

e.g. https://ci.swift.org/job/swift-PR-toolchain-osx/949/console

+2 -2

0 comment

1 changed file

pr created time in 9 hours

push eventapple/swift-driver

Artem Chikin

commit sha 433c66dbe644f5beb6adb9127eba7e838489a707

Remove target `x86_64` specialization from `testExplicitModuleBuildEndToEnd`

view details

Xi Ge

commit sha ddf2bde1a44981af935c55ffd9d0288b97c9fe3d

Merge pull request #608 from artemcm/NoTargetInEndToEndTest Remove target `x86_64` specialization from `testExplicitModuleBuildEndToEnd`

view details

push time in 9 hours

PR merged apple/swift-driver

Reviewers
Remove target `x86_64` specialization from `testExplicitModuleBuildEndToEnd`

This explicit specifier causes these modules to get built for x86_64 even on Apple Silicon hosts: e.g. https://ci.swift.org/job/oss-swift-incremental-RA-macos-apple-silicon/490/console

+3 -3

1 comment

3 changed files

artemcm

pr closed time in 9 hours

pull request commentapple/swift-driver

Remove target `x86_64` specialization from `testExplicitModuleBuildEndToEnd`

@swift-ci please test

artemcm

comment created time in 11 hours

PR opened apple/swift-driver

Reviewers
Remove target `x86_64` specialization from `testExplicitModuleBuildEndToEnd`

This explicit specifier causes these modules to get built for x86_64 even on Apple Silicon hosts: e.g. https://ci.swift.org/job/oss-swift-incremental-RA-macos-apple-silicon/490/console

+3 -3

0 comment

3 changed files

pr created time in 11 hours

created repositoryetagwerker/etagwerker

So meta!

created time in 13 hours

push eventbazelbuild/rules_swift

Tony Allevato

commit sha e4912a311f32f7c5ae2c5a61f549f03a4b0aab16

Add Xcode toolchain support for an optional binary that can rewrite the generated header of a Swift module after compilation. PiperOrigin-RevId: 369323385

view details

push time in 15 hours

push eventapple/swift-driver

Artem Chikin

commit sha e1e9b80db1f7c71169f6581162a63d35147bd5d4

Account for Simulator platforms when checking if the provided SDK is too old

view details

Artem Chikin

commit sha b7fb5872cea5c1fd0172afface415d1a7f0a38ae

Merge pull request #607 from artemcm/SimulatorSDKTooOld Account for Simulator platforms when checking if the provided SDK is too old

view details

push time in 15 hours

pull request commentapple/swift-driver

Account for Simulator platforms when checking if the provided SDK is too old

@swift-ci please test

artemcm

comment created time in 15 hours

Pull request review commentapple/swift-driver

Attempt to diagnose arguments to `-sdk` that point to unsupported SDKs

 extension Driver {   } } +// SDK checking: attempt to diagnose if the SDK we are pointed at is too old.+extension Driver {+  static func isSDKTooOld(sdkPath: AbsolutePath, fileSystem: FileSystem,+                          diagnosticsEngine: DiagnosticsEngine) -> Bool {+    let sdkInfo = DarwinToolchain.readSDKInfo(fileSystem, VirtualPath.absolute(sdkPath).intern())+    guard let sdkInfo = sdkInfo else {+      diagnosticsEngine.emit(.warning_no_sdksettings_json(sdkPath.pathString))+      return false+    }+    guard let sdkVersion = Version(potentiallyIncompleteVersionString: sdkInfo.versionString) else {+      diagnosticsEngine.emit(.warning_fail_parse_sdk_ver(sdkInfo.versionString, sdkPath.pathString))+      return false+    }+    if sdkInfo.canonicalName.hasPrefix("macos") {+      return sdkVersion < Version(10, 15, 0)+    } else if sdkInfo.canonicalName.hasPrefix("iphoneos") ||+                sdkInfo.canonicalName.hasPrefix("appletvos") {+      return sdkVersion < Version(13, 0, 0)+    } else if sdkInfo.canonicalName.hasPrefix("watchos") {

Thanks! Using a more concise prefix will just work.

artemcm

comment created time in 15 hours

Pull request review commentapple/swift-driver

Attempt to diagnose arguments to `-sdk` that point to unsupported SDKs

 extension Driver {   } } +// SDK checking: attempt to diagnose if the SDK we are pointed at is too old.+extension Driver {+  static func isSDKTooOld(sdkPath: AbsolutePath, fileSystem: FileSystem,+                          diagnosticsEngine: DiagnosticsEngine) -> Bool {+    let sdkInfo = DarwinToolchain.readSDKInfo(fileSystem, VirtualPath.absolute(sdkPath).intern())+    guard let sdkInfo = sdkInfo else {+      diagnosticsEngine.emit(.warning_no_sdksettings_json(sdkPath.pathString))+      return false+    }+    guard let sdkVersion = Version(potentiallyIncompleteVersionString: sdkInfo.versionString) else {+      diagnosticsEngine.emit(.warning_fail_parse_sdk_ver(sdkInfo.versionString, sdkPath.pathString))+      return false+    }+    if sdkInfo.canonicalName.hasPrefix("macos") {+      return sdkVersion < Version(10, 15, 0)+    } else if sdkInfo.canonicalName.hasPrefix("iphoneos") ||+                sdkInfo.canonicalName.hasPrefix("appletvos") {+      return sdkVersion < Version(13, 0, 0)+    } else if sdkInfo.canonicalName.hasPrefix("watchos") {

Ah, yes, that's a good catch. I thought this would work as is because it is a prefix, but it turns out that it won't. The os part of the prefix is not present for the simulator platforms so we need to pattern match prefixes: appletv, watch, iphone, without the os to also catch this for the simulator. I'll create another PR.

artemcm

comment created time in 15 hours

CommitCommentEvent

pull request commentbazelbuild/rules_apple

Add Swift runtime linker options when creating an `apple_binary`.

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

<!-- need_author_cla -->

keith

comment created time in 15 hours

PR opened bazelbuild/rules_apple

Add Swift runtime linker options when creating an `apple_binary`.

PiperOrigin-RevId: 368476099 (cherry picked from commit 45bcf73e983afef23bfac4e58d4db28f83f3dadf)

+21 -1

0 comment

3 changed files

pr created time in 15 hours

CommitCommentEvent

push eventbazelbuild/rules_apple

Tony Allevato

commit sha bbc422cdb5bab8c0cba46b4aca782799fd65be83

API changes to `create_swift_interop_info`. - Require all dependencies' `SwiftInfo`s to be passed instead of implicitly (and unconditionally) traversing `deps`. - Add `requested_features` and `unsupported_features` parameters so rule implementations can provide these values (to be automatically added to the values on the target) as if they were supplying the feature configuration themselves. - Correctly derive a module name if it is not provided. PiperOrigin-RevId: 368653094 (cherry picked from commit 44bf955ce986ca3ab4d73cc58ab4acd732eac48e)

view details

push time in 15 hours

pull request commentbazelbuild/rules_apple

Update `apple_{static,dynamic}_framework_import` to use `create_swift_interop_info`.

requires a rules_swift release prob

keith

comment created time in 15 hours

CommitCommentEvent

PR opened bazelbuild/rules_apple

Update `apple_{static,dynamic}_framework_import` to use `create_swift_interop_info`.

The Swift build rules will use this information instead of the Objc provider to determine which module map/module name to use.

PiperOrigin-RevId: 367438964 (cherry picked from commit 8f5fa94fee0d20a60a44419ee0f7ede2474288c8)

+41 -2

0 comment

1 changed file

pr created time in 15 hours