profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/sebalix/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Sébastien Alix sebalix @camptocamp Rennes, France https://www.camptocamp.com

OCA/odoorpc 143

Python module to pilot your Odoo servers through JSON-RPC.

OCA/ansible-odoo 97

Ansible role for Odoo

grindtildeath/server-tools 0

Tools for Odoo Administrators to improve some technical features on Odoo.

mmequignon/delivery-carrier 0

Odoo Carriers And Deliveries Management

sebalix/account-closing 0

Odoo Accountant closing tools

sebalix/account-financial-reporting 0

Financial reports for Odoo

sebalix/account-invoicing 0

Odoo Invoicing Extension Addons

sebalix/account-reconcile 0

Odoo account reconciliation modules (statements, data completion,...)

sebalix/ansible-odoo 0

Ansible role for Odoo

create barnchcamptocamp/wms

branch : 14.0

created branch time in 19 hours

pull request commentOCA/wms

[14.0][MIG] stock_storage_type_putaway_abc: Migration to 14.0

/ocabot merge nobump

sebalix

comment created time in 20 hours

PullRequestReviewEvent

Pull request review commentOCA/sale-workflow

[13.0] add sale warehouse calendar

+# Copyright Camptocamp SA+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl)++from datetime import datetime++from freezegun import freeze_time++from odoo.tests.common import SavepointCase++WORKING_DAYS = list(range(5))  # working days are from monday to friday included+CUTOFF_TIME = 8.0  # cutoff time will be set at 8 a.m.++FRIDAY = "2021-08-13"+SATURSDAY = "2021-08-14"+NEXT_MONDAY = "2021-08-16"+NEXT_TUESDAY = "2021-08-17"+FRIDAY_BEFORE_CUTOFF = "2021-08-13 07:00:00"+FRIDAY_AFTER_CUTOFF = "2021-08-13 09:00:00"+++class TestSaleOrderDates(SavepointCase):+    at_install = False+    post_install = True++    @classmethod+    def _define_calendar(cls, name, attendances):+        return cls.env["resource.calendar"].create(+            {+                "name": name,+                "attendance_ids": [+                    (+                        0,+                        0,+                        {+                            "name": "%s_%d" % (name, index),+                            "hour_from": att[0],+                            "hour_to": att[1],+                            "dayofweek": str(att[2]),+                        },+                    )+                    for index, att in enumerate(attendances)+                ],+            }+        )++    @classmethod+    def setupClassCompany(cls):+        cls.company = cls.env.user.company_id+        cls.company.security_lead = 1++    @classmethod+    def setUpClassCalendar(cls):+        cls.calendar = cls._define_calendar("40 Hours", [(8, 16, i) for i in range(5)],)++    @classmethod+    def setUpClassWarehouse(cls):+        cls.warehouse = cls.env.ref("stock.warehouse0")+        cls.warehouse.write(+            {+                "cutoff_time": CUTOFF_TIME,+                "apply_cutoff": True,+                "calendar_id": cls.calendar,+            }+        )++    @classmethod+    def setUpClassPartner(cls):+        cls.customer = cls.env.ref("base.res_partner_12")+        cls.customer.order_delivery_cutoff_preference = "warehouse_cutoff"+        cls.customer.delivery_time_preference = "workdays"++    @classmethod+    def setUpClassProduct(cls):+        cls.product = cls.env.ref("product.product_product_3")++    @classmethod+    def setUpClass(cls):+        super(TestSaleOrderDates, cls).setUpClass()+        cls.env = cls.env(+            context=dict(cls.env.context, tracking_disable=True, tz="UTC")+        )+        cls.setupClassCompany()+        cls.setUpClassCalendar()+        cls.setUpClassWarehouse()+        cls.setUpClassPartner()+        cls.setUpClassProduct()++    def _create_order(self, dt):+        with freeze_time(dt.strftime("%Y-%m-%d %H:%M:%S")):+            order = self.env["sale.order"].create(+                {"partner_id": self.customer.id, "warehouse_id": self.warehouse.id}+            )+            self.env["sale.order.line"].create(+                {+                    "order_id": order.id,+                    "product_id": self.product.id,+                    "product_uom_qty": 1,+                    "customer_lead": 1,+                }+            )+            return order++    @freeze_time(FRIDAY_BEFORE_CUTOFF)+    def test_confirm_before_cutoff_last_weekday(self):+        # - preparation is friday since sale_cutoff_time_delivery,+        #   has not postponed the delivery+        # - friday is compatible with the warehouse calendar.+        # - delivery should be done on satursday+        order = self._create_order(datetime.now())

Why calling freeze_time in _create_order method, can't we rely only on the freeze done by the decorator on the test method?

mmequignon

comment created time in a day

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentOCA/sale-workflow

[13.0] add sale warehouse calendar

 jobs:       after_success:     - stage: test       env:-        - TESTS="1" ODOO_REPO="odoo/odoo" MAKEPOT="1"+        - TESTS="1" ODOO_REPO="odoo/odoo" MAKEPOT="1" EXCLUDE="sale_warehouse_calendar"     - stage: test       env:-        - TESTS="1" ODOO_REPO="OCA/OCB"+        - TESTS="1" ODOO_REPO="OCA/OCB" EXCLUDE="sale_warehouse_calendar"

Can you add a comment about the conflicting module?

mmequignon

comment created time in 2 days

PullRequestReviewEvent

pull request commentOCA/sale-workflow

[IMP] 13.0: Extract delivery date logic to specific methods

@mmequignon I agree with @simahawk , commit messages should not mention a version (when the commit is ported is not relevant)

mmequignon

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentOCA/sale-workflow

[13.0] add sale warehouse calendar

+# Copyright 2021 Camptocamp SA+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl)++from datetime import timedelta++from odoo import models+++class SaleOrderLine(models.Model):+    _inherit = "sale.order.line"++    def _get_workload(self, customer_lead):+        return 1 + customer_lead - self.company_id.security_lead

So a comment is welcome

mmequignon

comment created time in 2 days

PullRequestReviewEvent

push eventcamptocamp/wms

Sébastien Alix

commit sha f498d1f27fa43431e66088e2ba7495555703ea34

[MIG] stock_storage_type_putaway_abc: Migration to 14.0

view details

push time in 3 days

push eventcamptocamp/wms

Sébastien Alix

commit sha 12addac38d15efc7291c85f92aaf2ab91f9a3ed7

[MIG] stock_storage_type_putaway_abc: Migration to 14.0

view details

Sébastien Alix

commit sha 85c96d27b6ae2e75b59c5c71a48f5c19b3f52069

Travis: exclude new branch from build

view details

push time in 3 days

push eventcamptocamp/wms

Sébastien Alix

commit sha 12addac38d15efc7291c85f92aaf2ab91f9a3ed7

[MIG] stock_storage_type_putaway_abc: Migration to 14.0

view details

push time in 3 days

create barnchcamptocamp/wms

branch : 14.0-mig-stock_storage_type_putaway_abc

created branch time in 3 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

pull request commentOCA/stock-logistics-warehouse

[14.0][MIG] stock_measuring_device

Ah pre-commit is failing BTW

hailangvn

comment created time in 4 days

Pull request review commentOCA/stock-logistics-warehouse

[14.0][MIG] stock_measuring_device

 class MeasuringWizardLine(models.TransientModel):     name = fields.Char("Packaging", readonly=True)     qty = fields.Float("Quantity")     max_weight = fields.Float("Weight (kg)", readonly=True)-    # this is not a typo:-    # https://github.com/odoo/odoo/issues/41353#issuecomment-568037415-    lngth = fields.Integer("Length (mm)", readonly=True)+    # this is renamed to match with a change in product_packaging_dimension+    # https://github.com/OCA/product-attribute/commit/24c773cb7c0099bf2f6ac11509e1aaa6781cd03b

You can drop this comment IMO, it's not a valuable information for upcoming migrations (but it's a great info for reviewers if you do it as a comment when you open the PR).

hailangvn

comment created time in 4 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

push eventsebalix/marabunta

push time in 5 days