profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/seanparsons/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

issue commentconcrete-utopia/utopia

adding/changing App.propertyControls requires you to reload the editor

This is occurring as a result of the triggering call which is only inside generateCodeResultCache, not being triggered after updates to files in the project.

balazsbajorics

comment created time in 38 minutes

push eventconcrete-utopia/utopia

Sean Parsons

commit sha c5f9788f4ec0bbbfef92061ce4f44cce88fdf4f2

fix(inspector) Mark intrinsic elements from libraries also as imported. (#1927) - Added `isIntrinsicElementMetadata` and `isIntrinsicHTMLElementMetadata`, which just invoke the aready existing similarly named functions but against an instance of `ElementInstanceMetadata`. - Modified `isImportedComponentNPM` to also include intrinsic elements which are not regular HTML intrinsics. - Slightly tweaked `ComponentInfoBox` to handle the case for intrinsics from dependencies which wont have a value for `componentPackageName`.

view details

push time in 2 hours

delete branch concrete-utopia/utopia

delete branch : fix/handle-imported-intrinsic-elements

delete time in 2 hours

PR merged concrete-utopia/utopia

Reviewers
Mark intrinsic elements from libraries also as imported.

Problem: React Three Fiber elements were not marked as being components coming from NPM, which is as a result of them not having associated imports, because React intrinsics.

Fix: For intrinsics that are not regular HTML intrinsics, the inspector now treats them as being components that came from NPM.

Limitations: As the R3F elements are intrinsics with no matching import, we cannot identify which library they originate from.

Commit Details:

  • Added isIntrinsicElementMetadata and isIntrinsicHTMLElementMetadata, which just invoke the aready existing similarly named functions but against an instance of ElementInstanceMetadata.
  • Modified isImportedComponentNPM to also include intrinsic elements which are not regular HTML intrinsics.
  • Slightly tweaked ComponentInfoBox to handle the case for intrinsics from dependencies which wont have a value for componentPackageName.
+53 -7

2 comments

2 changed files

seanparsons

pr closed time in 2 hours

PR opened concrete-utopia/utopia

Reviewers
Mark intrinsic elements from libraries also as imported.

Problem: React Three Fiber elements were not marked as being components coming from NPM, which is as a result of them not having associated imports, because React intrinsics.

Fix: For intrinsics that are not regular HTML intrinsics, the inspector now treats them as being components that came from NPM.

Limitations: As the R3F elements are intrinsics with no matching import, we cannot identify which library they originate from.

Commit Details:

  • Added isIntrinsicElementMetadata and isIntrinsicHTMLElementMetadata, which just invoke the aready existing similarly named functions but against an instance of ElementInstanceMetadata.
  • Modified isImportedComponentNPM to also include intrinsic elements which are not regular HTML intrinsics.
  • Slightly tweaked ComponentInfoBox to handle the case for intrinsics from dependencies which wont have a value for componentPackageName.
+53 -7

0 comment

2 changed files

pr created time in a day

issue closedconcrete-utopia/utopia

Include SQL migration scripts in the deploy.

Currently the migration scripts for the database aren't included in the deploy, they need to be included as otherwise any migration added will fail when it first hits a "production" style environment (which includes staging).

This can however be delayed until the first migration script is created, as the initial script does not run for a non-development environment.

closed time in a day

seanparsons

push eventconcrete-utopia/utopia

Sean Parsons

commit sha 18815f996779741794eeeddc2d97cc21a53a3cf0

fix(editor) Update the project URL again with name updates. (#1922) - Fixes #1902. - Moved `pushProjectURLToBrowserHistory` to `editor-component.tsx` as it doesn't make any sense for it to live with the persistence layer. - `EditorComponentInner`, similar to what happens with `document.title`, will push an URL update onto the browser history (which to the user looks like the URL changing without reloading) based on project ID and/or project name updates. - Removed the logic from the state machine for updating the URL. - When creating a new project, the name previously generated is used so that it doesn't cycle names in the URL bar.

view details

push time in a day

PR merged concrete-utopia/utopia

Update the project URL again with name updates.

Fixes #1902

Problem: When renaming a project, the URL wasn't updated at the same time.

Fix: The logic for updating the URL was in a conditional that didn't get triggered after the rename.

The browser URL is now updated similarly to how the window title gets updated via a useEffect clause, albeit with both project ID and project name being used.

Fixing this exposed an issue where the name would change a second time when creating a new project, that was fixed by using the same name generated as the editor starts up when triggering the creation of a new project in the state machine.

Commit Details:

  • Fixes #1902.
  • Moved pushProjectURLToBrowserHistory to editor-component.tsx as it doesn't make any sense for it to live with the persistence layer.
  • EditorComponentInner, similar to what happens with document.title, will push an URL update onto the browser history (which to the user looks like the URL changing without reloading) based on project ID and/or project name updates.
  • Removed the logic from the state machine for updating the URL.
  • When creating a new project, the name previously generated is used so that it doesn't cycle names in the URL bar.
+17 -17

2 comments

3 changed files

seanparsons

pr closed time in a day

delete branch concrete-utopia/utopia

delete branch : fix/update-project-url-for-name

delete time in a day

issue closedconcrete-utopia/utopia

Updating the project title no longer updates the url

I believe this regressed with the introduction of the state machine. Should take a judicious call in the right place to something like

useEffect(() => {
   document.title = "new title"
}, []);

closed time in a day

maltenuhn
PullRequestReviewEvent
PullRequestReviewEvent

PR closed concrete-utopia/utopia

Test if workflows work when symlinked.

Ignore me, testing only.

+36 -181

2 comments

17 changed files

seanparsons

pr closed time in a day

push eventseanparsons/task

Sean Parsons

commit sha 30280c6a9418f46a9f31d78530422a83df536c95

Finished up the refactor for both the calendar and task listing to use the pretty printing library.

view details

push time in 3 days

push eventseanparsons/task

Sean Parsons

commit sha 76d8711f0c8d86364228974ec73e3f6f748d3efb

Fixed completed calendar.

view details

push time in 4 days

push eventseanparsons/task

Sean Parsons

commit sha 045b6bd025e4789108e466da08358f72d556f562

Committing to get changes other to another machine.

view details

push time in 4 days

PR opened concrete-utopia/utopia

Test if workflows work when symlinked.

Ignore me, testing only.

+36 -181

0 comment

17 changed files

pr created time in 4 days

create barnchconcrete-utopia/utopia

branch : dummy/symlinked-workflows

created branch time in 4 days

PR opened concrete-utopia/utopia

Reviewers
Update the project URL again with name updates.

Fixes #1902

Problem: When renaming a project, the URL wasn't updated at the same time.

Fix: The logic for updating the URL was in a conditional that didn't get triggered after the rename.

The browser URL is now updated similarly to how the window title gets updated via a useEffect clause, albeit with both project ID and project name being used.

Fixing this exposed an issue where the name would change a second time when creating a new project, that was fixed by using the same name generated as the editor starts up when triggering the creation of a new project in the state machine.

Commit Details:

  • Fixes #1902.
  • Moved pushProjectURLToBrowserHistory to editor-component.tsx as it doesn't make any sense for it to live with the persistence layer.
  • EditorComponentInner, similar to what happens with document.title, will push an URL update onto the browser history (which to the user looks like the URL changing without reloading) based on project ID and/or project name updates.
  • Removed the logic from the state machine for updating the URL.
  • When creating a new project, the name previously generated is used so that it doesn't cycle names in the URL bar.
+17 -17

0 comment

3 changed files

pr created time in 4 days

create barnchconcrete-utopia/utopia

branch : fix/update-project-url-for-name

created branch time in 4 days

push eventconcrete-utopia/utopia

Sean Parsons

commit sha 28bbba16ed8efbe6c46cc00c24138d36950d33c2

fix(canvas) Ensure that old compile errors do not persist. (#1920) - Fixes #1909. - Change the `key` property for the `div` container surrounding each build error. - Renamed the props type for `CompileErrorContainer`.

view details

push time in 4 days

delete branch concrete-utopia/utopia

delete branch : fix/no-old-compile-errors

delete time in 4 days

PR merged concrete-utopia/utopia

Ensure that old compile errors do not persist.

Fixes #1909

Problem: When typing in the code editor old errors were being maintained over subsequent updates.

Fix: The key property for a wrapper div in the error container was generated from the position of the error, but that can quite easily for some cases be exactly the same for 2 different errors, resulting in a warning from React that we were doing something bad. Replacing that with one that just uses the index from the array mapping means we are no longer getting the warning and the issue of old errors persisting goes away.

Commit Details:

  • Fixes #1909.
  • Change the key property for the div container surrounding each build error.
  • Renamed the props type for CompileErrorContainer.
+46 -44

2 comments

1 changed file

seanparsons

pr closed time in 4 days

issue closedconcrete-utopia/utopia

typing in the code editor leads to accumulation of old eslint errors

Steps to reproduce:

  1. open a new project on utopia.app/p
  2. go to App.js,
  3. start typing import { } from
  4. see that there's an eslint error for i then im then imp etc as you type along image

closed time in 4 days

balazsbajorics

issue commentconcrete-utopia/utopia

Updating the project title no longer updates the url

The title is currently updated, but the browser URL doesn't get updated.

maltenuhn

comment created time in 5 days

PullRequestReviewEvent

Pull request review commentconcrete-utopia/utopia

Show a fatal overlay when IndexedDB fails

+import React from 'react'+import { betterReactMemo } from '../../uuiui-deps'++export const FatalIndexedDBErrorComponent = betterReactMemo('FatalIndexedDBErrorComponent', () => {+  return (+    <div+      style={{+        width: '100%',+        height: '100%',+        backgroundColor: '#0000AA',+        position: 'relative',+        color: 'white',+        padding: 40,+        fontFamily: 'Courier',+        fontSize: '16px',+        display: 'flex',+        flexDirection: 'column',+        alignItems: 'center',+      }}+    >+      <p>+        <span+          style={{+            background: 'grey',+            padding: '0px 16px',+          }}+        >+          Utopia+        </span>+      </p>+      <div style={{ textAlign: 'left', maxWidth: 800 }}>+        <p>+          A problem has been detected and Utopia has been shut down to prevent damage to your+          project.+        </p>+        <p>+          If this is the first time you've seen this error screen,{' '}+          <a href='' style={{ textDecoration: 'underline', color: 'white' }}>+            reload Utopia+          </a>+          . If this screen appears again, follow these steps:+        </p>+        <p>+          Check if your computer is out of disk space. Utopia uses your browser's database to store+          projects while you work on them, and your browser may delete that database if your+          computer is low on disk space.{' '}+        </p>+        <p>Check you've not logged out of Utopia in another tab. </p>+        <p>Technical information:</p>+        <p>***INDEXEDDB BUGGERED 0xFFFFFFFFF</p>

Errr, do we really want to use that word in there?

Rheeseyb

comment created time in 5 days