profile
viewpoint
Sean Marcia seanmarcia Ruby for Good Northern Virginia https://rubyforgood.org

rubyforgood/diaper 182

Diaperbase is an inventory system for diaper banks, to aid them in tracking their inventory and providing statistics about their inventory flows.

bglusman/debt_ceiling 83

Get a grip on your technical debt

rubyforgood/voices-of-consent 34

Open source tracking and inventory management application for nonprofit, Voices of Consent (Ruby for Good 2019)

rubyforgood/abalone 20

An data tracking and analytics app for abalone conservation efforts live at abalone-dev.herokuapp.com

rubyforgood/babywearing 17

A lending library for Babywearing communities that manages baby carrier inventory and memberships

rubyforgood/coral 10

An upcoming project for Ruby for Good

rposborne/rfg-scale 9

A DYMO scale component using WebUSB for Ruby For Good.

rubyforgood/habitatebsv 5

An upcoming project for Ruby for Good

cmhnk/terrastories_as_a_service 2

Terrastories - Ruby by the Bay 2019

push eventwalterewilliams/walterewilliams.github.io

Sean Marcia

commit sha e57b615662de157be69bad507985c8ddd04820fe

column

view details

push time in 15 hours

push eventrubyforgood/casa

Sean Marcia

commit sha 87dd63cb705238a9b24fff93d90307fb00413bc9

Yarn fixes for broken tests.

view details

push time in 2 days

push eventrubyforgood/casa

Sean Marcia

commit sha 96a9262e9e572262ab7af27da6c49ccdf69bc693

Yarn fixes for broken tests.

view details

push time in 2 days

Pull request review commentrubyforgood/casa

Applies STI to the User model

+class User < ApplicationRecord+  self.table_name = 'users'+end++class AddTypeToUser < ActiveRecord::Migration[6.0]+  def up+    add_column :users, :type, :string+    add_column :users, :active, :boolean, default: true++    # Set supervisor+    User.where(role: "supervisor").update_all(type: "Supervisor")

If this goes in before we "go live" we can probably kill these updates and just reset the database.

armahillo

comment created time in 2 days

MemberEvent

PR closed rubyforgood/casa

Reviewers
#466 Add new supervisor

What github issue is this PR for, if any?

Resolves #466

What changed, and why?

@seanmarcia and @jimnanney did the bulk of this work, I'm just helping finish it

They created the supervisors#new view. It has a link on the dashboard, and it works and has a system spec.

How will this affect user permissions?

n/a

How is this tested? (please write tests!) 💖💪

manually and AT-AT

Feelings gif (optional)

an AT AT

+971 -971

0 comment

18 changed files

armahillo

pr closed time in 2 days

push eventrubyforgood/diaper

Edwin Mak

commit sha 64fdeab49fbf09014f17bdbffeb957b5fd9bcba5

Add ability for admins to filter list of organization by name (#1768) * Add filterrific gem * Implement search by organization name via filterritic on admins#organization * Add system to spec to ensure filtering organizations as admin works * Remove change only used for testing

view details

push time in 2 days

PR merged rubyforgood/diaper

Add ability for admins to filter list of organization by name

Resolves #1765

Description

This PR grants the ability for admins to filter the organization's list on the admins#organization page. This feature also gives admins the ability to search using this feature to better ensure that new organization account requests aren't duplicates.

This PR was highly influenced by the merged PR in the partner base repo authored by @seanmarcia - https://github.com/rubyforgood/partner/pull/336

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Yes manually & via added system tests

Screenshots

Screen Shot 2020-08-01 at 3 51 21 PM Screen Shot 2020-08-01 at 3 51 25 PM Screen Shot 2020-08-01 at 3 51 32 PM Screen Shot 2020-08-01 at 3 51 36 PM

+106 -20

1 comment

10 changed files

edwinthinks

pr closed time in 2 days

issue closedrubyforgood/diaper

Add Search Functionality to Admin Organization Index Page

Summary

The diaper app now has several organizational users and it would be really helpful to be able to search for existing organization before adding new ones, so that duplicate records are not accidentally created.

When the user begins typing, results are returned as they type more letters in the word. For example, when the user types ba, all results that contain those letters populate in the search drop-down, or filters the list of organizations.

image

If you have any questions, please contact me (Gia) in the Ruby for Good Slack.

Criteria for Completion

  • [ ] Admins are able to filter down results using character matches in the list of existing organizations.
  • [ ] All relevant tests for this functionality.

closed time in 2 days

designbygia

push eventrubyforgood/casa

Sean Marcia

commit sha 0daae3cf3a601d8260aadb36ac940216bf2e6112

Yarn fixes for broken tests.

view details

push time in 2 days

push eventrubyforgood/casa

Sean Marcia

commit sha a92231e7e4721cb7014186176d449633041912a1

Yarn fixes for broken tests.

view details

push time in 2 days

create barnchrubyforgood/casa

branch : add_new_supervisor-466

created branch time in 5 days

PR closed rubyforgood/diaper

Feature/move organization controller spec to request spec

<!--Read comments, before committing pull request read checklist again

Checklist:

  • I have performed a self-review of my own code,
  • I have commented my code, particularly in hard-to-understand areas,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works,
  • New and existing unit tests pass locally with my changes ("bundle exec rake"),
  • Title include "WIP" if work is in progress.

-->

Resolves #1419

Description

<!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. Guide questions:

  • What motivated this change (if not already described in an issue)?
  • What alternative solutions did you consider?
  • What are the tradeoffs for your solution?

List any dependencies that are required for this change. (gems, js libraries, etc.)

Include anything else we should know about. -->

Move organization_controller_spec.rb to organization_request_spec.rb

Type of change

<!-- Please delete options that are not relevant. -->

  • Improvement
+142 -186

1 comment

5 changed files

EmersonManabuAraki

pr closed time in 5 days

pull request commentrubyforgood/casa

Formatting errors fix from copy paste.

Hey! Honestly, I don't know. This kind of stuff (emails) are stuff that, for me, tends to get set and then never change. Then, each time I have to do it, I have to look it up.

On Thu, Jul 30, 2020 at 12:46 PM naufragio de guardia de producción metafísica con linda desastre notifications@github.com wrote:

:) Is there a test we can write that checks this kind of thing- maybe something with the fake mail gem? You don't have to add it, I'm just looking for advice- I haven't done this in a while 😅

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rubyforgood/casa/pull/473#issuecomment-666517879, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFDCBO4UKGEDCWAE2M5NBTR6GPXDANCNFSM4PNYJ5NA .

seanmarcia

comment created time in 5 days

PR opened rubyforgood/casa

Formatting errors fix from copy paste.

Sorry, there were a couple of typos and spaces inserted from copy and pasting. This fixes htem.

+4 -4

0 comment

2 changed files

pr created time in 5 days

create barnchrubyforgood/casa

branch : mailfix

created branch time in 5 days

PR opened rubyforgood/casa

Removes mailgun and switches to sendinblue for emails.

Signed up for a sendingblue account that gives 300 free emails a day. (password shared to admins)

This will fix the issue with mailgun only allowing 5 differ recipients.

+12 -34

0 comment

4 changed files

pr created time in 6 days

push eventrubyforgood/casa

Sean Marcia

commit sha c6339774839e7de74ea8d814e6c91d5e3c69e4ad

Removes mailgun and switches to sendinblue for emails.

view details

push time in 6 days

create barnchrubyforgood/casa

branch : email_sending

created branch time in 6 days

create barnchrubyforgood/casa

branch : switch_to_sendgrid

created branch time in 7 days

PR opened rubyforgood/casa

Refactor the csv import to give more information.

When I was adding in the ability for the casa to import csv files I noticed that casa_case's were not attached to a casa_org. This PR adds in a migration to do that. Since it is a belongs_to this will likely break dev environments for folks. People will either need to do a drop/create/migrate/seed or jump into a console and run something like CasaCase.update_all(casa_org_id: 1)

All tests, forms, and whatnot have been updated to have casa_cases use the casa_org_id. Note: In the forms just set it has a hidden_field pointing at the current_user's casa_org id.

I also went and cleaned up the csv import stuff. Namely to make the routes more restful (use the create action) and to add in information about the imports. It also quickly doesn't error out now if the user forgets to attach a csv file.

Now when an admin imports csv they will see the number of volunteers, supervisors, casa cases they have imported. It will also let them know which cases/users/supervisors failed to import.

Successful volunteer import (supervisor looks the same):

volunteer-success

Volunteer import with fails (supervisor looks the same):

volunteer - fail

Successful case import: case - success

Failed case import:

case - fail

Feelings gif (optional)

+188 -40

0 comment

17 changed files

pr created time in 7 days

push eventrubyforgood/casa

Sean Marcia

commit sha 58156e2f2848ddf9266b1d0fcd9ae594576952d2

Refactor the csv import to give more information. Also made casa_org required on casa_cases.

view details

push time in 7 days

create barnchrubyforgood/casa

branch : refactor_csv_import

created branch time in 7 days

push eventwalterewilliams/walterewilliams.github.io

Sean Marcia

commit sha e0d114e3863fcd5aa5f5be15323122d22a060b10

column

view details

push time in 8 days

push eventrubyforgood/casa

Sean Marcia

commit sha 89a3fec9b33edebfcb02b8d2c74341aecf5f574d

Allow admins to import volunteers, supervisors, and cases.

view details

push time in 8 days

push eventrubyforgood/casa

Sean Marcia

commit sha 457a9cbafd3ac8f58fd8124998a7d253079cccf3

Allow admins to import volunteers, supervisors, and cases.

view details

push time in 8 days

pull request commentrubyforgood/casa

Allow admins to import volunteers, supervisors, and cases.

While I think this is good enough to go right now and begin testing I am planning on refactor to:

Remove the custom routes import_volunteers, import_supervisors, import_cases and be restful and use the create action with a trait to determine which import to run. Probably encapsulate each of the three imports in a service.

I think some of these imports should also be wrapped in an activeRecord::Base.transaction -- particularly the casa_case import. Casa cases don't appear to be attached to a casa_org so if we fail to associate them with a user we should probably roll back the transaction otherwise the case may end up floating in the ether. I don't currently have enough context on casa cases (and the rest) to

seanmarcia

comment created time in 9 days

push eventrubyforgood/casa

Sean Marcia

commit sha 62d13e02f928550e0ad56834bf88b76ae767017c

Allow admins to import volunteers, supervisors, and cases.

view details

push time in 9 days

PR opened rubyforgood/casa

Allow admins to import volunteers, supervisors, and cases.

What github issue is this PR for, if any?

Resolves #18

What changed, and why?

This PR does a bit more than the issue of just importing volunteers. I also allows the importation of supervisors and casa cases.

I added in the devise_invitable gem to make sending emails to new volunteers and supervisors easy. Also added in the mailcatcher gem with some configurations in development.rb to enable the testing of sending the emails.

How will this affect user permissions?

  • Volunteer permissions:
  • Supervisor permissions:
  • Admin permissions: Only admins can do this.

How is this tested? (please write tests!) 💖💪

I added in a new imports route that is tested with a request spec and I create a FileImporter class that is tested in /spec/models directory. (Probably not the best spot for it.) I also added in a fixtures directory with example csv's for the three different import types (volunteers, supervisors, casa_cases.)

Screenshots please :)

menu_item

imports

Feelings gif (optional)

+569 -5

0 comment

29 changed files

pr created time in 9 days

push eventrubyforgood/casa

Sean Marcia

commit sha cb09b3d479015c4f59da411de76ca3888fd0cc5e

Allow admins to import volunteers, supervisors, and cases.

view details

push time in 9 days

create barnchrubyforgood/casa

branch : import_users-18

created branch time in 9 days

pull request commentrubyforgood/casa

Allow users to change their passwords.

Also added in a couple capybara system specs.

seanmarcia

comment created time in 9 days

Pull request review commentrubyforgood/casa

Allow users to change their passwords.

   padding: 8px;   margin: 12px 0; }++.alert-dismissible .close {+  padding: 0.5rem 0.75rem;+}

Fixed :)

seanmarcia

comment created time in 9 days

push eventrubyforgood/casa

Sean Marcia

commit sha cdc61ca8210c38d7f9d62b739d65512a305443ce

Allow users to change their passwords. Add in some error helpers. Font Awesome. And a bit more.

view details

push time in 9 days

push eventrubyforgood/casa

Sean Marcia

commit sha 9514b49f2f7ba0df3bf4928ef2133cebbbfe0462

Allow users to change their passwords. Add in some error helpers. Font Awesome. And a bit more.

view details

push time in 9 days

PR opened rubyforgood/casa

WIP - Allow users to change their passwords. Add in some error helpers. Fon…

…t Awesome. And a bit more.

This resolves #189

At the core this resolves #189 allowing folks to change their password. We already have the ability for folks to reset their password if they forgot it so the work done, primarily, is for logged in folks.

A summary of stuff with pictures: -Changed the forgot password button link on the sign-in page to a button to make it more obvious it exists:

image

becomes:

image

Next I changed the edit profile page around a bit:

edit_profit

becomes:

new_profile

When you click the change password button it opens up the following:

change_password

I also added in a helper method with styling for the error messages so they are not plain text and more visible. So, rather than doing something like this in our views:

      <% if @user.errors.any? %>	
        <div id="error_explanation">	
          <h2><%= pluralize(user.errors.count, "error") %> prohibited this user from being saved:</h2>	

          <ul>	
            <% user.errors.full_messages.each do |message| %>	
              <li><%= message %></li>	
            <% end %>	
          </ul>	
        </div>	
      <% end %>

We can just do <%= errors_for(@user) %>

Error messages now look like this:

error messages

I also updated the flash messages how they are shown in the application.html.erb and made them dismissible. I also added in font-awesome-rails to the gemfile to put in an X into the alerts. (Plus it is handy to use elsewhere)

I also put in a tiny javascript function that will auto close alerts from pages after a couple of seconds.

The new alerts look like this:

alerts

It is still a WIP because I have a couple questions:

How is the team testing stuff that overlaps with gems? I'm happy to add in tests for the changing password functionality but it kind of feels like I'm testing stuff that overlaps with devise and didn't want to add cruft to the app.

I also added in Font Awesome which you all may not be cool with.

I'm also not sure where that tiny js function should live -- it is currently in application.js.

Let me know what you want me to do with all this and I'll move it forward.

+86 -19

0 comment

11 changed files

pr created time in 10 days

push eventrubyforgood/casa

Sean Marcia

commit sha 5a4b7a7b500f149ececa048a3c58dc750cfec21e

Allow users to change their passwords. Add in some error helpers. Font Awesome. And a bit more.

view details

push time in 10 days

push eventrubyforgood/casa

Sean Marcia

commit sha 6dd186913bf023baaceefb017c0a5b537b456a5f

Allow users to change their passwords. Add in some error helpers. Font Awesome. And a bit more.

view details

push time in 10 days

create barnchrubyforgood/casa

branch : reset_password-189

created branch time in 10 days

issue commentrubyforgood/casa

add Reset Password to Edit Profile

Working on this.

Zrrrpy

comment created time in 10 days

issue closedrubyforgood/diaper

Fix UX on cake

#1751

closed time in 11 days

edwinthinks

issue closedrubyforgood/diaper

[EPIC] Usuablity

closed time in 11 days

edwinthinks

delete branch rubyforgood/diaper

delete branch : revert-1444-dependabot/bundler/webdrivers-4.2.0

delete time in 11 days

delete branch rubyforgood/diaper

delete branch : add_in_paperclip

delete time in 11 days

create barnchrubyforgood/diaper

branch : add_in_paperclip

created branch time in 11 days

PR opened rubyforgood/diaper

Add paperclip back to the gemfile so legacy migrations work.

I had a new contributor complain that running rails db:migrate didn't work and that our migrations were broken.

It turns out that since we used to have paperclip in the application and we had a migration that depended on it we need to put this back to let new folks be able to run the migrations.

This is obviously a short term fix. We'll need to eventually remove the gem and the fix the migrations but this immediately unbreaks things and lets new contributors run migrations as expected.

+14 -0

0 comment

2 changed files

pr created time in 12 days

create barnchrubyforgood/diaper

branch : paperclip

created branch time in 12 days

push eventrubyforgood/diaper

Sean Marcia

commit sha 48e2bd81269871bcce189d206d1d9d8f351eab13

Commenting out a couple tests.

view details

push time in 14 days

PR closed rubyforgood/diaper

[1418] [WIP] Make transfers editable

Resolves #1418

Description

This PR attempts to give users the ability to edit transfers after they have been created. I've come close to a solution but here is what still needs to be handled:

  • [ ] Edits that remove line item need to fix inventory count
  • [ ] Build feature test (integration)
  • [ ] Dropdown count of line items to be visible on load. Currently selecting and deselecting a storage location is required. See the snapshot below.

Type of change

  • New feature (non-breaking change which adds functionality)

Screenshots

Screen Shot 2020-01-30 at 5 19 37 PM Screen Shot 2020-01-30 at 5 19 53 PM

+2509 -875

2 comments

139 changed files

edwinthinks

pr closed time in 14 days

pull request commentrubyforgood/diaper

[1418] [WIP] Make transfers editable

This one is fairly out of date. Let's sync up on slack on this one!

edwinthinks

comment created time in 14 days

push eventrubyforgood/diaper

Lucas Hiago

commit sha 1d386ce338b9d2e0a0a97c60230c67a7fb63a33a

Add new admin organization requests spec (#1548) * Add new admin organizations requests spec * Remove old admin organization controller spec * Corrects rubocop warning

view details

push time in 14 days

PR merged rubyforgood/diaper

Add new admin organization requests spec

Description

Change from admin organizations controller spec to requests spec

Type of change

<!-- Please delete options that are not relevant. -->

  • Improvement

How Has This Been Tested?

<!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Do we need to do anything else to verify your changes? If so, provide instructions (including any relevant configuration) so that we can reproduce? -->

All tests are green

+27 -42

1 comment

1 changed file

luchiago

pr closed time in 14 days

push eventwalterewilliams/walterewilliams.github.io

Sean Marcia

commit sha a8f6fe433c7f642c160664cf9c2e9ee147d2d45f

column

view details

push time in 15 days

delete branch rubyforgood/diaper

delete branch : 1407-removes-html-from-error-message

delete time in 15 days

delete branch rubyforgood/diaper

delete branch : 1597-include-organization-email-in-partner-invitation

delete time in 15 days

delete branch rubyforgood/diaper

delete branch : feature/1605_v2

delete time in 15 days

delete branch rubyforgood/diaper

delete branch : remove-empty-file

delete time in 15 days

delete branch rubyforgood/diaper

delete branch : dependabot/bundler/simplecov-0.18.5

delete time in 15 days

delete branch rubyforgood/diaper

delete branch : mdworken-patch-1

delete time in 15 days

delete branch rubyforgood/diaper

delete branch : mkd/1486-label-method-errors

delete time in 15 days

delete branch rubyforgood/diaper

delete branch : mkd/hotfix-100-x-values

delete time in 15 days

delete branch rubyforgood/diaper

delete branch : 1640_allow_diaper_banks_to_delete_purchases

delete time in 15 days

delete branch rubyforgood/diaper

delete branch : ch1584/extract-superclass-for-distribution

delete time in 15 days

delete branch rubyforgood/diaper

delete branch : send-organization-email-properly-to-partner-create-api

delete time in 15 days

delete branch rubyforgood/diaper

delete branch : spec-cleanup

delete time in 15 days

delete branch rubyforgood/diaper

delete branch : gracefully-fail-donation-destroy

delete time in 15 days

delete branch rubyforgood/diaper

delete branch : address_fields

delete time in 15 days

delete branch rubyforgood/diaper

delete branch : add_time_to_reminder_emails-1570

delete time in 15 days

MemberEvent

push eventrubyforgood/rubyforgood.org

Craig Zaccaro

commit sha 31ded25742be4f6a1dccf33bbfeff285ccf32e4c

Add a button that links to the GitHub sponsor page under the Sponsors section of the homepage.

view details

Sean Marcia

commit sha f1edc388165f5630f8b396385bff3dcf0cd091ae

Merge pull request #154 from rubyforgood/github-sponsor-button Add a button that links to the GitHub sponsor page under the Sponsors…

view details

push time in 21 days

push eventwalterewilliams/walterewilliams.github.io

Sean Marcia

commit sha 0b061e5602446fff631a9eea889552eab0a4a08b

column

view details

push time in 22 days

push eventrubyforgood/partner

dependabot-preview[bot]

commit sha 42fe8d5bd3ba1b00c4a44278abdc26ff1502ec92

Bump rubocop-rspec from 1.40.0 to 1.41.0 (#360) Bumps [rubocop-rspec](https://github.com/rubocop-hq/rubocop-rspec) from 1.40.0 to 1.41.0. - [Release notes](https://github.com/rubocop-hq/rubocop-rspec/releases) - [Changelog](https://github.com/rubocop-hq/rubocop-rspec/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop-hq/rubocop-rspec/compare/v1.40.0...v1.41.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

push time in a month

PR merged rubyforgood/partner

Bump rubocop-rspec from 1.40.0 to 1.41.0 dependencies

Bumps rubocop-rspec from 1.40.0 to 1.41.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/rubocop-hq/rubocop-rspec/releases">rubocop-rspec's releases</a>.</em></p> <blockquote> <h2>RuboCop RSpec v1.41.0</h2> <ul> <li>Extend the list of Rails spec types for <code>RSpec/DescribeClass</code>. (<a href="https://github.com/pirj">@pirj</a>)</li> <li>Fix <code>FactoryBot/AttributeDefinedStatically</code> to allow <code>#traits_for_enum</code> without a block. ([<a href="https://github.com/harrylewis">@harrylewis</a>][])</li> <li>Improve the performance of <code>FactoryBot/AttributeDefinedStatically</code>, <code>RSpec/InstanceVariable</code>, <code>RSpec/LetSetup</code>, <code>RSpec/NestedGroups</code> and <code>RSpec/ReturnFromStub</code>. ([<a href="https://github.com/andrykonchin">@andrykonchin</a>][])</li> </ul> <!-- raw HTML omitted --> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/rubocop-hq/rubocop-rspec/blob/master/CHANGELOG.md">rubocop-rspec's changelog</a>.</em></p> <blockquote> <h2>1.41.0 (2020-07-03)</h2> <ul> <li>Extend the list of Rails spec types for <code>RSpec/DescribeClass</code>. ([<a href="https://github.com/pirj">@pirj</a>][])</li> <li>Fix <code>FactoryBot/AttributeDefinedStatically</code> to allow <code>#traits_for_enum</code> without a block. ([<a href="https://github.com/harrylewis">@harrylewis</a>][])</li> <li>Improve the performance of <code>FactoryBot/AttributeDefinedStatically</code>, <code>RSpec/InstanceVariable</code>, <code>RSpec/LetSetup</code>, <code>RSpec/NestedGroups</code> and <code>RSpec/ReturnFromStub</code>. ([<a href="https://github.com/andrykonchin">@andrykonchin</a>][])</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rubocop-hq/rubocop-rspec/commit/e6857d8d79f0fade6bfdb238d56f48cc691228e4"><code>e6857d8</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop-rspec/issues/953">#953</a> from rubocop-hq/release</li> <li><a href="https://github.com/rubocop-hq/rubocop-rspec/commit/44e7d6e04932054369706b610affaa1bab22dd46"><code>44e7d6e</code></a> Bump version to v1.41.0</li> <li><a href="https://github.com/rubocop-hq/rubocop-rspec/commit/6e1d698a52bb4f151d46f5e8fe6bd2af4fa75122"><code>6e1d698</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop-rspec/issues/951">#951</a> from andrykonchin/optimize-performance-let-setup</li> <li><a href="https://github.com/rubocop-hq/rubocop-rspec/commit/28eab5afecf9a56995618c578b755a0b21a1425f"><code>28eab5a</code></a> RSpec/LetSetup Optimize #on_block callback</li> <li><a href="https://github.com/rubocop-hq/rubocop-rspec/commit/5551988c51b292a51d94613c4e02a2a7911c7523"><code>5551988</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop-rspec/issues/950">#950</a> from andrykonchin/optimize-performance-nested-groups</li> <li><a href="https://github.com/rubocop-hq/rubocop-rspec/commit/85b0399e3de64ee4b902c74270d35d1baf83e13a"><code>85b0399</code></a> RSpec/NestedGroups Optimize #on_top_level_describe callback</li> <li><a href="https://github.com/rubocop-hq/rubocop-rspec/commit/172dfe8e9c8ebdb3cb0a369429f91173196e8e58"><code>172dfe8</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop-rspec/issues/934">#934</a> from mockdeep/rf-shared_groups</li> <li><a href="https://github.com/rubocop-hq/rubocop-rspec/commit/7e2d6dcca6615977907c15dbd9270462019ceb26"><code>7e2d6dc</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop-rspec/issues/946">#946</a> from andrykonchin/optimize-performance-instance-variable</li> <li><a href="https://github.com/rubocop-hq/rubocop-rspec/commit/c51c544a673109188721a98b58eef1385ed5e775"><code>c51c544</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop-rspec/issues/949">#949</a> from andrykonchin/optimize-performance-attribute_defi...</li> <li><a href="https://github.com/rubocop-hq/rubocop-rspec/commit/87229cc7ec3025f030e5226ec803c35d708d86cc"><code>87229cc</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop-rspec/issues/944">#944</a> from harrylewis/bugfix/add-new-factory-bot-method-to-...</li> <li>Additional commits viewable in <a href="https://github.com/rubocop-hq/rubocop-rspec/compare/v1.40.0...v1.41.0">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+2 -2

0 comment

1 changed file

dependabot-preview[bot]

pr closed time in a month

push eventrubyforgood/partner

dependabot-preview[bot]

commit sha 684b3ce27c8f0254c3ddc51b73447cdfb5c42247

Bump rubocop from 0.86.0 to 0.87.0 (#361) Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.86.0 to 0.87.0. - [Release notes](https://github.com/rubocop-hq/rubocop/releases) - [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.86.0...v0.87.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

push time in a month

PR merged rubyforgood/partner

Bump rubocop from 0.86.0 to 0.87.0 dependencies

Bumps rubocop from 0.86.0 to 0.87.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/rubocop-hq/rubocop/releases">rubocop's releases</a>.</em></p> <blockquote> <h2>RuboCop 0.87</h2> <h3>New features</h3> <ul> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/7868">#7868</a>: <code>Cop::Base</code> is the new recommended base class for cops. (<a href="https://github.com/marcandre">@marcandre</a>)</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/3983">#3983</a>: Add new <code>Style/AccessorGrouping</code> cop. (<a href="https://github.com/fatkodima">@fatkodima</a>)</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/8244">#8244</a>: Add new <code>Style/BisectedAttrAccessor</code> cop. (<a href="https://github.com/fatkodima">@fatkodima</a>)</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/7458">#7458</a>: Add new <code>AsciiConstants</code> option for <code>Naming/AsciiIdentifiers</code>. (<a href="https://github.com/fatkodima">@fatkodima</a>)</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/7373">#7373</a>: Add new <code>Style/RedundantAssignment</code> cop. (<a href="https://github.com/fatkodima">@fatkodima</a>)</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/8213">#8213</a>: Permit to specify TargetRubyVersion 2.8 (experimental). (<a href="https://github.com/koic">@koic</a>)</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/8159">#8159</a>: Add new <code>CountAsOne</code> option for code length related <code>Metric</code> cops. (<a href="https://github.com/fatkodima">@fatkodima</a>)</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/8164">#8164</a>: Support auto-correction for <code>Lint/InterpolationCheck</code>. (<a href="https://github.com/koic">@koic</a>)</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/8223">#8223</a>: Support auto-correction for <code>Style/IfUnlessModifierOfIfUnless</code>. (<a href="https://github.com/koic">@koic</a>)</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/8172">#8172</a>: Support auto-correction for <code>Lint/SafeNavigationWithEmpty</code>. (<a href="https://github.com/koic">@koic</a>)</li> </ul> <h3>Bug fixes</h3> <ul> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/8039">#8039</a>: Fix false positives for <code>Lint/ParenthesesAsGroupedExpression</code> in when using operators or chain functions. (<a href="https://github.com/CamilleDrapier">@CamilleDrapier</a>)</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/8196">#8196</a>: Fix a false positive for <code>Style/RedundantFetchBlock</code> when using with <code>Rails.cache</code>. (<a href="https://github.com/fatkodima">@fatkodima</a>)</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/8195">#8195</a>: Fix an error for <code>Style/RedundantFetchBlock</code> when using <code>#fetch</code> with empty block. (<a href="https://github.com/koic">@koic</a>)</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/8193">#8193</a>: Fix a false positive for <code>Style/RedundantRegexpCharacterClass</code> when using <code>[\b]</code>. (<a href="https://github.com/owst">@owst</a>)</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/8205">#8205</a>: Fix a false positive for <code>Style/RedundantRegexpCharacterClass</code> when using a leading escaped <code>]</code>. (<a href="https://github.com/owst">@owst</a>)</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/8208">#8208</a>: Fix <code>Style/RedundantParentheses</code> with hash literal as first argument to <code>yield</code>. (<a href="https://github.com/karlwithak">@karlwithak</a>)</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/8176">#8176</a>: Don't load <code>.rubocop.yml</code> from personal folders to check for exclusions if there's a project configuration. (<a href="https://github.com/deivid-rodriguez">@deivid-rodriguez</a>)</li> </ul> <h3>Changes</h3> <ul> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/7868">#7868</a>: <strong>(Breaking)</strong> Extensive refactoring of internal classes <code>Team</code>, <code>Commissioner</code>, <code>Corrector</code>. <code>Cop::Cop#corrections</code> not completely compatible. See Upgrade Notes. (<a href="https://github.com/marcandre">@marcandre</a>)</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/8156">#8156</a>: <strong>(Breaking)</strong> <code>rubocop -a / --autocorrect</code> no longer run unsafe corrections; <code>rubocop -A / --autocorrect-all</code> run both safe and unsafe corrections. Options <code>--safe-autocorrect</code> is deprecated. (<a href="https://github.com/marcandre">@marcandre</a>)</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/8207">#8207</a>: <strong>(Breaking)</strong> Order for gems names now disregards underscores and dashes unless <code>ConsiderPunctuation</code> setting is set to <code>true</code>. (<a href="https://github.com/marcandre">@marcandre</a>)</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/8211">#8211</a>: <code>Style/ClassVars</code> cop now detects <code>class_variable_set</code>. (<a href="https://github.com/biinari">@biinari</a>)</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/8245">#8245</a>: Detect top-level constants like <code>::Const</code> in various cops. (<a href="https://github.com/biinari">@biinari</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md">rubocop's changelog</a>.</em></p> <blockquote> <h2>0.87.0 (2020-07-06)</h2> <h3>New features</h3> <ul> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/7868">#7868</a>: <code>Cop::Base</code> is the new recommended base class for cops. ([<a href="https://github.com/marcandre">@marcandre</a>][])</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/3983">#3983</a>: Add new <code>Style/AccessorGrouping</code> cop. ([<a href="https://github.com/fatkodima">@fatkodima</a>][])</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/8244">#8244</a>: Add new <code>Style/BisectedAttrAccessor</code> cop. ([<a href="https://github.com/fatkodima">@fatkodima</a>][])</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/7458">#7458</a>: Add new <code>AsciiConstants</code> option for <code>Naming/AsciiIdentifiers</code>. ([<a href="https://github.com/fatkodima">@fatkodima</a>][])</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/7373">#7373</a>: Add new <code>Style/RedundantAssignment</code> cop. ([<a href="https://github.com/fatkodima">@fatkodima</a>][])</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/8213">#8213</a>: Permit to specify TargetRubyVersion 2.8 (experimental). ([<a href="https://github.com/koic">@koic</a>][])</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/8159">#8159</a>: Add new <code>CountAsOne</code> option for code length related <code>Metric</code> cops. ([<a href="https://github.com/fatkodima">@fatkodima</a>][])</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/8164">#8164</a>: Support auto-correction for <code>Lint/InterpolationCheck</code>. ([<a href="https://github.com/koic">@koic</a>][])</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/8223">#8223</a>: Support auto-correction for <code>Style/IfUnlessModifierOfIfUnless</code>. ([<a href="https://github.com/koic">@koic</a>][])</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/8172">#8172</a>: Support auto-correction for <code>Lint/SafeNavigationWithEmpty</code>. ([<a href="https://github.com/koic">@koic</a>][])</li> </ul> <h3>Bug fixes</h3> <ul> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/8039">#8039</a>: Fix false positives for <code>Lint/ParenthesesAsGroupedExpression</code> in when using operators or chain functions. ([<a href="https://github.com/CamilleDrapier">@CamilleDrapier</a>][])</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/8196">#8196</a>: Fix a false positive for <code>Style/RedundantFetchBlock</code> when using with <code>Rails.cache</code>. ([<a href="https://github.com/fatkodima">@fatkodima</a>][])</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/8195">#8195</a>: Fix an error for <code>Style/RedundantFetchBlock</code> when using <code>#fetch</code> with empty block. ([<a href="https://github.com/koic">@koic</a>][])</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/8193">#8193</a>: Fix a false positive for <code>Style/RedundantRegexpCharacterClass</code> when using <code>[\b]</code>. ([<a href="https://github.com/owst">@owst</a>][])</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/8205">#8205</a>: Fix a false positive for <code>Style/RedundantRegexpCharacterClass</code> when using a leading escaped <code>]</code>. ([<a href="https://github.com/owst">@owst</a>][])</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/8208">#8208</a>: Fix <code>Style/RedundantParentheses</code> with hash literal as first argument to <code>yield</code>. ([<a href="https://github.com/karlwithak">@karlwithak</a>][])</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/8176">#8176</a>: Don't load <code>.rubocop.yml</code> from personal folders to check for exclusions if there's a project configuration. ([<a href="https://github.com/deivid-rodriguez">@deivid-rodriguez</a>][])</li> </ul> <h3>Changes</h3> <ul> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/7868">#7868</a>: <strong>(Breaking)</strong> Extensive refactoring of internal classes <code>Team</code>, <code>Commissioner</code>, <code>Corrector</code>. <code>Cop::Cop#corrections</code> not completely compatible. See Upgrade Notes. ([<a href="https://github.com/marcandre">@marcandre</a>][])</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/8156">#8156</a>: <strong>(Breaking)</strong> <code>rubocop -a / --autocorrect</code> no longer run unsafe corrections; <code>rubocop -A / --autocorrect-all</code> run both safe and unsafe corrections. Options <code>--safe-autocorrect</code> is deprecated. ([<a href="https://github.com/marcandre">@marcandre</a>][])</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/8207">#8207</a>: <strong>(Breaking)</strong> Order for gems names now disregards underscores and dashes unless <code>ConsiderPunctuation</code> setting is set to <code>true</code>. ([<a href="https://github.com/marcandre">@marcandre</a>][])</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/8211">#8211</a>: <code>Style/ClassVars</code> cop now detects <code>class_variable_set</code>. ([<a href="https://github.com/biinari">@biinari</a>][])</li> <li><a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/pull/8245">#8245</a>: Detect top-level constants like <code>::Const</code> in various cops. ([<a href="https://github.com/biinari">@biinari</a>][])</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rubocop-hq/rubocop/commit/ba8f13ad9640e71b29853d552f90a54e0acd7625"><code>ba8f13a</code></a> Cut 0.87</li> <li><a href="https://github.com/rubocop-hq/rubocop/commit/040e829b81f856aab4e40853f856b5df79b05738"><code>040e829</code></a> Changelog entry for <a href="https://github-redirect.dependabot.com/rubocop-hq/rubocop/issues/8245">#8245</a></li> <li><a href="https://github.com/rubocop-hq/rubocop/commit/5e03e9be65f3568c1ec1278a2fe395a8fb644ab1"><code>5e03e9b</code></a> Allow top-level const in MutableConst</li> <li><a href="https://github.com/rubocop-hq/rubocop/commit/91820ead1807623162aaa7653424aa0fae4cb915"><code>91820ea</code></a> Detect top-level const in ExpandPathArguments</li> <li><a href="https://github.com/rubocop-hq/rubocop/commit/bc268f899548b3d2721917f47b7e94ae40b64119"><code>bc268f8</code></a> Detect top-level const in RandomWithOffset</li> <li><a href="https://github.com/rubocop-hq/rubocop/commit/a59d579d100c48c076fd54c3e35deaba233cb335"><code>a59d579</code></a> Detect redundant ::RuntimeError in raise/fail</li> <li><a href="https://github.com/rubocop-hq/rubocop/commit/ce20cb432c9b85588d9162e93d0031a04b2b2e3a"><code>ce20cb4</code></a> Detect ::ENV in Style/RedundantFreeze</li> <li><a href="https://github.com/rubocop-hq/rubocop/commit/dbc3794111d054c0c017650759468ef5f0a12d5b"><code>dbc3794</code></a> Allow top-level const in Style/ZeroLengthPredicate</li> <li><a href="https://github.com/rubocop-hq/rubocop/commit/d0de34a931559517bfd385f740e5e1a6d3747863"><code>d0de34a</code></a> Allow ::Proc.new with arg in Style/SymbolProc</li> <li><a href="https://github.com/rubocop-hq/rubocop/commit/d49938681392382c5e46442d8f5bbf8b24bd319e"><code>d499386</code></a> Detect ::Struct in Style/StructInheritance</li> <li>Additional commits viewable in <a href="https://github.com/rubocop-hq/rubocop/compare/v0.86.0...v0.87.0">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+4 -4

0 comment

1 changed file

dependabot-preview[bot]

pr closed time in a month

push eventwalterewilliams/walterewilliams.github.io

Sean Marcia

commit sha 66002867caf3c77324e71dd20376d29a8994c3ae

column

view details

push time in a month

push eventrubyforgood/diaper

Sean Marcia

commit sha 36b0c33ae861ce4428ebdf4fc589b12eda301a68

Tiny commit to fix missing agency type.

view details

push time in a month

push eventrubyforgood/rubyforgood.org

RJ Beers

commit sha 6ed10019cf9f5c839fd527eb40469aa770246973

Fix navigation visual issue Moves featured navigation item to the same line as the rest of the navigation. This also makes the content below the navigation appear aligned while scrolling on the landing page.

view details

Sean Marcia

commit sha daf765853b43590b35d0b1682dde33b3d516bff0

Merge pull request #151 from rjbeers/fix-navigation-css Fix navigation visual issue

view details

push time in a month

PR merged rubyforgood/rubyforgood.org

Fix navigation visual issue

Moves featured navigation item to the same line as the rest of the navigation. This also makes the content below the navigation appear aligned while scrolling on the landing page.

Before (see nav height and content alignment below it)

before 1 See height of nav after scrolling down before 2

After (see nav height and content alignment below it)

after 1 See height of nav after scrolling down after 2

+1 -1

0 comment

1 changed file

rjbeers

pr closed time in a month

push eventrubyforgood/rubyforgood.org

Craig Zaccaro

commit sha c26cf29c751f00028f474c5ce373aae8622ccc14

First round of content updates for the September 2020 Ruby for Good event.

view details

Sean Marcia

commit sha 8c03abb3b3f7f361ba04c7d9056d85282eb07682

Merge pull request #152 from rubyforgood/fall2020_initial_updates First round of content updates for the September 2020 Ruby for Good e…

view details

push time in a month

push eventrubyforgood/diaper

Sean Marcia

commit sha 08647d2a30272c19fcb3d50a228657eb1be93858

Fix deploy file to match dependabot updated version.

view details

Sean Marcia

commit sha 6c85acb9f587ec306572b3b93e9566e4e1deaa95

Merge branch 'master' of github.com:rubyforgood/diaper

view details

push time in a month

push eventrubyforgood/diaper

Sean Marcia

commit sha 82196133dbb5b48d10478a86f283a2746ca40808

Address fields were not showing up. This PR fixes that. We were not grabbing the right hash value. (#1730)

view details

push time in a month

PR merged rubyforgood/diaper

Address fields were not showing up.

Got some feedback from a diaper bank that the address fields were not showing up in their approve partner page. This PR fixes that.

This also moves the fakeredis gem back into the development section since folks have been having an issue with that.

+6 -6

1 comment

2 changed files

seanmarcia

pr closed time in a month

PR opened rubyforgood/diaper

Address fields were not showing up.

Got some feedback from a diaper bank that the address fields were not showing up in their approve partner page. This PR fixes that.

This also moves the fakeredis gem back into the development section since folks have been having an issue with that.

+6 -6

0 comment

2 changed files

pr created time in a month

create barnchrubyforgood/diaper

branch : address_fields

created branch time in a month

push eventrubyforgood/diaper

Renata Marques

commit sha a8d52bcdcf6d58268c562588e41d928c4261fc14

#1712 Add total item quantity in donations#show page (#1729)

view details

push time in a month

PR merged rubyforgood/diaper

#1712 Add total item quantity in donations#show page

resolves #1712

Type of change

  • New feature (non-breaking change which adds functionality)

Screenshots

old behavior

image

new behavior

Screen Shot 2020-07-02 at 18 08 55

+1 -1

2 comments

1 changed file

renatamarques97

pr closed time in a month

issue closedrubyforgood/diaper

Add total item quantity in donations#show page

Summary

Originally from a request made to address a bug in https://github.com/rubyforgood/diaper/issues/1703. This is a related request included that involves adding the total quantity on the donations details page.

Example route to the page: http://diaper.test/diaper_bank/donations/14

84697624-7976df00-af1c-11ea-8b08-34bda64bbf1b

Criteria for Completion

  • [ ] When a user access the donation page, they see the quantity total
  • [ ] Add a spec coverage of this addition. (spec/system/donation_system_spec.rb:479 could be a good place)

closed time in a month

edwinthinks

pull request commentrubyforgood/diaper

#1712 Add total item quantity in donations#show page

Thanks!

renatamarques97

comment created time in a month

issue commentrubyforgood/diaper

Add Quota and Notes to Partner Agency

Awesome! Thanks, assigning you now!

seanmarcia

comment created time in a month

push eventrubyforgood/diaper

John Cato

commit sha 1559fb6884289b90b87e0ee01393cadfbf7ffd45

Alphabetize parnter list in filter options (#1728)

view details

push time in a month

PR merged rubyforgood/diaper

Alphabetize partner list in filter options

<!--Read comments, before committing pull request read checklist again

Checklist:

  • I have performed a self-review of my own code,
  • I have commented my code, particularly in hard-to-understand areas,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works,
  • New and existing unit tests pass locally with my changes ("bundle exec rake"),
  • Title include "WIP" if work is in progress.

-->

Resolves #1705 <!--fill issue number-->

Description

<!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. Guide questions:

  • What motivated this change (if not already described in an issue)?
  • What alternative solutions did you consider?
  • What are the tradeoffs for your solution?

List any dependencies that are required for this change. (gems, js libraries, etc.)

Include anything else we should know about. -->

Type of change

<!-- Please delete options that are not relevant. -->

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I manually tested the change via the UI. Due to the size of the change, I'm not sure this would require a test. I'm open to suggestions 😄

Screenshots

image

+1 -1

2 comments

1 changed file

cato-hga

pr closed time in a month

issue closedrubyforgood/diaper

Nice to have: alphabetized partner list in filter options

Hi there!

I was trying to find a partner agency today to filter in our distributions list and realized that the beginning of our partner list is alphabetized, but it appears after a certain point when we added on a whole new crop of partners, the list stopped alphabetizing. It would be great to have it all alphabetized to make it easier to find partners since we now have over 50. Screen Shot 2020-06-16 at 9 53 02 AM

Megan

closed time in a month

SCDB

pull request commentrubyforgood/diaper

Alphabetize partner list in filter options

Looks great, thanks for making the change!

cato-hga

comment created time in a month

push eventrubyforgood/partner

Emerson Manabu Araki

commit sha 00e4f2fb99cae2035d484498b549b37a94b8e419

Add filter to families (#349) Co-authored-by: Emerson Manabu Araki <emerson.araki@codeminer42.com>

view details

push time in a month

PR merged rubyforgood/partner

Add filter to families

Description

<!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. Guide questions:

  • What motivated this change (if not already described in an issue)?
  • What alternative solutions did you consider?
  • What are the tradeoffs for your solution?

Include anything else we should know about. -->

Add filter to families page

Type of change

<!-- Please delete options that are not relevant. -->

  • Feature

How Has This Been Tested?

Running tests with rspec

+159 -30

2 comments

6 changed files

EmersonManabuAraki

pr closed time in a month

pull request commentrubyforgood/partner

Add filter to families

Thank you!

EmersonManabuAraki

comment created time in a month

push eventrubyforgood/partner

Emerson Manabu Araki

commit sha 9b1982a26125bbb922e32709f2361c0be37b091c

Add filtering for Family Request (#359) Co-authored-by: Emerson Manabu Araki <emerson.araki@codeminer42.com>

view details

push time in a month

more