profile
viewpoint
Steve Durrheimer sdurrheimer @cycloidio Alsace, France

prometheus/promu 183

Prometheus Utility Tool

prometheus/golang-builder 57

Prometheus Golang builder Docker images

prometheus/busybox 21

Prometheus Busybox Docker base images

sdurrheimer/docker-compose-zsh-completion 19

zsh completion for docker-compose

sdurrheimer/alpine-golang-make-onbuild 3

Docker image for small size onbuild golang containers using make

Giorgiolino/kideploy 2

Meteor demo project. Who is deploying/uploading ?

nomaddevops/network 2

Terraform module to manage all network related on AWS

sdurrheimer/promu 1

Moved to https://github.com/prometheus/promu

startedEdlinOrg/prominentcolor

started time in 6 hours

Pull request review commentprometheus/prometheus

TSDB backfill: enforce # EOF

 func (p *OpenMetricsParser) Next() (textparse.Entry, error) { 		if et, err := p.Parser.Next(); err != io.EOF { 			return et, err 		}+		if string(line) == "# EOF\n" {

We add it here: https://github.com/prometheus/prometheus/pull/8232/files#diff-1f356c3850c952097aff258debcd0f10d6a313b616a17510de7d6c0448b4d853R49

roidelapluie

comment created time in 6 hours

push eventprometheus/prometheus

Ganesh Vernekar

commit sha 9972e69c43c2452dc8041d8ee39de1cb3ef0088d

Cut v2.23.0-rc.0 (#8206) Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>

view details

Ganesh Vernekar

commit sha 26d89b4b0776fe4cd5a3656dfa520f119a375273

Cut v2.23.0 (#8223) Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>

view details

Julien Pivotto

commit sha 868184b33a640abbca2f9025bfa6cb04e99e030b

Merge pull request #8234 from prometheus/release-2.23 Merge release 2.23 to master

view details

push time in 6 hours

PR merged prometheus/prometheus

Merge release 2.23 to master

<!-- Don't forget!

- If the PR adds or changes a behaviour or fixes a bug of an exported API it would need a unit/e2e test.

- Where possible use only exported APIs for tests to simplify the review and make it as close as possible to an actual library usage.

- No tests are needed for internal implementation changes.

- Performance improvements would need a benchmark test to prove it.

- All exposed objects should have a comment.

- All comments should start with a capital letter and end with a full stop.

-->

+30 -1

1 comment

2 changed files

roidelapluie

pr closed time in 6 hours

Pull request review commentprometheus/prometheus

TSDB backfill: enforce # EOF

 func (p *OpenMetricsParser) Next() (textparse.Entry, error) { 		if et, err := p.Parser.Next(); err != io.EOF { 			return et, err 		}+		if string(line) == "# EOF\n" {

The \n is optional.

roidelapluie

comment created time in 6 hours

pull request commentprometheus/prometheus

Merge release 2.23 to master

:+1:

roidelapluie

comment created time in 6 hours

PR opened prometheus/prometheus

Update remote-write grafana mixin

@beorn7 pls review This is related to https://github.com/prometheus/prometheus/issues/8229 <!-- Don't forget!

- If the PR adds or changes a behaviour or fixes a bug of an exported API it would need a unit/e2e test.

- Where possible use only exported APIs for tests to simplify the review and make it as close as possible to an actual library usage.

- No tests are needed for internal implementation changes.

- Performance improvements would need a benchmark test to prove it.

- All exposed objects should have a comment.

- All comments should start with a capital letter and end with a full stop.

-->

+6 -6

0 comment

1 changed file

pr created time in 7 hours

startedbenbjohnson/clock

started time in 7 hours

PR opened prometheus/prometheus

Merge release 2.23 to master

<!-- Don't forget!

- If the PR adds or changes a behaviour or fixes a bug of an exported API it would need a unit/e2e test.

- Where possible use only exported APIs for tests to simplify the review and make it as close as possible to an actual library usage.

- No tests are needed for internal implementation changes.

- Performance improvements would need a benchmark test to prove it.

- All exposed objects should have a comment.

- All comments should start with a capital letter and end with a full stop.

-->

+30 -1

0 comment

2 changed files

pr created time in 7 hours

issue openedprometheus/prometheus

gce_sd_configs cannot filter on tags

<!--

Please do *NOT* ask usage questions in Github issues.

If your issue is not a feature request or bug report use:
https://groups.google.com/forum/#!forum/prometheus-users. If
you are unsure whether you hit a bug, search and ask in the
mailing list first.

You can find more information at: https://prometheus.io/community/

-->

What did you do? In /etc/prometheus/prometheus.yml, I have the following snippet:

scrape_configs:
  - job_name: mytargets
    gce_sd_configs:
      - project: my-project-id
        zone: us-central1-b
        port: 9100
        filter: "tags.items = mytargets"

What did you expect to see? I was expecting this to work as a filter. The documentation https://prometheus.io/docs/prometheus/latest/configuration/configuration/#gce_sd_config says:

# Syntax of this filter string is described here in the filter query parameter section:
# https://cloud.google.com/compute/docs/reference/latest/instances/list

and sure enough, gcloud compute instances list --filter 'tags.items = mytargets works.

What did you see instead? Under which circumstances? When starting prometheus, I get the following error:

level=error ts=2020-11-27T22:16:41.839Z caller=refresh.go:79 component="discovery manager scrape" discovery=gce msg="Unable to refresh target groups" err="error retrieving refresh targets from gce: googleapi: Error 400: Invalid value for field 'filter': 'tags.items=mytargets'. Invalid list filter expression., invalid"

Note that the error comes from the Google API, which means that something along the way mangles the filter.

Environment

  • System information:

Linux 5.4.0-1029-gcp x86_64

  • Prometheus version:
$ prometheus --version
prometheus, version 2.15.2+ds (branch: debian/sid, revision: 2.15.2+ds-2)
  build user:       pkg-go-maintainers@lists.alioth.debian.org
  build date:       20200113-10:10:54
  go version:       go1.13.7
  • Alertmanager version:

    insert output of alertmanager --version here (if relevant to the issue)

  • Prometheus configuration file:

insert configuration here
  • Alertmanager configuration file:
insert configuration here (if relevant to the issue)
  • Logs:
insert Prometheus and Alertmanager logs relevant to the issue here

created time in 8 hours

PR opened prometheus/prometheus

Reviewers
TSDB import: enforce # EOF

cc @aSquare14

Fix #8228

Signed-off-by: Julien Pivotto roidelapluie@inuits.eu

<!-- Don't forget!

- If the PR adds or changes a behaviour or fixes a bug of an exported API it would need a unit/e2e test.

- Where possible use only exported APIs for tests to simplify the review and make it as close as possible to an actual library usage.

- No tests are needed for internal implementation changes.

- Performance improvements would need a benchmark test to prove it.

- All exposed objects should have a comment.

- All comments should start with a capital letter and end with a full stop.

-->

+31 -1

0 comment

2 changed files

pr created time in 8 hours

pull request commentprometheus/blackbox_exporter

Resolve #715 Metric for unknown probe

Thanks!

gavk34

comment created time in 9 hours

push eventprometheus/blackbox_exporter

gavk34

commit sha 57b2925620b3ea2d3bb20899e16a415c2d5dd95b

Resolve #715 Metric for unknown probe (#716) Co-authored-by: Gavin Kelly <gkelly@newsweaver.com>

view details

push time in 9 hours

issue closedprometheus/blackbox_exporter

[Feature Request] > Metric for unknown module

Currently this is hidden in the response https://github.com/prometheus/blackbox_exporter/blob/9fd70341277528877d55bfeffd46593646bca347/main.go#L77

Would be great to add two info points to this

  • Log Error message
  • Metric

Reason we ask for a metric is so that we(SRE) team can alert on misconfiguration of the module by teams. Thanks

I might get time to do this myself...seems easy enough 🤞

closed time in 9 hours

gavk34

issue commentprometheus/prometheus

Metric type in prompb

No, #6815 does not allow this. The information it provides is not sufficient, timely, or sent to the shard where it would be needed.

Pryz

comment created time in 9 hours

pull request commentprometheus/prometheus

Adds support to build promql parser in CI

@roidelapluie any views?

Harkishen-Singh

comment created time in 9 hours

Pull request review commentprometheus/blackbox_exporter

Resolve #715 Metric for unknown probe

 func probeHandler(w http.ResponseWriter, r *http.Request, c *config.Config, logg 	module, ok := c.Modules[moduleName] 	if !ok { 		http.Error(w, fmt.Sprintf("Unknown module %q", moduleName), http.StatusBadRequest)-		level.Debug(logger).Log("msg", "Error ", "err", "unknown module name", "module", moduleName)+		level.Debug(logger).Log("msg", "Error finding module", "module", moduleName)

Done, just in time for the Toy Show 🇮🇪 😄

gavk34

comment created time in 9 hours

Pull request review commentprometheus/blackbox_exporter

Resolve #715 Metric for unknown probe

 func probeHandler(w http.ResponseWriter, r *http.Request, c *config.Config, logg 	module, ok := c.Modules[moduleName] 	if !ok { 		http.Error(w, fmt.Sprintf("Unknown module %q", moduleName), http.StatusBadRequest)-		level.Debug(logger).Log("msg", "Error ", "err", "unknown module name", "module", moduleName)+		level.Debug(logger).Log("msg", "Error finding module", "module", moduleName)

It's not about finding, keep it consistent with the error we send back over HTTP - so Unknown module.

gavk34

comment created time in 9 hours

issue commentprometheus/prometheus

Metric type in prompb

@brian-brazil should this be closed as I think it is implemented in #6815

Pryz

comment created time in 10 hours

issue commentprometheus/prometheus

Joining different labels

Here is a design doc / proposal

https://docs.google.com/document/d/1KWh7TNt66zMqn6_yBytZ_n_KEXOhHX0Qmmv2JLssy0s/edit?usp=sharing

fabxc

comment created time in 10 hours

issue commentprometheus/prometheus

Investigate remote write resharding conditions

Sorry for the delay here.

Changing the handling of 429s is a different issue. One solution would be to consider 429s as recoverable errors

As per the discussion, is this the only thing left as part of this issue? @csmarchbanks

cstyan

comment created time in 10 hours

issue commentprometheus/prometheus

Promtool query should print error messages from upstream server

Just do the query against https://prometheus.io

Unable to reproduce this. BTW, the process is unclear as well.

roidelapluie

comment created time in 10 hours

pull request commentprometheus/prometheus

Reduce resharding impact by redirecting data to new shards

What would happen in the current implementation if a reshard is attempted but the remote endpoint is down? You would have shards stuck in sendSamples forever without a context cancellation I think?

The current implementation (with recent push) is such that after each shard is formed, we check if send sendSample() fails to send any sample, which is beyond the flush deadline, then we do a hardshutdown like earlier cases.

Harkishen-Singh

comment created time in 10 hours

PR opened prometheus/client_java

Summary based on HdrHistogram

This work supersedes #484. The main difference is that HdrHistogram implementation is copy-pasted as is to remove external dependency.

+15605 -524

0 comment

58 changed files

pr created time in 12 hours

push eventprometheus/docs

Richard Hartmann

commit sha 5b08612ded9ee69ce97c0442e713ef8a724dabe2

Add dev summit 2020 4 Signed-off-by: Richard Hartmann <richih@richih.org>

view details

Frederic Branczyk

commit sha a97d2ab526cc0a77e99b83c922312049a611a333

Merge pull request #1807 from prometheus/richih/dev_sum_2020-4 Add dev summit 2020 4

view details

push time in 13 hours

delete branch prometheus/docs

delete branch : richih/dev_sum_2020-4

delete time in 13 hours

PR merged prometheus/docs

Add dev summit 2020 4

Signed-off-by: Richard Hartmann richih@richih.org

+3 -0

1 comment

1 changed file

RichiH

pr closed time in 13 hours

pull request commentprometheus/docs

Add dev summit 2020 4

:+1:

RichiH

comment created time in 13 hours

Pull request review commentprometheus/blackbox_exporter

Resolve #715 Metric for unknown probe

 func probeHandler(w http.ResponseWriter, r *http.Request, c *config.Config, logg 	module, ok := c.Modules[moduleName] 	if !ok { 		http.Error(w, fmt.Sprintf("Unknown module %q", moduleName), http.StatusBadRequest)+		level.Debug(logger).Log("msg", "Error ", "err", fmt.Sprintf("unknown module %s", moduleName))

The message should be a fixed string about what's going on, and then the module a pair on its own.

gavk34

comment created time in 13 hours

more