profile
viewpoint
Pablo Aguiar scorphus @Kite-Consult Munich, Bavaria, Germany https://pabloaguiar.me  ❤️ FOSS Advocate              ⚡️ SDE @Kite-Consult            🙌 Mentor @HackIllinois           ☕️ Coffee Geek                  💡 Hacker

nvbn/thefuck 55699

Magnificent app which corrects your previous console command.

oh-my-fish/oh-my-fish 6520

The Fish Shell Framework

marcwebbie/passpie 896

:closed_lock_with_key: Multiplatform command-line password manager

albertoleal/features 63

Handy tool to deal with feature toggles.

oh-my-fish/plugin-thefuck 44

Provide fast and painless support to TheFuck

heynemann/generator-python-package 40

yeoman generator to create new python packages

oh-my-fish/theme-scorphish 33

Compact. Sufficient. PWD, Ruby+RVM, Python+VENV, Git status, Rust, NodeJS.

oh-my-fish/theme-fishbone 28

A clean theme for fish shell managed by Oh my fish

heynemann/tornado-angular 10

tornado-angular is an opinionated way of distributing angular applications with tornado web server as api handler.

oh-my-fish/plugin-python 9

Set of shortcuts to Python based utilities (pybeatifyjson – clean JSON files, pyclean – remove old .pyc, pyhttp & pysmtp – simple HTTP & SMTP servers)

delete branch scorphus/advent-of-code

delete branch : gh-actions

delete time in 2 hours

push eventscorphus/advent-of-code

Pablo Santiago Blum de Aguiar

commit sha e081e8e6d255dbff4583eff18a0b8558540cb6fc

2018: add coverage to the workflow

view details

push time in 2 hours

push eventscorphus/advent-of-code

Pablo Santiago Blum de Aguiar

commit sha da420efdfaf38820f4656ee2539c40fa2d549b10

2018: add coverage to the workflow

view details

push time in 2 hours

push eventscorphus/advent-of-code

Pablo Santiago Blum de Aguiar

commit sha ba9f363811fc66ba4b9787a02f0f4e3c4f6e0a77

2018: add coverage to the workflow

view details

push time in 2 hours

push eventscorphus/advent-of-code

Pablo Santiago Blum de Aguiar

commit sha 8dd8c91f716cc09da5c2ca1595d67ab4615b6242

2018: add coverage to the workflow

view details

push time in 3 hours

push eventscorphus/advent-of-code

Pablo Santiago Blum de Aguiar

commit sha 8e1cf7575c80f0337e8551d058cb34ae70aae61b

2018: add coverage to the workflow

view details

push time in 3 hours

push eventscorphus/advent-of-code

Pablo Santiago Blum de Aguiar

commit sha 5e1a1ee47ec0304279a0ec60618a64f727351a17

2018: add coverage to the workflow

view details

push time in 3 hours

push eventscorphus/advent-of-code

Pablo Santiago Blum de Aguiar

commit sha 3cbc23fdeeea09e6d4069918d04f785b1f1ff98b

2018: add coverage to the workflow

view details

push time in 4 hours

push eventscorphus/advent-of-code

Pablo Santiago Blum de Aguiar

commit sha 411d18dce954635027c269c299915fa544aaac2e

2018: add coverage to the workflow

view details

push time in 4 hours

push eventscorphus/advent-of-code

Pablo Santiago Blum de Aguiar

commit sha 1e2847bde0a8fac4ec8d73d5d8975bb81fbabc31

2018: add coverage to the workflow

view details

push time in 4 hours

push eventscorphus/advent-of-code

Pablo Santiago Blum de Aguiar

commit sha b19806266a7d4e69878cc2653eaf1746fcaadaa9

2018: add coverage to the workflow

view details

push time in 4 hours

push eventscorphus/advent-of-code

Pablo Santiago Blum de Aguiar

commit sha b3907b57049a1b20fb32d08a87ad87eaead8b9e1

2018: add coverage to the workflow

view details

push time in 4 hours

push eventscorphus/advent-of-code

Pablo Santiago Blum de Aguiar

commit sha dae8434cd1026e216a93d3b73992b99ca6b219c5

2018: add coverage to the workflow

view details

push time in 4 hours

create barnchscorphus/advent-of-code

branch : gh-actions

created branch time in 4 hours

delete branch scorphus/advent-of-code

delete branch : gh-actions

delete time in 4 hours

push eventscorphus/advent-of-code

Pablo Aguiar

commit sha 4e0335ba0538ed5d60cf05666bab1e735ea9bf95

2018: setup GitHub actions

view details

push time in 4 hours

push eventscorphus/advent-of-code

Pablo Aguiar

commit sha d8e9a701e1cb2c300f3004c62e200850fa0fa333

2018: setup GitHub actions

view details

push time in 4 hours

push eventscorphus/advent-of-code

Pablo Aguiar

commit sha fab1c0aeff5a7c38057d9356e7db6481e8b9f496

2018: setup GitHub actions

view details

push time in 5 hours

push eventscorphus/advent-of-code

Pablo Aguiar

commit sha 094b6b3f475df3c2d25676e7574f238975a1f34e

2018: setup GitHub actions

view details

push time in 5 hours

push eventscorphus/advent-of-code

Pablo Aguiar

commit sha cb93b93ed612b1703fd6d1a4a6058bbcb7cef288

2018: setup GitHub actions

view details

push time in 5 hours

push eventscorphus/advent-of-code

Pablo Aguiar

commit sha 00e20308c66ca051324a6293ef95fddf236f3ca1

2018: setup GitHub actions

view details

push time in 5 hours

push eventscorphus/advent-of-code

Pablo Aguiar

commit sha 0158b280f33357b33e24419a43ea30f9bb43c1f2

2018: setup GitHub actions

view details

push time in 5 hours

push eventscorphus/advent-of-code

Pablo Aguiar

commit sha ac033edb53bd6984faf1bb4e54cc61c6ef43a14b

2018: setup GitHub actions

view details

push time in 5 hours

push eventscorphus/advent-of-code

Pablo Aguiar

commit sha d1c296168cf837ee923237a3cff96c5dba58da91

2018: setup GitHub actions

view details

push time in 5 hours

push eventscorphus/advent-of-code

Pablo Aguiar

commit sha 55dcb4ad3a92caf08fabf47af20b85ba8bb4d946

2018: setup GitHub actions

view details

push time in 5 hours

push eventscorphus/advent-of-code

Pablo Santiago Blum de Aguiar

commit sha d5de27c8541e2cd438c9aeebe138f495c481e115

fixup! fixup! fixup! fixup! fixup! fixup! 2018: setup GitHub actions

view details

Pablo Santiago Blum de Aguiar

commit sha f46a91cc6c6ba9332184433d2cf69a375893ea88

fixup! fixup! fixup! fixup! fixup! fixup! fixup! 2018: setup GitHub actions

view details

push time in 5 hours

push eventscorphus/advent-of-code

Pablo Santiago Blum de Aguiar

commit sha 0ea6f48d0eaa06f4806b22d35f00c3a5d2a10cec

fixup! fixup! fixup! fixup! fixup! 2018: setup GitHub actions

view details

push time in 5 hours

push eventscorphus/advent-of-code

Pablo Santiago Blum de Aguiar

commit sha 0cde59878d7f670f24b927c690da8f0667c5c475

fixup! fixup! fixup! fixup! 2018: setup GitHub actions

view details

push time in 5 hours

push eventscorphus/advent-of-code

Pablo Santiago Blum de Aguiar

commit sha 4a81fe640a5da16f8b8e11afd90a3df3cd0547aa

fixup! fixup! fixup! 2018: setup GitHub actions

view details

push time in 6 hours

push eventscorphus/advent-of-code

Pablo Santiago Blum de Aguiar

commit sha 46c3ad31293999221fa5598454daff7d3093a933

fixup! fixup! 2018: setup GitHub actions

view details

push time in 6 hours

push eventscorphus/advent-of-code

Pablo Santiago Blum de Aguiar

commit sha 09ce4522786b510f2eb48c1bf0737fe1cc98f814

fixup! 2018: setup GitHub actions

view details

push time in 6 hours

PR opened scorphus/advent-of-code

2018: setup GitHub actions
+26 -0

0 comment

1 changed file

pr created time in 6 hours

create barnchscorphus/advent-of-code

branch : gh-actions

created branch time in 6 hours

push eventscorphus/advent-of-code

Pablo Santiago Blum de Aguiar

commit sha a2f83c66c4a2c73a191a45448d8ae66988a97bc4

2018/day07/part2: solve with Rust

view details

push time in 6 hours

issue closednvbn/thefuck

eval (thefuck --alias) gives error fish: Expected end of the statement, but instead found a pipe

<!-- If you have any issue with The Fuck, sorry about that, but we will do what we can to fix that. Actually, maybe we already have, so first thing to do is to update The Fuck and see if the bug is still there. -->

<!-- If it is (sorry again), check if the problem has not already been reported and if not, just open an issue on GitHub with the following basic information: -->

The output of thefuck --version (something like The Fuck 3.1 using Python 3.5.0 and Bash 4.4.12(1)-release):

The Fuck 3.30 using Python 3.8.5 and Fish Shell 3.1.2

Your system (Debian 7, ArchLinux, Windows, etc.):

Arch Linux

How to reproduce the bug:

1. Open fish shell
2. Execute
    $ eval (thefuck --alias) 

The output of The Fuck with THEFUCK_DEBUG=true exported (typically execute export THEFUCK_DEBUG=true in your shell before The Fuck):

Same error.

If the bug only appears with a specific application, the output of that application and its version:

sir@napkin ~> eval (thefuck --alias)
fish: Expected end of the statement, but instead found a pipe
function fuck -d "Correct your previous console command"   set -l fucked_up_command $history[1]   env TF_SHELL=fish TF_ALIAS=fuck PYTHONIOENCODING=utf-8 thefuck $fucked_up_command THEFUCK_ARGUMENT_PLACEHOLDER $argv | read -l unfucked_command   if [ "$unfucked_command" != "" ]     eval $unfucked_command     builtin history delete --exact --case-sensitive -- $fucked_up_command     builtin history merge ^ /dev/null   end end
                                                                                                                                                                                                                   ^

sir@napkin ~ [1]> 

Anything else you think is relevant:

Image in case the text misalignes above

image

<!-- It's only with enough information that we can do something to fix the problem. -->

closed time in 13 hours

SirNapkin1334

issue commentnvbn/thefuck

eval (thefuck --alias) gives error fish: Expected end of the statement, but instead found a pipe

Fish's eval uses source under the hood, so we recommend using it insted:

Quoting Shell-aliases > Fish:

Add this function to config.fish:

thefuck --alias | source 

It's right there on README.md 🙂

If you'd like to keep using eval, this should be your line:

eval (thefuck --alias | string join \;)

Please, check the wiki for other tips 😉

SirNapkin1334

comment created time in 13 hours

push eventscorphus/advent-of-code

Pablo Santiago Blum de Aguiar

commit sha 1ced2662d6d4c7c728db2d1a67a7f97bdabe247e

2018/day07/part1: solve with Rust

view details

push time in 2 days

push eventscorphus/advent-of-code

Pablo Santiago Blum de Aguiar

commit sha 129be96083c51ec424b5da57dd512b66b5536f00

2018/day06/part1: solve with Rust

view details

Pablo Santiago Blum de Aguiar

commit sha 86b3b22c7152a2a6d15b74ed3c9851a83a2bc12b

2018/day06/part2: solve with Rust

view details

Pablo Santiago Blum de Aguiar

commit sha 8c46454ba0cf5a923790cc4f0b6a09255bf821f4

2018/tests: fix order of assert_eq macro variables

view details

push time in 3 days

push eventscorphus/advent-of-code

Pablo Santiago Blum de Aguiar

commit sha 351e0f055ad01d09e4767d45f59dfafa51dbc8c8

2018/day06/part1: solve with Rust

view details

Pablo Santiago Blum de Aguiar

commit sha cd32a9cffb573fcf287d49d88dba8d6548a3e7c0

2018/day06/part2: solve with Rust

view details

push time in 3 days

push eventscorphus/advent-of-code

Pablo Santiago Blum de Aguiar

commit sha e87cc327baa9414cdf6b1c1c1f3ad85fee26041f

2018/day05/part1: improve Rust solution

view details

Pablo Santiago Blum de Aguiar

commit sha 7be8c70689f9c1fcb6ba2a87025e882d148221b5

2018/day05/part2: solve with Rust

view details

Pablo Santiago Blum de Aguiar

commit sha 5e3d149a4da117eea13e47b53d5d4982b1967a99

2018: fix hook entries

view details

Pablo Santiago Blum de Aguiar

commit sha 57e8fd24aad995536e7e9ed02bbf43e90bc3a5b9

2018: move hook entries to Makefile

view details

push time in 5 days

push eventscorphus/advent-of-code

Pablo Santiago Blum de Aguiar

commit sha 11118be7b9dd547574959d5d2e7943743182913a

2018/day05/part1: solve with Rust

view details

push time in 5 days

push eventscorphus/advent-of-code

Pablo Santiago Blum de Aguiar

commit sha cec13ae99f793f8be3eb271fca92937b31bf270c

2018/Makefile: start with setup and coverage targets

view details

Pablo Santiago Blum de Aguiar

commit sha f856d3bce5fc9e9dfb8957a4960b698ff834273f

2018: run checks with pre-commit on commit and push

view details

Pablo Santiago Blum de Aguiar

commit sha 8b73ad0557d9046ab55a1530c0dd2a82a1af0691

2018/day03: fix syntax

view details

Pablo Santiago Blum de Aguiar

commit sha 19ea672b3fec9f96aa9104587b5e88246c7e462f

2018/day04: fix header remark

view details

Pablo Santiago Blum de Aguiar

commit sha c5eea1f56f09aab901027c3668f6524f28291cb3

2018/day02: panic instead of returning non answer

view details

Pablo Santiago Blum de Aguiar

commit sha 76fdb3a224f9281e67ac9f1b5d5ac67159c802c0

2018/day01: rename macro for consistency

view details

Pablo Santiago Blum de Aguiar

commit sha 64331c30263d6e3823e7640a9d960c1ce737d8c4

2018: read input only once, in main

view details

push time in 5 days

push eventscorphus/advent-of-code

Pablo Santiago Blum de Aguiar

commit sha dd675bba974600f658bdba3554fac2b0a1e03b49

2018/day04/part1: solve with Rust

view details

Pablo Santiago Blum de Aguiar

commit sha 6b922f22dfe1ecfad1865b58fcf23ce020dc67d3

README: specify which language for each edition

view details

Pablo Santiago Blum de Aguiar

commit sha 68ec6239c2ad5228f76d63b469f61200a4a823c5

LICENSE: update with standard text

view details

Pablo Santiago Blum de Aguiar

commit sha a220509cdf10bd7907521c79e3405d116120a3a9

2018/day04/part2: solve with Rust

view details

push time in 6 days

delete branch scorphus/advent-of-code

delete branch : fixes

delete time in 6 days

push eventscorphus/advent-of-code

Pablo Santiago Blum de Aguiar

commit sha 2c0d83b6b79979a331e5e1dae0ded2ce3e0dac41

README: specify which language for each edition

view details

Pablo Santiago Blum de Aguiar

commit sha 7d0be118bfe32fbe14f92bd73e0d31a9555d1f3e

LICENSE: update with standard text

view details

push time in 6 days

push eventscorphus/advent-of-code

Pablo Santiago Blum de Aguiar

commit sha 6203f9a9fd13d1146d167f9e2f60d571eb63c550

LICENSE: update with standard text

view details

push time in 6 days

push eventscorphus/advent-of-code

Pablo Santiago Blum de Aguiar

commit sha 3d4a0b63c8ef270a6c3a3666bdd7c8fd9f0b30f2

README: specify which language for each edition

view details

push time in 6 days

create barnchscorphus/advent-of-code

branch : fixes

created branch time in 6 days

push eventscorphus/advent-of-code

Pablo Santiago Blum de Aguiar

commit sha 3eb333a9c6c2ea1fbea91277d67db1eab2348630

2018/day03/part1: solve with Rust

view details

Pablo Santiago Blum de Aguiar

commit sha 633dabf8f9d40d3819162d931c1a2c8956c5992a

2018/day03/part2: solve with Rust

view details

push time in 8 days

push eventscorphus/scorphiles

Pablo Santiago Blum de Aguiar

commit sha 35fe5ce42b5da2104cd35c5912e51af4787dd926

vscode/settings: update vscode settings

view details

push time in 10 days

PR opened cheykoff/photoassistant

ignore Python related files in Git
+138 -0

0 comment

2 changed files

pr created time in 11 days

push eventscorphus/photoassistant

Pablo Santiago Blum de Aguiar

commit sha a7c54e3b87415a9ec9f8e26520d0215bde193ad4

ignore Python related files in Git

view details

push time in 11 days

create barnchscorphus/photoassistant

branch : gitignore

created branch time in 11 days

push eventscorphus/photoassistant

push time in 11 days

push eventscorphus/photoassistant

Pablo Santiago Blum de Aguiar

commit sha 952516840b570ee648b2fc46463e05e5bbc04858

ignore Python-related files in Git

view details

push time in 11 days

fork scorphus/photoassistant

A playground to make photo sorting easier

fork in 11 days

push eventscorphus/advent-of-code

Pablo Santiago Blum de Aguiar

commit sha 7ca50f53f4330297973b064de78f3cb3aca8fcc3

2018/day02/part1: solve with Rust

view details

Pablo Santiago Blum de Aguiar

commit sha 1d2554f82d43fbfaccbb40aa930e86c719f55857

2018/day02/part2: solve with Rust

view details

Pablo Santiago Blum de Aguiar

commit sha f441336a15fd12cd33390119cabe761548beefbd

2018/main: reduce repetition a bit

view details

Pablo Santiago Blum de Aguiar

commit sha 5f9ed0951df83a500a206e8ebb0d04526c6582a9

2018: restructure code so you read it top down I like the way Elixir code reads so it's good that Rust accepts it, for the most part.

view details

Pablo Santiago Blum de Aguiar

commit sha 86461287696bbcb2f1ce3b2b0d16eabdb7b10ade

2018: copy answer to clipboard

view details

push time in 12 days

push eventscorphus/advent-of-code

Pablo Santiago Blum de Aguiar

commit sha 737ed2c0746d653f1a77d0bfa86dccdaa8723897

2018/day01: those are changes not frequencies

view details

Pablo Santiago Blum de Aguiar

commit sha 055f37d37613f52833336a7659e80b6532567a99

2018/day01: write some tests

view details

push time in 13 days

push eventscorphus/advent-of-code

Pablo Santiago Blum de Aguiar

commit sha a8b28fd195035c63304c82848caf90b859027bfb

2018/day01/part2: solve with Rust

view details

push time in 13 days

push eventscorphus/advent-of-code

Pablo Santiago Blum de Aguiar

commit sha 3a8cc9a15acec3d5f411542458ec8ed8d58de3b8

2019/day17: rename base script file

view details

Pablo Santiago Blum de Aguiar

commit sha 226803b61136946b41374f0d004750a494ab0cf5

2018: Yeah, let me learn some Rust! 🦀

view details

Pablo Santiago Blum de Aguiar

commit sha 320c3cc626eaa249af6e5acd3f934c0fdd124918

2018/day01/part1: solve with Rust

view details

push time in 14 days

push eventscorphus/sparring

Pablo Santiago Blum de Aguiar

commit sha 4dfa5ccaa3725b7cb403aeb530b533467a1eb34b

placeholder: more error handling in Rust

view details

Pablo Santiago Blum de Aguiar

commit sha fcc215baee1e681fad7704b46108730a0e6878e0

placeholder: more error handling in Rust

view details

push time in 15 days

push eventscorphus/sparring

Pablo Santiago Blum de Aguiar

commit sha 112606a75180e654ec40506a993c90c51819b7f5

placeholder: more error handling in Rust

view details

push time in 15 days

push eventscorphus/sparring

Pablo Santiago Blum de Aguiar

commit sha ebcc067c606e099d5a21856524a15554720f6f89

placeholder: error handling in Rust

view details

push time in 15 days

push eventscorphus/sparring

Pablo Santiago Blum de Aguiar

commit sha f622eb8069ea79a8268e1268f3c6724a26d9a6f5

placeholder: Rust's Drop trait 👌

view details

push time in 15 days

push eventscorphus/sparring

Pablo Santiago Blum de Aguiar

commit sha c98ae5eb88fd2b97ce9419b5fa734ad355c8eff7

placeholder: borrowing in Rust, again

view details

Pablo Santiago Blum de Aguiar

commit sha 7223f20ba6deca3d3157ade972017f2bac62d863

placeholder: borrowing in Rust, yet again

view details

Pablo Santiago Blum de Aguiar

commit sha 2cea9526aeb786ae5c0f06e981fa8667934e7e9f

placeholder: rustfmt issue 4355

view details

push time in 15 days

push eventscorphus/sparring

Pablo Santiago Blum de Aguiar

commit sha 64537048ff9d133cf49d9c616e9884e9a3ef338c

placeholder: rustfmt issue 4355

view details

push time in 15 days

push eventscorphus/sparring

Pablo Santiago Blum de Aguiar

commit sha b07e5795f0a936419d274f91be494d193a1ba7f8

ToDoApp: Add initial implementation

view details

Pablo Santiago Blum de Aguiar

commit sha 4c0645b652477f12359b691ab82c499a743796a5

ToDoApp: Turn into a mix project with GenServer

view details

Pablo Santiago Blum de Aguiar

commit sha 7825e0197e5092e4a50a90270b7379adcc4f0e80

placeholder: ownership in Rust

view details

Pablo Santiago Blum de Aguiar

commit sha 5cdeb0e7611f6fa84b13708ebffab98df7a350d5

placeholder: ownership in Rust, again

view details

Pablo Santiago Blum de Aguiar

commit sha 8b2356f96dec12fb5d221f7bef791a235e44e6b4

placeholder: borrowing in Rust

view details

Pablo Santiago Blum de Aguiar

commit sha c183f3f386bd4a097a4c5cca6ad89a88d29d6a54

placeholder: borrowing in Rust, again

view details

Pablo Santiago Blum de Aguiar

commit sha 53169b8229496f89a06347b9fea2db713f433415

placeholder: borrowing in Rust, yet again

view details

push time in 15 days

startedelixir-lang/elixir

started time in 15 days

startednedbat/song-basket

started time in 16 days

push eventscorphus/divykj

Divy Jain

commit sha 2a6579ab015a04a71f980168b148d78683d42701

🎨

view details

Divy Jain

commit sha 547a8f920d176127efdf1f3fbb6a502d5a8488d1

🚑

view details

Divy Jain

commit sha b4f4818a61e6302fef0fc017717cf5da91051ca2

📝

view details

Divy Jain

commit sha 6016b954755508b18a9b814f1f9dc1a4677c67b6

🙃

view details

Pablo Santiago Blum de Aguiar

commit sha efbd4f5e8fedc07406a9087b4408f6bf330e797c

💬

view details

Pablo Santiago Blum de Aguiar

commit sha 0f80272f1d0f4b3a39723371fe70ff5b9c0f1b7a

◻️

view details

push time in 22 days

delete branch scorphus/divykj

delete branch : patch-1

delete time in 22 days

PR opened divykj/divykj

◻️

Remove space from inside those links =)

+48 -48

0 comment

1 changed file

pr created time in 22 days

create barnchscorphus/divykj

branch : patch-1

created branch time in 22 days

delete branch scorphus/divykj

delete branch : patch-1

delete time in 22 days

push eventscorphus/divykj

Divy Jain

commit sha 2a6579ab015a04a71f980168b148d78683d42701

🎨

view details

Divy Jain

commit sha 547a8f920d176127efdf1f3fbb6a502d5a8488d1

🚑

view details

Divy Jain

commit sha b4f4818a61e6302fef0fc017717cf5da91051ca2

📝

view details

Divy Jain

commit sha 6016b954755508b18a9b814f1f9dc1a4677c67b6

🙃

view details

Pablo Santiago Blum de Aguiar

commit sha 3eb30ccfa7a933718da51fc22f9567fc1437406f

💬

view details

push time in 22 days

PR opened divykj/divykj

Add tooltips to tech stack icons
+16 -16

0 comment

1 changed file

pr created time in 22 days

push eventscorphus/divykj

Pablo Aguiar

commit sha 311044f889db63cfd4018d5889ec83a722c2da0f

Add tooltips to tech stack icons

view details

push time in 22 days

push eventmfinancecombr/wallet-api

Pablo Santiago Blum de Aguiar

commit sha 7d63390e073612cf322d080fcb70571d82df72d1

Create `datadir` before attempting to run MongoDB

view details

push time in 25 days

Pull request review commentmfinancecombr/wallet-api

More tooling

+setup:+	@rustup component add rustfmt+	@rustup component add clippy+	@type -p pre-commit >/dev/null 2>&1 || \+		(echo "Please install pre-commit and try again"; exit 1)+	@pre-commit install -f --hook-type pre-commit+	@pre-commit install -f --hook-type pre-push++mongo:+	@docker run --name wallet-api-mongo --rm -p 27017:27017 \

Aí complica. Vou mandar na master direto..

scorphus

comment created time in 25 days

PullRequestReviewEvent

Pull request review commentmfinancecombr/wallet-api

More tooling

+setup:+	@rustup component add rustfmt+	@rustup component add clippy+	@type -p pre-commit >/dev/null 2>&1 || \+		(echo "Please install pre-commit and try again"; exit 1)+	@pre-commit install -f --hook-type pre-commit+	@pre-commit install -f --hook-type pre-push++mongo:+	@docker run --name wallet-api-mongo --rm -p 27017:27017 \

Yeah, I thought of that too. Dunno why I didn't mention it. But, the PR is already merged 😆

scorphus

comment created time in 25 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentmfinancecombr/wallet-api

More tooling

+setup:+	@rustup component add rustfmt+	@rustup component add clippy+	@type -p pre-commit >/dev/null 2>&1 || \+		(echo "Please install pre-commit and try again"; exit 1)+	@pre-commit install -f --hook-type pre-commit+	@pre-commit install -f --hook-type pre-push++mongo:+	@docker run --name wallet-api-mongo --rm -p 27017:27017 \

/nudge @marcelometal @kov

scorphus

comment created time in 25 days

PullRequestReviewEvent

Pull request review commentmfinancecombr/wallet-api

More tooling

+setup:+	@rustup component add rustfmt+	@rustup component add clippy+	@type -p pre-commit >/dev/null 2>&1 || \+		(echo "Please install pre-commit and try again"; exit 1)+	@pre-commit install -f --hook-type pre-commit+	@pre-commit install -f --hook-type pre-push++mongo:+	@docker run --name wallet-api-mongo --rm -p 27017:27017 \

Good that you mention that line, as I totally forgot to comment that this command fails when there's no datadir directory:

docker: Error response from daemon: invalid mount config for type "bind": bind source path does not exist: /.../wallet-api/datadir.

So, what would you guys prefer?

  1. Having a datadir with a .gitignore inside — and nothing else in case you run mongo locally
  2. Manually creating it after make mongo fails with that message
scorphus

comment created time in a month

PullRequestReviewEvent

push eventmfinancecombr/wallet-api

Pablo Santiago Blum de Aguiar

commit sha f20d47b550cbae72aa5a89309fd87e8fce7652de

Use EditorConfig for a consistent coding style across IDEs

view details

Pablo Santiago Blum de Aguiar

commit sha 4b1d1f8dee7a00b673539a1b78800f81c32ff853

Add a Makefile with some initial targets

view details

Pablo Santiago Blum de Aguiar

commit sha c07d40d9973ad70476d3b7669a9fc9800d08eef7

Add a setup target to Makefile with pre-commit hooks

view details

push time in a month

push eventmfinancecombr/wallet-api

Gustavo Noronha Silva

commit sha be5cccacbe934ddba05df0b70f800adc4734c249

Address clippy suggestions I mostly made these mistakes: - being too eager to call .clone() - using *_or() rather than *_or_else() for defaults from function calls which then end up getting called on all cases - using closures on .map() to call a single function on the value, or to just return the value (doh); in my defense the latter were bad copy/pastes

view details

Pablo Santiago Blum de Aguiar

commit sha 3198fa05c8f38d3dd42771c64281bf8840065ee0

Use EditorConfig for a consistent coding style across IDEs

view details

Pablo Santiago Blum de Aguiar

commit sha 42bc9f0220a69df530342adfe72704572bd32041

Add a Makefile with some initial targets

view details

Pablo Santiago Blum de Aguiar

commit sha aa3264b38c78a65c5ddc963677f3f2888b4bfdb9

Add a setup target to Makefile with pre-commit hooks

view details

push time in a month

PR opened mfinancecombr/wallet-api

More tooling
+115 -39

0 comment

16 changed files

pr created time in a month

create barnchmfinancecombr/wallet-api

branch : more-tooling

created branch time in a month

PullRequestReviewEvent

Pull request review commentmfinancecombr/wallet-api

Address clippy suggestions

+#![warn(clippy::all)]

Fair enough 👍 That simply works.

You know.. it seldom feels right to have these "breadcrumbs" of tooling scattered around the code. I did find a couple ways to configure vscode but alas, they're kinda clumsy.

kov

comment created time in a month

PullRequestReviewEvent

Pull request review commentmfinancecombr/wallet-api

Address clippy suggestions

+#![warn(clippy::all)]

I think this attribute is redundant. As per the docs state:

  • clippy::all (everything that is on by default: all the categories below except for nursery, pedantic, and cargo)
kov

comment created time in a month

more