profile
viewpoint
Daiki Ihara sasurau4 @CureApp https://sasurau4.github.io/profile/ Frontend Engineer / Vimmer

startedEugeny/terminus

started time in 8 hours

startedmtoukei/statbox2

started time in 17 hours

delete branch phenyl-js/phenyl

delete branch : feature/fix-redux-middleware-type

delete time in 2 days

push eventphenyl-js/phenyl

yamatatsu

commit sha 79c9ca9a183078c10d56d2a6085d115d6ce9ff95

Fix: redux middleware type

view details

Daiki Ihara

commit sha b9e116be4b52c136f755c455c00bd93c73cba9e3

Fix: redux middleware type (#253) Fix: redux middleware type

view details

push time in 2 days

PR merged phenyl-js/phenyl

Fix: redux middleware type

Three type paramaters are required by redux Middleware type. https://github.com/reduxjs/redux/blob/master/index.d.ts#L361-L365

+1 -1

0 comment

1 changed file

yamatatsu

pr closed time in 2 days

startedawslabs/smithy

started time in 2 days

push eventsasurau4/phenyl

Daiki Ihara

commit sha f2d1ca6f67650f9ffa1ae2a8a959378b5b2819a8

change tsconfig of central-state

view details

push time in 2 days

PR opened phenyl-js/phenyl

[WIP] Separate build type

Overview

fix #244

+16 -7

0 comment

4 changed files

pr created time in 2 days

create barnchsasurau4/phenyl

branch : feature/separate-build-type

created branch time in 2 days

starteddlang/dmd

started time in 3 days

startedKudo/react-native-v8

started time in 5 days

startedawslabs/aws-cdk

started time in 6 days

startedlibra/libra

started time in 6 days

pull request commentdenoland/deno

[WIP][Test] reenable shutdown tests for net_test

@NamPNQ Thanks for your advice! I'll try them on this weekend!

sasurau4

comment created time in 6 days

startedvlang/v

started time in 7 days

startedtree-sitter/tree-sitter

started time in 7 days

push eventsasurau4/phenyl

Daiki Ihara

commit sha 792197f25c54bb7e6cd6174c8a37ed250e861df8

add test for memory-db

view details

Daiki Ihara

commit sha 3dec0f5ac7581d1a6deee537e71ad55c3d764fe2

add filter implementation for memory-db-client respect to mongodb

view details

Shin Suzuki

commit sha 8b6253644ca53e18a9b4e9e4736b2b7b12aa0623

Merge pull request #248 from sasurau4/feature/memorydb Feature/memorydb

view details

push time in 8 days

push eventsasurau4/node

Beni von Cheni

commit sha ed5e69d7e6eaf5e887ff48aa3fe941d394c44846

console: use consolePropAttributes for k-bind properties in constructor PR-URL: https://github.com/nodejs/node/pull/26850 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Daniel Bevenius

commit sha a8eac78f8dbe778a2aef69d0989416e47c6c403e

Revert "console: use consolePropAttributes for k-bind properties in constructor" This reverts commit ed5e69d7e6eaf5e887ff48aa3fe941d394c44846. PR-URL: https://github.com/nodejs/node/pull/26943 Refs: https://github.com/nodejs/node/pull/26850#issuecomment-477089697 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

view details

Joyee Cheung

commit sha 51970537ee06f824160fcd035b018117ce264345

src: move AsyncHooks out of Environment PR-URL: https://github.com/nodejs/node/pull/26824 Refs: https://github.com/nodejs/node/issues/26776 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Joyee Cheung

commit sha cc7bb855a78a11d1e7fb3eed78ba0b9458da0841

src: move AsyncCallbackScope out of Environment PR-URL: https://github.com/nodejs/node/pull/26824 Refs: https://github.com/nodejs/node/issues/26776 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Joyee Cheung

commit sha 4565698227c2644cc59bcdb705c4f4c92667d0d7

src: move ImmediateInfo out of Environment PR-URL: https://github.com/nodejs/node/pull/26824 Refs: https://github.com/nodejs/node/issues/26776 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Joyee Cheung

commit sha 242466167d6379791858ce59ca11d823c2eb4469

src: move TickInfo out of Environment PR-URL: https://github.com/nodejs/node/pull/26824 Refs: https://github.com/nodejs/node/issues/26776 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Joyee Cheung

commit sha 9f37d3c114b2c4233e58bdce8d82a06cac467738

src: move TrackingTraceStateObserver out of Environment PR-URL: https://github.com/nodejs/node/pull/26824 Refs: https://github.com/nodejs/node/issues/26776 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Joyee Cheung

commit sha 9d854fb60cd4a7386a23add2900fa224dcb1e2d5

src: move ShouldNotAbortOnUncaughtScope out of Environment PR-URL: https://github.com/nodejs/node/pull/26824 Refs: https://github.com/nodejs/node/issues/26776 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Ruben Bridgewater

commit sha 50a3fe20ead5fe9a77f2acd828f52754aa621406

lib: rename validateMode to parseMode The function did not only validate the mode but it returns a new value depending on the input. Thus `validate` did not seem to be an appropriate name. PR-URL: https://github.com/nodejs/node/pull/26809 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Ruben Bridgewater

commit sha 6c913fb0287fa7f823fcd0fbe7035bac3c4f75ec

lib: remove return values from validation functions This makes sure the validation functions do not cause any side effects. Validation functions should ideally only validate the input without any other effect. Since the input value must be known from the callee, there is no reason to return the input value. PR-URL: https://github.com/nodejs/node/pull/26809 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Ruben Bridgewater

commit sha 9e8c9be3ff07845320c350fa3b2097cfbdada85e

timers: rename validateTimerDuration to getTimerDuration The function did not only validate the timer but it caused side effects like a warning and potentially returned a different value than the input value. Thus the name `validate` did not seem to be appropriate. PR-URL: https://github.com/nodejs/node/pull/26809 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Ruben Bridgewater

commit sha 28e2c3771d3da014c35b57cc55f7808627e43f2d

child_process: rename _validateStdtio to getValidStdio The name indicated only validation while it did much more and it returned a different value to the callee function. The underscore was also not necessary as the function is internal one way or the other. PR-URL: https://github.com/nodejs/node/pull/26809 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Ruben Bridgewater

commit sha ce265908eb84aa0518dcadc57d59e7fbb353a256

http2: remove side effects from validateSettings The function did not only validate the input so far but it also made a copy of the input object and returned that copy to the callee function. That copy was not necessary for all call sites and it was not obvious that the function did not only validate the input but that it also returned a copy of it. This makes sure the function does nothing more than validation and copying is happening in the callee function when required. PR-URL: https://github.com/nodejs/node/pull/26809 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Ruben Bridgewater

commit sha bbfa93af3d1577fbf96622c9100c07d45ff8998a

url: refactor validateHostname This function did not only validate the input but it returned a new value in case the hostname was valid. This simplifies the function by always returning the required value, no matter if it is valid or invalid, so the callee site does not have to check that anymore. On top the function is renamed to `getHostname` to make clear that the function does not only validate the input but it also returns a new value. PR-URL: https://github.com/nodejs/node/pull/26809 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Ruben Bridgewater

commit sha 92db780d9e39cd25b63c031095cf0072ed2aec55

http2: rename function for clarity The function does not only validate the input but it causes side effects by adding default options to the input object in case the option is not set. PR-URL: https://github.com/nodejs/node/pull/26809 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Ruben Bridgewater

commit sha 751c92d9728da6f6f86e443783a61253791cfc2f

crypto: remove obsolete encoding check This renames the parameters for clarity and removes the check for undefined encoding. That will always default to `utf8`. PR-URL: https://github.com/nodejs/node/pull/26809 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Ruben Bridgewater

commit sha 7bddfcc61a5a7d04583a8c4fec462ca5ce45b677

lib: consolidate arrayBufferView validation There are lots of places that validate for arrayBufferView and we have multiple functions that do the same thing. Instead, move the validation into `internal/validators` so all files can use that instead. There are more functions throughout the code that do the same but it takes some more work to fully consolidate all of those. PR-URL: https://github.com/nodejs/node/pull/26809 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Ruben Bridgewater

commit sha 115f0f5a57f50f6b039f28a56910207f92df116d

module: throw an error for invalid package.json main entries We currently ignore invalid `main` entries in package.json files. This does not seem to be very user friendly as it's certainly an error if the `main` entry is not a valid file name. So instead of trying to resolve the file otherwise, throw an error immediately to improve the user experience. To keep it backwards compatible `index.js` files in the same directory as the `package.json` will continue to be resolved instead but that behavior is now deprecated. PR-URL: https://github.com/nodejs/node/pull/26823 Fixes: https://github.com/nodejs/node/issues/26588 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

Ruben Bridgewater

commit sha fd992e6e36bb4b01a6ceb71cfeb3bae640b492a6

doc: mark settings as optional and add callback The settings are currently not required and the callback was not documented so far. Refs: https://github.com/nodejs/node/pull/26811 PR-URL: https://github.com/nodejs/node/pull/26894 Refs: https://github.com/nodejs/node/pull/26811 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Ruben Bridgewater

commit sha b08a867d6016ccf04783a0f91fdbcc3460daf234

benchmark,doc,lib: capitalize more comments PR-URL: https://github.com/nodejs/node/pull/26849 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>

view details

push time in 8 days

push eventsasurau4/deno

Daiki Ihara

commit sha d583fe9ca93d4cd7e1dab782b457bd253dba2a76

[WIP] change port for net_test

view details

push time in 10 days

push eventsasurau4/deno

Daiki Ihara

commit sha d9f8f9f5e01fe1222d2cbc4246e243ee22856f86

[WIP] turn off net_test on Windows

view details

push time in 10 days

push eventsasurau4/deno

Daiki Ihara

commit sha 64bf1e9b0cee82b635804064cd2460659304869a

[WIP] Change windows port for net_test

view details

push time in 10 days

PR opened phenyl-js/phenyl

Reviewers
Feature/memorydb

Overview

Implement transaction for memory-db. reference: https://github.com/phenyl-js/phenyl/pull/246

But memory-db's operations are always synchronized not async operation. So, conflict and rollback never happened. I remove these tests from mongo-db ones.

+147 -3

0 comment

2 changed files

pr created time in 12 days

create barnchsasurau4/phenyl

branch : feature/memorydb

created branch time in 12 days

push eventsasurau4/phenyl

Daiki Ihara

commit sha 12dcd97e97463d653da5f4e372c416c14873a655

add type to test file

view details

Daiki Ihara

commit sha a8e5979d7f0b2104d0f5bdfe9b93401d02e6a19b

add test for issue #226

view details

Shin Suzuki

commit sha 7a798414d9bf7777ce55fe130e548817f5b11852

feat(central-state): Add memory-level transaction logic

view details

Shin Suzuki

commit sha 92bb38e48bb7d54a2117ad36a4e522aeebc912c1

feat(memory-db): Add `overwrite()` and modify interface of `updateById()`

view details

Shin Suzuki

commit sha b1c3cd8064b96446fc38ed6a0b32bab154dabc48

feat(mongodb): Add method: `updateById()`

view details

Shin Suzuki

commit sha d90143444375e352d93788f7f9fb53998943d96e

feat(mongodb): Implement overwrite()

view details

Shin Suzuki

commit sha e5dde3b4310d88b092c171ac8bd28150c468fdd8

feat(interface): overwrite => replaceOne

view details

Daiki Ihara

commit sha 59f6516b6189d80d0a194ec03d777f56d0baec2e

pass build

view details

Daiki Ihara

commit sha 8f1a71f48c7e81a22d6b4ca57a8b62a37cb92967

fix central-state check locked logic

view details

Daiki Ihara

commit sha b0dfb081923655107e3dc05b9dc77a59a2519304

add test case for mongodb merge operations

view details

Daiki Ihara

commit sha 0bba7cb521fc200d70af06dcc22a09755218031e

implement lock system

view details

Daiki Ihara

commit sha c8e3722b1e713be08bd8ea8391f4cdc6f049c39b

add test for merge-op

view details

Daiki Ihara

commit sha d863df206d245d4a389e3ccfd477a67c14746f3a

upgrade CI images

view details

Daiki Ihara

commit sha a28ccc64df5cb8b61e2af0e8383ecce74cc49c6e

upgrade @type/node v10

view details

Jesse Katsumata

commit sha a6b849c9e5323025b37342e75b97c97b40b33303

Merge pull request #247 from sasurau4/feature/upgrade-node Feature/upgrade node

view details

Daiki Ihara

commit sha d148bc311122000d3b2237aae62433125fde8ef4

Merge branch 'master' of github.com:phenyl-js/phenyl into transaction

view details

Daiki Ihara

commit sha 2ac48489758fa79897de9a7c39999ca1cd3e5ca5

add test for locked entity

view details

Daiki Ihara

commit sha f8b43f7fdbf2d3c122361d721f9cfd5bdaf38269

up count of operation

view details

Daiki Ihara

commit sha 5d548632a1e6d1ae46c49b19bdfed0629a158df7

use forEach instead of for of loop

view details

Daiki Ihara

commit sha 8baf95607207faa9be05927e177bb8e2ede4922b

use for loop instead of forEach

view details

push time in 12 days

startedreg-viz/node-xcb

started time in 12 days

push eventsasurau4/deno

Daiki Ihara

commit sha bb2dec3a7c8a0cb11caafb5b37daebd614c799fe

use DenoError when read throw error

view details

Daiki Ihara

commit sha 81395ebdd01ae7f129286be35b49570fe84c3a16

use DenoError instead of default Error

view details

Daiki Ihara

commit sha d462face8fd11a9c571723ba62ff8b5e5f234144

[WIP] CI test for Windows

view details

push time in 12 days

push eventsasurau4/deno

Bartek Iwańczuk

commit sha a115340288d974f141cceb16faac71914402c445

feat: Import maps (#2360)

view details

迷渡

commit sha 5871d22d9b1f99a4735ff7b4e2dcca977795aa74

check `URLSearchParams.constructor`'s params (#2488)

view details

Neil Richter

commit sha 163d60bf16b2c62192b5bf1763ebe6ee2b8c4406

typo (#2489)

view details

Yoshiya Hinosawa

commit sha 88b0c8756eef96c8adaff1005d00aae52bd2272c

website: use pre-wrap (#2486)

view details

Ryan Dahl

commit sha e0436975211202afadb1a8ccd7d5154694162f38

Expose dynamic import in core (#2472)

view details

Ryan Dahl

commit sha 523ab6a929dacf4cdd692c1319173a1a49c642de

Upgrade V8 to 7.7.37 (#2492)

view details

迷渡

commit sha 0efb7c2ab7b9705a9f5f177b4dc170c1abbd97ed

fix bug in URL (#2495)

view details

justjavac

commit sha cb581620522febe618cbf084b0dc3428479e84a9

set setTimeout callback's this to window object

view details

Matt Harrison

commit sha d82c1991cf0919c312b87501bc588cf17781b32f

Add --seed for setting RNG seed (#2483)

view details

Ryan Dahl

commit sha 508e9849ffd1491b8f3ac9aaaad507e84f57fed3

Move TestFmt to end of tests (#2491)

view details

Ryan Dahl

commit sha de8c85f8f2f4631cc4e7cba2616df94fd2c37160

Move Modules to ThreadSafeState (#2498)

view details

Ryan Dahl

commit sha 912e4f717785e2f5266d749c54a289227523db12

feat: default output filename for deno bundle (#2484) And improve bundle docs

view details

Gurwinder S

commit sha 7fc3d5ed8bef7373b96e4436dee8c68bec383184

Removed unused method and update docs (#2499)

view details

Bert Belder

commit sha 878d092df9cc89ad92e571e2422ffb1ed488dd0e

Revert "Work around Windows-only V8 concurrent initialization crash" This fix is no longer necessary as the underlying V8 bug has been fixed upstream. This reverts commit 48bcfce09e11901244447617be2eb7789427eab0.

view details

Kurt Mackey

commit sha 7bdeee8997bde0efe40bcec41c0706bdab58893b

makes global request type an interface (#2503)

view details

Ryan Dahl

commit sha 8693d0e0a7d7ce1e4533aef30c1a735276e3009b

Split up tools/sync_third_party This is just encoding my actual workflow; not suggesting that this workflow is ideal. Previously I would edit sync_third_party.py each time I ran it.

view details

Ryan Dahl

commit sha 2a5138a5166f0945d5fda68c89fa8e23c66fb681

Remove Config struct from core (#2502) It's unnecessary indirection and is preventing the ability to easily pass isolate references into the dispatch and dyn_import closures. Note: this changes how StartupData::Script is executed. It's no longer done during Isolate::new() but rather lazily on first poll or execution.

view details

Bartek Iwańczuk

commit sha b3c4307d02d627287cd28486b208b53c3bd378f0

Refactor module resolving (#2493) Adds ModuleSpecifier, which wraps a URL. This is now passed around instead of specifier and resolver strings.

view details

Bartek Iwańczuk

commit sha bca5cc5041172e22ad1851c8510d6521bf70ec22

Move ModuleSpecifier to //core (#2509)

view details

迷渡

commit sha 42d1024cd98811a4ce9eaaa73c84970d271628a6

forbidden to set `this` for setTimeout (#2511)

view details

push time in 12 days

create barnchsasurau4/deno

branch : feature/enable-reuse-addr

created branch time in 12 days

push eventsasurau4/deno

Daiki Ihara

commit sha af2bb23c716f7bbed441d1fe39b1e02dc7ba84f1

[WIP] test for Windows CI

view details

Daiki Ihara

commit sha 92dc4fc60dcb96ca5a4c2600152f0f4f3861ece0

Merge branch 'feature/enable-net-test' of github.com:sasurau4/deno into feature/enable-net-test

view details

push time in 12 days

startedmicrosoft/vscode

started time in 13 days

startedtc39/proposal-pipeline-operator

started time in 13 days

startedremojansen/logo.ts

started time in 13 days

issue commentgodaddy/svgs

svgs component cannot receive the style created by StyleSheet in web

Thanks for your response and sharing the proposals and discussions issue.👍

I read the issue, FB commented:

Comment by Facebook: This issue assumes that styles with React Native are not performant, which is not the case so there is nothing to be done to optimize them at this time. There may be an opportunity for us to improve our documentation to make sure people do not assume that the StyleSheet API is slow. We will not be adding a new API for defining styles at this time but that shouldn't stop you from exploring alternative solutions and building your own React Native styling libraries.

According from the comment, it has benefit for using StyleSheet API even though the performance section removed from the StyleSheet docs. I don't know why the section removed 🤔 and the future of StyleSheet API. So, I continue watching react-native repo and its community.

I understood the stance to the issue and priority for you. I'll look for a workaround or use passing regular object partially about svgs components instead of StyleSheet API.

If the issue is bothered you, please close the issue.

sasurau4

comment created time in 13 days

push eventsasurau4/dotfiles

Daiki Ihara

commit sha dd8db7e8cc8a043d70ac82d2b8d5cbd6c9d05cdb

remove cargor from fixer

view details

push time in 14 days

issue openedgodaddy/svgs

svgs component cannot receive the style created by StyleSheet in web

Overview

svgs's component can't receive style created by StyleSheet.create() in web.

Details

I'm developing an application with react-native and react-native-web. react-native-web is porting react-native's implementation as much as possible. So, StyleSheet.create() return object style key and id like following.

import { StyleSheet } from "react-native";

const styles = StyleSheet.create({
  container: {
    flex: 1
  }
});

console.log(styles.container) // -> 73 (style id)

react-native-web resolve all styles in it's components. https://github.com/necolas/react-native-web/blob/9872c9716973870ab3cc129215a17fc6cbb1b112/packages/react-native-web/src/exports/StyleSheet/ReactNativeStyleResolver.js

Actual Behavior

Throws Error of following and nothing to render.

Uncaught Invariant Violation: The `style` prop expects a mapping from style properties to values, not a string. For example, style={{marginRight: spacing + 'em'}} when using JSX.

Expected Behavior

Correctly svg rendered.

Reproduction repository

https://github.com/sasurau4/sample-rnweb/tree/repro/svgs-issue

I think this is edge case. But if this issue fixed, svgs fully compatible to the react-native-svg.

Thanks in advance.

created time in 14 days

create barnchsasurau4/sample-rnweb

branch : repro/svgs-issue

created branch time in 14 days

push eventsasurau4/sample-rnweb

Daiki Ihara

commit sha 41dccfcfd1bb20add2b0b207c5d621a1d73fbc2c

add README

view details

push time in 14 days

starteddaybrush/scenejs

started time in 14 days

create barnchsasurau4/sample-rnweb

branch : master

created branch time in 15 days

created repositorysasurau4/sample-rnweb

created time in 15 days

startedgithub/semantic

started time in 15 days

push eventsasurau4/deno

Daiki Ihara

commit sha f61dbe3a9e40519641dd49ac02ae893896c926ef

[WIP] enable log-debug option for CI debug

view details

push time in 16 days

push eventsasurau4/phenyl

Daiki Ihara

commit sha 8baf95607207faa9be05927e177bb8e2ede4922b

use for loop instead of forEach

view details

push time in 16 days

push eventsasurau4/phenyl

Daiki Ihara

commit sha 5d548632a1e6d1ae46c49b19bdfed0629a158df7

use forEach instead of for of loop

view details

push time in 16 days

pull request commentdenoland/deno

[WIP][Test] reenable shutdown tests for net_test

📝 At https://github.com/denoland/deno/pull/2410/commits/4719f576b912ddbd603a7cc58aa056b4a27eef94, the net test failed at netCloseReadSuccess by BrokenPipe: read error and others by AddrInUse: Only one usage of each socket address (protocol/network address/port) is normally permitted. (os error 10048).

At https://github.com/denoland/deno/pull/2410/commits/e5a1438ce1d0b30239267316e5e42eaf736b5554, the net test failed at netCloseReadSuccess by BrokenPipe.

So, the difference of 4719f57 and e5a1438 is enable reuse_address.

I couldn't find why the test failed by BrokenPipe: read error. 🤔

sasurau4

comment created time in 16 days

push eventsasurau4/deno

Daiki Ihara

commit sha 81a5ad2cf3cb6da1991205cc8fcc336d1d1c9ea0

remove unnecessary console.log

view details

Daiki Ihara

commit sha 4719f576b912ddbd603a7cc58aa056b4a27eef94

[WIP]

view details

push time in 16 days

push eventsasurau4/phenyl

Daiki Ihara

commit sha f8b43f7fdbf2d3c122361d721f9cfd5bdaf38269

up count of operation

view details

push time in 16 days

push eventsasurau4/phenyl

Daiki Ihara

commit sha d863df206d245d4a389e3ccfd477a67c14746f3a

upgrade CI images

view details

Daiki Ihara

commit sha a28ccc64df5cb8b61e2af0e8383ecce74cc49c6e

upgrade @type/node v10

view details

Jesse Katsumata

commit sha a6b849c9e5323025b37342e75b97c97b40b33303

Merge pull request #247 from sasurau4/feature/upgrade-node Feature/upgrade node

view details

Daiki Ihara

commit sha d148bc311122000d3b2237aae62433125fde8ef4

Merge branch 'master' of github.com:phenyl-js/phenyl into transaction

view details

Daiki Ihara

commit sha 2ac48489758fa79897de9a7c39999ca1cd3e5ca5

add test for locked entity

view details

push time in 16 days

delete branch sasurau4/phenyl

delete branch : feature/upgrade-node

delete time in 16 days

PR opened phenyl-js/phenyl

Reviewers
Feature/upgrade node

Overview

upgrade CI images and runtime node to v10

+6 -6

0 comment

4 changed files

pr created time in 16 days

create barnchsasurau4/phenyl

branch : feature/upgrade-node

created branch time in 16 days

push eventsasurau4/phenyl

Daiki Ihara

commit sha 2a68e1ce0af5d08438459604d0a1d50e5e07e675

replace direct import from src to package in test file

view details

Daiki Ihara

commit sha 4cd84c41d8432145565ae87e6b8e1b46ef7c7c1c

replace import other package src to node_modules

view details

Jesse Katsumata

commit sha c883d0a904aa2275c0a1e2e72076404233ad7c32

Merge pull request #241 from sasurau4/fix/issue-237 replace direct import from src to package in test file

view details

Daiki Ihara

commit sha d5b9befd3387ee0d745f26ff6b87d98883e12ac2

add script to publish patch or minor release from ci

view details

Daiki Ihara

commit sha 7a0a8f6df30d8535d50178442f50ff6b1bfa6ee5

add skipping ci when releasing

view details

Shin Suzuki

commit sha eea8c5d3f55a2a7b0a2e1b92f025d3b7c0b86c71

Add contributors

view details

Daiki Ihara

commit sha 20a15b7ddf05300dd429839c0927473dd14330f6

use phenyl-bot when releasing

view details

Daiki Ihara

commit sha 59c152a5b7f67448ddd0521a17dc71f43baec157

Merge pull request #243 from phenyl-js/add-contributors Add contributors

view details

Shin Suzuki

commit sha a4bfc5a62ec6e030ba1876fc3c06bda577bccfc1

Merge pull request #242 from sasurau4/feature/publish-by-ci add script to publish patch or minor release from ci

view details

push time in 16 days

PR closed phenyl-js/phenyl

[WIP] Transaction support at Push command
+254 -25

1 comment

10 changed files

shinout

pr closed time in 16 days

pull request commentphenyl-js/phenyl

[WIP] Transaction support at Push command

move #246

shinout

comment created time in 16 days

PR opened phenyl-js/phenyl

Reviewers
Transaction

Overview

fix #226

TODO

some tests are implemented after upgrading Node v10

+457 -40

0 comment

14 changed files

pr created time in 16 days

create barnchsasurau4/phenyl

branch : transaction

created branch time in 16 days

push eventsasurau4/deno

Daiki Ihara

commit sha e5a1438ce1d0b30239267316e5e42eaf736b5554

use 1024 to backlog

view details

push time in 16 days

push eventsasurau4/deno

Daiki Ihara

commit sha b00e8454d9814b80cf769cfbc076f4de71ef8d06

bind std_tcp_stream before connect on Windows

view details

push time in 16 days

push eventsasurau4/deno

Daiki Ihara

commit sha 2902acf96f35b76ef2f9c4001ff07b3d72c607ac

bind std_tcp_stream before connect on Windows

view details

push time in 16 days

push eventsasurau4/deno

Daiki Ihara

commit sha 0464013414dd10707f7ba0674561c8ea5b863103

remove unnecessary return statement

view details

push time in 16 days

push eventsasurau4/deno

Daiki Ihara

commit sha ba7e2a84530e94494256c85fe85ecf05da1765fd

use connect_std in op_dial

view details

push time in 16 days

push eventsasurau4/dotfiles

Daiki Ihara

commit sha a347524fb047d3470540e26016f05250c7080b49

add ale_fixiers

view details

Daiki Ihara

commit sha f65d3e32abdafbeeec3690abd126b3b5742415be

update vim plugins

view details

push time in 17 days

push eventsasurau4/deno

Daiki Ihara

commit sha 62b4b452c01a62d05b09ac250def5299a474830f

add error handling to netCloseReadSuccess

view details

push time in 17 days

push eventsasurau4/deno

Daiki Ihara

commit sha 8ccbeecd14dfb065627284f404f1231809912ca0

use DenoError when read throw error

view details

Daiki Ihara

commit sha d86c2ad416d705ab703b03c0e39733dff467dd41

fix test of netCloseReadSuccess for windows

view details

push time in 17 days

push eventsasurau4/deno

Adam Conrad

commit sha 9fd4096235a308a0d405888ef808d6c665bef355

add EventTarget implementation (#2377)

view details

Bartek Iwańczuk

commit sha 824542e61e1dbef09ca9388deca0c595a3e3e1df

chore: Port Python tests to unittest (#2408)

view details

Ryan Dahl

commit sha 3c355c2b3296cb930c37de44634b479cd7230ed6

Add 'brew install deno' to homepage (#2412)

view details

Ryan Dahl

commit sha 53b6356ec5eac1c84610c2d2e75b527485c47f3c

Correct tokio_util::block_on() and op_fetch_module_meta_data op_fetch_module_meta_data is an op that is used by the TypeScript compiler. TypeScript requires this op to be sync. However the implementation of the op does things on the event loop (like fetching HTTP resources). In certain situations this can lead to deadlocks. The runtime's thread pool can be filled with ops waiting on the result of op_fetch_module_meta_data. The runtime has a maximum number of threads it can use (the number of logical CPUs on the system). This patch changes tokio_util::block_on to launch a new Tokio runtime for evaluating the future, thus bipassing the max-thread problem. This is only an issue in op_fetch_module_meta_data. Other synchronous ops are truly synchornous, not interacting with the event loop. TODO comments are added to direct future development.

view details

Ryan Dahl

commit sha 64d2b7bc90cf6fdba661d6d3fe243fe332c076ee

Change tools/fmt_test.py to always download prettier This is to ensure a more fair test. Also we were already downloading from the internet since we changed the URL to use std@v0.5.0. This change exposes an OOM bug, which is then fixed in the upcoming compiler refactor by changing checkJs compiler option to false.

view details

Ryan Dahl

commit sha 856c44213b7faf507d4b481cfc170b2fd08f971a

TS compiler refactor * Compiler no longer has its own Tokio runtime. Compiler handles one message and then exits. * Uses the simpler ts.CompilerHost interface instead of ts.LanguageServiceHost. * avoids recompiling the same module by introducing a hacky but simple `hashset<string>` that stores the module names that have been already compiled. * Removes the CompilerConfig op. * Removes a lot of the mocking stuff in compiler.ts like `this._ts`. It is not useful as we don't even have tests. * Turns off checkJs because it causes fmt_test to die with OOM.

view details

Ryan Dahl

commit sha 5265bd7cb1f86af99b01d73c537d52a50df95fe2

v0.7.0

view details

Axetroy

commit sha 4c80394f54bf68e8e961fbc6275cd536717bc7f6

bump std/prettier@0.5.0 to std/prettier@0.7.0 (#2425)

view details

Christian Moritz

commit sha 15dadf812c95c3dd2b93b1ba41ef488baeeac0c1

tools/third_party: add DENO_GN_PATH and DENO_NINJA_PATH env vars

view details

Christian Moritz

commit sha 0e780e894854cada1244aa3f465c226593187edc

tools/setup: don't download sccache if --no-binary-download is passed

view details

Bert Belder

commit sha 1540b36ce7a4740f4a87c564becca65ed8d97255

third_party: upgrade rust crates

view details

Andy Hayden

commit sha 8fb44eba5bb9862de5fcc6c785eb6f21ecbd0aea

chore: refactor python tests to use unittest (#2414) Move every test to a method on DenoTestCase. test.py is a single TestSuite of every TestCase. Add a Spawn context manager for http_server, this is explicitly used where it's needed. Each python test file can now be run independently without needing to manually run http_server. Add --help and consistent flags using argparse for each python test, including --failfast. Use ColorTextTestRunner so that '... ok' is green.

view details

Kurt Mackey

commit sha 652be19041246d762ac5a1fa0b7fcddecb1ffd5d

use body when Request instance is passed to fetch (fixes #2433) (#2435)

view details

Yoshiya Hinosawa

commit sha 79f770b178da2d74f10eaa5668b3c3521ab6bb59

fmt: add --stdout option (#2439)

view details

Kitson Kelly

commit sha d438a6d259f79d1dd98d50ada01debbe24ca5a29

Upgrade TypeScript to 3.5.1 (#2437)

view details

Gurwinder S

commit sha bbc8de0c7a6a086ea7b0b79c6f5b005f9f374a7d

Fix typo (#2443)

view details

Bartek Iwańczuk

commit sha 43c6c1a9f58a8d423a2d55092609e620f9765bcf

Refactor test infrastructure (#2432) * use subclass of unittest.TestCase for all test cases * allow to run single test file (eg. python tools/integration_tests.py) * test filtering (via --pattern/-p CLI flag) * use common CLI parser for all tests: usage: test.py [-h] [--failfast] [--verbose] [--executable EXECUTABLE] [--release] [--pattern PATTERN] [--build-dir BUILD_DIR] optional arguments: -h, --help show this help message and exit --failfast, -f Stop on first failure --verbose, -v Verbose output --executable EXECUTABLE Use external executable of Deno --release Test against release executable --pattern PATTERN, -p PATTERN Run tests that match provided pattern --build-dir BUILD_DIR Deno build directory * respect NO_COLOR variable

view details

Ryan Dahl

commit sha 60d452264198adb3da4820236cf8ea35d33486cd

Compiler exit before emit if preEmitDiagnostics found (#2441)

view details

Kitson Kelly

commit sha a71305b4febc3d8db95d3d144ae3a64c023718f0

Handle compiler diagnostics in Rust (#2445)

view details

Vincent LE GOFF

commit sha 0b50c698ad898cd8fbdd1dc21956d584887fd87a

Add special hit cfix #1898 (#2455)

view details

push time in 17 days

delete branch sasurau4/phenyl

delete branch : fix/issue-226

delete time in 19 days

PR closed phenyl-js/phenyl

Fix/issue 226

Overview

fix #226

  • [x] add test case
  • [ ] fix test case
+60 -2

1 comment

2 changed files

sasurau4

pr closed time in 19 days

pull request commentphenyl-js/phenyl

Fix/issue 226

move to #245

sasurau4

comment created time in 19 days

startedceejbot/economics-of-package-management

started time in 19 days

startedsyumai/go-playground-addons

started time in 19 days

startedentropic-dev/entropic

started time in 20 days

startedtc39/agendas

started time in 20 days

startedPolymer/lit-html

started time in 20 days

startedtc39/proposal-weakrefs

started time in 20 days

startedactix/actix-web

started time in 20 days

push eventsasurau4/slides

Daiki Ihara

commit sha 9badbe8693e482781459bb67b73c34bce0437364

add

view details

push time in 21 days

startedCraneStation/wasmtime

started time in 21 days

push eventsasurau4/slides

Daiki Ihara

commit sha 7db6ce165821f6d1ee00b441543aed46f286dac0

add

view details

push time in 21 days

push eventsasurau4/slides

Daiki Ihara

commit sha 12adc4724ddf91d65a626ddeb5cf85a0eb485928

modify meguroes

view details

push time in 22 days

create barnchsasurau4/slides

branch : master

created branch time in 23 days

created repositorysasurau4/slides

Slides

created time in 23 days

startedhiroppy/slides

started time in 23 days

startedmAAdhaTTah/babel-plugin-prismjs

started time in 23 days

startedcloudflare/binast-cf-worker

started time in 23 days

issue closedcloudflare/binast-cf-worker

Response header return normal content-type

Overview

I found the server returns js as application/javascript content-type, so I couldn't try binaryAST.

D3___React_Examples

closed time in 23 days

sasurau4

issue commentcloudflare/binast-cf-worker

Response header return normal content-type

@xtuc I confirmed fixing. Thanks for fixing. 👍

sasurau4

comment created time in 23 days

startednodejs/llhttp

started time in 23 days

startedGoogleChrome/lighthouse-stack-packs

started time in 23 days

startedcloudflare/wrangler

started time in 23 days

startedjasonwilliams/boa

started time in a month

startedsyumai/ojichat-web

started time in a month

delete branch phenyl-js/phenyl

delete branch : add-contributors

delete time in a month

push eventphenyl-js/phenyl

Shin Suzuki

commit sha eea8c5d3f55a2a7b0a2e1b92f025d3b7c0b86c71

Add contributors

view details

Daiki Ihara

commit sha 59c152a5b7f67448ddd0521a17dc71f43baec157

Merge pull request #243 from phenyl-js/add-contributors Add contributors

view details

push time in a month

PR merged phenyl-js/phenyl

Add contributors
+13 -0

0 comment

1 changed file

phenyl-bot

pr closed time in a month

push eventsasurau4/phenyl

Daiki Ihara

commit sha 7a0a8f6df30d8535d50178442f50ff6b1bfa6ee5

add skipping ci when releasing

view details

Daiki Ihara

commit sha 20a15b7ddf05300dd429839c0927473dd14330f6

use phenyl-bot when releasing

view details

push time in a month

PR opened phenyl-js/phenyl

add script to publish patch or minor release from ci

Overview

Publish from CI by approval

+53 -16

0 comment

2 changed files

pr created time in a month

create barnchsasurau4/phenyl

branch : feature/publish-by-ci

created branch time in a month

issue openedcloudflare/binast-cf-worker

Response header return normal content-type

Overview

I found the server returns js as application/javascript content-type, so I couldn't try binaryAST.

D3___React_Examples

created time in a month

issue openedcloudflare/binjs-demo

Response header return normal content-type

Overview

I found the server returns js as application/javascript content-type, so I couldn't try binaryAST.

D3___React_Examples

created time in a month

startedcloudflare/binjs-demo

started time in a month

more