profile
viewpoint
Sam Saccone samccone Google ∆∆∆

push eventsamccone/me

Sam Saccone

commit sha 9cc53c620d32186fea2d4415e71f0eafa91dd71a

fix typo

view details

push time in 10 days

push eventsamccone/me

Sam Saccone

commit sha 9e3c762560e132000065783395db123065f2300a

add webpack profile post

view details

push time in 10 days

startedbengl/pflames

started time in 10 days

pull request commentsamccone/moji-brush

fix url typo in saved image footer

:) old URL

paulirish

comment created time in 10 days

push eventsamccone/moji-brush

Paul Irish

commit sha 05b362579e4ee71311326531209304acb4779842

fix url typo in saved image footer

view details

Sam Saccone

commit sha a9f2ef76fd2cbef35213af1b5b1020365994ad67

Merge pull request #46 from paulirish/patch-1 fix url typo in saved image footer

view details

push time in 10 days

issue openedGoogleChrome/lighthouse

Unused javascipt audit title is misleading

Proposal: The Remove Unused Javascript title is misleading as it is auditing for unused javascript on page load.

I propose updating the title from Remove unused JavaScript to Defer unused onload JavaScript to remove any communication confusion around exactly what this audit is quantifying.

I am open to any bikeshedding of the term that communicates that this is measuring on load and not JS payload for the entire app functionality.

code: https://github.com/GoogleChrome/lighthouse/blob/7750fe465d818a5bfd191ce7d959d82a2052eb8c/lighthouse-core/audits/byte-efficiency/unused-javascript.js#L13

created time in a month

delete branch samccone/entropic

delete branch : remove_unused

delete time in a month

CommitCommentEvent

Pull request review commententropic-dev/entropic

Fix minor spelling typo

 const main = () => {    // Docker gives containers 10 seconds to handle SIGTERM   // before sending SIGKILL. Close all current connections-  // graceully and exit with 0.+  // gracefully and exit with 0.

Done.

samccone

comment created time in a month

push eventsamccone/entropic

Sam Saccone

commit sha dcf503a9382671e5a266d64d2f3503e1c6584e70

Fix minor spelling typo graceully => gracefully.

view details

push time in a month

PR opened entropic-dev/entropic

Fix minor spelling typo

graceully => gracefully.

+1 -1

0 comment

1 changed file

pr created time in a month

push eventsamccone/entropic

Sam Saccone

commit sha 18a891bf283b1835724fd2823507717778dc4dc1

Fix minor spelling typo graceully => gracefully.

view details

push time in a month

create barnchsamccone/entropic

branch : sjs/minor_typo

created branch time in a month

delete branch samccone/entropic

delete branch : lint-and-fail

delete time in a month

PR closed entropic-dev/entropic

Add lint and fail phase for root lint script.

This should prevent any lint failing code to pass in presubmit prior to the code being landed in source control.


Note: currently lint is not set to run during presubmit, however we can enable this! Doing this class of enable will be a large-scale-change by running prettier to reformat all code prior to enabling the lint to minimize code-churn for all contributors.

+2 -1

2 comments

1 changed file

samccone

pr closed time in a month

pull request commententropic-dev/entropic

Add lint and fail phase for root lint script.

Ah apologies! I missed your change! Closing mine in favor of yours.

samccone

comment created time in a month

push eventsamccone/entropic

Sam Saccone

commit sha 4671fdf9ec9365f0ac8b5a5e0c64a7841200db57

Remove unused pipeline import from vcpm-sync.

view details

push time in a month

create barnchsamccone/entropic

branch : remove_unused

created branch time in a month

PR opened entropic-dev/entropic

Add lint and fail phase for root lint script.

This should prevent any lint failing code to pass in presubmit prior to the code being landed in source control.

+2 -1

0 comment

1 changed file

pr created time in a month

create barnchsamccone/entropic

branch : lint-and-fail

created branch time in a month

fork samccone/entropic

🦝 :package: a package registry for anything, but mostly javascript 🦝 🦝 🦝

fork in a month

push eventsamccone/bundle-buddy

Sam Saccone

commit sha 15aa0454784c18eb27aa52274e40992b315fa986

remove old debug log

view details

push time in a month

push eventsamccone/bundle-buddy

Sam Saccone

commit sha 224035785289f0e9b32cc843c6cc7ab20244a063

always generate sourcemaps for fishfooding

view details

Sam Saccone

commit sha 35632918b74dffc7167fdc4488807d824a63b664

woot! make stats.json + explode work

view details

push time in a month

push eventsamccone/bundle-buddy

Sam Saccone

commit sha f10552ba97ed3aeb393d81a6347dd1ca299af622

Better dependency walking

view details

push time in a month

push eventsamccone/bundle-buddy

Sam Saccone

commit sha 8aabd3021d34cd94042a88e66e75e897ac4c9683

update lock

view details

push time in a month

push eventsamccone/bundle-buddy

Sam Saccone

commit sha c7fbf75b464f95409f90d9b62935cdc7f470ad69

better handling of webpack bundle grouping

view details

push time in a month

push eventsamccone/bundle-buddy

Sam Saccone

commit sha ff91603f36dad6891a8fc775f674db1f4b0f81fe

always save stats

view details

push time in a month

push eventsamccone/bundle-buddy

Sam Saccone

commit sha b9eaae3628074432dcca713455ce0d2c3c5682f0

upgrade bundle to ts

view details

push time in a month

push eventsamccone/bundle-buddy

Sam Saccone

commit sha 39638925cc2d01d4ed6be4aa4f59aee5b5acf101

Add treemap data gen to import flow

view details

push time in a month

push eventsamccone/bundle-buddy

Sam Saccone

commit sha 7dc90b3646080ebdb07ff4b4253f2ed1d240bce3

Remove dummy test data.

view details

Sam Saccone

commit sha 7a781d51f68b2dfaafcc151e4299de7d38440dec

Clean overlapping trims.

view details

Sam Saccone

commit sha 3a02f838ae18f29f9e7b4408fc300d8b97dfb078

auto upload flow woot

view details

push time in a month

pull request commentsamccone/thermal_print

Select device endpoint by name

Thanks!!

ciex

comment created time in a month

push eventsamccone/thermal_print

Vincent Ahrend

commit sha dc5bca6c74b2ea4515cb988b8ccf734d9c796403

Select device endpoint by name (#3) * Select device endpoint by name * Fix suggestions from samccone * Fix code style

view details

push time in a month

PR merged samccone/thermal_print

Select device endpoint by name

Closes #2

I also removed the await from sendBytes and sendText as it's not needed on a return value.

+21 -2

0 comment

1 changed file

ciex

pr closed time in a month

issue closedsamccone/thermal_print

Hardcoded interface endpoint 0 not part of interface

I was able to make this lib work by changing the hardcoded interface endpoint in driver.sendBytes from 1 to 3:

export async function sendBytes(device: USBDevice, bytes: Uint8Array) {
  return device.transferOut(3, bytes);
}

For my printer this corresponds to the out endpoint.

endpoints: Array(2)
    0: USBEndpoint
        direction: "in"
        endpointNumber: 1
        packetSize: 64
        type: "bulk"
        __proto__: USBEndpoint
    1: USBEndpoint
        direction: "out"
        endpointNumber: 3
        packetSize: 64
        type: "bulk"
        __proto__: USBEndpoint
length: 2
__proto__: Array(0)

I am wondering if this should be dynamically selected instead of hardcoded but I don't know enough about WebUSB. If sendBytes should indeed choose the endpointNumber by selecting the endpoint with direction: 'out' I could make a PR.

closed time in a month

ciex

push eventsamccone/bundle-buddy

Sam Saccone

commit sha 9a858417a857b36f62ed6eb110b914c1330845ba

Implement prefix trimming logic for resolve flow.

view details

push time in a month

startedentropic-dev/entropic

started time in a month

Pull request review commentsamccone/thermal_print

Select device endpoint by name

 export async function reverse(   await sendText(device, "\x1DB" + enabled); } +/**+ * Select an endpoint from the currently selected device configuration by name+ * + * @param name usually 'out' or 'in'+ * @param device the connected USBDevice+ */+function selectEndpoint(name: string, device: USBDevice) {

can you update this type to 'in'|'out'

it will look like

(name: "in"|"out")
ciex

comment created time in 2 months

Pull request review commentsamccone/thermal_print

Select device endpoint by name

 export async function reverse(   await sendText(device, "\x1DB" + enabled); } +/**+ * Select an endpoint from the currently selected device configuration by name+ * + * @param name usually 'out' or 'in'+ * @param device the connected USBDevice+ */+function selectEndpoint(name: string, device: USBDevice) {+  const endpoint = device.configuration+    .interfaces[0]+    .alternate+    .endpoints.filter(ep => ep.direction == name)

prefer .find() instead of filter + shift

--

filter + shift is cool though, I have never seen this approach before :)

ciex

comment created time in 2 months

issue closedsamccone/chrome-trace-event

Version 1.0.1 has `npm` as a dependency

Hi! The recently published version 1.0.1 has npm declared as a direct dependency. I don't believe this was intended.

$ diff -u chrome-trace-event-git/package.json chrome-trace-event/package.json Where chrome-trace-event-git is what is available on this git repository, and chrome-trace-event is what I have in my node_modules folder.

--- chrome-trace-event-git/package.json 2019-05-26 06:34:13.000000000 +0300
+++ chrome-trace-event/package.json     2019-05-26 21:57:33.384000000 +0300
@@ -18,6 +18,7 @@
   "main": "./dist/trace-event.js",
   "typings": "./dist/trace-event.d.ts",
   "dependencies": {
+    "npm": "^6.9.0",
     "tslib": "^1.9.0"
   },
   "devDependencies": {

closed time in 2 months

sharkykh

issue commentsamccone/chrome-trace-event

Version 1.0.1 has `npm` as a dependency

1.0.2 pushed and published.

Thanks all.

sharkykh

comment created time in 2 months

created tagsamccone/chrome-trace-event

tagv1.0.2

A node module for creating event traces according to Google's Trace Event format

created time in 2 months

push eventsamccone/chrome-trace-event

Sam Saccone

commit sha 8a47645a220b30dc62478b46cf4c11e5ddeb48c0

remove npm dep in .lockfile

view details

Sam Saccone

commit sha d45bc8af3b5c53a3adfa2c5fc107b4fae054f579

1.0.2

view details

push time in 2 months

issue commentsamccone/chrome-trace-event

Version 1.0.1 has `npm` as a dependency

thanks for the flag, updating right now.

sharkykh

comment created time in 2 months

issue commentmicrosoft/monaco-editor

editor in a WebComponent: viewImpl and codeEditorWidget

I encountered similar problems with shadow dom and monaco. I was able to work around the problem by slotting the target DOM node into my application from the body level down.

mbana

comment created time in 2 months

issue commentsamccone/fried-twinkie

Not compatible with TypeScript 3

PR in progress here https://github.com/samccone/fried-twinkie/pull/11

However we are now hitting a bug in tsickle. https://github.com/angular/tsickle/issues/1019

rehmsen

comment created time in 2 months

issue openedangular/tsickle

TypeError: writeFileDelegate is not a function

REPO checkout: https://github.com/samccone/fried-twinkie/pull/11

yarn install yarn test

Stack:

/usr/local/google/home/samccone/Desktop/repos/src/tsickle.ts:153
        writeFileDelegate(fileName, content, writeByteOrderMark, onError, sourceFiles);
        ^
TypeError: writeFileDelegate is not a function
    at Object.writeFileImpl [as writeFile] (/usr/local/google/home/samccone/Desktop/repos/src/tsickle.ts:153:9)
    at Object.writeFile (/usr/local/google/home/samccone/Desktop/repos/fried-twinkie/node_modules/typescript/lib/typescript.js:11571:14)
    at printSourceFileOrBundle (/usr/local/google/home/samccone/Desktop/repos/fried-twinkie/node_modules/typescript/lib/typescript.js:83298:16)
    at emitJsFileOrBundle (/usr/local/google/home/samccone/Desktop/repos/fried-twinkie/node_modules/typescript/lib/typescript.js:83183:13)
    at emitSourceFileOrBundle (/usr/local/google/home/samccone/Desktop/repos/fried-twinkie/node_modules/typescript/lib/typescript.js:83115:13)
    at forEachEmittedFile (/usr/local/google/home/samccone/Desktop/repos/fried-twinkie/node_modules/typescript/lib/typescript.js:82907:34)
    at Object.emitFiles (/usr/local/google/home/samccone/Desktop/repos/fried-twinkie/node_modules/typescript/lib/typescript.js:83098:9)
    at emitWorker (/usr/local/google/home/samccone/Desktop/repos/fried-twinkie/node_modules/typescript/lib/typescript.js:89019:33)
    at /usr/local/google/home/samccone/Desktop/repos/fried-twinkie/node_modules/typescript/lib/typescript.js:88979:66
    at runWithCancellationToken (/usr/local/google/home/samccone/Desktop/repos/fried-twinkie/node_modules/typescript/lib/typescript.js:89070:24)
    at Object.emit (/usr/local/google/home/samccone/Desktop/repos/fried-twinkie/node_modules/typescript/lib/typescript.js:88979:20)

created time in 2 months

PR opened samccone/fried-twinkie

Update to typescript 3+

fixed #10

+19 -20

0 comment

3 changed files

pr created time in 2 months

create barnchsamccone/fried-twinkie

branch : sjs/update_to_3

created branch time in 2 months

issue commentsamccone/fried-twinkie

Not compatible with TypeScript 3

Hey Ole, we can totally update this!

rehmsen

comment created time in 2 months

issue closedsamccone/thermal_print

Does not work

Webpack fails to build

closed time in 2 months

jor3l

issue commentsamccone/thermal_print

Does not work

please let me know if this is still a problem for you. closing.

jor3l

comment created time in 2 months

issue commentsamccone/thermal_print

Hardcoded interface endpoint 0 not part of interface

oh yes.... this should 100% not be hard coded and instead should look to find the out endpoint. @ciex if you are interested in making the PR it would be appreciated. Please do let me know if you have any questions.

ciex

comment created time in 2 months

issue commentsamccone/chrome-trace-event

Invalid JSON in tsconfig.json

fixed. Thanks for the report.

heruan

comment created time in 2 months

created tagsamccone/chrome-trace-event

tagv1.0.1

A node module for creating event traces according to Google's Trace Event format

created time in 2 months

push eventsamccone/chrome-trace-event

Sam Saccone

commit sha 656e08718ce33f5c040301f92ef06d0e6dad163b

1.0.1

view details

push time in 2 months

push eventsamccone/chrome-trace-event

Sam Saccone

commit sha ce9058511eceb5e73a866947befed3b6fa10a7e0

drop comments from tsconfig Fix #7

view details

push time in 2 months

issue closedsamccone/chrome-trace-event

Invalid JSON in tsconfig.json

The JSON in tsconfig.json is invalid, as it contains comments which are not supported in JSON; this leads in IDE errors when this package is present in the dependency hierarchy.

closed time in 2 months

heruan

pull request commentsamccone/chrome-trace-event

fix: remove trailing comma, add closing brace

Thanks Daniel.

DanielRuf

comment created time in 2 months

push eventsamccone/chrome-trace-event

Daniel Ruf

commit sha 2827b80b7cd651558f0b6db7d128579b8966d737

fix: remove trailing comma, add closing brace

view details

Sam Saccone

commit sha 7bf5be98881098cd9ebf94a3cc7754ce47735598

Merge pull request #6 from DanielRuf/fix/remove-trailing-comma-add-closing-brace fix: remove trailing comma, add closing brace

view details

push time in 2 months

PR merged samccone/chrome-trace-event

fix: remove trailing comma, add closing brace

This fixes the output (removes trailing comma and adds missing closing brace).

See https://github.com/webpack/webpack/issues/7450#issuecomment-399700051

+10 -7

1 comment

1 changed file

DanielRuf

pr closed time in 2 months

push eventsamccone/me

Sam Saccone

commit sha f43b036505dc0a6a6fcba616ff66c044620d98fd

typos gah!

view details

push time in 3 months

push eventsamccone/me

Sam Saccone

commit sha 74515113c3d863cf1e4d7a8dbd8a6be5418aa923

fix image sizing for mobile

view details

push time in 3 months

push eventsamccone/me

Sam Saccone

commit sha f31bdd3eb3b10f6f7bda401435938ce6dd3d4d30

fix image url

view details

push time in 3 months

push eventsamccone/me

Sam Saccone

commit sha 4c34be6fae896295e8c51839e2565cbce4e01d18

hex article

view details

push time in 3 months

PR opened drudru/ansi_up

Add LICENSE file to repo for license conformance checking
+23 -26

0 comment

2 changed files

pr created time in 3 months

push eventsamccone/ansi_up

Sam Saccone

commit sha 38f8496e55f9b5398215f086726bbd35badaa18d

Add LICENSE file to repo for license conformance checking

view details

push time in 3 months

fork samccone/ansi_up

A javascript library that converts text with ANSI terminal codes into colorful HTML

fork in 3 months

create barnchsamccone/fieri_compress

branch : master

created branch time in 3 months

created repositorysamccone/fieri_compress

created time in 3 months

issue commentwebpack-contrib/webpack-bundle-analyzer

Visualize time spent inside plugins/loaders

No, I made the export format loadable by chrome://tracing

which is what is captured in the screenshot above.

SpaceK33z

comment created time in 3 months

more