salomegeo ( Salome V )

Matches design for linked cards displayed in Settings. We originally had exp date and limits in the card, but I've removed to match design, which just has 'Card Ending in {cardNumber}' as the detail.

Testing Steps (optional)

Detail the steps required for the reviewer(s) to verify and test these changes.

+6 -18

1 commit in blockchain/blockchain-wallet-v4-frontend/tree/fix/style blockchain/blockchain-wallet-v4-frontend/tree/development

0 comment

2 changed files

TheLeoB

pr closed time in 4 hours

delete branch blockchain/blockchain-wallet-v4-frontend

delete branch : fix/phrase-warning

delete time in 4 hours

push eventblockchain/blockchain-wallet-v4-frontend

leora

commit sha 48ac6a596035c5336da37b46b2d96c44b18f7c0b

feat(backup): scam mitigation copy for recovery phrase

view details

leora

commit sha 42a809c3870ceb1a7ac3ee325715c81155e28605

feat(pairing): add scam mitigation pairing copy

view details

leora

commit sha 17e660281858f98d3e6ec0feaa6c3d1765ecace1

fix(style): minor margin and size adjustments

view details

Andrew Schneider

commit sha f8eb864657cc0201aec1b8dcb839ea924d150219

Merge pull request #2893 from blockchain/fix/phrase-warning Fix/phrase warning

view details

push time in 4 hours

PR merged blockchain/blockchain-wallet-v4-frontend

Reviewers

Fix/phrase warning

Description (optional)

FWLT-1029 - scam mitigation copy updates.

Testing Steps (optional)

Detail the steps required for the reviewer(s) to verify and test these changes.

+187 -77

3 commit in blockchain/blockchain-wallet-v4-frontend/tree/fix/phrase-warning blockchain/blockchain-wallet-v4-frontend/tree/development

0 comment

4 changed files

TheLeoB

pr closed time in 4 hours

PR opened blockchain/blockchain-wallet-v4-frontend

Fix/phrase warning

Description (optional)

FWLT-1029 - scam mitigation copy updates.

Testing Steps (optional)

Detail the steps required for the reviewer(s) to verify and test these changes.

+187 -77

3 commit in blockchain/blockchain-wallet-v4-frontend/tree/fix/phrase-warning blockchain/blockchain-wallet-v4-frontend/tree/development

0 comment

4 changed files

pr created time in 4 hours

create barnchblockchain/blockchain-wallet-v4-frontend

branch : fix/phrase-warning

created branch time in 4 hours

pull request commentblockchain/blockchain-wallet-v4-frontend

feat(brokerage): abstracts brokerage related functionality into it's own data/modal sections starting with ACH

Also as dicussed i dont think we need the root index.ts in the modals/brokerage folder. Just do explicit lazy load imports via paths in the modals/index.ts file.

milan-bc

comment created time in 7 hours

Pull request review commentblockchain/blockchain-wallet-v4-frontend

feat(bankLinking): show bank details and remove bank

 type MessagesType = {   'lockbox.service.messages.storagespace': 'Insufficient storage space on device'   'lockbox.service.messages.unknown': 'An unknown error has occurred.'   'lockboxrequired.tooltip': 'Hardware device is required'+  'modals.brokerage.bank_preview.disclaimer': 'This account can be used for buys, sells & withdrawals.'+  'modals.brokerage.remove_bank.description': "You'e about to remove your {bankAccount}"+  'modals.brokerage.remove_bank.back': 'Back'

there is already a back. copy.back or buttons.back

milan-bc

comment created time in 9 hours

Pull request review commentblockchain/blockchain-wallet-v4-frontend

feat(bankLinking): show bank details and remove bank

 export type ModalOriginType =   | 'WalletBalanceDropdown'   | 'WelcomeModal'   | 'WithdrawModal'+  | 'BankDetailsModal'

sort alphabetically

milan-bc

comment created time in 8 hours

Pull request review commentblockchain/blockchain-wallet-v4-frontend

feat(bankLinking): show bank details and remove bank

 type MessagesType = {   'lockbox.service.messages.storagespace': 'Insufficient storage space on device'   'lockbox.service.messages.unknown': 'An unknown error has occurred.'   'lockboxrequired.tooltip': 'Hardware device is required'+  'modals.brokerage.bank_preview.disclaimer': 'This account can be used for buys, sells & withdrawals.'+  'modals.brokerage.remove_bank.description': "You'e about to remove your {bankAccount}"

typo in You're

milan-bc

comment created time in 9 hours

Pull request review commentblockchain/blockchain-wallet-v4-frontend

feat(bankLinking): show bank details and remove bank

 type MessagesType = {   'lockbox.service.messages.storagespace': 'Insufficient storage space on device'   'lockbox.service.messages.unknown': 'An unknown error has occurred.'   'lockboxrequired.tooltip': 'Hardware device is required'+  'modals.brokerage.bank_preview.disclaimer': 'This account can be used for buys, sells & withdrawals.'+  'modals.brokerage.remove_bank.description': "You'e about to remove your {bankAccount}"+  'modals.brokerage.remove_bank.back': 'Back'+  'modals.brokerage.curency': 'Curency'

typo here in Currency. also create maybe a create a generic copy.currency item if it doesnt already exist

milan-bc

comment created time in 8 hours

Pull request review commentblockchain/blockchain-wallet-v4-frontend

feat(bankLinking): show bank details and remove bank

+import { call, put, retry, select, take } from 'redux-saga/effects'++import { actions, selectors } from 'data'+import { APIType } from 'core/network/api'+import { errorHandler } from 'blockchain-wallet-v4/src/utils'+import { Remote } from 'blockchain-wallet-v4/src'+import { SBCheckoutFormValuesType } from 'data/types'++import * as A from './actions'+import * as AT from './actionTypes'++// TODO: removed this SB dependency+import { DEFAULT_SB_METHODS } from '../simpleBuy/model'

lets move this to a models file in brokerage data folder as discussed

milan-bc

comment created time in 8 hours

PR opened blockchain/blockchain-wallet-v4-frontend

fix(settings): update card style to match designs

Description (optional)

Matches design for linked cards displayed in Settings. We originally had exp date and limits in the card, but I've removed to match design, which just has 'Card Ending in {cardNumber}' as the detail.