profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/salmanm/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Salman Mitha salmanm @nearform JavaScript hacker

mcollina/autocannon 5400

fast HTTP/1.1 benchmarking tool written in Node.js

fastify/fastify-multipart 175

Multipart support for Fastify

fastify/fastify-passport 106

Use passport strategies for authentication within a fastify application

fastify/github-action-merge-dependabot 67

This action automatically approves and merges dependabot PRs.

Concorda/concorda-dashboard 5

concorda dashboard

salmanm/babel-plugin-reexport 2

Allows re-exporting a node module

AdrianRossouw/nodecpt 0

Meetup websites powered by GitHub Pages.

nearform/babel-plugin-react-docgen 0

📝 Babel plugin to add react-docgen info into your code.

salmanm/action-dependabot-auto-merge 0

Automatically merge Dependabot PRs when version comparison is within range

issue openednearform/optic-expo

Upgrade to expo 43

https://github.com/nearform/optic-expo/pull/194 https://github.com/nearform/optic-expo/pull/195

created time in 13 hours

pull request commentnearform/optic-expo

chore(deps-dev): bump jest-expo from 42.1.0 to 43.0.0

@dependabot ignore this major version

dependabot[bot]

comment created time in 13 hours

pull request commentnearform/optic-expo

chore(deps): bump expo from 42.0.4 to 43.0.0

@dependabot ignore this major version

dependabot[bot]

comment created time in 13 hours

push eventnearform/optic-expo

Salman

commit sha 52ba4d3de3230408ae45b904d82bbd52bf1b88d3

fix: disallow inputing invalid secret

view details

Salman

commit sha 91cb4e23090631668208049031b08edd6ac976ad

fix: prevent failing while generating otp

view details

Salman

commit sha e05642050c0f5323ae9fb3e203f0380439b9ef8e

fix: cleanup

view details

Salman

commit sha 864837191f1a786653b968ee4905d79bd435378e

fix: show FAB over other components

view details

Salman

commit sha a72734d8670d435c4c12cbca3ab184c57fe03833

fix: prevent FAB from getting below the fold

view details

Salman

commit sha 6eaa82d08fc86d10e566161196dd1aa17b2be06b

fix: validation

view details

Salman

commit sha b1849ae11cee161c02354a88909296b18414a131

chore: refactor and simplify qr scanner

view details

push time in 13 hours

issue openednearform/optic-expo

Enhance OTP request flow in the app

Motivation: Once I add a 2FA for npm into Optic, it can now be used for everything. Also, if I have multiple repos using the same token, I’ll get lot’s of request and will never know which repo is releasing.

So, to add more security and better experience, I propose we change the app flow as following.

  • We add a secret as usual (type or scan)
  • When we generate token, we allow entering some more details with the token. Details like the source (the repo this token is gonna be used for) or any other info for audit/logs.
  • And do not restrict to just one token, we allow generating multiple tokens and display a list of these generated tokens somewhere (only to view and revoke/delete).
  • When the request for OTP comes, we currently show a simple alert. Instead, we go to a new Screen and display the request details like the repo and/or any additional info we may have corresponding to that token and perhaps a timestamp of when the OTP for "this token" was requested in the past.

Thoughts? Feel free to post suggestions to improve the above flow.

created time in a day

issue closednearform/optic-expo

Stale UI state on second login

UPDATE: the PR which fixes this issue has been merged but it needs an expo SDK release to be available. See https://github.com/expo/expo/pull/11503

I noticed some stale UI state after logging in with Google. This only happens after I log in and logout once. I was able to reproduce it on both iPhone and Android.

https://user-images.githubusercontent.com/12698531/108235942-471e2100-713e-11eb-84d4-d1309478cc81.MP4

Steps to Reproduce

  • Login with Google & logout
  • Login again with the same account

Expected

  • User arrives on the Home screen

Actual

  • User is stuck on the Auth screen

closed time in a day

richiemccoll

issue commentnearform/optic-expo

Stale UI state on second login

Looks like this is fixed now. I tried logging in/out and all seemed fine on my phone

richiemccoll

comment created time in a day

push eventnearform/optic-expo

Salman

commit sha 2cfbb0f5af3d15886de2faa969125fd2a878eec9

fix: tests

view details

push time in 2 days

push eventnearform/optic-expo

dependabot[bot]

commit sha fdaeedf8ab91d4057826d2a484d38a5abb190853

chore(deps-dev): bump @testing-library/react-native from 7.2.0 to 8.0.0 (#189) Bumps [@testing-library/react-native](https://github.com/callstack/react-native-testing-library) from 7.2.0 to 8.0.0. - [Release notes](https://github.com/callstack/react-native-testing-library/releases) - [Changelog](https://github.com/callstack/react-native-testing-library/blob/main/.release-it.json) - [Commits](https://github.com/callstack/react-native-testing-library/compare/v7.2.0...v8.0.0) --- updated-dependencies: - dependency-name: "@testing-library/react-native" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

Salman

commit sha da1aac31bbfa258670f05a4ded307fa9a7700d06

chore: remove upload feature

view details

Salman

commit sha 0e7e883ec1d65396b3d4276729ab201e90cda7b2

fix: lint

view details

Salman

commit sha 1d9a582f23678f45ebdb518ca90bb8843dc3e52b

fix: input screen padding

view details

Salman

commit sha c405773da6ffa5d6a9d89c98a1db073d8f548651

chore: add typescript

view details

Salman

commit sha 20c47d52b73d7fd19abbf21f34411082df55be34

chore: refactor and TS fixes

view details

Salman

commit sha cdf51122bad5119c240a042315ec8048e7d49ad8

chore: more refactor

view details

Salman

commit sha ba0a2217fe0bbbafb3aba931496481e83b03122a

chore: refactor typography

view details

Salman

commit sha 9eadd0ca96967f984154aa5168206760b0e17e58

chore: more refactor

view details

Salman

commit sha db5a30c4710bfcbd7735e823932817cf603c242c

chore: theme refactor

view details

Salman

commit sha 9b94e6a1caf351070ce147422cf1548bb1bc2cbe

fix: crypto

view details

Salman

commit sha bce2b9f72b4e51da542165ecf689b2b15d5f1cbc

chore: more refactor

view details

Salman

commit sha 63af54f0777030898637b99c638fd8c75c9a76f6

fix: tests

view details

Salman

commit sha ca3abe9b335b8d8a0d58f96e6661e1e041b8401a

test: more tests

view details

Salman

commit sha 866f384ebdf7aa4e7facc11a261fe7b46b362cb4

fix: rename typography

view details

Salman

commit sha 1a1c3c385dec07c0294c72434284238a5e77fc9e

chore: upgrade react-nav

view details

Salman

commit sha e28024664e0b59e95b0336e2218a8c2798c805a9

fix: notifications

view details

push time in 2 days

push eventnearform/optic-expo

Salman

commit sha 026c6f19be3a0867526592d5d195ce8a0eac9107

fix: notifications

view details

push time in 2 days

push eventsalmanm/smn-auto-release

Salman

commit sha 9e8b15042f61c7bf194a04481b11b78b7d3d66f0

chore: cd

view details

Salman

commit sha 187b82a0b85805bf8e4ab743333a1efe4ed4e876

0.0.4

view details

Salman

commit sha d02a68e49371cd5c8aa19289768c29b8b43f60e8

chore: cd

view details

push time in 2 days

push eventsalmanm/smn-auto-release

Salman

commit sha e937b1239be1b392753e518d69c61336f38420d1

chore: cd

view details

push time in 2 days

push eventsalmanm/smn-auto-release

Salman

commit sha fe50e3e89804e3eb99327a6bf7011b85b9b99167

chore: cd

view details

push time in 2 days

push eventsalmanm/smn-auto-release

Salman

commit sha 5c83851dd1ea9f6675ea1eff2e9fb3b0bab17ff4

0.0.3

view details

Salman

commit sha 4b38e0b58d0ba52da42cf7f4d6948dc2153c95dd

chore: cd

view details

push time in 2 days

push eventsalmanm/smn-auto-release

Salman

commit sha 0ef01f0c740b8b2e191a69439f2d19af17bd64af

0.0.2

view details

Salman

commit sha 1e2b3b98e9379b64a9bc7ab6395902843bdf3abb

chore: cd

view details

push time in 2 days

push eventsalmanm/smn-auto-release

Salman

commit sha 50f7e3a4810057a1151d4850910e2cff726e96b2

chore: cd

view details

push time in 2 days

push eventsalmanm/smn-auto-release

Salman

commit sha d9aca820352c0d12c3bd6fa8b0671a0036131fd3

chore: cd

view details

push time in 2 days

push eventsalmanm/smn-auto-release

Salman

commit sha f57e4b524e947bd3fe292edda0023f9a4a1e7966

chore: cd

view details

push time in 2 days

push eventsalmanm/smn-auto-release

Salman

commit sha 1c392106d3613a829d4d8847b98c3ffc1a9f1531

chore: rename repo to avoid conflict

view details

push time in 2 days

push eventsalmanm/auto-release-example

Salman

commit sha 448e0a904e6074da33799640b59cd8bc414f75ba

chore: init npm

view details

Salman

commit sha d73c6037afd9f90ba9883e00b5724c781eff2c0d

0.0.1

view details

push time in 2 days

push eventsalmanm/auto-release-example

Salman

commit sha 2658bbf0f3d064fbe431ec1d2e1d53c94e6b9bcf

chore: release workflow

view details

push time in 2 days

create barnchsalmanm/auto-release-example

branch : main

created branch time in 2 days

created repositorysalmanm/auto-release-example

created time in 2 days

push eventnearform/optic-expo

Salman

commit sha 73eb1917d17874b5d9fdc09dea9275882ad00d0b

chore: upgrade react-nav

view details

push time in 3 days

push eventnearform/optic-expo

Salman

commit sha e3728eaf9e1a933e6a2671f08c37923854247226

chore: remove upload feature

view details

Salman

commit sha b8b2a81d9cae2936b7f2c5cb015acbce849428c1

fix: lint

view details

Salman

commit sha 27f835a959d7484b047ad47704eacdb5c25a90be

fix: input screen padding

view details

Salman

commit sha bef0c8cf0e5d8502d25286bf8b31e6ad1f4412ba

chore: add typescript

view details

Salman

commit sha 9c0c032e13f5175bab24f360b25d6d377606eab9

chore: refactor and TS fixes

view details

Salman

commit sha 5e97bbc177ee67991989e063377535358d3715e1

chore: more refactor

view details

Salman

commit sha e3146e3ae4ae0ae866f6bc0d1545a5382d8fb7d5

chore: refactor typography

view details

Salman

commit sha 232335e03224501a63695a8142d6271b21a70664

chore: more refactor

view details

Salman

commit sha fc2fce670ac1336c9f038ec0de3054e106422797

chore: theme refactor

view details

Salman

commit sha 8823fad3ce6daab8c0734592248d51eeec8a5fa1

fix: crypto

view details

Salman

commit sha ec1182229da3db9287225e2cb88691133dce382d

chore: more refactor

view details

Salman

commit sha 54d39a438b5f40ea38e1d4b07f2f8f2d560a8e38

fix: tests

view details

Salman

commit sha c76ceaa3359a29db70085ba3dbb53f3d3e6a569d

test: more tests

view details

Salman

commit sha 1d69f8cfe984656ebcf4f582b9e50f3e8be83d6e

fix: rename typography

view details

push time in 3 days

push eventnearform/optic-expo

dependabot[bot]

commit sha ba41baf7434673429f7ff5e68bdc2e89d2875532

chore(deps-dev): bump jest from 27.3.0 to 27.3.1 (#192) Bumps [jest](https://github.com/facebook/jest) from 27.3.0 to 27.3.1. - [Release notes](https://github.com/facebook/jest/releases) - [Changelog](https://github.com/facebook/jest/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/jest/compare/v27.3.0...v27.3.1) --- updated-dependencies: - dependency-name: jest dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

Salman

commit sha c72167b7d662f01b7408d7c80c284a0e25871dce

chore: remove upload feature

view details

Salman

commit sha 1a8f59198247b5836f8cae7fdddd773990046aa8

fix: lint

view details

Salman

commit sha 08ea652596bd9035e6303c714d4897b3177e149f

fix: input screen padding

view details

Salman

commit sha d61e39c80995131723e0747341cc2da74ebad98b

chore: add typescript

view details

Salman

commit sha bf605656ac08fbc842bd703feec1a6f3f65de206

chore: refactor and TS fixes

view details

Salman

commit sha 40d0bbc17bcc7060a4372713d0ab032e6dde0abb

chore: more refactor

view details

Salman

commit sha 3684f339ecad8c25c67be9dc98791a9ba6019316

chore: refactor typography

view details

Salman

commit sha ae2f64ebe572cee952022687d90b09dc8eb5d822

chore: more refactor

view details

Salman

commit sha d9c4e0fc61ed6de39798fa7ef71822616add11db

chore: theme refactor

view details

Salman

commit sha da2bd3fe5a6f95612f2b66cd19f5440a0a06a2f0

fix: crypto

view details

Salman

commit sha fcb37227673cd90977fb24ffe7dd76c1700dde24

chore: more refactor

view details

Salman

commit sha d03244245515687ab0d39b62ea51917ae1d5cf6b

fix: tests

view details

Salman

commit sha c523d18091dcff62e7c61d8cd9434fa019db3d08

test: more tests

view details

push time in 3 days

push eventnearform/optic-expo

Salman

commit sha 2c6c88e9a17cd8813ee567c30a3261d69bc7ecfe

chore: more refactor

view details

Salman

commit sha 46a25e9611d49154ecbedd3b9da25934ffb3e47b

chore: refactor typography

view details

Salman

commit sha 3303b00279f8c929d6ad3052a9f3e85b37041bc8

chore: more refactor

view details

Salman

commit sha 165a45910083a6b5627c8a66a99e31df3fd8f6ba

chore: theme refactor

view details

Salman

commit sha 3246903c90a0681707197054fbd7151a4d4818a0

fix: crypto

view details

Salman

commit sha d92da5f38efd51c7188a41d88278ce505c99f6c9

chore: more refactor

view details

Salman

commit sha fcc2612efd60a6c820ba4904b10fe6a38827f77e

fix: tests

view details

Salman

commit sha a7d57c6672e5169c709ca5d23b6d12c3c2f05d27

test: more tests

view details

push time in 3 days

PR closed nearform/optic-expo

Fix | Login flow fails if performed immediately after logging out

Closes: #17

This PR adds:

  • [x] Wraps third-party async functions in try/catch blocks where appropriate setting the pattern for proper error handling in the future.
  • [x] Preload static assets using the expo-asset library.
  • [ ] Bumps expo-auth-session library to new version that fixes the login issue.
+96 -56

3 comments

6 changed files

n370

pr closed time in 4 days

PR opened nearform/optic-expo

chore: fixes, refactor & typescript
+819 -225

0 comment

43 changed files

pr created time in 4 days