profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/saliceti/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Colin Saliceti saliceti Department for Education

DFE-Digital/architecture 8

Guide to DfE architecture and design

DFE-Digital/get-into-teaching-publisher 0

Static site generator for Get Into Teaching website

DFE-Digital/service-manual 0

DfE Service Manual

keymon/tsuru-dockerfiles 0

Set of dockerfiles to create docker images of tsuru.io services

mtekel/digitalmarketplace-admin-frontend 0

Frontend administration application for the digital marketplace

create barnchsaliceti/docker-caching-demo

branch : hello

created branch time in 17 hours

created repositorysaliceti/docker-caching-demo

created time in 17 hours

PullRequestReviewEvent

Pull request review commentDFE-Digital/apply-for-teacher-training

Remove assets precompile stage

-# To use or update to a ruby version, change {BASE_RUBY_IMAGE}+## To use or update to a ruby version, change {BASE_RUBY_IMAGE} ARG BASE_RUBY_IMAGE=ruby:2.7.4-alpine3.12-# BASE_RUBY_IMAGE_WITH_GEMS_AND_NODE_MODULES will default to apply-for-teacher-training-gems-node-modules-# building all layers above it if a value is not specidied during the build-ARG BASE_RUBY_IMAGE_WITH_GEMS_AND_NODE_MODULES=apply-for-teacher-training-gems-node-modules -# Stage 1: install-gems-node-modules, download gems and node modules.-FROM ${BASE_RUBY_IMAGE} AS install-gems-node-modules+# Stage 1: gems-node-modules, build gems and node modules.+FROM ${BASE_RUBY_IMAGE} AS gems-node-modules -ARG BUILD_DEPS="git gcc libc-dev make nodejs yarn postgresql-dev build-base libxml2-dev libxslt-dev ttf-ubuntu-font-family"-ENV WKHTMLTOPDF_GEM=wkhtmltopdf-binary-edge-alpine--WORKDIR /app--COPY Gemfile Gemfile.lock package.json yarn.lock ./+ARG BUILD_DEPS="git gcc libc-dev make postgresql-dev build-base libxml2-dev libxslt-dev ttf-ubuntu-font-family"  RUN apk -U upgrade && \     apk add --update --no-cache --virtual .gem-installdeps $BUILD_DEPS && \-    gem update --system && \-    find / -wholename '*default/bundler-*.gemspec' -delete && \-    rm -rf /usr/local/bin/bundle && \-    gem install bundler -v 2.1.4 && \-    bundler -v && \-    bundle config set no-cache 'true' && \-    bundle config set no-binstubs 'true' && \-    bundle --retry=5 --jobs=4 --without=development --with=production && \-    yarn install --check-files && \-    apk del .gem-installdeps && \-    rm -rf /usr/local/bundle/cache && \-    find /usr/local/bundle/gems -name "*.c" -delete && \-    find /usr/local/bundle/gems -name "*.h" -delete && \-    find /usr/local/bundle/gems -name "*.o" -delete--# Stage 2: apply-for-teacher-training-gems-node-modules, reduce size of gems-node-modules and only keep required files.-# published as dfedigital/apply-for-teacher-training-gems-node-modules-FROM ${BASE_RUBY_IMAGE} AS apply-for-teacher-training-gems-node-modules+    apk add --update --no-cache nodejs yarn tzdata libpq libxml2 libxslt graphviz && \

This big RUN command can be split into mutiple RUNs for readability since they will be cached independently

vigneshmsft

comment created time in 17 hours

Pull request review commentDFE-Digital/apply-for-teacher-training

Remove assets precompile stage

-# To use or update to a ruby version, change {BASE_RUBY_IMAGE}+## To use or update to a ruby version, change {BASE_RUBY_IMAGE} ARG BASE_RUBY_IMAGE=ruby:2.7.4-alpine3.12-# BASE_RUBY_IMAGE_WITH_GEMS_AND_NODE_MODULES will default to apply-for-teacher-training-gems-node-modules-# building all layers above it if a value is not specidied during the build-ARG BASE_RUBY_IMAGE_WITH_GEMS_AND_NODE_MODULES=apply-for-teacher-training-gems-node-modules -# Stage 1: install-gems-node-modules, download gems and node modules.-FROM ${BASE_RUBY_IMAGE} AS install-gems-node-modules+# Stage 1: gems-node-modules, build gems and node modules.+FROM ${BASE_RUBY_IMAGE} AS gems-node-modules -ARG BUILD_DEPS="git gcc libc-dev make nodejs yarn postgresql-dev build-base libxml2-dev libxslt-dev ttf-ubuntu-font-family"-ENV WKHTMLTOPDF_GEM=wkhtmltopdf-binary-edge-alpine--WORKDIR /app--COPY Gemfile Gemfile.lock package.json yarn.lock ./+ARG BUILD_DEPS="git gcc libc-dev make postgresql-dev build-base libxml2-dev libxslt-dev ttf-ubuntu-font-family"  RUN apk -U upgrade && \     apk add --update --no-cache --virtual .gem-installdeps $BUILD_DEPS && \-    gem update --system && \-    find / -wholename '*default/bundler-*.gemspec' -delete && \-    rm -rf /usr/local/bin/bundle && \-    gem install bundler -v 2.1.4 && \-    bundler -v && \-    bundle config set no-cache 'true' && \-    bundle config set no-binstubs 'true' && \-    bundle --retry=5 --jobs=4 --without=development --with=production && \-    yarn install --check-files && \-    apk del .gem-installdeps && \-    rm -rf /usr/local/bundle/cache && \-    find /usr/local/bundle/gems -name "*.c" -delete && \-    find /usr/local/bundle/gems -name "*.h" -delete && \-    find /usr/local/bundle/gems -name "*.o" -delete--# Stage 2: apply-for-teacher-training-gems-node-modules, reduce size of gems-node-modules and only keep required files.-# published as dfedigital/apply-for-teacher-training-gems-node-modules-FROM ${BASE_RUBY_IMAGE} AS apply-for-teacher-training-gems-node-modules+    apk add --update --no-cache nodejs yarn tzdata libpq libxml2 libxslt graphviz && \

since we don't really need to optimise this image for size --virtual .gem-installdeps and apk del .gem-installdeps may be removed

vigneshmsft

comment created time in 17 hours

PullRequestReviewEvent

Pull request review commentDFE-Digital/apply-for-teacher-training

Remove assets precompile stage

-# To use or update to a ruby version, change {BASE_RUBY_IMAGE}+## To use or update to a ruby version, change {BASE_RUBY_IMAGE} ARG BASE_RUBY_IMAGE=ruby:2.7.4-alpine3.12-# BASE_RUBY_IMAGE_WITH_GEMS_AND_NODE_MODULES will default to apply-for-teacher-training-gems-node-modules-# building all layers above it if a value is not specidied during the build-ARG BASE_RUBY_IMAGE_WITH_GEMS_AND_NODE_MODULES=apply-for-teacher-training-gems-node-modules -# Stage 1: install-gems-node-modules, download gems and node modules.-FROM ${BASE_RUBY_IMAGE} AS install-gems-node-modules+# Stage 1: gems-node-modules, build gems and node modules.+FROM ${BASE_RUBY_IMAGE} AS gems-node-modules -ARG BUILD_DEPS="git gcc libc-dev make nodejs yarn postgresql-dev build-base libxml2-dev libxslt-dev ttf-ubuntu-font-family"-ENV WKHTMLTOPDF_GEM=wkhtmltopdf-binary-edge-alpine--WORKDIR /app--COPY Gemfile Gemfile.lock package.json yarn.lock ./+ARG BUILD_DEPS="git gcc libc-dev make postgresql-dev build-base libxml2-dev libxslt-dev ttf-ubuntu-font-family"  RUN apk -U upgrade && \     apk add --update --no-cache --virtual .gem-installdeps $BUILD_DEPS && \-    gem update --system && \-    find / -wholename '*default/bundler-*.gemspec' -delete && \-    rm -rf /usr/local/bin/bundle && \-    gem install bundler -v 2.1.4 && \-    bundler -v && \-    bundle config set no-cache 'true' && \-    bundle config set no-binstubs 'true' && \-    bundle --retry=5 --jobs=4 --without=development --with=production && \-    yarn install --check-files && \-    apk del .gem-installdeps && \-    rm -rf /usr/local/bundle/cache && \-    find /usr/local/bundle/gems -name "*.c" -delete && \-    find /usr/local/bundle/gems -name "*.h" -delete && \-    find /usr/local/bundle/gems -name "*.o" -delete--# Stage 2: apply-for-teacher-training-gems-node-modules, reduce size of gems-node-modules and only keep required files.-# published as dfedigital/apply-for-teacher-training-gems-node-modules-FROM ${BASE_RUBY_IMAGE} AS apply-for-teacher-training-gems-node-modules+    apk add --update --no-cache nodejs yarn tzdata libpq libxml2 libxslt graphviz && \

nodejs and yarn could be in BUILD_DEPS

vigneshmsft

comment created time in 17 hours

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentDFE-Digital/apply-for-teacher-training

Remove assets precompile stage

-# To use or update to a ruby version, change {BASE_RUBY_IMAGE}+## To use or update to a ruby version, change {BASE_RUBY_IMAGE} ARG BASE_RUBY_IMAGE=ruby:2.7.4-alpine3.12-# BASE_RUBY_IMAGE_WITH_GEMS_AND_NODE_MODULES will default to apply-for-teacher-training-gems-node-modules-# building all layers above it if a value is not specidied during the build-ARG BASE_RUBY_IMAGE_WITH_GEMS_AND_NODE_MODULES=apply-for-teacher-training-gems-node-modules -# Stage 1: install-gems-node-modules, download gems and node modules.-FROM ${BASE_RUBY_IMAGE} AS install-gems-node-modules+# Stage 1: gems-node-modules, build gems and node modules.+FROM ${BASE_RUBY_IMAGE} AS gems-node-modules -ARG BUILD_DEPS="git gcc libc-dev make nodejs yarn postgresql-dev build-base libxml2-dev libxslt-dev ttf-ubuntu-font-family"-ENV WKHTMLTOPDF_GEM=wkhtmltopdf-binary-edge-alpine--WORKDIR /app--COPY Gemfile Gemfile.lock package.json yarn.lock ./+ARG BUILD_DEPS="git gcc libc-dev make postgresql-dev build-base libxml2-dev libxslt-dev ttf-ubuntu-font-family"

This could be an ENV

vigneshmsft

comment created time in 17 hours

push eventDFE-Digital/technical-guidance

Colin Saliceti

commit sha e7ad58c2e35b45163c37c0b04af8eedf006b82a2

Continuous delivery guide

view details

push time in 4 days

create barnchDFE-Digital/technical-guidance

branch : continuous-delivery

created branch time in 4 days

push eventDFE-Digital/technical-guidance

Colin Saliceti

commit sha d5ce3ba7af4fcb950676c67dc4c1471bbb17b4ca

Accessibility fixes

view details

Colin Saliceti

commit sha f4ddda16d9832c575cfcdb50d3b9af9e2fcd091e

Update accessibility statement

view details

Colin Saliceti

commit sha 4e9adbcca0e21889cd75740a728c2212422b6be1

Update README: accessibility testing

view details

push time in 4 days

PR opened DFE-Digital/technical-guidance

Fix accessibility issues
  • Fix accessibility issues
  • Update govuk tech docs gem
  • Update accessibility statement
+70 -86

0 comment

6 changed files

pr created time in 4 days

create barnchDFE-Digital/technical-guidance

branch : accessibility

created branch time in 4 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

delete branch DFE-Digital/find-teacher-training

delete branch : 2313-cache-docker-build-in-pull-requests

delete time in 6 days

push eventDFE-Digital/find-teacher-training

Colin Saliceti

commit sha 3b4c049b0128aa9a4af0c525aafeb17b10b76f86

Use PR branch sha as docker tag Improve docker caching and build time

view details

Colin Saliceti

commit sha b944562260c332eaf2d07d87afb04cffc8fed6c9

Remove unused variable from Makefile

view details

Colin Saliceti

commit sha afe8a54d96446c61f9e9c440a341ba39ee32a529

Ping docker actions to major version only

view details

Colin Saliceti

commit sha 6458149a07e40172cad38e2b815c09ed39894118

Reorder Dockerfile to optimise caching

view details

Colin Saliceti

commit sha 35a5ba5519d2cf26491e5695ad1b942e0b894a58

Replace buildx cache with standard registry This is more consistent with the other repos and allows more caching options

view details

Colin Saliceti

commit sha ea32e529d22c5968bb9b0877206228abe349c6ea

Merge pull request #858 from DFE-Digital/2313-cache-docker-build-in-pull-requests [2313] Use PR branch sha as docker tag

view details

push time in 6 days

PR merged DFE-Digital/find-teacher-training

[2313] Use PR branch sha as docker tag

Context

Improve docker caching and build time

Changes proposed in this pull request

  • Use PR branch sha as docker tag
  • Replace builx cahe with standard registry cache
  • Reorder Dockerfile

Guidance to review

Trello card

Checklist

  • [ ] Rebased master
  • [ ] Cleaned commit history
  • [ ] Tested by running locally
+59 -28

1 comment

3 changed files

saliceti

pr closed time in 6 days

push eventDFE-Digital/find-teacher-training

push time in 6 days

push eventDFE-Digital/find-teacher-training

Colin Saliceti

commit sha 59a3e7be413e2681698f9c07d61917ce71b92fce

TEST

view details

push time in 6 days