profile
viewpoint
Saad Quadri saadq Front End Engineer at Amazon Seattle https://saadq.com Open Source 💚

issue commentsaadq/resumake.io

Add in custom sections

Sorry for not updating guys...

I'll have a more official statement on this later, but the tldr is that I have been working on a new version of Resumake from scratch (in a private repo) that will support custom sections with a couple of other people and its been kind of slow due to me starting full-time work and just working on this when I have time.

My big project at work is finishing up, so I believe after this week I'll have a lot more time to work on this. I'll make a post next week about the current status of the new project and I'll see if I can just move it to this repo and make it public so others can contribute too.

jeeva86

comment created time in 4 days

startedviraptor/reverse-interview

started time in 10 days

pull request commentsaadq/resumake.io

About section for templates 6,4,7,5 and 9

Looks good, great work @ducaale! I'll be able to work on the other template and I can hopefully get this new section deployed by the end of the week.

ducaale

comment created time in 16 days

push eventsaadq/resumake.io

Mohamed Daahir

commit sha 4fde181f60dd8fcce9b697bd466dd60a3985899a

About section for templates 6,4,7,5 and 9 (#108) * add about section to template6 * add aboutSection in template4 * add aboutSection in template7 * add aboutSection in template5 * add aboutSection in template9 * format code

view details

push time in 16 days

pull request commentsaadq/resumake.io

About section for templates 6,4,7,5 and 9

Sorry, wasn't able to get to it over the weekend... will check this out right after work.

ducaale

comment created time in 16 days

pull request commentsaadq/resumake.io

About section for templates 6,4,7,5 and 9

Good stuff again @ducaale! I'll review this tomorrow and if everything looks good I'll see if I can finish the section for the remaining templates and get this change deployed.

ducaale

comment created time in 19 days

pull request commentsaadq/resumake.io

add about section for template 1 and 8

Thanks so much @ducaale, great work! I won't be able to deploy this change until About section support is there for every template, but it should be easy to add those sections for the rest of the templates since you already setup everything else.

I can hopefully get to adding the About section for the rest of the templates next week. Thanks again @ducaale :)

ducaale

comment created time in 24 days

push eventsaadq/resumake.io

maxamed daahir

commit sha a8b8beb5c0d9563513152c793bac84794a0e88d0

add about section for template 1 and 8 (#106) * add about section for template 1 and 8 * make aboutSection optional * fix flow error * fix lint error * format code

view details

push time in 24 days

PR merged saadq/resumake.io

add about section for template 1 and 8

This pull request adds About section which is used in most JSON Resume Examples

+97 -5

1 comment

11 changed files

ducaale

pr closed time in 24 days

issue commentsaadq/resumake.io

Template 9 Education bug

Fixed by #107

eka-sap

comment created time in 25 days

issue closedsaadq/resumake.io

Template 9 Education bug

Describe the bug In template 9 (last template), the education section has a bug. When adding more the 1 education details the formatting breaks.

To Reproduce Steps to reproduce the behavior:

  1. Go to Template 9(last template)
  2. Click on Education section
  3. Add education detail and add 2-3 education details
  4. See the broken format.

closed time in 25 days

eka-sap

PR merged saadq/resumake.io

Fixed formatting issue in education section of Template 9 (Issue #100)

See title. Small issue where entering more than one school caused formatting issues/failure to render pdf. Also swapped a \ for sepspace which is consistent with the rest of the sections in template 9

+2 -1

3 comments

1 changed file

cookster9

pr closed time in 25 days

push eventsaadq/resumake.io

cookster9

commit sha 8f763886f038f9c27e41e0eeff8bfba25a01b169

Fixed formatting issue in education section of Template 9 (Issue #100) (#107)

view details

push time in 25 days

pull request commentsaadq/resumake.io

Fixed formatting issue in education section of Template 9 (Issue #100)

Verified your changes, thanks so much @cookster9! :D

Would love to have more contributions, let me know if there's anything I can do to help out in anyway. There's also a Slack channel you can join if you have any questions/suggestions/feedback where it's a bit easier to chat.

Thanks again :)

cookster9

comment created time in 25 days

Pull request review commentsaadq/resumake.io

add about section for template 1 and 8

 function template1(values: SanitizedValues) {           case 'profile':             return generator.profileSection(values.basics) +          case 'about':+            return generator.aboutSection(values.basics, headings.about)

Because we want to set the aboutSection method in the Generator type to optional for now, this will have a type error because Flow won't be sure that the aboutSection method exists or not. For now, we can just add a check to make sure it exists before using it to get rid of the type error (we can remove this method check at some point once we have the aboutSection implemented in every template)

              return generator.aboutSection ? generator.aboutSection(values.basics, headings.about) : ''
ducaale

comment created time in 25 days

Pull request review commentsaadq/resumake.io

add about section for template 1 and 8

 const initialState = {   sections: [     'templates',     'profile',+    'about',

There is a Section type in client/src/common/types.js that will need to be updated as well for this change.

ducaale

comment created time in 25 days

Pull request review commentsaadq/resumake.io

add about section for template 1 and 8

 type SanitizedValues = {  type Generator = {   profileSection: (basics?: Basics) => string,+  aboutSection: (basics?: Basics, heading?: string) => string,

Until the rest of the templates also have an aboutSection method, can we mark this method as optional to prevent type errors?

  aboutSection?: (basics?: Basics, heading?: string) => string,
ducaale

comment created time in 25 days

Pull request review commentsaadq/resumake.io

add about section for template 1 and 8

 function template8(values: SanitizedValues) {       ${values.sections         .map(section => {           switch (section) {+            case 'about':+              return generator.aboutSection(values.basics, headings.about)

Same as template 1 –

Because we want to set the aboutSection method in the Generator type to optional for now, this will have a type error because Flow won't be sure that the aboutSection method exists or not. For now, we can just add a check to make sure it exists before using it to get rid of the type error (we can remove this method check at some point once we have the aboutSection implemented in every template)

              return generator.aboutSection ? generator.aboutSection(values.basics, headings.about) : ''
ducaale

comment created time in 25 days

Pull request review commentsaadq/resumake.io

add about section for template 1 and 8

 type Headings = { 

The Headings type in this file will also need to have an about property

ducaale

comment created time in 25 days

Pull request review commentsaadq/resumake.io

add about section for template 1 and 8

 type Headings = { 

The Headings type in this file will also need to have an about property

ducaale

comment created time in 25 days

pull request commentsaadq/resumake.io

Fixed formatting issue in education section of Template 9 (Issue #100)

Thanks a lot @cookster9 ! Will be able to check this out tomorrow :)

cookster9

comment created time in a month

pull request commentsaadq/resumake.io

add about section for template 1 and 8

@ducaale Awesome work, thanks so much for the PR! I'll be able to take a look at this tomorrow.

ducaale

comment created time in a month

issue closedsaadq/resumake.io

Bullet point feature missing for project description

Please provide bullet points in project description as it is present for experience field.

closed time in a month

kartik533

issue commentsaadq/resumake.io

Bullet point feature missing for project description

Duplicate of #104

kartik533

comment created time in a month

issue commentsaadq/resumake.io

Unable to run xelatex command

Do you have xelatex installed on your machine? A few of the templates use xelatex or lualatex instead of pdflatex to compile the PDFs, so you need to install them separately. The contributing.md needs to be updated to include this information.

pseudo13

comment created time in a month

startedgetify/TypL

started time in a month

pull request commentsaadq/misc

Bump eslint-utils from 1.3.1 to 1.4.2 in /lynt-jest

@dependabot ignore this major version

dependabot[bot]

comment created time in 2 months

PR closed saadq/misc

Bump eslint-utils from 1.3.1 to 1.4.2 in /lynt-jest dependencies

Bumps eslint-utils from 1.3.1 to 1.4.2. <details> <summary>Commits</summary>

  • 4e1bc07 1.4.2
  • e4cb014 🐛 add null test
  • 230a4e2 1.4.1
  • 08158db 🐛 fix getStaticValue security issue
  • 587cca2 🐛 fix getStringIfConstant to handle literals correctly
  • c119e83 🐛 fix getStaticValue to handle bigint correctly
  • 531b16f 🔖 1.4.0
  • 276303d ⚒ upgrade rollup
  • cb518c7 🐛 fix hasSideEffect false negative
  • aac472e 🐛 fix isParenthesized had false positive on ImportExpression (fixes #1)
  • Additional commits viewable in compare view </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+762 -54

0 comment

2 changed files

dependabot[bot]

pr closed time in 2 months

issue openedgoogleapis/google-api-nodejs-client

Unable to use `Purchases.Subscriptions: get` even after using Service to Service Authentication

I am trying to call Purchases.Subscriptions: get from my local server, but I am getting an error message saying Error: Login Required.

I have already created a service account with a role of Project Owner as described here. I then set the GOOGLE_APPLICATION_CREDENTIALS environment variable and made it point to the JSON file that was downloaded as mentioned here.

Lastly, I tried running some example code that was meant for server-to-server authentication based off the website docs example to see if I could authenticate successfully:

import { google } from 'googleapis'

async function main() {
  try {
    const auth = new google.auth.GoogleAuth({
      scopes: ['https://www.googleapis.com/auth/androidpublisher']
    })

    const authClient = await auth.getClient()
    const project = await auth.getProjectId()
    const publisher = google.androidpublisher('v3')

    const result = await publisher.purchases.subscriptions.get({
      packageName: 'com.mywebsite.subdomain',
      subscriptionId: 'com.mywebsite.subscription_name',
      token: '...my purchase token...'
    })

    console.log(result)
  } catch (error) {
    console.error(error)
  }
}

main()

I just used the Billing API instead of the Compute API, otherwise my example is the same as the one given in the docs. I am not sure why I am having issues, any help would be appreciated!


Full error:

{ Error: Login Required
    at Gaxios.request (/Users/squadri/Desktop/googlenode/node_modules/gaxios/src/gaxios.ts:86:15)
    at process._tickCallback (internal/process/next_tick.js:68:7)
  response:
   { config:
      { url:
         'https://www.googleapis.com/androidpublisher/v3/applications/com.mywebsite.subdomain/purchases/subscriptions/com.mywebsite.subscription_name/tokens/...my%20purchase%20token...',
        method: 'GET',
        paramsSerializer: [Function],
        headers: [Object],
        params: [Object: null prototype] {},
        validateStatus: [Function],
        retry: true,
        responseType: 'json',
        retryConfig: [Object] },
     data: { error: [Object] },
     headers:
      { 'alt-svc': 'quic=":443"; ma=2592000; v="46,43,39"',
        'cache-control': 'private, max-age=0',
        connection: 'close',
        'content-encoding': 'gzip',
        'content-type': 'application/json; charset=UTF-8',
        date: 'Tue, 20 Aug 2019 04:41:29 GMT',
        expires: 'Tue, 20 Aug 2019 04:41:29 GMT',
        server: 'GSE',
        'transfer-encoding': 'chunked',
        vary: 'Origin, X-Origin',
        'www-authenticate': 'Bearer realm="https://accounts.google.com/"',
        'x-content-type-options': 'nosniff',
        'x-frame-options': 'SAMEORIGIN',
        'x-xss-protection': '1; mode=block' },
     status: 401,
     statusText: 'Unauthorized' },
  config:
   { url:
      'https://www.googleapis.com/androidpublisher/v3/applications/com.mywebsite.subdomain/purchases/subscriptions/com.mywebsite.subscription_name/tokens/...my%20purchase%20token...',
     method: 'GET',
     paramsSerializer: [Function],
     headers:
      { 'x-goog-api-client': 'gdcl/3.1.0 gl-node/10.16.1 auth/5.2.0',
        'Accept-Encoding': 'gzip',
        'User-Agent': 'google-api-nodejs-client/3.1.0 (gzip)',
        Accept: 'application/json' },
     params: [Object: null prototype] {},
     validateStatus: [Function],
     retry: true,
     responseType: 'json',
     retryConfig:
      { currentRetryAttempt: 0,
        retry: 3,
        retryDelay: 100,
        httpMethodsToRetry: [Array],
        noResponseRetries: 2,
        statusCodesToRetry: [Array] } },
  code: 401,
  errors:
   [ { domain: 'global',
       reason: 'required',
       message: 'Login Required',
       locationType: 'header',
       location: 'Authorization' } ] }

created time in 2 months

fork saadq/react-native-iap

react-native native module for In App Purchase.

fork in 2 months

issue openediexg/IEX-API

[Issue] The /stats endpoint is missing `year5ChangePercent` for certain stocks

Clearly describe the problem Some stocks, such as WORK, have no year5ChangePercent field when using the /stats API.

What time did the problem occur? (with timezone) N/A

What is the expected behavior? The field should exist.

Your environment (e.g. browser, OS, API version, language): N/A

API URL (if applicable) https://cloud.iexapis.com/stable/stock/work/stats?token=<TOKEN>

What are the steps to reproduce the bug? Look at the JSON response for the above endpoint and see that the year5ChangePercent field is missing from the response.

Additional context N/A

created time in 2 months

push eventsaadq/node-latex

saadq

commit sha 1dc91c98bd8d51a7417e6ceaf3452f9ff004c99a

2.6.1

view details

saadq

commit sha 0ca2db26d35bee151823a98b3a6f72b98f3c4c1d

2.6.2

view details

push time in 2 months

push eventsaadq/node-latex

Roshan Padaki

commit sha a2d78f9cb0f72fd9c984d0432d0782fc34ae10ac

Specify `-jobname=texput` in LaTeX compiler args. (#28)

view details

push time in 2 months

PR merged saadq/node-latex

Specify `-jobname=texput` in LaTeX compiler args.

Just a small fix that should help with issue #22

Specifying the jobname will force the outputs to be texput.pdf and texput.log, etc. in the temporary directory, even when using \documentclass{article} which seems to normally rename the outputs to article.*.

+1 -0

1 comment

1 changed file

rpadaki

pr closed time in 2 months

pull request commentsaadq/node-latex

Specify `-jobname=texput` in LaTeX compiler args.

Awesome, thanks a lot @rpadaki!

rpadaki

comment created time in 2 months

issue commentsaadq/resumake.io

Preview window is empty

Yes, I think it's currently unintuitive. There won't be any content shown in the preview window until you put information in to the form fields (using the sidebar on the left). You can press the <kbd>Make</kbd> button whenever you want to generate the PDF.

But yeah, there are plans to make the UX more intuitive in the next version.

Yboktaya

comment created time in 2 months

PR closed saadq/node-latex

Bump lodash from 4.17.4 to 4.17.15 dependencies

Bumps lodash from 4.17.4 to 4.17.15. <details> <summary>Commits</summary>

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+6 -2

0 comment

1 changed file

dependabot[bot]

pr closed time in 2 months

PR closed saadq/node-latex

Bump is-my-json-valid from 2.16.0 to 2.20.0 dependencies

Bumps is-my-json-valid from 2.16.0 to 2.20.0. <details> <summary>Commits</summary>

  • 60111f4 2.20.0
  • 8c11f77 Merge pull request #175 from LinusU/meta
  • b6d9b3f Cleanup package metadata
  • dcea5be 2.19.0
  • 1712811 Merge pull request #171 from mafintosh/ts-nullable
  • fad4c91 Add nullable types to TypeScript typings
  • 484197f Add test for nested object in typings
  • 4bec868 Merge pull request #168 from mafintosh/ts-oneof
  • e8c30d5 Add support for "oneOf" to TypeScript typings
  • 7160756 Merge pull request #167 from mafintosh/ts-required
  • Additional commits viewable in compare view </details> <details> <summary>Maintainer changes</summary>

This version was pushed to npm by linusu, a new releaser for is-my-json-valid since your current version. </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

</details>

+16 -5

0 comment

1 changed file

dependabot[bot]

pr closed time in 2 months

PR closed saadq/node-latex

Bump js-yaml from 3.8.2 to 3.13.1 dependencies

Bumps js-yaml from 3.8.2 to 3.13.1. <details> <summary>Changelog</summary>

Sourced from js-yaml's changelog.

3.13.1 / 2019-04-05

  • Fix possible code execution in (already unsafe) .load(), #480.

3.13.0 / 2019-03-20

  • Security fix: safeLoad() can hang when arrays with nested refs used as key. Now throws exception for nested arrays. #475.

3.12.2 / 2019-02-26

  • Fix noArrayIndent option for root level, #468.

3.12.1 / 2019-01-05

  • Added noArrayIndent option, #432.

3.12.0 / 2018-06-02

  • Support arrow functions without a block statement, #421.

3.11.0 / 2018-03-05

  • Fix dump in bin/octal/hex formats for negative integers, #399.
  • Add arrow functions suport for !!js/function.

3.10.0 / 2017-09-10

  • Fix condenseFlow output (quote keys for sure, instead of spaces), #371, #370.
  • Dump astrals as codepoints instead of surrogate pair, #368.

3.9.1 / 2017-07-08

  • Ensure stack is present for custom errors in node 7.+, #351.

</tr></table> ... (truncated) </details> <details> <summary>Commits</summary>

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

</details>

+12 -8

0 comment

1 changed file

dependabot[bot]

pr closed time in 2 months

pull request commentsaadq/node-latex

add capacity to use relative paths in options

Thanks a lot for the improvements @paultopia! Just published v2.6.1 with your changes :)

paultopia

comment created time in 2 months

push eventsaadq/node-latex

Paul Gowder

commit sha da67a726dc6a6f8fda0aaeada1caa30c4c88f725

add capacity to use relative paths in options (#27) * add capacity to use relative paths in options * resolve path for user log too

view details

push time in 2 months

PR merged saadq/node-latex

add capacity to use relative paths in options

Permits users to pass relative paths to options.inputs and options.fonts; closes #26 :-)

+12 -5

2 comments

2 changed files

paultopia

pr closed time in 2 months

issue closedsaadq/node-latex

Support relative paths in options?

Hi there,

Would it be terribly difficult to have the options support relative paths? I'm trying to include a font in a complicated build that involves using a mustache template to generate a tex file and then building it with node-latex, but having to supply an absolute path for the fonts directory in the options is totally blowing up the build process. If there isn't some complex latex-related reason why this won't work, I'm happy to try to implement it myself if you're interested...

closed time in 2 months

paultopia

pull request commentsaadq/node-latex

add capacity to use relative paths in options

Awesome, thanks a lot! So sorry, I just realized that another option that it would be a good idea to resolve is options.errorLogs. Would you mind updating the PR to include that?

It should always be a string, so it could be handled in one of two ways.

Option 1: Here we would want to resolve it only if it is not undefined

Option 2: We just resolve the userLogPath it where it is actually used.

Either way would be fine, lmk if you would be okay with doing this, otherwise I can merge this as-is and then do a followup change.

paultopia

comment created time in 2 months

issue commentsaadq/node-latex

Support relative paths in options?

Hey Paul,

I don't think there is a good reason why the resolve isn't done on the library side rather than making the user do it.

I would actually prefer having this done on the library side to make it more ergonomic for people to use... I also agree with your implementation notes, if it is a string, we just resolve it or if it is an array we can map over each path and resolve each one.

My preference would be to create a function above the joinPaths function called resolvePaths which will take in a string or array as input and then return the resolved paths as described above.

Then it would just be a matter of changing

const inputs = options.inputs || tempPath

to

const inputs = options.inputs ? resolvePaths(options.inputs) : tempPath

and same thing for the options.fonts probably...

Let me know if that sounds good. I'd be very happy to get a PR for this, but otherwise lmk if you'd rather not do it and I can take care of it.

paultopia

comment created time in 2 months

more