profile
viewpoint

push eventdenoland/rusty_v8

Bartek Iwańczuk

commit sha 2cfb80e174f377c471a25cce27eb6fd9609c4ecd

Add v8::Function (#57)

view details

push time in an hour

PR merged denoland/rusty_v8

Add v8::Function
+237 -1

1 comment

7 changed files

bartlomieju

pr closed time in an hour

issue commentdenoland/deno

release assets is not a executable file

@lucacasonato Oh - yes that's what I thought. I don't use Windows so based on the above comments I thought maybe tar support was added. I'm fine with switching to zip for everyone. It's annoying to have two types of packages.

axetroy

comment created time in an hour

Pull request review commentdenoland/deno_install

feat: Support DENO_INSTALL in the powershell installer

 if (!(Get-Module PSScriptAnalyzer -ListAvailable)) { # Lint. Invoke-ScriptAnalyzer *.ps1 -EnableExit -Exclude PSAvoidAssignmentToAutomaticVariable -$BinDir = if ($IsWindows) {-  "$Home\.deno\bin"+# Test that we can install the latest version at the default location.+$env:DENO_INSTALL = ""+.\install.ps1+if ($IsWindows) {+  ~\.deno\bin\deno.exe --version } else {-  "$Home/.deno/bin"+  ~/.local/bin/deno --version } -# Test we can install a specific version.-Remove-Item $BinDir -Recurse -Force -ErrorAction SilentlyContinue+# Test that we can install a specific version at a custom location.+$env:DENO_INSTALL = if ($IsWindows) {+  "$Home\deno-0.13.0"+} else {+  "$Home/deno-0.13.0"+} .\install.ps1 v0.13.0 $DenoVersion = if ($IsWindows) {-  deno --version+  ~\deno-0.13.0\bin\deno.exe --version } else {-  ~/.deno/bin/deno --version+  ~/deno-0.13.0/bin/deno --version } if (!($DenoVersion -like '*0.13.0*')) {   throw $DenoVersion }--# Test we can install the latest version.

why remove this?

nayeemrmn

comment created time in an hour

push eventdenoland/deno_install

木杉

commit sha 7bdb161ab57958adfb2410c38a2bdb44c0e7f611

Add documents to manage multiple versions on Windows with Scoop (#91)

view details

push time in an hour

push eventdenoland/deno_website2

Rafał Pocztarski

commit sha 0f2ce2f34a08bcb2686dd302d8d688dae8f938a3

Add rand module (#139)

view details

push time in 2 hours

PR merged denoland/deno_website2

Add rand module

This PR adds rand module for easy access to random numbers:

  • https://github.com/rsp/deno-rand
+5 -0

0 comment

1 changed file

rsp

pr closed time in 2 hours

push eventdenoland/deno

AleksandrukTad

commit sha 31ddfd5a42d658b92e954e44d3326a8e37ac9198

fix: decoding uri in file_server (#3187)

view details

push time in 16 hours

PR merged denoland/deno

Bug/decoding uri

Hey its my first pr to open source project, let me know if I have to do some additional stuff. Was not able to test it with actual files, but now if you go to 0.0.0.0:4500/test test.txt fsPath will be with space not %20.

Fixes #3164 <!-- Before submitting a PR read https://deno.land/manual.html#contributing -->

+16 -2

14 comments

3 changed files

AleksandrukTad

pr closed time in 16 hours

issue closeddenoland/deno

[std] File server example can not handle url encoded characters

https://deno.land/std/http/file_server.ts can not handle urls like /test%20file.txt - it does not seem to parse URL encoded characters like %20.

closed time in 16 hours

lucacasonato

push eventdenoland/rusty_v8

Bartek Iwańczuk

commit sha b698e2fce339696ddd57fe08790f5e60d7969aa1

add v8::Object (#55)

view details

push time in a day

PR merged denoland/rusty_v8

add v8::Object
+136 -3

0 comment

6 changed files

bartlomieju

pr closed time in a day

issue commentdenoland/deno

Cannot work on Azure Web Apps (Windows Server 2016)

Hmm even FOLDERID_Profile isn't set Deno shouldn't panic.

horihiro

comment created time in a day

Pull request review commentdenoland/rusty_v8

add v8::Object

 fn exception() {   });   isolate.exit(); }++#[test]+fn object() {+  setup();+  let mut params = v8::Isolate::create_params();+  params.set_array_buffer_allocator(+    v8::array_buffer::Allocator::new_default_allocator(),+  );+  let mut isolate = v8::Isolate::new(params);+  let mut locker = v8::Locker::new(&mut isolate);+  v8::HandleScope::enter(&mut locker, |scope| {+    let mut context = v8::Context::new(scope);+    context.enter();+    let null = new_null(scope);+    // TODO: safer casts.+    let null: v8::Local<v8::Value> =+        unsafe { std::mem::transmute_copy(&null) };++    // TODO: safer casts.+    let n1: Local<v8::Name> = unsafe { std::mem::transmute_copy(&v8::String::new(scope, "a", v8::NewStringType::Normal).unwrap()) };+    let n2: Local<v8::Name> = unsafe { std::mem::transmute_copy(&v8::String::new(scope, "b", v8::NewStringType::Normal).unwrap()) };+    let names = vec![n1, n2];+    // TODO: safer casts.+    let v1: v8::Local<v8::Value> = unsafe { std::mem::transmute_copy(&v8::Number::new(scope, 1.0)) };+    let v2: v8::Local<v8::Value> = unsafe { std::mem::transmute_copy(&v8::Number::new(scope, 2.0)) };+    let values = vec![v1, v2];

Can you pull the constructors out of the unsafe block?

Also rather than // TODO: safer casts put

// TODO Safer casts https://github.com/denoland/rusty_v8/issues/51
bartlomieju

comment created time in a day

push eventdenoland/rusty_v8

Bartek Iwańczuk

commit sha 41e1f14ab5a5d4c4379f3f5b02f9d39419f49269

add v8::JSON (#54)

view details

push time in a day

PR merged denoland/rusty_v8

add v8::JSON
+88 -0

0 comment

5 changed files

bartlomieju

pr closed time in a day

PR opened denoland/deno

Disable flaky plugin test on windows

<!-- Before submitting a PR read https://deno.land/manual.html#contributing -->

+2 -0

0 comment

1 changed file

pr created time in a day

create barnchry/deno

branch : disable_flaky

created branch time in a day

Pull request review commentdenoland/deno

file_server prints errors in console

 test(async function serveFallback(): Promise<void> {     killFileServer();   } });++test(async function servePermissionDenied(): Promise<void> {+  const deniedServer = Deno.run({+    args: [Deno.execPath(), "run", "--allow-net", "http/file_server.ts"],+    stdout: "null",+    stderr: "piped"+  });++  const curl = Deno.run({+    args: ["curl", "http://localhost:4500/"],+    stdout: "null"+  });

I don't think the tests should depend on curl. Can you use fetch instead?

zhmushan

comment created time in a day

issue commentdenoland/deno

Flag order error

We could require that script args are placed after -- so it would be

deno -A https://deno.land/std/http/file_server.ts -- /etc

This would allow for better error checking of the flags...

Soremwar

comment created time in a day

issue openeddenoland/deno

plugin test is flaky on windows?

https://github.com/denoland/deno/pull/3470/checks?check_run_id=340389213

2019-12-09T16:52:40.7820723Z test basic ... FAILED
2019-12-09T16:52:40.7820950Z 
2019-12-09T16:52:40.7821938Z failures:
2019-12-09T16:52:40.7822131Z 
2019-12-09T16:52:40.7822526Z ---- basic stdout ----
2019-12-09T16:52:40.7822888Z target_dir D:\a\deno\deno\target\release
2019-12-09T16:52:40.7823084Z target_dir D:\a\deno\deno\target\release
2019-12-09T16:52:40.7823290Z stdout Hello from plugin. data: test | zero_copy: test
2019-12-09T16:52:40.7823496Z Plugin Sync Response: test
2019-12-09T16:52:40.7824000Z 
2019-12-09T16:52:40.7824961Z stderr 
2019-12-09T16:52:40.7825174Z 
2019-12-09T16:52:40.7825352Z #
2019-12-09T16:52:40.7825549Z # Fatal error in , line 0
2019-12-09T16:52:40.7825745Z # ignored
2019-12-09T16:52:40.7825933Z #
2019-12-09T16:52:40.7826118Z #
2019-12-09T16:52:40.7826282Z #
2019-12-09T16:52:40.7826478Z #FailureMessage Object: 0000008B0EDFD330
2019-12-09T16:52:40.7826848Z ==== C stack trace ===============================
2019-12-09T16:52:40.7827031Z 
2019-12-09T16:52:40.7827264Z 	v8::base::debug::StackTrace::StackTrace [0x00007FF6C68D499B+27]
2019-12-09T16:52:40.7827511Z 	v8::platform::DefaultPlatform::GetStackTracePrinter [0x00007FF6C6726317+55]
2019-12-09T16:52:40.7827724Z 	V8_Fatal [0x00007FF6C6724DB9+217]
2019-12-09T16:52:40.7827936Z 	v8::internal::GlobalBackingStoreRegistry::Register [0x00007FF6C6832689+441]
2019-12-09T16:52:40.7828137Z 	v8::ArrayBuffer::GetBackingStore [0x00007FF6C6715636+262]
2019-12-09T16:52:40.7828350Z 	deno::Send [0x00007FF6C672110C+284]
2019-12-09T16:52:40.7828564Z 	v8::internal::FunctionCallbackArguments::Call [0x00007FF6C6AE557D+589]
2019-12-09T16:52:40.7828784Z 	v8::internal::Builtins::InvokeApiFunction [0x00007FF6C6AE49CA+2378]
2019-12-09T16:52:40.7829031Z 	v8::internal::Builtin_HandleApiCall [0x00007FF6C6AE3FFC+1020]
2019-12-09T16:52:40.7829248Z 	v8::internal::Builtin_HandleApiCall [0x00007FF6C6AE3C47+71]
2019-12-09T16:52:40.7829447Z 	Builtins_CEntry_Return1_DontSaveFPRegs_ArgvOnStack_BuiltinExit [0x00007FF6C695559D+61]
2019-12-09T16:52:40.7829671Z 	Builtins_InterpreterEntryTrampoline [0x00007FF6C68E125B+187]
2019-12-09T16:52:40.7829888Z 	Builtins_InterpreterEntryTrampoline [0x00007FF6C68E125B+187]
2019-12-09T16:52:40.7830093Z 	Builtins_InterpreterEntryTrampoline [0x00007FF6C68E125B+187]
2019-12-09T16:52:40.7830297Z 	Builtins_InterpreterEntryTrampoline [0x00007FF6C68E125B+187]
2019-12-09T16:52:40.7830502Z 	Builtins_InterpreterEntryTrampoline [0x00007FF6C68E125B+187]
2019-12-09T16:52:40.7830685Z 	Builtins_GeneratorPrototypeNext [0x00007FF6C6913072+146]
2019-12-09T16:52:40.7830888Z 	Builtins_JSEntryTrampoline [0x00007FF6C68DEADE+94]
2019-12-09T16:52:40.7831220Z 	Builtins_JSEntry [0x00007FF6C68DE6CC+204]
2019-12-09T16:52:40.7831476Z 	v8::internal::Execution::Call [0x00007FF6C67C7AF6+1062]
2019-12-09T16:52:40.7831688Z 	v8::internal::Execution::Call [0x00007FF6C67C77C3+243]
2019-12-09T16:52:40.7831891Z 	v8::internal::SourceTextModule::ExecuteModule [0x00007FF6C67CFA3F+287]
2019-12-09T16:52:40.7832117Z 	v8::internal::SourceTextModule::InnerModuleEvaluation [0x00007FF6C67CF27F+1071]
2019-12-09T16:52:40.7832338Z 	v8::internal::SourceTextModule::Evaluate [0x00007FF6C67CEDB2+146]
2019-12-09T16:52:40.7832567Z 	v8::internal::SourceTextModule::EvaluateMaybeAsync [0x00007FF6C67CEB5E+302]
2019-12-09T16:52:40.7832785Z 	v8::internal::Module::Evaluate [0x00007FF6C67CA905+101]
2019-12-09T16:52:40.7832990Z 	v8::Module::Evaluate [0x00007FF6C6711226+486]
2019-12-09T16:52:40.7833169Z 	deno_mod_evaluate [0x00007FF6C670C206+230]
2019-12-09T16:52:40.7833381Z 	ZN4deno7isolate7Isolate12mod_evaluate17hcc2f0fdc8c14dcb6E [0x00007FF6C662899E+30]
2019-12-09T16:52:40.7833621Z 	ZN80_$LT$std..future..GenFuture$LT$T$GT$$u20$as$u20$core..future..future..Future$GT$4poll17h4a15c2b98a574942E [0x00007FF6C625DCDB+1963]
2019-12-09T16:52:40.7833877Z 	ZN80_$LT$std..future..GenFuture$LT$T$GT$$u20$as$u20$core..future..future..Future$GT$4poll17hb38b650467cbede1E [0x00007FF6C625FE54+1044]
2019-12-09T16:52:40.7834127Z 	ZN97_$LT$futures_util..compat..compat03as01..Compat$LT$Fut$GT$$u20$as$u20$futures..future..Future$GT$4poll17h4d9b699aa4581661E [0x00007FF6C61A4F33+83]
2019-12-09T16:52:40.7834500Z 	ZN7futures6future5chain22Chain$LT$A$C$B$C$C$GT$4poll17hd679173e7149e6ecE [0x00007FF6C610EF11+97]
2019-12-09T16:52:40.7834722Z 	ZN7futures9task_impl3std3set17hc40a385e2375be91E [0x00007FF6C6602280+96]
2019-12-09T16:52:40.7834924Z 	ZN3std9panicking3try7do_call17hcb4923d650ed8541E.llvm.5887183077164218732 [0x00007FF6C6601F35+149]
2019-12-09T16:52:40.7835175Z 	panic_unwind::__rust_maybe_catch_panic [0x00007FF6C66F4272+34] (/rustc/4560ea788cb760f0a34127156c78e2552949f734\/src\libpanic_unwind\lib.rs:80)
2019-12-09T16:52:40.7835400Z 	ZN16tokio_threadpool4task4Task3run17hb52befe50050fc40E [0x00007FF6C660B8B5+245]
2019-12-09T16:52:40.7835623Z 	ZN16tokio_threadpool6worker6Worker3run17h62be210ba81dc782E [0x00007FF6C6600136+3366]
2019-12-09T16:52:40.7835913Z 	ZN16tokio_threadpool6worker6Worker3run17h62be210ba81dc782E [0x00007FF6C65FF813+1027]
2019-12-09T16:52:40.7836620Z 	ZN3std6thread5local17LocalKey$LT$T$GT$4with17h602f66a0b54c5d82E [0x00007FF6C65E10D9+153]
2019-12-09T16:52:40.7836991Z error: test failed, to rerun pass '-p test_plugin --test integration_tests'
2019-12-09T16:52:40.7837134Z 	ZN3std6thread5local17LocalKey$LT$T$GT$4with17h952ea0e63369e2c8E [0x00007FF6C65E1354+212]
2019-12-09T16:52:40.7837397Z 	ZN96_$LT$tokio_threadpool..park..boxed..BoxedPark$LT$T$GT$$u20$as$u20$tokio_executor..park..Park$GT$6unpark17ha9dd4ebec68c4809E [0x00007FF6C65E87E0+224]
2019-12-09T16:52:40.7837642Z 	ZN3std6thread5local17LocalKey$LT$T$GT$4with17h31781bbcad31b5fbE [0x00007FF6C6607CD3+147]
2019-12-09T16:52:40.7837871Z 	ZN3std6thread5local17LocalKey$LT$T$GT$4with17h9dd6dab994fa9906E [0x00007FF6C6608257+151]
2019-12-09T16:52:40.7838103Z 	ZN3std10sys_common9backtrace28__rust_begin_short_backtrace17h1bca0a7c71f16f26E [0x00007FF6C660AD21+241]
2019-12-09T16:52:40.7838317Z 	ZN3std9panicking3try7do_call17hc8e4e3ad30f41392E.llvm.5887183077164218732 [0x00007FF6C6601E8F+31]
2019-12-09T16:52:40.7838698Z 	panic_unwind::__rust_maybe_catch_panic [0x00007FF6C66F4272+34] (/rustc/4560ea788cb760f0a34127156c78e2552949f734\/src\libpanic_unwind\lib.rs:80)
2019-12-09T16:52:40.7838941Z 	ZN3std6thread7Builder5spawn17he4f870f7a6333807E [0x00007FF6C6602B90+992]
2019-12-09T16:52:40.7839191Z 	alloc::boxed::{{impl}}::call_once<(),FnOnce<()>> [0x00007FF6C66D0817+87] (/rustc/4560ea788cb760f0a34127156c78e2552949f734\src\liballoc\boxed.rs:922)
2019-12-09T16:52:40.7839448Z 	std::sys::windows::thread::{{impl}}::new::thread_start [0x00007FF6C66F22F7+119] (/rustc/4560ea788cb760f0a34127156c78e2552949f734\/src\libstd\sys\windows\thread.rs:47)
2019-12-09T16:52:40.7839671Z 	BaseThreadInitThunk [0x00007FFA68647974+20]
2019-12-09T16:52:40.7839872Z 	RtlUserThreadStart [0x00007FFA6B3AA271+33]
2019-12-09T16:52:40.7840014Z 
2019-12-09T16:52:40.7840238Z thread 'basic' panicked at 'assertion failed: output.status.success()', test_plugin\tests\integration_tests.rs:36:3
2019-12-09T16:52:40.7840478Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-12-09T16:52:40.7840639Z 
2019-12-09T16:52:40.7840810Z 
2019-12-09T16:52:40.7840986Z failures:
2019-12-09T16:52:40.7841181Z     basic
2019-12-09T16:52:40.7841340Z 
2019-12-09T16:52:40.7841528Z test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
2019-12-09T16:52:40.7841702Z 
2019-12-09T16:52:41.0053770Z ##[error]Process completed with exit code 1.
2019-12-09T16:52:41.0106046Z Cleaning up orphan processes
2019-12-09T16:52:41.0892995Z Terminate orphan process: pid (3560) (sccache)

created time in a day

Pull request review commentdenoland/deno

std: add `pluginFilename` function

+import { test } from "../testing/mod.ts";

Please add

// Copyright 2018-2019 the Deno authors. All rights reserved. MIT license.
afinch7

comment created time in a day

issue commentdenoland/deno

release assets is not a executable file

Yeah - we can switch to tar for all platforms. I agree it’s probably better.

axetroy

comment created time in 2 days

delete branch ry/rusty_v8

delete branch : deref_string_value

delete time in 2 days

push eventdenoland/rusty_v8

Ryan Dahl

commit sha 774e34adf1e835d4a8cead2ec5efced4aef24329

Deref String to Value

view details

push time in 2 days

PR merged denoland/rusty_v8

Deref String to Value
+9 -0

0 comment

1 changed file

ry

pr closed time in 2 days

PR opened denoland/rusty_v8

Deref String to Value
+9 -0

0 comment

1 changed file

pr created time in 2 days

create barnchry/rusty_v8

branch : deref_string_value

created branch time in 2 days

issue openeddenoland/rusty_v8

Need automated conversion for Local<String> to Local<Value>

Here is an attempted solution which doesn't quite work.

/// For example, to allow automated conversion from Local<String> to
/// Local<Value>
impl<'sc, T, U> From<Local<'sc, T>> for Local<'sc, U>
where
  T: Deref<Target = U>,
{
  fn from(v: Local<'sc, T>) -> Local<'sc, U> {
    unsafe { std::mem::transmute(v) }
  }
}

In C++ this is done by this bit of code: https://github.com/v8/v8/blob/63da8397bc967232f91fea07b1861a50d20ca717/include/v8.h#L192-L201

created time in 2 days

push eventry/rusty_v8

Ryan Dahl

commit sha 03e2a011da80c7e21cfdb74e6a4820ba4a52a2af

fix

view details

push time in 2 days

push eventry/rusty_v8

Bert Belder

commit sha ada75e81d19320715c6a1534139d425c719c1e78

Turn 'symbol_level = 1' back on (#47)

view details

Ryan Dahl

commit sha 0c904167d3ba70cd7a87969b98c5f58fbe9291e5

WIP ScriptOrigin constructor

view details

Ryan Dahl

commit sha 7f4d108d31b05d1be0b38a1a6eab9b2f2cd02098

x

view details

Ryan Dahl

commit sha 8f66fedb034e8a0fbc31e26edfb78e7d446f59c7

wip

view details

push time in 2 days

push eventbartlomieju/deno

木杉

commit sha cfa4f540baac5beaf168de3e818c882ccbd95136

better html for file_server (#3423)

view details

Andy Finch

commit sha 00844b41428a73d3fb3fd06ba3e564b4e1e3c63c

fix some typos in permissions (#3436)

view details

Ry Dahl

commit sha ee013102ff4ce75c1068b6e771ed120fc32a849d

remove duplicated argv member from ThreadSafeGlobalState (#3433)

view details

Nayeem Rahman

commit sha 91da410fc3bfde76c3c8930c6f8bfd4d5f9b974e

feat: Add --no-remote, rename --no-fetch to --cached-only (#3417)

view details

Kevin (Kun) "Kassimo" Qian

commit sha 32937251315493ef2c3b42dd29340e8a34501aa4

Timer/microtask ordering fix (#3439)

view details

Christian Moritz

commit sha 214b3eb29aa9cce8a55a247b4bd816cbd19bfe6b

fix depot_tools on macOS Catalina by upgrading it to 23247b9 (#3441) Fixes: #3440 Fixes: #3153

view details

Andy Finch

commit sha 7c3b9b4f4f2f4ec8fdeb0e77bb853fd22ffaa476

feat: first pass at native plugins (#3372)

view details

Ry Dahl

commit sha e6228bc3c4d974cf9e67b00e0a14a09f94d8ef5e

Revert "Synchronize deno and deno_std versions" (#3446) Preventing release v0.26.0 This reverts commit 81efa9d938aa169d16e67762d336d75738375cd6.

view details

Ryan Dahl

commit sha 0ce9011edc8ec53df47e3103ecca3069d385ce37

v0.26.0

view details

Bartek Iwańczuk

commit sha e02029c602cbef4c2c63d53a9d6bdab3ab2130fe

fix isolate tests (#3459) Some tests were silently failing after #3358 and #3434 because pool.spawn_ok was used which doesn't panic on errors. For reference, the failure looked like this: thread '<unnamed>' panicked at 'assertion failed: match isolate.poll_unpin(cx) { Poll::Ready(Ok(_)) => true, _ => false, }', core/isolate.rs:1408:7

view details

Luca Casonato

commit sha 7144bbed34ee3d867c76a88398e6d73843385b34

fix: plugin ops should change op count metrics (#3455)

view details

Kevin (Kun) "Kassimo" Qian

commit sha 50b6907bc332315eeb13c05bf687b990bc8dd936

Replace deprecated GetContent with GetBackingStore (#3458)

view details

木杉

commit sha 90c5aadbca8b47fc43bd3ece80e007b1b546c402

fix(installer): installs to the wrong directory on Windows (#3462) Close: #3443

view details

Ryan Dahl

commit sha 2d5609844c72c798bbc470897241ea2916c17404

Merge branch 'master' into upgrade-tokio_deno_core_take2

view details

Ryan Dahl

commit sha 5426908e5b866613461748ddb79af54fde5e00b4

Use tokio 0.2

view details

push time in 2 days

push eventdenoland/deno_website2

迷渡

commit sha 963079ff9f470b0bd92ea600b913dfdb12a3df2c

module name must not contain dashes (#137)

view details

push time in 2 days

PR merged denoland/deno_website2

module name must not contain dashes

cc @paulmillr

+2 -2

1 comment

2 changed files

justjavac

pr closed time in 2 days

push eventdenoland/deno_website2

迷渡

commit sha 4308c36da5a0b4ae028e0f7ee5e573435ec408e7

sort database.json (#134)

view details

push time in 3 days

PR merged denoland/deno_website2

sort database.json
+35 -30

2 comments

2 changed files

justjavac

pr closed time in 3 days

delete branch denoland/rusty_v8

delete branch : gn

delete time in 3 days

PR closed denoland/rusty_v8

Undo all .gn changes
+24 -5

1 comment

1 changed file

ry

pr closed time in 3 days

pull request commentdenoland/rusty_v8

Undo all .gn changes

closed in favor of #47

ry

comment created time in 3 days

PR opened denoland/rusty_v8

Undo all .gn changes
+24 -5

0 comment

1 changed file

pr created time in 3 days

create barnchdenoland/rusty_v8

branch : gn

created branch time in 3 days

pull request commentdenoland/rusty_v8

Fix mac build

Let's just revert all the changes I made to .gn

They were arrived through much trial and error and I was hoping it could just be simplified - but apparently not. We can try to simplify in the future. It's really not so important right now.

ry

comment created time in 3 days

issue commentdenoland/deno

Rust crates cannot be published to crates.io

The problem is only with the windows crate... as a short term solution we could remove support for windows crate and publish 0.26

ry

comment created time in 3 days

PR opened denoland/rusty_v8

WIP ScriptOrigin constructor
+60 -2

0 comment

4 changed files

pr created time in 3 days

create barnchry/rusty_v8

branch : script_origin

created branch time in 3 days

pull request commentdenoland/rusty_v8

add v8::Context::Scope

but it is not obvious how to do it in rust without violating safety rules.

I hadn't considered that... That's a good reason to keep them.

bartlomieju

comment created time in 3 days

delete branch ry/deno_website2

delete branch : choco

delete time in 3 days

push eventdenoland/deno_website2

Ry Dahl

commit sha e27631dd5fc5aad7ccd357efe8072cdec589b124

update home page links for installation (#135)

view details

push time in 3 days

PR merged denoland/deno_website2

update home page links for installation
+21 -22

0 comment

1 changed file

ry

pr closed time in 3 days

PR opened denoland/deno_website2

update home page links for installation
+21 -22

0 comment

1 changed file

pr created time in 3 days

create barnchry/deno_website2

branch : choco

created branch time in 3 days

pull request commentdenoland/rusty_v8

add v8::Context::Scope

I'm not sure yet I want to continue using closures for controlling the lifetime of C++ RAII objects

I'm also in favor of removing the closure helpers for RAII. It seems to go against the principal of exposing a Rust V8 API as close as possible to the C++ API. Closures for lifetime management is neither used in C++, nor is it particularly Rusty.

bartlomieju

comment created time in 3 days

pull request commentdenoland/deno

(std/file_server): better template

This change reduced the size of the file_server bundle by half! I suppose that's because it no longer needs the content-type database?

Screen Shot 2019-12-07 at 4 27 22 PM

zhmushan

comment created time in 3 days

push eventdenoland/deno

Kevin (Kun) "Kassimo" Qian

commit sha 50b6907bc332315eeb13c05bf687b990bc8dd936

Replace deprecated GetContent with GetBackingStore (#3458)

view details

push time in 3 days

PR merged denoland/deno

Replace deprecated GetContent with GetBackingStore

Ref: https://docs.google.com/document/d/1sTc_jRL87Fu175Holm5SV0kajkseGl2r8ifGY76G35k/edit Ref: https://chromium-review.googlesource.com/c/v8/v8/+/1859628 Ref: https://github.com/nodejs/node/pull/30339

+4 -4

0 comment

2 changed files

kevinkassimo

pr closed time in 3 days

issue commentdenoland/deno

release assets is not a executable file

I'm not sure what error you're experiencing, but it works for me.

~/Downloads> gunzip deno_osx_x64.gz
~/Downloads> ls -lh deno_osx_x64
-rw-r--r--  1 rld  staff    43M Dec  7 15:29 deno_osx_x64
~/Downloads> chmod u+x deno_osx_x64
~/Downloads> ./deno_osx_x64 -V
deno 0.26.0
axetroy

comment created time in 3 days

issue commentdenoland/deno

Give plugins access to json_op helpers

I guess we could move those helper functions into the core deno crate - they would be easier to access there.

lucacasonato

comment created time in 3 days

push eventdenoland/deno_install

Nayeem Rahman

commit sha 654d0ea30950d7540e1dae65e4f9476909cc50fd

Default DENO_INSTALL to $HOME/.local (#89)

view details

push time in 3 days

PR merged denoland/deno_install

Default DENO_INSTALL to $HOME/.local

Closes #40.

~To make DENO_INSTALL compatible with XDG_BIN_HOME, it now points to the binary directory directly rather than having bin appended to it. i.e. Installing to /usr/local/bin required DENO_INSTALL=/usr/local, now it would be DENO_INSTALL=/usr/local/bin.~

cc @ry

+11 -11

4 comments

3 changed files

nayeemrmn

pr closed time in 3 days

issue closeddenoland/deno_install

Change installation directory

Since https://github.com/denoland/deno/commit/e782ba1a6fd8342cddd961da9274dbd0244685d1 deno now stores cache files in platform dependent cache directories like $HOME/Library/Caches (mac).

Downloading the deno binary into $HOME/.deno/bin seems now inappropriate.

Where should it be installed?

cc @flying-sheep

closed time in 3 days

ry

pull request commentdenoland/deno_website2

sort database.json

While you're at it, maybe you can add a test to ensure it's always sorted in the future?

justjavac

comment created time in 3 days

Pull request review commentdenoland/deno_install

Default DENO_INSTALL to $HOME/.local

 else 	deno_uri="https://github.com/denoland/deno/releases/download/${1}/deno_${os}_x64.gz" fi -deno_install=${DENO_INSTALL:-$HOME/.deno}-bin_dir="${deno_install}/bin"+deno_install=${DENO_INSTALL:-$HOME/.local}+bin_dir=$deno_install/bin

Maybe leave the quotation marks? Without quotation marks maybe this breaks in the case that $deno_install has spaces in it

nayeemrmn

comment created time in 3 days

push eventdenoland/deno

Luca Casonato

commit sha 7144bbed34ee3d867c76a88398e6d73843385b34

fix: plugin ops should change op count metrics (#3455)

view details

push time in 3 days

PR merged denoland/deno

Wrap plugin ops in ThreadSafeState.core_op

Fixes #3454

+21 -1

0 comment

2 changed files

lucacasonato

pr closed time in 3 days

issue closeddenoland/deno

Plugin ops don't count towards op metrics

Ops that are dispatched by plugins don't count towards Deno.metrics. This is because they don't go through ThreadSafeState.core_op.

closed time in 3 days

lucacasonato

push eventdenoland/deno

Bartek Iwańczuk

commit sha e02029c602cbef4c2c63d53a9d6bdab3ab2130fe

fix isolate tests (#3459) Some tests were silently failing after #3358 and #3434 because pool.spawn_ok was used which doesn't panic on errors. For reference, the failure looked like this: thread '<unnamed>' panicked at 'assertion failed: match isolate.poll_unpin(cx) { Poll::Ready(Ok(_)) => true, _ => false, }', core/isolate.rs:1408:7

view details

push time in 3 days

PR merged denoland/deno

fix: isolate tests

Fixes Isolate tests as pointed by @kevinkassimo in Gitter.

I screwed it up during #3358 and #3434 because I used pool.spawn_ok which doesn't panic on errors.

+12 -96

0 comment

2 changed files

bartlomieju

pr closed time in 3 days

Pull request review commentdenoland/deno

fix: isolate tests

 pub mod tests {     assert_eq!(resolve_count.load(Ordering::SeqCst), 1);   } -  #[test]-  fn test_poll_async_immediate_ops() {

This test is just being removed?

bartlomieju

comment created time in 4 days

push eventdenoland/deno_website2

迷渡

commit sha c90bd90736859884d4d299db7fb7d4d6ba744edc

add murmurhash (#133)

view details

push time in 4 days

PR merged denoland/deno_website2

add murmurhash
+5 -0

0 comment

1 changed file

justjavac

pr closed time in 4 days

delete branch ry/rusty_v8

delete branch : primitives

delete time in 5 days

push eventdenoland/rusty_v8

Ryan Dahl

commit sha f9a29cf56c7f4b2fc4938d448a34cd223ae091e2

Add primitive constructors null, undefined, true, false

view details

Ryan Dahl

commit sha 7a233e277ea89f864a486734db56d490c66cc2ad

Add Value::{is_undefined, is_null, is_null_or_undefined}

view details

push time in 5 days

PR merged denoland/rusty_v8

Reviewers
Add primitive constructors null, undefined, true, false
+167 -5

0 comment

8 changed files

ry

pr closed time in 5 days

push eventry/rusty_v8

Ryan Dahl

commit sha 7693633320fb4a028862fea6b56aee76b41abc0b

Add primitive constructors null, undefined, true, false

view details

Ryan Dahl

commit sha 65c30dd209080be0ab5ec11ebd1cf37099878b54

Add Value::{is_undefined, is_null, is_null_or_undefined}

view details

push time in 5 days

push eventry/rusty_v8

Ry Dahl

commit sha 0430c43ec2835d7d77ac83fab482e4a6b0072299

status (#43)

view details

Ryan Dahl

commit sha e3618f693938bc1124486c61339d18e66072d19c

v0.0.10

view details

Ryan Dahl

commit sha d1020d4466af6f802d7ce19fb6b1cff26ab86954

Add primitive constructors null, undefined, true, false

view details

push time in 5 days

issue commentdenoland/deno_install

Change installation directory

$XDG_BIN_HOME sounds better

ry

comment created time in 5 days

issue openeddenoland/deno

Add documentation in std/manual.md about plugins

should have examples of both rust and ts code

created time in 5 days

push eventdenoland/deno_install

Nayeem Rahman

commit sha 7b3d3daf45de14d5b52f1a774ff7abe06534b5e9

fix: Don't use version as a subcommand (#88) Fix DENO_INSTALL example

view details

push time in 5 days

PR merged denoland/deno_install

fix: Don't use version as a subcommand

DENO_INSTALL example: Adds sudo, removes unnecessary version specification.

Edit: Whatever, I'll just make this about the version subcommand thing.

+12 -12

0 comment

3 changed files

nayeemrmn

pr closed time in 5 days

Pull request review commentdenoland/deno_install

fix: Don't use version as a subcommand

 asdf local deno 0.2.10   One application of this is a system-wide Shell installation to [`/opt/deno`](https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch03s13.html):    ```sh-  curl -fsSL https://deno.land/x/install/install.sh | DENO_INSTALL=/opt/deno sh -s v0.2.10+  curl -fsSL https://deno.land/x/install/install.sh | sudo DENO_INSTALL=/opt/deno sh

Maybe this directory should be changed to something more common like /usr/local/bin

nayeemrmn

comment created time in 5 days

delete branch denoland/rusty_v8

delete branch : release

delete time in 5 days

created tagdenoland/rusty_v8

tagv0.0.10

created time in 5 days

push eventdenoland/rusty_v8

Ryan Dahl

commit sha e3618f693938bc1124486c61339d18e66072d19c

v0.0.10

view details

push time in 5 days

PR merged denoland/rusty_v8

v0.0.10
+2 -2

0 comment

2 changed files

ry

pr closed time in 5 days

created tagdenoland/deno

tagv0.26.0

A secure JavaScript and TypeScript runtime

created time in 5 days

delete branch ry/deno

delete branch : bump-v0.26

delete time in 5 days

push eventdenoland/deno

Ryan Dahl

commit sha 0ce9011edc8ec53df47e3103ecca3069d385ce37

v0.26.0

view details

push time in 5 days

PR merged denoland/deno

v0.26.0

<!-- Before submitting a PR read https://deno.land/manual.html#contributing -->

+26 -15

1 comment

5 changed files

ry

pr closed time in 5 days

PR opened denoland/rusty_v8

v0.0.10
+2 -2

0 comment

2 changed files

pr created time in 5 days

create barnchdenoland/rusty_v8

branch : release

created branch time in 5 days

push eventry/deno

Ryan Dahl

commit sha 098124b81be74922851a56d322653d4a0017e6e2

v0.26.0

view details

push time in 5 days

push eventry/deno

Ry Dahl

commit sha e6228bc3c4d974cf9e67b00e0a14a09f94d8ef5e

Revert "Synchronize deno and deno_std versions" (#3446) Preventing release v0.26.0 This reverts commit 81efa9d938aa169d16e67762d336d75738375cd6.

view details

Ryan Dahl

commit sha 5b97481ebd5f7c55a3e60609eb539ed6397940bd

v0.26.0

view details

push time in 5 days

delete branch ry/deno

delete branch : revert-3415

delete time in 5 days

push eventdenoland/deno

Ry Dahl

commit sha e6228bc3c4d974cf9e67b00e0a14a09f94d8ef5e

Revert "Synchronize deno and deno_std versions" (#3446) Preventing release v0.26.0 This reverts commit 81efa9d938aa169d16e67762d336d75738375cd6.

view details

push time in 5 days

PR merged denoland/deno

Revert "Synchronize deno and deno_std versions"

This change is preventing the release of v0.26.0 because it during the bump commit the URL https://deno.land/std@v0.26.0/ does not yet exist. We need to solve this some other way. For now I will just update the links to v0.25.0 so I can get the release out.

Ref https://github.com/denoland/deno/pull/3445 Ref #3415 cc @axetroy

+1 -6

2 comments

1 changed file

ry

pr closed time in 5 days

push eventdenoland/rusty_v8

Ry Dahl

commit sha 0430c43ec2835d7d77ac83fab482e4a6b0072299

status (#43)

view details

push time in 5 days

PR merged denoland/rusty_v8

status
+3 -1

0 comment

1 changed file

ry

pr closed time in 5 days

push eventry/rusty_v8

Ryan Dahl

commit sha 36a052ac47e76a66f07d3c5a2df6862463465ff5

typo

view details

push time in 5 days

PR opened denoland/rusty_v8

status
+2 -0

0 comment

1 changed file

pr created time in 5 days

more