profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/ry/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

denoland/deno 78003

A secure JavaScript and TypeScript runtime

ry/deno 412

ry/deno_typescript 31

To generate snapshots of TypeScript files during build.rs

ry/awesome-deno 17

🎉A curated list of awesome things related to Deno

ry/eecs151 12

http://inst.eecs.berkeley.edu/~eecs151/fa19/

denoland/terraform-deploy-provider 10

Terraform provider for Deno Deploy

ry/aws-appsync-chat 10

Real-Time Offline Ready Chat App written with GraphQL, AWS AppSync, & AWS Amplify

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

pull request commentdenoland/wpt.deno.land

fix: fix filtering of wpt results

What's the status of this PR, @kt3k? Please close if stale.

kt3k

comment created time in a day

PR closed denoland/deno

Reviewers
BREAKING(unstable): Structure Deno.emit() output, add Deno.emitBundle()

Closes #10770. Fixes #11141. Fixes #11206.

Makes Deno.emit() output code, source maps, declaration files etc. as a list of structured module entries instead of a dictionary of magical file names. Breaks out Deno.emitBundle() as a new API, since it has a different output structure.


Deno.emit()

console.log(
  await Deno.emit("https://deno.land/std@0.97.0/testing/asserts.ts", {
    compilerOptions: { declaration: true },
  }),
);

Before:

{
  files: {
    "https://deno.land/std@0.97.0/testing/_diff.ts.js.map": '{"version":3,"file":"_diff.js","sourceRoot":"","sources":["https://deno.land/std@0.97.0/testing/_dif...',
    "https://deno.land/std@0.97.0/testing/_diff.ts.js": 'export var DiffType;\n(function (DiffType) {\n    DiffType["removed"] = "removed";\n    DiffType["commo...',
    "https://deno.land/std@0.97.0/fmt/colors.ts.js.map": '{"version":3,"file":"colors.js","sourceRoot":"","sources":["https://deno.land/std@0.97.0/fmt/colors....',
    "https://deno.land/std@0.97.0/testing/asserts.ts.d.ts": '/// <amd-module name="https://deno.land/std@0.97.0/testing/asserts.ts" />\ninterface Constructor {\n  ...',
    "https://deno.land/std@0.97.0/testing/asserts.ts.js": 'import { bold, gray, green, red, stripColor, white } from "../fmt/colors.ts";\nimport { diff, DiffTyp...',
    "https://deno.land/std@0.97.0/fmt/colors.ts.d.ts": '/// <amd-module name="https://deno.land/std@0.97.0/fmt/colors.ts" />\ninterface Rgb {\n    r: number;\n...',
    "https://deno.land/std@0.97.0/fmt/colors.ts.js": "const noColor = globalThis.Deno?.noColor ?? true;\nlet enabled = !noColor;\nexport function setColorEn...",
    "https://deno.land/std@0.97.0/testing/asserts.ts.js.map": '{"version":3,"file":"asserts.js","sourceRoot":"","sources":["https://deno.land/std@0.97.0/testing/as...',
    "https://deno.land/std@0.97.0/testing/_diff.ts.d.ts": '/// <amd-module name="https://deno.land/std@0.97.0/testing/_diff.ts" />\nexport declare enum DiffType...'
  },
  // ...
}

After:

{
  modules: [
    {
      specifier: "https://deno.land/std@0.97.0/fmt/colors.ts",
      code: "const noColor = globalThis.Deno?.noColor ?? true;\nlet enabled = !noColor;\nexport function setColorEn...",
      map: '{"version":3,"file":"colors.js","sourceRoot":"","sources":["https://deno.land/std@0.97.0/fmt/colors....',
      declaration: '/// <amd-module name="https://deno.land/std@0.97.0/fmt/colors.ts" />\ninterface Rgb {\n    r: number;\n...'
    },
    {
      specifier: "https://deno.land/std@0.97.0/testing/asserts.ts",
      code: 'import { bold, gray, green, red, stripColor, white } from "../fmt/colors.ts";\nimport { diff, DiffTyp...',
      map: '{"version":3,"file":"asserts.js","sourceRoot":"","sources":["https://deno.land/std@0.97.0/testing/as...',
      declaration: '/// <amd-module name="https://deno.land/std@0.97.0/testing/asserts.ts" />\ninterface Constructor {\n  ...'
    },
    {
      specifier: "https://deno.land/std@0.97.0/testing/_diff.ts",
      code: 'export var DiffType;\n(function (DiffType) {\n    DiffType["removed"] = "removed";\n    DiffType["commo...',
      map: '{"version":3,"file":"_diff.js","sourceRoot":"","sources":["https://deno.land/std@0.97.0/testing/_dif...',
      declaration: '/// <amd-module name="https://deno.land/std@0.97.0/testing/_diff.ts" />\nexport declare enum DiffType...'
    }
  ],
  // ...
}

Deno.emitBundle()

Before:

console.log(
  await Deno.emit("https://deno.land/std@0.97.0/testing/asserts.ts", {
    bundle: "module",
  }),
);
{
  files: {
    "deno:///bundle.js.map": '{"version":3,"sources":["<https://deno.land/std@0.97.0/fmt/colors.ts>","<https://deno.land/std@0.97....',
    "deno:///bundle.js": "const noColor = globalThis.Deno?.noColor ?? true;\nlet enabled = !noColor;\nfunction code(open, close)..."
  },
  // ...
}

After:

console.log(
  await Deno.emitBundle("https://deno.land/std@0.97.0/testing/asserts.ts"),
);
{
  code: "const noColor = globalThis.Deno?.noColor ?? true;\nlet enabled = !noColor;\nfunction code(open, close)...",
  map: '{"version":3,"sources":["<https://deno.land/std@0.97.0/fmt/colors.ts>","<https://deno.land/std@0.97....',
  // ...
}

cc @kitsonk. This redoes #10767 with errors reported on the module entries instead of as diagnostics.

+769 -447

5 comments

26 changed files

nayeemrmn

pr closed time in a day

pull request commentdenoland/deno

BREAKING(unstable): Structure Deno.emit() output, add Deno.emitBundle()

@nayeemrmn We are looking into deprecating and removing Deno.emit because we don't want the runtime APIs to be so closely linked with TypeScript and nitty gritty compiler functionality. We would rather have Deno.emit be available as a userland API, likely utilizing deno_graph in wasm. That's all to say, I don't want to iterate further on a potentially-dead API right now. Thanks for the patch, but ideally this is done outside the runtime. Closing without merge.

nayeemrmn

comment created time in a day

push eventdenoland/deno

Ryan Dahl

commit sha 8923f6cb1023f1a6f55bf5629b7da1ab504b98ef

leave in poll_event_loop

view details

push time in a day

push eventdenoland/deno

Ryan Dahl

commit sha b7acdbf619f324a7e332a7e04be39a700c250733

fix

view details

push time in a day

push eventdenoland/deno

Ryan Dahl

commit sha c1100c92d0245cba5ac3aa1d261fc347ac17b3b5

strip_shebang

view details

push time in a day

push eventdenoland/deno

Ryan Dahl

commit sha 6c3b474b3232995fcab4196acf779e2a4ea988de

Revert "Remove unused properties from lsp" This reverts commit 36f407f5b57d072d5fa08ca7e5e92e3011ea1e44.

view details

push time in a day

PR opened denoland/deno

refactor: Remove unused code

<!-- Before submitting a PR, please read http://deno.land/manual/contributing

  1. Give the PR a descriptive title.

Examples of good title: - fix(std/http): Fix race condition in server - docs(console): Update docstrings - feat(doc): Handle nested reexports

Examples of bad title: - fix #7123 - update docs - fix bugs

  1. Ensure there is a related issue and it is referenced in the PR text.
  2. Ensure there are tests that cover the changes.
  3. Ensure cargo test passes.
  4. Ensure ./tools/format.js passes without changing files.
  5. Ensure ./tools/lint.js passes. -->
+4 -91

0 comment

6 changed files

pr created time in a day

create barnchdenoland/deno

branch : unused2

created branch time in a day

delete branch denoland/deno

delete branch : module_loader_op_state

delete time in a day

push eventdenoland/deno

Ryan Dahl

commit sha 9705efd419ffa05b0d88e788e0ceb77e38078449

refactor: Remove op_state parameter (#12202)

view details

push time in a day

PR merged denoland/deno

refactor: Remove op_state parameter

<!-- Before submitting a PR, please read http://deno.land/manual/contributing

  1. Give the PR a descriptive title.

Examples of good title: - fix(std/http): Fix race condition in server - docs(console): Update docstrings - feat(doc): Handle nested reexports

Examples of bad title: - fix #7123 - update docs - fix bugs

  1. Ensure there is a related issue and it is referenced in the PR text.
  2. Ensure there are tests that cover the changes.
  3. Ensure cargo test passes.
  4. Ensure ./tools/format.js passes without changing files.
  5. Ensure ./tools/lint.js passes. -->
+19 -67

0 comment

4 changed files

ry

pr closed time in a day

push eventdenoland/deno

Ryan Dahl

commit sha 01da1d0adc0d09d60eb765ac583be8108eb31e36

refactor: Rename ProgramState to ProcState (#12204) Move Arc into struct

view details

push time in a day

delete branch denoland/deno

delete branch : ProcState

delete time in a day

PR merged denoland/deno

refactor: Rename ProgramState to ProcState

And move the Arc inside the struct.

+284 -334

0 comment

13 changed files

ry

pr closed time in a day

PullRequestReviewEvent

push eventdenoland/deno

Ryan Dahl

commit sha 913692a1cf98041a538a13c03f9b9ad8fa0e6b05

remove another unnessary Arc

view details

push time in 2 days

Pull request review commentdenoland/deno

refactor: Rename ProgramState to ProcState

 use std::collections::HashSet; use std::env; use std::fs::File; use std::io::BufReader;+use std::ops::Deref; use std::sync::Arc;  /// This structure represents state of single "deno" program. /// /// It is shared by all created workers (thus V8 isolates).-pub struct ProgramState {+#[derive(Clone)]+pub struct ProcState(Arc<Inner>);

Why isn't it? Matches what we do in Deploy

ry

comment created time in 2 days

PullRequestReviewEvent

push eventdenoland/deno

Ryan Dahl

commit sha 80a9a37df1607c4713538c422309801e25024bff

refactor: Remove depreated Worker::execute_module (#12203)

view details

push time in 2 days

delete branch denoland/deno

delete branch : rm_execute_module

delete time in 2 days

PR merged denoland/deno

refactor: Remove depreated Worker::execute_module

<!-- Before submitting a PR, please read http://deno.land/manual/contributing

  1. Give the PR a descriptive title.

Examples of good title: - fix(std/http): Fix race condition in server - docs(console): Update docstrings - feat(doc): Handle nested reexports

Examples of bad title: - fix #7123 - update docs - fix bugs

  1. Ensure there is a related issue and it is referenced in the PR text.
  2. Ensure there are tests that cover the changes.
  3. Ensure cargo test passes.
  4. Ensure ./tools/format.js passes without changing files.
  5. Ensure ./tools/lint.js passes. -->
+0 -22

0 comment

2 changed files

ry

pr closed time in 2 days

PR opened denoland/deno

refactor: Rename ProgramState to ProcState

And move the Arc inside the struct.

+281 -329

0 comment

13 changed files

pr created time in 2 days

create barnchdenoland/deno

branch : ProcState

created branch time in 2 days

PR opened denoland/deno

refactor: Remove depreated Worker::execute_module

<!-- Before submitting a PR, please read http://deno.land/manual/contributing

  1. Give the PR a descriptive title.

Examples of good title: - fix(std/http): Fix race condition in server - docs(console): Update docstrings - feat(doc): Handle nested reexports

Examples of bad title: - fix #7123 - update docs - fix bugs

  1. Ensure there is a related issue and it is referenced in the PR text.
  2. Ensure there are tests that cover the changes.
  3. Ensure cargo test passes.
  4. Ensure ./tools/format.js passes without changing files.
  5. Ensure ./tools/lint.js passes. -->
+0 -22

0 comment

2 changed files

pr created time in 2 days

create barnchdenoland/deno

branch : rm_execute_module

created branch time in 2 days