profile
viewpoint

denoland/deno 67620

A secure JavaScript and TypeScript runtime

ry/tensorflow-resnet 1555

ResNet model in TensorFlow

ry/tensorflow-vgg16 649

conversation of caffe vgg16 model to tensorflow

ry/deno 387

ry/deno_typescript 31

To generate snapshots of TypeScript files during build.rs

ry/awesome-deno 16

🎉A curated list of awesome things related to Deno

ry/eecs151 12

http://inst.eecs.berkeley.edu/~eecs151/fa19/

ry/go 10

The Go programming language

push eventdenoland/deno

Nayeem Rahman

commit sha 8cbf0e75b2a7cf0e86608da0cf780b871b582deb

fix: Use $deno$test.ts instead of .deno.test.ts (#7717)

view details

push time in a few seconds

PR merged denoland/deno

fix: Use $deno$test.ts instead of .deno.test.ts

Missed in #7430.

+2 -2

0 comment

2 changed files

nayeemrmn

pr closed time in a few seconds

PullRequestReviewEvent

push eventdenoland/deno

uki00a

commit sha 94dcef714d09e09cd7eb777396f954ac3d24b161

BREAKING(std/encoding/csv): improve the definition of ParseOptions (#7714)

view details

push time in a minute

PR merged denoland/deno

BREAKING(std/encoding/csv): improve the definition of ParseOptions

This PR resolves #7426. cc @jsejcksn Please review.

Changes

  • Renames ParseOptions.comma to ParseOptions.separator.
  • Makes ParseOptions.header accept only boolean and adds ParseOptions.columns to define the header definition.
  • Renames ParseOptions.header to ParseOptions.skipFirstRow.

These change were made in response to feedback by @jsejcksn.

+101 -72

1 comment

3 changed files

uki00a

pr closed time in a minute

issue closeddenoland/deno

[std/encoding/csv] Omit header row when specifying header options

It doesn't appear that this kind of behavior is documented: https://deno.land/std@0.68.0/encoding#csv

Example:

data.csv:

size,cost
m,12
s,10
l,14

main.ts:

import {parse} from 'https://deno.land/std@0.68.0/encoding/csv.ts';

const parseOptions = {
  header: [
    {
      name: 'size',
      parse: (string: string) => string.toUpperCase(),
    },
    {
      name: 'cost',
      parse: (string: string) => Number(string),
    },
  ],
};

const raw = await Deno.readTextFile('data.csv');

const result = await parse(raw, parseOptions);
console.log(result);

output:

% deno run --allow-read=. --allow-write=. main.ts
[
  { size: "SIZE", cost: NaN },
  { size: "M", cost: 12 },
  { size: "S", cost: 10 },
  { size: "L", cost: 14 }
]

As you can see, the resulting array includes the header row, but I can't figure out how to omit it when parsing using header options.

If this is not possible, please consider this a feature request. If I just missed it, please point me in the right direction. Thanks!

closed time in a minute

jsejcksn
PullRequestReviewEvent

push eventdenoland/deno

Casper Beyer

commit sha 5db72dcaf364d0a9d9a5c5c9c10e80cdf8a199ad

fix(cli/inspector): shutdown server gracefully on drop (#7716)

view details

push time in 2 minutes

PR merged denoland/deno

fix(cli/inspector): shutdown server gracefully on drop

This signals a graceful shutdown of the inspector server and waits for the server thread to join when an InspectorServer is dropped.

+39 -25

0 comment

1 changed file

caspervonb

pr closed time in 2 minutes

PullRequestReviewEvent
PullRequestReviewEvent

push eventdenoland/deno

Luca Casonato

commit sha ebcb032c6bc60ae94039bc047509acffd9713379

fix: no check recognizes require (#7720)

view details

push time in 5 minutes

PR merged denoland/deno

Reviewers
fix: no check recognizes require

Fixes #7719

+11 -1

0 comment

3 changed files

lucacasonato

pr closed time in 5 minutes

issue closeddenoland/deno

--no-check recognizes `require`

// test.ts
require("fs");
>>> deno cache --no-check deno.ts 
error: relative import path "fs" not prefixed with / or ./ or ../ Imported from "file:///mnt/f9/Projects/github.com/denofn/denopack/test.ts"

We are recognizing require when using --no-check.

Likely related: #7621

cc @kitsonk

closed time in 5 minutes

lucacasonato
PullRequestReviewEvent

push eventdenoland/deno

Trivikram Kamat

commit sha 249d82099ecc2851ba0309d5b57a77fd8e728c9a

doc: use APA citation style for listing conference talks (#7721)

view details

push time in 31 minutes

PR merged denoland/deno

doc: use APA citation style for listing conference talks

This style provides information about the author, date and conference where the talk was given.

APA citation style details: https://pitt.libguides.com/citationhelp/apa7 Markdown after edit: https://github.com/trivikr/deno/blob/patch-1/docs/contributing/architecture.md#conference

+3 -2

0 comment

1 changed file

trivikr

pr closed time in 31 minutes

PullRequestReviewEvent

push eventdenoland/deno

Trivikram Kamat

commit sha d2fde8a363f1db9fd37b96b46260dcbf6c4d1b3e

doc: end sentences with a period in examples (#7722)

view details

push time in 32 minutes

PR merged denoland/deno

doc: end sentences with a period in examples

Deno Style Guide doesn't explicitly mention about ending sentences with period, but have been informally following it. Rust RFCs style guide recommends using periods for comments.

Also recommended by:

  • Microsoft docs style guide for periods.
  • Google developer documentation style guide for periods.
+36 -36

0 comment

13 changed files

trivikr

pr closed time in 32 minutes

PullRequestReviewEvent

push eventdenoland/deno

Giorgi Rostomashvili

commit sha eaba9adb03f0427ecf0a7a8b6937a6b82e134266

fix: net listen crashes on explicit undefined hostname (#7706)

view details

push time in 4 hours

PR merged denoland/deno

fix: net listen crashes on explicit undefined hostname

<!-- Before submitting a PR, please read https://github.com/denoland/deno/blob/master/docs/contributing.md --> fixes #7697

quite a small change and added test case too

+13 -2

1 comment

2 changed files

grosto

pr closed time in 4 hours

issue closeddenoland/deno

std/http: unexpected error when specifying "hostname" as undefined

When you set the hostname option for serve to undefined, it results in an unexpected error:

error: Uncaught InvalidData: data did not match any variant of untagged enum ArgsEnum
    at Object.jsonOpSync (core.js:247:13)
    at opListen (deno:cli/rt/30_net.js:32:17)
    at Object.listen (deno:cli/rt/30_net.js:207:17)
    at serve (server.ts:287:25)
    at index.ts:3:14

When you do not include the hostname option at all, the error does not happen. It only happens when you specifically set it to undefined yourself.

Reproduction Code

import { serve } from 'https://deno.land/std@0.70.0/http/server.ts';

let server = serve({ port: 8080, hostname: undefined });
for await (let req of server) {
    req.respond({ body: 'Hello World' });
}

Additional Information

deno 1.4.1
deno std 0.70.0
v8 8.7.75
typescript 4.0.2
Win 10 Pro

closed time in 4 hours

blockba5her
PullRequestReviewEvent

pull request commentdenoland/deno

feat(fmt): Sort named import and export specifiers

Nice! LGTM

dsherret

comment created time in 8 hours

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentdenoland/deno

refactor: move op state registration to workers

 use deno_core::error::generic_error; #[cfg(not(unix))] use deno_core::error::not_supported; -pub fn init(rt: &mut deno_core::JsRuntime) {-  super::reg_json_sync(rt, "op_open_sync", op_open_sync);-  super::reg_json_async(rt, "op_open_async", op_open_async);+pub fn init(state: &mut deno_core::OpState) {+  super::reg_json_sync(state, "op_open_sync", op_open_sync);+  super::reg_json_async(state, "op_open_async", op_open_async);

These changes seem superfluous - what is the purpose?

I like the init functions to take a &mut JsRuntime for maximum extensibility.

bartlomieju

comment created time in a day

PullRequestReviewEvent

Pull request review commentdenoland/deno

refactor: move op state registration to workers

-// Copyright 2018-2020 the Deno authors. All rights reserved. MIT license.--use crate::global_state::GlobalState;-use crate::js;-use crate::ops;-use crate::permissions::Permissions;-use crate::state::CliModuleLoader;-use crate::worker::Worker;-use crate::worker::WorkerEvent;-use crate::worker::WorkerHandle;-use deno_core::error::AnyError;-use deno_core::futures::channel::mpsc;-use deno_core::futures::future::FutureExt;-use deno_core::futures::stream::StreamExt;-use deno_core::v8;-use deno_core::ModuleSpecifier;-use std::future::Future;-use std::ops::Deref;-use std::ops::DerefMut;-use std::pin::Pin;-use std::sync::atomic::AtomicBool;-use std::sync::atomic::Ordering;-use std::sync::Arc;-use std::task::Context;-use std::task::Poll;--/// Wrapper for `WorkerHandle` that adds functionality-/// for terminating workers.-///-/// This struct is used by host as well as worker itself.-///-/// Host uses it to communicate with worker and terminate it,-/// while worker uses it only to finish execution on `self.close()`.-#[derive(Clone)]-pub struct WebWorkerHandle {-  worker_handle: WorkerHandle,-  terminate_tx: mpsc::Sender<()>,-  terminated: Arc<AtomicBool>,-  isolate_handle: v8::IsolateHandle,-}--impl Deref for WebWorkerHandle {-  type Target = WorkerHandle;-  fn deref(&self) -> &Self::Target {-    &self.worker_handle-  }-}--impl DerefMut for WebWorkerHandle {-  fn deref_mut(&mut self) -> &mut Self::Target {-    &mut self.worker_handle-  }-}--impl WebWorkerHandle {-  pub fn terminate(&self) {-    // This function can be called multiple times by whomever holds-    // the handle. However only a single "termination" should occur so-    // we need a guard here.-    let already_terminated = self.terminated.swap(true, Ordering::Relaxed);--    if !already_terminated {-      self.isolate_handle.terminate_execution();-      let mut sender = self.terminate_tx.clone();-      // This call should be infallible hence the `expect`.-      // This might change in the future.-      sender.try_send(()).expect("Failed to terminate");-    }-  }-}--/// This worker is implementation of `Worker` Web API-///-/// At the moment this type of worker supports only-/// communication with parent and creating new workers.-///-/// Each `WebWorker` is either a child of `MainWorker` or other-/// `WebWorker`.-pub struct WebWorker {-  worker: Worker,-  event_loop_idle: bool,-  terminate_rx: mpsc::Receiver<()>,-  handle: WebWorkerHandle,-  pub has_deno_namespace: bool,-}--impl WebWorker {-  pub fn new(-    name: String,-    permissions: Permissions,-    main_module: ModuleSpecifier,-    global_state: Arc<GlobalState>,-    has_deno_namespace: bool,-  ) -> Self {-    let loader = CliModuleLoader::new_for_worker();-    let mut worker = Worker::new(-      name,-      Some(js::deno_isolate_init()),-      permissions,-      main_module,-      global_state,-      loader,-      false,-    );--    let terminated = Arc::new(AtomicBool::new(false));-    let isolate_handle = worker.isolate.thread_safe_handle();-    let (terminate_tx, terminate_rx) = mpsc::channel::<()>(1);--    let handle = WebWorkerHandle {-      worker_handle: worker.thread_safe_handle(),-      terminated,-      isolate_handle,-      terminate_tx,-    };--    let mut web_worker = Self {-      worker,-      event_loop_idle: false,-      terminate_rx,-      handle,-      has_deno_namespace,-    };--    {-      ops::runtime::init(&mut web_worker.worker);-      let sender = web_worker.worker.internal_channels.sender.clone();-      let handle = web_worker.thread_safe_handle();-      ops::web_worker::init(&mut web_worker.worker, sender, handle);-      ops::worker_host::init(&mut web_worker.worker);-      ops::reg_json_sync(-        &mut web_worker.worker,-        "op_domain_to_ascii",-        deno_web::op_domain_to_ascii,-      );-      ops::io::init(&mut web_worker.worker);-      ops::reg_json_sync(-        &mut web_worker.worker,-        "op_close",-        deno_core::op_close,-      );-      ops::reg_json_sync(-        &mut web_worker.worker,-        "op_resources",-        deno_core::op_resources,-      );-      ops::errors::init(&mut web_worker.worker);-      ops::timers::init(&mut web_worker.worker);-      ops::fetch::init(&mut web_worker.worker);-      ops::websocket::init(&mut web_worker.worker);--      if has_deno_namespace {-        ops::runtime_compiler::init(&mut web_worker.worker);-        ops::fs::init(&mut web_worker.worker);-        ops::fs_events::init(&mut web_worker.worker);-        ops::plugin::init(&mut web_worker.worker);-        ops::net::init(&mut web_worker.worker);-        ops::tls::init(&mut web_worker.worker);-        ops::os::init(&mut web_worker.worker);-        ops::permissions::init(&mut web_worker.worker);-        ops::process::init(&mut web_worker.worker);-        ops::random::init(&mut web_worker.worker);-        ops::signal::init(&mut web_worker.worker);-        ops::tty::init(&mut web_worker.worker);-      }-    }--    web_worker-  }-}--impl WebWorker {-  /// Returns a way to communicate with the Worker from other threads.-  pub fn thread_safe_handle(&self) -> WebWorkerHandle {-    self.handle.clone()-  }-}--impl Deref for WebWorker {-  type Target = Worker;-  fn deref(&self) -> &Self::Target {-    &self.worker-  }-}--impl DerefMut for WebWorker {-  fn deref_mut(&mut self) -> &mut Self::Target {-    &mut self.worker-  }-}--impl Future for WebWorker {-  type Output = Result<(), AnyError>;--  fn poll(self: Pin<&mut Self>, cx: &mut Context) -> Poll<Self::Output> {-    let inner = self.get_mut();-    let worker = &mut inner.worker;--    let terminated = inner.handle.terminated.load(Ordering::Relaxed);--    if terminated {-      return Poll::Ready(Ok(()));-    }--    if !inner.event_loop_idle {-      match worker.poll_unpin(cx) {-        Poll::Ready(r) => {-          let terminated = inner.handle.terminated.load(Ordering::Relaxed);-          if terminated {-            return Poll::Ready(Ok(()));-          }--          if let Err(e) = r {-            let mut sender = worker.internal_channels.sender.clone();-            sender-              .try_send(WorkerEvent::Error(e))-              .expect("Failed to post message to host");-          }-          inner.event_loop_idle = true;-        }-        Poll::Pending => {}-      }-    }--    if let Poll::Ready(r) = inner.terminate_rx.poll_next_unpin(cx) {-      // terminate_rx should never be closed-      assert!(r.is_some());-      return Poll::Ready(Ok(()));-    }--    if let Poll::Ready(r) =-      worker.internal_channels.receiver.poll_next_unpin(cx)-    {-      match r {-        Some(msg) => {-          let msg = String::from_utf8(msg.to_vec()).unwrap();-          let script = format!("workerMessageRecvCallback({})", msg);--          if let Err(e) = worker.execute(&script) {-            // If execution was terminated during message callback then-            // just ignore it-            if inner.handle.terminated.load(Ordering::Relaxed) {-              return Poll::Ready(Ok(()));-            }--            // Otherwise forward error to host-            let mut sender = worker.internal_channels.sender.clone();-            sender-              .try_send(WorkerEvent::Error(e))-              .expect("Failed to post message to host");-          }--          // Let event loop be polled again-          inner.event_loop_idle = false;-          worker.waker.wake();-        }-        None => unreachable!(),-      }-    }--    Poll::Pending-  }-}--#[cfg(test)]-mod tests {-  use super::*;-  use crate::tokio_util;-  use crate::worker::WorkerEvent;-  use deno_core::serde_json::json;--  fn create_test_worker() -> WebWorker {-    let main_module =-      ModuleSpecifier::resolve_url_or_path("./hello.js").unwrap();-    let global_state = GlobalState::mock(vec!["deno".to_string()], None);-    let mut worker = WebWorker::new(-      "TEST".to_string(),-      Permissions::allow_all(),-      main_module,-      global_state,-      false,-    );-    worker-      .execute("bootstrap.workerRuntime(\"TEST\", false)")-      .unwrap();-    worker-  }-  #[test]-  fn test_worker_messages() {-    let (handle_sender, handle_receiver) =-      std::sync::mpsc::sync_channel::<WebWorkerHandle>(1);--    let join_handle = std::thread::spawn(move || {-      let mut worker = create_test_worker();-      let source = r#"-          onmessage = function(e) {-            console.log("msg from main script", e.data);-            if (e.data == "exit") {-              return close();-            } else {-              console.assert(e.data === "hi");-            }-            postMessage([1, 2, 3]);-            console.log("after postMessage");-          }-          "#;-      worker.execute(source).unwrap();-      let handle = worker.thread_safe_handle();-      handle_sender.send(handle).unwrap();-      let r = tokio_util::run_basic(worker);-      assert!(r.is_ok())-    });--    let mut handle = handle_receiver.recv().unwrap();--    tokio_util::run_basic(async move {-      let msg = json!("hi").to_string().into_boxed_str().into_boxed_bytes();-      let r = handle.post_message(msg.clone());-      assert!(r.is_ok());--      let maybe_msg = handle.get_event().await.unwrap();-      assert!(maybe_msg.is_some());--      let r = handle.post_message(msg.clone());-      assert!(r.is_ok());--      let maybe_msg = handle.get_event().await.unwrap();-      assert!(maybe_msg.is_some());-      match maybe_msg {-        Some(WorkerEvent::Message(buf)) => {-          assert_eq!(*buf, *b"[1,2,3]");-        }-        _ => unreachable!(),-      }--      let msg = json!("exit")-        .to_string()-        .into_boxed_str()-        .into_boxed_bytes();-      let r = handle.post_message(msg);-      assert!(r.is_ok());-      let event = handle.get_event().await.unwrap();-      assert!(event.is_none());-      handle.sender.close_channel();-    });-    join_handle.join().expect("Failed to join worker thread");-  }--  #[test]-  fn removed_from_resource_table_on_close() {-    let (handle_sender, handle_receiver) =-      std::sync::mpsc::sync_channel::<WebWorkerHandle>(1);--    let join_handle = std::thread::spawn(move || {-      let mut worker = create_test_worker();-      worker.execute("onmessage = () => { close(); }").unwrap();-      let handle = worker.thread_safe_handle();-      handle_sender.send(handle).unwrap();-      let r = tokio_util::run_basic(worker);-      assert!(r.is_ok())-    });--    let mut handle = handle_receiver.recv().unwrap();--    tokio_util::run_basic(async move {-      let msg = json!("hi").to_string().into_boxed_str().into_boxed_bytes();-      let r = handle.post_message(msg.clone());-      assert!(r.is_ok());-      let event = handle.get_event().await.unwrap();-      assert!(event.is_none());-      handle.sender.close_channel();-    });-    join_handle.join().expect("Failed to join worker thread");-  }-}

This is desirable

bartlomieju

comment created time in a day

PullRequestReviewEvent
PullRequestReviewEvent

issue openeddenoland/doc_website

sidebar ordering should match main page ordering

Screen Shot 2020-09-26 at 1 15 43 PM

currently addEventListener shows up first in the main content, but not first on the side.

created time in a day

issue openeddenoland/deno_doc

sidebar ordering should match main page ordering

Screen Shot 2020-09-26 at 1 15 43 PM

currently addEventListener shows up first in the main content, but not first on the side.

created time in a day

push eventdenoland/deno

tokiedokie

commit sha 04836dc700a8e22fdb604f0640cb72be5e0194c9

refactor(std/example): Inconsistencies in the example tests (#7684)

view details

push time in a day

PR merged denoland/deno

refactor(std/example): Inconsistencies in the example tests

Other /std tests have tests next to the script, but /std/example doesn't.

+27 -27

0 comment

8 changed files

tokiedokie

pr closed time in a day

PullRequestReviewEvent

issue openeddenoland/deno

source_graph_type_references test is flaky

https://github.com/denoland/deno/runs/1170119138

failures:

---- module_graph::tests::source_graph_type_references stdout ----
Error: thread 'module_graph::tests::source_graph_type_references' panicked at 'Failed to build graph: Cannot resolve module "http://localhost:4545/cli/tests/type_definitions.ts"', cli/module_graph.rs:722:8
stack backtrace:
   0:     0x560659e326f5 - backtrace::backtrace::libunwind::trace::h14d338b30b3ea0a7
                               at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.46/src/backtrace/libunwind.rs:86
   1:     0x560659e326f5 - backtrace::backtrace::trace_unsynchronized::h73ea91d74a3fd67f
                               at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.46/src/backtrace/mod.rs:66
   2:     0x560659e326f5 - std::sys_common::backtrace::_print_fmt::hd42948c952866e12
                               at src/libstd/sys_common/backtrace.rs:78
   3:     0x560659e326f5 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::ha8f928866ff7571e
                               at src/libstd/sys_common/backtrace.rs:59
   4:     0x560659e6252c - core::fmt::write::he0c1e5f7426d2718
                               at src/libcore/fmt/mod.rs:1076
   5:     0x560657033545 - std::io::Write::write_fmt::h1152922039931516
                               at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/io/mod.rs:1537
   6:     0x560659e26851 - std::io::impls::<impl std::io::Write for alloc::boxed::Box<W>>::write_fmt::ha927d7e5f294bce5
                               at src/libstd/io/impls.rs:176
   7:     0x560659e35460 - std::sys_common::backtrace::_print::hfc0110703f3696fd
                               at src/libstd/sys_common/backtrace.rs:62
   8:     0x560659e35460 - std::sys_common::backtrace::print::h3f77c6990ddfaa22
                               at src/libstd/sys_common/backtrace.rs:49
   9:     0x560659e35460 - std::panicking::default_hook::{{closure}}::heae49580a8d62d75
                               at src/libstd/panicking.rs:198
  10:     0x560659e3515a - std::panicking::default_hook::hecc34e3f729e213c
                               at src/libstd/panicking.rs:214
  11:     0x560659e35aa3 - std::panicking::rust_panic_with_hook::he82f5d0644692441
                               at src/libstd/panicking.rs:526
  12:     0x560659e3569b - rust_begin_unwind
                               at src/libstd/panicking.rs:437
  13:     0x560659e60be1 - core::panicking::panic_fmt::h09c929f06bb87c98
                               at src/libcore/panicking.rs:85
  14:     0x560659e60a03 - core::option::expect_none_failed::h188f17af6c9f404b
                               at src/libcore/option.rs:1269
  15:     0x560656e66c34 - core::result::Result<T,E>::expect::h59068c1fd3c070d0
                               at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libcore/result.rs:963
  16:     0x560656b18b80 - deno::module_graph::tests::source_graph_type_references::{{closure}}::hf73e49cda48fd106
                               at cli/module_graph.rs:720
  17:     0x560656d5edd9 - <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h701b7c93a0689073
                               at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libcore/future/mod.rs:78
  18:     0x5606567dc513 - tokio::runtime::basic_scheduler::BasicScheduler<P>::block_on::{{closure}}::{{closure}}::h85957d687403ee44
                               at /home/runner/work/deno/deno/.cargo_home/registry/src/github.com-1ecc6299db9ec823/tokio-0.2.22/src/runtime/basic_scheduler.rs:131
  19:     0x560656b6c7c6 - tokio::coop::with_budget::{{closure}}::hdd7d40cbb19de20c
                               at /home/runner/work/deno/deno/.cargo_home/registry/src/github.com-1ecc6299db9ec823/tokio-0.2.22/src/coop.rs:127
  20:     0x560656eef3e1 - std::thread::local::LocalKey<T>::try_with::hc4c9947c71195f75
                               at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/thread/local.rs:263
  21:     0x560656ed5f0d - std::thread::local::LocalKey<T>::with::hb5e9988bb53a2cb5
                               at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/thread/local.rs:239
  22:     0x5606567ba943 - tokio::coop::with_budget::h12f2b56ec9b6c0c3
                               at /home/runner/work/deno/deno/.cargo_home/registry/src/github.com-1ecc6299db9ec823/tokio-0.2.22/src/coop.rs:120
  23:     0x5606567ba943 - tokio::coop::budget::h7e71f32b596e4685
                               at /home/runner/work/deno/deno/.cargo_home/registry/src/github.com-1ecc6299db9ec823/tokio-0.2.22/src/coop.rs:96
  24:     0x5606567ba943 - tokio::runtime::basic_scheduler::BasicScheduler<P>::block_on::{{closure}}::h02345f1d887d943c
                               at /home/runner/work/deno/deno/.cargo_home/registry/src/github.com-1ecc6299db9ec823/tokio-0.2.22/src/runtime/basic_scheduler.rs:131
  25:     0x5606567ec062 - tokio::runtime::basic_scheduler::enter::{{closure}}::h1a3da75471891a28
                               at /home/runner/work/deno/deno/.cargo_home/registry/src/github.com-1ecc6299db9ec823/tokio-0.2.22/src/runtime/basic_scheduler.rs:213
  26:     0x560656f0569f - tokio::macros::scoped_tls::ScopedKey<T>::set::hedad61f5c5575af6
                               at /home/runner/work/deno/deno/.cargo_home/registry/src/github.com-1ecc6299db9ec823/tokio-0.2.22/src/macros/scoped_tls.rs:63
  27:     0x5606567df429 - tokio::runtime::basic_scheduler::enter::h04bf70506bc5b063
                               at /home/runner/work/deno/deno/.cargo_home/registry/src/github.com-1ecc6299db9ec823/tokio-0.2.22/src/runtime/basic_scheduler.rs:213
  28:     0x5606567b8cab - tokio::runtime::basic_scheduler::BasicScheduler<P>::block_on::h1267706e8e225323
                               at /home/runner/work/deno/deno/.cargo_home/registry/src/github.com-1ecc6299db9ec823/tokio-0.2.22/src/runtime/basic_scheduler.rs:123
  29:     0x560656aabe3d - tokio::runtime::Runtime::block_on::{{closure}}::h02fd93dcd47b7f53
                               at /home/runner/work/deno/deno/.cargo_home/registry/src/github.com-1ecc6299db9ec823/tokio-0.2.22/src/runtime/mod.rs:444
  30:     0x5606569eac37 - tokio::runtime::context::enter::h7071c8efa7d9a552
                               at /home/runner/work/deno/deno/.cargo_home/registry/src/github.com-1ecc6299db9ec823/tokio-0.2.22/src/runtime/context.rs:72
  31:     0x560656da5aeb - tokio::runtime::handle::Handle::enter::h81ca9407a3dc53b2
                               at /home/runner/work/deno/deno/.cargo_home/registry/src/github.com-1ecc6299db9ec823/tokio-0.2.22/src/runtime/handle.rs:76
  32:     0x560656aaa9cb - tokio::runtime::Runtime::block_on::h4f19562d9a96fe91
                               at /home/runner/work/deno/deno/.cargo_home/registry/src/github.com-1ecc6299db9ec823/tokio-0.2.22/src/runtime/mod.rs:441
  33:     0x560656b18828 - deno::module_graph::tests::source_graph_type_references::hab70c3e8b22b1999
                               at cli/module_graph.rs:711
  34:     0x560656b1873a - deno::module_graph::tests::source_graph_type_references::{{closure}}::h2ec24404c4b23053
                               at cli/module_graph.rs:711
  35:     0x560656bc288e - core::ops::function::FnOnce::call_once::h92df0485c47e9fd7
                               at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libcore/ops/function.rs:233
  36:     0x56065705aabc - <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once::h6633cb15d0d76942
                               at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/liballoc/boxed.rs:1081
  37:     0x56065705aabc - <std::panic::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once::h1e20120def172c5c
                               at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panic.rs:318
  38:     0x56065705aabc - std::panicking::try::do_call::hcc2ec3bbb75e9316
                               at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panicking.rs:348
  39:     0x56065705aabc - std::panicking::try::h94eaebaaa7dd6f41
                               at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panicking.rs:325
  40:     0x56065705aabc - std::panic::catch_unwind::h151c07c08497cf8b
                               at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panic.rs:394
  41:     0x56065705aabc - test::run_test_in_process::hd082de93b1922c89
                               at src/libtest/lib.rs:541
  42:     0x56065705aabc - test::run_test::run_test_inner::{{closure}}::h22369c9424e5ab3a
                               at src/libtest/lib.rs:450
  43:     0x560657032a36 - std::sys_common::backtrace::__rust_begin_short_backtrace::h0660a89f67243e05
                               at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/sys_common/backtrace.rs:130
  44:     0x560657037ae5 - std::thread::Builder::spawn_unchecked::{{closure}}::{{closure}}::h8bb2049509aa1add
                               at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/thread/mod.rs:475
  45:     0x560657037ae5 - <std::panic::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once::hb49f3484cb9c3dd3
                               at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panic.rs:318
  46:     0x560657037ae5 - std::panicking::try::do_call::ha910a12d1577339b
                               at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panicking.rs:348
  47:     0x560657037ae5 - std::panicking::try::hd8b3d620360e55fa
                               at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panicking.rs:325
  48:     0x560657037ae5 - std::panic::catch_unwind::h475454730ea43154
                               at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/panic.rs:394
  49:     0x560657037ae5 - std::thread::Builder::spawn_unchecked::{{closure}}::h2407d9379d805151
                               at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libstd/thread/mod.rs:474
  50:     0x560657037ae5 - core::ops::function::FnOnce::call_once{{vtable.shim}}::haef9f772dfab225e
                               at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/libcore/ops/function.rs:233
  51:     0x560659e406da - <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once::hd2b3bc04af94a84f
                               at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/liballoc/boxed.rs:1081
  52:     0x560659e406da - <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once::h1044417e186e567a
                               at /rustc/04488afe34512aa4c33566eb16d8c912a3ae04f9/src/liballoc/boxed.rs:1081
  53:     0x560659e406da - std::sys::unix::thread::Thread::new::thread_start::h276e6ca033938925
                               at src/libstd/sys/unix/thread.rs:87
  54:     0x7f30067316db - start_thread
  55:     0x7f3006242a3f - __clone
  56:                0x0 - <unknown>


failures:
    module_graph::tests::source_graph_type_references

test result: FAILED. 258 passed; 1 failed; 1 ignored; 0 measured; 0 filtered out

created time in a day

PullRequestReviewEvent

PR opened denoland/deno_website2

update versions.json

merge on approval

+3 -0

0 comment

1 changed file

pr created time in a day

push eventry/deno_website2

Ryan Dahl

commit sha e9a9ada88123379a6a9cac488d7f8fb1665bacdf

update versions.json

view details

push time in a day

create barnchry/deno_website2

branch : std/0.71.0

created branch time in a day

push eventdenoland/deno

KNnut

commit sha e0d4696a7201301dfa23e108b6e73d016e3f5e63

Fix typos (#7687)

view details

push time in a day

PR merged denoland/deno

Fix typos
+6 -6

2 comments

2 changed files

KNnut

pr closed time in a day

PullRequestReviewEvent

push eventdenoland/deno

Kang Huaishuai

commit sha ab96619cd6d2cdfde531db3432854166a8dbed5d

simply github actions yaml (#7688) use strategy->matrix->include

view details

push time in a day

PR merged denoland/deno

simply github actions yaml

use strategy->matrix->include

+28 -28

2 comments

1 changed file

khs1994

pr closed time in a day

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

push eventdenoland/deno

Casper Beyer

commit sha eb7f70c0b04d07feb30d41418935a3521811f8f8

test(std/async): remove redundant export in test (#7682)

view details

push time in 2 days

PR merged denoland/deno

chore(std/async): remove redundant export in test

This removes a redundant export in delay_test that was introduced in #7671

+0 -2

1 comment

1 changed file

caspervonb

pr closed time in 2 days

PullRequestReviewEvent

push eventdenoland/deno

Tim Reichen

commit sha f1231ff58e80b5a8f1660ffc443dc7851e8ea7e7

fix(std/datetime): add timezone to date strings in tests (#7675)

view details

push time in 2 days

PR merged denoland/deno

(std/datetime): add timezone to test date strings

<!-- Before submitting a PR, please read https://github.com/denoland/deno/blob/master/docs/contributing.md --> fixes #7665

+101 -53

0 comment

1 changed file

timreichen

pr closed time in 2 days

issue closeddenoland/deno

(std/datetime): dayOfYear returns different values depending on the time zone

I cannot pass std tests because of this issue


js file:

import * as datetime from "https://deno.land/std@0.70.0/datetime/mod.ts"

console.log(datetime.dayOfYear(new Date("1582-10-04T03:24:00+0000")));
console.log(datetime.dayOfYear(new Date("1582-10-04T03:24:00+0900")));

output:

277
276

closed time in 2 days

tokiedokie
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentdenoland/deno

test(std): unit test for async/delay

+// Copyright 2018-2020 the Deno authors. All rights reserved. MIT license.+import { delay } from "./delay.ts";+import { assert } from "../testing/asserts.ts";++Deno.test("[async] delay", async function (): Promise<void> {+  const start = new Date();+  const delayedPromise = delay(100);+  const result = await delayedPromise;+  const diff = new Date().getTime() - start.getTime();+  assert(result === undefined);+  assert(diff >= 100);+  assert(diff < 150);+});++export {};

Remove

ochronus

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentdenoland/deno

test(std): unit test for async/delay

+// Copyright 2018-2020 the Deno authors. All rights reserved. MIT license.+import { delay } from "./delay.ts";+import { assert } from "../testing/asserts.ts";++Deno.test("[async] delay", async function (): Promise<void> {+  const start = new Date();+  const delayedPromise = delay(100);+  const result = await delayedPromise;+  const diff = new Date().getTime() - start.getTime();+  assert(result === undefined);+  assert(diff >= 100);+  assert(diff < 150);

Thanks for the patch! The test looks good except this last assert - this is guaranteed by the API - please remove.

ochronus

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

issue commentdenoland/deno

std/node/fs missing a lot of functionality

symlink is unstable https://doc.deno.land/builtin/unstable#Deno.symlink

AliBasicCoder

comment created time in 3 days

pull request commentdenoland/deno_website2

feat: add languages page

@tokiedokie Cool - put the link with the other "extra" pages at the bottom. Title it "Translations"?

tokiedokie

comment created time in 3 days

push eventdenoland/deno

Will

commit sha 7726cfb93243932a07107f67b87032adb40abdc0

Replaced legacy chrome-devtools:// scheme. (#7659) The legacy chrome-devtools scheme was removed from the Chromium codebase. The new scheme is simply "devtools://" https://chromium.googlesource.com/chromium/src/+/6700d12448f76712c62a6d2372a95b97a26d4779

view details

push time in 3 days

PR merged denoland/deno

Fix. Replaced legacy chrome-devtools:// scheme.

The legacy chrome-devtools:// scheme was removed from the Chromium codebase. The new scheme is simply "devtools://"

https://chromium-review.googlesource.com/c/chromium/src/+/2088335 https://chromium.googlesource.com/chromium/src/+/6700d12448f76712c62a6d2372a95b97a26d4779

+1 -1

1 comment

1 changed file

june07

pr closed time in 3 days

PullRequestReviewEvent

push eventdenoland/deno

Tim Reichen

commit sha 9c75e4876f68b36cb8a79bfe5a734d2783c527ce

fix(std/datetime):: 12 and 24 support (#7661)

view details

push time in 3 days

PR merged denoland/deno

(std/datetime): 12 and 24 hour support

<!-- Before submitting a PR, please read https://github.com/denoland/deno/blob/master/docs/contributing.md -->

+148 -59

0 comment

4 changed files

timreichen

pr closed time in 3 days

PullRequestReviewEvent

PR closed denoland/deno

(docs) Add missing backticks

added backticks deleted on #6998

+1 -1

2 comments

1 changed file

kyle-seongwoo-jun

pr closed time in 3 days

pull request commentdenoland/deno

(docs) Add missing backticks

Thanks but it's fine.

kyle-seongwoo-jun

comment created time in 3 days

PullRequestReviewEvent
PullRequestReviewEvent

PR opened denoland/deno

Simplify op_fetch_asset signature

<!-- Before submitting a PR, please read https://github.com/denoland/deno/blob/master/docs/contributing.md -->

+6 -4

0 comment

1 changed file

pr created time in 3 days

create barnchry/deno

branch : op_fetch_asset

created branch time in 3 days

push eventdenoland/deno

Casper Beyer

commit sha 6254bd41b72705fc5fba02f9006302dc0c85ea80

fix(cli/coverage): print lines with no coverage to stdout (#7640)

view details

push time in 4 days

PR merged denoland/deno

feat(cli/coverage): print lines with no coverage to stdout

This pretty prints uncovered lines as red text with line numbers to stdout with the coverage report.

Screenshot 2020-09-23 at 2 18 39 PM

+71 -63

1 comment

3 changed files

caspervonb

pr closed time in 4 days

pull request commentdenoland/deno

feat(cli/coverage): print lines with no coverage to stdout

Is coverage an unstable feature? Can we land this immediately?

caspervonb

comment created time in 4 days

PullRequestReviewEvent

push eventdenoland/deno

Casper Beyer

commit sha e1b61d6794facf2d8da4d13273685dc0a5248aed

fix(cli/console): quote non-alphanumeric symbols (#7641) This quotes and escapes symbol descriptions that contains characters outside of the basic alpha-numeric identifier range.

view details

push time in 4 days

PR merged denoland/deno

fix(cli/console): quote non-alphanumeric symbols

This quotes and escapes symbol descriptions that contains characters outside of the basic alpha-numeric identifier range.

Fixes an issue brought up in #7551

+28 -2

0 comment

2 changed files

caspervonb

pr closed time in 4 days

PullRequestReviewEvent

push eventdenoland/deno

Casper Beyer

commit sha 3ac9f1e209c3bb10cbb3c0a49077877a5bc5e2eb

fix(std/fs): mark createWalkEntry(Sync) as internal (#7643)

view details

push time in 4 days

PR merged denoland/deno

fix(std/fs): mark createWalkEntry(Sync) as internal

This marks createWalkEntry and createWalkEntry in std/fs as internal via an underscore prefix. These were showing up on the docs website.

Fixes #7572

+10 -10

0 comment

2 changed files

caspervonb

pr closed time in 4 days

issue closeddenoland/deno

createWalkEntry and createWalkEntrySync should probably not be exported from std/fs

There's two functions exported in std/fs/walk.ts (createWalkEntry and createWalkEntrySync) that don't make much sense to keep public and seem to be just exported to share internally between modules.

closed time in 4 days

caspervonb
PullRequestReviewEvent

push eventdenoland/deno

qlcom

commit sha 1021dad5f61d4328f02786f02687aecdab11bcfc

mark shell code blocks as sh instead of bash (#7645)

view details

push time in 4 days

PR merged denoland/deno

mark shell code blocks as sh instead of bash

this blocks don't contain bash specific code

+2 -2

1 comment

1 changed file

qlcom

pr closed time in 4 days

PullRequestReviewEvent

push eventdenoland/deno

Valentin Anger

commit sha 71c2497fd47829a177b81a884b75f705272156b2

Add example for deno_core (#7611)

view details

push time in 4 days

PR merged denoland/deno

Reviewers
Add example for deno_core #7453

I've written an example for the usage of sync ops. A list of other aspects that should be covered would be useful, an obvious one is async ops.

+125 -0

0 comment

1 changed file

SyrupThinker

pr closed time in 4 days

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentdenoland/deno

feat(cli): Use swc for deno bundle

IMO tree shaking seems more important than type checking when bundling.

kdy1

comment created time in 5 days

push eventSyrupThinker/deno

Yusuke Tanaka

commit sha c30c782c2c22d725c007623dbf43009999a2b184

fix(logger): change log level to which prefix added (#7582)

view details

Casper Beyer

commit sha a33315aaa70884c10968669c31adf3c6bb142e72

fix(cli/console): quote object symbol keys that are invalid identifiers (#7553)

view details

Nayeem Rahman

commit sha a43984c9cfcea852ca18e1c575f9acdb8f023a5a

refactor(cli/fmt_errors): Color stack traces in Rust (#7628)

view details

Bartek Iwańczuk

commit sha dd1cd4d95237359acd822143265d7d2365bf928c

fix: clearing timers race condition (#7617)

view details

Schwarzkopf Balázs

commit sha f601721851bdd64ee5b40bd3d408df063691b425

feat(std/node): implement getSystemErrorName() (#7624)

view details

Luca Casonato

commit sha cf0c49191e9be862027f74f39318a3479fce3ba2

chore(std/hash): update crates (#7631)

view details

Bartek Iwańczuk

commit sha 68fd7a927b26c3e72cf73515821450f3aa252014

refactor(core): support error stack, remove js_check (#7629) This commit adds support for stack traces in "deno_core". Implementation of "Display" trait for "JsError" has been updated and in consequence "deno_core::js_check" became obsolete and removed.

view details

Kitson Kelly

commit sha 751bb45a0a4ca4ab3baf5e5037c0b10f0430aeb6

fix: ignore fileExists in tsc host (#7635) Fixes #7630

view details

Ryan Dahl

commit sha ffd08a2249b3aab1e8e70d9cef9c350ab41f22a7

Actually remove js_check (#7636)

view details

Valentin Anger

commit sha 559ce3f45e8989f2f7f9629eb09d1244ffbe6ce2

Add example for sync ops

view details

push time in 5 days

delete branch ry/deno

delete branch : actually_remove_js_check

delete time in 5 days

more