push eventdenoland/deno
commit sha 2235dd795d3cc6c24ff1bdd1bbdcd110b4b0bdfc
Revert json ops (#2814) * Revert "port more ops to JSON (#2809)" This reverts commit 137f33733d365026903d40e7cde6e34ac6c36dcf. * Revert "port ops to JSON: compiler, errors, fetch, files (#2804)" This reverts commit 79f82cf10ed1dbf91346994250d7311a4d74377a. * Revert "Port rest of os ops to JSON (#2802)" This reverts commit 5b2baa5c990fbeae747e952c5dcd7a5369e950b1.
push time in 7 hours
PR merged denoland/deno
We're experiencing odd benchmarks and errors as a result of the recent ops moving to JSON. They're odd because node and hyper benchmarks are being negatively effected along with deno.
It's disconcerting that the errors below did not cause the tests to fail.
Errors are seen during the benchmarks:
Compile file:///home/travis/build/denoland/deno/tools/deno_tcp.ts
Listening on 127.0.0.1:4544
Listening on 127.0.0.1:4545
error: Uncaught RangeError: start offset of Int32Array should be a multiple of 4
► js/dispatch_minimal.ts:44:17
at asyncMsgFromRust (js/dispatch_minimal.ts:44:17)
at asyncMsgFromRust$3 (js/dispatch.ts:57:7)
at handleAsyncMsgFromRust (shared_queue.js:171:9)
Compile file:///home/travis/build/denoland/deno/js/deps/https/deno.land/std/http/http_bench.ts
http://127.0.0.1:4546/
Listening on http://127.0.0.1:4548
Compile file:///home/travis/build/denoland/deno/tools/deno_http_proxy.ts
Proxy listening on http://127.0.0.1:4547/
error: Uncaught RangeError: start offset of Int32Array should be a multiple of 4
► js/dispatch_minimal.ts:44:17
at asyncMsgFromRust (js/dispatch_minimal.ts:44:17)
at asyncMsgFromRust$3 (js/dispatch.ts:57:7)
at handleAsyncMsgFromRust (shared_queue.js:171:9)
Listening on http://127.0.0.1:4550
Compile file:///home/travis/build/denoland/deno/tools/deno_tcp_proxy.ts
Proxy listening on http://127.0.0.1:4549/
single-thread
http_bench.js start
listening http://127.0.0.1:4544/ rid = 3
unexpected err Connection reset by peer (os error 104)
unexpected err Connection reset by peer (os error 104)
unexpected err Connection reset by peer (os error 104)
unexpected err Connection reset by peer (os error 104)
unexpected err Connection reset by peer (os error 104)
unexpected err Connection reset by peer (os error 104)
unexpected err Connection reset by peer (os error 104)
unexpected err Connection reset by peer (os error 104)
cc @bartlomieju
pr closed time in 7 hours
PR opened denoland/deno
We're experiencing odd benchmarks and errors as a result of the recent ops moving to JSON. They're odd because node and hyper benchmarks are being negatively effected along with deno.
Errors are seen during the benchmarks:
Compile file:///home/travis/build/denoland/deno/tools/deno_tcp.ts
Listening on 127.0.0.1:4544
Listening on 127.0.0.1:4545
error: Uncaught RangeError: start offset of Int32Array should be a multiple of 4
► js/dispatch_minimal.ts:44:17
at asyncMsgFromRust (js/dispatch_minimal.ts:44:17)
at asyncMsgFromRust$3 (js/dispatch.ts:57:7)
at handleAsyncMsgFromRust (shared_queue.js:171:9)
Compile file:///home/travis/build/denoland/deno/js/deps/https/deno.land/std/http/http_bench.ts
http://127.0.0.1:4546/
Listening on http://127.0.0.1:4548
Compile file:///home/travis/build/denoland/deno/tools/deno_http_proxy.ts
Proxy listening on http://127.0.0.1:4547/
error: Uncaught RangeError: start offset of Int32Array should be a multiple of 4
► js/dispatch_minimal.ts:44:17
at asyncMsgFromRust (js/dispatch_minimal.ts:44:17)
at asyncMsgFromRust$3 (js/dispatch.ts:57:7)
at handleAsyncMsgFromRust (shared_queue.js:171:9)
Listening on http://127.0.0.1:4550
Compile file:///home/travis/build/denoland/deno/tools/deno_tcp_proxy.ts
Proxy listening on http://127.0.0.1:4549/
single-thread
http_bench.js start
listening http://127.0.0.1:4544/ rid = 3
unexpected err Connection reset by peer (os error 104)
unexpected err Connection reset by peer (os error 104)
unexpected err Connection reset by peer (os error 104)
unexpected err Connection reset by peer (os error 104)
unexpected err Connection reset by peer (os error 104)
unexpected err Connection reset by peer (os error 104)
unexpected err Connection reset by peer (os error 104)
unexpected err Connection reset by peer (os error 104)
pr created time in 8 hours
push eventdenoland/deno_std
commit sha 28e77389ff409814c9da81d767458b36534f095a
Move colors to fmt (#571)
push time in 9 hours
push eventdenoland/deno
commit sha bdc0a13261deaa3748f51d9948b4e7b92864c324
doc: add CONTRIBUTING.md (#2813) Similar to React's CONTRIBUTING.md https://github.com/facebook/react/blob/master/CONTRIBUTING.md
push time in 11 hours
PR merged denoland/deno
Similar to React's CONTRIBUTING.md https://github.com/facebook/react/blob/master/CONTRIBUTING.md
pr closed time in 11 hours
push eventdenoland/deno
commit sha 137f33733d365026903d40e7cde6e34ac6c36dcf
port more ops to JSON (#2809)
push time in 12 hours
PR merged denoland/deno
- [x]
metrics.rs - [x]
net.ts - [x]
performance.rs - [x]
permissions.rs - [x]
process.rs - [x]
random.rs - [x]
repl.rs - [x]
resources.rs - [x]
timers.rs - [x]
workers.rs
pr closed time in 12 hours
Pull request review commentdenoland/deno
// Copyright 2018-2019 the Deno authors. All rights reserved. MIT license.-use super::dispatch_flatbuffers::serialize_response;-use super::utils::blocking;-use super::utils::ok_buf;-use super::utils::CliOpResult;-use crate::msg;+use super::dispatch_json::{blocking_json, Deserialize, JsonOp, Value}; use crate::repl; use crate::resources; use crate::state::ThreadSafeState; use deno::*;-use flatbuffers::FlatBufferBuilder;++#[derive(Deserialize)]+#[serde(rename_all = "camelCase")]+struct ReplStartArgs {+ history_file: String,+} pub fn op_repl_start( state: &ThreadSafeState,- base: &msg::Base<'_>,- data: Option<PinnedBuf>,-) -> CliOpResult {- assert!(data.is_none());- let inner = base.inner_as_repl_start().unwrap();- let cmd_id = base.cmd_id();- let history_file = String::from(inner.history_file().unwrap());+ args: Value,+ _zero_copy: Option<PinnedBuf>,+) -> Result<JsonOp, ErrBox> {+ let args: ReplStartArgs = serde_json::from_value(args)?; - debug!("op_repl_start {}", history_file);- let history_path = repl::history_path(&state.dir, &history_file);+ debug!("op_repl_start {}", args.history_file);+ let history_path = repl::history_path(&state.dir, &args.history_file); let repl = repl::Repl::new(history_path); let resource = resources::add_repl(repl); - let builder = &mut FlatBufferBuilder::new();- let inner = msg::ReplStartRes::create(- builder,- &msg::ReplStartResArgs { rid: resource.rid },- );- ok_buf(serialize_response(- cmd_id,- builder,- msg::BaseArgs {- inner: Some(inner.as_union_value()),- inner_type: msg::Any::ReplStartRes,- ..Default::default()- },- ))+ Ok(JsonOp::Sync(json!(resource.rid)))+}++#[derive(Deserialize)]+struct ReplReadlineArgs {+ rid: i32,+ prompt: String, } pub fn op_repl_readline( _state: &ThreadSafeState,- base: &msg::Base<'_>,- data: Option<PinnedBuf>,-) -> CliOpResult {- assert!(data.is_none());- let inner = base.inner_as_repl_readline().unwrap();- let cmd_id = base.cmd_id();- let rid = inner.rid();- let prompt = inner.prompt().unwrap().to_owned();+ args: Value,+ _zero_copy: Option<PinnedBuf>,+) -> Result<JsonOp, ErrBox> {+ let args: ReplReadlineArgs = serde_json::from_value(args)?;+ let rid = args.rid;+ let prompt = args.prompt; debug!("op_repl_readline {} {}", rid, prompt); - blocking(base.sync(), move || {- let repl = resources::get_repl(rid)?;+ // TODO(bartlomieju): this is a sync operation, why is it async in repl.ts?
Yes please
comment created time in 14 hours
Pull request review commentdenoland/deno
// Copyright 2018-2019 the Deno authors. All rights reserved. MIT license.-use super::dispatch_flatbuffers::serialize_response;-use super::utils::blocking;-use super::utils::ok_buf;-use super::utils::CliOpResult;-use crate::msg;+use super::dispatch_json::{blocking_json, Deserialize, JsonOp, Value}; use crate::repl; use crate::resources; use crate::state::ThreadSafeState; use deno::*;-use flatbuffers::FlatBufferBuilder;++#[derive(Deserialize)]+#[serde(rename_all = "camelCase")]+struct ReplStartArgs {+ history_file: String,+} pub fn op_repl_start( state: &ThreadSafeState,- base: &msg::Base<'_>,- data: Option<PinnedBuf>,-) -> CliOpResult {- assert!(data.is_none());- let inner = base.inner_as_repl_start().unwrap();- let cmd_id = base.cmd_id();- let history_file = String::from(inner.history_file().unwrap());+ args: Value,+ _zero_copy: Option<PinnedBuf>,+) -> Result<JsonOp, ErrBox> {+ let args: ReplStartArgs = serde_json::from_value(args)?; - debug!("op_repl_start {}", history_file);- let history_path = repl::history_path(&state.dir, &history_file);+ debug!("op_repl_start {}", args.history_file);+ let history_path = repl::history_path(&state.dir, &args.history_file); let repl = repl::Repl::new(history_path); let resource = resources::add_repl(repl); - let builder = &mut FlatBufferBuilder::new();- let inner = msg::ReplStartRes::create(- builder,- &msg::ReplStartResArgs { rid: resource.rid },- );- ok_buf(serialize_response(- cmd_id,- builder,- msg::BaseArgs {- inner: Some(inner.as_union_value()),- inner_type: msg::Any::ReplStartRes,- ..Default::default()- },- ))+ Ok(JsonOp::Sync(json!(resource.rid)))+}++#[derive(Deserialize)]+struct ReplReadlineArgs {+ rid: i32,+ prompt: String, } pub fn op_repl_readline( _state: &ThreadSafeState,- base: &msg::Base<'_>,- data: Option<PinnedBuf>,-) -> CliOpResult {- assert!(data.is_none());- let inner = base.inner_as_repl_readline().unwrap();- let cmd_id = base.cmd_id();- let rid = inner.rid();- let prompt = inner.prompt().unwrap().to_owned();+ args: Value,+ _zero_copy: Option<PinnedBuf>,+) -> Result<JsonOp, ErrBox> {+ let args: ReplReadlineArgs = serde_json::from_value(args)?;+ let rid = args.rid;+ let prompt = args.prompt; debug!("op_repl_readline {} {}", rid, prompt); - blocking(base.sync(), move || {- let repl = resources::get_repl(rid)?;+ // TODO(bartlomieju): this is a sync operation, why is it async in repl.ts?
readline could potentially be async...
comment created time in 14 hours
push eventdenoland/deno
commit sha 79f82cf10ed1dbf91346994250d7311a4d74377a
port ops to JSON: compiler, errors, fetch, files (#2804)
push time in 14 hours
PR merged denoland/deno
Based on #2802
- [x]
compiler.rs - [x]
errors.rs - [x]
fetch.rs - [x]
files.rs(sans,op_writeandop_read)
pr closed time in 14 hours
push eventdenoland/deno
commit sha 5b2baa5c990fbeae747e952c5dcd7a5369e950b1
Port rest of os ops to JSON (#2802)
push time in 15 hours
PR merged denoland/deno
pr closed time in 15 hours
Pull request review commentdenoland/deno
port ops to JSON (compiler, errors, fetch, files)
export class Response implements domTypes.Response { } } -function msgHttpRequest(- builder: flatbuffers.Builder,+interface FetchResponse {+ bodyRid: number;+ status: number;+ headers: Array<[string, string]>;+}++async function sendFetchReq( url: string,- method: null | string,- headers: null | domTypes.Headers-): flatbuffers.Offset {- const methodOffset = !method ? 0 : builder.createString(method);- let fieldsOffset: flatbuffers.Offset = 0;- const urlOffset = builder.createString(url);+ method: string | null,+ headers: domTypes.Headers | null,+ body: ArrayBufferView | undefined+): Promise<FetchResponse> {+ const serializedHeaders = [];
Maybe s/serializedHeaders/headerArray/ ?
maybe you can do
let headerArray = Array.from(headers.entries());
comment created time in a day
Pull request review commentdenoland/deno
port ops to JSON (compiler, errors, fetch, files)
export function asyncMsgFromRust(opId: number, ui8: Uint8Array): void { case OP_READ: minimal.asyncMsgFromRust(opId, ui8); break;+ case OP_EXIT:+ case OP_IS_TTY:+ case OP_ENV:+ case OP_EXEC_PATH: case OP_UTIME:+ case OP_APPLY_SOURCE_MAP:+ case OP_FORMAT_ERROR:+ case OP_CACHE:+ case OP_FETCH_SOURCE_FILE:+ case OP_OPEN:+ case OP_CLOSE:+ case OP_SEEK:+ case OP_FETCH:
Only put async ops in this list - that will induce an error through the default case below if we unexpectedly get an async response for a sync op.
comment created time in a day
pull request commentdenoland/deno_std
I'm having trouble running the tests with the big bundle file...
comment created time in a day
push eventry/deno
commit sha f49c4fe10efc7cd8fc81709d29604e72cded7a42
fix rebasing error
push time in a day
push eventry/deno
commit sha 8de1b7f1859dcc8e5181d85f759445fc15e9e36c
Port rest of os ops to JSON homeDir, setEnv, start
push time in a day
push eventry/deno
commit sha 6c7d337960b3745a7b614a18150862279ef1c942
Support .d.ts files (#2746) Fixes #1432
commit sha 31aa7c1a5d8a27c720b6255dc3eceda3707b1826
build: support rust crates that generate sources in their build script
commit sha e0c1ed96e22dc9a94cb5457c8b3eb2f2cd1af831
build: remove per-crate 'treat_warnings_as_errors' gn flag
commit sha 7a902fed04e23c2be6133024f7ad8fdebb641c60
build: add 'cap_lints' flag for rust crates Using a specialized flag rather than the generic 'args' option makes build_extra/rust/BUILD.gn shorter and more readable.
commit sha 7f9c6decc8982dc9dec762d6f2cc77c6bdd3f817
third_party: upgrade rust crates
commit sha 0809b06a3938868f364f1343b0de4d5d9686495d
v0.16.0
commit sha 47c216317f8eb5bf277663a732a79f6b07ba79ef
build: enable 'derive' feature of 'serde' crate
commit sha bc467b265fbe06ace24f5d9536bd8eb36ae4a601
introduce JSON serialization for ops (#2799) Converts env(), exit(), execPath(), utime() and utimeSync() to use JSON instead of flatbuffers.
commit sha 6e80c940f50f6aad853387499ec767af64ab5e03
Port rest of os ops to JSON homeDir, setEnv, start
push time in a day
push eventdenoland/deno
commit sha bc467b265fbe06ace24f5d9536bd8eb36ae4a601
introduce JSON serialization for ops (#2799) Converts env(), exit(), execPath(), utime() and utimeSync() to use JSON instead of flatbuffers.
push time in 2 days
PR merged denoland/deno
ref #2121
depends on #2796
next pr contains some examples of ops that have been ported https://github.com/denoland/deno/pull/2802
pr closed time in 2 days
push eventry/deno
commit sha 0809b06a3938868f364f1343b0de4d5d9686495d
v0.16.0
commit sha 47c216317f8eb5bf277663a732a79f6b07ba79ef
build: enable 'derive' feature of 'serde' crate
commit sha fd9de8bfa66034a23a3a0ecd66311fb400b1acf9
Merge remote-tracking branch 'piscisaureus/derive_feature' into json_ops
push time in 2 days
Pull request review commentdenoland/deno
Start porting flatbuffer ops to JSON
export function utimeSync( atime: number | Date, mtime: number | Date ): void {- sendSync(...req(filename, atime, mtime));+ sendSync(OP_UTIME, {+ filename,+ atime: toSecondsFromEpoch(atime),
I've added a TODO for this.
comment created time in 2 days
issue commentdenoland/deno
Convert all Flatbuffer ops to JSON
@s-panferov actually the opposite - we found flatbuffers too slow and we don’t yet know the speed of this JSON serialization. We have some ops which are very hot: Deno.read and Deno.write. These we converted to a custom serialization and got some perf increases.
The other ops are not measured in our benchmarks - so we don’t particularly care how fast they are. More important is the ease of implementing and maintaining them. The flatbuffer API is unfortunately very verbose. It also complicated our build at a time when we’re trying to move from gn/ninja to cargo based. So the JSON serialization will help simplify things and not effect the benchmarks.
comment created time in 2 days
Pull request review commentdenoland/deno
Start porting flatbuffer ops to JSON
export function utimeSync( atime: number | Date, mtime: number | Date ): void {- sendSync(...req(filename, atime, mtime));+ sendSync(OP_UTIME, {+ filename,+ atime: toSecondsFromEpoch(atime),
I also think it’s odd that this op takes seconds instead of something more precise but in this PR I’m only trying to change the serialization, not modify the logical messages or behavior of the ops. So I would prefer to do this later.
comment created time in 2 days
push eventry/deno
commit sha 31aa7c1a5d8a27c720b6255dc3eceda3707b1826
build: support rust crates that generate sources in their build script
commit sha e0c1ed96e22dc9a94cb5457c8b3eb2f2cd1af831
build: remove per-crate 'treat_warnings_as_errors' gn flag
commit sha 7a902fed04e23c2be6133024f7ad8fdebb641c60
build: add 'cap_lints' flag for rust crates Using a specialized flag rather than the generic 'args' option makes build_extra/rust/BUILD.gn shorter and more readable.
commit sha 7f9c6decc8982dc9dec762d6f2cc77c6bdd3f817
third_party: upgrade rust crates
commit sha 25e24fcf543b2d7ffc66b247cb0d7254204361da
Merge branch 'master' into json_ops
push time in 2 days
Pull request review commentdenoland/deno
env["GN_OUT_DIR"] = os.path.abspath(".") assert os.path.isdir(env["GN_OUT_DIR"]) +# Some crates (e.g. 'typenum') generate source files and place them in the+# directory indicated by the 'OUT_DIR' environment variable, which is normally+# set by Cargo. We pre-generate these files and store them in the source repo.+# Therefore, set 'OUT_DIR' so these crates can find their generated sources.
Build.rs gets executed when I run gnargo
Ah ok - got it.
comment created time in 2 days
Pull request review commentdenoland/deno
env["GN_OUT_DIR"] = os.path.abspath(".") assert os.path.isdir(env["GN_OUT_DIR"]) +# Some crates (e.g. 'typenum') generate source files and place them in the+# directory indicated by the 'OUT_DIR' environment variable, which is normally+# set by Cargo. We pre-generate these files and store them in the source repo.+# Therefore, set 'OUT_DIR' so these crates can find their generated sources.
The reason I'm asking is that build.rs support in rust.gni is my main hold up in importing deno_typescript into the main repo
comment created time in 2 days
Pull request review commentdenoland/deno
env["GN_OUT_DIR"] = os.path.abspath(".") assert os.path.isdir(env["GN_OUT_DIR"]) +# Some crates (e.g. 'typenum') generate source files and place them in the+# directory indicated by the 'OUT_DIR' environment variable, which is normally+# set by Cargo. We pre-generate these files and store them in the source repo.+# Therefore, set 'OUT_DIR' so these crates can find their generated sources.
Build.rs files have been supported for the entire time
Maybe I'm confused... is there an example third-party crate which executes its own build.rs ?
comment created time in 2 days
Pull request review commentdenoland/deno
env["GN_OUT_DIR"] = os.path.abspath(".") assert os.path.isdir(env["GN_OUT_DIR"]) +# Some crates (e.g. 'typenum') generate source files and place them in the+# directory indicated by the 'OUT_DIR' environment variable, which is normally+# set by Cargo. We pre-generate these files and store them in the source repo.+# Therefore, set 'OUT_DIR' so these crates can find their generated sources.
I was hoping this was general purpose support for build.rs files, but I guess not.
comment created time in 2 days
Pull request review commentdenoland/deno
https://github.com/denoland/deno/releases We also have one-line install commands at https://github.com/denoland/deno_install +### v0.16.0 / 2019.08.22++In deno:++- feat: "deno test" subcommand (#2783, #2784, #2800)+- feat: implement console.trace() (#2780)+- feat: support .d.ts files (#2746)+- feat: support custom inspection of objects (#2791)+- fix: dynamic import panic (#2792)+- fix: handle tsconfig.json with comments (#2773)+- fix: import map panics, use import map's location as its base URL (#2770)+- fix: set response.url (#2782)++In deno_std:++- feat: add overloaded form of unit test declaration (denoland/deno_std#563)+- feat: add printf implementation (fmt/sprintf.ts) (denoland/deno_std#566)+- feat: print out the failed tests after the summary (denoland/deno_std#554)+- feat: test runner (denoland/deno_std#516, denoland/deno_std#564,+ denoland/deno_std#568)+- fix: accept absolute root directories in the file server+ (denoland/deno_std#558)+- fix: refactor 'assertEquals' (denoland/deno_std#560)+- fix: test all text functions in colors module (denoland/deno_std#553)+
I don't usually list deno_install changes here
comment created time in 2 days
push eventdenoland/deno_install
commit sha 898e6c740fe63026e1c1680c74c68d22900ef950
Use DENO_INSTALL instead of DENO_DIR (#75)
push time in 2 days
PR merged denoland/deno_install
The install script is the only place in denoland where the cache directory variable $DENO_DIR is also used to determine Deno's installation directory. This separates the two into $DENO_DIR and $DENO_HOME.
Now $DENO_HOME can be set to a custom location in your profile (for updates or third party tools) without the cache defaulting to the same, potentially root-owned, location.
cc @ry
pr closed time in 2 days
Pull request review commentdenoland/deno_install
Use DENO_INSTALL instead of DENO_DIR
scoop install deno brew install deno ``` +## Environment Variables++- `DENO_INSTALL` - The directory in which to install Deno. This defaults to `$HOME/.deno`.+ Not yet supported in the PowerShell installer (#76).
Can you give a concrete example of usage here?
comment created time in 2 days
pull request commentdenoland/deno
how should we handle op_write and op_read that still use flatbuffers?
Just leave them in flatbuffers for now. I'll port them over to dispatch_minimal later.
comment created time in 2 days
PR opened denoland/deno
<!-- Before submitting a PR read https://deno.land/manual.html#contributing -->
pr created time in 2 days
Pull request review commentdenoland/deno
+// Copyright 2018-2019 the Deno authors. All rights reserved. MIT license.+import * as flatbuffers from "./flatbuffers";+import { DenoError } from "./errors";+import { core } from "./core";+import * as msg from "gen/cli/msg_generated";+import * as util from "./util";+import { OP_FLATBUFFER } from "./dispatch";+export { msg, flatbuffers };
I suspect the bundle size increase is a result of this line.
comment created time in 2 days
push eventry/deno
commit sha 6c7d337960b3745a7b614a18150862279ef1c942
Support .d.ts files (#2746) Fixes #1432
commit sha 0947ece4d625076ca3a73387f7ea939498c53623
cleanup
commit sha 50a1426a319a53a06359bae634ac0b1bde759077
Merge branch 'master' into json_ops
push time in 2 days
pull request commentdenoland/deno
This patch caused the compiler.js bundle to increase from 7.8 MB to 9.1 MB, which ultimately resulted in adding 2.5 MB to the final executable. This is bad and unexpected.
That said I don't want to revert it because it is preliminary work necessary for ultimately removing flatbuffers - which I think will have a very positive impact on the bundles and executable size.
comment created time in 2 days
pull request commentdenoland/deno
This patch seems to have reduced the thread count for cold_relative_import from 13 to 11. That pleasant but surprising.
comment created time in 2 days
pull request commentdenoland/deno
New dispatcher infrastructure.
@afinch7 It's probably more work, but I want to let the JSON ops settle in a bit before prescribing a new dispatch interface. I think we can find a lot of mini clean ups on that front and it won't be hard to then later modify the ops to use a dispatcher trait as you've outlined above.
I apologize because it massively conflicts with this patch - I'll help getting this rebased after #2799 (and any other conversions that are ready to land at the time).
comment created time in 2 days
push eventdenoland/deno
commit sha 6c7d337960b3745a7b614a18150862279ef1c942
Support .d.ts files (#2746) Fixes #1432
push time in 2 days
PR merged denoland/deno
Fixes #1432
I have a MVP where the following is working:
/// <deno-types path="./foo.d.ts" />
import * as foo from "./foo.js";
/// <deno-types path="./bar.d.ts" />
import * as bar from "./bar.js";
console.log(foo.foo, bar.bar);
Where instead of TypeScript trying to load foo.js and bar.js, it instead loads foo.d.ts and bar.d.ts. There are quite a few more scenarios that need to be supported and I need to try it out with some real world code, but it looks like it will work.
pr closed time in 2 days
issue closeddenoland/deno
I have a simple example here it's a .js file paired with a d.ts file and deno doesn't throw any type issues where typescript does.
import lodash from './deno_modules/lodash.js'
console.log(lodash.add('2', '2'))
Typescript does throw an issue here when run within the node runtime.
example.ts(2,24): error TS2345: Argument of type '"2"' is not assignable to parameter of type 'number'.
closed time in 2 days
reggi
Pull request review commentdenoland/deno
Start porting flatbuffer ops to JSON
+// Copyright 2018-2019 the Deno authors. All rights reserved. MIT license.+use crate::state::ThreadSafeState;+use crate::tokio_util;+use deno::*;+use futures::Future;+use futures::Poll;+pub use serde_derive::Deserialize;+use serde_json::json;+pub use serde_json::Value;++pub type AsyncJsonOp = Box<dyn Future<Item = Value, Error = ErrBox> + Send>;++pub enum JsonOp {+ Sync(Value),+ Async(AsyncJsonOp),+}++fn json_err(err: ErrBox) -> Value {+ use crate::deno_error::GetErrorKind;+ json!({+ "message": err.to_string(),+ "kind": err.kind() as u32,+ })+}++pub type Dispatcher = fn(+ state: &ThreadSafeState,+ args: Value,+ zero_copy: Option<PinnedBuf>,+) -> Result<JsonOp, ErrBox>;++fn serialize_result(+ promise_id: Option<u64>,+ result: Result<Value, ErrBox>,+) -> Buf {+ let value = match result {+ Ok(v) => json!({ "ok": v, "promiseId": promise_id }),+ Err(err) => json!({ "err": json_err(err), "promiseId": promise_id }),+ };+ let vec = serde_json::to_vec(&value).unwrap();+ vec.into_boxed_slice()+}++#[derive(Deserialize)]+#[serde(rename_all = "camelCase")]+struct AsyncArgs {+ promise_id: Option<u64>,+}++pub fn dispatch(+ d: Dispatcher,+ state: &ThreadSafeState,+ control: &[u8],+ zero_copy: Option<PinnedBuf>,+) -> CoreOp {+ let async_args: AsyncArgs = serde_json::from_slice(control).unwrap();
(Generally I'm trying to not be very prescriptive about the form of the JSON ops, because I'm not sure if there are any odd cases. Once everything is ported over, I think it will make sense to go back and and clean it up.)
comment created time in 2 days
Pull request review commentdenoland/deno
Start porting flatbuffer ops to JSON
+// Copyright 2018-2019 the Deno authors. All rights reserved. MIT license.+use crate::state::ThreadSafeState;+use crate::tokio_util;+use deno::*;+use futures::Future;+use futures::Poll;+pub use serde_derive::Deserialize;+use serde_json::json;+pub use serde_json::Value;++pub type AsyncJsonOp = Box<dyn Future<Item = Value, Error = ErrBox> + Send>;++pub enum JsonOp {+ Sync(Value),+ Async(AsyncJsonOp),+}++fn json_err(err: ErrBox) -> Value {+ use crate::deno_error::GetErrorKind;+ json!({+ "message": err.to_string(),+ "kind": err.kind() as u32,+ })+}++pub type Dispatcher = fn(+ state: &ThreadSafeState,+ args: Value,+ zero_copy: Option<PinnedBuf>,+) -> Result<JsonOp, ErrBox>;++fn serialize_result(+ promise_id: Option<u64>,+ result: Result<Value, ErrBox>,+) -> Buf {+ let value = match result {+ Ok(v) => json!({ "ok": v, "promiseId": promise_id }),+ Err(err) => json!({ "err": json_err(err), "promiseId": promise_id }),+ };+ let vec = serde_json::to_vec(&value).unwrap();+ vec.into_boxed_slice()+}++#[derive(Deserialize)]+#[serde(rename_all = "camelCase")]+struct AsyncArgs {+ promise_id: Option<u64>,+}++pub fn dispatch(+ d: Dispatcher,+ state: &ThreadSafeState,+ control: &[u8],+ zero_copy: Option<PinnedBuf>,+) -> CoreOp {+ let async_args: AsyncArgs = serde_json::from_slice(control).unwrap();
Improvements welcome.
comment created time in 3 days
push eventdenoland/deno
commit sha 1b7b5b26108d409f3bacbbe3cd308ffd6ea1219e
remove old tools/gn.rs
push time in 3 days
push eventdenoland/deno
commit sha 4519f9a50db8852c5b70ff47481f0fc9d0fbe2f2
Make Deno.execPath a function (#2743) And throws without allow-env
commit sha 77d0d1e45ccfd33a8a98e2f5fa4ba618759b5dd3
Fix small execPath issues (#2744)
commit sha 43d099c0275878f6c6358eb0e9a0094d076d7c29
Fix incremental 'cargo build' (#2740) Tip: RUSTC_WRAPPER should be unset for incremental builds to work.
commit sha 5350abbc7ffdba6d17166fa00ad89e86979a43f7
manual: Edit note about V8 profiling (#2742)
commit sha e438ac2c74c823882dc9c9ecde2a9e9ed7bcfb4b
Add op_id throughout op API (#2734) Removes the magic number hack to switch between flatbuffers and the minimal dispatcher. Adds machinery to pass the op_id through the shared_queue.
commit sha 520bdb6c31dd08b6f4e52de5116fd23d6d57fdda
Fix repl crash when deno dir doesn't exist (#2727)
commit sha 56a82e72d9867a9b5f8a10bc8e4b81b86cd815c9
Resolve worker specifiers relative to main module of host. (#2751)
commit sha 6fbf2e96243e6b79c1fb03c17b376b028e442694
Dynamic import (#2516)
commit sha 83d5362f1d7d8589b862de57912135067a8278c7
v0.14.0
commit sha 286ee1d8b68b54d39e698f3b78e3ce9e257fa674
Fix dynamic import base path problem for REPL and eval (#2757)
commit sha 54982e948e882fbf413e06319f711d85b232026b
fix: cache paths on Windows are broken (#2760)
commit sha 9bd473d8ac9228e483bd26028dbe7ba88e971c08
feat: print cache location when no arg in deno info (#2752)
commit sha c3afa557515c64610b23ee460f8c6251de421f1a
Propagate Url::to_file_path() errors instead of panicking (#2771) * Propagate Url::to_file_path() errors instead of panicking
commit sha 1947f572d735096c1ccd7de2c386b8289c287701
Fix permission requirements for Deno.rename() and Deno.link() (#2737)
commit sha 1f8b1a587c397dd01e058820769580323a0f7330
Dynamic import should respect permissions (#2764)
commit sha 58f0e9b9b1b53ca486ef38ae662b98cbde839248
v0.15.0
commit sha e6c349af9f7260c2c4ec713bd231fe554240721e
split up ops.rs (#2753) Note cli/dispatch_minimal.rs ops are not yet included in cli/ops. This is part of work towards #2730
commit sha 498f6ad431478f655b136782093e19e29248b24d
Remove dead code: legacy read/write ops (#2776) readSync and writeSync use dispatch_minimal now.
commit sha d2d3afaf2de3cc9709cdf145c2f9438d3a4fa8a1
add deno test subcommand (#2783)
commit sha 52a66c2796f97f5a08d679389172c39c0652cb16
Fix import map panics, use import map's location as its base URL (#2770)
push time in 3 days
push eventMarkTiedemann/deno_std
commit sha 5e77e8adc70f9fffc88a86e18608283b0e10848e
Make shebangs Linux compatible (#545)
commit sha 826deb1012d3595c3f6de19659e13564a15ceda1
Ignore error of writing responses to aborted requests (#546)
commit sha 287b0a9cd259952387739405152e031e9abcdb63
refactor: use Deno.execPath where possible (#548)
commit sha 28ae08b4244cda59379e25b523c3490edbaa7ce2
enable test of aborted conn on windows (#549)
commit sha 6d78eec41306b98943847a5d1ec3bcaf389698fd
Fix URLs in examples/README (#551)
commit sha 3e17815c7e61cfd2e4c46a12649811543509d563
Revert "http: delete conn parameter in readRequest" (#550) This reverts commit 209183e24812095a40e48e60484f80a5a254b1c3. Fixes: #441
commit sha f3ddb4f26b81b4fbed86f4b54db7b3e7e3b7fe4e
ci: bump to v0.15.0 (#556)
commit sha ff2d7f24dbc955650a11fc8db2f35c0aa38dcdb1
refactor 'assertEquals' (#560) * merge 'testing/pretty.ts' into 'testing/asserts.ts' * throw AssertionError in assertEquals * update misc tests use AssertionError
commit sha bd146e0188dbd2c4a802e0af6e6b0705675c4abb
feat: add overloaded form of unit test declaration (#563)
commit sha c44e5367bfd08d7a69adfa3434c00991509c4a67
feat: test runner (#516)
commit sha 15afc61356afe0bbf36c78cc3da8d9182d0e5b75
add file:// prefix for imports in test runner (#564)
commit sha f7b511611ca5bc3801d6f210d82bddce9b0a61e4
Add fmt modules (printf implementation) (#566)
commit sha 262d9572ab4078b8d886a21474a5a246cacb5def
Accept absolute root directories in the file server (#558)
commit sha b5ded6ccbf03c93155dd6aae85a8408b6b315d7a
Fix typo in examples/README.md (#567)
commit sha 4531fa81597c346fd291c1d1a2063789369fb84d
fix: add global test registry (#568) After adding deno test command a new problem appeared. If you try running deno test inside this repo test runner will find 80 test files but won't run any tests! This is caused by fact that deno test uses tagged version of standard library which causes test function available inside to repo to be different function that test available in standard lib used by deno test.
commit sha f1c4c1a1626f4d794f05cb033eddfa43a3502e5c
test all text functions in colors module (#553)
commit sha d7a837d599ca7d5c489d6c74b7bd42d22a3314eb
use relative paths in test imports (#572)
commit sha ed1b9e0563e0f22eb6415b248d6218e75e500783
print out the failed tests after the summary (#554)
commit sha 6071e9832be673829f7f29e0dee7768ad7dd4dac
Merge branch 'master' into port-jsdom
push time in 3 days
push eventdenoland/deno_std
commit sha ed1b9e0563e0f22eb6415b248d6218e75e500783
print out the failed tests after the summary (#554)
push time in 3 days
PR merged denoland/deno_std
We have 575 tests and it is a problem to scroll up the terminal to see which tests failed. So I added a summary of all the failed tests down under with a red label next to them.
These changes will only affect cases when we have failed tests (If all tests pass, it will look like before.)
Also some refactoring to use existing TestResult model and populate it with the test results. We only initialized it before when going Serial testing and could not extract the details from each test afterwards.
proposed look :
pr closed time in 3 days
push eventry/deno_std
commit sha dfa7ee4c433e14057ae856c8cc75bb226a42b504
Move colors to fmt
push time in 3 days
push eventry/deno_std
commit sha f1c4c1a1626f4d794f05cb033eddfa43a3502e5c
test all text functions in colors module (#553)
commit sha d7a837d599ca7d5c489d6c74b7bd42d22a3314eb
use relative paths in test imports (#572)
commit sha 7322cc7a29cd997566934cea0453a7f77ccafe97
Move colors to fmt
commit sha 65fe1159e337e16855e73c7ba355bb098ae3f9dd
fix
push time in 3 days
push eventdenoland/deno_std
commit sha d7a837d599ca7d5c489d6c74b7bd42d22a3314eb
use relative paths in test imports (#572)
push time in 3 days
push eventdenoland/deno_std
commit sha f1c4c1a1626f4d794f05cb033eddfa43a3502e5c
test all text functions in colors module (#553)
push time in 3 days
PR merged denoland/deno_std
test all the text functions inside the colors module
pr closed time in 3 days
pull request commentdenoland/deno_std
print out the failed tests after the summary
@bartlomieju PTAL
comment created time in 3 days
issue openeddenoland/deno_std
deno test doesn't work with URLs
> deno test https://deno.land/std/fmt/sprintf_test.ts -A
No matching test files found.
created time in 3 days
issue openeddenoland/deno_std
deno test doesn't work on subdirs
~/src/deno_std> deno test ./fmt/
Found 4 matching test files.
error: Uncaught SyntaxError: Unexpected token '*'
► file:///Users/rld/src/deno_std/fmt/TODO:2:1
2 * "native" formatting, json, arrays, object/structs, functions ...
^
created time in 3 days
push eventry/deno
commit sha aa4e39609a4aa695a45e539d1225fc1e8c95bc97
cleanup
commit sha 6f158fe8481313d5934cb442396572850360c8d9
cleanup
push time in 3 days
push eventry/deno
push time in 3 days
push eventry/deno
commit sha d67c33287fdc2c03e9efc25364185c6254792db4
fix op dispatch/completed metrics
commit sha 3aa91a8e0d5166db30b066e724c9061dedf0d5d5
Port Deno.setEnv to JSON
commit sha 2e74a66417ef4e2193bdeed6467cbb983b152d8a
Port Deno.homeDir() to JSON
commit sha 79747c8687750b200892f35697622c0c604f739e
Port start op to JSON
commit sha fa101c1ef1ecf89aa989c42956cb1b5613dcdf61
fix op dispatch/completed metrics
push time in 3 days
push eventry/deno
commit sha d67c33287fdc2c03e9efc25364185c6254792db4
fix op dispatch/completed metrics
push time in 3 days
push eventry/deno
push time in 3 days
PR opened denoland/deno
pr created time in 3 days
push eventry/deno
commit sha 28f77782f4667a0a9aa8071888ee75b032122576
fix op dispatch/completed metrics
push time in 3 days
push eventry/deno
commit sha 8675c274481b8d3ac48a6166e54eaa435b03ba8a
Port start op to JSON
push time in 3 days
push eventry/deno
commit sha 2fc2c9383e1d753915ed9ceb81232792b3172555
Port Deno.homeDir() to JSON
push time in 3 days
push eventry/deno
commit sha b342be2622d5a878d970511b7716f0eb6d6997e5
Convert Deno.homeDir() to JSON
push time in 3 days
pull request commentdenoland/registry
Extract the embedded HTML/CSS out of the code render page
I've deployed this to the site, but it looks odd:
comment created time in 3 days
issue openeddenoland/deno
Convert all Flatbuffer ops to JSON
To all contributors who are listening -
We want to convert all of the flatbuffer ops to JSON. Here is a commit showing how to do it.
There's many ops to convert, and if you are interested, this is would be a helpful contribution.
I'm currently working on js/os.ts - please let me know if you want to work on some of the ops, I'll try to coordinate so people in an issue if anyone's interested.
Here is a list of ops we need to convert:
compiler.rs
errors.rs
fetch.rs
files.rs
fs.rs
io.rs
metrics.rs
mod.rs
net.rs
os.rs // @ry
performance.rs
permissions.rs
process.rs
random.rs
repl.rs
resources.rs
timers.rs
utils.rs
workers.rs
created time in 3 days
push eventry/deno
commit sha 8efb8cdb268c7fa00e64e9e3b71052bfd65ef72a
Port Deno.setEnv to JSON
push time in 3 days
push eventry/deno
commit sha 389763c04e3102d5b8261a10bb7514ba046fe373
bump test runner revision (#2800)
commit sha b764d1b8ffc4bf5e2ab89bdbd978d708a6da0f24
fix: dynamic import panic (#2792)
commit sha bdc97b3976786bb744a27e59b0f4f28554a682df
Organize dispatch a bit (#2796) Just some clean up reorganization around flatbuffer/minimal dispatch code. This is prep for adding a JSON dispatcher.
commit sha 846d91b7b1ba7988dc2c468f5ad07b85b7e8ea29
Add ability to dispatch ops using JSON Converts env(), exit(), execPath(), utime() and utimeSync() to use JSON instead of flatbuffers.
push time in 3 days
push eventdenoland/deno
commit sha bdc97b3976786bb744a27e59b0f4f28554a682df
Organize dispatch a bit (#2796) Just some clean up reorganization around flatbuffer/minimal dispatch code. This is prep for adding a JSON dispatcher.
push time in 3 days
PR merged denoland/deno
Just some clean up reorganization around flatbuffer/minimal dispatch code. This is prep for adding a JSON dispatcher.
pr closed time in 3 days
push eventdenoland/deno
commit sha b764d1b8ffc4bf5e2ab89bdbd978d708a6da0f24
fix: dynamic import panic (#2792)
push time in 3 days
PR merged denoland/deno
Reproduction:
// dyn_import_panic.ts
async function main() {
const root = `file://${Deno.cwd()}/`;
await import(root + "foo.js");
await import(root + "README.md");
}
main();
This panic occurred only if there was error for 2nd and following dynamic imports.
Before:
thread 'tokio-runtime-worker-1' panicked at 'assertion failed: `(left == right)`
left: `1`,
right: `0`', ../../core/isolate.rs:507:7
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
thread 'main' panicked at 'internal error: entered unreachable code', ../../third_party/rust_crates/registry/src/github.com-1ecc6299db9ec823/tokio-0.1.22/src/runtime/threadpool/mod.rs:296:26
thread 'tokio-runtime-worker-2' panicked at 'unexpected state while aborting task: Complete', ../../third_party/rust_crates/registry/src/github.com-1ecc6299db9ec823/tokio-threadpool-0.1.15/src/task/mod.rs:216:21
^C
After:
error: Uncaught SyntaxError: Invalid or unexpected token
► file:///Users/biwanczuk/dev/deno/README.md:1:1
1 # deno
^
CC @ry
pr closed time in 3 days
push eventry/deno
commit sha 5cbdd908d6cb179019ef93cb682d715dc6d43f6f
Organize op dispatch a bit Just some clean up reorganization around flatbuffer/minimal dispatch code. This is prep for adding a JSON dispatcher.
commit sha 90c00ecf453264985e12da4feabfac1b0aab7b1f
Add ability to dispatch ops using JSON Converts env(), exit(), execPath(), utime() and utimeSync() to use JSON instead of flatbuffers.
push time in 3 days
push eventry/deno
commit sha d46ddb14dd2316e726151eb387d62af423d46bb4
Organize op dispatch a bit Just some clean up reorganization around flatbuffer/minimal dispatch code. This is prep for adding a JSON dispatcher.
commit sha 2774da21e5e3574a966a0be40aee80a38d371a87
Add ability to dispatch ops using JSON Converts env(), exit(), execPath(), utime() and utimeSync() to use JSON instead of flatbuffers.
push time in 3 days
push eventry/deno
commit sha d46ddb14dd2316e726151eb387d62af423d46bb4
Organize op dispatch a bit Just some clean up reorganization around flatbuffer/minimal dispatch code. This is prep for adding a JSON dispatcher.
push time in 3 days
PR closed denoland/deno
This commit checks into the repo the two generated files cli/msg_generated.rs js/msg_generated.js And removes support for automatically building them from the build.
This is further simplifications in order to allow the cli crate to build without gn/ninja. See #2608.
<!-- Before submitting a PR read https://deno.land/manual.html#contributing -->
pr closed time in 3 days
pull request commentdenoland/deno
Remove flatbuffers compile support
Porting ops to JSON is actually going smoothly. I want to delay ripping out the build support for flatbuffers, as I think we can do it better gradually as in #2799 ...
I hope to re-apply this in a few days but without having to add the generated files to repo.
comment created time in 3 days