ry ( Ryan Dahl )

push time in 2 hours

PR merged denoland/deno

Typo

+9 -9

2 commit in sfabriece/deno/tree/patch-1 denoland/deno/tree/master

1 comment

1 changed file

sfabriece

pr closed time in 2 hours

push eventbartlomieju/deno

commit sha 9564705554d219831f69ebc8b54761c8440fb973

fix var names

push time in 2 hours

push eventdenoland/rusty_v8

commit sha aca89c2055f31134c2f0adc2817e95f3af29abc1

new_backing_store_from_boxed_slice doesn't need to be unsafe (#247)

push time in 2 hours

PR merged denoland/rusty_v8

ArrayBuffer::new_backing_store_from_boxed_slice doesn't need to be un…

…safe

+10 -9

1 commit in ry/rusty_v8/tree/new_backing_store_from_boxed_slice denoland/rusty_v8/tree/master

0 comment

2 changed files

ry

pr closed time in 2 hours

push eventbartlomieju/deno

commit sha 48e4c6f2fd92e5650ee7511188681704d135e485

move unsafe inside boxed_slice_to_uint8array

push time in 2 hours

push eventsfabriece/deno

commit sha ca0daa20d36fca7476d855483ab29f5cf3db907b

fmt

refactor: remove Isolate.shared_response_buf

push time in 2 hours

Pull request review commentdenoland/deno

 pub fn initialize_context<'s>(   scope.escape(context) } -pub unsafe fn slice_to_uint8array<'sc>(-  deno_isolate: &mut Isolate,+pub unsafe fn boxed_slice_to_uint8array<'sc>(

ref https://github.com/denoland/rusty_v8/pull/247

bartlomieju

comment created time in 3 hours

PR opened denoland/rusty_v8

ArrayBuffer::new_backing_store_from_boxed_slice doesn't need to be un…

…safe

+10 -9

1 commit in ry/rusty_v8/tree/new_backing_store_from_boxed_slice denoland/rusty_v8/tree/master

0 comment

2 changed files

pr created time in 3 hours

create barnchry/rusty_v8

branch : new_backing_store_from_boxed_slice

created branch time in 3 hours

Pull request review commentdenoland/deno

refactor: remove Isolate.shared_response_buf

 pub fn initialize_context<'s>(   scope.escape(context) } -pub unsafe fn slice_to_uint8array<'sc>(-  deno_isolate: &mut Isolate,+pub unsafe fn boxed_slice_to_uint8array<'sc>(

I think the unsafe can be moved inside the function to only surround the new_backing_store_from_boxed_slice.

bartlomieju

comment created time in 3 hours

pull request commentdenoland/deno

Add signal handlers

@kt3k Is this working now? It looks like it. Please give an update : )

kt3k

comment created time in 3 hours

issue commentdenoland/deno

fetch cache

Yes, I agree. It would be ideal it could be done at the rust level....

brandonkal

comment created time in 3 hours

issue commentdenoland/rusty_v8

unknown argument: '-gno-inline-line-tables'

@hayd Yes, do you know how to do that? You need to add a new "arg" to the declare_args block at the top of //build/config/compiler/BUILD.gn.

We probably need to add a cargo feature to toggle it... We don't have an example of this yet.

hayd

comment created time in 3 hours

PR closed denoland/deno

v0.30.2

This patch release is being done only to test crate publishing, hence lack of release notes or published binaries.

+15 -15

1 commit in ry/deno/tree/bump-v0.30.2 denoland/deno/tree/master

0 comment

4 changed files

ry

pr closed time in 18 hours

push eventdenoland/deno_website2

Elias

commit sha 4b13c7ea8a8b93d6c796d9d9de1ff3e46a9a2e12

Add denon (#206)

push time in 19 hours

PR merged denoland/deno_website2

Add denon

Like nodemon but made in and for deno. Also a deno style file watcher.

+6 -0

1 commit in eliassjogreen/deno_website2/tree/patch-1 denoland/deno_website2/tree/master

1 comment

1 changed file

eliassjogreen

pr closed time in 19 hours

Pull request review commentdenoland/deno

 fn main() {   let c = PathBuf::from(env::var_os("CARGO_MANIFEST_DIR").unwrap());   let o = PathBuf::from(env::var_os("OUT_DIR").unwrap()); -  let custom_libs = vec![(-    "lib.deno_runtime.d.ts".to_string(),-    c.join("js/lib.deno_runtime.d.ts"),-  )];-+  // Main snapshot   let root_names = vec![c.join("js/main.ts")];-  let bundle = o.join("CLI_SNAPSHOT.js");-  let state =-    deno_typescript::compile_bundle(&bundle, root_names, Some(custom_libs))-      .unwrap();-  assert!(bundle.exists());-  deno_typescript::mksnapshot_bundle(&bundle, state).unwrap();--  let custom_libs = vec![(+  let bundle_path = o.join("CLI_SNAPSHOT.js");+  let snapshot_path = o.join("CLI_SNAPSHOT.bin");++  let main_module_name =+    deno_typescript::compile_bundle(&bundle_path, root_names)+      .expect("Bundle compilation failed");+  assert!(bundle_path.exists());++  let runtime_isolate = &mut Isolate::new(StartupData::None, true);++  deno_typescript::mksnapshot_bundle(+    runtime_isolate,+    &snapshot_path,+    &bundle_path,+    &main_module_name,+  )+  .expect("Failed to create snapshot");++  // Compiler snapshot+  let root_names = vec![c.join("js/compiler.ts")];+  let bundle_path = o.join("COMPILER_SNAPSHOT.js");+  let snapshot_path = o.join("COMPILER_SNAPSHOT.bin");+  let mut custom_libs: HashMap<String, PathBuf> = HashMap::new();+  custom_libs.insert(     "lib.deno_runtime.d.ts".to_string(),     c.join("js/lib.deno_runtime.d.ts"),-  )];+  ); -  let root_names = vec![c.join("js/compiler.ts")];-  let bundle = o.join("COMPILER_SNAPSHOT.js");-  let state =-    deno_typescript::compile_bundle(&bundle, root_names, Some(custom_libs))-      .unwrap();-  assert!(bundle.exists());-  deno_typescript::mksnapshot_bundle_ts(&bundle, state).unwrap();+  let main_module_name =+    deno_typescript::compile_bundle(&bundle_path, root_names)+      .expect("Bundle compilation failed");+  assert!(bundle_path.exists());++  let runtime_isolate = &mut Isolate::new(StartupData::None, true);+  runtime_isolate.register_op("fetch_asset", make_op_fetch_asset(custom_libs));

This is cleaner, I agree

bartlomieju

comment created time in 20 hours

Pull request review commentdenoland/deno

 // Copyright 2018-2020 the Deno authors. All rights reserved. MIT license.+use deno_core::CoreOp;+use deno_core::Isolate;+use deno_core::Op;+use deno_core::PinnedBuf;+use deno_core::StartupData;+use std::collections::HashMap; use std::env; use std::path::PathBuf; +fn make_op_fetch_asset(

s/make_//

bartlomieju

comment created time in 20 hours

Pull request review commentdenoland/deno

Vendor Acorn; Use Acorn parser in REPL

 struct ReadFile {   should_create_new_source_file: bool, } -pub fn read_file(s: &mut TSState, v: Value) -> Result<Value, ErrBox> {+pub fn read_file(_s: &mut TSState, v: Value) -> Result<Value, ErrBox> {   let v: ReadFile = serde_json::from_value(v)?;   let (module_name, source_code) = if v.file_name.starts_with("$asset$/") {     let asset = v.file_name.replace("$asset$/", ""); -    let source_code = match s.custom_assets.get(&asset) {-      Some(asset_path) => std::fs::read_to_string(&asset_path)?,-      None => crate::get_asset2(&asset)?.to_string(),+    let source_code = match crate::get_asset(&asset) {+      Some(code) => code.to_string(),+      None => {+        return Err(+          std::io::Error::new(std::io::ErrorKind::NotFound, "Asset not found")+            .into(),+        );+      }     };      (asset, source_code)   } else {     assert!(!v.file_name.starts_with("$assets$"), "you meant $asset$");     let module_specifier = ModuleSpecifier::resolve_url_or_path(&v.file_name)?;     let path = module_specifier.as_url().to_file_path().unwrap();+    // TODO(bartlomieju): has no effect on cli crate, still rebuilds every time     println!("cargo:rerun-if-changed={}", path.display());

I'm not sure this comment is true. If you "touch cli/lib.rs" it will not cause a rebuild of the snapshot, but if you do "touch cli/js/main.ts" it will rebuild the snapshot - which is what we want.

bartlomieju

comment created time in 20 hours

PR closed denoland/deno

Vendor Acorn; Use Acorn parser in REPL

If accepted, would close #3112

Add Acorn and use it to check if REPL input is terminated. This is basically adapted from corresponding Node.js code.

+7080 -26

2 commit in kevinkassimo/deno/tree/repl/acorn denoland/deno/tree/master

9 comments

4 changed files

kevinkassimo

pr closed time in 21 hours

pull request commentdenoland/deno

Closing this one because we don't want to add another parser. But thank you for the patch @kevinkassimo it will be instructive to have this. We should either be using TS or V8 parser.

kevinkassimo

comment created time in 21 hours

Pull request review commentdenoland/deno

Basic values in deno repl are considered "syntax errors"

 // Copyright 2018-2020 the Deno authors. All rights reserved. MIT license.+use deno_core::CoreOp;+use deno_core::ErrBox;+use deno_core::Isolate;+use deno_core::Op;+use deno_core::PinnedBuf;+use deno_core::StartupData;+use serde_json::json;+use serde_json::Value;+use std::collections::HashMap; use std::env; use std::path::PathBuf; +fn inner_fetch_asset(+  custom_assets: HashMap<String, PathBuf>,+  v: Value,+) -> Result<Value, ErrBox> {+  let name = v["name"].as_str().unwrap();++  if let Some(source_code) = deno_typescript::get_asset(name) {+    return Ok(json!(source_code));+  }++  if let Some(asset_path) = custom_assets.get(name) {+    let source_code_vec = std::fs::read(&asset_path)?;+    let source_code = std::str::from_utf8(&source_code_vec)?;+    return Ok(json!(source_code));+  }++  panic!("op_fetch_asset bad asset {}", name)+}++fn make_op_fetch_asset(+  custom_assets: HashMap<String, PathBuf>,+) -> impl Fn(&[u8], Option<PinnedBuf>) -> CoreOp {+  move |control: &[u8], zero_copy_buf: Option<PinnedBuf>| -> CoreOp {+    assert!(zero_copy_buf.is_none()); // zero_copy_buf unused in this op.+    let custom_assets = custom_assets.clone();+    let result = serde_json::from_slice(control)+      .map_err(ErrBox::from)+      .and_then(move |args| inner_fetch_asset(custom_assets, args));++    let response = match result {+      Ok(v) => json!({ "ok": v }),+      Err(err) => json!({ "err": err.to_string() }),+    };++    let x = serde_json::to_string(&response).unwrap();+    let vec = x.into_bytes();+    Op::Sync(vec.into_boxed_slice())+  }+}

There's no way to unit test this, since it's defined in build.rs

Also I wonder if JSON could be avoided here.

bartlomieju

comment created time in 21 hours

issue closeddenoland/deno

The Deno repl is very... well, unhelpful I'd say. Aside from the fact I can't actually run typescript in it, it also doesn't allow very basic values:

> {"foo":"bar"}
error: Uncaught SyntaxError: Unexpected token ':'
► <unknown>:1:7
    at evaluate ($deno$/repl.ts:84:34)
    at replLoop ($deno$/repl.ts:175:13)

Valid javascript, valid typescript. Why is this a syntax error?

closed time in a day

Qix-

issue commentdenoland/deno

deno crate fails to build on WSL (win10) ubuntu

Maybe we should update the manual with this information?

rvdende

comment created time in a day

Pull request review commentdenoland/deno

Reland "Create an old program to be used in snapshot."

 fn main() {     deno_typescript::ts_version()   ); -  let c = PathBuf::from(env::var_os("CARGO_MANIFEST_DIR").unwrap());-  let o = PathBuf::from(env::var_os("OUT_DIR").unwrap());--  let root_names = vec![c.join("js/main.ts")];-  let bundle = o.join("CLI_SNAPSHOT.js");-  let state = deno_typescript::compile_bundle(&bundle, root_names).unwrap();-  assert!(bundle.exists());-  deno_typescript::mksnapshot_bundle(&bundle, state).unwrap();--  let root_names = vec![c.join("js/compiler.ts")];-  let bundle = o.join("COMPILER_SNAPSHOT.js");-  let state = deno_typescript::compile_bundle(&bundle, root_names).unwrap();-  assert!(bundle.exists());-  deno_typescript::mksnapshot_bundle_ts(&bundle, state).unwrap();+  create_main_snapshot();+  create_compiler_snapshot();

The problem with having a bunch of code in build.rs is that none of it can be unit tested. This code will only be tested through the build process. It seems we should strive to keep it as small as possible.

bartlomieju

comment created time in a day

Pull request review commentdenoland/deno

Reland "Create an old program to be used in snapshot."

 name = "deno" path = "main.rs"  [build-dependencies]+deno_core = { path = "../core", version = "0.30.1" } deno_typescript = { path = "../deno_typescript", version = "0.30.1" }+serde = { version = "1.0.104", features = ["derive"] }+serde_derive = "1.0.104"+serde_json = { version = "1.0.44", features = [ "preserve_order" ] }

This bit is annoying...

bartlomieju

comment created time in a day

Pull request review commentdenoland/deno

Reland "Create an old program to be used in snapshot."

 // Copyright 2018-2020 the Deno authors. All rights reserved. MIT license.+use deno_core::js_check;+use deno_core::CoreOp;+use deno_core::ErrBox;+use deno_core::Isolate;+use deno_core::Op;+use deno_core::PinnedBuf;+use deno_core::StartupData;+use serde::Deserialize;+use serde_json::json;+use serde_json::Value; use std::env;+use std::fs; use std::path::PathBuf; +#[derive(Deserialize)]+struct FetchAssetArgs {+  name: String,+}++fn op_fetch_asset(+  custom_assets: Vec<(String, PathBuf)>,+  control: &[u8],+) -> CoreOp {+  let result = serde_json::from_slice(control)+    .map_err(ErrBox::from)+    .and_then(move |args| inner_fetch_asset(custom_assets, args));++  let response = match result {+    Ok(v) => json!({ "ok": v }),+    Err(err) => json!({ "err": err.to_string() }),+  };+

It seems the use of serde here isn't adding that much. What about returning the asset as a raw byte array?

bartlomieju

comment created time in a day

PR opened denoland/deno

Remove cargo-package test

The test still relies on crates published to crates.io, thus this test prevents us from making changes to the API used between cli and deno_typescript.

+1 -16

1 commit in ry/deno/tree/remove_cargo_package_test denoland/deno/tree/master

0 comment

1 changed file

pr created time in a day

create barnchry/deno

branch : remove_cargo_package_test

created branch time in a day

push eventry/deno

commit sha a8bda560e238181d6c5b01affe328bee4503b9e8

Change 'cargo publish' test to only do 'cargo package' (#3750) It was found the cargo-package-dry-run test would fail when version numbers are bumped because crates were not actually published. So, for example, deno_typescript 0.30.2 would not be able to find deno_core 0.30.2 because it had not yet been published (see #3744). Ref #3712

commit sha a6603b3fd6c5f2dc78a9bdbd86bacb9e8100923c

v0.30.2 This patch release is being done only to test crate publishing, hence lack of release notes or published binaries.

Changes to API in `deno_core` crate causes `test_publish` to fail

push time in a day

issue commentdenoland/deno

see https://github.com/denoland/deno/pull/3750

afinch7

comment created time in a day

PR opened denoland/deno

Change 'cargo publish' test to only do 'cargo package'

It was found the cargo-package-dry-run test would fail when version numbers are bumped because crates were not actually published. So, for example, deno_typescript 0.30.2 would not be able to find deno_core 0.30.2 because it had not yet been published (see #3744). Ref #3712

+12 -6

1 commit in ry/deno/tree/ci_package denoland/deno/tree/master

0 comment

1 changed file

pr created time in a day

create barnchry/deno

branch : ci_package

created branch time in a day

push eventdenoland/rusty_v8

Andy Finch

commit sha d302180ffaf5ad0970685e5b8c25dbaa70af4038

remove `pub use support::int;` #235 (#239)

`int` should not be part of the public interface

push time in a day

PR merged denoland/rusty_v8

remove `pub use support::int;` #235

fixes #235

+0 -1

1 commit in afinch7/rusty_v8/tree/remove_pub_use_int denoland/rusty_v8/tree/master

0 comment

1 changed file

afinch7

pr closed time in a day

issue closeddenoland/rusty_v8

https://docs.rs/rusty_v8/0.1.1/rusty_v8/type.int.html

closed time in a day

ry

Pull request review commentdenoland/deno

Reland "Create an old program to be used in snapshot."

 impl TSIsolate {     self.isolate.execute("<anon>", source)?;     Ok(self.state)   }++  pub fn add_custom_assets(&mut self, custom_assets: Vec<(String, PathBuf)>) {+    let mut state = self.state.lock().unwrap();+    for (name, path) in custom_assets {+      state.custom_assets.insert(name, path);+    }+  } }  pub fn compile_bundle(   bundle: &Path,   root_names: Vec<PathBuf>,+  custom_assets: Option<Vec<(String, PathBuf)>>,

Nice work. I think this will solve the situation. It would be nice to have a unit test of this in action.

bartlomieju

comment created time in a day

push eventdenoland/deno_website2

Yoshiya Hinosawa

commit sha f22846e8096d0a0b35d3c271f66b2bb8b5745d22

feat: better page titles (#205)

The title of top page doesn't look beautiful.

push time in a day

PR merged denoland/deno_website2

feat: better page titles

~~react-helmet is a library for setting the contents in <head> tag such as <title>, <meta>, etc.~~

~~This PR introduces react-helmet, and gives more sensible titles to each page.~~

This PR introduces Title component for setting the titles in the page components.

closes #204

+35 -7

4 commit in kt3k/deno_website2/tree/feature/better-title denoland/deno_website2/tree/master

2 comments

6 changed files

kt3k

pr closed time in a day

issue closeddenoland/deno_website2

The top page's title is now deno /. This doesn't look ideal. This also affects the title in the google search result page.

スクリーンショット 2020-01-21 15 15 51

closed time in a day

kt3k

pull request commentdenoland/deno

Revert "Create an old program to be used in snapshot. (#3644)"

Do you think a symbolic link to the file work?

No cargo package doesn't allow symbol links. My guess is we need a way to dynamically provide assets when calling mksnapshot_bundle and mksnapshot_bundle_ts.

ry

comment created time in 2 days

PR opened denoland/deno

v0.30.2

This patch release is being done only to test crate publishing, hence lack of release notes or published binaries.

+15 -15

1 commit in ry/deno/tree/bump-v0.30.2 denoland/deno/tree/master

0 comment

4 changed files

pr created time in 2 days

create barnchry/deno

branch : bump-v0.30.2

created branch time in 2 days

push eventdenoland/rusty_v8

Ben Noordhuis

commit sha 4b8573a993ddab64ee1cf72da4353ec79783cf0e

Implement fmt::Display for StringView (#236) Make StringView objects inspectable to make it easier to debug the V8 inspector's wire protocol. StringBuffer objects can't be inspected yet because they need a mutable reference if they want to call `StringBuffer::string()`, which makes sense because that method calls out to a C++ virtual method that can modify the object. For now, instances can be inspected like this: let mut sb = StringBuffer::create(...); println!("StringBuffer({})", sb.string().unwrap()); Closes #233

inspector: human-readable StringBuffer, StringView

push time in 2 days

PR merged denoland/rusty_v8

Implement fmt::Display for StringView

Make StringView objects inspectable to make it easier to debug the V8 inspector's wire protocol.

StringBuffer objects can't be inspected yet because they need a mutable reference if they want to call StringBuffer::string(), which makes sense because that method calls out to a C++ virtual method that can modify the object.

For now, instances can be inspected like this:

let mut sb = StringBuffer::create(...);
println!("StringBuffer({})", sb.string().unwrap());

Closes #233

+31 -2

2 commit in bnoordhuis/rusty_v8/tree/fix233 denoland/rusty_v8/tree/master

2 comments

1 changed file

bnoordhuis

pr closed time in 2 days

issue closeddenoland/rusty_v8

For debugging the wire protocol. Just adding #[derive(Debug)] produces:

UniquePtr(Some(StringBuffer { _cxx_vtable: CxxVTable(0x55d8a19e34b0) }))

Not super useful, I daresay.

closed time in 2 days

bnoordhuis

pull request commentdenoland/deno

Revert "Create an old program to be used in snapshot. (#3644)"

@kitsonk During "cargo package" it builds the crate in a special directory - so if you do something like include_str("../cli/js/lib.deno_runtime.d.ts") it fails.

When the CLI crate is built, the snapshot is created, and with this patch, the snapshot creation accesses various assets. We need to only modify this patch so it can get those assets.

I've landed a CI test which checks "cargo package" now, so if we can get this patch to go green we can land it again.

ry

comment created time in 2 days

pull request commentdenoland/rusty_v8

Implement fmt::Display for StringView

Looks good. How about removing the derive Debug too?

bnoordhuis

comment created time in 2 days

push eventdenoland/deno

commit sha 92ceb8e3237c6a6e07c18bffdebf97b5ecaf8a56

Add github action for cargo publish (#3724)

Upgrade to rusty_v8 v0.1.1

push time in 2 days

PR merged denoland/deno

Add github action for cargo publish

This makes two changes:

Adds a new CI build which will do a dry-run of the publish procedure, checking that we can package the crates. This is to prevent issues like https://github.com/denoland/deno/issues/3712 from popping up again.
Adjusts the publish-on-tag action, so that it's only done by a single worker.

+12 -2

1 commit in ry/deno/tree/ci_cargo_publish2 denoland/deno/tree/master

0 comment

1 changed file

ry

pr closed time in 2 days

Pull request review commentdenoland/deno

 fn shared_getter(    // Lazily initialize the persistent external ArrayBuffer.   if deno_isolate.shared_ab.is_empty() {-    let data_ptr = deno_isolate.shared.bytes.as_ptr();-    let data_len = deno_isolate.shared.bytes.len();-    let ab = unsafe {-      v8::SharedArrayBuffer::new_DEPRECATED(-        scope,-        data_ptr as *mut c_void,-        data_len,-      )-    };+    let ab = v8::SharedArrayBuffer::new_with_backing_store(+      scope,+      deno_isolate.shared.get_backing_store(),+    );

👍

piscisaureus

comment created time in 2 days

issue closeddenoland/deno

crash during 'cargo publish' for cli (aka "deno" crate)

The error comes from here: https://github.com/denoland/deno/blob/v0.30.0/deno_typescript/lib.rs#L271

No idea why. Here's the log

[...]
cargo:rerun-if-changed=/Users/rld/src/deno/target/package/deno-0.30.0/js/streams/readable-stream-byob-reader.ts
cargo:rerun-if-changed=/Users/rld/src/deno/target/package/deno-0.30.0/js/repl.ts
cargo:rerun-if-changed=/Users/rld/src/deno/target/package/deno-0.30.0/js/format_error.ts
cargo:rerun-if-changed=/Users/rld/src/deno/target/package/deno-0.30.0/js/location.ts

--- stderr
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }', src/libcore/result.rs:1165:5
stack backtrace:
   0: backtrace::backtrace::libunwind::trace
             at /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.40/src/backtrace/libunwind.rs:88
   1: backtrace::backtrace::trace_unsynchronized
             at /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.40/src/backtrace/mod.rs:66
   2: std::sys_common::backtrace::_print_fmt
             at src/libstd/sys_common/backtrace.rs:77
   3: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
             at src/libstd/sys_common/backtrace.rs:61
   4: core::fmt::write
             at src/libcore/fmt/mod.rs:1028
   5: std::io::Write::write_fmt
             at src/libstd/io/mod.rs:1412
   6: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:65
   7: std::sys_common::backtrace::print
             at src/libstd/sys_common/backtrace.rs:50
   8: std::panicking::default_hook::{{closure}}
             at src/libstd/panicking.rs:188
   9: std::panicking::default_hook
             at src/libstd/panicking.rs:205
  10: std::panicking::rust_panic_with_hook
             at src/libstd/panicking.rs:464
  11: std::panicking::continue_panic_fmt
             at src/libstd/panicking.rs:373
  12: rust_begin_unwind
             at src/libstd/panicking.rs:302
  13: core::panicking::panic_fmt
             at src/libcore/panicking.rs:139
  14: core::result::unwrap_failed
             at src/libcore/result.rs:1165
  15: core::result::Result<T,E>::unwrap
             at /rustc/73528e339aae0f17a15ffa49a8ac608f50c6cf14/src/libcore/result.rs:933
  16: deno_typescript::read_file
             at /Users/rld/.cargo/registry/src/github.com-1ecc6299db9ec823/deno_typescript-0.30.0/lib.rs:256
  17: deno_typescript::get_asset
             at /Users/rld/.cargo/registry/src/github.com-1ecc6299db9ec823/deno_typescript-0.30.0/lib.rs:271
  18: deno_typescript::get_asset2
             at /Users/rld/.cargo/registry/src/github.com-1ecc6299db9ec823/deno_typescript-0.30.0/lib.rs:246
  19: deno_typescript::ops::read_file
             at /Users/rld/.cargo/registry/src/github.com-1ecc6299db9ec823/deno_typescript-0.30.0/ops.rs:48
  20: deno_typescript::ops::json_op::{{closure}}::{{closure}}
             at /Users/rld/.cargo/registry/src/github.com-1ecc6299db9ec823/deno_typescript-0.30.0/ops.rs:23
  21: core::result::Result<T,E>::and_then
             at /rustc/73528e339aae0f17a15ffa49a8ac608f50c6cf14/src/libcore/result.rs:691
  22: deno_typescript::ops::json_op::{{closure}}
             at /Users/rld/.cargo/registry/src/github.com-1ecc6299db9ec823/deno_typescript-0.30.0/ops.rs:21
  23: deno_typescript::compiler_op::{{closure}}
             at /Users/rld/.cargo/registry/src/github.com-1ecc6299db9ec823/deno_typescript-0.30.0/lib.rs:62
  24: <alloc::boxed::Box<F> as core::ops::function::Fn<A>>::call
             at /rustc/73528e339aae0f17a15ffa49a8ac608f50c6cf14/src/liballoc/boxed.rs:956
  25: deno_core::ops::OpRegistry::call
             at /Users/rld/.cargo/registry/src/github.com-1ecc6299db9ec823/deno_core-0.30.0/ops.rs:95
  26: deno_core::isolate::Isolate::dispatch_op
             at /Users/rld/.cargo/registry/src/github.com-1ecc6299db9ec823/deno_core-0.30.0/isolate.rs:496
  27: deno_core::bindings::send
             at /Users/rld/.cargo/registry/src/github.com-1ecc6299db9ec823/deno_core-0.30.0/bindings.rs:440
  28: core::ops::function::Fn::call
             at /rustc/73528e339aae0f17a15ffa49a8ac608f50c6cf14/src/libcore/ops/function.rs:69
  29: rusty_v8::function::<impl rusty_v8::support::MapFnFrom<F> for extern "C" fn(*const rusty_v8::function::FunctionCallbackInfo)>::mapping::{{closure}}
             at /Users/rld/.cargo/registry/src/github.com-1ecc6299db9ec823/rusty_v8-0.1.0/src/function.rs:240
  30: <extern "C" fn(A0) .> R as rusty_v8::support::CFnFrom<F>>::mapping::c_fn
             at /Users/rld/.cargo/registry/src/github.com-1ecc6299db9ec823/rusty_v8-0.1.0/src/support.rs:398
  31: Call
             at ../../../../../../../../.cargo/registry/src/github.com-1ecc6299db9ec823/rusty_v8-0.1.0/v8/src/api/api-arguments-inl.h:158
  32: HandleApiCallHelper<false>
             at ../../../../../../../../.cargo/registry/src/github.com-1ecc6299db9ec823/rusty_v8-0.1.0/v8/src/builtins/builtins-api.cc:111
  33: Builtin_Impl_HandleApiCall
             at ../../../../../../../../.cargo/registry/src/github.com-1ecc6299db9ec823/rusty_v8-0.1.0/v8/src/builtins/builtins-api.cc:141
  34: Builtin_HandleApiCall
             at ../../../../../../../../.cargo/registry/src/github.com-1ecc6299db9ec823/rusty_v8-0.1.0/v8/src/builtins/builtins-api.cc:129
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
fatal runtime error: failed to initiate panic, error 5

closed time in 2 days

ry

issue commentdenoland/deno

crash during 'cargo publish' for cli (aka "deno" crate)

Fixed in https://github.com/denoland/deno/commit/fa7f34eb8cec07f4c68ca4e9c46a983bc3e2308f

ry

comment created time in 2 days

push eventry/deno

commit sha 7966bf14c062a05b1606a62c996890571454ecc8

refactor: split worker and worker host logic (#3722) * split ops/worker.rs into ops/worker_host.rs and ops/web_worker.rs * refactor js/workers.ts and factor out js/worker_main.ts - entry point for WebWorker runtime * BREAKING CHANGE: remove support for blob: URL in Worker * BREAKING CHANGE: remove Deno namespace support and noDenoNamespace option in Worker constructor * introduce WebWorker struct which is a stripped down version of cli::Worker

Michał Sabiniarz

commit sha 21cc9cb7a76d805fbb7b53583448aa101c294e71

Implemented alternative open mode in files (#3119) Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>

commit sha 0cd605515c99458fa80cd4a1a3906f3db37a86ca

refactor: don't create new runtime for fs ops (#3730)

commit sha 5e2fd183ff1fe240ddbd864dbf1e6a0941fb4582

refactor: Rename JS entry functions (#3732)

Takashi Idobe

commit sha 108294deeb0897199ebdf0af203ff8ddd457b1ef

change copyrights from 2019 to 2020 (#3733)

Lasse Brudeskar Vikås

commit sha 159ac525ae13816fec76395b0a6e7b1ab55dee1a

Update manual.md (#3734) Updated the `Deno.bundle` description to actually use the `bundle`-function.

commit sha 229eb292f83dedbc32dc24f912841caf79a53e9c

Revert "don't include assets in binary (#3661)" Ref #3712 This reverts commit 32cbcfe4e9943a0318c497188e045d23c5f6703a.

commit sha ecd1d3abb0cae9c7cbc1330cbaa035a5786e94d7

refactor: split cli::Worker (#3735) * cli::Worker is base struct to create specialized workers * add MainWorker * add CompilerWorker * refactor WebWorker to use Worker

Yoshiya Hinosawa

commit sha 9de8178c9b9bc21cc880ea81f163118408cc6c46

feat: add AsyncUnref ops (#3721) This is in order to support features like signal handlers, which shouldn't prevent the program from exiting.

commit sha 7fd50065a7d8a4c6ed1b1090703a7baaabdbd6aa

v0.30.1 This patch release is being done only to test crate publishing, hence lack of release notes or published binaries.

commit sha fa7f34eb8cec07f4c68ca4e9c46a983bc3e2308f

Revert "Create an old program to be used in snapshot. (#3644)" Ref #3712. This change allowed the deno_typescript crate to reference cli/js/lib.deno_runtime.d.ts which breaks "cargo package". We intend to reintroduce a revised version of this patch later once "cargo package" is working and tested. This reverts commit 737ab94ea1bdf65eeef323ea37e84bcf430fb92c.

commit sha 7054621f4c9da21f13b94bf788fb879abacaa9b9

Add github action for cargo publish

push time in 2 days

delete branch ry/deno

delete branch : revert_old_program

delete time in 2 days

push eventdenoland/deno

commit sha fa7f34eb8cec07f4c68ca4e9c46a983bc3e2308f

Revert "Create an old program to be used in snapshot. (#3644)" Ref #3712. This change allowed the deno_typescript crate to reference cli/js/lib.deno_runtime.d.ts which breaks "cargo package". We intend to reintroduce a revised version of this patch later once "cargo package" is working and tested. This reverts commit 737ab94ea1bdf65eeef323ea37e84bcf430fb92c.

unknown argument: '-gno-inline-line-tables'

push time in 2 days

PR merged denoland/deno

Revert "Create an old program to be used in snapshot. (#3644)"

Ref #3712. This change allowed the deno_typescript crate to reference cli/js/lib.deno_runtime.d.ts which breaks "cargo package". We intend to reintroduce a revised version of this patch later once "cargo package" is working and tested.

This reverts commit 737ab94ea1bdf65eeef323ea37e84bcf430fb92c.

cc @kitsonk

+59 -84

2 commit in ry/deno/tree/revert_old_program denoland/deno/tree/master

0 comment

14 changed files

ry

pr closed time in 2 days

issue commentdenoland/rusty_v8

@hayd check out https://github.com/denoland/chromium_build/commit/65d79729a

Essentially you'll want to revert that commit (or better, make it conditional), and update the build submodule in rusty_v8.

hayd

comment created time in 2 days

Pull request review commentdenoland/deno

Revert "Create an old program to be used in snapshot. (#3644)"

 pub fn get_asset(name: &str) -> Option<&'static str> {   }   match name {     "bundle_loader.js" => Some(include_str!("bundle_loader.js")),-    "lib.deno_runtime.d.ts" => {-      Some(include_str!("../cli/js/lib.deno_runtime.d.ts"))

Note: this is the reason for the revert - this breaks "cargo package".

ry

comment created time in 2 days

issue commentdenoland/rusty_v8

unknown argument: '-gno-inline-line-tables'

@hayd I'm not sure what you mean, but deno_src is created here: https://github.com/denoland/deno/blob/7fd50065a7d8a4c6ed1b1090703a7baaabdbd6aa/.github/workflows/ci.yml#L43

hayd

comment created time in 2 days

push eventry/deno

commit sha 362aff1f10400da4f05f4a0b3b6a377b97a28321

bump

branch : revert_old_program

push time in 2 days

PR opened denoland/deno

Revert "Create an old program to be used in snapshot. (#3644)"

Ref #3712. This change allowed the deno_typescript crate to reference cli/js/lib.deno_runtime.d.ts which breaks "cargo package". We intend to reintroduce this a revised version of this patch later once "cargo package" is working and tested.

This reverts commit 737ab94ea1bdf65eeef323ea37e84bcf430fb92c.

+59 -84

1 commit in ry/deno/tree/revert_old_program denoland/deno/tree/master

0 comment

14 changed files

pr created time in 2 days

create barnchry/deno

created branch time in 2 days

PR closed denoland/deno

deno_typescript should not use assets outside of crate

cc @kitsonk

+36 -23

2 commit in ry/deno/tree/cli_assets denoland/deno/tree/master

1 comment

5 changed files

ry

pr closed time in 2 days

pull request commentdenoland/deno

deno_typescript should not use assets outside of crate

This isn't working. I'm going to revert the oldProgram patch. We can re-introduce it later after fixing "cargo package"

ry

comment created time in 2 days

push eventry/deno

commit sha ffad8d2a5a47ac66c7fa2f4baa4457cfe3759f70

fix

push time in 2 days

PR opened denoland/deno

deno_typescript should not use assets outside of crate

+1 -4

1 commit in ry/deno/tree/cli_assets denoland/deno/tree/master

0 comment

2 changed files

pr created time in 2 days

create barnchry/deno

branch : cli_assets

created branch time in 2 days

delete branch ry/deno

delete branch : release_crates

delete time in 2 days

created tagdenoland/deno

tagv0.30.1

A secure JavaScript and TypeScript runtime

created time in 2 days

push eventdenoland/deno

commit sha 7fd50065a7d8a4c6ed1b1090703a7baaabdbd6aa

v0.30.1 This patch release is being done only to test crate publishing, hence lack of release notes or published binaries.

`int` should not be part of the public interface

push time in 2 days

PR merged denoland/deno

v0.30.1

This patch release is being done only to test crate publishing, hence lack of release notes or published binaries.

Ref #3712

+16 -16

1 commit in ry/deno/tree/release_crates denoland/deno/tree/master

2 comments

4 changed files

ry

pr closed time in 2 days

pull request commentdenoland/deno

v0.30.1

@omarhoro have a look at https://github.com/denoland/deno/issues/2473

ry

comment created time in 2 days

issue openeddenoland/rusty_v8

https://docs.rs/rusty_v8/0.1.1/rusty_v8/type.int.html

created time in 2 days

PR opened denoland/deno

v0.30.1

This patch release is being done only to test crate publishing, hence lack of release notes or published binaries.

+16 -16

1 commit in ry/deno/tree/release_crates denoland/deno/tree/master

0 comment

4 changed files

pr created time in 2 days

create barnchry/deno

branch : release_crates

created branch time in 2 days

push eventdenoland/deno_website2

commit sha 6bff71b16adce18282b948db5841544cb57ad235

fix example new line char (#203)

push time in 2 days

PR merged denoland/deno_website2

fix home page example new line char

+1 -1

1 commit in ry/deno_website2/tree/example denoland/deno_website2/tree/master

0 comment

1 changed file

ry

pr closed time in 2 days

PR opened denoland/deno_website2

fix home page example new line char

+1 -1

1 commit in ry/deno_website2/tree/example denoland/deno_website2/tree/master

0 comment

1 changed file

pr created time in 2 days

create barnchry/deno_website2

branch : example

created branch time in 2 days

push eventdenoland/deno_website2

Charles Moog

commit sha 081af6efa1ef81335fc6359bdfe33108a74b126a

updates server example (#202)

push time in 2 days

PR merged denoland/deno_website2

updates server example

updates hello world server example by removing unnecessary text encoder

+2 -3

1 commit in cmoog/deno_website2/tree/server-example denoland/deno_website2/tree/master

1 comment

1 changed file

cmoog

pr closed time in 2 days

push eventdenoland/deno

Yoshiya Hinosawa

commit sha 9de8178c9b9bc21cc880ea81f163118408cc6c46

feat: add AsyncUnref ops (#3721) This is in order to support features like signal handlers, which shouldn't prevent the program from exiting.

push time in 2 days

PR merged denoland/deno

feat: optional async ops 2

This PR is the variation of #3715. This uses AsyncOptional enum variant instead of adding the flags.

+70 -1

7 commit in kt3k/deno/tree/feature/optional-async-ops-2 denoland/deno/tree/master

3 comments

4 changed files

kt3k

pr closed time in 2 days

push eventkt3k/deno

commit sha 71f28b81629865b1a709d3b63af3fe1bbefe5dd7

comment