profile
viewpoint
Rijnard van Tonder rvantonder @sourcegraph Phoenix, AZ rijnard.com

comby-tools/sample-catalog 2

A sample catalog with rewrite templates. Feel free to fork and modify with your own!

ddcc/15745-s15-project 2

15-745 Optimizing Compilers S15 Project

agroce/mutantsnsfsmall 1

NSF proposal on mutation testing

rvantonder/archat 1

server client chat

rvantonder/bandwidth-tester 1

test tcp/udp bandwidth on point to point connection

rvantonder/2048 0

2048 Game with Kivy

rvantonder/afl 0

american fuzzy lop (copy of the source code for easy access)

rvantonder/afl-compiler-fuzzer 0

Variation of american fuzzy lop for testing compilers for C-like languages

push eventrvantonder/gql-sublimetext-yolo

Rijnard van Tonder

commit sha 0468c3a0dc7a0b2b4fce21d690b41ea9bc3f9bee

Create ThirdPartyLicense

view details

push time in 9 hours

pull request commentsourcegraph/sourcegraph

search: barebones frontend recursive descent parser (draft for comments)

Will we eventually change parseSearchQuery to use this new parser?

parseSearchQuery will be changing to something else, yes

rvantonder

comment created time in 10 hours

issue commentsourcegraph/sourcegraph

Streaming Search Progress API Proposal

Following sync: I can see the usefulness of shards metric (so, in general, in favor of communicating this, or a progress metric derived from it). It also feels entirely Zoekt-specific, so how would that fit into progress for, say, unindexed search. You might say "we don't care" about unindexed search but I mean more generally, e.g., if we decide to use other search-like backends where shards is not part of the terminology/quantity of progress (let's say there's some backend that could be dedicated to searching commits, etc. which may or may not use Zoekt). So maybe we can generalize this metric, along the lines of the other fields in the Addendum.


result count:

I suspect that for code results, most users would instinctively expect "result count" to mean "non-overlapping ranges". It would be nice to validate that assumption though.

Agree

I could maybe see "number of file matches" as an unintuitive when a user is expecting an exhaustive result?

Ultimately, we should surface both non-overlapping ranges and file matches in result stats ("X results across Y documents, Z shards").

Fully agree. It is important to report the number of matches subject to search kind (file contents, files, etc) and we should strive to provide the full breakdown. It is extremely useful to have match counts from an API perspective (e.g., to measure number of calls matched in commit X versus commit Y). Only reporting file matches is limiting.

More past discussion about this: https://github.com/sourcegraph/sourcegraph/issues/9426#issuecomment-607396894

because this has been a source of no confidence/non-determinism.

Even though it's a source of no confidence/non-determinism, we should still collect/report it IMO. Limiting our own visibility into number of matches will just make things harder, and if we do use a solution that improves on this, we'd want to report it.


While we're discussing match count:

Number of line matches. ... This is what we currently document as the value of matchCount

Where is that documented? Related, in https://github.com/sourcegraph/sourcegraph/pull/11242 I pointed out my discovery that Zoekt seems to report line matches and not non-overlapping ranges, and I think that's still the case. In that PR I took the Zoekt result and calculate the non-overlapping ranges, which is what we now report in text search results.

keegancsmith

comment created time in 10 hours

push eventsourcegraph/sourcegraph

Rijnard van Tonder

commit sha b8a4127116b1046ab547cb29ee45c38b3b4d0ce0

search: remove quote hint in regex mode if pattern contains colon (#15055)

view details

push time in 10 hours

delete branch sourcegraph/sourcegraph

delete branch : rvt/no-quotes-hint-for-regexp

delete time in 10 hours

PR merged sourcegraph/sourcegraph

search: remove quote hint in regex mode if pattern contains colon

In favor of removing this. It's related to improving other quoting hints, which I'll get to later (https://github.com/sourcegraph/sourcegraph/issues/12802, https://github.com/sourcegraph/sourcegraph/issues/10793, https://github.com/sourcegraph/sourcegraph/issues/11909).

As in: I half-know what I’m doing here by using regex. I appreciate the hint though, when I use it the first time.

I don't think there's any way to make this dismissible. The usefulness showing this on first time is outweighed by this showing up every time, and regex is an opt-in toggle, so we can mostly safely assume the user knows what they're dealing with.

Context:

Screen Shot 2020-10-26 at 8 50 28 AM

+0 -26

0 comment

2 changed files

rvantonder

pr closed time in 10 hours

PullRequestReviewEvent

Pull request review commentsourcegraph/sourcegraph

search: aggregator merges file match results in report

 func (fm *FileMatchResolver) path() string { // counts and limit. func (fm *FileMatchResolver) appendMatches(src *FileMatchResolver) { 	fm.JLineMatches = append(fm.JLineMatches, src.JLineMatches...)+	fm.symbols = append(fm.symbols, src.symbols...)

looks good to me, is there any specific reason you're calling out this line? :-)

keegancsmith

comment created time in 11 hours

PullRequestReviewEvent

PR opened sourcegraph/sourcegraph

search: remove quote hint in regex mode if pattern contains colon

In favor of removing this. It's related to other quoting hints, which I'll get to later (https://github.com/sourcegraph/sourcegraph/issues/12802, https://github.com/sourcegraph/sourcegraph/issues/10793, https://github.com/sourcegraph/sourcegraph/issues/11909).

As in: I half-know what I’m doing here by using regex. I appreciate the hint though, when I use it the first time.

I don't think there's any way to make this dismissible. The usefulness showing this on first time is outweighed by this showing up every time, and regex is an opt-in toggle, so we can mostly safely assume the user knows what they're dealing with.

Context:

Screen Shot 2020-10-26 at 8 50 28 AM

+0 -26

0 comment

2 changed files

pr created time in 11 hours

create barnchsourcegraph/sourcegraph

branch : rvt/no-quotes-hint-for-regexp

created branch time in 11 hours

push eventsourcegraph/about

Rijnard van Tonder

commit sha bf0c48fb7710d528c923fc83f9c941264a176ffa

Update iteration_log.md (#1836)

view details

push time in 19 hours

delete branch sourcegraph/about

delete branch : rvantonder-patch-1

delete time in 19 hours

PR merged sourcegraph/about

Update iteration_log.md
+2 -2

1 comment

1 changed file

rvantonder

pr closed time in 19 hours

PR opened sourcegraph/about

Update iteration_log.md
+2 -2

0 comment

1 changed file

pr created time in 19 hours

create barnchsourcegraph/about

branch : rvantonder-patch-1

created branch time in 20 hours

PR opened sourcegraph/sourcegraph

search: refactor parser to simplify regex and literal handling

Closes https://github.com/sourcegraph/sourcegraph/issues/13434. This is a pretty hefty refactor to get rid of a kind of 'forked' handling of parsing. Before, it basically did:

              /----- parseLeavesLiteral (literal search)------\                   /--parsePatternLiteral-\
input  -----                                                   ----shared stuff---                        -- ....
              \---------- parseLeavesRegexp (regexp search)---/                   \--parsePatternRegexp--/

these forked/analog functions shared things, but also different and separated by the fact that I implemented literal search support after regex. They share enough logic that they should be merged (read: PR has more deletions than additions :P). After this PR, the structure is:

input -- parseLeaves (arg has literal or regex context) --- stuff --- parsePattern (arg has context) ---...

This will make it easier to translate some of the logic to frontend parser, see #14016.

With this change, I also decide to drop support for dangling closing parentheses. Mainly because I don't think handling this edge case is worth the amount of complexity it adds to the code. There's no harm in dropping support if we flag it, and provide the alternative (content:"thing with )")

+105 -273

0 comment

2 changed files

pr created time in 20 hours

push eventsourcegraph/sourcegraph

Rijnard van Tonder

commit sha 34ed1c0d45643afb5248ff4308e69c7c969d9057

search: refactor parser to simplify regex and literal handling

view details

push time in 20 hours

create barnchsourcegraph/sourcegraph

branch : rvt/parser-cleanup-2

created branch time in 20 hours

push eventsourcegraph/sourcegraph

Rijnard van Tonder

commit sha e27a52d3d71b5c6d9b445f7198f8cc89859ffa21

ok

view details

push time in 20 hours

push eventsourcegraph/sourcegraph

Rijnard van Tonder

commit sha fb4b28eb7ce59c93343ef97eecb93bfb0970f349

progress

view details

push time in 20 hours

startedmysticatea/regexpp

started time in a day

push eventcomby-tools/comby

Rijnard van Tonder

commit sha 3723d3b5667ad64f4fff80d8e9edf235ea1fa583

tidy things up a bit (#212)

view details

push time in a day

delete branch comby-tools/comby

delete branch : cleanup

delete time in a day

PR merged comby-tools/comby

tidy things up a bit
+145 -121

0 comment

11 changed files

rvantonder

pr closed time in a day

pull request commentrvantonder/hack_parallel

Update to the version from pyre-check 0.0.56

Sorry this has taken a while. I've looked at the changes and will need more time to fix some things up, it will currently break the previous interface, the reason is there isn't a one-to-one correspondence with upstream pyre library.

bnavigator

comment created time in a day

create barnchrvantonder/hack_parallel

branch : update-to-pyre

created branch time in a day

PR opened comby-tools/comby

tidy things up a bit
+145 -121

0 comment

11 changed files

pr created time in a day

create barnchcomby-tools/comby

branch : cleanup

created branch time in a day

push eventsourcegraph/sourcegraph

Rijnard van Tonder

commit sha 0de819134305d6aaf628f45126ccf69b5b08047f

factor out delimiter parser

view details

Rijnard van Tonder

commit sha 4e9ab40b1e0e07ffe1c136333527627c540fc512

chom chomp

view details

Rijnard van Tonder

commit sha e6684283d3cff5c2a6056df64f358391ead7dcad

chomp

view details

push time in 3 days

create barnchsourcegraph/sourcegraph

branch : rvt/parser-cleanup

created branch time in 3 days

create barnchcomby-tools/comby

branch : colon

created branch time in 3 days

push eventsourcegraph/sourcegraph

Rijnard van Tonder

commit sha b04a4501910012c2a838ab673d8129ce3fe24391

docs: render railroad figs on narrow screens (#15027)

view details

push time in 3 days

delete branch sourcegraph/sourcegraph

delete branch : rvt/fix-railroad-overflow

delete time in 3 days

PR merged sourcegraph/sourcegraph

docs: render railroad figs on narrow screens

Kapture 2020-10-23 at 14 17 35

  • also fixes a case toggle button appearing larger than it should
+12 -7

2 comments

1 changed file

rvantonder

pr closed time in 3 days

pull request commentsourcegraph/sourcegraph

docs: render railroad figs on narrow screens

I care about these railroads :-)

rvantonder

comment created time in 3 days

PR opened sourcegraph/sourcegraph

Reviewers
docs: render railroad figs on narrow screens

Kapture 2020-10-23 at 14 17 35

  • also fixes a case toggle button appearing larger than it should
+12 -7

0 comment

1 changed file

pr created time in 3 days

push eventsourcegraph/sourcegraph

Rijnard van Tonder

commit sha 8b88359bd120d08d2e66c9f975a82a4bf6d1608a

docs: render railroad figs on narrow screens

view details

push time in 3 days

create barnchsourcegraph/sourcegraph

branch : rvt/fix-railroad-overflow

created branch time in 3 days

PR opened sourcegraph/sourcegraph

Reviewers
search: barebones frontend recursive descent parser

This implements the barebones recursive descent parsing that ensures operator precedence. I am intentionally leaving complexity to make this easier for feedback/comments. I don't have TypeScript savvy, I'm sure this can be improved and eager to get comments. It does closely model the initial Go PR.

Simplifying decisions I'm not addressing in this PR:

  • Just leaf for arbitrary leaf nodes. This will be patterns/filters later.
  • No parens for grouping here
  • A type for errors, but no real error handling
  • No range info yet

There are some notable differences I'm thinking about wrt frontend parser and backend. E.g., in the Go PR it's very reasonable to normalize nested statements like:

a or b or c or d' => (or a b c d). This is useful when evaluating nodes, no need for those additional ors in that context. Note that this normalization is part and parcel of parsing in the Go parser (cf. reduce) to avoid doing extra passes.

One frontend concern is highlighting, and so with the normalization above ^ we would effectively throw away any additional or tokens, the output doesn't expose that information for highlighting the concrete syntax. The implication is, this is probably not normalization we want to apply in the frontend in the interest of highlighting, since we'd like to communicate those or tokens to Monaco.

+212 -0

0 comment

2 changed files

pr created time in 4 days

create barnchsourcegraph/sourcegraph

branch : rvt/fe-parser-v1

created branch time in 4 days

delete branch sourcegraph/sourcegraph

delete branch : rvt/fix-double-colon-issue

delete time in 4 days

push eventsourcegraph/sourcegraph

Rijnard van Tonder

commit sha 16ca583ce209bc59b82870e3f0edbaa4a22ace6d

structural search: fix double colon conversion (#15010)

view details

push time in 4 days

PR merged sourcegraph/sourcegraph

Reviewers
structural search: fix double colon conversion

A dumb thing where parsing ::[stuff] thought :: can be treated as literal, when the lookahead : could be start of :[stuff].

@mrnugget found it

+15 -0

3 comments

2 changed files

rvantonder

pr closed time in 4 days

push eventsourcegraph/sourcegraph

Rijnard van Tonder

commit sha 293960db2a0a0bd4a9dea81ecd5a13c6ca33b6cc

structural search: fix double colon conversion

view details

push time in 4 days

PR opened sourcegraph/sourcegraph

Reviewers
structural search: fix double colon conversion

A dumb thing where parsing ::[stuff] thought :: can be treated as literal, when the lookahead : could be start of :[stuff].

+10 -0

0 comment

2 changed files

pr created time in 4 days

push eventsourcegraph/sourcegraph

Rijnard van Tonder

commit sha f829798a5e2092dedc1f1f61e03c0d0ce6bf6a99

structural search: fix double colon conversion

view details

push time in 4 days

push eventsourcegraph/sourcegraph

Rijnard van Tonder

commit sha 40831d6acc6f24f73e4634eebf1598b5f195752b

structural search: fix double colon conversion

view details

push time in 4 days

create barnchsourcegraph/sourcegraph

branch : rvt/fix-double-colon-issue

created branch time in 4 days

push eventsourcegraph/sourcegraph

Rijnard van Tonder

commit sha ace3085772b2c092bb79d85f9af92ddbf8a1abc2

docs: make all search pages work on dark background (#14932)

view details

push time in 4 days

delete branch sourcegraph/sourcegraph

delete branch : rvt/fix-doc-colors

delete time in 4 days

PR merged sourcegraph/sourcegraph

Reviewers
docs: update search assets to work on dark background

Closes #14365.

Renders correctly now:

Screen Shot 2020-10-20 at 6 48 18 PM

Screen Shot 2020-10-20 at 6 55 01 PM

+85 -58

6 comments

12 changed files

rvantonder

pr closed time in 4 days

issue closedsourcegraph/sourcegraph

Update search docs to render nicely on dark mode

  • [ ] We use some icons that are not dark mode friendly. I'm not sure how to set the image based on theme, will figure it out.

On page: https://docs.sourcegraph.com/user/search/queries

Screen Shot 2020-10-01 at 9 46 51 PM

  • [ ] language reference page renders white background for diagrams always:

Screen Shot 2020-10-01 at 9 47 53 PM

  • [ ] language reference page should not change code style since the contrast issue that bothered me before is now gone:

Screen Shot 2020-10-01 at 9 48 15 PM

closed time in 4 days

rvantonder

pull request commentsourcegraph/sourcegraph

docs: update search assets to work on dark background

@christinaforney feel free to leave post merge feedback if any

rvantonder

comment created time in 4 days

pull request commentsourcegraph/sourcegraph

docs: update search assets to work on dark background

@christinaforney I fixed things to work in dark and light mode.

Got invert(100%) working for the toggle PNGs so I don't need extra dark versions, but doing the same for the railroad assets is just a big pain and much easier to just override.

rvantonder

comment created time in 5 days

push eventsourcegraph/sourcegraph

Rijnard van Tonder

commit sha 36d41a14e32ef60046161e12bceb1eb0ac328b79

docs: update search assets to work on dark background

view details

push time in 5 days

push eventsourcegraph/sourcegraph

Rijnard van Tonder

commit sha 8b15ea8c3097823d016076e4b6f02d138a74db35

docs: update search assets to work on dark background

view details

push time in 5 days

PR merged sourcegraph/sourcegraph

search: fix colon pattern in structural hole

Minor fix: :[~:] should match a literal colon in structural search. But the regex converter translated this to (:\]) instead of (:).

+9 -0

2 comments

2 changed files

rvantonder

pr closed time in 5 days

push eventsourcegraph/sourcegraph

Rijnard van Tonder

commit sha 7b269de885c6939d6739484e5981d2cdcf8144d0

search: fix colon pattern in structural hole (#14931)

view details

push time in 5 days

delete branch sourcegraph/sourcegraph

delete branch : rvt/fix-fix-colon

delete time in 5 days

PR closed sourcegraph/sourcegraph

tidy: staticcheck cleanup

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+5 -7

1 comment

1 changed file

rvantonder

pr closed time in 5 days

push eventsourcegraph/sourcegraph

Rijnard van Tonder

commit sha b6eb37cf793ff87000d8f9005acd851eb11b30ca

tidy: staticcheck cleanup

view details

push time in 6 days

pull request commentsourcegraph/sourcegraph

docs: update search assets to work on dark background

Ah, thanks for catching @christinaforney, I assumed (wrongly) the docs are only in dark mode now since we only had one theme before. I'll figure out a solution to make this work for both.

FWIW I tried invert(100%) before changing the assets but that would only invert the non-transparent part of the PNGs and not apply to the borders. I'll play around.

rvantonder

comment created time in 6 days

PR opened sourcegraph/sourcegraph

tidy: staticcheck cleanup

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+14 -34

0 comment

3 changed files

pr created time in 6 days

create barnchsourcegraph/sourcegraph

branch : rvt/comby-go-patterns

created branch time in 6 days

PR opened sourcegraph/sourcegraph

Reviewers
docs: update search assets to work on dark background

Closes #14365.

Renders correctly now:

Screen Shot 2020-10-20 at 6 48 18 PM

Screen Shot 2020-10-20 at 6 55 01 PM

+30 -45

0 comment

14 changed files

pr created time in 6 days

push eventsourcegraph/sourcegraph

Rijnard van Tonder

commit sha 740e77dc09c35a010a68d4ff6debaf5bc897be65

docs: update search assets to work on dark background

view details

push time in 6 days

create barnchsourcegraph/sourcegraph

branch : rvt/fix-doc-colors

created branch time in 6 days

push eventsourcegraph/sourcegraph

Rijnard van Tonder

commit sha 00b711cb1ddded3962120651596efbbc31f60046

search: fix colon pattern in structural hole

view details

push time in 6 days

PR opened sourcegraph/sourcegraph

search: fix colon pattern in structural hole

Minor fix: :[~:] should match a literal colon in structural search. But the regex converter translated this to (:\]) instead of (:).

+11 -0

0 comment

2 changed files

pr created time in 6 days

create barnchsourcegraph/sourcegraph

branch : rvt/fix-fix-colon

created branch time in 6 days

push eventsourcegraph/about

Rijnard van Tonder

commit sha a6e86c3427e04bd61539ec70fc53b8416be70422

code search query blog post edits (#1793)

view details

push time in 6 days

delete branch sourcegraph/about

delete branch : reorg-query

delete time in 6 days

PR merged sourcegraph/about

code search query blog post edits
+11 -6

1 comment

1 changed file

rvantonder

pr closed time in 6 days

PR opened sourcegraph/about

code search query blog post edits
+11 -6

0 comment

1 changed file

pr created time in 6 days

create barnchsourcegraph/about

branch : reorg-query

created branch time in 6 days

push eventsourcegraph/about

Rijnard van Tonder

commit sha ab3f841e5133128335064b79ffb4f199246b3d23

blog post: fix table rendering on media devices (#1791)

view details

push time in 6 days

delete branch sourcegraph/about

delete branch : table-css-code-check

delete time in 6 days

PR merged sourcegraph/about

fix table rendering on media devices

The table is too wide on a widescreen, which I fixed, but then it renders offscreen on mobile device. Fix that with some CSS

+10 -5

1 comment

1 changed file

rvantonder

pr closed time in 6 days

push eventsourcegraph/about

greggstone

commit sha a6dd44c65576c15a1b5363bf6d3aff90f928805b

Update index.md

view details

aileenrose

commit sha 901d4b9a5ef445d73234b39cafb721e774dbb22e

Add blog article (#1789)

view details

aileenrose

commit sha 35b10cb456e84bf84f8f8e20e02bf1750e6af165

Update release (#1790)

view details

Rijnard van Tonder

commit sha d71a462957f044cda60f80ef4ff7ba7ff9a07724

fix build: delete unreferenced file (#1792)

view details

Rijnard van Tonder

commit sha 9fe259dae844eecd47d488f93ec328ee9732b92a

fix table rendering on media devices

view details

push time in 6 days

push eventsourcegraph/about

Rijnard van Tonder

commit sha d71a462957f044cda60f80ef4ff7ba7ff9a07724

fix build: delete unreferenced file (#1792)

view details

push time in 6 days

delete branch sourcegraph/about

delete branch : fix-build

delete time in 6 days

PR merged sourcegraph/about

fix build: delete unreferenced file

Introduced by https://github.com/sourcegraph/about/commit/a6dd44c65576c15a1b5363bf6d3aff90f928805b

Screen Shot 2020-10-20 at 11 28 51 AM

+0 -56

0 comment

1 changed file

rvantonder

pr closed time in 6 days

push eventsourcegraph/about

greggstone

commit sha a6dd44c65576c15a1b5363bf6d3aff90f928805b

Update index.md

view details

aileenrose

commit sha 901d4b9a5ef445d73234b39cafb721e774dbb22e

Add blog article (#1789)

view details

aileenrose

commit sha 35b10cb456e84bf84f8f8e20e02bf1750e6af165

Update release (#1790)

view details

Rijnard van Tonder

commit sha 40b0dfd4f7793f5701fb790c11f8daf0542d764c

delete unreferenced file

view details

push time in 6 days

PR opened sourcegraph/about

fix build: delete unreferenced file

Introduced by https://github.com/sourcegraph/about/commit/a6dd44c65576c15a1b5363bf6d3aff90f928805b

Screen Shot 2020-10-20 at 11 28 51 AM

+0 -56

0 comment

1 changed file

pr created time in 6 days

create barnchsourcegraph/about

branch : fix-build

created branch time in 6 days

PR opened sourcegraph/about

fix table rendering on media devices

The table is too wide on a widescreen, which I fixed, but then it renders offscreen on mobile device. Fix that with some CSS

+10 -5

0 comment

1 changed file

pr created time in 6 days

create barnchsourcegraph/about

branch : table-css-code-check

created branch time in 6 days

pull request commentsourcegraph/about

observability docs: move file to where it's referenced

agree!

rvantonder

comment created time in 7 days

push eventsourcegraph/about

Rijnard van Tonder

commit sha d966fae3c08a7314936c3576b42e1802e61265bf

observability docs: move file to where it's referenced (#1785)

view details

push time in 7 days

delete branch sourcegraph/about

delete branch : rvt/fix-docsite-observ

delete time in 7 days

PR merged sourcegraph/about

Reviewers
observability docs: move file to where it's referenced

https://github.com/sourcegraph/about/pull/1221 broke docsite build. It looks like this file should live where I moved it in this PR see https://github.com/sourcegraph/about/runs/1279046251#step:4:23

+0 -0

3 comments

2 changed files

rvantonder

pr closed time in 7 days

pull request commentsourcegraph/about

observability docs: move file to where it's referenced

@bobheadxi OK, I looked at the docsite logs and it's this file--based on the change, the referenced file should live where I moved it, and this PR unbreaks the build (which is really the part I care about :-) it's either this PR or revert the other). Can I get a stamp here please, and you can fix up anything else that needs Real Fixing (TM) in your PR, if needed?

rvantonder

comment created time in 7 days

push eventsourcegraph/about

Rijnard van Tonder

commit sha f39dcd1b128bdd6692a628b032596645fbc8f656

observability docs: move file to where it's references

view details

push time in 7 days

create barnchsourcegraph/about

branch : rvt/fix-docsite-observ

created branch time in 7 days

push eventsourcegraph/about

Rijnard van Tonder

commit sha 8f98f96570984ec9a6776ed8e9572505f215ea74

Fix typos for blog post onCode search turned code checker

view details

push time in 7 days

delete branch sourcegraph/about

delete branch : rvt/code-search-analysis

delete time in 7 days

push eventsourcegraph/about

Rijnard van Tonder

commit sha 174aded7d35222d9200a48c89df3482795f2a6cb

Blog post: Code search turned code checker (#1618)

view details

push time in 7 days

PR merged sourcegraph/about

Code search turned code checker

Notes to self:

Before publishing:

  • [x] page visit should trigger https://github.com/sourcegraph/sourcegraph/pull/14437
  • [x] encodeURIComponent https://github.com/sourcegraph/sourcegraph/pull/14394
  • [x] clicking back should restore previous history https://github.com/sourcegraph/sourcegraph/pull/14478
  • [x] deny count:1000 page visit should trigger https://github.com/sourcegraph/sourcegraph/pull/14478
  • [ ] index all repos in go-gh-100
  • [ ] Two bugs:
if strings.HasPrefix(:[str.], :[prefix.]) {
  :[str.] = :[str.][len(:[prefix]):]
} :[~else]

doesn't work

and

simple select


Nice to haves:

  • [ ] Layout improvement (maybe 5/12 editor, 7/12 results)
  • [x] comments in editor https://github.com/sourcegraph/sourcegraph/pull/14476
  • [x] cmd+enter https://github.com/sourcegraph/sourcegraph/pull/14508
  • [ ] -bound-count comby
  • [ ] hover info for query
  • [ ] toml config file for rewriting
+338 -0

2 comments

1 changed file

rvantonder

pr closed time in 7 days

more