profile
viewpoint

grpc/grpc-web 5001

gRPC for Web Clients

buildbot/buildbot 4495

Python-based continuous integration testing framework; your pull requests are more than welcome!

rutsky/blender 2

Blender Demos

rutsky/acm 1

ACM problems.

rutsky/asm 1

Assembler examples and tests.

rutsky/abseil.github.io 0

Abseil documentation abseil.io

rutsky/aiobackoff 0

Function decoration for backoff and retry

rutsky/aiohttp 0

http client/server for asyncio (PEP-3156)

rutsky/aiohttp-sse 0

Server-sent events support for aiohttp

push eventaio-libs/aiohttp

Sam Bull

commit sha bb0440220785b6006b6afc5f103bddc934fe5507

[3.8] Backport fix for setting cookies (#5233) Co-authored-by: aio-libs-github-bot[bot] <72856194+aio-libs-github-bot[bot]@users.noreply.github.com> Co-authored-by: Gary Wilson Jr <gary@thegarywilson.com> Co-authored-by: Sam Bull <git@sambull.org>

view details

push time in 28 minutes

pull request commentaio-libs/aiohttp

[3.8] Backport fix for setting cookies

Thanks!

Dreamsorcerer

comment created time in 28 minutes

PR merged aio-libs/aiohttp

Reviewers
[3.8] Backport fix for setting cookies bot:chronographer:provided

I see this fix in master, but this needs to be released on the 3.7 branch, as aiohttp-session is broken without this.

(cherry-picked from https://github.com/aio-libs/aiohttp/commit/54afac769c44054d7b9458c8fe0e42278ec70766)

+39 -11

15 comments

3 changed files

Dreamsorcerer

pr closed time in 28 minutes

pull request commentaio-libs/aiohttp

[3.8] Backport fix for setting cookies

Then I see lgtm alerts I usually open "view on LGTM.com" link, analyze it, and close as "I don't care" or "false alarm". But sometimes it is helpful as a point at "bad smelling" code.

Dreamsorcerer

comment created time in 29 minutes

issue commentkubernetes/ingress-nginx

TCP Exposing got high cpu usage when upstream went unavaliable

/remove-lifecycle stale

Any chance of getting this mitigated?

ArvinSiChuan

comment created time in 2 hours

issue commentkubernetes/ingress-nginx

TCP Exposing got high cpu usage when upstream went unavaliable

Any chance of getting this mitigated?

ArvinSiChuan

comment created time in 2 hours

pull request commentkubernetes/release

cip: calling some functions by passing the parameters by pointer

@cpanato: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-release-verify 7f6b0a10d2f87cddc113b2a3bd3e4e438fde590f link /test pull-release-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

cpanato

comment created time in 2 hours

pull request commentkubernetes/release

cip: calling some functions by passing the parameters by pointer

@cpanato: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-release-verify f17873b100f674565694bf7c5e9f30afec35a24c link /test pull-release-verify
pull-release-test f17873b100f674565694bf7c5e9f30afec35a24c link /test pull-release-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

cpanato

comment created time in 2 hours

pull request commentkubernetes/release

cip: calling some functions by passing the parameters by pointer

@cpanato: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-release-verify f17873b100f674565694bf7c5e9f30afec35a24c link /test pull-release-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

cpanato

comment created time in 2 hours

pull request commentkubernetes/release

cip: calling some functions by passing the parameters by pointer

@cpanato: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-release-verify 187a9040246fd7ad10022ad365d799c7c658abf6 link /test pull-release-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

cpanato

comment created time in 2 hours

pull request commentkubernetes/release

cip: calling some functions by passing the parameters by pointer

@cpanato: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-release-verify 9f22f1a728c4552eb14b40dd61e7fdf26aa086b5 link /test pull-release-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

cpanato

comment created time in 2 hours

pull request commentkubernetes/release

cip: calling some functions by passing the parameters by pointer

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: <a href="https://github.com/kubernetes/release/pull/1802#" title="Author self-approved">cpanato</a>

The full list of commands accepted by this bot can be found here.

The pull request process is described here

<details > Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":[]} -->

cpanato

comment created time in 2 hours

PR opened kubernetes/release

cip: calling some functions by passing the parameters by pointer

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

cip: calling some functions by passing the parameters by pointer

removing tech debt :)

Which issue(s) this PR fixes:

<!-- *Automatically closes linked issue when PR is merged. Usage: Fixes #<issue number>, or Fixes (paste link of issue).

Fixes #

or

None -->

Special notes for your reviewer:

Does this PR introduce a user-facing change?

<!-- If no, just write "NONE" in the release-note block below. If yes, a release note is required: Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".

For more information on release notes see: https://git.k8s.io/community/contributors/guide/release-notes.md -->

cip: calling some functions by passing the parameters by pointer

/assign @saschagrunert @hasheddan @justaugustus

+31 -48

0 comment

6 changed files

pr created time in 2 hours

issue commentaio-libs/frozenlist

CI misconfigure

Okidoki, sorry if this caused headaches!

asvetlov

comment created time in 2 hours

pull request commentaio-libs/aiohttp

[3.8] Backport fix for setting cookies

First time I've seen a failure from lgtm. :P Appears to be from the merge though, not related to the PR.

Dreamsorcerer

comment created time in 3 hours

pull request commentaio-libs/aiohttp

[3.8] Backport fix for setting cookies

This pull request introduces 2 alerts and fixes 1 when merging eee5eea7d89bc03890accdfb7c602c880170f377 into 5d1a75e68d278c641c90021409f4eb5de1810e5e - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Missing call to __init__ during object initialization

fixed alerts:

  • 1 for __eq__ not overridden when adding attributes
Dreamsorcerer

comment created time in 3 hours

pull request commentaio-libs/aiohttp

[3.8] Backport fix for setting cookies

Tests passed this time. Good to go.

Dreamsorcerer

comment created time in 3 hours

pull request commentaio-libs/aiohttp

[3.7] Backport fix for setting cookies

maybe change the pr title as well.

Dreamsorcerer

comment created time in 3 hours

Pull request review commentaio-libs/aiohttp

[3.7] Backport fix for setting cookies

 async def start(self) -> None:                 task = self._loop.create_task(self._handle_request(request, start))                 try:                     resp, reset = await task+                except HTTPException as exc:

Please move this except block and if getattr(resp, "__http_exception__", False): into _handle_request method.

Dreamsorcerer

comment created time in 4 hours

push eventaio-libs/aiohttp

Andrew Svetlov

commit sha 1e6ec85e709db083d240c5ca249660d0fa56c61c

Bump async-timeout version for aiohttp 3.8 (#5299)

view details

push time in 4 hours

delete branch aio-libs/aiohttp

delete branch : bumpt-async-timeout

delete time in 4 hours

PR merged aio-libs/aiohttp

Reviewers
Bump async-timeout version for aiohttp 3.8 bot:chronographer:provided

This change allows keeping more or less the same code that uses timeouts for both master and 3.8 branches.

The master has backward-incompatible changes and it is not complete yet; aiohttp 4.0 cannot be published anytime soon.

+44 -73

0 comment

10 changed files

asvetlov

pr closed time in 4 hours

issue commentkubernetes/ingress-nginx

tcp-proxy use allow/deny

@palko444, there are no plans to add more TCP/UDP features. The Ingress evolution https://kubernetes-sigs.github.io/service-apis/ maybe will add such feature

palko444

comment created time in 4 hours

issue commentkubernetes/ingress-nginx

tcp-proxy use allow/deny

@aledbf , is this at least planned or not at all?

palko444

comment created time in 4 hours

issue closedkubernetes/ingress-nginx

tcp-proxy use allow/deny

<!--

Welcome to ingress-nginx!

You probably didn't want to be one this page. It shouldn't really be here anyway.

  • If you want a quick response to a question, ask on the Kubernetes Slack instance in #ingress-nginx.

  • If this is actually a bug or a feature request, file one of those. If you're not sure which, just take a guess and we can always re-label.

  • If you think this might turn into a bug or feature request, but you're not sure, try asking in Slack first.

-->

<!--

Still here? Double-check that this hasn't been asked before, then put your question below with as many details as possible.

If you need to include code snippets or logs, please put them in fenced code blocks. If they're super-long, please use the details tag like <details><summary>super-long log</summary> lots of stuff </details>

-->

Hello,

Is it possible to use allow/deny in tcp-proxy (stream)? I'm using nginx-ingress-controller deployment: helm version: 1.41.2

I did check also in latest version, however I did not find any possibility to do this. Only way i found is to edit directly /etc/nginx/nginx.conf on pods, however this is not persistent.

Thank you in advance

closed time in 4 hours

palko444

issue commentkubernetes/ingress-nginx

tcp-proxy use allow/deny

@palko444 no, this is not supported. Only routing to TCP/UDP service ports.

palko444

comment created time in 4 hours

issue commentkubernetes/ingress-nginx

Internal error occurred: failed calling webhook "validate.nginx.ingress.kubernetes.io"

Error: admission webhook "validate.nginx.ingress.kubernetes.io" denied the request: rejecting admission review because the request does not contains an Ingress resource but networking.k8s.io/v1, Resource=ingresses with name jupyterhub in namespace staging-jhub

@rkevin-arch please make sure you are using the latest version v0.41.2. There was a regression that denied validation of ingresses networking.k8s.io/v1.

aduncmj

comment created time in 4 hours

issue openedkubernetes/ingress-nginx

tcp-proxy use allow/deny

<!--

Welcome to ingress-nginx!

You probably didn't want to be one this page. It shouldn't really be here anyway.

  • If you want a quick response to a question, ask on the Kubernetes Slack instance in #ingress-nginx.

  • If this is actually a bug or a feature request, file one of those. If you're not sure which, just take a guess and we can always re-label.

  • If you think this might turn into a bug or feature request, but you're not sure, try asking in Slack first.

-->

<!--

Still here? Double-check that this hasn't been asked before, then put your question below with as many details as possible.

If you need to include code snippets or logs, please put them in fenced code blocks. If they're super-long, please use the details tag like <details><summary>super-long log</summary> lots of stuff </details>

-->

Hello,

Is it possible to use allow/deny in tcp-proxy (stream)? I'm using nginx-ingress-controller deployment: helm version: 1.41.2

I did check also in latest version, however I did not find any possibility to do this. Only way i found is to edit directly /etc/nginx/nginx.conf on pods, however this is not persistent.

Thank you in advance

created time in 5 hours

PR opened aio-libs/aiohttp

Bump async-timeout version for aiohttp 3.8

This change allows keeping more or less the same code that uses timeouts for both master and 3.8 branches.

The master has backward-incompatible changes and it is not complete yet; aiohttp 4.0 cannot be published anytime soon.

+19301 -28111

0 comment

224 changed files

pr created time in 7 hours

create barnchaio-libs/aiohttp

branch : bumpt-async-timeout

created branch time in 7 hours

more