profile
viewpoint
Rusty Russell rustyrussell Blockstream http://rusty.ozlabs.org GPG: 15EE 8D6C AB0E 7F0C F999 BFCB D920 0E6C D1AD B8F1 Rusty Russell <rusty@rustcorp.com.au>

lightningnetwork/lightning-rfc 1195

Lightning Network Specifications

rustyrussell/ccan 816

The C Code Archive Network

lightningd/plugins 107

Community curated plugins for c-lightning

rustyrussell/bitcoin-iterate 100

Simple fast iterator to extract data from bitcoind's blockchain files.

rustyrussell/bitcoin-storage-guide 81

Rusty's Remarkable Unreliable Guide To Bitcoin Storage

cdecker/lightning-integration 67

Lightning Integration Testing Framework

rustyrussell/bitcoin-iblt 8

IBLT benchmarking for bitcoin

pull request commentlightningd/plugins

backup: Implement network backup

Rebased, also added support for using the COMPACT command through the socket backend:

Received COMPACT       
Starting compaction: stats={'before': {'backupsize': 487140440, 'version_count': 49345}}
Adding intial snapshot with 181899264 bytes for version 1264659
Compacted 49343 changes, saving 305240217 bytes, swapping backups
user@medea:~ % lcli backup-compact
{
   "before": {
      "backupsize": 487140440,
      "version_count": 49345
   },
   "after": {
      "version_count": 2,
      "backupsize": 181900223
   }
}
laanwj

comment created time in 37 minutes

GollumEvent

Pull request review commentlightningd/plugins

backup: Add the ability to compact the backups

 def read_metadata(self):     def add_change(self, entry: Change) -> bool:         typ = b'\x01' if entry.snapshot is None else b'\x02'         if typ == b'\x01':-            payload = b'\x00'.join([t.encode('UTF-8') for t in entry.transaction])+            stmts = [t.encode('UTF-8') if isinstance(t, str) else t for t in entry.transaction]+            payload = b'\x00'.join(stmts)

Thanks—yeah no problem, these changes are very contained and easy to port over.

cdecker

comment created time in 2 hours

push eventlightningd/plugins

Michael Schmoock

commit sha 92aafe7404863d13da7810fe01ca5292e5fc5dc9

chore: rename feeadjustertoggle to feeadjuster-toggle

view details

push time in 8 hours

PR merged lightningd/plugins

chore: renames RPC feeadjusttoggle to feeadjust-toggle

After small chat with cdecker, using dash/minus in RPC name is good and will be translated to underscore in pyln on the fly.

+4 -4

4 comments

2 changed files

m-schmoock

pr closed time in 8 hours

pull request commentlightningd/plugins

chore: renames RPC feeadjusttoggle to feeadjust-toggle

Also: do we want feeadjuster-toggle or feeadjust-toggle ? I tend to the first. Second one is only better if we rename the whole plugin, which I dont like.

I think the current feeadjuster-toggle is good in the code. Maybe the commit message could be more precise, but does not matter.

m-schmoock

comment created time in 8 hours

pull request commentlightningd/plugins

chore: renames RPC feeadjusttoggle to feeadjust-toggle

tACK fb05a96 Now I can call feeadjuster-toggle (with dash) from command line and feeadjuster_toggle (with underscore) from python RPC.

m-schmoock

comment created time in 8 hours

pull request commentlightningd/plugins

chore: renames RPC feeadjusttoggle to feeadjust-toggle

Also: do we want feeadjuster-toggle or feeadjust-toggle ? I tend to the first. Second one is only better if we rename the whole plugin, which I dont like.

m-schmoock

comment created time in 8 hours

pull request commentlightningd/plugins

chore: renames RPC feeadjusttoggle to feeadjust-toggle

@gallizoltan as mentioned earlier ...

m-schmoock

comment created time in 8 hours

PR opened lightningd/plugins

chore: renames RPC feeadjusttoggle to feeadjust-toggle

After small chat with cdecker, using dash/minus in RPC name is good and will be translated to underscore in pyln on the fly.

+4 -4

0 comment

2 changed files

pr created time in 8 hours

issue commentElementsProject/lightning

Multiple channels not supported

Thanks to @niftynei's efforts we have an experimental implementation of dual-funding (compile with EXPERIMENTAL_FEATURES=1). Once the specification is finalized we expect other implementations to implement the proposal as well.

peername

comment created time in 8 hours

Pull request review commentlightningd/plugins

rebalance: better feeadjuster integration

 def get_ideal_ratio(channels: list, enough_liquidity: Millisatoshi):   def feeadjust_would_be_nice(plugin: Plugin):-    try:+    commands = [c for c in plugin.rpc.help().get("help") if c["command"].split()[0] == "feeadjust"]

Update: doesn't seem to work, as rpc code generates method on the fly when getattr is called.

gallizoltan

comment created time in 8 hours

PR closed lightningd/plugins

rebalance: improve the feeadjust availability check

This can be done without invoking RPC help. Sorry I didnt get this earlier ;)

+2 -4

4 comments

1 changed file

m-schmoock

pr closed time in 8 hours

pull request commentlightningd/plugins

rebalance: improve the feeadjust availability check

print(callable(getattr(plugin.rpc, "this_function_does_not_exist")))

Hm, just tried and it gives me: plugin-rebalance.py: True Do you know why?

m-schmoock

comment created time in 8 hours

PR opened ElementsProject/lightning

hsmtool: fix a segfault on `dumponchaindescriptors` default network parameter

fixes https://github.com/ElementsProject/lightning/issues/4339

+2 -2

0 comment

1 changed file

pr created time in 8 hours

pull request commentlightningd/plugins

rebalance: improve the feeadjust availability check

What happens if I call this?

print(callable(getattr(plugin.rpc, "this_function_does_not_exist")))
m-schmoock

comment created time in 9 hours

issue commentElementsProject/lightning

Change sqlite page_size to 4096 - massive performance improvement

Suggest separate thread, maybe link some of the relevant text in this thread. Some of the other SCAN TABLEs in the query plan might be worth pursuing but as per my analysis the expected speed increase would be significantly lower.

I could create a short document for tweaking parameters of your SQLITE based on the underlying filesystem characteristics.

mb300sd

comment created time in 9 hours

pull request commentlightningd/plugins

rebalance: improve the feeadjust availability check

Looks good to me, thanks! :)

m-schmoock

comment created time in 9 hours

pull request commentlightningd/plugins

rebalance: improve the feeadjust availability check

@gallizoltan does this also work for you?

m-schmoock

comment created time in 9 hours

Pull request review commentlightningd/plugins

rebalance: better feeadjuster integration

 def get_ideal_ratio(channels: list, enough_liquidity: Millisatoshi):   def feeadjust_would_be_nice(plugin: Plugin):-    try:+    commands = [c for c in plugin.rpc.help().get("help") if c["command"].split()[0] == "feeadjust"]

See https://github.com/lightningd/plugins/pull/201

gallizoltan

comment created time in 9 hours

PR opened lightningd/plugins

rebalance: improve the feeadjust availability check

This can be done without invoking RPC help. Sorry I didnt get this earlier ;)

+2 -4

0 comment

1 changed file

pr created time in 9 hours

Pull request review commentlightningd/plugins

backup: Add the ability to compact the backups

 def read_metadata(self):     def add_change(self, entry: Change) -> bool:         typ = b'\x01' if entry.snapshot is None else b'\x02'         if typ == b'\x01':-            payload = b'\x00'.join([t.encode('UTF-8') for t in entry.transaction])+            stmts = [t.encode('UTF-8') if isinstance(t, str) else t for t in entry.transaction]+            payload = b'\x00'.join(stmts)

Good point, I'm fine with either, since this is at runtime only and doesn't change the backup files.

Feel free to switch it around if that makes it easier to rebase.

Sorry for breaking your PR by merging this. I'll review #189 asap.

cdecker

comment created time in 9 hours

pull request commentlightningd/plugins

feeadjuster: no underscore in method name

@m-schmoock Ok, understood. I will submit a PR later today.

gallizoltan

comment created time in 9 hours

pull request commentlightningd/plugins

rebalance: better feeadjuster integration

Just looks a bit clunky ;)

* b80c558 (origin/master, origin/HEAD, master) rebalance: better feeadjuster integration - turns off feeadjuster's automatic fee updates while rebalance running - runs feeadjust only once, at the end - measures time for rebalance
* 7c88402 feeadjuster: no underscore in method name

Ok, I think I just hit one Enter in the commit message instead of two. Will do better next time.

gallizoltan

comment created time in 9 hours

issue commentElementsProject/lightning

Change sqlite page_size to 4096 - massive performance improvement

@mb300sd, @ZmnSCPxj merging #4337 auto-closed this issue. Would you like me to reopen, or shall we create a separate thread for further sqlite3 optimizations?

mb300sd

comment created time in 9 hours

pull request commentlightningd/plugins

feeadjuster: no underscore in method name

@gallizoltan

A follow up: After a small chat with cdecker we should have renamed feeadjuster_toggle to feeadjuster-toggle then the RPC code would be able to find and call it by using an underscore. Because the quoted code assumes that when we call a method with underscore, the RPC interface assumes there is a dash version of it.

gallizoltan

comment created time in 9 hours

pull request commentlightningd/plugins

rebalance: better feeadjuster integration

Just looks a bit clunky ;)

* b80c558 (origin/master, origin/HEAD, master) rebalance: better feeadjuster integration - turns off feeadjuster's automatic fee updates while rebalance running - runs feeadjust only once, at the end - measures time for rebalance
* 7c88402 feeadjuster: no underscore in method name
gallizoltan

comment created time in 10 hours

push eventlightningd/plugins

Gálli Zoltán

commit sha b80c558ebdd2ec8a72ceffda43b6966ff81a443f

rebalance: better feeadjuster integration - turns off feeadjuster's automatic fee updates while rebalance running - runs feeadjust only once, at the end - measures time for rebalance

view details

push time in 10 hours

PR merged lightningd/plugins

rebalance: better feeadjuster integration
  • turns off feeadjuster's automatic fee updates while rebalance running
  • runs feeadjust only once, at the end
  • measures time for rebalance
+25 -6

3 comments

1 changed file

gallizoltan

pr closed time in 10 hours

pull request commentlightningd/plugins

rebalance: better feeadjuster integration

@gallizoltan Next time, but could you try to keep the commit message to a 50/72 format? Meaning 50chars for the header and 72 chars for the text body part?

gallizoltan

comment created time in 10 hours

more