profile
viewpoint

startedrust-lang/book

started time in 18 minutes

startedrust-lang/rustlings

started time in 19 minutes

startedrust-lang/rust

started time in 21 minutes

Pull request review commentrust-lang/cargo

Add message caching.

 matrix:  before_script:   - rustup target add $ALT+  - rustup component add clippy || echo "clippy not available"

Should we do echo "clippy not available" here?

ehuss

comment created time in 30 minutes

push eventrust-lang/rust

William D. Jones

commit sha a775d11fff5f604c09c5ec06c2a82cb8fbef285f

Fix MSP430 AsmPrinter and assembler syntax mismatch.

view details

bors

commit sha b7f6b8a56befa0b83b869d27f7887cbcc0f38197

Auto merge of #60985 - cr1901:msp430-fix, r=alexcrichton Bump LLVM submodule to fix MSP430 AsmPrinter and assembler syntax mismatch. Moving on to steps 9 and 10 of the llvm bugfix [guide](https://rust-lang.github.io/rustc-guide/codegen/updating-llvm.html#bugfix-updates), now that Rust's copy of LLVM was [updated](https://github.com/rust-lang/llvm-project/pull/13). This PR closes issue #59077. Nightlies following this PR should have working msp430 codegen again :D. Thanks for the prompt response even though it took me a while to get this "simple" PR done!

view details

push time in 41 minutes

PR merged rust-lang/rust

Bump LLVM submodule to fix MSP430 AsmPrinter and assembler syntax mismatch. S-waiting-on-bors merged-by-bors

Moving on to steps 9 and 10 of the llvm bugfix guide, now that Rust's copy of LLVM was updated.

This PR closes issue #59077. Nightlies following this PR should have working msp430 codegen again :D.

Thanks for the prompt response even though it took me a while to get this "simple" PR done!

+1 -1

9 comments

1 changed file

cr1901

pr closed time in 41 minutes

push eventrust-lang/rust

Taiki Endo

commit sha b53d839b239d8fcf4cddfbd565ce5a8836217d5c

Move arbitrary_self_types's tests into ui/self

view details

Taiki Endo

commit sha 3e73ca6e336650eb0cb8429b3932d63d71c2a476

Move run-pass/self/* to ui/self

view details

bors

commit sha 46ad3e188287a3514de45ff89bac3cc451590d62

Auto merge of #60950 - taiki-e:arbitrary_self_types-tests, r=Centril Move arbitrary self types's tests into ui/self https://github.com/rust-lang/rust/pull/60944#discussion_r285362006 r? @Centril

view details

push time in 41 minutes

pull request commentrust-lang/rust

Move arbitrary self types's tests into ui/self

:hourglass: Testing commit 3e73ca6e336650eb0cb8429b3932d63d71c2a476 with merge 46ad3e188287a3514de45ff89bac3cc451590d62... <!-- homu: {"type":"BuildStarted","head_sha":"3e73ca6e336650eb0cb8429b3932d63d71c2a476","merge_sha":"46ad3e188287a3514de45ff89bac3cc451590d62"} -->

taiki-e

comment created time in 41 minutes

issue commentrust-lang/rustup.rs

Unable to download files, certificate verify failed

Actually, it looks like I might have been wrong about RUSTUP_USE_CURL=1 working; I noticed today that running rustc is still giving the no default toolchain configured error, and running rustup install stable or rustup default stable give errors regarding verifying the SSL certificate (with both the reqwest and curl backends) due to it being "self-signed".

The copy of rustc I'm using was installed with apt install rustc cargo -- even trying to print help/version gives the toolchain error; is there some setup command that is needed to tell rustc to ignore the lack of a default toolchain? The top search results all say to use rustup, which isn't working due to the certificate issues (I found a list of certs at work and installed all of them -- none of them seem to be the one used by the MITM device).

nightlark

comment created time in 41 minutes

pull request commentrust-lang/rust

Bump LLVM submodule to fix MSP430 AsmPrinter and assembler syntax mismatch.

:sunny: Test successful - checks-travis, status-appveyor Approved by: alexcrichton Pushing b7f6b8a56befa0b83b869d27f7887cbcc0f38197 to master... <!-- homu: {"type":"BuildCompleted","approved_by":"alexcrichton","base_ref":"master","builders":{"status-appveyor":"https://ci.appveyor.com/project/rust-lang/rust/builds/24685959","checks-travis":"https://travis-ci.com/rust-lang/rust/builds/112528072"},"merge_sha":"b7f6b8a56befa0b83b869d27f7887cbcc0f38197"} -->

cr1901

comment created time in 41 minutes

startedrust-lang/rust

started time in an hour

startedrust-lang/rust

started time in an hour

push eventrust-lang/crates.io-index

bors

commit sha 6a46c57ba1a4caac896ee5c0cc2ef4fa36efd84c

Updating crate `haru#0.2.13`

view details

push time in an hour

Pull request review commentrust-lang/rust

Update boxed::Box docs on memory layout

 impl<T: ?Sized> Box<T> {     ///     /// After calling this function, the raw pointer is owned by the     /// resulting `Box`. Specifically, the `Box` destructor will call-    /// the destructor of `T` and free the allocated memory. Since the-    /// way `Box` allocates and releases memory is unspecified, the-    /// only valid pointer to pass to this function is the one taken-    /// from another `Box` via the [`Box::into_raw`] function.+    /// the destructor of `T` and free the allocated memory. For this+    /// to be safe, the memory must have been allocated in the precise+    /// way that `Box` expects, namely, using the global allocator+    /// with the correct [`Layout`] for holding a value of type `T`. In+    /// particular, this will be satisfied for a pointer obtained+    /// from a previously existing `Box` using [`Box::into_raw`].+    ///+    /// # Safety     ///     /// This function is unsafe because improper use may lead to     /// memory problems. For example, a double-free may occur if the     /// function is called twice on the same raw pointer.     ///-    /// [`Box::into_raw`]: struct.Box.html#method.into_raw-    ///     /// # Examples-    ///+    /// Recreate a `Box` which was previously converted to a raw pointer using [`Box::into_raw`]:     /// ```     /// let x = Box::new(5);     /// let ptr = Box::into_raw(x);     /// let x = unsafe { Box::from_raw(ptr) };     /// ```+    /// Manually create a `Box` from scratch by using the global allocator:+    /// ```+    /// use std::alloc::{Layout, alloc};+    ///+    /// let ptr = unsafe{ alloc(Layout::new::<i32>()) } as *mut i32;+    /// unsafe{ *ptr = 5; }+    /// let x = unsafe{ Box::from_raw(ptr) };

Done! And thanks for the tip on the new rustfmt feature; it worked!

blkerby

comment created time in an hour

Pull request review commentrust-lang/rust

Update boxed::Box docs on memory layout

 impl<T: ?Sized> Box<T> {     ///     /// After calling this function, the raw pointer is owned by the     /// resulting `Box`. Specifically, the `Box` destructor will call-    /// the destructor of `T` and free the allocated memory. Since the-    /// way `Box` allocates and releases memory is unspecified, the-    /// only valid pointer to pass to this function is the one taken-    /// from another `Box` via the [`Box::into_raw`] function.+    /// the destructor of `T` and free the allocated memory. For this+    /// to be safe, the memory must have been allocated in the precise

Sounds great! I've just pushed a commit up to do this, creating a section called "Memory Layout" in the module docs. I also moved this section down to the bottom since it seemed better to have the simple examples first, before the more detailed information on memory layout.

blkerby

comment created time in an hour

startedrust-lang/rustlings

started time in an hour

issue commentrust-lang/rustc-guide

Rust Humor index

https://users.rust-lang.org/t/rust-koans/2408/4

mark-i-m

comment created time in an hour

startedrust-lang/rust-clippy

started time in 2 hours

push eventrust-lang/crates.io-index

bors

commit sha 61aa0000cda774616e14ae075ac4b4012dcee2f0

Updating crate `cita_trie#0.4.0`

view details

push time in 2 hours

push eventrust-lang/cargo

Ivan Tham

commit sha c2234069c82cfb90ab9780cb9694bb8df542b037

Fix typo

view details

bors

commit sha 0ef35b947031dc84fbf50e5d6e79dbd44b5cbbb2

Auto merge of #6974 - pickfire:patch-1, r=ehuss Fix typo

view details

push time in 2 hours

PR merged rust-lang/cargo

Fix typo S-waiting-on-bors
+1 -1

5 comments

1 changed file

pickfire

pr closed time in 2 hours

pull request commentrust-lang/cargo

Fix typo

:sunny: Test successful - checks-travis, status-appveyor Approved by: ehuss Pushing 0ef35b947031dc84fbf50e5d6e79dbd44b5cbbb2 to master... <!-- homu: {"type":"BuildCompleted","approved_by":"ehuss","base_ref":"master","builders":{"status-appveyor":"https://ci.appveyor.com/project/rust-lang-libs/cargo/builds/24687093","checks-travis":"https://travis-ci.com/rust-lang/cargo/builds/112533182"},"merge_sha":"0ef35b947031dc84fbf50e5d6e79dbd44b5cbbb2"} -->

pickfire

comment created time in 2 hours

pull request commentrust-lang/rustfmt

not to avoid self

Thanks!

rchaser53

comment created time in 2 hours

push eventrust-lang/rustfmt

rChaser53

commit sha 0ef2144c82fbba72411c8cce105a60866e2fa53d

not to avoid self (#3570)

view details

push time in 2 hours

PR merged rust-lang/rustfmt

not to avoid self

fix: #3568

+11 -7

1 comment

3 changed files

rchaser53

pr closed time in 2 hours

issue closedrust-lang/rustfmt

`use` normalization can break `self` imports

There are rare cases where normalizing a use a::b::{self}; into use a::b; will break things. Specifically, cases in which b already exists as a function or macro in the current namespace, and you only want to import it as a module.

Playground example: https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=12f1d13256258ac8b34d06b9592a86ef

Running rustfmt on this will cause it to no longer compile.

closed time in 2 hours

jrobsonchase

push eventrust-lang/rustfmt

Stéphane Campinas

commit sha 5a5aa459f66e88a6b50c1cc22ff3d84def6024b4

changelog for 0.4.2

view details

Stéphane Campinas

commit sha 2c7a0ca57592e84c190fe5c4111736f17223cfe6

changelog for 0.5.0

view details

Stéphane Campinas

commit sha 583d58d80b22a44f1e4f9a43cab9b3c5f9a6358a

changelog for 0.6.0

view details

Stéphane Campinas

commit sha d169b957103cb180cb631b8765725ad2cb5c21d0

changelog for 0.6.1

view details

Stéphane Campinas

commit sha 6d83d59b8d6094083892140f00a2f048f5663a30

changelog for 0.7.0

view details

Stéphane Campinas

commit sha 8ea5460e7914912c8239ad7783e7ab0f8124f0d1

changelog for 0.8.2

view details

Stéphane Campinas

commit sha 67bab695adfb2c42c1bb19642b3961a3dbbc9458

changelog for 0.9.0

view details

Stéphane Campinas

commit sha 3ac895236c4f3f07720b31cfc212192104969ac2

changelog for 0.99.0

view details

Stéphane Campinas

commit sha e425e4c376a7736a01f1fac74126e3784a0da4e8

changelog for 0.99.1

view details

Stéphane Campinas

commit sha 9646ef1a142c94eba27e989b507204e57cd0f8b4

changelog for 0.99.2

view details

Stéphane Campinas

commit sha 135db8e787ed07633c66cd26f73f1ec27ef6fd1d

changelog for 0.99.3

view details

Stéphane Campinas

commit sha 9618e22a349d8a37ee041a50317219734ab7a57f

changelog for 0.99.4

view details

Stéphane Campinas

commit sha 61dc467a5902392ae272247d53ac2364f8c1efb3

changelog for 0.99.5

view details

Stéphane Campinas

commit sha 1c3437db8cc76d4d7fb27271a1aefa18abf85fe6

changelog for 0.99.6

view details

Stéphane Campinas

commit sha ca18c45d99097555847f451549c71e347fea474f

changelog for 0.99.7

view details

Stéphane Campinas

commit sha c51c27034a9361e1b7ba751b9dbff9dbd4af15f3

changelog for 0.99.8

view details

Stéphane Campinas

commit sha 416795d1d69fdd553a9960d956103318d3dfe139

changelog for 0.99.9

view details

Stéphane Campinas

commit sha b7dec0c357d6d674e8de5d94097195e6f01fe1fc

changelog for 1.0.0

view details

Stéphane Campinas

commit sha 7a711b357e6aa9095a973e3609a566dbfaf7dd2c

changelog for 1.0.1

view details

Stéphane Campinas

commit sha fa59a683c03286764a634f251a2fd50748331a6f

changelog for 1.0.2

view details

push time in 2 hours

PR merged rust-lang/rustfmt

Update changelogs

Close #3525

+437 -0

1 comment

1 changed file

scampi

pr closed time in 2 hours

issue closedrust-lang/rustfmt

Revive changelog

closed time in 2 hours

topecongiro

pull request commentrust-lang/rustfmt

Update changelogs

Awesome, thank you!

scampi

comment created time in 2 hours

push eventrust-lang/rustup-components-history

Deploy from CI

commit sha 4f09ea32053e3b55f0022d883242e3bbef888ffe

Deploy 5c2b9119d660e6ac23a6c58560f6b26b5afc7d4d to gh-pages

view details

push time in 2 hours

pull request commentrust-lang/rust

Add DocFS layer to rustdoc

I think this is complete now; if it fails CI obviously I'll fix it, but barring review feedback, I have no further planned changes.

rbtcollins

comment created time in 2 hours

push eventrust-lang/cargo

Ivan Tham

commit sha c2234069c82cfb90ab9780cb9694bb8df542b037

Fix typo

view details

bors

commit sha 0ef35b947031dc84fbf50e5d6e79dbd44b5cbbb2

Auto merge of #6974 - pickfire:patch-1, r=ehuss Fix typo

view details

push time in 2 hours

pull request commentrust-lang/cargo

Fix typo

:hourglass: Testing commit c2234069c82cfb90ab9780cb9694bb8df542b037 with merge 0ef35b947031dc84fbf50e5d6e79dbd44b5cbbb2... <!-- homu: {"type":"BuildStarted","head_sha":"c2234069c82cfb90ab9780cb9694bb8df542b037","merge_sha":"0ef35b947031dc84fbf50e5d6e79dbd44b5cbbb2"} -->

pickfire

comment created time in 2 hours

pull request commentrust-lang/cargo

Fix typo

:pushpin: Commit c2234069c82cfb90ab9780cb9694bb8df542b037 has been approved by ehuss

<!-- @bors r=ehuss c2234069c82cfb90ab9780cb9694bb8df542b037 -->

pickfire

comment created time in 2 hours

pull request commentrust-lang/cargo

Fix typo

@bors r+

pickfire

comment created time in 2 hours

issue openedrust-lang/rust

Equality Comparison of u128 produces less ideal assembly

Compiled on Stable with Release target.

#[no_mangle]
pub fn foo(a: u128, b: u128) -> bool
{
    a == b
}

#[no_mangle]
pub fn foo2(a: u128, b: u128) -> bool
{
    ((a >> 64) as u64) == ((b >> 64) as u64) && (a as u64) == (b as u64)
}

#[no_mangle]
pub fn foo3(a: u128, b: u128) -> bool
{
    bar((a >> 64) as u64, a as u64, (b >> 64) as u64, b as u64)
}

#[no_mangle]
pub fn bar(a1: u64, a2: u64, b1: u64, b2: u64) -> bool
{
    a1 == b1 && a2 == b2
}

Produces:

foo:
	movq	xmm0, rcx
	movq	xmm1, rdx
	punpcklqdq	xmm1, xmm0
	movq	xmm0, rsi
	movq	xmm2, rdi
	punpcklqdq	xmm2, xmm0
	pcmpeqb	xmm2, xmm1
	pmovmskb	eax, xmm2
	cmp	eax, 65535
	sete	al
	ret

foo2:
	xor	rsi, rcx
	xor	rdi, rdx
	or	rdi, rsi
	sete	al
	ret

foo3:
	xor	rsi, rcx
	xor	rdi, rdx
	or	rdi, rsi
	sete	al
	ret

bar:
	xor	rdi, rdx
	xor	rsi, rcx
	or	rsi, rdi
	sete	al
	ret

It seems like all three methods should produce the same ASM.

created time in 2 hours

push eventrust-lang/crates.io-index

bors

commit sha f164415efc49a802a193bc6315ce25fc68a91f1c

Yanking crate `heaparray#0.4.0`

view details

push time in 2 hours

startedrust-lang/rust

started time in 2 hours

push eventrust-lang/crates.io-index

bors

commit sha df2a1f31f8ef82f2bb20a7ca2be3148db8b69a2b

Updating crate `heaparray#0.4.1`

view details

push time in 2 hours

startedrust-lang/rustlings

started time in 2 hours

pull request commentrust-lang/rust

std: Depend on `backtrace` crate from crates.io

That seems pretty bad - is the theory that it's specifically limited to symbols in libstd?

alexcrichton

comment created time in 2 hours

issue closedrust-lang/rust

Generic function produces multiple identical methods in ASM.

Compiled on Stable with Release target.

use std::any::Any;

#[inline(never)]
fn cast<T1: ?Sized, T2>(t: Box<T1>) -> Box<T2>
{
    unsafe { Box::from_raw(Box::into_raw(t) as *mut T2) }
}

fn main()
{
    let t: Box<Any> = Box::new(5);
    let s: Box<u32> = cast(t);
    println!("{}", *s);

    let t: Box<Any> = Box::new(10.0f32);
    let s: Box<f32> = cast(t);
    println!("{}", *s);
}

In the ASM, I see the following produced.

playground::cast:
    mov    rax, rdi
    ret

playground::cast:
    mov    rax, rdi
    ret

I observed this earlier today on Rust Playground. I don't know if #[inline(never)] is causing them not to be merged, or if it's expected that they don't get merged despite being identical. It seems to me like they should be merged, as they are identical aside from the type parameters, which is only a difference at compile time, not runtime.

closed time in 2 hours

rickvanprim

issue commentrust-lang/rust

Generic function produces multiple identical methods in ASM.

Sorry for the slow response. Just tested now and issue no longer reproduces!

rickvanprim

comment created time in 2 hours

push eventrust-lang/crates.io-index

bors

commit sha 87494b868e33130b1223a8e69c430d5f8dad2145

Updating crate `mysql_fetcher#0.1.2`

view details

push time in 2 hours

pull request commentrust-lang/cargo

Fix typo

r? @ehuss

(rust_highfive has picked a reviewer for you, use r? to override)

pickfire

comment created time in 2 hours

PR opened rust-lang/cargo

Fix typo
+1 -1

0 comment

1 changed file

pr created time in 2 hours

startedrust-lang/rust

started time in 2 hours

startedrust-lang/rustlings

started time in 2 hours

pull request commentrust-lang/rust

Remove more Lrcs from queries

Success: Queued 3c4e28e6354da9ee1a4d40f8bd3eee4d55bc8f61 with parent d35181ad8785fa958e43580a29a982afe02c728f, comparison URL.

Zoxc

comment created time in 3 hours

pull request commentrust-lang/rust

Remove more Lrcs from queries

@rust-timer build 3c4e28e6354da9ee1a4d40f8bd3eee4d55bc8f61

Zoxc

comment created time in 3 hours

issue commentrust-lang/rust

Tracking issue for stabilizing "pipelined compilation"

One might argue that metadata generation should be moved earlier.

No no... ;) At the start of code-gen sounds good to me and we should be cautious with moving it too much earlier as that can mess with language design.

alexcrichton

comment created time in 3 hours

push eventrust-lang/crates.io-index

bors

commit sha 88f3c299570374fa255d155d10eee5c5cfa3dac3

Updating crate `jsonrpc-parse#0.1.1`

view details

push time in 3 hours

pull request commentrust-lang/rust

Allow lifetime elision in arbitrary_self_types

I haven't reviewed anything in the file changed;

r? @eddyb

taiki-e

comment created time in 3 hours

Pull request review commentrust-lang/rust

Allow lifetime elision in arbitrary_self_types

+#![feature(arbitrary_self_types)]++use std::pin::Pin;++#[derive(Debug)]+struct Foo;+#[derive(Debug)]+struct Bar<'a>(&'a Foo);++impl std::ops::Deref for Bar<'_> {+    type Target = Foo;+    fn deref(&self) -> &Self::Target {+        &self.0+    }+}++impl Foo {+    fn a(&self) -> Bar<'_> {+        Bar(self)+    }++    fn b(c: &Self) -> Bar<'_> {+        Bar(c)+    }++    fn c(self: Bar<'_>) -> Bar<'_> {+        self+    }++    fn d(e: Bar<'_>) -> Bar<'_> {+        e+    }++    fn e(self: &Self) -> Bar<'_> {+        Bar(self)+    }++    fn f(self: Bar<'_>) -> impl std::fmt::Debug {+        self+        //~^ ERROR cannot infer an appropriate lifetime

Consider splitting this case to a different file which can be // compile-fail while the others can be *-pass.

taiki-e

comment created time in 3 hours

Pull request review commentrust-lang/rust

Allow lifetime elision in arbitrary_self_types

 impl<'a, 'tcx> LifetimeContext<'a, 'tcx> {             _ => false,         }; +        // Only skip `Self`, `&Self` and `&mut Self`,+        // and to handle other `self`s like normal arguments.+        let mut skip = 0;

Would be better as a bool and then cast to usize as needed. In so doing, also rename to should_skip or something like that.

taiki-e

comment created time in 3 hours

pull request commentrust-lang/cargo

cargo package: detect new empty directories

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

ExpHP

comment created time in 3 hours

PR opened rust-lang/cargo

cargo package: detect new empty directories

Detect the creation of directories in a build script, which is currently a very tempting workaround for the fact that a crate built from a package will be missing any empty directories.

Maybe it would be better to only include directories in the map of hashes if they are completely empty.

The removal of a directory that is initially empty cannot be tested because, as stated above, a crate built from a package will not have any empty directories.

Closes #6931.

+11 -4

0 comment

2 changed files

pr created time in 3 hours

push eventrust-lang/crates.io-index

bors

commit sha 04eb860b675fadd40557dba7a66963309cac3cfa

Updating crate `drumatech#0.1.0`

view details

push time in 3 hours

issue commentrust-lang/rust

Tracking issue for stabilizing "pipelined compilation"

Yes: metadata is now generated right at the start of code generation, immediately after all the checking (typeck, borrowck, etc.) finish. This is the best place for the initial pipelining implementation.

One might argue that metadata generation should be moved earlier. That would help with successful builds, but slow down builds that trigger compile errors. Given that a lot of Rust compiler invocations end in compile errors during the normal development cycle, slowing down such invocations would be bad.

Another possibility is to generate metadata in parallel with checking. That might give the best of both worlds. But that's a bigger change.

alexcrichton

comment created time in 3 hours

pull request commentrust-lang/rust

Simplify use of keyword symbols

This should be ready for rebasing now.

petrochenkov

comment created time in 3 hours

push eventrust-lang/crates.io-index

bors

commit sha bcff106acd70bd81fb306b30a309206b23a2d30c

Updating crate `sw-composite#0.5.1`

view details

push time in 3 hours

issue openedrust-lang/rust

False positive for explicit_outlives_requirements lint

#![allow(dead_code)]
#![deny(explicit_outlives_requirements)]

struct Test<'a, T>(&'a T) where T: ?Sized;

(Playground)

Errors:

   Compiling playground v0.0.1 (/playground)
error: outlives requirements can be inferred
 --> src/lib.rs:4:19
  |
4 | struct Test<'a, T>(&'a T) where T: ?Sized;
  |                   ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these bounds
  |
note: lint level defined here
 --> src/lib.rs:2:9
  |
2 | #![deny(explicit_outlives_requirements)]
  |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to previous error

error: Could not compile `playground`.

To learn more, run the command again with --verbose.

Maybe I'm missing something, but this lint error makes no sense in this context, as there are no outlives bounds written.

created time in 3 hours

issue commentrust-lang/rust

ICE with incorrect turbofish

Possibly related to const generics? cc @varkor

With backtrace:

error: internal compiler error: src/librustc_typeck/check/mod.rs:2456: no type for node 48: type B (hir_id=HirId { owner: DefIndex(16), local_id: 13 }) in fcx 0x7f82da7ec990

thread 'rustc' panicked at 'Box<Any>', src/librustc_errors/lib.rs:637:9
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
stack backtrace:
   0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
             at src/libstd/sys/unix/backtrace/tracing/gcc_s.rs:39
   1: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:71
   2: std::panicking::default_hook::{{closure}}
             at src/libstd/sys_common/backtrace.rs:59
             at src/libstd/panicking.rs:197
   3: std::panicking::default_hook
             at src/libstd/panicking.rs:211
   4: rustc::util::common::panic_hook
   5: std::panicking::rust_panic_with_hook
             at src/libstd/panicking.rs:478
   6: std::panicking::begin_panic
   7: rustc_errors::Handler::bug
   8: rustc::util::bug::opt_span_bug_fmt::{{closure}}
   9: rustc::ty::context::tls::with_opt::{{closure}}
  10: rustc::ty::context::tls::with_context_opt
  11: rustc::ty::context::tls::with_opt
  12: rustc::util::bug::opt_span_bug_fmt
  13: rustc::util::bug::bug_fmt
  14: rustc_typeck::check::FnCtxt::node_ty
  15: <rustc_typeck::check::writeback::WritebackCx as rustc::hir::intravisit::Visitor>::visit_ty
  16: rustc::hir::intravisit::walk_path
  17: rustc::hir::intravisit::walk_ty
  18: <rustc_typeck::check::writeback::WritebackCx as rustc::hir::intravisit::Visitor>::visit_ty
  19: rustc::hir::intravisit::walk_path
  20: <rustc_typeck::check::writeback::WritebackCx as rustc::hir::intravisit::Visitor>::visit_expr
  21: rustc::hir::intravisit::walk_expr
  22: <rustc_typeck::check::writeback::WritebackCx as rustc::hir::intravisit::Visitor>::visit_expr
  23: <rustc_typeck::check::writeback::WritebackCx as rustc::hir::intravisit::Visitor>::visit_local
  24: rustc::hir::intravisit::walk_expr
  25: <rustc_typeck::check::writeback::WritebackCx as rustc::hir::intravisit::Visitor>::visit_expr
  26: rustc_typeck::check::writeback::<impl rustc_typeck::check::FnCtxt>::resolve_type_vars_in_body
  27: rustc::ty::context::GlobalCtxt::enter_local
  28: rustc_typeck::check::typeck_tables_of
  29: rustc::ty::query::__query_compute::typeck_tables_of
  30: rustc::ty::query::<impl rustc::ty::query::config::QueryAccessors for rustc::ty::query::queries::typeck_tables_of>::compute
  31: rustc::dep_graph::graph::DepGraph::with_task_impl
  32: rustc::ty::query::plumbing::<impl rustc::ty::context::TyCtxt>::get_query
  33: rustc::ty::<impl rustc::ty::context::TyCtxt>::par_body_owners
  34: rustc_typeck::check::typeck_item_bodies
  35: rustc::ty::query::__query_compute::typeck_item_bodies
  36: rustc::ty::query::<impl rustc::ty::query::config::QueryAccessors for rustc::ty::query::queries::typeck_item_bodies>::compute
  37: rustc::dep_graph::graph::DepGraph::with_task_impl
  38: rustc::ty::query::plumbing::<impl rustc::ty::context::TyCtxt>::get_query
  39: rustc::util::common::time
  40: rustc_typeck::check_crate
  41: rustc_interface::passes::analysis
  42: rustc::ty::query::__query_compute::analysis
  43: rustc::ty::query::<impl rustc::ty::query::config::QueryAccessors for rustc::ty::query::queries::analysis>::compute
  44: rustc::dep_graph::graph::DepGraph::with_task_impl
  45: rustc::ty::query::plumbing::<impl rustc::ty::context::TyCtxt>::get_query
  46: rustc::ty::context::tls::enter_global
  47: rustc_interface::passes::BoxedGlobalCtxt::access::{{closure}}
  48: rustc_interface::passes::create_global_ctxt::{{closure}}
  49: rustc_interface::interface::run_compiler_in_existing_thread_pool
  50: std::thread::local::LocalKey<T>::with
  51: scoped_tls::ScopedKey<T>::set
  52: syntax::with_globals
query stack during panic:
#0 [typeck_tables_of] processing `main`
#1 [typeck_item_bodies] type-checking all item bodies
#2 [analysis] running analysis passes on this crate
end of query stack
error: aborting due to previous error


note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports

note: rustc 1.36.0-nightly (6afcb5628 2019-05-19) running on x86_64-unknown-linux-gnu

note: compiler flags: -C codegen-units=1 -C debuginfo=2 --crate-type bin

note: some of the compiler flags provided by cargo are hidden

error: Could not compile `playground`.
cramertj

comment created time in 3 hours

push eventrust-lang/crates.io-index

bors

commit sha 4286031fb16fdca107f1fd1a2a237178ac639375

Updating crate `gadu#0.1.2`

view details

push time in 3 hours

issue commentrust-lang/rust

Tracking issue for stabilizing "pipelined compilation"

Reading the various issues and PRs, I got the impression that metadata is generated at earliest post static analysis, is that correct?

alexcrichton

comment created time in 3 hours

push eventrust-lang/crates.io-index

bors

commit sha 89cb99781573b4d64228ec0e5b06db541140a009

Updating crate `heaparray#0.4.0`

view details

push time in 3 hours

startedrust-lang/rustlings

started time in 3 hours

startedrust-lang/cargo

started time in 3 hours

pull request commentrust-lang/rust-by-example

Reword "Flow Control" to "Flow of Control"

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @marioidival (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

russelldavis

comment created time in 3 hours

PR opened rust-lang/rust-by-example

Reword "Flow Control" to "Flow of Control"

It's a bit of a nit, but flow control generally refers to something different. The way it's being used here, it's usually worded as flow of control or control flow.

References: https://en.wikipedia.org/wiki/Flow_control https://en.wikipedia.org/wiki/Control_flow

+3 -3

0 comment

3 changed files

pr created time in 3 hours

pull request commentrust-lang/rustfmt

not to avoid self

Thank you the review. I fixed it.

rchaser53

comment created time in 3 hours

issue commentrust-lang/rust

ICE with incorrect turbofish

Prior output:

error[E0109]: type arguments are not allowed on this entity
  --> <source>:12:22
   |
12 |     let c2: B = c1::<Into<B>>.into();
   |                      ^^^^^^^ type argument not allowed
cramertj

comment created time in 3 hours

issue openedrust-lang/rustfmt

Inconsistent Formatting with non-ASCII characters

It appears that rustfmt does not always format essentially identical lines the same, and in this case the only difference is that one line has only ASCII characters, while the other has non-ASCII characters. The specific example I have (after formatting):

pub fn foo(config: &Config) {
    let csv = RefCell::new(create_csv(config, "foo"));
    {
        let mut csv = csv.borrow_mut();
        for (i1, i2, i3) in iproduct!(0..2, 0..3, 0..3) {
            csv.write_field(format!("γ[{}.{}.{}]", i1, i2, i3))
                .unwrap();
            csv.write_field(format!("d[{}.{}.{}]", i1, i2, i3)).unwrap();
            csv.write_field(format!("i[{}.{}.{}]", i1, i2, i3)).unwrap();
        }
        csv.write_record(None::<&[u8]>).unwrap();
    }

where each line within the iproduct! loop should be identical as they are all exactly the same length; however, the line with the γ letter is formatted differently to the other two.

Note I am using rustfmt 1.0.3-stable (d6829d6 2019-02-14)

created time in 3 hours

PR closed rust-lang/rust

Rollup of 3 pull requests S-waiting-on-review

Successful merges:

  • #60950 (Move arbitrary self types's tests into ui/self)
  • #60981 (Bump compiler-builtins to 0.1.15)
  • #60985 (Bump LLVM submodule to fix MSP430 AsmPrinter and assembler syntax mismatch.)

Failed merges:

r? @ghost

+57 -28

5 comments

38 changed files

Centril

pr closed time in 4 hours

startedrust-lang/rust

started time in 4 hours

push eventrust-lang/rust

bors

commit sha b7f6b8a56befa0b83b869d27f7887cbcc0f38197

Auto merge of #60985 - cr1901:msp430-fix, r=alexcrichton Bump LLVM submodule to fix MSP430 AsmPrinter and assembler syntax mismatch. Moving on to steps 9 and 10 of the llvm bugfix [guide](https://rust-lang.github.io/rustc-guide/codegen/updating-llvm.html#bugfix-updates), now that Rust's copy of LLVM was [updated](https://github.com/rust-lang/llvm-project/pull/13). This PR closes issue #59077. Nightlies following this PR should have working msp430 codegen again :D. Thanks for the prompt response even though it took me a while to get this "simple" PR done!

view details

push time in 4 hours

pull request commentrust-lang/rust

Bump LLVM submodule to fix MSP430 AsmPrinter and assembler syntax mismatch.

:hourglass: Testing commit a775d11fff5f604c09c5ec06c2a82cb8fbef285f with merge b7f6b8a56befa0b83b869d27f7887cbcc0f38197... <!-- homu: {"type":"BuildStarted","head_sha":"a775d11fff5f604c09c5ec06c2a82cb8fbef285f","merge_sha":"b7f6b8a56befa0b83b869d27f7887cbcc0f38197"} -->

cr1901

comment created time in 4 hours

pull request commentrust-lang/rust

Rollup of 3 pull requests

The job dist-aarch64-linux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

<details><summary><i>Click to expand the log.</i></summary>

[00:03:52] --- stdout
[00:03:52] TARGET = Some("x86_64-unknown-linux-gnu")
[00:03:52] OPT_LEVEL = Some("2")
[00:03:52] HOST = Some("x86_64-unknown-linux-gnu")
[00:03:52] CC_x86_64-unknown-linux-gnu = Some("sccache cc")
[00:03:52] CFLAGS_x86_64-unknown-linux-gnu = Some("-ffunction-sections -fdata-sections -fPIC -m64")
[00:03:52] CRATE_CC_NO_DEFAULTS = None
[00:03:52] DEBUG = Some("false")
[00:03:52] CARGO_CFG_TARGET_FEATURE = Some("fxsr,mmx,sse,sse2")
[00:03:52] running: "sccache" "cc" "-O2" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-fno-builtin" "-fvisibility=hidden" "-fomit-frame-pointer" "-ffreestanding" "-DVISIBILITY_HIDDEN" "-DCOMPILER_RT_HAS_UNAME=1" "-DCOMPILER_RT_HAS_FCNTL_LCK=1" "-DCOMPILER_RT_HAS_ATOMICS=1" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/x86_64-unknown-linux-gnu/release/build/profiler_builtins-98e28db5f13c3bec/out/GCDAProfiling.o" "-c" "/cargo/registry/src/github.com-1ecc6299db9ec823/compiler_builtins-0.1.15/compiler-rt/lib/profile/GCDAProfiling.c"
[00:03:52] cargo:warning=cc: error: /cargo/registry/src/github.com-1ecc6299db9ec823/compiler_builtins-0.1.15/compiler-rt/lib/profile/GCDAProfiling.c: No such file or directory
[00:03:52] cargo:warning=cc: warning: '-x c' after last input file has no effect
[00:03:52] cargo:warning=cc: fatal error: no input files
[00:03:52] cargo:warning=compilation terminated.
[00:03:52] 
[00:03:52] --- stderr
[00:03:52] thread 'main' panicked at '
[00:03:52] 
[00:03:52] 
[00:03:52] Internal error occurred: Command "sccache" "cc" "-O2" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-fno-builtin" "-fvisibility=hidden" "-fomit-frame-pointer" "-ffreestanding" "-DVISIBILITY_HIDDEN" "-DCOMPILER_RT_HAS_UNAME=1" "-DCOMPILER_RT_HAS_FCNTL_LCK=1" "-DCOMPILER_RT_HAS_ATOMICS=1" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/x86_64-unknown-linux-gnu/release/build/profiler_builtins-98e28db5f13c3bec/out/GCDAProfiling.o" "-c" "/cargo/registry/src/github.com-1ecc6299db9ec823/compiler_builtins-0.1.15/compiler-rt/lib/profile/GCDAProfiling.c" with args "cc" did not execute successfully (status code exit code: 1).
[00:03:52] ', /cargo/registry/src/github.com-1ecc6299db9ec823/cc-1.0.35/src/lib.rs:2398:5
[00:03:52] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[00:03:52] 
[00:03:52] warning: build failed, waiting for other jobs to finish...
---
travis_time:end:1e2e92de:start=1558399699876263235,finish=1558399699890322238,duration=14059003
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0a4ee891
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0a0a8324
travis_time:start:0a0a8324
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:00bbd071
$ dmesg | grep -i kill

</details><p></p>

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Centril

comment created time in 4 hours

pull request commentrust-lang/rust

Rollup of 3 pull requests

:broken_heart: Test failed - checks-travis <!-- homu: {"type":"BuildFailed","builder_url":"https://travis-ci.com/rust-lang/rust/builds/112527671","builder_name":"checks-travis"} -->

Centril

comment created time in 4 hours

pull request commentrust-lang/rust

Remove more Lrcs from queries

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

<details><summary><i>Click to expand the log.</i></summary>

travis_time:end:02179482:start=1558393394901951467,finish=1558393397101869866,duration=2199918399
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
travis_time:start:test_codegen
Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:18:32] 
[01:18:32] running 143 tests
[01:18:35] i..iii.....iii..iiii.....i......................i..i.................i.....i..........ii.i..i..i.ii. 100/143
[01:18:36] test result: ok. 113 passed; 0 failed; 30 ignored; 0 measured; 0 filtered out
[01:18:36] 
[01:18:36]  finished in 4.550
[01:18:36] travis_fold:end:test_codegen
---
travis_time:start:test_assembly
Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:18:39] 
[01:18:39] running 9 tests
[01:18:39] iiiiiiiii
[01:18:39] 
[01:18:39]  finished in 0.153
[01:18:39] travis_fold:end:test_assembly

---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:18:54] 
[01:18:54] running 122 tests
[01:19:18] .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....i..........iiii..........i...ii...i.......ii.i 100/122
[01:19:23] .i.i......iii.i.....ii
[01:19:23] 
[01:19:23]  finished in 29.257
[01:19:23] travis_fold:end:test_debuginfo

---
travis_time:start:test_run-make-fulldeps
Check compiletest suite=run-make-fulldeps mode=run-make (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:41:11] 
[01:41:11] running 199 tests
[01:41:36] ..................i...i.......................................F........................i............ 100/199
[01:42:20] ...........................iiii........i..........iiii.iii....................................i....
[01:42:20] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:512:22
[01:42:20] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:42:20] 
[01:42:20] ---- [run-make] run-make-fulldeps/hotplug_codegen_backend stdout ----
[01:42:20] ---- [run-make] run-make-fulldeps/hotplug_codegen_backend stdout ----
[01:42:20] 
[01:42:20] error: make failed
[01:42:20] status: exit code: 2
[01:42:20] command: "make"
[01:42:20] stdout:
[01:42:20] ------------------------------------------
[01:42:20] make[1]: Entering directory '/checkout/src/test/run-make-fulldeps/hotplug_codegen_backend'
[01:42:20] /bin/echo || exit 0 # This test requires /bin/echo to exist
[01:42:20] 
[01:42:20] LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/hotplug_codegen_backend/hotplug_codegen_backend:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib" '/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc' --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/hotplug_codegen_backend/hotplug_codegen_backend -L /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/hotplug_codegen_backend/hotplug_codegen_backend  the_backend.rs --crate-name the_backend --crate-type dylib \
[01:42:20]  -o /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/hotplug_codegen_backend/hotplug_codegen_backend/the_backend.dylib
[01:42:20] Makefile:4: recipe for target 'all' failed
[01:42:20] make[1]: Leaving directory '/checkout/src/test/run-make-fulldeps/hotplug_codegen_backend'
[01:42:20] ------------------------------------------
[01:42:20] stderr:
[01:42:20] ------------------------------------------
[01:42:20] ------------------------------------------
[01:42:20] warning: ignoring --out-dir flag due to -o flag
[01:42:20] 
[01:42:20] error[E0277]: the trait bound `&std::collections::HashMap<std::string::String, std::option::Option<syntax::ast::Name>, std::hash::BuildHasherDefault<rustc_data_structures::fx::FxHasher>>: std::default::Default` is not satisfied
[01:42:20]   --> the_backend.rs:51:13
[01:42:20] 51 |             Default::default() // Just a dummy
[01:42:20] 51 |             Default::default() // Just a dummy
[01:42:20]    |             ^^^^^^^^^^^^^^^^ the trait `std::default::Default` is not implemented for `&std::collections::HashMap<std::string::String, std::option::Option<syntax::ast::Name>, std::hash::BuildHasherDefault<rustc_data_structures::fx::FxHasher>>`
[01:42:20]    = help: the following implementations were found:
[01:42:20]              <std::collections::HashMap<K, V, S> as std::default::Default>
[01:42:20]    = note: required by `std::default::Default::default`
[01:42:20] 
[01:42:20] 
[01:42:20] error: aborting due to previous error
[01:42:20] 
[01:42:20] For more information about this error, try `rustc --explain E0277`.
[01:42:20] make[1]: *** [all] Error 1
[01:42:20] ------------------------------------------
[01:42:20] 
[01:42:20] 
[01:42:20] 
[01:42:20] 
[01:42:20] failures:
[01:42:20]     [run-make] run-make-fulldeps/hotplug_codegen_backend
[01:42:20] 
[01:42:20] test result: FAILED. 182 passed; 1 failed; 16 ignored; 0 measured; 0 filtered out
[01:42:20] 
[01:42:20] 
[01:42:20] 
[01:42:20] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--rustdoc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "--src-base" "/checkout/src/test/run-make-fulldeps" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "run-make" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "cc" "--cxx" "c++" "--cflags" "-ffunction-sections -fdata-sections -fPIC -m64" "--llvm-components" "aarch64 aarch64asmparser aarch64asmprinter aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils all all-targets amdgpu amdgpuasmparser amdgpuasmprinter amdgpucodegen amdgpudesc amdgpudisassembler amdgpuinfo amdgpuutils analysis arm armasmparser armasmprinter armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter binaryformat bitreader bitwriter bpf bpfasmparser bpfasmprinter bpfcodegen bpfdesc bpfdisassembler bpfinfo codegen core coroutines coverage debuginfocodeview debuginfodwarf debuginfomsf debuginfopdb demangle dlltooldriver engine executionengine fuzzmutate globalisel hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo instcombine instrumentation interpreter ipo irreader lanai lanaiasmparser lanaiasmprinter lanaicodegen lanaidesc lanaidisassembler lanaiinfo libdriver lineeditor linker lto mc mcdisassembler mcjit mcparser mips mipsasmparser mipsasmprinter mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmprinter msp430codegen msp430desc msp430info native nativecodegen nvptx nvptxasmprinter nvptxcodegen nvptxdesc nvptxinfo objcarcopts object objectyaml option orcjit passes powerpc powerpcasmparser powerpcasmprinter powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata runtimedyld scalaropts selectiondag sparc sparcasmparser sparcasmprinter sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzasmprinter systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target transformutils vectorize windowsmanifest x86 x86asmparser x86asmprinter x86codegen x86desc x86disassembler x86info x86utils xcore xcoreasmprinter xcorecodegen xcoredesc xcoredisassembler xcoreinfo" "--llvm-cxxflags" "-I/usr/lib/llvm-6.0/include -std=c++0x -fuse-ld=gold -Wl,--no-keep-files-mapped -Wl,--no-map-whole-files -fPIC -fvisibility-inlines-hidden -Werror=date-time -std=c++11 -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wno-maybe-uninitialized -Wdelete-non-virtual-dtor -Wno-comment -ffunction-sections -fdata-sections -O2 -DNDEBUG  -fno-exceptions -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS" "--ar" "ar" "--llvm-bin-dir" "/usr/lib/llvm-6.0/bin" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:42:20] 
[01:42:20] 
[01:42:20] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:42:20] Build completed unsuccessfully in 0:35:21
[01:42:20] Build completed unsuccessfully in 0:35:21
[01:42:20] make: *** [check] Error 1
[01:42:20] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:037736f4
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Tue May 21 00:45:50 UTC 2019
---
travis_time:end:098fb560:start=1558399552285861906,finish=1558399552290712170,duration=4850264
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:15c973fa
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0446f916
travis_time:start:0446f916
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:2c9e58ac
$ dmesg | grep -i kill

</details><p></p>

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Zoxc

comment created time in 4 hours

pull request commentrust-lang/rust

syntax: Continue refactoring literals

:umbrella: The latest upstream changes (presumably #60986) made this pull request unmergeable. Please resolve the merge conflicts.

petrochenkov

comment created time in 4 hours

pull request commentrust-lang/rust

Bump compiler-builtins to 0.1.15

cc: error: /cargo/registry/src/github.com-1ecc6299db9ec823/compiler_builtins-0.1.15/compiler-rt/lib/profile/GCDAProfiling.c: No such file or directory

That path isn't valid -- it should be using something under src/llvm-project/ now.

@bors r-

alexcrichton

comment created time in 4 hours

pull request commentrust-lang/rust

Bump LLVM submodule to fix MSP430 AsmPrinter and assembler syntax mismatch.

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

<details><summary><i>Click to expand the log.</i></summary>

Cloning into 'rust-lang/rust'...
travis_time:end:09908b50:start=1558399396066118869,finish=1558399401547924085,duration=5481805216
$ cd rust-lang/rust
$ git checkout -qf 2d7bfa706fd54ba5ce36f9c0ef6c453afc479032
fatal: reference is not a tree: 2d7bfa706fd54ba5ce36f9c0ef6c453afc479032
The command "git checkout -qf 2d7bfa706fd54ba5ce36f9c0ef6c453afc479032" failed and exited with 128 during .
Your build has been stopped.

</details><p></p>

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

cr1901

comment created time in 4 hours

pull request commentrust-lang/rust

Associate an allocator to boxes

:umbrella: The latest upstream changes (presumably #60986) made this pull request unmergeable. Please resolve the merge conflicts.

glandium

comment created time in 4 hours

push eventrust-lang/rust

Taiki Endo

commit sha b53d839b239d8fcf4cddfbd565ce5a8836217d5c

Move arbitrary_self_types's tests into ui/self

view details

Taiki Endo

commit sha 3e73ca6e336650eb0cb8429b3932d63d71c2a476

Move run-pass/self/* to ui/self

view details

Alex Crichton

commit sha 69c632699c3190c2004b6725873d0ea39c59bf83

Bump compiler-builtins to 0.1.15 This commit bumps the `compiler-builtins` dependency to 0.1.15 which expects to have the source for `compiler-rt` provided externally if the `c` feature is enabled. This then plumbs through the necessary support in the build system to ensure that if the `llvm-project` directory is checked out and present that we enable the `c` feature of `compiler-builtins` and compile in all the C intrinsics.

view details

Mazdak Farrokhzad

commit sha 5bc84d273a85169ff8eff4ae74559d7adfa3d208

Rollup merge of #60950 - taiki-e:arbitrary_self_types-tests, r=Centril Move arbitrary self types's tests into ui/self https://github.com/rust-lang/rust/pull/60944#discussion_r285362006 r? @Centril

view details

Mazdak Farrokhzad

commit sha 89f7628f813e165b3debd7d31be6445436e5cf2f

Rollup merge of #60981 - alexcrichton:update-compiler-builtins, r=cuviper Bump compiler-builtins to 0.1.15 This commit bumps the `compiler-builtins` dependency to 0.1.15 which expects to have the source for `compiler-rt` provided externally if the `c` feature is enabled. This then plumbs through the necessary support in the build system to ensure that if the `llvm-project` directory is checked out and present that we enable the `c` feature of `compiler-builtins` and compile in all the C intrinsics.

view details

Mazdak Farrokhzad

commit sha 62afa76a789d76269bfca196e0d2746f5fd2893c

Rollup merge of #60985 - cr1901:msp430-fix, r=alexcrichton Bump LLVM submodule to fix MSP430 AsmPrinter and assembler syntax mismatch. Moving on to steps 9 and 10 of the llvm bugfix [guide](https://rust-lang.github.io/rustc-guide/codegen/updating-llvm.html#bugfix-updates), now that Rust's copy of LLVM was [updated](https://github.com/rust-lang/llvm-project/pull/13). This PR closes issue #59077. Nightlies following this PR should have working msp430 codegen again :D. Thanks for the prompt response even though it took me a while to get this "simple" PR done!

view details

bors

commit sha a2c9ef79ca76c0da27664dafc462f90683370009

Auto merge of #60992 - Centril:rollup-u441n72, r=Centril Rollup of 3 pull requests Successful merges: - #60950 (Move arbitrary self types's tests into ui/self) - #60981 (Bump compiler-builtins to 0.1.15) - #60985 (Bump LLVM submodule to fix MSP430 AsmPrinter and assembler syntax mismatch.) Failed merges: r? @ghost

view details

push time in 4 hours

pull request commentrust-lang/rust

Rollup of 3 pull requests

:hourglass: Testing commit 62afa76a789d76269bfca196e0d2746f5fd2893c with merge a2c9ef79ca76c0da27664dafc462f90683370009... <!-- homu: {"type":"BuildStarted","head_sha":"62afa76a789d76269bfca196e0d2746f5fd2893c","merge_sha":"a2c9ef79ca76c0da27664dafc462f90683370009"} -->

Centril

comment created time in 4 hours

pull request commentrust-lang/rust

Bump LLVM submodule to fix MSP430 AsmPrinter and assembler syntax mismatch.

@bors retry

cr1901

comment created time in 4 hours

pull request commentrust-lang/rust

Bump compiler-builtins to 0.1.15

@bors retry

Not fully sure if spurious or not...

alexcrichton

comment created time in 4 hours

pull request commentrust-lang/rust

Rollup of 3 pull requests

:pushpin: Commit 62afa76a789d76269bfca196e0d2746f5fd2893c has been approved by Centril

<!-- @bors r=Centril 62afa76a789d76269bfca196e0d2746f5fd2893c -->

Centril

comment created time in 4 hours

pull request commentrust-lang/rust

Rollup of 3 pull requests

@bors r+ p=3 rollup=never

Centril

comment created time in 4 hours

push eventrust-lang/rust

William D. Jones

commit sha a775d11fff5f604c09c5ec06c2a82cb8fbef285f

Fix MSP430 AsmPrinter and assembler syntax mismatch.

view details

bors

commit sha 2d7bfa706fd54ba5ce36f9c0ef6c453afc479032

Auto merge of #60985 - cr1901:msp430-fix, r=alexcrichton Bump LLVM submodule to fix MSP430 AsmPrinter and assembler syntax mismatch. Moving on to steps 9 and 10 of the llvm bugfix [guide](https://rust-lang.github.io/rustc-guide/codegen/updating-llvm.html#bugfix-updates), now that Rust's copy of LLVM was [updated](https://github.com/rust-lang/llvm-project/pull/13). This PR closes issue #59077. Nightlies following this PR should have working msp430 codegen again :D. Thanks for the prompt response even though it took me a while to get this "simple" PR done!

view details

push time in 4 hours

pull request commentrust-lang/rust

Bump LLVM submodule to fix MSP430 AsmPrinter and assembler syntax mismatch.

:hourglass: Testing commit a775d11fff5f604c09c5ec06c2a82cb8fbef285f with merge 2d7bfa706fd54ba5ce36f9c0ef6c453afc479032... <!-- homu: {"type":"BuildStarted","head_sha":"a775d11fff5f604c09c5ec06c2a82cb8fbef285f","merge_sha":"2d7bfa706fd54ba5ce36f9c0ef6c453afc479032"} -->

cr1901

comment created time in 4 hours

PR opened rust-lang/rust

Rollup of 3 pull requests

Successful merges:

  • #60950 (Move arbitrary self types's tests into ui/self)
  • #60981 (Bump compiler-builtins to 0.1.15)
  • #60985 (Bump LLVM submodule to fix MSP430 AsmPrinter and assembler syntax mismatch.)

Failed merges:

r? @ghost

+57 -28

0 comment

38 changed files

pr created time in 4 hours

pull request commentrust-lang/rust

Bump compiler-builtins to 0.1.15

The job dist-aarch64-linux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

<details><summary><i>Click to expand the log.</i></summary>

[00:03:49] --- stdout
[00:03:49] TARGET = Some("x86_64-unknown-linux-gnu")
[00:03:49] OPT_LEVEL = Some("2")
[00:03:49] HOST = Some("x86_64-unknown-linux-gnu")
[00:03:49] CC_x86_64-unknown-linux-gnu = Some("sccache cc")
[00:03:49] CFLAGS_x86_64-unknown-linux-gnu = Some("-ffunction-sections -fdata-sections -fPIC -m64")
[00:03:49] CRATE_CC_NO_DEFAULTS = None
[00:03:49] DEBUG = Some("false")
[00:03:49] CARGO_CFG_TARGET_FEATURE = Some("fxsr,mmx,sse,sse2")
[00:03:49] running: "sccache" "cc" "-O2" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-fno-builtin" "-fvisibility=hidden" "-fomit-frame-pointer" "-ffreestanding" "-DVISIBILITY_HIDDEN" "-DCOMPILER_RT_HAS_UNAME=1" "-DCOMPILER_RT_HAS_FCNTL_LCK=1" "-DCOMPILER_RT_HAS_ATOMICS=1" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/x86_64-unknown-linux-gnu/release/build/profiler_builtins-98e28db5f13c3bec/out/GCDAProfiling.o" "-c" "/cargo/registry/src/github.com-1ecc6299db9ec823/compiler_builtins-0.1.15/compiler-rt/lib/profile/GCDAProfiling.c"
[00:03:49] cargo:warning=cc: error: /cargo/registry/src/github.com-1ecc6299db9ec823/compiler_builtins-0.1.15/compiler-rt/lib/profile/GCDAProfiling.c: No such file or directory
[00:03:49] cargo:warning=cc: warning: '-x c' after last input file has no effect
[00:03:49] cargo:warning=cc: fatal error: no input files
[00:03:49] cargo:warning=compilation terminated.
[00:03:49] 
[00:03:49] --- stderr
[00:03:49] thread 'main' panicked at '
[00:03:49] 
[00:03:49] 
[00:03:49] Internal error occurred: Command "sccache" "cc" "-O2" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-fno-builtin" "-fvisibility=hidden" "-fomit-frame-pointer" "-ffreestanding" "-DVISIBILITY_HIDDEN" "-DCOMPILER_RT_HAS_UNAME=1" "-DCOMPILER_RT_HAS_FCNTL_LCK=1" "-DCOMPILER_RT_HAS_ATOMICS=1" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/x86_64-unknown-linux-gnu/release/build/profiler_builtins-98e28db5f13c3bec/out/GCDAProfiling.o" "-c" "/cargo/registry/src/github.com-1ecc6299db9ec823/compiler_builtins-0.1.15/compiler-rt/lib/profile/GCDAProfiling.c" with args "cc" did not execute successfully (status code exit code: 1).
[00:03:49] ', /cargo/registry/src/github.com-1ecc6299db9ec823/cc-1.0.35/src/lib.rs:2398:5
[00:03:49] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[00:03:49] 
[00:03:49] warning: build failed, waiting for other jobs to finish...
---
travis_time:end:342b0232:start=1558399180038769625,finish=1558399180044269164,duration=5499539
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:14539ad5
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:18601eee
travis_time:start:18601eee
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:025cd52a
$ dmesg | grep -i kill

</details><p></p>

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

alexcrichton

comment created time in 4 hours

pull request commentrust-lang/rust

Bump compiler-builtins to 0.1.15

:broken_heart: Test failed - checks-travis <!-- homu: {"type":"BuildFailed","builder_url":"https://travis-ci.com/rust-lang/rust/builds/112527236","builder_name":"checks-travis"} -->

alexcrichton

comment created time in 4 hours

pull request commentrust-lang/rust

WIP: Allocator- and fallibility-polymorphic collections

:umbrella: The latest upstream changes (presumably #60986) made this pull request unmergeable. Please resolve the merge conflicts.

Ericson2314

comment created time in 4 hours

push eventrust-lang/rust

Guillaume Gomez

commit sha 67ca448dac4ccf189e2c708be3f3569b70ee2698

Improve file sidebar in source code view page on mobile

view details

Guillaume Gomez

commit sha 87d1c17683b7911522e3bcc223a308c82702f7d8

Cleanup media queries

view details

Tobias Bucher

commit sha bd8885d340beb20ac1728d0bd7e64321da641b91

Fall back to `/dev/urandom` on `EPERM` for `getrandom` This can happen because of seccomp or some VMs. Fixes #52609.

view details

Guillaume Gomez

commit sha e2a25007beba16caa8653f1f3c35bcb7543d659e

Fix search sidebar width when no crate select is present

view details

Taiki Endo

commit sha ccb9dac5ed65341bf8d9ce01a83b9aad02f42526

Fix intra-doc link resolution failure on re-exporting libstd

view details

Oliver Scherer

commit sha 2adc6da7aa4f3f8cb646b8f7b7759e73c98ade12

Fix incremental compilation of cdylib emitting spurious unused_attributes lint

view details

Oliver Scherer

commit sha e92d13ea2e84586ce17790946ae4241777a9778f

Update ui tests

view details

Michael Woerister

commit sha eed1e1ecd265071dc45abcd331272e6bb1b919d7

Remove unused field from StableHasher.

view details

bjorn3

commit sha cb0039e3b749350fc649f3d19cb964ee798c1ac8

Misc changes to rustc_metadata

view details

David Tolnay

commit sha ea7aa76911b6b896d503a812b26bfd6227fa90d9

Document BinaryHeap time complexity I went into some detail on the time complexity of `push` because it is relevant for using BinaryHeap efficiently -- specifically that you should avoid pushing many elements in ascending order when possible.

view details

Vadim Petrochenkov

commit sha 88fa5c6a45a533a78c698a22f4b16002a3bc9fc3

Improve type size assertions Now they - Tell what the new size is, when it changes - Do not require passing an identifier

view details

Ralf Jung

commit sha b9be68ce2ed75a3801075f66f50200e329211400

remove confusing remarks about mixed volatile and non-volatile accesses

view details

Michael Woerister

commit sha a79c06a9ce1986d3c4dbc27b5e51d60d77befafb

Document requirements for HashStable implementations better.

view details

Petr Hosek

commit sha d8f764bbbf10cdccfde48f0a6b7dfdea157b5568

Set -funwind-tables and -fno-exceptions unconditionally for LLVM's libunwind These are required otherwise libunwind will end up with undefined references to __gxx_personality_v0 which is provided by C++ ABI library and that's undesirable.

view details

Mazdak Farrokhzad

commit sha daf8aca0e3b9566bdd96479b6efae2e93de97bd1

Rollup merge of #60383 - GuillaumeGomez:fix-position-source-code-files-toggle, r=Manishearth Fix position source code files toggle Fixes #60381. The second commit is a big cleanup of the media queries. r? @rust-lang/rustdoc cc @Manishearth screenshot of the fix: <img width="501" alt="Screenshot 2019-04-29 at 23 42 56" src="https://user-images.githubusercontent.com/3050060/56929111-112b2b00-6ad9-11e9-9a23-e0a8e3641395.png">

view details

Mazdak Farrokhzad

commit sha 5a08ca38deb7c363aa5078681b4ea90a6276c931

Rollup merge of #60453 - tbu-:pr_getrandom_enoperm, r=sfackler Fall back to `/dev/urandom` on `EPERM` for `getrandom` This can happen because of seccomp or some VMs. Fixes #52609.

view details

Mazdak Farrokhzad

commit sha bf54251f907c0979f14e955e0b4f3760ccba5317

Rollup merge of #60487 - GuillaumeGomez:fix-search-sidebar-width-colors, r=Dylan-DPC Fix search sidebar width when no crate select is present Fixes #60480. I also fixed the box-shadow that seemed to have been kind of removed? r? @QuietMisdreavus

view details

Mazdak Farrokhzad

commit sha a34dae35874a5b33fb2895dcf15463f7f4bd9af3

Rollup merge of #60511 - taiki-e:libstd-intra-doc, r=Dylan-DPC Fix intra-doc link resolution failure on re-exporting libstd Currently, re-exporting libstd items as below will [occur a lot of failures](https://gist.github.com/taiki-e/e33e0e8631ef47f65a74a3b69f456366). ```rust pub use std::*; ``` Until the underlying issue (#56922) fixed, we can fix that so they don't propagate to downstream crates. Related: https://github.com/rust-lang/rust/pull/56941 (That PR fixed failures that occur when re-exporting from libcore to libstd.) r? @QuietMisdreavus

view details

Mazdak Farrokhzad

commit sha 36b5724e0dd7a328f5065cbf1188e114c2e5a1b3

Rollup merge of #60823 - oli-obk:used_unused_no_mangle, r=michaelwoerister Fix incremental compilation of cdylib emitting spurious unused_attributes lint fixes #60050

view details

Mazdak Farrokhzad

commit sha 3f86faddaf5d6a676167f858e6044ea08809179a

Rollup merge of #60915 - michaelwoerister:hashstablestuff, r=estebank stable hashing: Remove unused field and add documentation. This PR removes the `bytes_hashed` field from `StableHasher` which in the past has been used for collecting some statistics but has gone unused for quite a while (months at least) now. The PR also tries to document some requirements for `HashStable` implementations that haven't been written down explicitly anywhere.

view details

push time in 4 hours

push eventrust-lang/rust

Alex Crichton

commit sha 69c632699c3190c2004b6725873d0ea39c59bf83

Bump compiler-builtins to 0.1.15 This commit bumps the `compiler-builtins` dependency to 0.1.15 which expects to have the source for `compiler-rt` provided externally if the `c` feature is enabled. This then plumbs through the necessary support in the build system to ensure that if the `llvm-project` directory is checked out and present that we enable the `c` feature of `compiler-builtins` and compile in all the C intrinsics.

view details

bors

commit sha 4e4e986f9dc43c199ff1971ddc5d90ecf3c18d1c

Auto merge of #60981 - alexcrichton:update-compiler-builtins, r=cuviper Bump compiler-builtins to 0.1.15 This commit bumps the `compiler-builtins` dependency to 0.1.15 which expects to have the source for `compiler-rt` provided externally if the `c` feature is enabled. This then plumbs through the necessary support in the build system to ensure that if the `llvm-project` directory is checked out and present that we enable the `c` feature of `compiler-builtins` and compile in all the C intrinsics.

view details

push time in 4 hours

more