profile
viewpoint
rubyide rubyide IDE support for ruby

startedrubyide/vscode-ruby

started time in 9 hours

issue commentrubyide/vscode-ruby

breakpoint not being hit in remote debugging

I finally managed to get this working (with some help!) in the end using the insider build of VS code (1.35.0-insider). Set up as follows

{ "name": "Rails server", "type": "Ruby", "request": "launch", "cwd": "${workspaceRoot}", "showDebuggerOutput": true, "program": "${workspaceRoot}/bin/rails", "args": [ "s" ] }

I had to uninstall older versions of debase and ruby-debug-ide and update to the latest beta versions. It now respects breakpoints. Current Version information: Ruby: 2.5.1 Rails: 5.2.0 ruby-debug-ide: (0.7.0.beta7) Debase: 0.2.3.beta5

I did the following:

  1. bundle binstubs ruby-debug-ide
  2. bundle binstubs railties
  3. bundle binstubs bundler --force
jots

comment created time in 11 hours

startedrubyide/vscode-ruby

started time in 20 hours

push eventrubyide/vscode-ruby

Chris Born

commit sha 29aa1bbe9beb57bb3be64a06fa058ce30bc3cf2e

add --force-exclusion flag to reek options Force excluding files specified in the configuration `exclude_paths` even if they are explicitly passed as arguments.

view details

Stafford Brunk

commit sha 7440488865d031e1f637caad2ac3b5efad2b73ef

Merge branch 'master' into reek-force-exclusion

view details

Chris Born

commit sha aed352225dbd674d2f1fb3ab028a365928f0d818

Merge branch 'master' into reek-force-exclusion

view details

Stafford Brunk

commit sha a0602505efe84fef71f2aac5e4b8c20ba2f6dedf

Merge pull request #287 from pelted/reek-force-exclusion add --force-exclusion flag to reek options

view details

push time in 3 days

PR merged rubyide/vscode-ruby

add --force-exclusion flag to reek options

Force excluding files specified in the configuration exclude_paths even if they are explicitly passed as arguments.

Resolves problem with exclude_paths in the .reek config being ignored since we run reek on single files rather than the whole project.

Example that now works after this PR.

exclude_paths:
  - db/migrate

Make sure these boxes are checked before submitting your PR -- thanks in advance!

+1 -1

1 comment

1 changed file

pelted

pr closed time in 3 days

pull request commentrubyide/vscode-ruby

add --force-exclusion flag to reek options

@rubyide Can you consider reviewing/merging/rejecting this PR? I though about submitting one, but PR older than year still waiting for reaction are a bit discouraging.

pelted

comment created time in 3 days

issue openedrubyide/vscode-ruby

broken bracket matching with inline if/unless

Your environment

  • vscode-ruby version: 0.22.3
  • Ruby version: ruby 2.4.6p354 (2019-04-01 revision 67394) [x86_64-linux-gnu]
  • Ruby version manager (if any): none
  • VS Code version: 1.33.1
  • Operating System: Ubuntu 16.04
  • Using language server? I am not aware that I am using one

Expected behavior

Bracket matching works for

if a < b
  next if a == b

  puts a
end

Actual behavior

Selection_003

created time in 3 days

startedrubyide/vscode-ruby

started time in 3 days

issue commentrubyide/vscode-ruby

Received invalid JSON from rubocop

I have a similar issue, currently. The rubocop lint is failing because of a warning that rubocop (the CLI) is creating. All of the mentioned issues have in common, that output to STDERR is created and this results in Lint: Received invalid JSON from rubocop:. If the command would skip STDERR, the warnings would not be interpreted as JSON and parsing would work as expected. (As mentioned here). This does not solve invalid rubocop installations, but it solves every problem that is based on output to STDOUT (warnings, errors, ...).

@wingrunr21 is it possible to publish your local branch, so that somebody with a working local setup can support you?

raywagner88

comment created time in 3 days

issue commentrubyide/vscode-ruby

Sorry, but there is no formatter for 'ruby'-files installed.

@rezamarandi what is the language server logging?

@chioi You have useBundler set to true but rubocop installed globally. The language server logs what it is trying to run.

@minkir014 it has the exact same issues. That extension relies on the user starting VSCode up with the correct environment already loaded.

rezamarandi

comment created time in 5 days

issue commentrubyide/vscode-ruby

Sorry, but there is no formatter for 'ruby'-files installed.

For a temporary solution there's a Rubocop extension which doesn't' have these problems. https://marketplace.visualstudio.com/items?itemName=misogi.ruby-rubocop

rezamarandi

comment created time in 5 days

issue commentrubyide/vscode-ruby

Sorry, but there is no formatter for 'ruby'-files installed.

Same issue here

Enviroment

  • vscode-ruby version: 0.22.3
  • ruby version: ruby 2.6.3p62 (2019-04-16 revision 67580) [x86_64-darwin18]
  • rvm
  • macOS Mojave version 10.14.4
  • Visual Studio Code version 1.33.1

VSC config

{
   "ruby.format": "rubocop",
    "ruby.codeCompletion": "rcodetools",
    "ruby.intellisense": "rubyLocate",
    "ruby.lint": {
        "rubocop": true,
        "ruby": true
    },
    "editor.formatOnSave": true,
    "editor.formatOnPaste": true,
    "editor.formatOnSaveTimeout": 1500,
    "ruby.useBundler": true,
    "ruby.useLanguageServer": true,
}
$ gem list | grep rubocop
rubocop (0.69.0)
rezamarandi

comment created time in 5 days

issue commentrubyide/vscode-ruby

RuboCop crashes the language server when linting large files or files with a lot of errors

This is also happening to me. I'm hitting the following on a file that is 228 lines long that has about 22 errors:

Lint: executing rubocop -s /Users/username/project/lorem.rb -f json...
events.js:167
      throw er; // Unhandled 'error' event
      ^

Error: write EPIPE
    at WriteWrap.afterWrite [as oncomplete] (net.js:833:14)
Emitted 'error' event at:
    at onwriteError (_stream_writable.js:431:12)
    at onwrite (_stream_writable.js:456:5)
    at _destroy (internal/streams/destroy.js:40:7)
    at Socket._destroy (net.js:603:3)
    at Socket.destroy (internal/streams/destroy.js:32:8)
    at WriteWrap.afterWrite [as oncomplete] (net.js:835:10)
[Info  - 3:24:39 PM] Connection to server got closed. Server will restart.
[Error - 3:24:39 PM] Request textDocument/foldingRange failed.
Error: Connection got disposed.
	at Object.dispose (/Users/username/.vscode/extensions/rebornix.ruby-0.22.3/client/node_modules/vscode-jsonrpc/lib/main.js:876:25)
	at Object.dispose (/Users/username/.vscode/extensions/rebornix.ruby-0.22.3/client/node_modules/vscode-languageclient/lib/client.js:71:35)
	at LanguageClient.handleConnectionClosed (/Users/username/.vscode/extensions/rebornix.ruby-0.22.3/client/node_modules/vscode-languageclient/lib/client.js:2153:42)
	at LanguageClient.handleConnectionClosed (/Users/username/.vscode/extensions/rebornix.ruby-0.22.3/client/node_modules/vscode-languageclient/lib/main.js:151:15)
	at closeHandler (/Users/username/.vscode/extensions/rebornix.ruby-0.22.3/client/node_modules/vscode-languageclient/lib/client.js:2140:18)
	at CallbackList.invoke (/Users/username/.vscode/extensions/rebornix.ruby-0.22.3/client/node_modules/vscode-jsonrpc/lib/events.js:62:39)
	at Emitter.fire (/Users/username/.vscode/extensions/rebornix.ruby-0.22.3/client/node_modules/vscode-jsonrpc/lib/events.js:120:36)
	at closeHandler (/Users/username/.vscode/extensions/rebornix.ruby-0.22.3/client/node_modules/vscode-jsonrpc/lib/main.js:226:26)
	at CallbackList.invoke (/Users/username/.vscode/extensions/rebornix.ruby-0.22.3/client/node_modules/vscode-jsonrpc/lib/events.js:62:39)
	at Emitter.fire (/Users/username/.vscode/extensions/rebornix.ruby-0.22.3/client/node_modules/vscode-jsonrpc/lib/events.js:120:36)
	at IPCMessageReader.fireClose (/Users/username/.vscode/extensions/rebornix.ruby-0.22.3/client/node_modules/vscode-jsonrpc/lib/messageReader.js:111:27)
	at ChildProcess.constructor.eventEmitter.on (/Users/username/.vscode/extensions/rebornix.ruby-0.22.3/client/node_modules/vscode-jsonrpc/lib/messageReader.js:213:45)
	at ChildProcess.emit (events.js:187:15)
	at maybeClose (internal/child_process.js:961:16)
	at Socket.ChildProcess.spawn.stream.socket.on (internal/child_process.js:380:11)
	at Socket.emit (events.js:182:13)
	at Pipe.Socket._destroy._handle.close [as _onclose] (net.js:596:12)
[Info  - 3:24:39 PM] Initializing Ruby language server...
[Info  - 3:24:39 PM] Rebuilding tree-sitter for local Electron version
[Info  - 3:24:39 PM] Rebuild succeeded!

vscode-ruby version: 0.22.3 Ruby version: 2.3.3p222 Ruby version manager (if any): rvm 1.29.3 VS Code version: 1.33.1 Operating System: Max OS X 10.14.2 (18C54) Using language server? Yes

shir

comment created time in 5 days

issue commentrubyide/vscode-ruby

[Proposal] implement a TaskProvider for running tests

Or you may create that task yourself. It's not hard.

doudou

comment created time in 6 days

issue commentrubyide/vscode-ruby

[Proposal] implement a TaskProvider for running tests

I created a Ruby Test Explorer that seems relevant to this issue: https://marketplace.visualstudio.com/items?itemName=connorshea.vscode-ruby-test-adapter

doudou

comment created time in 6 days

issue commentrubyide/vscode-ruby

Symbol strings (ex. :abc) via "Remote - SSH" are not correctly highlighted

No but that's what I'm trying to determine what the problem is. Does another theme give you correct highlighting?

The Remote SSH environment isn't stable yet and this extension doesn't explicitly support it. Theming is a core VSCode function as well. The grammar is supplying and matching a TM Scope but the theme doesn't have a matching style.

danglduy

comment created time in 7 days

issue commentrubyide/vscode-ruby

Symbol strings (ex. :abc) via "Remote - SSH" are not correctly highlighted

@wingrunr Have you tried using in “Remote SSH” environment? I get highlighted normally in local environment.

danglduy

comment created time in 7 days

startedrubyide/vscode-ruby

started time in 7 days

issue commentrubyide/vscode-ruby

Symbol strings (ex. :abc) via "Remote - SSH" are not correctly highlighted

interesting. I also use Dark+ and I get those keywords highlighted in blue. Do you get highlighting with a different theme?

danglduy

comment created time in 7 days

issue commentrubyide/vscode-ruby

Debugging not working with ruby on rails

Don't know how to do that. What's your config file in VSCode? Is there a command to give the -d parameter to the spawned debugger?

Sorry, I'm not familiar with this setup :\

MicMicMon

comment created time in 7 days

issue commentrubyide/vscode-ruby

Debugging not working with ruby on rails

Run rdebug-ide-d commnd and set a breakpoints. So you must see it in the terminal that it will break in the line number.

MicMicMon

comment created time in 7 days

issue commentrubyide/vscode-ruby

Debugging not working with ruby on rails

Thanks for your help @jonmchan Unfortunately, disabling bootsnap and multiple workers didn't help. Debugger still stops the process, but VSCode does not jump to the line, showing context (I can just see the other threads running).

Didn't understand your rdebug-ide -d, could you elaborate?

What versions of ruby, ruby-debug-ide and debase do you use?

MicMicMon

comment created time in 7 days

startedrubyide/vscode-ruby

started time in 7 days

startedrubyide/vscode-ruby

started time in 7 days

startedrubyide/vscode-ruby

started time in 7 days

issue commentrubyide/vscode-ruby

Rubocop warnings with zero length do not show up in editor

@wingrunr21 Sorry, I did not mean to put you under pressure. Thank you for your effort!

trkoch

comment created time in 7 days

pull request commentrubyide/vscode-ruby

Node Runtime

there's going to be some additional work required to fully support remote environments

@wingrunr21 let me know if you need any information from me for the remote support.

rebornix

comment created time in 8 days

issue commentrubyide/vscode-ruby

Symbol strings (ex. :abc) via "Remote - SSH" are not correctly highlighted

@wingrunr21 I am using the default theme.

danglduy

comment created time in 8 days

issue commentrubyide/vscode-ruby

Symbol strings (ex. :abc) via "Remote - SSH" are not correctly highlighted

Ok. What theme are you using? The Ruby grammar is correctly matching the TM scopes but it appears your theme does not have support.

danglduy

comment created time in 8 days

issue commentrubyide/vscode-ruby

Symbol strings (ex. :abc) via "Remote - SSH" are not correctly highlighted

@wingrunr21 I inspected with: and :exception image image

danglduy

comment created time in 8 days

pull request commentrubyide/vscode-ruby

Path manipulation using correct OS path class

@hnioche thank you for your work. I'll take a look at this soon!

hnioche

comment created time in 8 days

pull request commentrubyide/vscode-ruby

Node Runtime

I took a look at this over the weekend. I'll merge this and cut a release so as to at least prevent the crash, but there's going to be some additional work required to fully support remote environments.

rebornix

comment created time in 8 days

issue commentrubyide/vscode-ruby

Symbol strings (ex. :abc) via "Remote - SSH" are not correctly highlighted

hi @danglduy

Can you use the Developer: Inspect TM Scopes tool to tell me what scopes are being matched for the with: :exception part of that code?

The with: should be matching the grammar with a scope of constant.language.symbol.hashkey.ruby and :exception should be constant.language.symbole.ruby.

danglduy

comment created time in 8 days

issue commentrubyide/vscode-ruby

Symbol strings (ex. :abc) via "Remote - SSH" are not correctly highlighted

@minkir014 "Remote - SSH" extension does only work on VS Code Insider I'm afraid.

danglduy

comment created time in 8 days

issue commentrubyide/vscode-ruby

Symbol strings (ex. :abc) via "Remote - SSH" are not correctly highlighted

Have you tried that on an ordinary vs code?

danglduy

comment created time in 8 days

issue commentrubyide/vscode-ruby

Symbol strings (ex. :abc) via "Remote - SSH" are not correctly highlighted

I think these are not the same problems. Ruby symbols are correctly highlighted without any language servers anyway.

danglduy

comment created time in 8 days

pull request commentrubyide/vscode-ruby

Path manipulation using correct OS path class

Please, provide your launch.json I knew what is the problem in it (launch.json) but I want to be sure. Please provide it to see if there is another problem we can solve.

hnioche

comment created time in 8 days

pull request commentrubyide/vscode-ruby

Path manipulation using correct OS path class

I don't think this is the appropriate spot to try to solve it. I actually got the breakpoints to catch by disabling byebug temporarily but now I can't access the thread that has the breakpoints in it to debug window, so I can't see the variables etc. Googling around I found others with the same issue, I think it has to do with child processes; there is an issue in the tracker that talks about something very similar. The app is also on Rails 5.1.1 which a closed bug also blamed for a similar sounding issue, but migrating it is out of the question for me.

Point is, though I am still having some issues, this PR clearly does what it is supposed to do and fixed my windows path issue! I won't be able to work on this for a few days anyway. When I do I may just try a command line debugger; my needs are actually pretty simple.

On Sun, May 12, 2019, 21:30 minkir014 notifications@github.com wrote:

@DavidGriswoldTeacher https://github.com/DavidGriswoldTeacher Could you post your launch.json to see where is the problem?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rubyide/vscode-ruby/pull/477#issuecomment-491642221, or mute the thread https://github.com/notifications/unsubscribe-auth/ALWSINWZRCLOPMVMVI4AYQTPVCZBHANCNFSM4HLTU6CQ .

hnioche

comment created time in 8 days

issue commentrubyide/vscode-ruby

Debugger stops at breakpoint but doesn't see any variables

This issue is closed, I know, but I am also having this same problem on Rails 5.1.1 . Unfortunately, I am simply working on fixing something in an open-source app and have no ability to migrate to rails 5.2 (an initial attempt failed miserably).

For me I'm trying to debug into a docker container, which obviously adds another wrinkle, but this bug report very closely matches my own result. It stops at my breakpoint, but I can't actually see anything and the Call stack shows 8 "running" threads and nothing else.

nonsenseless

comment created time in 8 days

pull request commentrubyide/vscode-ruby

Path manipulation using correct OS path class

@DavidGriswoldTeacher Could you post your launch.json to see where is the problem?

hnioche

comment created time in 8 days

pull request commentrubyide/vscode-ruby

Path manipulation using correct OS path class

I was just banging my head against the wall with this same problem. New ruby-on-rails developer, rolled a docker service to run the app, configured the IDE, but then it seemed to ignore my RemoteWorkspaceRoot. I could see the "C:\Users..." path whenever I added a breakpoint. I just ran this version in testing, and can confirm that it now correctly converts my Windows paths to POSIX paths in the console.

I am still having issues getting breakpoints to catch as of now, but I'm guessing it's another setting somewhere since I'm very new to this. At the very least, the path conversion seems fixed in this version.

hnioche

comment created time in 8 days

issue commentrubyide/vscode-ruby

Symbol strings (ex. :abc) via "Remote - SSH" are not correctly highlighted

I assume this is the same problem as https://github.com/microsoft/vscode-remote-release/issues/153

danglduy

comment created time in 8 days

issue openedrubyide/vscode-ruby

Symbol strings (ex. :abc) via "Remote - SSH" are not correctly highlighted

Your environment

  • vscode-ruby version: 0.22.3
  • Ruby version: 2.6.3
  • Ruby version manager (if any): rbenv
  • VS Code version: 1.34.10-insider
  • Operating System: Windows
  • Using language server? Solargraph
  • Using via "Remote - SSH" remote environment

Expected behavior

Symbol strings syntax is correctly highlighted

Actual behavior

Symbol strings syntax is incorrectly highlighted

In the picture below :exception should be highlighted image

created time in 9 days

startedrubyide/vscode-ruby

started time in 9 days

issue commentrubyide/vscode-ruby

Block comment folds pop open when I start editing

@wingrunr21 you might find a solution in solograph extension as this issue doesn't exist there and compare your code to his and @Hurbo if this bothers you much you could use solograph for intellisense and this for debugging.

Hubro

comment created time in 9 days

issue commentrubyide/vscode-ruby

Debugging not working with ruby on rails

Thanks for you help @jonmchan.

MicMicMon

comment created time in 9 days

startedrubyide/vscode-ruby

started time in 9 days

issue commentrubyide/vscode-ruby

Debugging not working with ruby on rails

For everyone's info, there is a bug with the debugger and rails5. The gem bootsnap causes the breakpoints to not work (see https://youtrack.jetbrains.com/issue/RUBY-20684). If you can get the VSCode debugger to start and properly connect to the rdebug-ide process (you can run rdebug-ide -d to help verify this), then there isn't any issue with VSCode Ruby extension. The trick lies in fixing the debugger.

When you have -d running, set a breakpoint and verify that rdebug-ide is receiving it properly. You'll see the following immediately when you startup if the breakpoint is set before you launch:

75: Starting control thread
75: Processing in control: break /usr/src/app/config/application.rb:11

I have setup a RAILS_DEBUG mode that disables a lot of these optimizations to get the debugger working. Good luck for everyone else trying to get this working!

MicMicMon

comment created time in 9 days

issue commentrubyide/vscode-ruby

Launch and attach?

Here's my working example using docker-compose. Note the ${relativeFile} is very useful for the remote file.

tasks.json

{
    // See https://go.microsoft.com/fwlink/?LinkId=733558
    // for the documentation about the tasks.json format
    "version": "2.0.0",
    "tasks": [
        {
            "label": "start-debug",
            "command": "/usr/local/bin/docker-compose",
            "args": [
                "exec",
                "app",
                "bash",
                "-c",
                "RUBYLIB=\"\" rdebug-ide --port 1234 --host 0.0.0.0 --dispatcher-port 26162 -- /usr/local/bin/bundle exec rspec ${relativeFile}"
            ],
            "isBackground": true,
            "presentation": {
                "panel": "new"
            },
            "problemMatcher": {
                "owner": "custom",
                "pattern": {
                    "regexp": "____"
                },
                "background": {
                    "activeOnStart": true,
                    "beginsPattern": "____",
                    "endsPattern": "Fast Debugger"
                }
            }
        }
    ]
}

launch.json

{
    // Use IntelliSense to learn about possible attributes.
    // Hover to view descriptions of existing attributes.
    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Docker RSpec Debug",
            "type": "Ruby",
            "request": "attach",
            "remoteHost": "127.0.0.1",
            "remotePort": "1234",
            "remoteWorkspaceRoot": "/usr/src/app",
            "showDebuggerOutput": true,
            "cwd": "${workspaceRoot}",
            "preLaunchTask": "start-debug"
        }
    ]
}
thomthom

comment created time in 10 days

issue commentrubyide/vscode-ruby

Block comment folds pop open when I start editing

If I understood right it doesn't open them when you write but when you use snippets.

Incorrect, I'm simply typing the method name when they all pop open. It also doesn't necessarily open at the same time every time, some of the tests I got to end before they popped open. It seems quite unpredictable.

Hubro

comment created time in 10 days

issue commentrubyide/vscode-ruby

Block comment folds pop open when I start editing

If I understood right it doesn't open them when you write but when you use snippets.

Hubro

comment created time in 10 days

issue commentrubyide/vscode-ruby

Block comment folds pop open when I start editing

Awesome, thanks so much

Hubro

comment created time in 10 days

issue commentrubyide/vscode-ruby

Block comment folds pop open when I start editing

Thanks for the report. Would you be able to attach a sample Ruby file here for me?

Sure, here's the one I used:

test.rb

# Lorem ipsum dolor sit amet, consectetur adipiscing elit
#
# Pellentesque volutpat arcu id nulla egestas, eget cursus tellus sagittis. Proin pellentesque suscipit tortor, sit
# amet vulputate erat pretium id. Cras eleifend lobortis lectus quis dignissim. Aenean pellentesque posuere orci, id
# venenatis risus consectetur finibus. Quisque sollicitudin porttitor ipsum, a pretium massa luctus sit amet. Aenean
# tincidunt vitae nisi eu porta. Sed semper sapien a ipsum blandit sagittis. Phasellus tempus ex quis lorem varius, in
# blandit nisi suscipit. Aliquam gravida condimentum sagittis. In ultricies ante sit amet nibh consectetur tempus. Ut
# finibus, ligula vitae gravida facilisis, tellus orci tincidunt lectus, et placerat ante nisi vitae nisl.
#
module Foo
  # Pellentesque pretium mauris non nisi fermentum, et suscipit turpis fringilla
  #
  # Quisque in dolor ut justo molestie cursus sit amet et augue. Maecenas et auctor tellus. Ut laoreet turpis sapien,
  # non pellentesque quam congue sit amet. Sed risus est, tincidunt at congue vitae, viverra ut odio. Nam nibh elit,
  # feugiat eu gravida ut, molestie et purus. Suspendisse mollis mauris iaculis nibh vehicula, sed volutpat nulla
  # aliquam. Nulla quis arcu orci. Maecenas sed dolor et tortor sagittis euismod. Donec mi ante, porta sollicitudin
  # elementum quis, consequat semper enim. Ut porta convallis egestas.
  #
  def bar
    # ...
  end

  # Morbi felis massa, rhoncus et congue sit amet, ullamcorper id nibh
  #
  # Nam a augue ac justo cursus accumsan. Aliquam eget gravida nibh, non efficitur mi. Fusce tristique condimentum
  # ligula, ut ornare orci ullamcorper non. Duis et sagittis nulla. Aenean at eros a leo pharetra congue sed id elit.
  # Integer vel ipsum eget lorem laoreet venenatis commodo quis lacus.
  #
  def cow
    # ...
  end

  # Cras at pellentesque risus, dictum elementum mauris
  #
  # Maecenas id sem rhoncus lectus consequat accumsan non sed
  # dolor. Fusce imperdiet egestas arcu, vel scelerisque nisl lobortis ut. Proin sit amet tincidunt augue, id facilisis
  # augue. Praesent dignissim, purus vel viverra lacinia, ante lacus finibus nisl, in condimentum ligula felis sed elit.
  # Nulla non arcu vitae nunc pharetra varius venenatis vel sapien. Phasellus ex quam, commodo fringilla vehicula nec,
  # gravida ut ex. Nullam pharetra posuere justo, ut aliquam ante pharetra at. Nulla enim sapien, rhoncus suscipit quam
  # eget, bibendum posuere risus. Aliquam aliquam commodo neque, eu euismod ligula laoreet ut.
  #
  def pop
    # ...
  end
end
Hubro

comment created time in 10 days

issue commentrubyide/vscode-ruby

Block comment folds pop open when I start editing

Thanks for the report. Would you be able to attach a sample Ruby file here for me?

Hubro

comment created time in 10 days

issue openedrubyide/vscode-ruby

Block comment folds pop open when I start editing

Your environment

  • vscode-ruby version: 0.22.3
  • Ruby version: 2.6.2p47
  • Ruby version manager (if any): rvm
  • VS Code version: 1.33.1
  • Operating System: Arch Linux
  • Using language server? Yes, Solargraph 0.19.6 (gem version 0.32.2)

Expected behavior

All closed folds should stay closed until I open them

Actual behavior

When I start editing code, randomly all my block comment folds will pop open.

Example:

Peek 2019-05-10 19-03

created time in 10 days

push eventrubyide/vscode-ruby

Franklin Yu

commit sha 710a98bd5c574dde01cdb8db4ea37972fc86655e

Fix link in README

view details

Stafford Brunk

commit sha 7018ffe27cb5e80ffa023864504816ac684ab8c0

Merge pull request #463 from FranklinYu/doc/readme Fix link in README

view details

push time in 10 days

PR merged rubyide/vscode-ruby

Fix link in README

Description of change and why it was needed here

  • [ ] The build passes (N/A)
  • [ ] TSLint is mostly happy (N/A)
  • [ ] Prettier has been run (N/A)

RubyForge has been shut down for years. See Wikipedia for details.

+1 -1

0 comment

1 changed file

FranklinYu

pr closed time in 10 days

push eventrubyide/vscode-ruby

Brian Buchalter

commit sha aa8590770daa4b95a21cfd727836a53c49fc8cd0

README update for viewing language server output This wasn't obvious to me, so I thought it would help others.

view details

Stafford Brunk

commit sha 1fa4a01b4a73392858a9abb5078884519e71fa76

Merge pull request #471 from bbuchalter/patch-1 README update for viewing language server output

view details

push time in 10 days

PR merged rubyide/vscode-ruby

README update for viewing language server output

This wasn't obvious to me, so I thought it would help others.

Would a screenshot be welcome? Screen Shot 2019-04-25 at 3 39 56 AM

  • [] The build passes
  • [] TSLint is mostly happy
  • [] Prettier has been run
+1 -1

0 comment

1 changed file

bbuchalter

pr closed time in 10 days

push eventrubyide/vscode-ruby

Rowan James

commit sha d6157f955d1e43095fb8824cb10550222b805db9

Update extension recommendations eg2.tslint has been deprecated in favour of Microsoft's `ms-vscode-vscode-typescript-tslint-pugin`

view details

Stafford Brunk

commit sha 83330698cb3ed3d69d5f7f1b5a0a7fe97c038397

Merge pull request #481 from rowanj/extension-recommends Update extension recommendations

view details

push time in 10 days

PR merged rubyide/vscode-ruby

Update extension recommendations

eg2.tslint has been deprecated in favour of Microsoft's ms-vscode-vscode-typescript-tslint-pugin

  • [] The build passes
  • [] TSLint is mostly happy
  • [] Prettier has been run
+1 -1

0 comment

1 changed file

rowanj

pr closed time in 10 days

pull request commentrubyide/vscode-ruby

Node Runtime

I'll look at this tomorrow probably. I'll need to have a new version cut in tree-sitter-ruby first though as the prebuilt binaries won't be there until there's a new version (independent of the PR).

rebornix

comment created time in 10 days

startedrubyide/vscode-ruby

started time in 10 days

PR opened rubyide/vscode-ruby

Update extension recommendations

eg2.tslint has been deprecated in favour of Microsoft's ms-vscode-vscode-typescript-tslint-pugin

+1 -1

0 comment

1 changed file

pr created time in 11 days

fork rowanj/vscode-ruby

Provides Ruby language and debugging support for Visual Studio Code

https://marketplace.visualstudio.com/items?itemName=rebornix.Ruby

fork in 11 days

PR opened rubyide/vscode-ruby

Node Runtime
+36 -18

0 comment

5 changed files

pr created time in 11 days

create barnchrubyide/vscode-ruby

branch : rebornix/nodeRuntime

created branch time in 11 days

issue commentrubyide/vscode-ruby

Rubocop warnings with zero length do not show up in editor

See this extension. It doesn't run into the issues here maybe you could compare your code to its code. https://github.com/misogi/vscode-ruby-rubocop

trkoch

comment created time in 11 days

issue commentrubyide/vscode-ruby

Rubocop warnings with zero length do not show up in editor

I'm troubleshooting a variety of RuboCop related errors. This will be looked at but there are A) more pressing bugs and B) I have limited time right now to spend on this. In addition, I'm trying to get a test suite/harness set up to allow easier community contribution. It'll get done but I've got a full time job + other life obligations.

trkoch

comment created time in 12 days

issue closedrubyide/vscode-ruby

Support for prettier

I want to use https://github.com/prettier/plugin-ruby to format ruby files. It would be great to have support for it.

closed time in 12 days

krzychukula

issue commentrubyide/vscode-ruby

Support for prettier

This will not be supported here. Prettier already has a VSCode extension that supports this.

krzychukula

comment created time in 12 days

issue openedrubyide/vscode-ruby

Support for prettier

I want to use https://github.com/prettier/plugin-ruby to format ruby files. It would be great to have support for it.

created time in 12 days

pull request commentrubyide/vscode-ruby

Path manipulation using correct OS path class

OK. very good. so, this pull request didn't run into any problems. Thanks for your help, @hnioche and nice work.

hnioche

comment created time in 12 days

pull request commentrubyide/vscode-ruby

Path manipulation using correct OS path class

Very good. What about OSX?

I don't have any Apple device to test with

hnioche

comment created time in 12 days

pull request commentrubyide/vscode-ruby

Path manipulation using correct OS path class

Very good. What about OSX?

hnioche

comment created time in 12 days

pull request commentrubyide/vscode-ruby

Path manipulation using correct OS path class

The last thing Have you tried to run a project on Linux and vs code on another Linux.

Yes, I've tried Windows to Windows, Windows to Linux, Linux to Windows and Linux to Linux.

hnioche

comment created time in 12 days

pull request commentrubyide/vscode-ruby

Path manipulation using correct OS path class

The last thing Have you tried to run a project and vs code on another Linux.

hnioche

comment created time in 12 days

startedrubyide/vscode-ruby

started time in 12 days

pull request commentrubyide/vscode-ruby

Path manipulation using correct OS path class

I've applied the last changes. Now, the remote workspace default to the local one if not defined.

I've also cleaned up a few things (missing semicolon and run Prettier on my changes).

I've tested those last changes again between VSCode running on Windows and Linux against a debugger running on Windows and Linux, all the combinations are working properly.

hnioche

comment created time in 12 days

issue commentrubyide/vscode-ruby

Rubocop warnings with zero length do not show up in editor

Any news? Can I help?

trkoch

comment created time in 12 days

PR closed rubyide/vscode-ruby

Develop

Default remote workspace to local workspace Run prettier on the changes

  • [x] The build passes
  • [x] TSLint is mostly happy
  • [x] Prettier has been run
+43 -16

0 comment

1 changed file

hnioche

pr closed time in 12 days

PR opened rubyide/vscode-ruby

Develop

Default remote workspace to local workspace Run prettier on the changes

  • [x] The build passes
  • [x] TSLint is mostly happy
  • [x] Prettier has been run
+43 -16

0 comment

1 changed file

pr created time in 12 days

startedrubyide/vscode-ruby

started time in 12 days

pull request commentrubyide/vscode-ruby

Path manipulation using correct OS path class

No, there isn't. Nice work.

hnioche

comment created time in 12 days

pull request commentrubyide/vscode-ruby

Path manipulation using correct OS path class

I'm done for the day 🙂 I'll default remote cwd to the local workspace if not defined tomorrow, and i would be done with my changes. Any other thing I should change?

hnioche

comment created time in 12 days

pull request commentrubyide/vscode-ruby

Path manipulation using correct OS path class

Have you crashed into any problems?

hnioche

comment created time in 12 days

pull request commentrubyide/vscode-ruby

Path manipulation using correct OS path class

We can set cwd to {workspaceroot} I think this will work.

hnioche

comment created time in 12 days

pull request commentrubyide/vscode-ruby

Path manipulation using correct OS path class

Try a helloworld app but we want to make sure that there isn't any issues with this.

I found time to test other scenarios. windows attached to windows worked out of the box.

I found a bug when attaching from Linux to Windows which is now fixed.

So attaching VSCode from either Windows or Linux to a debugger running in either Windows or Linux works

The only scenario I'm not sure of is if we should always expect to have a remote CWD when the debugger mode is not launch, which I don't think make sense.

hnioche

comment created time in 12 days

pull request commentrubyide/vscode-ruby

Path manipulation using correct OS path class

I'll wait news from you tomorrow.

hnioche

comment created time in 12 days

pull request commentrubyide/vscode-ruby

Path manipulation using correct OS path class

Try a helloworld app but we want to make sure that there isn't any issues with this.

Make sense, I won't have time right now, I'll update you tomorrow on this

hnioche

comment created time in 12 days

pull request commentrubyide/vscode-ruby

Path manipulation using correct OS path class

Try a helloworld app but we want to make sure that there isn't any issues with this.

hnioche

comment created time in 12 days

pull request commentrubyide/vscode-ruby

Path manipulation using correct OS path class

Have you tried to make the project running on windows and vscode running on Linux?

No, the ruby app is a pain to run on Windows, I'll see if I can test with a sample app

hnioche

comment created time in 12 days

pull request commentrubyide/vscode-ruby

Path manipulation using correct OS path class

https://github.com/rubyide/vscode-ruby/pull/477#issuecomment-490591579

hnioche

comment created time in 12 days

pull request commentrubyide/vscode-ruby

Path manipulation using correct OS path class

Have you tried to make the project running on windows and vscode running on Linux?

hnioche

comment created time in 12 days

pull request commentrubyide/vscode-ruby

Path manipulation using correct OS path class

Please tell me the news because if that worked I'll change my ruby extension source code.

It does work in both scenarios yes, either having a Windows or Linux running vscode and the ruby debugger running on Linux

hnioche

comment created time in 12 days

pull request commentrubyide/vscode-ruby

Path manipulation using correct OS path class

Please tell me the news because if that worked I'll change my ruby extension source code.

hnioche

comment created time in 12 days

pull request commentrubyide/vscode-ruby

Path manipulation using correct OS path class

Did it work successfully with you? I mean you can now remote debug a project on Linux from vscode on windows.

Yes, I can attach VSCode to the ruby-debug-ide instance in docker, and breakpoints are working now. I haven't tested all scenarios though, I'm gonna test Linux to Docker to make sure I didn't break this part

hnioche

comment created time in 12 days

pull request commentrubyide/vscode-ruby

Path manipulation using correct OS path class

Did it work successfully with you? I mean you can now remote debug a project on Linux from vscode on windows.

hnioche

comment created time in 12 days

more