profile
viewpoint
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentedgexfoundry/app-functions-sdk-go

fix: http trigger response can set content-type

 func (f Conversion) TransformToJSON(edgexcontext *appcontext.Context, params ... 			// LoggingClient.Error(fmt.Sprintf("Error parsing JSON. Error: %s", err.Error())) 			return false, errors.New("Error marshalling JSON") 		}+		edgexcontext.ResponseContentType = "application/json"

You use clients.ContentTypeJSON in the test, why not use it here? Perhaps a constant should be added for XML as well?

beaufrusetta

comment created time in 12 hours

Pull request review commentedgexfoundry/app-functions-sdk-go

fix: http trigger response can set content-type

 type Context struct { 	RetryData []byte 	// SecretProvider exposes the support for getting and storing secrets 	SecretProvider security.SecretProvider+	// ResponseContentType sets a custom response type

Perhaps something like: // ResponseContentType is used for holding custom response type for HTTP Trigger.

beaufrusetta

comment created time in 12 hours

PullRequestReviewEvent
PullRequestReviewEvent

push eventrsdmike/rpc

Mike

commit sha 859d0d788c18747c908dad1a8ce0850aa1a81cc3

Update build.yml

view details

push time in 5 days

push eventrsdmike/rpc

Mike

commit sha 824d47ebf80c1fe9b3fc26a3a2dfd245fc61d080

ci: pipeline Signed-off-by: Mike <michael.johanson@intel.com>

view details

push time in 5 days

fork rsdmike/rpc

Remote Provisioning Client

fork in 5 days

push eventrsdmike/rpc

Mike

commit sha 85a8ed79c1e637acbd898f923bc926459905137f

Update cmake.yml

view details

push time in 5 days

push eventrsdmike/rpc

Mike

commit sha e3c234cd757df46940178dd0c789fb566da581c2

Update cmake.yml

view details

push time in 5 days

push eventrsdmike/rpc

Mike

commit sha 1b3a6e52f6999a0def7191a4cd3db2534d1bb1ee

Update cmake.yml

view details

push time in 5 days

push eventrsdmike/rpc

Mike

commit sha ddf042b4517940a183336b0565d18be38dba7fa6

Update cmake.yml

view details

push time in 5 days

push eventrsdmike/rpc

Mike

commit sha 34645efa388b4166e333d8ef2998e955a35d77f7

Update cmake.yml

view details

push time in 5 days

push eventrsdmike/rpc

Mike

commit sha bbee671fdb286223426b8abaa95f4226f9680a2f

Update cmake.yml

view details

push time in 5 days

push eventrsdmike/rpc

Mike

commit sha 0120db28969e1b486e84cb3551c34bcfe1dbd3cf

Update cmake.yml

view details

push time in 5 days

push eventrsdmike/rpc

Mike

commit sha 4d74d963338f9692e7462e5c30b85bb50ac93868

Update cmake.yml

view details

push time in 5 days

push eventrsdmike/rpc

Mike

commit sha 3fbf2d52a8dcc02734dbca48ce67c98ab51dc372

Update cmake.yml

view details

push time in 5 days

push eventrsdmike/rpc

Mike

commit sha 2d605d4a9f5b6ff6d9dd49e5efff31dd0b292a99

Update cmake.yml

view details

push time in 5 days

push eventrsdmike/rpc

Mike

commit sha a081e1c93603cbd78195c4f05a2f00a419e1fa67

Update cmake.yml

view details

push time in 5 days

push eventrsdmike/rpc

Mike

commit sha 143cb54ba3ab4e92412b2886536a57798aca1087

Update cmake.yml

view details

push time in 5 days

push eventrsdmike/rpc

Mike

commit sha 64b4b6eb0418f7ffee6216ec19292d0350052b94

Update cmake.yml

view details

push time in 5 days

push eventrsdmike/rpc

Mike

commit sha 90d3e9801a1512db3f93dcdeceddadd99f474136

Update cmake.yml

view details

push time in 6 days

push eventrsdmike/rpc

Mike

commit sha d11201a32fa6efd83c4c62d2b559beb2a3f2025d

Update cmake.yml

view details

push time in 6 days

push eventrsdmike/mps

Mike

commit sha bea0e6e0cae09cae38cac22483c6f12e528c8d07

Create azure.yml

view details

push time in 6 days

push eventrsdmike/rpc

Mike

commit sha 7da14560dd515eae56c158af7465a04de50c6f04

Update cmake.yml

view details

push time in 6 days

push eventrsdmike/rpc

Mike

commit sha e9a1f1c97fe1cd03b898f8bf79dc2816b5f1b936

Update cmake.yml

view details

push time in 6 days

push eventrsdmike/rpc

Mike

commit sha 241bba4b1d75f1cf2e6fb5f8306b4bb34d5586d4

Update cmake.yml

view details

push time in 6 days

push eventrsdmike/rpc

Mike

commit sha e3cd3b14cb9906be27cd13e3654ff9bfacfd5727

Update cmake.yml

view details

push time in 6 days

push eventrsdmike/rpc

Mike

commit sha f23425153b7cac0ed2b7a07313200e2e8a4f1ebe

Update cmake.yml

view details

push time in 6 days

push eventrsdmike/rpc

Mike

commit sha 32b18dada78d4418b9d2c5d158eee7a2753c83e2

Update cmake.yml

view details

push time in 6 days

push eventrsdmike/rpc

Mike

commit sha 017148c01618b710fd0dbc93ef859041ea2f90ef

Update cmake.yml

view details

push time in 6 days

push eventrsdmike/rpc

Mike

commit sha a53dbde46999178f94dbb83b77159d8825611316

Update cmake.yml

view details

push time in 6 days

push eventrsdmike/rpc

Mike

commit sha 4b159cb014fa906cccbb7f58a343251a35e96e86

Update cmake.yml

view details

push time in 6 days

push eventrsdmike/rpc

Mike

commit sha 986f8f9eb24a18f787cb2065499f5f7066302c27

Update cmake.yml

view details

push time in 6 days

push eventrsdmike/rpc

Mike

commit sha 3e0d608ace6e9161946e6c572590753b9e6667d8

Update cmake.yml

view details

push time in 6 days

push eventrsdmike/rpc

Mike

commit sha f8da9eea4d6dcb47133ae6de89980f14464ae17d

Update cmake.yml

view details

push time in 6 days

push eventrsdmike/rpc

Mike

commit sha 4db4c9c9fdcd6c4c79e5b2f7cf383b7fa4b8dd71

Update cmake.yml

view details

push time in 6 days

push eventrsdmike/rpc

Mike

commit sha e74be159cf8c8662f98dd34e55a3b4536f4c5ac9

Update cmake.yml

view details

push time in 6 days

push eventrsdmike/rpc

Mike

commit sha d631c60f6e7a5fb07fca70caf8f4525135765f4c

Update cmake.yml

view details

push time in 6 days

push eventrsdmike/rpc

Mike

commit sha 5c6a6bd318c885599bb90dc2787e31fcaebc0c51

Update cmake.yml

view details

push time in 6 days

push eventrsdmike/rpc

Mike

commit sha 44f2ea3a5e24cedd71328dae7982852a1f7d8451

Update cmake.yml

view details

push time in 6 days

push eventrsdmike/rpc

Mike

commit sha 15ef859241f585747ec34fac9fdf72920282c60d

Update cmake.yml

view details

push time in 6 days

push eventrsdmike/rpc

Mike

commit sha 0bbee8b2f4f20fc447b03bbbe30b06104687bf84

Update cmake.yml

view details

push time in 6 days

push eventrsdmike/rpc

Mike

commit sha 09c093726b7572d3c1bbe65b02af6f1813713150

Update cmake.yml

view details

push time in 6 days

push eventrsdmike/rpc

Mike

commit sha cdc2a0c28c781a139d22cddd556e08c3dc3dd599

Create cmake.yml

view details

push time in 6 days

PR opened rsdmike/rpc

Create cmake.yml
+28 -0

0 comment

1 changed file

pr created time in 6 days

create barnchrsdmike/rpc

branch : rsdmike-patch-1

created branch time in 6 days

fork rsdmike/rpc

Remote Provisioning Client

fork in 6 days

push eventrsdmike/mps

Mike

commit sha 3875cefd382043aeefd71fb9c3b84575323760ba

Update c-cpp.yml

view details

push time in 6 days

push eventrsdmike/mps

Mike

commit sha d7c4426534f15172156523468d89f64d50576b4c

Update c-cpp.yml

view details

push time in 6 days

push eventrsdmike/mps

Mike

commit sha d17f7a6bc3cb212e60658cd7d73b94e46d625a19

Update c-cpp.yml

view details

push time in 6 days

push eventrsdmike/mps

Mike

commit sha fc1dcc06df6e3b2b6a9bb7615b3eb2faf475c61c

Update c-cpp.yml

view details

push time in 6 days

push eventrsdmike/mps

Mike

commit sha b09f6768bc0982ffc4181cd61084a7d8ac085504

Update c-cpp.yml

view details

push time in 6 days

PR opened rsdmike/mps

Create c-cpp.yml
+17 -0

0 comment

1 changed file

pr created time in 6 days

create barnchrsdmike/mps

branch : rsdmike-patch-1

created branch time in 6 days

fork rsdmike/mps

Management Presence Server

fork in 7 days

delete branch rsdmike/edgex-docs

delete branch : update-versions.json

delete time in 11 days

push eventedgexfoundry/edgex-docs

Mike

commit sha 730df8d0644a16d3dbee2e0a09c6b52d68d4311b

build: update versions.json to include 1.3 Signed-off-by: Mike <michael.johanson@intel.com>

view details

Mike

commit sha 31e07ac6613f1efc65519cefb29ab3a8df79513a

Merge pull request #258 from rsdmike/update-versions.json build: update versions.json to include 1.3

view details

push time in 11 days

PR merged edgexfoundry/edgex-docs

build: update versions.json to include 1.3

Signed-off-by: Mike michael.johanson@intel.com

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] Changes have been rendered and validated locally using mkdocs-material (see edgex-docs README)
  • [x] Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-docs/blob/master/.github/CONTRIBUTING.md.

What is the current behavior?

<!-- Please describe the current behavior and link to a relevant issue. -->

Issue Number:

What is the new behavior?

Does this PR introduce a breaking change?

<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->

  • [ ] Yes
  • [x] No

Specific Instructions

Are there any specific instructions or things that should be known prior to reviewing?

Other information

+2 -1

0 comment

1 changed file

rsdmike

pr closed time in 11 days

PR opened edgexfoundry/edgex-docs

Reviewers
build: update versions.json to include 1.3

Signed-off-by: Mike michael.johanson@intel.com

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] Changes have been rendered and validated locally using mkdocs-material (see edgex-docs README)
  • [x] Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-docs/blob/master/.github/CONTRIBUTING.md.

What is the current behavior?

<!-- Please describe the current behavior and link to a relevant issue. -->

Issue Number:

What is the new behavior?

Does this PR introduce a breaking change?

<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->

  • [ ] Yes
  • [x] No

Specific Instructions

Are there any specific instructions or things that should be known prior to reviewing?

Other information

+2 -1

0 comment

1 changed file

pr created time in 11 days

create barnchrsdmike/edgex-docs

branch : update-versions.json

created branch time in 11 days

push eventrsdmike/edgex-docs

Mike

commit sha cab602390184ee55faab265fb4db4c034d1e525f

build: remove 1.2 folder Signed-off-by: Mike <michael.johanson@intel.com>

view details

Mike

commit sha 5ad79484c51b2a0e868d193627d4f268c5634221

Merge pull request #257 from rsdmike/remove1.2frommaster build: remove 1.2 folder

view details

push time in 11 days

delete branch rsdmike/edgex-docs

delete branch : remove1.2frommaster

delete time in 11 days

push eventedgexfoundry/edgex-docs

Mike

commit sha cab602390184ee55faab265fb4db4c034d1e525f

build: remove 1.2 folder Signed-off-by: Mike <michael.johanson@intel.com>

view details

Mike

commit sha 5ad79484c51b2a0e868d193627d4f268c5634221

Merge pull request #257 from rsdmike/remove1.2frommaster build: remove 1.2 folder

view details

push time in 11 days

PR merged edgexfoundry/edgex-docs

build: remove 1.2 folder

Signed-off-by: Mike michael.johanson@intel.com

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] Changes have been rendered and validated locally using mkdocs-material (see edgex-docs README)
  • [x] Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-docs/blob/master/.github/CONTRIBUTING.md.

What is the current behavior?

<!-- Please describe the current behavior and link to a relevant issue. --> when jenkins job runs, items in docs are overwrite old 1.2 site due to content being in docs folder on master.

Issue Number:

What is the new behavior?

versioning works as intended.

Does this PR introduce a breaking change?

<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->

  • [ ] Yes
  • [x] No

Specific Instructions

Are there any specific instructions or things that should be known prior to reviewing?

Other information

+0 -156893

0 comment

386 changed files

rsdmike

pr closed time in 11 days

push eventrsdmike/edgex-docs

Mike

commit sha cab602390184ee55faab265fb4db4c034d1e525f

build: remove 1.2 folder Signed-off-by: Mike <michael.johanson@intel.com>

view details

push time in 11 days

PR opened edgexfoundry/edgex-docs

docs: remove 1.2 folder

Signed-off-by: Mike michael.johanson@intel.com

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] Changes have been rendered and validated locally using mkdocs-material (see edgex-docs README)
  • [x] Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-docs/blob/master/.github/CONTRIBUTING.md.

What is the current behavior?

<!-- Please describe the current behavior and link to a relevant issue. --> when jenkins job runs, items in docs are overwrite old 1.2 site due to content being in docs folder on master.

Issue Number:

What is the new behavior?

versioning works as intended.

Does this PR introduce a breaking change?

<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->

  • [ ] Yes
  • [x] No

Specific Instructions

Are there any specific instructions or things that should be known prior to reviewing?

Other information

+0 -156893

0 comment

386 changed files

pr created time in 11 days

push eventrsdmike/edgex-docs

Mike

commit sha 4df3d8876c854903717869a7112e463fe2ebfe86

docs: remove 1.2 folder Signed-off-by: Mike <michael.johanson@intel.com>

view details

push time in 11 days

create barnchrsdmike/edgex-docs

branch : remove1.2frommaster

created branch time in 11 days

push eventedgexfoundry/edgex-docs

Mike

commit sha 206c301fb33e6f5ad69486ef15243ab118bc67ce

Update versions.json

view details

push time in 13 days

PullRequestReviewEvent

push eventedgexfoundry/app-functions-sdk-go

dependabot[bot]

commit sha 4d6d34db027735e12da7a9c3064e813a8589f5e6

build(deps): bump github.com/edgexfoundry/go-mod-bootstrap Bumps [github.com/edgexfoundry/go-mod-bootstrap](https://github.com/edgexfoundry/go-mod-bootstrap) from 0.0.39 to 0.0.46. - [Release notes](https://github.com/edgexfoundry/go-mod-bootstrap/releases) - [Commits](https://github.com/edgexfoundry/go-mod-bootstrap/compare/v0.0.39...v0.0.46) Signed-off-by: dependabot[bot] <support@github.com>

view details

Mike

commit sha 11135aa80e527cda27448d3fc9afd0dd950ec3b5

Merge pull request #523 from edgexfoundry/dependabot/go_modules/github.com/edgexfoundry/go-mod-bootstrap-0.0.46 build(deps): bump github.com/edgexfoundry/go-mod-bootstrap from 0.0.39 to 0.0.46

view details

Mike

commit sha 3c2cd7b4de51fe1fa2b85d09e606c0df7f06f44c

Merge branch 'master' into dependabot/go_modules/github.com/edgexfoundry/go-mod-core-contracts-0.1.90

view details

push time in 14 days

delete branch edgexfoundry/app-functions-sdk-go

delete branch : dependabot/go_modules/github.com/edgexfoundry/go-mod-bootstrap-0.0.46

delete time in 14 days

push eventedgexfoundry/app-functions-sdk-go

dependabot[bot]

commit sha 4d6d34db027735e12da7a9c3064e813a8589f5e6

build(deps): bump github.com/edgexfoundry/go-mod-bootstrap Bumps [github.com/edgexfoundry/go-mod-bootstrap](https://github.com/edgexfoundry/go-mod-bootstrap) from 0.0.39 to 0.0.46. - [Release notes](https://github.com/edgexfoundry/go-mod-bootstrap/releases) - [Commits](https://github.com/edgexfoundry/go-mod-bootstrap/compare/v0.0.39...v0.0.46) Signed-off-by: dependabot[bot] <support@github.com>

view details

Mike

commit sha 11135aa80e527cda27448d3fc9afd0dd950ec3b5

Merge pull request #523 from edgexfoundry/dependabot/go_modules/github.com/edgexfoundry/go-mod-bootstrap-0.0.46 build(deps): bump github.com/edgexfoundry/go-mod-bootstrap from 0.0.39 to 0.0.46

view details

push time in 14 days

PR merged edgexfoundry/app-functions-sdk-go

build(deps): bump github.com/edgexfoundry/go-mod-bootstrap from 0.0.39 to 0.0.46 dependencies

Bumps github.com/edgexfoundry/go-mod-bootstrap from 0.0.39 to 0.0.46. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/edgexfoundry/go-mod-bootstrap/commit/167de56ad1273e1a2b4c9dc28370f0524a4e88eb"><code>167de56</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/edgexfoundry/go-mod-bootstrap/issues/105">#105</a> from edgexfoundry/dependabot/go_modules/github.com/ed...</li> <li><a href="https://github.com/edgexfoundry/go-mod-bootstrap/commit/57fcc743f38ddf136e5b5687c2a84d663694edf2"><code>57fcc74</code></a> build(deps): bump github.com/edgexfoundry/go-mod-registry</li> <li><a href="https://github.com/edgexfoundry/go-mod-bootstrap/commit/27e91a1ab20546e707878558a791d213273b002c"><code>27e91a1</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/edgexfoundry/go-mod-bootstrap/issues/104">#104</a> from edgexfoundry/dependabot/go_modules/github.com/ed...</li> <li><a href="https://github.com/edgexfoundry/go-mod-bootstrap/commit/face20a332a315f7998c820b0c6fff4b6e81ffb5"><code>face20a</code></a> build(deps): bump github.com/edgexfoundry/go-mod-core-contracts</li> <li><a href="https://github.com/edgexfoundry/go-mod-bootstrap/commit/61a4dbf2d66960796dcfae1e6c00372a9cc5e7a9"><code>61a4dbf</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/edgexfoundry/go-mod-bootstrap/issues/103">#103</a> from edgexfoundry/dependabot/go_modules/github.com/ed...</li> <li><a href="https://github.com/edgexfoundry/go-mod-bootstrap/commit/e324f7c015710545a5a6b6b7f86810a5b1494bf5"><code>e324f7c</code></a> build(deps): bump github.com/edgexfoundry/go-mod-configuration</li> <li><a href="https://github.com/edgexfoundry/go-mod-bootstrap/commit/1704b5afda2f8ff6a4f2ee8d352bd08f83ebee92"><code>1704b5a</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/edgexfoundry/go-mod-bootstrap/issues/102">#102</a> from edgexfoundry/dependabot/go_modules/github.com/ed...</li> <li><a href="https://github.com/edgexfoundry/go-mod-bootstrap/commit/54fdde4110586b0b8f8870d1414092b763ede1d6"><code>54fdde4</code></a> build(deps): bump github.com/edgexfoundry/go-mod-secrets</li> <li><a href="https://github.com/edgexfoundry/go-mod-bootstrap/commit/2cd2465e64d65a35b3613c4990a394352c14b0b4"><code>2cd2465</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/edgexfoundry/go-mod-bootstrap/issues/99">#99</a> from edgexfoundry/dependabot/go_modules/github.com/edg...</li> <li><a href="https://github.com/edgexfoundry/go-mod-bootstrap/commit/5c0786855a5bfcab22809d544339486e1f1d6ffc"><code>5c07868</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/edgexfoundry/go-mod-bootstrap/issues/101">#101</a> from lenny-intel/duration</li> <li>Additional commits viewable in <a href="https://github.com/edgexfoundry/go-mod-bootstrap/compare/v0.0.39...v0.0.46">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+4 -4

0 comment

1 changed file

dependabot[bot]

pr closed time in 14 days

PullRequestReviewEvent
PullRequestReviewEvent

delete branch rsdmike/edgex-docs

delete branch : versioning

delete time in 18 days

push eventedgexfoundry/edgex-docs

Mike

commit sha d41482137ae793aa55e98da8306c797208d62504

docs: Add instructions on how to version EdgeX Docs site Signed-off-by: Mike <michael.johanson@intel.com>

view details

Mike

commit sha 24ff5126fe637a47c69f4843b0dbafea828f8ec3

Merge branch 'master' into versioning

view details

Mike

commit sha 612229dd78cc426543b30d6e08d6ab6e299a03b6

Merge branch 'master' into versioning

view details

Mike

commit sha 90d667e113046b881ad6ef3825e79cd86b4f1382

Merge pull request #254 from rsdmike/versioning docs: Add instructions on how to version EdgeX Docs site

view details

push time in 18 days

PR merged edgexfoundry/edgex-docs

Reviewers
docs: Add instructions on how to version EdgeX Docs site

Signed-off-by: Mike michael.johanson@intel.com

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://wiki.edgexfoundry.org/display/FA/Contributor%27s+Guide
  • [x] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". -->

  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [x] Documentation content changes
  • [ ] Other... Please describe:

What is the current behavior?

<!-- Please describe the current behavior and link to a relevant issue. --> Versioning was a mystery on how it worked. Issue Number:

What has been updated?

Docs for how to version the docs site.

Are there any specific instructions or things that should be known prior to reviewing?

Other information

+48 -0

0 comment

1 changed file

rsdmike

pr closed time in 18 days

Pull request review commentedgexfoundry/edgex-docs

docs(AppServices): Document the App Services new MQTT Trigger capability

 Only used for `messagebus` binding type | MessageBus SubscribeHost `Protocol` | tcp** | Indicates the protocol number for publishing to the Message Bus | | **MessageBus Optional** | ... | This section is used for optional configuration specific to the Message Bus type used. Please refer to [go-mod-messaging](https://github.com/edgexfoundry/go-mod-messaging/blob/master/README.md) for more details | +### MqqtBroker++This section defines the external MQTT Broker connect information.+Only used for `external-mqtt` trigger binding type++!!! note+    `external-mqtt` is not the default Trigger type, so there are no default values for `MqttBrokerConfig` settings beyond those that the Go compiler gives to the empty struct. Some of those default values are not valid and must be specified, i.e. `Authmode`++| Configuration                     | Default Value | Description                                                  |+| --------------------------------- | ------------- | ------------------------------------------------------------ |+| MqqtBroker `Url`            | blank**       | fully qualified URL to connect to the MQTT broker, i.e. `tcp://localhost:1883` |+| MqqtBroker `ClientId`       | blank**       | ClientId to connect to the broker with                       |+| MqqtBroker `ConnectTimeout` | blank**       | time duration indicating how long to wait before timing out                                                                            

Casing is inconsistent for descriptions in this table.

lenny-intel

comment created time in 18 days

Pull request review commentedgexfoundry/edgex-docs

docs(AppServices): Document the App Services new MQTT Trigger capability

-Triggers determine how the app functions pipeline begins execution. The trigger is determined by the `configuration.toml` file located in the `/res` directory under a section called `[Binding]`. Check out the [Configuration Section](#configuration) for more information about the toml file.+Triggers determine how the app functions pipeline begins execution. The trigger is determined by the `configuration.toml` file located in the `/res` directory under a section called `[Binding]`. Check out the [Configuration Section](../GeneralAppServiceConfig/) for more information about the toml file. -## Message Bus Trigger+## Edgex Message Bus Trigger -A message bus trigger will execute the pipeline every time data is received off of the configured topic.  +An EdgeX Message Bus trigger will execute the pipeline every time data is received from the configured Edgex Message Bus `SubscribeTopic`.  The EdgeX Message Bus is the central message bus internal to EdgeX and has a specific message envelope that wraps all data published to this message bus.++There currently are three implementations of the EdgeX Message Bus available to be used. These are `ZeroMQ`, `MQTT` & `Redis Streams`. The implementation type is selected via the `[MessageBus]` configuration described below.  ### Type and Topic configuration  Here's an example:+ ```toml-Type="messagebus" +[Binding]+Type="edgex-messagebus" # also can use legacy messagebus for type SubscribeTopic="events" PublishTopic="" ```-The `Type=` is set to "messagebus". [EdgeX Core Data]() is publishing data to the `events` topic. So to receive data from core data, you can set your `SubscribeTopic=` either to `""` or `"events"`. You may also designate a `PublishTopic=` if you wish to publish data back to the message bus.-`edgexcontext.Complete([]byte outputData)` - Will send data back to back to the message bus with the topic specified in the `PublishTopic=` property+The `Type=` is set to `edgex-messagebus` trigger type or the legacy type of `messagebus`. [EdgeX Core Data]() is publishing data to the `events` topic. So to receive data from core data, you can set your `SubscribeTopic=` either to `""` or `"events"`. You may also designate a `PublishTopic=` if you wish to publish data back to the message bus. `edgexcontext.Complete([]byte outputData)` - Will send data back to the message bus on the topic specified by the `PublishTopic=` property

EdgeX Core Data --> is this supposed to be a link somewhere?

lenny-intel

comment created time in 18 days

Pull request review commentedgexfoundry/edgex-docs

docs(AppServices): Document the App Services new MQTT Trigger capability

 Only used for `messagebus` binding type | MessageBus SubscribeHost `Protocol` | tcp** | Indicates the protocol number for publishing to the Message Bus | | **MessageBus Optional** | ... | This section is used for optional configuration specific to the Message Bus type used. Please refer to [go-mod-messaging](https://github.com/edgexfoundry/go-mod-messaging/blob/master/README.md) for more details | +### MqqtBroker

Mqqt?

lenny-intel

comment created time in 18 days

Pull request review commentedgexfoundry/edgex-docs

docs(AppServices): Document the App Services new MQTT Trigger capability

-Triggers determine how the app functions pipeline begins execution. The trigger is determined by the `configuration.toml` file located in the `/res` directory under a section called `[Binding]`. Check out the [Configuration Section](#configuration) for more information about the toml file.+Triggers determine how the app functions pipeline begins execution. The trigger is determined by the `configuration.toml` file located in the `/res` directory under a section called `[Binding]`. Check out the [Configuration Section](../GeneralAppServiceConfig/) for more information about the toml file. -## Message Bus Trigger+## Edgex Message Bus Trigger

EdgeX

lenny-intel

comment created time in 18 days

Pull request review commentedgexfoundry/edgex-docs

docs(AppServices): Document the App Services new MQTT Trigger capability

 Only used for `messagebus` binding type | MessageBus SubscribeHost `Protocol` | tcp** | Indicates the protocol number for publishing to the Message Bus | | **MessageBus Optional** | ... | This section is used for optional configuration specific to the Message Bus type used. Please refer to [go-mod-messaging](https://github.com/edgexfoundry/go-mod-messaging/blob/master/README.md) for more details | +### MqqtBroker++This section defines the external MQTT Broker connect information.+Only used for `external-mqtt` trigger binding type++!!! note+    `external-mqtt` is not the default Trigger type, so there are no default values for `MqttBrokerConfig` settings beyond those that the Go compiler gives to the empty struct. Some of those default values are not valid and must be specified, i.e. `Authmode`++| Configuration                     | Default Value | Description                                                  |+| --------------------------------- | ------------- | ------------------------------------------------------------ |+| MqqtBroker `Url`            | blank**       | fully qualified URL to connect to the MQTT broker, i.e. `tcp://localhost:1883` |

MqqT? For all of these :) COPY PASTA error

lenny-intel

comment created time in 18 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventrsdmike/edgex-docs

Lenny Goodell

commit sha 90084f65c1c2cafc35bdc0fe2a2e2947a75f7b4d

feat: Document Application Service's new AddTags function (#231) closes #230 Signed-off-by: lenny <leonard.goodell@intel.com>

view details

Alex Ullrich

commit sha c135d42789c029668ef0471bbfb53abcc0f1026b

docs(app-sdk): Expose RegistryClient (#245) Adds simple explanation on using exposed RegistryClient in app services Signed-off-by: Alex Ullrich <alexullrich@technotects.com> Co-authored-by: Lenny Goodell <44779287+lenny-intel@users.noreply.github.com>

view details

Alex Ullrich

commit sha b9357a8f84fb228053a8ccda84e85bbf34284791

docs(app-sdk): Add background publisher API detail (#229) Adds a simple paragraph and code example for using background publisher API References: #462 Signed-off-by: Alex Ullrich <alexullrich@technotects.com> Co-authored-by: Lenny Goodell <44779287+lenny-intel@users.noreply.github.com>

view details

Mike

commit sha 612229dd78cc426543b30d6e08d6ab6e299a03b6

Merge branch 'master' into versioning

view details

push time in 18 days

push eventrsdmike/edgex-docs

Ernesto Ojeda

commit sha 5c2359ef593a49f8d074fbccb6dd07041cb282c7

build: add Hanoi version 1.3 (#252) Signed-off-by: Ernesto Ojeda <ernesto.ojeda@intel.com>

view details

Mike

commit sha 24ff5126fe637a47c69f4843b0dbafea828f8ec3

Merge branch 'master' into versioning

view details

push time in 18 days

PR opened edgexfoundry/edgex-docs

docs: Add instructions on how to version EdgeX Docs site

Signed-off-by: Mike michael.johanson@intel.com

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://wiki.edgexfoundry.org/display/FA/Contributor%27s+Guide
  • [x] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". -->

  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [x] Documentation content changes
  • [ ] Other... Please describe:

What is the current behavior?

<!-- Please describe the current behavior and link to a relevant issue. --> Versioning was a mystery on how it worked. Issue Number:

What has been updated?

Docs for how to version the docs site.

Are there any specific instructions or things that should be known prior to reviewing?

Other information

+48 -0

0 comment

1 changed file

pr created time in 18 days

create barnchrsdmike/edgex-docs

branch : versioning

created branch time in 18 days

issue commentedgexfoundry/app-functions-sdk-go

about demo http-command-service uri /api/v1/trigger is response content-type

We'll take a look and see if this something we can support in response w/ SetOutputData.

zhongweibest

comment created time in 18 days

issue commentedgexfoundry/app-functions-sdk-go

Integration tests for Store and Forward capability

Needs to be moved to TAF repo

lenny-intel

comment created time in 18 days

PR closed edgexfoundry/app-functions-sdk-go

build(deps): bump github.com/edgexfoundry/go-mod-core-contracts from 0.1.80 to 0.1.82 dependencies

Bumps github.com/edgexfoundry/go-mod-core-contracts from 0.1.80 to 0.1.82. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/edgexfoundry/go-mod-core-contracts/commit/cf2d6ff636ffd34821300a1ced153a249f1f92fb"><code>cf2d6ff</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/edgexfoundry/go-mod-core-contracts/issues/291">#291</a> from cloudxxx8/issue-290</li> <li><a href="https://github.com/edgexfoundry/go-mod-core-contracts/commit/b21f5c8332eac12f44817843c8407ad1c1505b64"><code>b21f5c8</code></a> Fix: Error msg should return first non-empty msg</li> <li><a href="https://github.com/edgexfoundry/go-mod-core-contracts/commit/0d5d88458eaedf18de20903fc0779208ad678d39"><code>0d5d884</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/edgexfoundry/go-mod-core-contracts/issues/293">#293</a> from weichou1229/issue-292</li> <li><a href="https://github.com/edgexfoundry/go-mod-core-contracts/commit/cbead72e9781d06be1405dd456b1af764cd6939a"><code>cbead72</code></a> feat(metadata): Add API route path for metadata V2 API</li> <li>See full diff in <a href="https://github.com/edgexfoundry/go-mod-core-contracts/compare/v0.1.80...v0.1.82">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+1 -1

1 comment

1 changed file

dependabot-preview[bot]

pr closed time in 18 days

pull request commentedgexfoundry/app-functions-sdk-go

build(deps): bump go.mongodb.org/mongo-driver from 1.1.1 to 1.4.1

@dependabot ignore this dependency

dependabot[bot]

comment created time in 18 days

PullRequestReviewEvent

issue commentedgexfoundry/app-functions-sdk-go

Multiple Export destinations

Will consider enabling multiple exports destinations via conditional pipelines. Not multiple in the same pipeline

lenny-intel

comment created time in 25 days

PullRequestReviewEvent
more