profile
viewpoint

rrhyne/MapzenGo 0

Pokemon Go clone using Unity3D & Mapzen/OpenStreetMap

rrhyne/vue-enterprise-boilerplate 0

An ever-evolving, very opinionated architecture and dev environment for new Vue SPA projects using Vue CLI 3.

rrhyne/yii2-images 0

Yii2-images - behavior-based module for resizing, storing, caching and attaching images.

rrhyne/yii2-mailgun 0

Mailgun integration for the Yii2 framework

Pull request review commentsourcegraph/sourcegraph

Storybook additions 2

 add(                         We'll never share your email with anyone else.                     </small>                 </div>+                <div className="form-group">+                    <label htmlFor="example-prepend-input">Prepend group</label>

As the other item has one element, I'd say let's move it here.

rrhyne

comment created time in an hour

push eventsourcegraph/sourcegraph

rob rhyne

commit sha 8c0f382fbea9a8cd4bbd0d5b472b8d6fe9545d3f

prettier

view details

push time in 5 hours

pull request commentsourcegraph/sourcegraph

Storybook additions 2

@felixfbecker I've added a prepend form groups, radio buttons, checked state for checkboxes, radio buttons with all states and button groups. See these screenshots:

Screen Shot 2020-08-07 at 9 27 50 AM

Screen Shot 2020-08-07 at 9 27 40 AM

LMK what I need to change about the underlying components/html

rrhyne

comment created time in 5 hours

push eventsourcegraph/sourcegraph

Eric Fritz

commit sha 40b316180fd0821888f3f7d6fdae73acd42016b5

codeintel: Remove ErrMalformedBundle (#12497)

view details

Rijnard van Tonder

commit sha 7d6cafd040926f59c9dd58efa684a5da61f61734

remove replacer (#12480)

view details

Adam Harvey

commit sha c6db6b232639b991eb5746a9b90daf12f6133c7d

schema: allow personal repos on Bitbucket Server (#12504) Unlike GitHub and GitLab, personal repos are additionally namespaced with a tilde on Bitbucket Server. We should be able to specify these in the repository and exclusion configuration.

view details

Robert Lin

commit sha caf2339820f75d22e53933fa11afac613708d288

monitoring: increase alert repeat interval to 7d (#12484)

view details

Robert Lin

commit sha c81be13d383a3fa99eeee3aa4f6436d5a04d238c

monitoring: add for:7d to provisioning alerts (#12507)

view details

Stefan Hengl

commit sha c2b33bf986c1028908dc22e7b9c567d6d0e3d00c

search: add NOT as syntactic sugar (#12520)

view details

Loïc Guychard

commit sha c6ca86f0b63f73a4f4ccd148f35049e45e2be3eb

Add platform to code host integration event logs (#12533) Rel. #11447 Adds platform argument to `CODEHOSTINTEGRATION` events, where platform will be one of: `firefox-extension`, `chrome-extension`, `phabricator-integration`, `bitbucket-integration`, `gitlab-integration`

view details

Eric Fritz

commit sha b1e5893c7e564f013c6ee2b4a0516190b6afddbc

Move [enterprise/]cmd/frontend/authz to [enterprise/]internal/authz (#12538)

view details

Eric Fritz

commit sha 407a02565821e63d637f0a943405444adce377ee

Categorize enterprise frontend startup behaviors (#12539)

view details

Loïc Guychard

commit sha e06be89633a3b29524a09b12a9cf96afcd497657

Add platform to BrowserExtensionConnectedToServer event log (#12535) Rel. #11447 Last piece of the solution to track browser extension usage, for users who never click any injected links or take any code intelligence action, but visit the Sourcegraph instance with the browser extension connected. I could have just added a `browser` argument parsed from the user agent string here, but figured standardizing on the `platform` sent by the browser extension like in other logs (#12533) or utm_sources (#12534) would be better for consistency.

view details

Rijnard van Tonder

commit sha 3a380cdd42fbe3a23ceb2680fbf4164c48c4f309

Revert "remove replacer (#12480)" (#12541)

view details

Stephen Gutekanst

commit sha d07cd9909a5fb6f32925653432ac5b1e6858be00

pure_docker: release v3.17.2 (#12542)

view details

Rijnard van Tonder

commit sha ff14a9340feb96f587ccee57a108f8773339cd0c

search: dedup results in union operation (#12531)

view details

Keegan Carruthers-Smith

commit sha 9997438a8ba2fdc54920f1f6ad22dd08d4a37215

zoekt: binary encoder for repo branches (#12546) This updates zoekt to include a custom binary marshaller for repo branches. When CPU profiling two of the major contributors is Gob encoding and garbage collection. This should significantly improve time spent gob encoding (~4x faster). It also will only allocate one large buffer vs 2 per key, value in gob. This should help reduce pressure on frontend. For example on Sourcegraph.com we have 100k repos indexed with 12 search replicas. This means when marshalling the repobranches for default we will go from allocating 100k * 2 * 12 = 2.4 million objects to 12. This commit requires zoekt and sourcegraph-frontend to have the same version of query.RepoBranches. For customers this will require a small amount of downtime when upgrading. For sourcegraph.com I will ensure they roll out at the same time. Changes: - c908c13 shards: optimize RepoBranches when all branches are the same - 809c853 query: binary encoder for repo branches - 2a821ee query: exactly match on repobranch branches

view details

Ryan Slade

commit sha a4d9c17aa0785b19f829fcf162fea2b19a350967

conf: Cancel timer to free goroutine (#12553) Previously all calls to conf.Get, via WaitUntilInitialized, would spawn a timer that would leave a pending goroutine running, even if config had already been initialised. The default timeout period is 5 minutes so this can lead to a large number of pending routines.

view details

Ryan Slade

commit sha 4d254b2f7e5c6e9c451a74f8eb7112a7128143dd

conf: More efficient deadlock check (#12555) Perform a non blocking check early so that we have a fast path when we know config is already initialsed.

view details

Keegan Carruthers-Smith

commit sha 5b0a6bc46fb008703672f20028e1b46107a9817f

search: more trace logging (#12554) I am investigating traces on Sourcegraph.com. Resolving repositories is half the time, so added more detailed trace logging for it. Additionally I improved how we log for Zoekt to make it more pleasant (and efficient) to read those traces.

view details

Stefan Hengl

commit sha 370226e109b04888578884b2e475a3c9eb65818f

search: reactivate dead code path in alertForOverRepoLimit (#12556)

view details

Keegan Carruthers-Smith

commit sha 05db081805ef89db3f58c53bac3d4f0307e4d00d

db: in-memory cache of default repos (#12557) This is a sourcegraph.com specific optimization. We add an in-memory cache of the list of repos search on Sourcegraph.com when no repo filters are specified. Currently retrieving this list from the database takes 350ms. It is a very rarely changing value and is shared across users/requests. Co-authored-by: Ryan Slade <ryanslade@gmail.com>

view details

Loïc Guychard

commit sha 70b6f64e2a16bcdb1d3c85336778f22da05c2c89

Code host integrations: always add utm_source (#12534) Rel. #11447 Ensures we always add `?utm_source=platform_name` to links pointing back to the Sourcegraph instance from code host integrations, where the platform name is one of: `firefox-extension`, `chrome-extension`, `phabricator-integration`, `bitbucket-integration`, `gitlab-integration`

view details

push time in 5 hours

pull request commentsourcegraph/sourcegraph

web: highlight search operators and/or/not

@rvantonder, I think the choice of purple is perfect. The only change I would make is to select two similar colors from the open color palette as Felix mentioned: Here is a comp showing the two I picked:

https://www.figma.com/file/DzmwBVeEu4cADYIoz5EefH/%2312694-and%2For%2Fnot?node-id=0%3A1&viewport=1298%2C1014%2C1

#CC5DE8 (#5 of 10 purple) almost works for both, but it's a tad light on the white background.

rvantonder

comment created time in 3 days

issue closedsourcegraph/sourcegraph

Nicer display of sign-in errors

When a user's sign-in fails, they are shown a text/plain page with a message like:

No user exists matching any of the verified emails: alice@example.com alice2@example.org.

First error was: Username "alice" already exists, but no verified email matched "alice@example.com"

Reported by a user from https://app.hubspot.com/contacts/2762526/company/407948923 on Sourcegraph.com, not on their internal instance

closed time in 7 days

sqs

issue commentsourcegraph/sourcegraph

Nicer display of sign-in errors

This issue appears to have been addressed.

sqs

comment created time in 7 days

issue commentsourcegraph/sourcegraph

Sign in page has ugly navbar

I mean that "the overall design" should be a separate project, the navbar can certainly be fixed in the IA project.

My issue with the design is that it is uninspiring. Here's a sketch of the opposite of that page. It goes a bit too far and is now off-brand, but illustrates the spectrum of possibilities:

https://www.figma.com/file/BsMRCHLqk8okCkDICYmtWE/Login-page-exploration?node-id=3%3A191

slimsag

comment created time in 7 days

Pull request review commentsourcegraph/sourcegraph

Web content styles

+.web-content {+    --link-color: #329af0;+    font-weight: normal;+    font-size: 14px;+    line-height: 20px;+    color: $gray-06;++    h1,+    h2,+    h3 {+        color: $gray-08;+        font-weight: normal;+    }++    h4 {+        color: $gray-06;+        font-weight: normal;+    }++    h5,+    h6 {+        color: $gray-04;+        font-weight: normal;+    }++    strong {+        color: $gray-11;+    }++    small {+        font-size: 12px;+    }++    .search-keyword {+        color: #329af0;

That looks to be a library that is not in the Sourcegraph team, at least I cannot find it. Can you share a link?

attfarhan

comment created time in 8 days

Pull request review commentsourcegraph/sourcegraph

Web content styles

+.web-content {+    --link-color: #329af0;+    font-weight: normal;+    font-size: 14px;+    line-height: 20px;+    color: $gray-06;++    h1,+    h2,+    h3 {+        color: $gray-08;+        font-weight: normal;+    }++    h4 {+        color: $gray-06;+        font-weight: normal;+    }++    h5,+    h6 {+        color: $gray-04;+        font-weight: normal;+    }++    strong {+        color: $gray-11;+    }++    small {+        font-size: 12px;+    }++    .search-keyword {+        color: #329af0;

It came from here, which I assumed was sanctioned:

https://www.figma.com/file/P2M4QrgIxeUsjE80MHP8TmY3/Sourcegraph-Colors?node-id=0%3A2

I think the next step now is to go through that file and figure out what is different.

attfarhan

comment created time in 8 days

issue commentsourcegraph/sourcegraph

Sign in page has ugly navbar

Agree the navbar could go, but the overall design here should be a project as well.

slimsag

comment created time in 8 days

Pull request review commentsourcegraph/sourcegraph

Web content styles

+.web-content {+    --link-color: #329af0;+    font-weight: normal;+    font-size: 14px;+    line-height: 20px;+    color: $gray-06;++    h1,+    h2,+    h3 {+        color: $gray-08;+        font-weight: normal;+    }++    h4 {+        color: $gray-06;+        font-weight: normal;+    }++    h5,+    h6 {+        color: $gray-04;+        font-weight: normal;+    }++    strong {+        color: $gray-11;+    }++    small {+        font-size: 12px;+    }++    .search-keyword {+        color: #329af0;

It is, in the palette. One of the styles we use it for is $web-color/link-styles/dark.

attfarhan

comment created time in 8 days

Pull request review commentsourcegraph/sourcegraph

Web content styles

+.web-content {+    --link-color: #329af0;+    font-weight: normal;+    font-size: 14px;+    line-height: 20px;+    color: $gray-06;++    h1,+    h2,+    h3 {+        color: $gray-08;+        font-weight: normal;+    }++    h4 {+        color: $gray-06;+        font-weight: normal;+    }++    h5,+    h6 {+        color: $gray-04;+        font-weight: normal;+    }++    strong {+        color: $gray-11;+    }++    small {+        font-size: 12px;+    }++    .search-keyword {+        color: #329af0;+    }++    .example-searches {+        a {

That was my intension: search query links have different styling all-together. They should not be affected by normal link styles.

attfarhan

comment created time in 8 days

Pull request review commentsourcegraph/sourcegraph

Storybook additions 2

 add(                 sizes, states, and more.{' '}                 <a href="https://getbootstrap.com/docs/4.5/components/buttons/">Bootstrap documentation</a>             </p>+             <p>                 {semanticColors.map(semantic => (                     <React.Fragment key={semantic}>                         <button                             type="button"                             key={semantic}                             className={classNames('btn', `btn-${semantic}`)}+                        >+                            {startCase(semantic)}+                        </button>{' '}+                    </React.Fragment>+                ))}+            </p>++            <h3>Small</h3>

Good call. I made our storybook match your example.

rrhyne

comment created time in 10 days

issue commentsourcegraph/sourcegraph

Author searches report 'no results', should hint to use type:commit or type:diff

That's a much better approach than addressing these at a single time. Altering the ticket to reflect that. You might need to edit it to be more accurate.

rrhyne

comment created time in 10 days

push eventsourcegraph/sourcegraph

Keegan Carruthers-Smith

commit sha 9c70e49a5c8371a31bea82a291188bf9b869e805

zoekt: indexserver removes repos from queue (#12474) This includes several changes to zoekt indexserver which improve observability as well as make us behave better during rebalancing. In particular we would try to index all repos on a replica if we ever rebalanced. We will still do that, but as soon as the replica comes back up we will stop doing that. - 3e5f0f3 indexserver: track last index state as a metric - cfdfeff indexserver: metrics for queue - a453878 indexserver: stop indexing repositories if not listed

view details

uwedeportivo

commit sha 964d97bd4d5817949a5cf596e415c454525313fb

e2e regression test fixes (#12439) * e2e regression tests * e2e -> test in selectors * Update web/src/regression/extensions.test.ts Co-authored-by: Loïc Guychard <loic@sourcegraph.com> * prettier * eslint exception for innerText in core.test * eslint exception for innerText in core.test take 2 Co-authored-by: Loïc Guychard <loic@sourcegraph.com>

view details

uwedeportivo

commit sha 0ef436765fbe494af19506a6eaf42b86fc12ebf7

fix build (#12475)

view details

Felix Becker

commit sha 646ebbb62f5ed21ab1feec1e4fab19a0bb39845e

Use Dart Sass (#12329)

view details

Rijnard van Tonder

commit sha c6cfafb22cb2693695cadcffef5f06f219d8186f

search: fix field value scanner (#12446)

view details

Rijnard van Tonder

commit sha 1d5a67069d35c8840a075207aa77890ae61e7f89

search: error on breaking concat invariant (#12457)

view details

Rijnard van Tonder

commit sha 3029f7449c0fb1198ffcbaee4ebdf25b8ee02ff7

search: log search inputs for differential testing parsers (#12479)

view details

Robert Lin

commit sha e208aa82343e82cf7a1b1bacc88b4d008dd0f537

monitoring: base alert_count only on state=firing alerts (#12483)

view details

github-actions[bot]

commit sha c6d280cec8513a8c2f56ae39185cba5acb955a6e

Update third-party licenses (#12488) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

view details

Thorsten Ball

commit sha 9a85a646af4887e3b9551bdcc43f8dac7f2614a2

Update example in basestore.Store docstring (#12432) I think the docstring was a bit outdated.

view details

Eric Fritz

commit sha 74f698b0c8fcb8cb247580580984cce550fed2c7

codeintel: Add CalculateVisibleUploads to store (#12408)

view details

Ryan Slade

commit sha 65d2eae2857724b745ad953f6b719a7bd1ee746c

go: Update out graphql-go dependency (#12459)

view details

Stefan Hengl

commit sha 255cb618c755026d801b2d2fd5bc9d30197c19a5

search: support negation for field content (#12412)

view details

Keegan Carruthers-Smith

commit sha a521dfbea179120227aae57e31720c998475eeaf

zoekt: prevent indexserver stalling (#12502) See https://github.com/sourcegraph/zoekt/compare/6ed80895db7e...a99799fdc041 - a99799f ctags: handle fatal ctags errors - 5fcad78 ctags: skip commands that are too large - cf36be0 ctags: use file basename - d4fecb4 indexserver: timeout if no output for 5m - 34a0dd6 indexserver: coarse 1h timeout on index job - fdc9c2c Merge remote-tracking branch 'gerrit/master' - b48e35d shards: a progress message every 10s when loading - 4481f7b shards: throttle loading in watcher

view details

Robert Lin

commit sha 434fd412bfeb7c2cdb0909797a31e09d1588944f

monitoring: fix alert state query, fix alert firing threshold (#12489)

view details

uwedeportivo

commit sha 30f8af2388bce040be095a762c5492608a8db2f4

release captain 3.19 (#12505)

view details

Robert Lin

commit sha 37a8af898fffc0be990240f4979b7c1877b8fc3e

monitoring: migrate out-of-band alerts to the generator (#12391) Migrates all out-of-band alert rules defined by deploy-sourcegraph to the generator, such that each alert now has a panel as part of a service dashboard like all our other alerts, with a few changes and additions.

view details

Stephen Gutekanst

commit sha cff20a845c2263deacdcbf18e3b50e2b3c4af94c

Release Docker Compose v3.18.0-1 (#12509) * Release Docker Compose v3.18.0-1 * Release Docker Compose v3.18.0-1 * Release Docker Compose v3.18.0-1

view details

Robert Lin

commit sha da520cf2c4aa5396860e9569d8efe1f68e668f04

monitoring: log prom-wrapper attempts at connecting to the frontend (#12508)

view details

Robert Lin

commit sha 9db0d540d5dab475de834378c8a38988ef17ccd0

monitoring: use prometheus model.Duration (#12510)

view details

push time in 10 days

issue commentsourcegraph/sourcegraph

Add browser argument to BrowserExtensionConnectedToServer event

Suggestion:

#chrome_ext and #firefox_ext

ebrodymoore

comment created time in 10 days

issue closedsourcegraph/sourcegraph

Add hash parameter to links in chrome and firefox extensions

We need to add a marker on all sourcegraph.com URLs so we can identify the source of traffic. Suggestion:

#chrome_ext and #firefox_ext

closed time in 10 days

rrhyne

issue commentsourcegraph/sourcegraph

Add hash parameter to links in chrome and firefox extensions

Closing as duplicate of https://github.com/sourcegraph/sourcegraph/issues/11447

rrhyne

comment created time in 10 days

issue openedsourcegraph/sourcegraph

Add hash parameter to links in chrome and firefox extensions

We need to add a marker on all sourcegraph.com URLs so we can identify the source of traffic. Suggestion:

#chrome_ext and #firefox_ext

created time in 10 days

issue openedsourcegraph/sourcegraph

Author searches report 'no results', should hint to use type:commit or type:diff

  • Sourcegraph version: All
  • Platform information: All

Steps to reproduce:

  1. Search repo:sourcgraph/sourcegraph author:rob@sourcegraph.com
  2. Note the user has not included type commit or diff
  3. Run search

Expected behavior:

A tip is provided that author searches require type:commit or type:diff.

Actual behavior:

  1. Receive the "No Results" banner

created time in 10 days

Pull request review commentsourcegraph/sourcegraph

Web content styles

                 color: $gray-19;             }         }--        &__web-link {-            color: #1c7cd6;-        }--        &__keyword-text {

@attfarhan was this helpful? Do you need anything more from me on this?

attfarhan

comment created time in 11 days

issue commentsourcegraph/sourcegraph

Add tags to Git-extras extension

Good catch! Also, the extension search should leverage descriptions: https://github.com/sourcegraph/sourcegraph/issues/11264.

AlicjaSuska

comment created time in 11 days

Pull request review commentsourcegraph/sourcegraph

Web content styles

+.web-content {+    --link-color: #329af0;++    h1,+    h2,+    h3 {+        color: $gray-08;+        font-weight: normal;+    }++    h4 {+        color: $gray-06;+        font-weight: normal;+    }++    h5,+    h6 {+        color: $gray-04;+        font-weight: normal;+    }++    p {+        font-weight: normal;+        font-size: 14px;+        line-height: 20px;+        color: $gray-06;+    }++    i {+        color: $gray-06;+    }++    strong {+        color: $gray-11;+    }++    &__small {+        font-size: 12px;+    }++    &__search-keyword {+        color: var(--link-color);

Why separate if they are the same color?

attfarhan

comment created time in 14 days

Pull request review commentsourcegraph/sourcegraph

Web content styles

+.web-content {+    --link-color: #329af0;++    h1,+    h2,+    h3 {+        color: $gray-08;+        font-weight: normal;+    }++    h4 {+        color: $gray-06;+        font-weight: normal;+    }++    h5,+    h6 {+        color: $gray-04;+        font-weight: normal;+    }++    p {+        font-weight: normal;+        font-size: 14px;+        line-height: 20px;+        color: $gray-06;+    }++    i {

I think this color designation should be removed. If it was being used on an italic, that italic was probably supposed to be text-muted or it's a special override.

attfarhan

comment created time in 14 days

Pull request review commentsourcegraph/sourcegraph

Web content styles

+.web-content {+    --link-color: #329af0;++    h1,+    h2,+    h3 {+        color: $gray-08;+        font-weight: normal;+    }++    h4 {+        color: $gray-06;+        font-weight: normal;+    }++    h5,+    h6 {+        color: $gray-04;+        font-weight: normal;+    }++    p {+        font-weight: normal;+        font-size: 14px;+        line-height: 20px;+        color: $gray-06;+    }++    i {+        color: $gray-06;+    }++    strong {+        color: $gray-11;+    }++    &__small {+        font-size: 12px;+    }++    &__search-keyword {

They do have a different color as the default light mode keyword color doesn't display well over the body color:

image

The link-color is a shade darker, but it doesn't look inconsistent, it just has better contrast.

attfarhan

comment created time in 14 days

push eventsourcegraph/sourcegraph

rob rhyne

commit sha e9855e8c7381ad9fcfda73b04cbc0a6a45442fce

adjust button radius for all sizes

view details

push time in 14 days

pull request commentsourcegraph/sourcegraph

Storybook additions 2

Yeah I had punted on the size variants and outline, thanks for adding!

Afaik only sm and lg variants exist, no xs: https://getbootstrap.com/docs/4.5/components/buttons/#sizes Where would that be used? It would be easy to add, just want to check.

I often use btn-sm in panel headers (button groups, etc) and other tight places. btn-lg is often used in empty states or CTA where you want to prompt the user to clearly take action.

rrhyne

comment created time in 14 days

push eventsourcegraph/about

Rob Rhyne

commit sha 07fd1f62b1896f012dc33e2c67819fbcf22a375b

Add iconify (#1219)

view details

push time in 14 days

delete branch sourcegraph/about

delete branch : add-iconify

delete time in 14 days

PR merged sourcegraph/about

Add iconify
+1 -0

0 comment

1 changed file

rrhyne

pr closed time in 14 days

push eventsourcegraph/sourcegraph

rob rhyne

commit sha 5bcea9a9722c26ccfa7d9037a4f7bba3c88a27c7

remove xs buttons

view details

push time in 14 days

pull request commentsourcegraph/sourcegraph

Storybook additions 2

@felixfbecker I'm going to require btn-sm in an upcoming design and realized we didn't have them in our storybook, so I've added 3 button sizes, xs, sm and LG.

It looks like there is a discrepancy between border-radius on the sm and LG sizes. Could you correct or let me know how you would correct?

This storybook also now contains button outlines as btn-outline-primary was in our Figma components but not Storybook.

rrhyne

comment created time in 14 days

push eventsourcegraph/sourcegraph

rob rhyne

commit sha ed06a8811e18e80d17c8dee85c1aa9f616c111cf

add xs buttons

view details

push time in 14 days

push eventsourcegraph/sourcegraph

rob rhyne

commit sha 9232f2e943c2064cc96d80f1e5f99f36a3c91101

fix outline, button sizes

view details

push time in 14 days

push eventsourcegraph/sourcegraph

Eric Fritz

commit sha 5c42d6954211dde1e74d601602f9cedb51919212

codeintel: Add CommitGraph to gitserver client (#12404)

view details

Eric Fritz

commit sha 8af9002ca940c8b064f32322ee717013040329a3

codeintel: Add commit graph utilities (#12402)

view details

Eric Fritz

commit sha 4db05a84e89d9115a7fcee2ac868a2a09d3b67b2

codeintel: Add Lock to store (#12401)

view details

Rijnard van Tonder

commit sha 568ad90e70537450358f39783c9ced70d27d43f7

search: add additional alert for comby out of memory (#12385)

view details

Rijnard van Tonder

commit sha 7814eca4dc3feb4b7fa06e88f4575061c8cc7ea6

search: add DNF conversion for hierarchical search (#12381)

view details

Keegan Carruthers-Smith

commit sha c22422b05c57a70afee1674a99db922e28f2820e

schema: cleanup schema gen (#12394) Moved logic into a shell script and deduplicated it a bit.

view details

Ryan Slade

commit sha f085ae76798b6c7f8351875fb4587d3a564a0923

go: Update our graphql-go dependency (#12430)

view details

Felix Becker

commit sha e7f82155835102cebed818e9aaa4f55a0ecb9e5e

Update info color to a lighter cyan (#12433)

view details

Keegan Carruthers-Smith

commit sha 62738b92764866c3b3d77e26dff35e1a69014672

search: limit indexed branches per repository to 64 (#12431) Zoekt only supports indexing up to 64 repositories. This commit enforces this in the JSON schema for "search.index.branches". Enforcing this for Version Contexts will require adding a custom validator, which I'll leave for a later improvement. Since we don't enforce this everywhere, the options we generate will deterministically only return up to 64 branches. If an admin specifies more, it is likely better to index 64 branches than index none and fail.

view details

Keegan Carruthers-Smith

commit sha c03c8d475820912385372d7502fdace795847aa5

endpoint: prom metric and debug logs for k8s service discovery (#12434)

view details

Rijnard van Tonder

commit sha 9d4818686873846ec6268801b0f38fc72168711b

search: update parser fuzzer harness (#12438)

view details

Dan Adler

commit sha 3f383db8a6757c9616a1bad36fa1c08403d8df0b

Add link to saved searches page in email (#11651) * Add link to saved searches page in email * Add changelog * Update changelog

view details

Dax McDonald

commit sha f04c93047b6317d88d0985730a774a122dc88f04

Add cleanup step to Grafana and Prometheus ignored files (#12428) * Add cleanup step to Grafana and Prometheus ignored files * Handle path err & use const

view details

Keegan Carruthers-Smith

commit sha 971f0eca42806e7ea042e95ef0879c9541feb809

debugproxies: clearer debug logs for watchEndpointEvents (#12427) We log errors for /-/debug endpoint's use of k8s service discovery as debug logs. This can look like real problems in our cluster when you spot the log messages. This commit updates the log message to be more informative, as well as to differentiate between expected errors vs unexpected errors.

view details

Robert Lin

commit sha f350b4fc4b984e4958b009f0d547f0caf15061b8

cmd(server): always build grafana (#12424) * cmd(server): always build grafana * use editor role

view details

Quinn Slack

commit sha c3568c3535688615d2314046f754d13b021b31b8

use new sourcegraphstatic.com host for static assets (#12419) The https://sourcegraphstatic.com site serves content from the `sourcegraph-assets` Google Cloud Storage bucket. We are using this hostname instead of https://storage.googleapis.com/sourcegraph-assets/ because the latter is blocked by some ad blockers, which means our assets are not visible to many of our users. `fastmod https://storage.googleapis.com/sourcegraph-assets/ https://sourcegraphstatic.com/`

view details

Robert Lin

commit sha 2f84b41c3d8919370578cab157dfc9f176f752ad

monitoring: simple support for alert rule 'for' (#12395)

view details

Nick Snyder

commit sha dd4095c8cfbb938b755a6f7cc24d1973f7fe4c96

Update changelog about removing gitolite.blacklist (#12414)

view details

Nick Snyder

commit sha 79ad76143f56c8b175b3b3daa05755ad8c634540

Run code scanning in parallel for Go and JavaScript (#12441)

view details

Nick Snyder

commit sha cd5f9abd6f35d0e7759843a0db4f64a88166c279

replace link to HackerOne (#12440)

view details

push time in 14 days

push eventsourcegraph/about

Rob Rhyne

commit sha 46f198d8a55016ebc1808263aa17247d7870ec6f

Update handbook/product/design/design_process.md

view details

push time in 15 days

Pull request review commentsourcegraph/about

Design handoff process

 While asynchronous communication is a core attribute of remote work, key moments - Tools     - Figma +### Design to engineering handoff++- Design preperation+    - Ensure colors utilize the named color styles vs. the color palette where possible +        - Doing so adds our color style variable name to the code palette so developers do not have to translate hex to scss variables+    - Redline any colors, styles, margins and paddings unique to the designs (not provided by a component)+    - If introducing new colors, type, or other design elements, ask for review by an engineer focused on styles and React components+    - Ensure any illustrations work in both light and dark mode +    - TODO: Determine method of illustration/image exports+
    - TODO: design-engineering review process (probably using Chromatic)
rrhyne

comment created time in 15 days

Pull request review commentsourcegraph/about

Design handoff process

 While asynchronous communication is a core attribute of remote work, key moments       - Schedule a meeting with engineers to discuss the interaction   - Tools       - Figma-- Metrics collection:+- **Design to engineering handoff**+    - Design preperation+        - Ensure colors utilize the named color styles vs. the color palette where possible +            - This adds our color style variable name to the code palette 

I've clarified in the most recent version.

rrhyne

comment created time in 15 days

push eventsourcegraph/about

Rob Rhyne

commit sha cb055ff97ea84194ae8518ce6a043248df91f544

Clarify use of styles vs. colors

view details

push time in 15 days

Pull request review commentsourcegraph/about

Design handoff process

 While asynchronous communication is a core attribute of remote work, key moments       - Schedule a meeting with engineers to discuss the interaction   - Tools       - Figma-- Metrics collection:+- **Design to engineering handoff**+    - Design preperation+        - Ensure colors utilize the named color styles vs. the color palette where possible 

Please feel free to add enhancements like this without asking!

rrhyne

comment created time in 15 days

pull request commentsourcegraph/sourcegraph

Storybook additions

Clean PR is here: https://github.com/sourcegraph/sourcegraph/pull/12418

rrhyne

comment created time in 16 days

PR opened sourcegraph/sourcegraph

Storybook additions 2

Adds text-muted label and will contain other discrepancies required for global component creation in Figma.

+8 -2

0 comment

2 changed files

pr created time in 16 days

create barnchsourcegraph/sourcegraph

branch : storybook-additions-2

created branch time in 16 days

Pull request review commentsourcegraph/sourcegraph

Storybook additions

 add('Text', () => (             </small>         </p> +        <p>+            <label>'Labels'</label> help label things

I think you are right. I saw them as part of the form group but was looking for a stand-alone version to easily compare styles with and to mirror the independent component in Figma for easier viewing.

rrhyne

comment created time in 16 days

PR closed sourcegraph/sourcegraph

Reviewers
Storybook additions

Two small storybook additions text-muted and labels. I needed to see what they looked like for Figma component work.

+30 -46

1 comment

4 changed files

rrhyne

pr closed time in 16 days

pull request commentsourcegraph/sourcegraph

Storybook additions

Thanks, Erik, I inadvertently based this off my last branch. I should take this opportunity to learn to rebase but I'll do that on my time and start a new clean branch and PR to complete this.

rrhyne

comment created time in 16 days

PR opened sourcegraph/sourcegraph

Reviewers
Storybook additions

Two small storybook additions text-muted and labels. I needed to see what they looked like for Figma component work.

+30 -46

0 comment

4 changed files

pr created time in 16 days

create barnchsourcegraph/sourcegraph

branch : storybook-additions

created branch time in 16 days

Pull request review commentsourcegraph/sourcegraph

WIP: Web content styles

                 color: $gray-19;             }         }--        &__web-link {-            color: #1c7cd6;-        }--        &__keyword-text {

@attfarhan I've aligned the color usage between headers on those two pages and the design system within the design system. This link to those components in the design system should solve those questions for you: https://www.figma.com/file/BkY8Ak997QauG0Iu2EqArv/Sourcegraph-Components?node-id=261%3A951

attfarhan

comment created time in 16 days

issue commentsourcegraph/sourcegraph

Add Repository / Update Repository actions unclear

@lguychard just pinging you to see if we can have a look at those links. Can you add a screenshot to show where the links are displayed? I cannot find them in my instance.

rrhyne

comment created time in 16 days

issue closedsourcegraph/sourcegraph

Display warning to users if repository is unavailable to search

Feature request description

When a repository being searched is a fork or it is currently being cloned or indexed, the user is not notified. Searches on that repository may not return results.

For each search, review the current repository status of each repo in the search (resolving repogroups). If a repo is cloning or indexing, display a warning message to the user stating which repository is unavailable for search.

Is your feature request related to a problem? If so, please describe.

Customer feedback:

is there a capability to display a warning or status message? it's not usual to have issues with a large codebase. for example, "we just started indexing a new branch" or "we had a perforce problem so we're reindexing everything from scratch"

https://app.hubspot.com/contacts/2762526/company/693777200

closed time in 16 days

rrhyne

issue commentsourcegraph/sourcegraph

Display warning to users if repository is unavailable to search

Closed as it was addressed in: https://github.com/sourcegraph/sourcegraph/issues/10899

rrhyne

comment created time in 16 days

Pull request review commentsourcegraph/sourcegraph

WIP: Web content styles

                 color: $gray-19;             }         }--        &__web-link {-            color: #1c7cd6;-        }--        &__keyword-text {

@attfarhan I believe they are one off because we are not using them anywhere else yet.

Headers:

  • We are reducing font-weight on all headers throughout web styles.

Link sizes:

  • I don't think we need a style for this. These examples utilize bootstrap and the second one lowers the font size correctly:
<a href='#link' class='btn btn-link'>Link</a>
<a href='#link' class='btn btn-sm btn-link'>Small Link</a>

I'll review the differences of home and repository group page separately.

attfarhan

comment created time in 16 days

pull request commentsourcegraph/about

Add docs on how we style UI

We will strive to mirror the same strategies where possible in Figma, especially these lines:

The best approach is to not reference colors at all and use building blocks that have borders, text colors etc defined. This saves code and makes it easy to maintain design consistency even if we want to change colors in the future. When that is not possible (for example UI contributed by extensions), prefer to reference CSS variables with semantic colors like var(--danger), var(--success), var(--border-color), var(--body-bg) etc.

felixfbecker

comment created time in 17 days

push eventsourcegraph/sourcegraph

Rob Rhyne

commit sha 3b2daf896c94398cfead0af2089e374ee174deea

add public code tag line (#12371) Adds a tag line below the sourcegraph logo to help users understand the differences between cloud and enterprise search.

view details

push time in 17 days

delete branch sourcegraph/sourcegraph

delete branch : add-public-code-tag

delete time in 17 days

PR merged sourcegraph/sourcegraph

Reviewers
add public code tag line

Adds a tag line below the logo to the Cloud application.

image

+18 -44

6 comments

2 changed files

rrhyne

pr closed time in 17 days

issue commentsourcegraph/sourcegraph

Unclear empty state for extension command palette

Will be addressed in https://github.com/sourcegraph/sourcegraph/issues/11872

nicksnyder

comment created time in 17 days

push eventsourcegraph/sourcegraph

rob rhyne

commit sha 73f107e78cd961c23cccb26aba672fa95413bdad

remove duplicate styles

view details

push time in 17 days

Pull request review commentsourcegraph/sourcegraph

add public code tag line

 export const SearchPage: React.FunctionComponent<Props> = props => {     return (         <div className="search-page">             <BrandLogo className="search-page__logo" isLightTheme={props.isLightTheme} />+            {props.isSourcegraphDotCom ? <div className="search-page__cloud-tag-line">Search public code</div> : null}

Should be fixed.

rrhyne

comment created time in 17 days

PR opened sourcegraph/about

Design handoff process

Start of the documentation for the design handoff process documentation. Let's use this draft PR to communicate on what should be included here.

+50 -8

0 comment

1 changed file

pr created time in 17 days

create barnchsourcegraph/about

branch : design-handoff-process

created branch time in 17 days

pull request commentsourcegraph/sourcegraph

add public code tag line

Should this maybe be the input placeholder instead? In interactive mode, we also have a placeholder that says "Search code...", the tagline feels a bit redundant to that. The fact that plain text mode does not have a placeholder is an inconsistency that we should solve regardless I think.

I considered this, but no, a placeholder will not solve the issue. Marketing would like to separate the enterprise product from the cloud product so that expectations are set appropriately.

I agree with the placeholder inconsistency you mention and do feel that will be redundant. Perhaps now the answer is to remove the placeholder for cloud environments?

rrhyne

comment created time in 17 days

push eventsourcegraph/sourcegraph

rob rhyne

commit sha 73c2963e619beb53cc66c344be688053425a2d44

code style

view details

rob rhyne

commit sha f9a7e3acf265d7a2d091b2d86e699316dc09e01a

Merge branch 'add-public-code-tag' of github.com:sourcegraph/sourcegraph into add-public-code-tag

view details

push time in 17 days

pull request commentsourcegraph/sourcegraph

add public code tag line

@eseliger screenshot added to PR.

rrhyne

comment created time in 17 days

push eventsourcegraph/sourcegraph

Eric Fritz

commit sha b769ef6faeda831f06c3d8f56882a48ef76a15f6

codeintel: Reduce correlation memory usage by 50% (#11977)

view details

Pooja Jain

commit sha 25459ec7aff5e2111b8bb7f5139a52e05c41b55a

Remove fancy quotes on homepage (#12061) * Remove fancy quotes on homepage * Replace with normal quotes instead Co-authored-by: Pooja Jsin <poojajain@poojas-mbp.attlocal.net>

view details

Farhan Attamimi

commit sha 5d86b8b46cefcbe78f24ff9f0aec3546cdd1ac02

repogroup pages: read from settings (#11923)

view details

Rob Rhyne

commit sha 41db04954c28180792defbc5cf0496c24e08ef37

Repo group dark mode (#12078)

view details

Rijnard van Tonder

commit sha bb1daacb6d09a77a9337040361baba439d661072

search: remove dead function RepoSearch (#12081)

view details

Asdine El Hrychy

commit sha cab1a64cfdbe0c930cccdc9fd550e60913972b60

cloud: use the cloned column to filter by clone status (#11932)

view details

renovate[bot]

commit sha 7b5cbd9dfcaa5e279ff8f6294d58e1f0dbecfa4b

Update dependency highlight.js to ^10.1.1 (#11858) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Erik Seliger <erikseliger@me.com>

view details

Asdine El Hrychy

commit sha c9224061da6a614e0e15d04c5aa057dccda45dd1

Delete cloning tab from the site-admin repositories page (#12043)

view details

Eric Fritz

commit sha b459aa491f1fadfa53b07667cfcaf99cc15fe0ee

codeintel: Add enabled flag to lsif_indexable_repositories (#12062)

view details

Ryan Slade

commit sha d3dbb2811f1832206be7c7c0c9848c0012a6d369

repo-updater: Consistent use of MustRegister (#12094) * repo-updater: Consistent use of MustRegister Make it a method of each metric type. Also moved "handler" closer to where it's used. * No need to run server in goroutine

view details

Christina Forney

commit sha 750c90ffcf65fe1bf80555ccefe8987f1c94f8b5

Fixes #12057 search example page copy edits (#12084)

view details

Felix Becker

commit sha 58124b94ad83ab3121eca9450f5fedda537bec3a

Serve mock index.html and window.context (#12091)

view details

Felix Becker

commit sha 7889886f2cd906deccc14f88f5afa18fb3c28b39

Add integration tests to CI (#12096)

view details

Simon

commit sha 4623f8c9a52da3e4d393666f6f725a9bf224f1fa

typesafe stubbing of graphQL requests for integration tests (#11983) * WIP first iteration of type generation of all queries * WIP: fixed nested list in the parser + gave operations unique names * WIP: partially migrated search tests to have typesafe responses, operations in shared is the last standing issue * refactored tests to use typechecked graphql stubbing * fixed eslint issues * runt prettier on generated sources * changed override to be a function + PR comments Co-authored-by: Marek <marekz@gmail.com> * rebased * make process fail if we have an error during extraction * added site admin activation status

view details

ᴜɴᴋɴᴡᴏɴ

commit sha 985c423d2de6eac234f2aabd6ad1b5ecfb2dbea3

gqltest: add search integration tests (#12085)

view details

Erik Seliger

commit sha f02940d197e58d0aaefdfcea7098017bb113adbd

Don't use goacc on master branch to fix coverage reporting (#12112)

view details

renovate[bot]

commit sha bccd65c0c9764f89ab5b1a871c4c5e01cba008ac

Update dependency graphql to ^14.7.0 (#11975) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha 8f01e217cdd08a5a2fc327bce53ff0c86579ba65

Update dependency json-schema-to-typescript to v9 (#12115) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Erik Seliger

commit sha f7abecdfb7d9d0533f1c5e2903fb291f0ce57d94

Revert original go-acc PR (#12122) * Revert "Don't use goacc on master branch to fix coverage reporting (#12112)" This reverts commit f02940d197e58d0aaefdfcea7098017bb113adbd. * Revert "ci: enable go-acc on default branch (#11887)" This reverts commit 49d50f4236e7589e7c1de9eb4a3086284d00229e.

view details

Eric Fritz

commit sha 5ba8bfa1739f364cf59a17264edaf1d18bb9f520

Bump recommended src-cli version to 3.16.0. (#12059)

view details

push time in 17 days

push eventsourcegraph/sourcegraph

rob rhyne

commit sha 652c0cdcca6881d1f8919b8d1885bc0bc3f68259

Show only if dotcommode

view details

push time in 17 days

PR opened sourcegraph/sourcegraph

add public code tag line

<!-- Reminder: Have you updated the changelog and relevant docs (user docs, architecture diagram, etc) ? -->

+18 -2

0 comment

2 changed files

pr created time in 17 days

push eventsourcegraph/sourcegraph

rob rhyne

commit sha a1cd2d0289bfed7ea2346a7b20e529b01a2fca8c

add public code tag line

view details

push time in 17 days

create barnchsourcegraph/sourcegraph

branch : add-public-code-tag

created branch time in 17 days

pull request commentsourcegraph/sourcegraph

Add private code CTAs

Looks great. Ready to launch, IMO.

attfarhan

comment created time in 18 days

Pull request review commentsourcegraph/sourcegraph

Add private code CTAs

+import { storiesOf } from '@storybook/react'+import { PrivateCodeCta } from './PrivateCodeCta'+import webStyles from '../../SourcegraphWebApp.scss'+import React from 'react'++const { add } = storiesOf('web/PrivateCodeCta', module).addDecorator(story => (+    <>+        <style>{webStyles}</style>+        <div className="theme-light p-4">{story()}</div>+    </>+))

Added in this commit:

https://github.com/sourcegraph/sourcegraph/pull/12288/commits/58a1daf0116d1f2a505b6f96ccc58477cd8750c0

attfarhan

comment created time in 18 days

push eventsourcegraph/sourcegraph

rob rhyne

commit sha 58a1daf0116d1f2a505b6f96ccc58477cd8750c0

add figma link to story

view details

push time in 18 days

pull request commentsourcegraph/sourcegraph

Add private code CTAs

The campaign's layout has a content section that does not respect the two column layout:

image

Ask questions and share feedback should be part of the col-8 above it.

attfarhan

comment created time in 21 days

Pull request review commentsourcegraph/sourcegraph

Add private code CTAs

 export const RepogroupPage: React.FunctionComponent<RepogroupPageProps> = (props                     ))}                 </div>                 <div className="repogroup-page__column col-xs-12 col-lg-5">-                    <div className="repogroup-page__repo-card card">-                        <h2 className="font-weight-normal">-                            <SourceRepositoryMultipleIcon className="icon-inline mr-2" />-                            Repositories-                        </h2>-                        <p>-                            Using the syntax{' '}-                            <span className="text-monospace">-                                <span className="repogroup-page__keyword-text">repogroup:</span>-                                {props.repogroupMetadata.name}-                            </span>{' '}-                            in a query will search these repositories:-                        </p>-                        <div className="repogroup-page__repo-list row">-                            <div className="col-lg-6">-                                {repogroupRepoList?.slice(0, Math.ceil(repogroupRepoList.length / 2)).map(repo => (-                                    <RepoLink key={repo} repo={repo} />-                                ))}-                            </div>-                            <div className="col-lg-6">-                                {repogroupRepoList-                                    ?.slice(Math.ceil(repogroupRepoList.length / 2), repogroupRepoList.length)-                                    .map(repo => (+                    <div className="order-1-lg order-2-xs">+                        <PrivateCodeCta />+                    </div>+                    <div className="order-2-lg order-1-xs">+                        <div className="repogroup-page__repo-card card">+                            <h2 className="font-weight-normal">

To meet the design spec. We should address this as part of .web-styles. I've added to #12303

attfarhan

comment created time in 21 days

Pull request review commentsourcegraph/sourcegraph

Add private code CTAs

+.private-code-cta {+    padding: 1.5rem;+    border-radius: 3px;+    box-shadow: 0px 4px 8px rgba(0, 0, 0, 0.07);+    background: #1d2535;

I'd propose in web/src/global-styles/web-content.scss, all under a global class .web-content.

This is going to take a few hours and we are hoping to get this branch pushed out to cloud so we can send traffic from about to /search. Can we address this separately as part of #12303?

attfarhan

comment created time in 21 days

Pull request review commentsourcegraph/sourcegraph

Add private code CTAs

+.private-code-cta {+    padding: 1.5rem;+    border-radius: 3px;+    box-shadow: 0px 4px 8px rgba(0, 0, 0, 0.07);+    background: #1d2535;

To be honest, I'm not sure. Can we move this discussion outside the PR now that the colors are properly using variables?

attfarhan

comment created time in 21 days

Pull request review commentsourcegraph/sourcegraph

Add private code CTAs

+.private-code-cta {+    padding: 1.5rem;+    border-radius: 3px;+    box-shadow: 0px 4px 8px rgba(0, 0, 0, 0.07);

Should be fixed with the latest commit.

attfarhan

comment created time in 21 days

push eventsourcegraph/sourcegraph

rob rhyne

commit sha d947dad0853ba67265f0e470a25be5426e9a054f

adjust default shadows

view details

push time in 21 days

Pull request review commentsourcegraph/sourcegraph

Add private code CTAs

 export const SearchPage: React.FunctionComponent<Props> = props => {                 {views && <ViewGrid {...props} className="mt-5" views={views} />}             </div>             {props.isSourcegraphDotCom && props.showRepogroupHomepage && (-                <div className="search-page__repogroup-content container-fluid mt-5">-                    <div className="d-flex align-items-baseline mb-3">-                        <h3 className="search-page__help-content-header mr-2">Search in repository groups</h3>-                        <span className="text-monospace font-weight-normal search-page__lang-ref">-                            <span className="search-page__keyword-text">repogroup:</span>-                            <i>name</i>-                        </span>-                    </div>-                    <div className="search-page__repogroup-list-cards">-                        {repogroupList.map(repogroup => (-                            <div className="d-flex" key={repogroup.name}>-                                <img className="search-page__repogroup-list-icon mr-2" src={repogroup.homepageIcon} />-                                <div className="d-flex flex-column">-                                    <Link-                                        to={repogroup.url}-                                        className="search-page__repogroup-listing-title search-page__web-link font-weight-bold"-                                    >-                                        {repogroup.title}-                                    </Link>-                                    <p className="search-page__repogroup-listing-description">-                                        {repogroup.homepageDescription}-                                    </p>+                <>+                    <div className="search-page__repogroup-content container-fluid mt-5">+                        <div className="d-flex align-items-baseline mb-3">+                            <h3 className="search-page__help-content-header mr-2">Search in repository groups</h3>+                            <span className="text-monospace font-weight-normal search-page__lang-ref">+                                <span className="search-page__keyword-text">repogroup:</span>+                                <i>name</i>+                            </span>+                        </div>+                        <div className="search-page__repogroup-list-cards">+                            {repogroupList.map(repogroup => (+                                <div className="d-flex" key={repogroup.name}>+                                    <img+                                        className="search-page__repogroup-list-icon mr-2"+                                        src={repogroup.homepageIcon}+                                    />+                                    <div className="d-flex flex-column">+                                        <Link+                                            to={repogroup.url}+                                            className="search-page__repogroup-listing-title search-page__web-link font-weight-bold"+                                        >+                                            {repogroup.title}+                                        </Link>+                                        <p className="search-page__repogroup-listing-description">+                                            {repogroup.homepageDescription}+                                        </p>+                                    </div>                                 </div>-                            </div>-                        ))}-                    </div>-                    <div className="search-page__help-content row mt-5">-                        <div className="search-page__example-searches col-xs-12 col-lg-5 col-xl-6">-                            <h3 className="search-page__help-content-header">Example searches</h3>-                            <ul className="list-group-flush p-0 mt-2">-                                <li className="list-group-item px-0 pt-3 pb-2">-                                    <Link-                                        to="/search?q=lang:javascript+alert%28:%5Bvariable%5D%29&patternType=structural"-                                        className="text-monospace mb-2"-                                    >-                                        <span className="search-page__keyword-text">lang:</span>javascript-                                        alert(:[variable])-                                    </Link>{' '}-                                    <p className="mt-2">-                                        Find usages of the alert() method that displays an alert box.-                                    </p>-                                </li>-                                <li className="list-group-item px-0 pt-3 pb-2">-                                    <Link-                                        to="/search?q=lang:python+from+%5CB%5C.%5Cw%2B+import+%5Cw%2B&patternType=regexp"-                                        className="text-monospace mb-2"-                                    >-                                        <span className="search-page__keyword-text">lang:</span>python from \B\.\w+-                                        import \w+-                                    </Link>{' '}-                                    <p className="mt-2">-                                        Search for explicit imports with one or more leading dots that indicate current-                                        and parent packages involved.-                                    </p>-                                </li>-                                <li className="list-group-item px-0 pt-3 pb-2">-                                    <Link-                                        to='/search?q=repo:%5Egithub%5C.com/golang/go%24+type:diff+after:"1+week+ago"&patternType=literal"'-                                        className="text-monospace mb-2"-                                    >-                                        <span className="search-page__keyword-text">repo:</span>-                                        ^github\.com/golang/go$ <span className="search-page__keyword-text">type:</span>-                                        diff <span className="search-page__keyword-text">after:</span>"1 week ago"-                                    </Link>{' '}-                                    <p className="mt-2">-                                        Browse diffs for recent code changes in the 'golang/go' GitHub repository.-                                    </p>-                                </li>-                                <li className="list-group-item px-0 pt-3 pb-2">-                                    <Link-                                        to='/search?q=file:pod.yaml+content:"kind:+ReplicationController"&patternType=literal'-                                        className="text-monospace mb-2"-                                    >-                                        <span className="search-page__keyword-text">file:</span>pod.yaml{' '}-                                        <span className="search-page__keyword-text">content:</span>"kind:-                                        ReplicationController"-                                    </Link>{' '}-                                    <p className="mt-2">-                                        Use a ReplicationController configuration to ensure specified number of pod-                                        replicas are running at any one time.-                                    </p>-                                </li>-                            </ul>+                            ))}                         </div>-                        <div className="search-page__search-a-language col-xs-12 col-md-6 col-lg-3 col-xl-2">-                            <div className="align-items-baseline mb-4">-                                <h3 className="search-page__help-content-header">-                                    Search a language{' '}-                                    <span className="text-monospace font-weight-normal search-page__lang-ref">-                                        <span className="search-page__keyword-text ml-1">lang:</span>-                                        <i className="search-page__keyword-value-text">name</i>-                                    </span>-                                </h3>+                        <div className="search-page__help-content row mt-5">+                            <div className="search-page__example-searches col-xs-12 col-lg-5 col-xl-6">+                                <h3 className="search-page__help-content-header">Example searches</h3>+                                <ul className="list-group-flush p-0 mt-2">+                                    <li className="list-group-item px-0 pt-3 pb-2">+                                        <Link+                                            to="/search?q=lang:javascript+alert%28:%5Bvariable%5D%29&patternType=structural"+                                            className="text-monospace mb-2"+                                        >+                                            <span className="search-page__keyword-text">lang:</span>javascript+                                            alert(:[variable])+                                        </Link>{' '}+                                        <p className="mt-2">+                                            Find usages of the alert() method that displays an alert box.+                                        </p>+                                    </li>+                                    <li className="list-group-item px-0 pt-3 pb-2">+                                        <Link+                                            to="/search?q=lang:python+from+%5CB%5C.%5Cw%2B+import+%5Cw%2B&patternType=regexp"+                                            className="text-monospace mb-2"+                                        >+                                            <span className="search-page__keyword-text">lang:</span>python from \B\.\w++                                            import \w++                                        </Link>{' '}+                                        <p className="mt-2">+                                            Search for explicit imports with one or more leading dots that indicate+                                            current and parent packages involved.+                                        </p>+                                    </li>+                                    <li className="list-group-item px-0 pt-3 pb-2">+                                        <Link+                                            to='/search?q=repo:%5Egithub%5C.com/golang/go%24+type:diff+after:"1+week+ago"&patternType=literal"'+                                            className="text-monospace mb-2"+                                        >+                                            <span className="search-page__keyword-text">repo:</span>+                                            ^github\.com/golang/go${' '}+                                            <span className="search-page__keyword-text">type:</span>+                                            diff <span className="search-page__keyword-text">after:</span>"1 week ago"+                                        </Link>{' '}+                                        <p className="mt-2">+                                            Browse diffs for recent code changes in the 'golang/go' GitHub repository.+                                        </p>+                                    </li>+                                    <li className="list-group-item px-0 pt-3 pb-2">+                                        <Link+                                            to='/search?q=file:pod.yaml+content:"kind:+ReplicationController"&patternType=literal'+                                            className="text-monospace mb-2"+                                        >+                                            <span className="search-page__keyword-text">file:</span>pod.yaml{' '}+                                            <span className="search-page__keyword-text">content:</span>"kind:+                                            ReplicationController"+                                        </Link>{' '}+                                        <p className="mt-2">+                                            Use a ReplicationController configuration to ensure specified number of pod+                                            replicas are running at any one time.+                                        </p>+                                    </li>+                                </ul>                             </div>-                            <div className="d-flex row-cols-2 mt-2">-                                <div className="d-flex flex-column col mr-auto">-                                    {homepageLanguageList-                                        .slice(0, Math.ceil(homepageLanguageList.length / 2))-                                        .map(language => (-                                            <Link-                                                className="search-page__web-link search-page__lang-link text-monospace mb-3"-                                                to={`/search?q=lang:${language.filterName}`}-                                                key={language.name}-                                            >-                                                {language.name}-                                            </Link>-                                        ))}+                            <div className="search-page__search-a-language col-xs-12 col-md-6 col-lg-3 col-xl-2">+                                <div className="align-items-baseline mb-4">+                                    <h3 className="search-page__help-content-header">+                                        Search a language{' '}+                                        <span className="text-monospace font-weight-normal search-page__lang-ref">+                                            <span className="search-page__keyword-text ml-1">lang:</span>+                                            <i className="search-page__keyword-value-text">name</i>+                                        </span>+                                    </h3>                                 </div>-                                <div className="d-flex flex-column col">-                                    {homepageLanguageList-                                        .slice(Math.ceil(homepageLanguageList.length / 2), homepageLanguageList.length)-                                        .map(language => (-                                            <Link-                                                className="search-page__web-link search-page__lang-link text-monospace mb-3"-                                                to={`/search?q=lang:${language.filterName}`}-                                                key={language.name}-                                            >-                                                {language.name}-                                            </Link>-                                        ))}+                                <div className="d-flex row-cols-2 mt-2">+                                    <div className="d-flex flex-column col mr-auto">+                                        {homepageLanguageList+                                            .slice(0, Math.ceil(homepageLanguageList.length / 2))+                                            .map(language => (+                                                <Link+                                                    className="search-page__web-link search-page__lang-link text-monospace mb-3"+                                                    to={`/search?q=lang:${language.filterName}`}+                                                    key={language.name}+                                                >+                                                    {language.name}+                                                </Link>+                                            ))}+                                    </div>+                                    <div className="d-flex flex-column col">+                                        {homepageLanguageList+                                            .slice(+                                                Math.ceil(homepageLanguageList.length / 2),+                                                homepageLanguageList.length+                                            )+                                            .map(language => (+                                                <Link+                                                    className="search-page__web-link search-page__lang-link text-monospace mb-3"+                                                    to={`/search?q=lang:${language.filterName}`}+                                                    key={language.name}+                                                >+                                                    {language.name}+                                                </Link>+                                            ))}+                                    </div>+                                </div>+                            </div>+                            <div className="search-page__search-syntax col-xs-12 col-md-6  col-lg-4">+                                <h3 className="search-page__help-content-header">Search syntax</h3>+                                <div className="mt-3 row">+                                    <dl className="col-xs-12 col-lg-6 mb-4">+                                        <dt className="search-page__help-content-subheading">+                                            <h5>Common search keywords</h5>+                                        </dt>+                                        <dd className="text-monospace">+                                            <p>repo:my/repo</p>+                                        </dd>+                                        <dd className="text-monospace">+                                            <p>repo:github.com/myorg/</p>+                                        </dd>+                                        <dd className="text-monospace">+                                            <p>file:my/file</p>+                                        </dd>+                                        <dd className="text-monospace">+                                            <p>lang:javascript</p>+                                        </dd>+                                        <dt className="search-page__help-content-subheading mt-5">+                                            <h5>Diff/commit search keywords</h5>+                                        </dt>+                                        <dd className="text-monospace">+                                            <p>type:diff or type:commit</p>+                                        </dd>+                                        <dd className="text-monospace">+                                            <p>after:"2 weeks ago"</p>+                                        </dd>+                                        <dd className="text-monospace">+                                            <p>author:alice@example.com</p>+                                        </dd>{' '}+                                        <dd className="text-monospace">+                                            <p>repo:r@*refs/heads/ (all branches)</p>+                                        </dd>+                                    </dl>+                                    <dl className="col-xs-12 col-xl-6">+                                        <dt className="search-page__help-content-subheading">+                                            <h5>Finding matches</h5>+                                        </dt>+                                        <dd>+                                            <p>+                                                <strong>Regexp:</strong>{' '}+                                                <span className="text-monospace">(read|write)File</span>+                                            </p>+                                        </dd>{' '}+                                        <dd>+                                            <p>+                                                <strong>Exact:</strong>{' '}+                                                <span className="text-monospace">"fs.open(f)"</span>+                                            </p>+                                        </dd>+                                        <dd>+                                            <p>+                                                <strong>Structural:</strong>{' '}+                                                <span className="text-monospace">if(:[my_match])</span>+                                            </p>+                                        </dd>+                                    </dl>                                 </div>                             </div>                         </div>-                        <div className="search-page__search-syntax col-xs-12 col-md-6  col-lg-4">-                            <h3 className="search-page__help-content-header">Search syntax</h3>-                            <div className="mt-3 row">-                                <dl className="col-xs-12 col-lg-6 mb-4">-                                    <dt className="search-page__help-content-subheading">-                                        <h5>Common search keywords</h5>-                                    </dt>-                                    <dd className="text-monospace">-                                        <p>repo:my/repo</p>-                                    </dd>-                                    <dd className="text-monospace">-                                        <p>repo:github.com/myorg/</p>-                                    </dd>-                                    <dd className="text-monospace">-                                        <p>file:my/file</p>-                                    </dd>-                                    <dd className="text-monospace">-                                        <p>lang:javascript</p>-                                    </dd>-                                    <dt className="search-page__help-content-subheading mt-5">-                                        <h5>Diff/commit search keywords</h5>-                                    </dt>-                                    <dd className="text-monospace">-                                        <p>type:diff or type:commit</p>-                                    </dd>-                                    <dd className="text-monospace">-                                        <p>after:"2 weeks ago"</p>-                                    </dd>-                                    <dd className="text-monospace">-                                        <p>author:alice@example.com</p>-                                    </dd>{' '}-                                    <dd className="text-monospace">-                                        <p>repo:r@*refs/heads/ (all branches)</p>-                                    </dd>-                                </dl>-                                <dl className="col-xs-12 col-xl-6">-                                    <dt className="search-page__help-content-subheading">-                                        <h5>Finding matches</h5>-                                    </dt>-                                    <dd>-                                        <p>-                                            <strong>Regexp:</strong>{' '}-                                            <span className="text-monospace">(read|write)File</span>-                                        </p>-                                    </dd>{' '}-                                    <dd>-                                        <p>-                                            <strong>Exact:</strong> <span className="text-monospace">"fs.open(f)"</span>-                                        </p>-                                    </dd>-                                    <dd>-                                        <p>-                                            <strong>Structural:</strong>{' '}-                                            <span className="text-monospace">if(:[my_match])</span>-                                        </p>-                                    </dd>-                                </dl>+                        <div className="row justify-content-center">+                            <div className="mx-auto col-sm-12 col-md-8 col-lg-8 col-xl-6">+                                <PrivateCodeCta className="private-code-cta--search-page" />

Should be fixed now.

attfarhan

comment created time in 21 days

push eventsourcegraph/sourcegraph

rob rhyne

commit sha 0a8f11fbd658e1cad671565479ea2ece92a5e3de

add no referrer

view details

rob rhyne

commit sha 0f242ec4737604deb38867818f5a450dbb0cb47b

use variables to define colors, remove unused styles

view details

rob rhyne

commit sha 2e800fb98bb6311648fbe6cfebcfa7368dfd04cf

prettier

view details

push time in 21 days

Pull request review commentsourcegraph/sourcegraph

Add private code CTAs

+.private-code-cta {+    padding: 1.5rem;+    border-radius: 3px;+    box-shadow: 0px 4px 8px rgba(0, 0, 0, 0.07);+    background: #1d2535;

I've filed a ticket to catalog the technical debt these styles have introduced: https://github.com/sourcegraph/sourcegraph/issues/12303

If you specify where architecture for where the styles should live and how to apply them to individual pages, I'm happy to do the work to consolidate these three components.

attfarhan

comment created time in 21 days

issue openedsourcegraph/sourcegraph

Remove duplicate styles

The addition of 'web' oriented styles have been added to the following components and their scss files and require consolidation once they are properly defined within the global styles:

SearchPage.tsx & SearchPage.scss RepositoryGroupPage.tsx & RepositoryGroupPage.scss PrivateCode.tsx & PrivateCode.scss

created time in 21 days

Pull request review commentsourcegraph/sourcegraph

Add private code CTAs

+.private-code-cta {+    padding: 1.5rem;+    border-radius: 3px;+    box-shadow: 0px 4px 8px rgba(0, 0, 0, 0.07);+    background: #1d2535;

This is $grey-21 and the other colors should likewise be to spec. I think the problem here is difficulty in moving from designs to code when these items are not yet properly componentized. Additionally, Figma knows nothing about our variable names and does not describe them for developers when they review the files. I'll try to figure out a delivery solution to solve this issue or start displaying them in the redlines.

I'm translating them now.

attfarhan

comment created time in 21 days

Pull request review commentsourcegraph/sourcegraph

Add private code CTAs

+.private-code-cta {+    padding: 1.5rem;+    border-radius: 3px;+    box-shadow: 0px 4px 8px rgba(0, 0, 0, 0.07);

The default shadow is really agressive. I would like to configure it to the values specified in the CSS: box-shadow: 0px 4px 8px rgba(0, 0, 0, 0.07);

Where should that happen?

attfarhan

comment created time in 21 days

Pull request review commentsourcegraph/sourcegraph

Add private code CTAs

+<svg width="68" height="115" viewBox="0 0 68 115" fill="none" xmlns="http://www.w3.org/2000/svg">

Good catch, I've removed.

attfarhan

comment created time in 21 days

push eventsourcegraph/sourcegraph

rob rhyne

commit sha ace299b3f4b02802955404d972e91e3fbe1c57f8

remove duplicate illustration

view details

push time in 21 days

push eventsourcegraph/sourcegraph

rob rhyne

commit sha 2b1310398e8e4b600542c70cdc435e59cd6ecbef

add tag for ga tracking

view details

rob rhyne

commit sha 26c56cea86c7e2f3fc2331c4884e7a83933a1575

add target blank to install now

view details

push time in 21 days

push eventsourcegraph/sourcegraph

rob rhyne

commit sha 2fad4d1725d7736466e074e7312f368dd9b9d11c

small improvement to breakpoints on CTA

view details

rob rhyne

commit sha 3fc8d621382c6e1ddfbc10f39b4dd1705a1b526f

prettier

view details

push time in 21 days

push eventsourcegraph/sourcegraph

rob rhyne

commit sha 102734d9ebc6c145c2a413a3ed9374329fe37c63

design updates * Add margins to the home page CTA and fix size at various break points * Corrected illustration in Figma to be compatible with both light and dark * Dark mode text is now specified correctly on the campaign's page * Campaigns page CTA wraps on md sizes to avoid being squashed * CTA background is not white

view details

push time in 21 days

Pull request review commentsourcegraph/about

Formatting and adding final review section

 While asynchronous communication is a core attribute of remote work, key moments  ## Process segments -- Ideation-  - This is generally represented by a kickoff meeting with interested parties. Kickoff meetings should generally include representatives of the following parties:-      - The product manager-      - Developers working on the project-      - Designers-      - Sales, ops and customer engineering staff who have insight into how this affects users-      - Customers if available-      - Stakeholders as required-  - Tools-      - We are experimenting with [miro.com](https://miro.com/) as an ideation tool-      - Figma.com can be used to generate mood boards+### Ideation++- This is generally represented by a kickoff meeting with interested parties. Kickoff meetings should generally include representatives of the following parties:+    - The product manager+    - Developers working on the project+    - Designers+    - Sales, ops and customer engineering staff who have insight into how this affects users+    - Customers if available+    - Stakeholders as required+- Tools+    - We are experimenting with [miro.com](https://miro.com/) as an ideation tool+    - Figma.com can be used to generate mood boards - Research-  - Interview internal users-      - As our users are developers, Sourcegraph developers make great interview subjects. However, we need to acknowledge that they do have biases about features and this research must be augmented-  - Interview external users-      - Where the project requires and time permits, conduct research with these users to inform your designs-  - Customer requests and support tickets-      - Our users are passionate and provide excellent feedback. Each project should utilize our collections of this feedback in [Productboard](https://sourcegraph.productboard.com/)-  - Analogous designs-  - Competitive designs-  - Usability tests-    - When updating existing product features, first conduct usability tests to inform redesign decisions-  - Process-      - A GitHub issue should be created to track the work-      - Research is conducted according to requirements-      - Findings publishing and review-        - Findings should be detailed in a Google doc and announced in the corresponding team channel or #product on Slack-        - Findings should contain a clear summary, links to resources and supporting data-        - Conduct a synchronous review meeting with key stakeholders based on the size of project or importance of findings-      - Schedule and conduct a presentation meeting with stakeholders where necessary-  - Tools-      - Google Docs-      - Google Forms for polls-      - UserTesting.com-      - Maze.design-- Wireframes-  - Wireframes should utilize the Sourcegraph Figma component system-  - Wireframes should generally utilize realistic data and text for each element. In cases where many elements are required, ‘lorem epsum’ placeholder text will suffice if the initial or prominent elements are real data.-  - Process-      - A GitHub issue should be created to track the work-          - Label the issue with the design and/or ux label-          - TBD - how do we replicate pull request reviewers?-      - Wireframes are produced in Figma-      - Wireframes are announced in Slack and linked in the GitHub issue well before they are complete for review-      - Wireframes are hallway tested with internal users and product managers-      - Schedule and conduct a presentation meeting-      - Stakeholders will approve the GitHub issue indicating the designs are ready for the next phase-  - Checklist-      - Ensure designs meet Jacob Nielsen's [ten usability heuristics](https://www.nngroup.com/articles/ten-usability-heuristics/)+- Interview internal users+    - As our users are developers, Sourcegraph developers make great interview subjects. However, we need to acknowledge that they do have biases about features and this research must be augmented+- Interview external users+    - Where the project requires and time permits, conduct research with these users to inform your designs+- Customer requests and support tickets+    - Our users are passionate and provide excellent feedback. Each project should utilize our collections of this feedback in [Productboard](https://sourcegraph.productboard.com/)+- Analogous designs+- Competitive designs+- Usability tests+  - When updating existing product features, first conduct usability tests to inform redesign decisions+- Process+    - A GitHub issue should be created to track the work+    - Research is conducted according to requirements+    - Findings publishing and review+      - Findings should be detailed in a Google doc and announced in the corresponding team channel or #product on Slack+      - Findings should contain a clear summary, links to resources and supporting data+      - Conduct a synchronous review meeting with key stakeholders based on the size of project or importance of findings+    - Schedule and conduct a presentation meeting with stakeholders where necessary+- Tools+    - Google Docs+    - Google Forms for polls+    - UserTesting.com+    - Maze.design++### Wireframes++- Wireframes should utilize the Sourcegraph Figma component system+- Wireframes should generally utilize realistic data and text for each element. In cases where many elements are required, ‘lorem epsum’ placeholder text will suffice if the initial or prominent elements are real data.+- Process+    - A GitHub issue should be created to track the work+        - Label the issue with the design and/or ux label+        - TBD - how do we replicate pull request reviewers?+    - Wireframes are produced in Figma+    - Wireframes are announced in Slack and linked in the GitHub issue well before they are complete for review+    - Wireframes are hallway tested with internal users and product managers+    - Schedule and conduct a presentation meeting+    - Stakeholders will approve the GitHub issue indicating the designs are ready for the next phase+- Checklist+    - Ensure designs meet Jacob Nielsen's [ten usability heuristics](https://www.nngroup.com/articles/ten-usability-heuristics/)+    - Has the change’s effect on the CLI been considered?+        - Does the language in the UI map to the language in the CLI?+    - Enterprise / Cloud+    - Signed in vs. anonymous user+    - User permissions+    - Interactive mode / plain text mode+    - TBD - add a standard UX checklist+- Tools+    - Figma++### Testing++- Process+    - A GitHub issue should be created to track the work+    - Testing is conducted according to requirements+    - Publish testing results summary to google drive+    - Announce results in slack+    - Create a GitHub issue to address items in the test results+- Tools+    - Maze.design+    - UserTesting.org++### Visual design++- Visual design should utilize the Sourcegraph’s Figma based component system+- Dark compositions will be created for each major design+- If new components are required, components will be created in the file itself, not the component system+- Improvements to the Sourcegraph user experience should consider the following in every change:       - Has the change’s effect on the CLI been considered?-          - Does the language in the UI map to the language in the CLI?+      - Does the language in the UI map to the language in the CLI?+      - Does the documentation reflect the change?+      - Light mode / Dark mode       - Enterprise / Cloud       - Signed in vs. anonymous user       - User permissions       - Interactive mode / plain text mode-      - TBD - add a standard UX checklist-  - Tools-      - Figma-- Testing-  - Process-      - A GitHub issue should be created to track the work-      - Testing is conducted according to requirements-      - Publish testing results summary to google drive-      - Announce results in slack-      - Create a GitHub issue to address items in the test results-  - Tools-      - Maze.design-      - UserTesting.org-- Visual design-  - Visual design should utilize the Sourcegraph’s Figma based component system-  - Dark compositions will be created for each major design-  - If new components are required, components will be created in the file itself, not the component system-  - Improvements to the Sourcegraph user experience should consider the following in every change:-        - Has the change’s effect on the CLI been considered?-        - Does the language in the UI map to the language in the CLI?-        - Does the documentation reflect the change?-        - Light mode / Dark mode-        - Enterprise / Cloud-        - Signed in vs. anonymous user-        - User permissions-        - Interactive mode / plain text mode-  - Process-      - A GitHub issue should be created to track the work-      - Designs are produced in Figma-      - Designs will be announced in Slack and linked in the GitHub issue well before they are complete for review-      - Ensure designs meet the visual design checklist:-        - Ensure spacing is consistent and matches the 8pt grid system-        - Ensure text, colors and other sytles match existing styles, if possible. -          - Introduce new text styles only if really necessary.-          - If adding new styles, ensure that they meet the accessibility standards and add them to the design system -        - Review designs for accessability:-          - Color blind check-          - Contrast check should meet AA standard for small text-      - Schedule and conduct a design presentation meeting if the size of the project requires-      - Receive signoff from stakeholders-      - If components were created in the visual design process, when the designs are signed off on, those components will be moved to the Sourcegraph component system-      - Prepare redlines or an interaction delivery writeup for the engineers. Consider the following:-          - Margin and padding-          - Animation-          - Links and hover states-      - Describe expected behavior of layout for tablet and moble screensizes-        - Due to the low number of mobile and table visitors (< 3%) design comps for these sizes are generally not required -      - Schedule a meeting with engineers to discuss the interaction-  - Tools-      - Figma-- Metrics collection:-  - In the RFC process, the definition of success will include items which can be measured and evaluated-  - Involve the business operations team in determining what metrics to track and how they are tracked-  - Work with engineers to add the required eventLog tracking-  - Tools-      - Looker-      - Google analytics-- Refinement-  - Designers will review metrics and determine if their designs are meeting objectives set for them.-  - If areas for improvement are found, tickets will be created to document the change required to improve the issue+- Process+    - A GitHub issue should be created to track the work+    - Designs are produced in Figma+    - Designs will be announced in Slack and linked in the GitHub issue well before they are complete for review+    - Ensure designs meet the visual design checklist:+      - Ensure spacing is consistent and matches the 8pt grid system+      - Ensure text, colors and other sytles match existing styles, if possible. +        - Introduce new text styles only if really necessary.+        - If adding new styles, ensure that they meet the accessibility standards and add them to the design system +      - Review designs for accessability:+        - Color blind check+        - Contrast check should meet AA standard for small text+    - Schedule and conduct a design presentation meeting if the size of the project requires+    - Receive signoff from stakeholders+    - If components were created in the visual design process, when the designs are signed off on, those components will be moved to the Sourcegraph component system+    - Prepare redlines or an interaction delivery writeup for the engineers. Consider the following:+        - Margin and padding+        - Animation+        - Links and hover states+    - Describe expected behavior of layout for tablet and moble screensizes+      - Due to the low number of mobile and table visitors (< 3%) design comps for these sizes are generally not required +    - Schedule a meeting with engineers to discuss the interaction+- Tools+    - Figma++### Metrics collection++- In the RFC process, the definition of success will include items which can be measured and evaluated+- Involve the business operations team in determining what metrics to track and how they are tracked+- Work with engineers to add the required eventLog tracking+- Tools+    - Looker+    - Google analytics++### Refinement++- Designers will review metrics and determine if their designs are meeting objectives set for them.+- If areas for improvement are found, tickets will be created to document the change required to improve the issue  +### Final review of implementation +- Test the feature for both themes, Light and Dark. Check for icon consistency across themes.

I think I cleared that section up a bit.

christinaforney

comment created time in 21 days

push eventsourcegraph/about

Rob Rhyne

commit sha 41170d2b07c864bae733f40d4799f6df25a82c75

Clarify icon review

view details

push time in 21 days

push eventsourcegraph/about

AlicjaSuska

commit sha 8b76830d351a8cfd54a356ef2d1362db42ccae7b

Add Plugins and Project Tools (#1188)

view details

Beyang Liu

commit sha 80caf6e5b55953bfd5aba36e11a120b1a63a7d56

podcast: publish luke hoban

view details

Beyang Liu

commit sha f43c44a96cab6f84b3c417006fb085d0c52d25f5

podcast: yves and john v0

view details

davejrt

commit sha 869776906ea080d0c138d4b960176a4faccae334

adjust heading for pulumi section (#1189)

view details

Quinn Slack

commit sha 878b33811395da119a5e7f957377c14201882b08

company meeting introing a new person

view details

renovate[bot]

commit sha c7d732658fc9b9e21b10f0fe7333700f835b8a68

Update dependency react-bootstrap to ^1.2.2 (#1159) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha 43330a7dbcbb50aaba90e724d0ee1d0090968e60

Update dependency sharp to ^0.25.4 (#1139) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: aileenrose <aileenrose@users.noreply.github.com>

view details

renovate[bot]

commit sha 988f27b17f1a8e3387f1a611104f6378782d1336

Update dependency stylelint to ^13.6.1 (#1141) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: aileenrose <aileenrose@users.noreply.github.com>

view details

renovate[bot]

commit sha 0633d20b72da3355d9ba4d9fad32220b87108b0f

Update dependency stylelint-scss to ^3.18.0 (#1142) * Update dependency stylelint-scss to ^3.18.0 * Update dependency stylelint-scss to ^3.18.0 Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: aileenrose <aileenrose@users.noreply.github.com>

view details

Gonzalo Peci

commit sha 8926bf6f2eecce6e8a40651b1a195061ed3182bb

distribution: Weekly team updates (#1175) * distribution: Weekly team updates * Update recurring_processes.md * Update handbook/engineering/distribution/recurring_processes.md Co-authored-by: Robert Lin <robert@bobheadxi.dev> Co-authored-by: Robert Lin <robert@bobheadxi.dev>

view details

Beyang Liu

commit sha e84e4e8b272edab74ed8391a35ca92c678aecdcd

podcast: luke hoban: paragraph formatting

view details

renovate[bot]

commit sha d10c0f690c2fa34b724323e9f1d66c276af9341e

Update dependency slugify to ^1.4.4 (#1140) * Update dependency slugify to ^1.4.4 * Update sharp version Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: aileenrose <aileenrose@users.noreply.github.com>

view details

renovate[bot]

commit sha 4bfb1822780218112013fe669f09e96695845836

Update dependency react-share to ^4.2.1 (#1039) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: aileenrose <aileenrose@users.noreply.github.com>

view details

renovate[bot]

commit sha c38e39a14b3a664fdc48a8c9bf5a7505aa9cc2bc

Update dependency react-router-dom to ^5.2.0 (#1003) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha 108a2998297bb250d7ca641938bc5fe4b2494cd3

Update dependency mdi-react to v7 (#895) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

renovate[bot]

commit sha 241484d30a438ebd33551c5a313a8d95c911e61a

Update dependency react-helmet to v6 (#896) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

aileenrose

commit sha 8616e93172794361edf45498aa208116e56fb222

Fix icons (#1191) * Fix icons * Let's get the icon names correct * Update mdi-react to get updated icons.

view details

renovate[bot]

commit sha 023a82199140ca26ecda6d17b7aeffe4ebe906f3

Update Node.js to v14.5.0 (#997) * Update Node.js to v14.5.0 * Update Node.js to v14.5.0 * Update Node.js to v14.5.0 * Update Node.js to v14.5.0 * Fix icons * Update Node.js to v14.5.0 Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: aileenrose <aileenrose@users.noreply.github.com>

view details

renovate[bot]

commit sha ffa112049cb87295073017081c5ad8af2e092cf9

Update dependency typescript to ^3.9.6 (#1007) * Update dependency typescript to ^3.9.6 * Update icons Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: aileenrose <aileenrose@users.noreply.github.com>

view details

renovate[bot]

commit sha e3092dd91e2018e7ea2cda19106cf0ad208a650b

Update gatsby monorepo (#1028) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in 21 days

Pull request review commentsourcegraph/about

Add Working with design files + heading update

 While asynchronous communication is a core attribute of remote work, key moments       - Schedule a meeting with engineers to discuss the interaction   - Tools       - Figma-- Metrics collection:+- **Metrics collection**   - In the RFC process, the definition of success will include items which can be measured and evaluated   - Involve the business operations team in determining what metrics to track and how they are tracked   - Work with engineers to add the required eventLog tracking   - Tools       - Looker       - Google analytics-- Refinement+- **Refinement**   - Designers will review metrics and determine if their designs are meeting objectives set for them.   - If areas for improvement are found, tickets will be created to document the change required to improve the issue+  +## Working with design files+To provide consistency in design files handling, follow the rules listed below:++#### File location+All files should be created under the Sourcegraph organization in Figma. It is important to not work on Sourcegraph projects in the private files as designs should be accessible to all Team Members.++#### Naming convention+- All the files containing current project work must follow this naming structure:++RFC or GitHub issue number + RCF or GitHub issue title + stage (Draft, Open to review, Final review or Approved).++- Keep the stage updated as you progress with your work. ++#### Project Tools+Use [Project Tools](https://www.figma.com/file/8qNcDzOXLj1hcOM76WDPN9/Project-Tools?node-id=0%3A1) to provide more information about the project directly in the Figma file. It will help all the visitors connect files to the related RFC or GitHub issue and understand better all the details about the design.++- Project Card - displays basic information about project ex. reviewers, RFC and GitHub issue links, deadlines etc. It should be created for every file.++- Project Introduction - necessary when sharing your prototype with the Team. It should contain details about the target audience and project goals, to provide good context before starting the review.++- Final Page - placed at the end of the prototype. It shows additional notes on the solution, points out the most important pages in the prototype and describes what feedback the designer is looking for. It also instructs reviewers on how to leave comments.++#### File structure

Perfect, thanks!

AlicjaSuska

comment created time in 21 days

delete branch sourcegraph/sourcegraph

delete branch : CTA

delete time in 22 days

create barnchsourcegraph/sourcegraph

branch : CTA

created branch time in 22 days

PR opened sourcegraph/about

Reviewers
Add iconify
+1 -0

0 comment

1 changed file

pr created time in 23 days

create barnchsourcegraph/about

branch : add-iconify

created branch time in 23 days

more