profile
viewpoint

google/guice 9785

Guice (pronounced 'juice') is a lightweight dependency injection framework for Java 6 and above, brought to you by Google.

google/flogger 1246

A Fluent Logging API for Java

google/bazel-common 57

Common functionality for Google's open-source libraries that are built with bazel.

google/inject-common 3

Utilities for implementers and consumers of the javax.inject APIs.

ronshapiro/albus 0

An open-source crash reporter

ronshapiro/albus-android 0

An open-source crash reporting client.

ronshapiro/androidx 0

Development environment for Jetpack Android extension libraries. Synchronized with Jetpack's primary development branch on AOSP.

ronshapiro/auto-value-gson 0

AutoValue Extension to add Gson De/Serializer support

ronshapiro/BackspaceEditText 0

An alternative to attempting to detect KeyEvent.KEYCODE_DEL on Android

issue commentgoogle/google-java-format

Before commit reformatting option in IntelliJ does invoke plugin

Also observing the same issue. The workaround with the codestyle.xml is nice, but the formatting can be wildly different. Especially regarding annotations (on single line, annotation indentation, ...) so the workaround is in the end not really sufficient as you still have to always apply the style either manually or via a maven plugin.

mqzry

comment created time in 30 minutes

issue commentgoogle/guice

Move Logger binding out to LoggerModule, so users can bind their own Loggers

Running into this years later...

gissuebot

comment created time in an hour

issue openedgoogle/guava

Synchronized usage of Concurrent Multi Hash Map

While looking for a Concurrent Multi Hash Map, I found Multimaps.synchronizedMultimap() wrapper which seems to be what I'm looking for. However, the documentation gives an example which I'm not picturing a situation when this might be useful: https://github.com/google/guava/blob/4709fe4d50cf5249b9e5e40fb8917c610831c317/guava/src/com/google/common/collect/Multimaps.java#L566-L583

My take is that put operations will still be outside this synchronized block. Am I getting it wrong?

I went to look for valid usages in the test suite, but only found one that didn't help me much understanding it.

My use case is that I don't really care for non-deterministic behavior as long as it does not result in a fail operation (e.g., throw an Exception). Even if this might not be an issue, I am still curious about a scenario where this should be employed.

created time in 4 hours

startedloreanvictor/callbag-common

started time in 5 hours

issue commentgoogle/error-prone

RemoveUnusedImports is not working

Thanks @cushon this option worked for me. The only challenge is it is taking 2 passes

  1. In the first pass it removed my stale flag but imports are not imported.
  2. In the second pass it removed the unused imports.
cnarsimharaju

comment created time in 6 hours

startedssbc/ssb-private1

started time in 6 hours

pull request commentgoogle/jimfs

Adding ppc64le architecture support on travis-ci

Any views on the requested PR?

kishorkunal-raj

comment created time in 8 hours

created repositorysimon-weber/kleroteria

An email lottery and spiritual successor to The Listserve.

created time in 18 hours

issue commentgoogle/guava

EventBus: Add options to enable ImmediateDispatcher

Actually I also found issue #3406 related to this problem now. The most problematic thing is only, that the abstract class Dispatcher is package visible. If the implementation of ImmediateDispatchercan be used or not, is not that important because the code is trivial and can easily be reimplemented by extending Dispatcher. I could also create a Pull request to fix this issue if this is OK and is accepted.

ckloner

comment created time in 20 hours

issue openedgoogle/guava

EventBus: Add options to enable ImmediateDispatcher

This ticket is almost the same as #2986 but deals with the EventBus instead of the AsycEventBus object.

I am using the EventBus object not as global object (static or singleton) but on a single instance per user session. In this scenario, instantiating for each EventBus instance an instance of PerThreadQueuedDispatcher with all the ThreadLocal variables does not make much sense. It would be better to have the possibility to use ImmediateDispatcher.INSTANCE by making Dispatcher.immediate() public - as well as changing the package visibility of the class Dispatcher to public. Changing the package visible constructor EventBus(String,Executor,Dispatcher,SubscriberExceptionHandler) would enable much more flexibility.

created time in 20 hours

startedTribler/py-ipv8

started time in 21 hours

startedbijection/g9

started time in 21 hours

issue commentgoogle/guava

Enable multiple Finalizers for FinalizableReferenceQueue

The data-structure of the Graph is given, we use the BinaryResource of the Eclipse Modelling Framework. But nevertheless thanks for the link, it looks interesting. Maybe it provides some good ideas (Since it seems to be abandon, it is probably not a good idea to use it directly).

Yes, that sounds reasonable. I'll have to think about it again and hopefully find a better solution. Thanks a lot for your help.

HannesWell

comment created time in a day

issue closedgoogle/compile-testing

[feature request] support assert generate multi source file.

My annotation processor generate multi file for a annotationed class. If I use com.google.testing.compile.CompilationSubject#generatedSourceFile to test it. It said:

expected to generate file: /io/github/vipcxj/beanknife/tests/otherbeans/TestBean1Meta.java
in location              : SOURCE_OUTPUT
it generated:
  /SOURCE_OUTPUT/io/github/vipcxj/beanKnfie/tests/otherbeans/TestBean1Meta.java
  /SOURCE_OUTPUT/io/github/vipcxj/beanknife/tests/beans/TestBean1Meta.java
  /SOURCE_OUTPUT/io/github/vipcxj/beanKnfie/tests/otherbeans/ViewOfTestBean1.java
  /SOURCE_OUTPUT/io/github/vipcxj/beanknife/tests/beans/ViewOfTestBean1.java

	at io.github.vipcxj.beanknife.tests.ViewMetaProcessorTest.testViewMetaCase(ViewMetaProcessorTest.java:50)
	at io.github.vipcxj.beanknife.tests.ViewMetaProcessorTest.testBean1(ViewMetaProcessorTest.java:18)

And I can't find a method to support this use case.

closed time in a day

vipcxj

issue commentgoogle/compile-testing

[feature request] support assert generate multi source file.

My fault, beanKnfie is not equal to beanknife

vipcxj

comment created time in a day

issue openedgoogle/compile-testing

[feature request] support assert generate multi source file.

My annotation processor generate multi file for a annotationed class. If I use com.google.testing.compile.CompilationSubject#generatedSourceFile to test it. It said:

expected to generate file: /io/github/vipcxj/beanknife/tests/otherbeans/TestBean1Meta.java
in location              : SOURCE_OUTPUT
it generated:
  /SOURCE_OUTPUT/io/github/vipcxj/beanKnfie/tests/otherbeans/TestBean1Meta.java
  /SOURCE_OUTPUT/io/github/vipcxj/beanknife/tests/beans/TestBean1Meta.java
  /SOURCE_OUTPUT/io/github/vipcxj/beanKnfie/tests/otherbeans/ViewOfTestBean1.java
  /SOURCE_OUTPUT/io/github/vipcxj/beanknife/tests/beans/ViewOfTestBean1.java

	at io.github.vipcxj.beanknife.tests.ViewMetaProcessorTest.testViewMetaCase(ViewMetaProcessorTest.java:50)
	at io.github.vipcxj.beanknife.tests.ViewMetaProcessorTest.testBean1(ViewMetaProcessorTest.java:18)

And I can't find a method to support this use case.

created time in a day

startedtrebleshot/android

started time in a day

push eventgoogle/error-prone

travis-ci

commit sha 272e6c690e772bce545241be5335ebb73a6d7c32

Latest docs on successful travis build 2817 auto-pushed to gh-pages

view details

push time in a day

delete branch google/error-prone

delete branch : test_343657126

delete time in a day

PR merged google/error-prone

Add a new bug checker to suggest using immutable collection when the collection is not mutated. cla: yes

Add a new bug checker to suggest using immutable collection when the collection is not mutated.

For now only tacking list and limiting to cases where mutable generic type is initialized with an immutable type.

+216 -0

0 comment

3 changed files

copybara-service[bot]

pr closed time in a day

push eventgoogle/error-prone

Ashish Kedia

commit sha aeafd79184b5ef0f8f8bd43980f2c21369449845

Add a new bug checker to suggest using immutable collection when the collection is not mutated. For now only tacking list and limiting to cases where mutable generic type is initialized with an immutable type. PiperOrigin-RevId: 344389214

view details

push time in a day

push eventgoogle/error-prone

Ashish Kedia

commit sha aeafd79184b5ef0f8f8bd43980f2c21369449845

Add a new bug checker to suggest using immutable collection when the collection is not mutated. For now only tacking list and limiting to cases where mutable generic type is initialized with an immutable type. PiperOrigin-RevId: 344389214

view details

push time in a day

create barnchgoogle/error-prone

branch : test_343657126

created branch time in a day

PR opened google/error-prone

Add a new bug checker to suggest using immutable collection when the collection is not mutated.

Add a new bug checker to suggest using immutable collection when the collection is not mutated.

For now only tacking list and limiting to cases where mutable generic type is initialized with an immutable type.

+216 -0

0 comment

3 changed files

pr created time in a day

startedmadisp/android-chunk-utils

started time in a day

Pull request review commentgoogle/google-java-format

Check build with JDK 16-ea

 jobs:         shell: bash         run: mvn test -B +  early_access:+    name: 'JDK Early-Access'+    continue-on-error: true

Ah, thanks for clarifying. I'll go ahead and merge this.

sormuras

comment created time in 2 days

issue commentgoogle/google-java-format

Publish snapshot artifacts to Sonatype fails

I'll take care of it, thanks for confirming!

sormuras

comment created time in 2 days

issue commentgoogle/google-java-format

Publish snapshot artifacts to Sonatype fails

... there's a separate step that sets the env variable to the 'secret': ...

Aye. That env section is missing. Do you want to add those two lines directly or should I create a PR?

      - name: 'Publish'
        env:
          CI_DEPLOY_USERNAME: ${{ secrets.CI_DEPLOY_USERNAME }}
          CI_DEPLOY_PASSWORD: ${{ secrets.CI_DEPLOY_PASSWORD }}
        run: mvn source:jar deploy -B -DskipTests=true -Dinvoker.skip=true -Dmaven.javadoc.skip=true
sormuras

comment created time in 2 days

Pull request review commentgoogle/google-java-format

Check build with JDK 16-ea

 jobs:         shell: bash         run: mvn test -B +  early_access:+    name: 'JDK Early-Access'+    continue-on-error: true

It did work as expected on the branch of my forked repository. See https://github.com/google/google-java-format/issues/538#issuecomment-733933661

Just this PR was marked as failed -- perhaps it would work after merging to master.

sormuras

comment created time in 2 days

startedrust-num/num-iter

started time in 2 days

more