profile
viewpoint
Robert robbanl Codepeak AB Sweden

robbanl/cdn 0

[WIP] Magento CDN module that allows hosting all media on AWS S3. A must when you need to scale Magento horizontally.

robbanl/imagecdn 0

One Pica ImageCDN Magento extension

robbanl/magemonkey 0

FULL, FREE and SUPPORTED integration with MailChimp Email Marketing and Mandrill Transactional Emails for Magento.

robbanl/magento-turpentine 0

A Varnish extension for Magento.

robbanl/mock-http-server 0

Mock HTTP server written in Go

robbanl/modman 0

Modularize extensions using symlinks. Voted #1 Magento tool by @WebShopApps!

robbanl/PHPoAuthLib 0

PHP 5.3+ oAuth 1/2 Client Library

PR opened mpociot/laravel-apidoc-generator

fix the way unicode character are displayed in generated responses in…

A little change, to show correct unicode characters that example responses might have instead of the way the are now in escaped.

For example:

{"name":"\u0627\u0628\u0631\u0627\u0647\u06cc\u0645"}

should be displayed as :

{"name":"ابراهیم"}

to be readable in documents.

+4 -4

0 comment

4 changed files

pr created time in 25 minutes

issue commentduplicati/duplicati

Gibibytes vs Gigabytes

I might have misunderstood the issue, but I don't see an issue with using GB and meaning 1024^3 bytes. The only (mis)usage I saw is that disk manufacturers (still) claiming for example 1 TB, but it is actually only 931.5 GB (as most users would understand it).

For file sizes, memory size and so on all major software manufacturer are using it the same way as Duplicati currently does (as far as I understood the issue).

For consistency with existing software, I wouldn't change the current usage. I think it would be rather confusing to use "GiB", even if it is more correct in the view of SI.

Pectojin

comment created time in 36 minutes

issue commentmpociot/laravel-apidoc-generator

{object} need to replace with Id or other text.

This is not an issue about this package, it's about the way you add metadata to your code's docblock.

You may use docblocks like :

/**
 * Show Account
 *
 * @urlParam account required
 */
public function show(Account $account)
{
    // ...
}

just before corresponding controller method or even your validation form request. laravel-apidoc-generator would detect that param and add that name to generated documents. It would even be better add some description or example too.

/**
 * Show Account
 *
 * @urlParam account required Some description here. Example:brnrajoriya
 */
public function show(Account $account)
{
    // ...
}

then you would have something like this: image

brnrajoriya

comment created time in an hour

pull request commentmagento/magento2

Added 'UnavailableQuantity' test case for updateCartItems mutation

Hi @rogyar, thank you for the review. ENGCOM-8507 has been created to process this Pull Request

sergiy-v

comment created time in 2 hours

pull request commentmagento/magento2

Added 'UnavailableQuantity' test case for updateCartItems mutation

I really like the approach of writing a test for making sure that the issue does not appear anymore.

sergiy-v

comment created time in 2 hours

pull request commentmagento/magento2

[WIP] Removed usage of CliIndexerReindexActionGroup action group

Yeah, looks like the failing tests for bundling products are related.

sergiy-v

comment created time in 2 hours

issue commentmagento/magento2

Import of products discards many relation links

Hi @stephansteiner. Thank you for your report. To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

stephansteiner

comment created time in 2 hours

issue openedmagento/magento2

Import of products discards many relation links

When importing a csv file with many product relations (columns crosssell_skus, related_skus and upsell_skus) in Magento 2.4 many of the relations are discarded, but no error is reported. A short analysis of the CatalogImportExport module showed that the function processLinkBunches is called with the same nextLinkId over and over, thus importing only the first bunch of relations and discarding all other relations.

Preconditions (*)

  1. Affected versions are Magento 2.4.0 and 2.4.1 (maybe also earlier versions, did not check)
  2. Create a sample import file with many relations or use the file attached to this report (contains 300 products that are linked to each other as related, crosssell and upsell). sample_import.txt

Steps to reproduce (*)

  1. Import sample file with many relations. The sample file provided contains 300 products with each 3 links of type related, crosssell and upsell, making a total of 900 product links that should be imported.
  2. Check number of relations in table catalog_product_link. With my sample file I get only 300 relations, because LinkProcessor::processLinkBunches is called with bunches of 100 items, but always with the same nextLinkid, thus only the first 300 links are being imported.

Expected result (*)

  1. Total number of product links should be 900 (300 products x 3 links per product = 900 links)

Actual result (*)

  1. Only 300 product links have been imported from the first bunch, later links are discarded.

Workaround / Patch

One possible workaround is to import products in smaller bunches (which is really tedious if you need to import thousands of products).

Another possibility is to patch vendor/magento-catalog-import-export/Model/Import/Product/LinkProcessor.php:

diff --git a/vendor/magento/module-catalog-import-export/Model/Import/Product/LinkProcessor.php b/vendor/magento/module-catalog-import-export/Model/Import/Product/LinkProcessor.php
index 65064e8..4ea7620 100644
--- a/vendor/magento/module-catalog-import-export/Model/Import/Product/LinkProcessor.php
+++ b/vendor/magento/module-catalog-import-export/Model/Import/Product/LinkProcessor.php
@@ -89,7 +89,6 @@ class LinkProcessor
         $resource = $this->linkFactory->create();
         $mainTable = $resource->getMainTable();
         $positionAttrId = [];
-        $nextLinkId = $this->resourceHelper->getNextAutoincrement($mainTable);
 
         // pre-load 'position' attributes ID for each link type once
         foreach ($this->linkNameToId as $linkId) {
@@ -103,6 +102,8 @@ class LinkProcessor
             $positionAttrId[$linkId] = $importEntity->getConnection()->fetchOne($select, $bind);
         }
         while ($bunch = $dataSourceModel->getNextBunch()) {
+           // get next linkid before processing a bunch
+            $nextLinkId = $this->resourceHelper->getNextAutoincrement($mainTable);
             $this->processLinkBunches($importEntity, $linkField, $bunch, $resource, $nextLinkId, $positionAttrId);
         }
     }

  • [ ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • [X] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • [ ] Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • [ ] Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • [ ] Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

created time in 2 hours

issue commentmagento/magento2

giftcard_created_codes Unavailable on Order API

Hi @engcom-Delta. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: :point_down:

  • [ ] 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).<details><summary>Details</summary>If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.</details>

  • [ ] 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • [ ] 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • [ ] 4. Verify that the issue is reproducible on 2.4-develop branch<details><summary>Details</summary>- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure. <br/> - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.<br/>- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!</details>

  • [ ] 5. Add label Issue: Confirmed once verification is complete.

  • [ ] 6. Make sure that automatic system confirms that report has been added to the backlog.

catalyst-steve

comment created time in 3 hours

issue commentmagento/magento2

Customer Account Edit controller action enforces Page Title to "Account Information"

:white_check_mark: Confirmed by @engcom-Delta Thank you for verifying the issue. Based on the provided information internal tickets MC-39563 were created

Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

ericmorand

comment created time in 3 hours

issue commentmagento/magento2

Invoice for an order that contains only one configurable product is not generated correctly

Hi @mizzimizzi. Thank you for your report. To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


:warning: According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

mizzimizzi

comment created time in 3 hours

issue openedmagento/magento2

Invoice for an order that contains only one configurable product is not generated correctly

Preconditions (*)

  1. Magento ver. 2.3.5-p1

Steps to reproduce (*)

  1. create a cart with exactly one configurable product
  2. complete the order with any payment method
  3. invoice the order from Admin (only if the invoice has not already been created)

Expected result (*)

The invoice is treated as last invoice (\Magento\Sales\Model\Order\Invoice::isLast returns true)

Actual result (*)

The invoice is not treated as last invoice (\Magento\Sales\Model\Order\Invoice::isLast returns false)


similar issue is https://github.com/magento/magento2/issues/22283 isLast should skip the dummy items to avoid the problem

created time in 3 hours

pull request commentmagento/magento2

Fixed configurable product price indexer issue

@magento run all tests

ananth-iyer

comment created time in 3 hours

pull request commentmagento/magento2

set correct remaining available discount amount when applying fixed p…

@magento run all tests

sky-hub

comment created time in 3 hours

pull request commentmagento/magento2

Fix wrong product ratings issue #30196

@magento run all tests

somat-211

comment created time in 3 hours

pull request commentmagento/magento2

[WIP] Removed usage of CliIndexerReindexActionGroup action group

@magento run Functional Tests CE

sergiy-v

comment created time in 3 hours

pull request commentmagento/magento2

Missing unique key on eav attribute label table

@magento run all tests

alex311982

comment created time in 3 hours

pull request commentmagento/magento2

Fix wrong format error DHL shipping label

@magento run all tests

vpsnak

comment created time in 3 hours

pull request commentmagento/magento2

[MFTF] Refactoring of AdminMassProductPriceUpdateTest

@magento run all tests

AnnaAPak

comment created time in 3 hours

pull request commentmagento/magento2

Initialize authentication popup modal only when needed

@magento run Functional Tests B2B

krzksz

comment created time in 3 hours

pull request commentmagento/magento2

Removed usage of CliIndexerReindexActionGroup action group

Going to check failed tests for Bundle module.

sergiy-v

comment created time in 4 hours

pull request commentmagento/magento2

Removed redundant header issue in grid cells while adding grouped product items after changing attribute set

Hi @saphaljha. Thank you for your contribution Here is some useful tips how you can test your changes using Magento test environment. Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

:information_source: Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

:warning: According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

saphaljha

comment created time in 4 hours

PR opened magento/magento2

Removed redundant header issue in grid cells while adding grouped product items after changing attribute set

<!--- Thank you for contributing to Magento. To help us process this pull request we recommend that you add the following information: - Summary of the pull request, - Issue(s) related to the changes made, - Manual testing scenarios Fields marked with (*) are required. Please don't remove the template. -->

<!--- Please provide a general summary of the Pull Request in the Title above -->

Description (*)

<!--- Please provide a description of the changes proposed in the pull request. Letting us know what has changed and why it needed changing will help us validate this pull request. --> Removed redundant header issue in grid cells while adding grouped product items after changing attribute set

Related Pull Requests

<!-- related pull request placeholder -->

Fixed Issues (if relevant)

<!--- If relevant, please provide a list of fixed issues in the format magento/magento2#<issue_number>. There could be 1 or more issues linked here and it will help us find some more information about the reasoning behind this change. -->

  1. Fixes magento/magento2#30911

Manual testing scenarios (*)

<!--- Please provide a set of unambiguous steps to test the proposed code change. Giving us manual testing scenarios will help with the processing and validation process. -->

  1. Manually tested

Questions or comments

<!--- If relevant, here you can ask questions or provide comments on your pull request for the reviewer For example if you need assistance with writing tests or would like some feedback on one of your development ideas -->

Contribution checklist (*)

  • [ ] Pull request has a meaningful description of its purpose
  • [ ] All commits are accompanied by meaningful commit messages
  • [ ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ ] All automated tests passed successfully (all builds are green)
+5 -1

0 comment

1 changed file

pr created time in 4 hours

pull request commentmagento/magento2

magento/magento2#459 verify custom customer address attribute shows at checkout

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B, Semantic Version Checker

sagar1dahiwala

comment created time in 5 hours

pull request commentmagento/magento2

Added 'UnavailableQuantity' test case for updateCartItems mutation

@magento run WebAPI Tests

sergiy-v

comment created time in 5 hours

pull request commentmagento/magento2

Added 'UnavailableQuantity' test case for updateCartItems mutation

Hi @sergiy-v. Thank you for your contribution Here is some useful tips how you can test your changes using Magento test environment. Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

:exclamation: Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s) For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

:information_source: Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

:warning: According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

:clock10: You can find the schedule on the Magento Community Calendar page.

:telephone_receiver: The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

:movie_camera: You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

:pencil2: Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

sergiy-v

comment created time in 5 hours

PR opened magento/magento2

Added 'UnavailableQuantity' test case for updateCartItems mutation

Description

Could not reproduce reported bug, looks like the mentioned logic (see path below) has been refactored. vendor/magento/module-quote-graph-ql/Model/Resolver/UpdateCartItems.php:92 Because of that added the test to cover 'UnavailableQuantity' case (similar to reported case).

Fixed Issues

#30220

+18 -0

0 comment

1 changed file

pr created time in 5 hours

Pull request review commentmagento/magento2

MC-38931: Product URL Rewrites are not removed when product removed from website

+<?php+/**+ * Copyright © Magento, Inc. All rights reserved.+ * See COPYING.txt for license details.+ */+declare(strict_types=1);++namespace Magento\Catalog\Model\ResourceModel\Product;++use Magento\Framework\DB\Select;+use Magento\Catalog\Api\Data\ProductInterface;+use Magento\Catalog\Model\Product;+use Magento\Catalog\Model\Product\Visibility;+use Magento\Eav\Model\Config;+use Magento\Framework\App\ResourceConnection;+use Magento\Framework\EntityManager\MetadataPool;+use Magento\Store\Model\Store;++/**+ * Product data needed for url rewrite generation locator class+ */+class ProductUrlRewriteDataLocator+{+    /**+     * @var MetadataPool+     */+    private $metadataPool;++    /**+     * @var array+     */+    private $productStoreData = [];++    /**+     * @var Visibility+     */+    private $visibility;++    /**+     * @var ResourceConnection+     */+    private $resource;++    /**+     * @var Config+     */+    private $eavConfig;++    /**+     * @param MetadataPool $metadataPool+     * @param Visibility $visibility+     * @param ResourceConnection $connection+     * @param Config $eavConfig+     */+    public function __construct(+        MetadataPool $metadataPool,+        Visibility $visibility,+        ResourceConnection $connection,+        Config $eavConfig+    ) {+        $this->metadataPool = $metadataPool;+        $this->visibility = $visibility;+        $this->resource = $connection;+        $this->eavConfig = $eavConfig;+    }++    /**+     * Retrieves data for product by store+     *+     * @param ProductInterface $product+     * @param int $storeId+     * @return array+     */+    public function getRewriteGenerateData(ProductInterface $product, int $storeId = Store::DEFAULT_STORE_ID): array+    {+        $storeId = $storeId ?? $product->getStoreId();+        if (isset($this->productStoreData[$product->getId()])) {+            return $this->productStoreData[$product->getId()][$storeId]+                ?? ($this->productStoreData[$product->getId()][Store::DEFAULT_STORE_ID]+                    ?? []);

don't see why we should use $linkField here instead fo id

engcom-Golf

comment created time in 5 hours

more