profile
viewpoint

brendangregg/FlameGraph 10225

Stack trace visualizer

trevoro/node-named 301

DNS Server in node.js

brendangregg/dtrace-cloud-tools 184

Some DTrace tools written for the SmartOS/SmartDataCenter cloud (illumos-based)

illumos/illumos-docbooks 33

Updated versions of old Sun docbooks for illumos

illumos/illumos-hcl 13

Automatic generation of the illumos Hardware Compatability List

rmustacc/embench 5

C Extensible Micro-Benchmarking

rmustacc/bardiche-doc 3

docs for https://us-east.manta.joyent.com/rmustacc/public/bardiche

rmustacc/illumos-gate 3

Community developed and maintained version of the OS/Net consolidation

rmustacc/man-wip 2

wip manual pages for illumos

rmustacc/ctf-tests 1

Misc. programs for testing ctf

push eventrmustacc/illumos-gate

Patrick Mooney

commit sha e0c0d44e917080841514d0dd031a696c74e8c435

12989 improve interface boundary for bhyve MMIO 12990 improve interface boundary for bhyve ins/outs 12991 bhyve vlapic should SIPI more carefully Reviewed by: Mike Zeller <mike.zeller@joyent.com> Reviewed by: Joshua M. Clulow <josh@sysmgr.org> Reviewed by: Robert Mustacchi <rm@fingolfin.org> Approved by: Gordon Ross <gordon.w.ross@gmail.com>

view details

Patrick Mooney

commit sha 84971882a96ac0fecd538b02208054a872ff8af3

12996 bhyve kernel should be wscheck clean Reviewed by: Andy Fiddaman <andy@omniosce.org> Approved by: Robert Mustacchi <rm@fingolfin.org>

view details

John Levon

commit sha 8548ec78d85644539a23c4262ed2b9512a47865e

13065 log when suspending a zpool Reviewed by: Andy Fiddaman <andy@omniosce.org> Reviewed by: Toomas Soome <tsoome@me.com> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Toomas Soome

commit sha b89fb824168e36795c325b5e0a4d1e71dd2d8d65

13068 gptzfsboot: command from /boot/config should be nul terminated Reviewed by: Andy Fiddaman <andy@omniosce.org> Reviewed by: Juraj Lutter <juraj@lutter.sk> Approved by: Robert Mustacchi <rm@fingolfin.org>

view details

Toomas Soome

commit sha 5fae793b9b02afd1f3f434f3a915a64c08edc7b2

13062 loader: make env_discard() public Reviewed by: Andy Fiddaman <andy@omniosce.org> Reviewed by: Andrew Stormont <andyjstormont@gmail.com> Approved by: Robert Mustacchi <rm@fingolfin.org>

view details

Richard Hansen

commit sha 0a9a25a293d437b1563e1d8479fef8f3795ba817

13021 Invalid state if bindtextdomain() fails during re-binding Reviewed by: Joshua M. Clulow <josh@sysmgr.org> Approved by: Dan McDonald <danmcd@joyent.com>

view details

John Gardner

commit sha 9fff840dca14d75459a8240b19c931e2fec186c5

13032 printf(3C) should talk about NULL string pointers Reviewed by: Robert Mustacchi <rm@fingolfin.org> Reviewed by: C Fraire <cfraire@me.com> Reviewed by: Andy Fiddaman <andy@omniosce.org> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Robert Mustacchi

commit sha 31c9b836861e74f837a36ca29220b58f3657585a

13044 Clarify parts of getopt_long(3C) Reviewed by: Peter Tribble <peter.tribble@gmail.com> Reviewed by: C Fraire <cfraire@me.com> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Andy Fiddaman

commit sha 6863ede29751efd2be66ec1b48c3c0ee705d7d61

13066 Want crontab -u Reviewed by: Peter Tribble <peter.tribble@gmail.com> Reviewed by: Dominik Hassler <hadfl@omniosce.org> Approved by: Robert Mustacchi <rm@fingolfin.org>

view details

Toomas Soome

commit sha e0721d5ae1542c80097f6fcd487736fdfe601233

13003 console: multiple issues related to colors and font loading and switching Reviewed by: Robert Mustacchi <rm@fingolfin.org> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Andy Fiddaman

commit sha c6fc7f7b786ce47c35645054cdce73e83f39e7f3

13051 sed: lastline check does not work properly with empty files Reviewed by: Robert Mustacchi <rm@fingolfin.org> Reviewed by: Dominik Hassler <hadfl@omniosce.org> Approved by: Gordon Ross <gordon.w.ross@gmail.com>

view details

Andy Fiddaman

commit sha cd94aa947d1e02a1c25259f2cf06c165d75aa4fa

13061 Import sed tests from freebsd Reviewed by: Robert Mustacchi <rm@fingolfin.org> Approved by: Gordon Ross <gordon.w.ross@gmail.com>

view details

Robert Mustacchi

commit sha f415aa8f1340638644c6cf63e9d11d3767f4cbba

13036 grep tests could be easier to extend Reviewed by: Andy Fiddaman <andy@omniosce.org> Reviewed by: Toomas Soome <tsoome@me.com> Approved by: Gordon Ross <gordon.w.ross@gmail.com>

view details

Robert Mustacchi

commit sha 2e5ac464a5683c5bf11439ccad74c9f279051820

13037 grep could support -L Reviewed by: Andy Fiddaman <andy@omniosce.org> Reviewed by: Toomas Soome <tsoome@me.com> Approved by: Gordon Ross <gordon.w.ross@gmail.com>

view details

Robert Mustacchi

commit sha 8ccd021704a4fe1b4022c110d3dd497f8cd907d5

13038 grep could support --label Reviewed by: Andy Fiddaman <andy@omniosce.org> Reviewed by: Toomas Soome <tsoome@me.com> Approved by: Gordon Ross <gordon.w.ross@gmail.com>

view details

Robert Mustacchi

commit sha 81dd18d87c3c2e198d2178dfd1f30d62a81b69ea

3546 add support for grep -o option Reviewed by: Andy Fiddaman <andy@omniosce.org> Reviewed by: Toomas Soome <tsoome@me.com> Approved by: Gordon Ross <gordon.w.ross@gmail.com>

view details

Robert Mustacchi

commit sha dbe930bf51e0d7458b24d30e9f25756c5da54ddf

13040 grep can leverage bmg in more cases Reviewed by: Andy Fiddaman <andy@omniosce.org> Reviewed by: Toomas Soome <tsoome@me.com> Approved by: Gordon Ross <gordon.w.ross@gmail.com>

view details

Paul Winder

commit sha e1447ca93391f31609bda487cb922dbff9dcdef5

12980 attempting to change MTU on mlxcx based aggregation can induce FMA event 12987 devo_power misconfigured in mlxcx 12988 potential hang in mlxcx when async and ring vectors end up on same CPU Reviewed by: Robert Mustacchi <rm@fingolfin.org> Reviewed by: Dan McDonald <danmcd@joyent.com> Reviewed by: Igor Kozhukhov <igor@dilos.org> Approved by: Garrett D'Amore <garrett@damore.org>

view details

Sergio Aguayo

commit sha d770dd109db2b92dea49c41ab80ce452e6e7064c

12767 Document '-delete' option to find(1) Reviewed by: Andy Fiddaman <andy@omniosce.org> Reviewed by: Robert Mustacchi <rm@fingolfin.org> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Patrick Mooney

commit sha 7611ab7b771a068fbab94a90143de2afd495769f

13034 dnode_sync is careless with range tree Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed by: Igor Kozhukhov <igor@dilos.org> Reviewed by: Andrew Stormont <andyjstormont@gmail.com> Reviewed by: Jason King <jason.king@joyent.com> Approved by: Dan McDonald <danmcd@joyent.com>

view details

push time in 25 days

create barnchrmustacc/illumos-gate

branch : zen-dev

created branch time in a month

push eventrmustacc/illumos-gate

Patrick Mooney

commit sha ec82ad7502f4abb881c6b3012833e59fd3c24594

13000 bhyve sources should reflect license details Reviewed by: Andy Fiddaman <andy@omniosce.org> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Patrick Mooney

commit sha 425a83377a83720d1e9907ec3641a499a5eed18f

12998 OpenBSD needs DE_CFG MSR on AMD bhyve Reviewed by: Andy Fiddaman <andy@omniosce.org> Reviewed by: Mike Zeller <mike.zeller@joyent.com> Reviewed by: Robert Mustacchi <rm@fingolfin.org> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Toomas Soome

commit sha 001481f6cda9064930e4caee83ed1a8f0c801b8b

12405 audioens: variable may be used uninitialized Reviewed by: Robert Mustacchi <rm@fingolfin.org> Reviewed by: Rob Johnston <rob.johnston@joyent.com> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Robert Mustacchi

commit sha 01c0c40b21ae5d91e9c44377d6b19c9326e8e94f

12954 Rewrite coretemp to use the ksensor framework 12955 coretemp had the wrong granularity Reviewed by: Ryan Zezeski <ryan@zinascii.com> Reviewed by: Garrett D'Amore <garrett@damore.org> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Robert Mustacchi

commit sha 64c2d2f3dba85d007642204d91961a84db9360cd

12984 devo_power misset in sensor drivers Reviewed by: Paul Winder <paul@winder.uk.net> Reviewed by: Garrett D'Amore <garrett@damore.org> Reviewed by: Randy Fishel <randyf@sibernet.com> Approved by: Dan McDonald <danmcd@joyent.com>

view details

John Levon

commit sha b8ffbd3111b44e6c578236149ddc6140effd3dc2

12694 race between write() and shutdown() for unix sockets Reviewed by: Robert Mustacchi <rm@fingolfin.org> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Toomas Soome

commit sha 1a10a9077a9effc574b7f797a4d321dd0cea4197

12419 intel_nb5000: variable may be used uninitialized Reviewed by: C Fraire <cfraire@me.com> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Andy Fiddaman

commit sha fe417ad0efdf365d5438ae46904118fa27ae38b8

12853 bhyve manifests should include BSD license Reviewed by: Patrick Mooney <pmooney@pfmooney.com> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Spencer Berger

commit sha 2c834067bf731e663c6269489bf5dc0a9b4c6299

12977 smb3 server encryption leak in smb2_send_reply Reviewed by: Gordon Ross <gordon.w.ross@gmail.com> Reviewed by: Dan McDonald <danmcd@joyent.com> Approved by: Robert Mustacchi <rm@fingolfin.org>

view details

Patrick Mooney

commit sha bd05d33960c9701232eaa8bdb6a5ce585912ffc6

13016 bhyve cannot emulate MMIO from bootrom Reviewed by: Andy Fiddaman <andy@omniosce.org> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Joshua M. Clulow

commit sha be235d17490f6a5ad01c6a5319530fce66d88389

12801 libdiskmgt leaks PROM device information handles like a sieve Reviewed by: Garrett D'Amore <garrett@damore.org> Reviewed by: Robert Mustacchi <rm@fingolfin.org> Reviewed by: Yuri Pankov <yuripv@yuripv.dev> Approved by: Richard Lowe <richlowe@richlowe.net>

view details

Olaf Faaland

commit sha 0caa75193db78d20398498ff9eca8f1c173ec99c

13017 Dump unique configurations and Uberblocks in zdb -lu Portions contributed by: Ryan Moeller <ryan@iXsystems.com> Portions contributed by: Jason King <jason.king@joyent.com> Reviewed by: Tim Chase <tim@chase2k.com> Reviewed by: Don Brady <don.brady@intel.com> Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed by: John Kennedy <john.kennedy@delphix.com> Reviewed by: Andy Fiddaman <andy@omniosce.org> Reviewed by: C Fraire <cfraire@me.com> Approved by: Richard Lowe <richlowe@richlowe.net>

view details

Robert Mustacchi

commit sha b018085dfc5b5d4dc24cf2784f322e76bc3e91c0

13014 ksensor tests are a bit environment dependent Reviewed by: Toomas Soome <tsoome@me.com> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Nan Xiao

commit sha 40ae3b8f7394f061252c31a21b854ae328f6f269

13024 Add omitted word in sed man page Reviewed by: Andy Fiddaman <andy@omniosce.org> Reviewed by: C Fraire <cfraire@me.com> Approved by: Robert Mustacchi <rm@fingolfin.org>

view details

Patrick Mooney

commit sha c3d209cab1511045e9bb1a521f1bd85995d4fd7e

13008 bhyve devmem could match better 13009 mdb-bhyve mishandles memseg offsets 13010 bhyve should not exit when VM debugged Reviewed by: Andy Fiddaman <andy@omniosce.org> Reviewed by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org> Approved by: Robert Mustacchi <rm@fingolfin.org>

view details

Toomas Soome

commit sha f7eeebb7a51b880fb7920f443b9774532d3efea6

13019 loader.efi: cursor and pixel draw should use Blt() if possible Reviewed by: Robert Mustacchi <rm@fingolfin.org> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Richard Lowe

commit sha 0904e7ecf266ebe6844dfc4b178441dc8d81296b

12944 remove long obsolete libsys Reviewed by: Robert Mustacchi <rm+illumos@fingolfin.org> Reviewed by: Toomas Soome <tsoome@me.com> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Brian Behlendorf

commit sha 0ac8993002ee179cc3289243a0fc956ee0db04da

13013 Port OpenZFS zpool label clear improvements 13012 zpool_read_label semantics should match OpenZFS Portions contributed by: Jason King <jason.king@joyent.com> Reviewed by: Matt Ahrens <mahrens@delphix.com> Reviewed by: Tim Chase <tim@chase2k.com> Reviewed by: Tony Hutter <hutter2@llnl.gov> Reviewed by: Andy Fiddaman <andy@omniosce.org> Reviewed by: Toomas Soome <tsoome@me.com> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Patrick Mooney

commit sha 4d3fdeb14779bb6b0838521971d9ac99d65b0572

13029 AMD bhyve should reload TSS ASAP Reviewed by: John Levon <john.levon@joyent.com> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Andy Fiddaman

commit sha 4e81fcfe0bcce62e29d80c1e391d9a241c0ee3b1

13027 sed loses count of relative line offset 13028 system/test/utiltest package is missing licence metadata Reviewed by: Robert Mustacchi <rm@fingolfin.org> Reviewed by: Toomas Soome <tsoome@me.com> Approved by: Dan McDonald <danmcd@joyent.com>

view details

push time in a month

push eventrmustacc/illumos-gate

Patrick Mooney

commit sha 086d96878f5f62a25a6d90e5b03a1ef9ba352231

12909 epoll should better detect fd reassignment Portions contributed by: Bryan Cantrill <bryan@joyent.com> Portions contributed by: Jerry Jelinek <jerry.jelinek@joyent.com> Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com> Reviewed by: Dan McDonald <danmcd@joyent.com> Reviewed by: Jason King <jason.king@joyent.com> Approved by: Robert Mustacchi <rm@fingolfin.org>

view details

Yuri Pankov

commit sha 6f0673af8764c356a5bd511fc7ca8af579fe2000

12810 usr/src/tools/opensolaris contents are unused Reviewed by: Peter Tribble <peter.tribble@gmail.com> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Don Brady

commit sha 7ac89354c798225fea6296348415955ccd95fb80

12877 Port OpenZFS #7780 - Add basic zfs ioc input nvpair validation 12895 zfs_onexit_fd_hold fails to release non-zfs fds Portions contributed by: Brian Behlendorf <behlendorf1@llnl.gov> Portions contributed by: George Wilson <george.wilson@delphix.com> Portions contributed by: Simon Klinkert <simon.klinkert@gmail.com> Portions contributed by: Jason King <jason.king@joyent.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed by: Toomas Soome <tsoome@me.com> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Toomas Soome

commit sha be9c3adb90f4f745cf5c07f3c0dbdd6c9028cda0

12926 libstand: add missing iscntrl() isgraph() and ispunct() Reviewed by: Yuri Pankov <ypankov@tintri.com> Reviewed by: Igor Kozhukhov <igor@dilos.org> Reviewed by: Andy Fiddaman <andy@omniosce.org> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Patrick Mooney

commit sha 95e434b588459fbd3ca313889cc0223436f1b0cd

12910 EPOLLONESHOT should not remove fd Reviewed by: Bryan Cantrill <bryan@joyent.com> Reviewed by: Mike Zeller <mike.zeller@joyent.com> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Patrick Mooney

commit sha f4f9009fc79529ef8f45e7a31acd2ce4ca86a276

12912 epoll mishandles excessive timeout negativity Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com> Reviewed by: Ryan Zezeski <ryan.zeseski@joyent.com> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Jason King

commit sha 33f84ecfada5880d94e9bfc5af7954d41e5664d5

12924 blkdev needs to be better at handling attach failures Reviewed by: Toomas Soome <tsoome@me.com> Reviewed by: Paul Winder <paul@winders.demon.co.uk> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Patrick Mooney

commit sha 66373fa702508a0a41753138f0b10f985c7e058d

12902 epoll should nominally support EPOLLEXCLUSIVE Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com> Reviewed by: Mike Zeller <mike.zeller@joyent.com> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Marcel Telka

commit sha 1c0fc4547783fdfd7365d5d483e2750915523d44

6089 The comment for svc_callout_find() should be improved Reviewed by: Toomas Soome <tsoome@me.com> Approved by: Robert Mustacchi <rm@fingolfin.org>

view details

Toomas Soome

commit sha 7fc77f3f3f63424c569601711f173702dbfd5c45

12927 loader: move zfs_boot_args to bootargs.h Reviewed by: Igor Kozhukhov <igor@dilos.org> Reviewed by: Andy Fiddaman <andy@omniosce.org> Approved by: Robert Mustacchi <rm@fingolfin.org>

view details

Toomas Soome

commit sha fdb2a7e9480266dfaa0b5aaa0e1237456552f332

12881 sparcv9: add __multi3 Reviewed by: Robert Mustacchi <rm@fingolfin.org> Reviewed by: Andrew Stormont <andyjstormont@gmail.com> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Jason King

commit sha 480497bc2ff96b447dc09403a6c187a1593ac1ec

12934 sockfs rights test should close unneeded descriptors Reviewed by: Dan McDonald <danmcd@joyent.com> Reviewed by: Robert Mustacchi <rm@fingolfin.org> Approved by: Richard Lowe <richlowe@richlowe.net>

view details

Robert Mustacchi

commit sha 4a663bac9c5f9f82a5f633bc9639bbee3c2317ff

12904 Update nvme health logpage and temp thresholds Reviewed by: C Fraire <cfraire@me.com> Reviewed by: Paul Winder <paul@winder.uk.net> Approved by: Richard Lowe <richlowe@richlowe.net>

view details

Toomas Soome

commit sha 7e9964352166d31ee78f8ed0e600c9e32d9d72a4

12891 eri: this 'if' clause does not guard... Reviewed by: Andy Fiddaman <andy@omniosce.org> Reviewed by: Peter Tribble <peter.tribble@gmail.com> Reviewed by: Igor Kozhukhov <igor@dilos.org> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Jerry Jelinek

commit sha 2fc9ab6e6080d66d8dc6b967cea7ba24bee8c7e5

12793 kernel FPU support Portions contributed by: Robert Mustacchi <rm@fingolfin.org> Reviewed by: C Fraire <cfraire@me.com> Reviewed by: Ryan Zezeski <ryan@zinascii.com> Reviewed by: Jason King <jason.king@joyent.com> Reviewed by: Toomas Soome <tsoome@me.com> Reviewed by: Patrick Mooney <pmooney@pfmooney.com>

view details

Jason King

commit sha 1a5ae140ba142cafb59ab08b3212c4ebbce84f32

12506 Add support to vioblk for DISCARD operation Reviewed by: Robert Mustacchi <rm@fingolfin.org> Reviewed by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Paul Winder

commit sha 234a3cfbeb41cab4c47872d4972632d855f56d2b

12931 The number of tx/rx queue pairs can exceed the i40e's capabilities Reviewed by: Robert Mustacchi <rm@fingolfin.org> Reviewed by: Garrett D'Amore <garrett@damore.org> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Toomas Soome

commit sha 415535b1f3a5b13ac8fe4938b44c5f5688f82237

12888 mdb: error: variable set but not used Reviewed by: Robert Mustacchi <rm@fingolfin.org> Approved by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>

view details

Alexander Stetsenko

commit sha 4e065a9f6a4471f1001853cd10a093bc5beb58a5

12513 SMB 3.1.1 support for server Reviewed by: Matt Barden <mbarden@tintri.com> Reviewed by: Gordon Ross <gordon.w.ross@gmail.com> Approved by: Robert Mustacchi <rm@fingolfin.org>

view details

Paul Winder

commit sha 5f0e3176f407dfb9d989b5dcc94a6d5384d0b142

12797 mlxcx max flow table limit can be exceeded 12798 mlxcx command interface should allow concurrent commands and be interrupt driven 12799 mlxcx #if defined for MAC_VLAN_UNTAGGED is redundant 12890 mlxcx uses excessive stack space causing stack overflow panic Reviewed by: Garrett D'Amore <garrett@damore.org> Reviewed by: Andy Stormont <astormont@racktopsystems.com> Reviewed by: Robert Mustacchi <rm@fingolfin.org> Reviewed by: Alex Wilson <alex@cooperi.net> Approved by: Dan McDonald <danmcd@joyent.com>

view details

push time in 2 months

delete branch rmustacc/illumos-gate

delete branch : imc-dev

delete time in 2 months

delete branch rmustacc/illumos-gate

delete branch : wpi-dev

delete time in 2 months

delete branch rmustacc/illumos-gate

delete branch : coretemp-dev

delete time in 2 months

create barnchrmustacc/illumos-gate

branch : wpi-dev

created branch time in 2 months

push eventrmustacc/illumos-gate

Robert Mustacchi

commit sha 26c19283cc1bb26ff3a97817f1b46b3bff82135b

12954 Rewrite coretemp to use the ksensor framework 12955 coretemp had the wrong granularity Change-Id: I4e0ca05455d7f9b766a787f070294118ab5e1f47

view details

push time in 2 months

push eventrmustacc/illumos-gate

Robert Mustacchi

commit sha ba43f6a809e8fa661f4f13a4ca8751a7cb40afcd

12954 Rewrite coretemp to use the ksensor framework 12955 coretemp had the wrong granularity Change-Id: I4e0ca05455d7f9b766a787f070294118ab5e1f47

view details

push time in 3 months

push eventrmustacc/illumos-gate

Patrick Mooney

commit sha 086d96878f5f62a25a6d90e5b03a1ef9ba352231

12909 epoll should better detect fd reassignment Portions contributed by: Bryan Cantrill <bryan@joyent.com> Portions contributed by: Jerry Jelinek <jerry.jelinek@joyent.com> Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com> Reviewed by: Dan McDonald <danmcd@joyent.com> Reviewed by: Jason King <jason.king@joyent.com> Approved by: Robert Mustacchi <rm@fingolfin.org>

view details

Yuri Pankov

commit sha 6f0673af8764c356a5bd511fc7ca8af579fe2000

12810 usr/src/tools/opensolaris contents are unused Reviewed by: Peter Tribble <peter.tribble@gmail.com> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Don Brady

commit sha 7ac89354c798225fea6296348415955ccd95fb80

12877 Port OpenZFS #7780 - Add basic zfs ioc input nvpair validation 12895 zfs_onexit_fd_hold fails to release non-zfs fds Portions contributed by: Brian Behlendorf <behlendorf1@llnl.gov> Portions contributed by: George Wilson <george.wilson@delphix.com> Portions contributed by: Simon Klinkert <simon.klinkert@gmail.com> Portions contributed by: Jason King <jason.king@joyent.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed by: Toomas Soome <tsoome@me.com> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Toomas Soome

commit sha be9c3adb90f4f745cf5c07f3c0dbdd6c9028cda0

12926 libstand: add missing iscntrl() isgraph() and ispunct() Reviewed by: Yuri Pankov <ypankov@tintri.com> Reviewed by: Igor Kozhukhov <igor@dilos.org> Reviewed by: Andy Fiddaman <andy@omniosce.org> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Patrick Mooney

commit sha 95e434b588459fbd3ca313889cc0223436f1b0cd

12910 EPOLLONESHOT should not remove fd Reviewed by: Bryan Cantrill <bryan@joyent.com> Reviewed by: Mike Zeller <mike.zeller@joyent.com> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Patrick Mooney

commit sha f4f9009fc79529ef8f45e7a31acd2ce4ca86a276

12912 epoll mishandles excessive timeout negativity Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com> Reviewed by: Ryan Zezeski <ryan.zeseski@joyent.com> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Jason King

commit sha 33f84ecfada5880d94e9bfc5af7954d41e5664d5

12924 blkdev needs to be better at handling attach failures Reviewed by: Toomas Soome <tsoome@me.com> Reviewed by: Paul Winder <paul@winders.demon.co.uk> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Patrick Mooney

commit sha 66373fa702508a0a41753138f0b10f985c7e058d

12902 epoll should nominally support EPOLLEXCLUSIVE Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com> Reviewed by: Mike Zeller <mike.zeller@joyent.com> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Marcel Telka

commit sha 1c0fc4547783fdfd7365d5d483e2750915523d44

6089 The comment for svc_callout_find() should be improved Reviewed by: Toomas Soome <tsoome@me.com> Approved by: Robert Mustacchi <rm@fingolfin.org>

view details

Toomas Soome

commit sha 7fc77f3f3f63424c569601711f173702dbfd5c45

12927 loader: move zfs_boot_args to bootargs.h Reviewed by: Igor Kozhukhov <igor@dilos.org> Reviewed by: Andy Fiddaman <andy@omniosce.org> Approved by: Robert Mustacchi <rm@fingolfin.org>

view details

Toomas Soome

commit sha fdb2a7e9480266dfaa0b5aaa0e1237456552f332

12881 sparcv9: add __multi3 Reviewed by: Robert Mustacchi <rm@fingolfin.org> Reviewed by: Andrew Stormont <andyjstormont@gmail.com> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Jason King

commit sha 480497bc2ff96b447dc09403a6c187a1593ac1ec

12934 sockfs rights test should close unneeded descriptors Reviewed by: Dan McDonald <danmcd@joyent.com> Reviewed by: Robert Mustacchi <rm@fingolfin.org> Approved by: Richard Lowe <richlowe@richlowe.net>

view details

Robert Mustacchi

commit sha 4a663bac9c5f9f82a5f633bc9639bbee3c2317ff

12904 Update nvme health logpage and temp thresholds Reviewed by: C Fraire <cfraire@me.com> Reviewed by: Paul Winder <paul@winder.uk.net> Approved by: Richard Lowe <richlowe@richlowe.net>

view details

Toomas Soome

commit sha 7e9964352166d31ee78f8ed0e600c9e32d9d72a4

12891 eri: this 'if' clause does not guard... Reviewed by: Andy Fiddaman <andy@omniosce.org> Reviewed by: Peter Tribble <peter.tribble@gmail.com> Reviewed by: Igor Kozhukhov <igor@dilos.org> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Jerry Jelinek

commit sha 2fc9ab6e6080d66d8dc6b967cea7ba24bee8c7e5

12793 kernel FPU support Portions contributed by: Robert Mustacchi <rm@fingolfin.org> Reviewed by: C Fraire <cfraire@me.com> Reviewed by: Ryan Zezeski <ryan@zinascii.com> Reviewed by: Jason King <jason.king@joyent.com> Reviewed by: Toomas Soome <tsoome@me.com> Reviewed by: Patrick Mooney <pmooney@pfmooney.com>

view details

Jason King

commit sha 1a5ae140ba142cafb59ab08b3212c4ebbce84f32

12506 Add support to vioblk for DISCARD operation Reviewed by: Robert Mustacchi <rm@fingolfin.org> Reviewed by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Paul Winder

commit sha 234a3cfbeb41cab4c47872d4972632d855f56d2b

12931 The number of tx/rx queue pairs can exceed the i40e's capabilities Reviewed by: Robert Mustacchi <rm@fingolfin.org> Reviewed by: Garrett D'Amore <garrett@damore.org> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Toomas Soome

commit sha 415535b1f3a5b13ac8fe4938b44c5f5688f82237

12888 mdb: error: variable set but not used Reviewed by: Robert Mustacchi <rm@fingolfin.org> Approved by: Hans Rosenfeld <rosenfeld@grumpf.hope-2000.org>

view details

Alexander Stetsenko

commit sha 4e065a9f6a4471f1001853cd10a093bc5beb58a5

12513 SMB 3.1.1 support for server Reviewed by: Matt Barden <mbarden@tintri.com> Reviewed by: Gordon Ross <gordon.w.ross@gmail.com> Approved by: Robert Mustacchi <rm@fingolfin.org>

view details

Paul Winder

commit sha 5f0e3176f407dfb9d989b5dcc94a6d5384d0b142

12797 mlxcx max flow table limit can be exceeded 12798 mlxcx command interface should allow concurrent commands and be interrupt driven 12799 mlxcx #if defined for MAC_VLAN_UNTAGGED is redundant 12890 mlxcx uses excessive stack space causing stack overflow panic Reviewed by: Garrett D'Amore <garrett@damore.org> Reviewed by: Andy Stormont <astormont@racktopsystems.com> Reviewed by: Robert Mustacchi <rm@fingolfin.org> Reviewed by: Alex Wilson <alex@cooperi.net> Approved by: Dan McDonald <danmcd@joyent.com>

view details

push time in 3 months

issue commentillumos/libdwarf

README update about branches & git commits?

When I started this, we were using the tarballs. However there hasn't been a release in a while and I think using the actual history plus our patches is actually more useful. At this point, since we never used the 191104 I should remove that. I was waiting until I actually had a working version in order. I'll take another swing at updating this and the example branches.

danmcd

comment created time in 3 months

create barnchrmustacc/illumos-gate

branch : imc-dev

created branch time in 3 months

delete branch rmustacc/illumos-gate

delete branch : bge-dev

delete time in 3 months

delete branch rmustacc/illumos-gate

delete branch : ufm-dev

delete time in 3 months

delete branch rmustacc/illumos-gate

delete branch : kfpu-dev

delete time in 3 months

push eventrmustacc/illumos-gate

Mike Zeller

commit sha cf7690ebb38fa81bd6f3904ba5ad4649c0ea3c0b

12897 bhyve mevent can mistakenly handle events twice Reviewed by: Patrick Mooney <pmooney@pfmooney.com> Reviewed by: Andy Fiddaman <andy@omniosce.org> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Jason King

commit sha cfcec26617a5b667ad909c32c24594a670c98b2d

12856 pkcs11_softtoken should validate session and object handles Reviewed by: Robert Mustacchi <rm@fingolfin.org> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Patrick Mooney

commit sha 3c2d4f391c2bc4b3b4126c0757329835c80781ed

12907 epoll_ctl can avoid EINTR entirely Reviewed by: Ryan Zezeski <rpz@joyent.com> Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com> Approved by: Robert Mustacchi <rm@fingolfin.org>

view details

Patrick Mooney

commit sha 87bfe94c15340e9846f25201fa63446ac956d845

12908 epoll should exclude normal files/directories Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com> Reviewed by: Robert Mustacchi <rm@joyent.com> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Robert Mustacchi

commit sha 1ec776a9bf2feedbaca6e140fb724fcb09774cad

12830 Want centralized ksensor framework 12831 temperature sensors could describe accuracy 12832 topo support for generic PCI device temp sensors Reviewed by: Ryan Zezeski <ryan@zinascii.com> Reviewed by: Toomas Soome <toomas@me.com>

view details

Robert Mustacchi

commit sha abe23778932ab58d1444a860d4096cbd62155cd6

12833 Rewrite pchtemp to use the ksensor framework Reviewed by: Ryan Zezeski <ryan@zinascii.com> Reviewed by: Toomas Soome <toomas@me.com>

view details

Robert Mustacchi

commit sha 5ea87af068acf9b995a7675ed5f19f20210e2dd1

12834 Rewrite amdbnbtemp to use the ksensor framework Reviewed by: Ryan Zezeski <ryan@zinascii.com> Reviewed by: Toomas Soome <toomas@me.com>

view details

Robert Mustacchi

commit sha 6b04d5e1c3869f7da626b0b924bb026ca0813b9f

12835 Want support for I350 temperature sensor Reviewed by: Ryan Zezeski <ryan@zinascii.com> Reviewed by: Toomas Soome <toomas@me.com>

view details

Robert Mustacchi

commit sha 0f476ac76d1f73fec036969a0b594f997d6e3eb4

XXXXX Rewrite coretemp to use the ksensor framework XXXXX coretemp had the wrong granularity

view details

push time in 3 months

push eventrmustacc/illumos-gate

Andy Fiddaman

commit sha 61de0de2b543856b77c5769b0d8981f58a7f26bd

12829 Add Zstandard to /etc/magic Reviewed by: Toomas Soome <tsoome@me.com> Reviewed by: Robert Mustacchi <rm@fingolfin.org> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Jason King

commit sha b30f02def0d29c7f2398666939cf35cf81f809f1

12850 demangle(1) can trip up on names starting with underscore Reviewed by: Andrew Stormont <andyjstormont@gmail.com> Reviewed by: Yuri Pankov <ypankov@tintri.com> Reviewed by: Toomas Soome <tsoome@me.com> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Toomas Soome

commit sha ae121a1498fc4947aa90fa23f0276b59938ed62e

12571 pcisch: NULL pointer errors Reviewed by: Yuri Pankov <ypankov@tintri.com> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Toomas Soome

commit sha 772852a5d3501d23ca0f77fcdbd7ddb0a25da28b

12546 pcieb: NULL pointer errors Reviewed by: Robert Mustacchi <rm@fingolfin.org> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Jason King

commit sha 989c147e4f8311ee853a577bac8009cc7ffc4a73

12796 pcks11_softtoken C_GetMechanismList() should validate its arguments Reviewed by: Andrew Stormont <andyjstormont@gmail.com> Reviewed by: Sebastian Wiedenroth <wiedi@frubar.net> Reviewed by: Juraj Lutter <juraj@lutter.sk> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Ryan Zezeski

commit sha 99ad48a445346f36969661ed214f75b99e19a9a7

12754 packet flow over a defaulted LACP port Reviewed by: Dan McDonald <danmcd@joyent.com> Reviewed by: Andrew Stormont <andyjstormont@gmail.com> Reviewed by: Igor Kozhukhov <igor@dilos.org> Approved by: Robert Mustacchi <rm@fingolfin.org>

view details

Robert Mustacchi

commit sha 6682e4c38cf4cf5fd5fc490fac27f3d7af9bab4c

12875 igb I211 doesn't have an nvm version which leads to ufm panic Reviewed by: Igor Kozhukhov <igor@dilos.org> Reviewed by: Patrick Mooney <pmooney@pfmooney.com> Approved by: Richard Lowe <richlowe@richlowe.net>

view details

Toomas Soome

commit sha ce5f7fb896fce369b4ec50da6d3a232bce2458ce

12836 loader: strings in nvlist are counted strings, not c-strings Reviewed by: Igor Kozhukhov <igor@dilos.org> Reviewed by: C Fraire <cfraire@me.com> Reviewed by: Andy Fiddaman <andy@omniosce.org> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Andy Fiddaman

commit sha d865fc92e4b640c73c2957a20b3d82622c741be5

12824 recvmsg(): adjust final cmsg->cmsg_len upon MSG_CTRUNC Reviewed by: Robert Mustacchi <rm@fingolfin.org> Reviewed by: Igor Kozhukhov <igor@dilos.org> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Toomas Soome

commit sha c686756220120076a07be0dcce54be698101a3d1

12541 sgs: smatch and NULL pointer errors Reviewed by: Yuri Pankov <ypankov@tintri.com> Reviewed by: Gary Mills <gary_mills@fastmail.fm> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Toomas Soome

commit sha 44db26e7361c4574265471e293de16d6063dd990

12878 check_rtime: missing entries Reviewed by: Yuri Pankov <ypankov@tintri.com> Reviewed by: Andy Fiddaman <andy@omniosce.org> Approved by: Joshua M. Clulow <josh@sysmgr.org>

view details

Patrick Mooney

commit sha b58b977e8fdb738e19dfe72999e4f57a62e9d05f

12869 bhyve kernel/user split should be clearer Reviewed by: Mike Zeller <mike.zeller@joyent.com> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Patrick Mooney

commit sha e156a47b6ebcf79f0515365c32a22c7ed38dc19b

12871 bhyve ioctls needn't the struct size Reviewed by: Mike Zeller <mike.zeller@joyent.com> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Toomas Soome

commit sha e386029b3dc09ced91c6806c9767572be25b584b

12879 sparc: unresolved dependencies Reviewed by: Andy Fiddaman <andy@omniosce.org> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Toomas Soome

commit sha 2ca761b0b92364bea5ec829f3ac6187c20057a0a

12880 sparc: pkglint errors Reviewed by: Andy Fiddaman <andy@omniosce.org> Reviewed by: Alexander Pyhalov <apyhalov@gmail.com> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Dan McDonald

commit sha ed5ba7eb5b9baea17a09428feca1d7cfdc912cbf

12816 Update Intel microcode to 20200616 Reviewed by: Andy Fiddaman <andy@omniosce.org> Approved by: Robert Mustacchi <rm@fingolfin.org>

view details

Robert Mustacchi

commit sha 207eb048d59b803f49e5ebdbfdb1ed33848b198f

12872 ioctl(2) needs additional ENOTTY documentation Reviewed by: Ryan Zezeski <ryan@zinascii.com> Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Toomas Soome

commit sha 4df3b64db8cae3f054ccdd573395ba7807bcd868

12654 nxge: smatch and NULL pointer errors Reviewed by: Michael Speer <michael.speer@pluribusnetworks.com> Reviewed by: Yuri Pankov <ypankov@tintri.com> Reviewed by: Igor Kozhukhov <igor@dilos.org> Reviewed by: Vitaliy Gusev <gusev.vitaliy@icloud.com> Approved by: Dan McDonald <danmcd@joyent.com>

view details

Toomas Soome

commit sha dfecc46651d2b074027544a9c03682fd51d51054

12661 null.h: enable NULL pointer for SPARC Reviewed by: Gergő Mihály Doma <domag02@gmail.com> Reviewed by: Andrew Stormont <andyjstormont@gmail.com> Approved by: Robert Mustacchi <rm@fingolfin.org>

view details

Richard Lowe

commit sha 9b9e3196fde9c0f47c8cc4ab00f3bc5b539ceaca

12770 stop including exception unwind info in the kernel Reviewed by: Patrick Mooney <pmooney@pfmooney.com> Reviewed by: Andy Fiddaman <andy@omniosce.org> Reviewed by: Toomas Soome <tsoome@me.com> Reviewed by: Andrew Stormont <andyjstormont@gmail.com> Approved by: Dan McDonald <danmcd@joyent.com>

view details

push time in 3 months

create barnchrmustacc/illumos-gate

branch : coretemp-dev

created branch time in 3 months

push eventrmustacc/illumos-gate

Robert Mustacchi

commit sha 4d46ad5e34d9dff53a3ea9cde446f9ecb08ac306

12835 Want support for I350 temperature sensor Change-Id: I2616f224559ed10ea24f18c4c422684ab219000e

view details

push time in 3 months

push eventrmustacc/illumos-gate

Robert Mustacchi

commit sha d2171b0c2a99eb4755e330a9480cc84a833f0eca

12830 Want centralized ksensor framework 12831 temperature sensors could describe accuracy 12832 topo support for generic PCI device temp sensors Change-Id: If1e854934a3493626b1218fab931507d17aa087d

view details

Robert Mustacchi

commit sha c9c81f88680ad57fae3da4913e061c61e83f0e4a

12833 Rewrite pchtemp to use the ksensor framework Change-Id: Iab00ff40cb6bc1e88f8e03e6c77d5eb3d5a06ff5

view details

Robert Mustacchi

commit sha 4cbd85a439b12c074689d55f8ce804991ee8a4a8

12834 Rewrite amdbnbtemp to use the ksensor framework Change-Id: Ia9793812ceec01a0aabd8a7611f466255d30770f

view details

Robert Mustacchi

commit sha ea384b8551c62238903524ffed835b42bfb1c97e

12835 Want support for I350 temperature sensor Change-Id: I2616f224559ed10ea24f18c4c422684ab219000e

view details

push time in 3 months

issue openedrust-lang/rust

missing struct declaration type leads to confusing type ascription diagnostic

While trying to get started with rust, I was attempting to declare a global instance of a struct for various reasons (integrating into a device driver framework). This was based on the nightly toolchain because of some other nightly features. Having written a lot of C, but not a lot of rust, I mistakenly declared a structure leaving out the type on the right hand side of the equals sign. This led to a relatively confusing message about type ascription. Here's a reduced version of the code that generates this as of version rustc 1.46.0-nightly (16957bd4d 2020-06-30) though I first encountered this on rustc 1.44.0-nightly (b77aefb76 2020-04-14).

#![crate_type="staticlib"]
#![feature(extern_types)]
#![feature(lang_items)]
#![no_std]

use core::panic::PanicInfo;

const MODREV_1: i32 = 1;

#[repr(C)]
struct IllumosModLinkage {
    ml_rev: i32,
}

#[no_mangle]
static RMOD_MODLINKAGE: IllumosModLinkage = {
        ml_rev: MODREV_1,
};

#[lang = "eh_personality"]
extern fn eh_personality() {}
#[panic_handler]
fn panic(_info: &PanicInfo) -> ! {
    loop {}
}

When building this with a nightly rustc you receive the following error message:

$ rustc example.rs 
error: expected one of `!`, `(`, `.`, `::`, `;`, `<`, `?`, or `}`, found `,`
  --> example.rs:17:25
   |
17 |         ml_rev: MODREV_1,
   |               -         ^ expected one of 8 possible tokens
   |               |
   |               tried to parse a type due to this type ascription
   |
   = note: `#![feature(type_ascription)]` lets you annotate an expression with a type: `<expr>: <type>`
   = note: see issue #23416 <https://github.com/rust-lang/rust/issues/23416> for more information

error: aborting due to previous error

While I now understand that this was trying to use type ascription incidentally, this sent me initially down the path of trying to figure out what type ascription was and a number of wrong paths. I know at one point I did try to add the feature there, as it seems to be suggesting that, but that didn't change anything. Upon better understanding the problem and what I did wrong, I wouldn't expect adding the feature to have changed anything, but when getting started these messages are usually pretty helpful in indicating what to change or what's going on which is what led me to try it.

If there's some way to indicate that someone might have left a type declaration out in this case, that might be useful and help save someone else who's learning some time in the future.

created time in 3 months

issue commentoxidecomputer/dropshot

need TLS support

A related question is what types of TLS do we need to support? For example, rustls seems not to support TLS v1.1 or v1.0, which is reasonable. It'd be nice to only get away with supporting TLS v1.2+.

davepacheco

comment created time in 3 months

more