profile
viewpoint
Nikola Ristić rista404 Serbia ristic.io web developer, acrobat

rista404/deno-debug 7

Debugging utility for deno. Ported from https://npmjs.com/debug

rista404/golang-docker-heroku 1

An example app using heroku's docker support to deploy a golang app

rista404/meteor-email-whitelist 1

Make sure that only unicorns :rainbow: with specific email addresses can register to your app. Great for testing and beta access!

rista404/next-project-kickstart 1

Future-proof project kickstart - ES2015, CSSNext, NPM scripts 🤘🏻🚀

rista404/Advanced-React 0

Starter Files and Solutions for Full Stack Advanced React and GraphQL

rista404/algorithms 0

Collection of algorithms in multiple programming languages

rista404/awesome-deno 0

🎉A curated list of awesome things related to Deno

rista404/berry 0

📦🐈 The active development trunk for Yarn 2 ⚒

rista404/blocked-by-bot 0

Github App for cross-referencing issues as blocking 🛑

rista404/cli 0

The GitHub CLI

push eventrista404/deno-debug

rista404

commit sha 345a3c55de4fc0c48bef9e94e81dbd18ac699730

Add miliseconds formatting back

view details

push time in 3 days

issue commentSNathJr/ghost-on-heroku

Add support for Theme upload

I managed to upload my theme with these steps:

heroku git:clone -a your-app
cd your-app
git remote add origin https://github.com/SNathJr/ghost-on-heroku
git pull origin master
# extract zip file of your theme inside `content/themes` dir
# remove content/themes from .gitignore
git commit -am "Add theme"
git push heroku master # deploys the theme
aayushdutt

comment created time in 5 days

startedamacneil/dbmate

started time in 5 days

push eventrista404/deno-debug

João Moura

commit sha 6ca6b69a7a2dcb95952a71426a2a8bd93d042837

Changed stderr to console.log (#4) Co-authored-by: João Moura <joao.moura@b-i.com>

view details

push time in 11 days

PR merged rista404/deno-debug

Changed stderr to console.log

Some of the logs were not being printed out, I tried to move from stderr to stdout but the issue continued. The only way I was able to get all the logs showing was by using console.log instead of stderr. I was not able to understand why it happened. In terms of testing, I've put a console.log on the function log(...args: any[]): void { just before the stderr, and I was getting the logs from that but not from stderr. I've created this small PR so that you can also check if you have the same issue.

+2 -2

3 comments

1 changed file

JWebCoder

pr closed time in 11 days

pull request commentrista404/deno-debug

Changed stderr to console.log

Hey @JWebCoder thanks for another PR! I've checked the discussion, and yeah, looks like console.log is best. std/log uses console.log by default also. https://deno.land/std/log/handlers.ts#L85

JWebCoder

comment created time in 11 days

startedmswjs/msw

started time in 12 days

startedcortesi/modd

started time in 13 days

PR opened dchenk/go-render-quill

Add syntax highlighting to README example

Just a small thingy to make it look nicer. Thanks for the package!

+1 -1

0 comment

1 changed file

pr created time in 13 days

push eventrista404/go-render-quill

Nikola Ristić

commit sha 1ada6b3a1d7817c8c7090811b3ddcb2f426841dc

Add syntax highlighting to README example

view details

push time in 13 days

fork rista404/go-render-quill

Render Quill insert Delta operations to HTML

fork in 13 days

startedvalyala/quicktemplate

started time in 13 days

startedexchangeratesapi/exchangeratesapi

started time in 16 days

startedjulienschmidt/httprouter

started time in 16 days

push eventrista404/sizes

rista404

commit sha f7561be4ce58ba263b8b35182ba448569e9e312d

Sort by aplha or size

view details

rista404

commit sha 9a3d05fd3641f56976844b84f5f56ea98d50adf0

Add sort flag

view details

push time in 20 days

push eventrista404/deno-debug

rista404

commit sha edd6b663abb88360c7d3e682f81505933de0c729

Support NO_COLOR

view details

push time in 20 days

push eventrista404/deno-debug

rista404

commit sha e2a9fcbbc1bdd0835def3c077e3a807c826c434c

Type `this` to remove the need for tsconfig.json

view details

rista404

commit sha 2dded692e33e6c06683c9427747d59e04c44077b

Update README.md

view details

push time in 20 days

push eventrista404/deno-debug

rista404

commit sha ac19b21f3db448f858dccceda4597c44bca66f74

Add github action for testing

view details

push time in 20 days

push eventrista404/deno-debug

rista404

commit sha 9e35a143bbbcdfacff6b0d1971db7b461f47ee2c

Add github action for testing

view details

push time in 20 days

push eventrista404/deno-debug

rista404

commit sha ad97abf66311d09abdc23d39064711a1b81a6277

Add github action for testing

view details

push time in 20 days

create barnchrista404/deno-debug

branch : gh-ci

created branch time in 20 days

push eventrista404/deno-debug

rista404

commit sha aaf5e6ac247e85108be914892980143a67752401

Update travis.yml

view details

push time in 20 days

push eventrista404/deno-debug

rista404

commit sha 28b4798a4802a05c2ab2419aae596a7929e34931

Update Makefile + cleanup

view details

push time in 20 days

push eventrista404/deno-debug

João Moura

commit sha 5cfaaa005aab6ecb15c23229fd5cce91754a2d91

Added support for latest Deno version (#3) * Updated code to work on the lasted deno version * Removed unwanted logs * Removed the logs from the format.ts Co-authored-by: João Moura <joao.moura@b-i.com>

view details

push time in 20 days

PR merged rista404/deno-debug

Added support for latest Deno version

There were several issues around the module. I've updated it to work on the latest Deno version and I also updated the code on the tests.

I removed the ms module because that one also has issues with the latest Deno, I pretend to make a pull request there if I'm able to fix it, and then I'll try to come here again and reinsert it.

I've also added a new tsconfig file.

For tests use: deno test --allow-env -c tsconfig.json

+103 -114

1 comment

7 changed files

JWebCoder

pr closed time in 20 days

pull request commentrista404/deno-debug

Added support for latest Deno version

Hey @JWebCoder thanks for updating this! 🎉 I saw there were a number of breaking changes. I'll merge this and we'll introduce ms back in once https://github.com/denolib/ms/pull/3 is merged.

JWebCoder

comment created time in 20 days

startedfxmontigny/quill-image-upload

started time in 24 days

startedjuggle/resize-observer

started time in 25 days

push eventrista404/cli

Nikola Ristic

commit sha 1f9b7c0fe09f3c8c6cc7715f462fd39f779d5c3f

Disable interactive only if both flags are passed Co-authored-by: Mislav Marohnić <mislav@github.com>

view details

push time in a month

startedevanw/esbuild

started time in a month

startedkelseyhightower/envconfig

started time in a month

startedquilljs/quill

started time in a month

startedkataras/iris

started time in a month

push eventrista404/test-repo

rista404

commit sha b54f6fa4274c1eb16559ae08c70c9b62ce0faeec

Add space to frontmatter

view details

push time in a month

push eventrista404/test-repo

rista404

commit sha 45b0a9a03381322102d4750bd291255938b7cfbd

Add space to yaml frontmatter

view details

push time in a month

push eventrista404/test-repo

rista404

commit sha 52001c98fbc4a32f3094e6ed8957383dff454d04

Add more issue templates

view details

push time in a month

push eventrista404/test-repo

rista404

commit sha b41776648ce899dc0186de1cf7f515ef9b74b1d8

Move issue template to it's dir

view details

push time in a month

push eventrista404/test-repo

rista404

commit sha 6fe97aed8c68b2106c930427f3cbeb34f1aeda1c

Add another issue template

view details

push time in a month

push eventrista404/test-repo

rista404

commit sha dae57589b524f9434208de46b06b0797174edcf3

Add issue templates

view details

push time in a month

push eventrista404/cli

UmairShahzad

commit sha de77e78ef57b0764d87ecf8de5d6aaa1ceb81afa

added pr count string before printing PRs

view details

UmairShahzad

commit sha c546fd863d1d52fa64f13cb14cba84dfb94a91ab

Merge remote-tracking branch 'cli/master' into pr-count

view details

UmairShahzad

commit sha 906f49659fa85e3496425454371519302cec36ed

updated title and tests

view details

UmairShahzad

commit sha c50f6f324e97c9b4192f2ccb7aaad9ceec67ee18

updated list tests

view details

UmairShahzad

commit sha 94ef4bb3774bb8ee9b8641c5478287bde827383c

switched title to fn literal

view details

UmairShahzad

commit sha bb0fe46db6df745d32e64bb7ca337044ab3748a7

total match count in title

view details

UmairShahzad

commit sha 1a485ddd2e8ddef1623af280a17c2245f30653f4

Merge remote-tracking branch 'cli/master' into pr-count

view details

UmairShahzad

commit sha 7589da4c2bf7653ec2cdc8460e02b684e213741c

removed extra import

view details

mingrammer

commit sha 39ea067328c386313074211a55641d038fb30455

fix: inconsistent format between issue list and status

view details

UmairShahzad

commit sha b8a7c871420e959166ef50adf3595a7a3732d146

Merge remote-tracking branch 'cli/master' into pr-count

view details

UmairShahzad

commit sha 3c687ed11113bf5508579f1b4d21c7663c7edb3a

moved getTitle to common; changed title string

view details

UmairShahzad

commit sha 0c9909c2307e266987574f28a7b2da4986a96bfa

pluralize match if total == 1

view details

UmairShahzad

commit sha 945d4ffb554600874e7d30288a09e7310f672600

Merge branch 'master' of https://github.com/cli/cli into pr-count

view details

UmairShahzad

commit sha 77a6caa84ddedd2d466bcf2731dc903b8b7f6559

test for all possible titles

view details

UmairShahzad

commit sha debedf98cf28c9963c82aa1c947dc974c96c111a

include int in command reset to reset 'Limit'

view details

Mislav Marohnić

commit sha 1ba577ca36a9c8401886b2f372cd0a112b79e37a

Merge remote-tracking branch 'origin/master' into pr-count

view details

Mislav Marohnić

commit sha 5518c013f3776be4d2b8f2b5aaf986a1ef83bd16

Indicate that the default `issue list` state is "open"

view details

Mislav Marohnić

commit sha 3d48d40b69b28a7f5c5887b8cc3427984062c76b

Simplify `getTitle` and rename it to `listHeader`

view details

Mislav Marohnić

commit sha 9cd53b8f190af984a91b6343c6d090bae92570de

Simplify `listHeader` tests

view details

mingrammer

commit sha 0d38f1f6dce0fe9bbb5857d2aae3952dc3d6882b

fix: don't truncate field (tablewriter will do)

view details

push time in a month

pull request commentcli/cli

Disable interactive mode for `issue create` if any flag is passed

@mislav I updated the PR, but let me know if anything needs to be changed!

rista404

comment created time in a month

push eventrista404/cli

UmairShahzad

commit sha de77e78ef57b0764d87ecf8de5d6aaa1ceb81afa

added pr count string before printing PRs

view details

UmairShahzad

commit sha c546fd863d1d52fa64f13cb14cba84dfb94a91ab

Merge remote-tracking branch 'cli/master' into pr-count

view details

UmairShahzad

commit sha 906f49659fa85e3496425454371519302cec36ed

updated title and tests

view details

UmairShahzad

commit sha c50f6f324e97c9b4192f2ccb7aaad9ceec67ee18

updated list tests

view details

UmairShahzad

commit sha 94ef4bb3774bb8ee9b8641c5478287bde827383c

switched title to fn literal

view details

UmairShahzad

commit sha bb0fe46db6df745d32e64bb7ca337044ab3748a7

total match count in title

view details

UmairShahzad

commit sha 1a485ddd2e8ddef1623af280a17c2245f30653f4

Merge remote-tracking branch 'cli/master' into pr-count

view details

UmairShahzad

commit sha 7589da4c2bf7653ec2cdc8460e02b684e213741c

removed extra import

view details

mingrammer

commit sha 39ea067328c386313074211a55641d038fb30455

fix: inconsistent format between issue list and status

view details

UmairShahzad

commit sha b8a7c871420e959166ef50adf3595a7a3732d146

Merge remote-tracking branch 'cli/master' into pr-count

view details

UmairShahzad

commit sha 3c687ed11113bf5508579f1b4d21c7663c7edb3a

moved getTitle to common; changed title string

view details

UmairShahzad

commit sha 0c9909c2307e266987574f28a7b2da4986a96bfa

pluralize match if total == 1

view details

UmairShahzad

commit sha 945d4ffb554600874e7d30288a09e7310f672600

Merge branch 'master' of https://github.com/cli/cli into pr-count

view details

UmairShahzad

commit sha 77a6caa84ddedd2d466bcf2731dc903b8b7f6559

test for all possible titles

view details

UmairShahzad

commit sha debedf98cf28c9963c82aa1c947dc974c96c111a

include int in command reset to reset 'Limit'

view details

Mislav Marohnić

commit sha 1ba577ca36a9c8401886b2f372cd0a112b79e37a

Merge remote-tracking branch 'origin/master' into pr-count

view details

Mislav Marohnić

commit sha 5518c013f3776be4d2b8f2b5aaf986a1ef83bd16

Indicate that the default `issue list` state is "open"

view details

Mislav Marohnić

commit sha 3d48d40b69b28a7f5c5887b8cc3427984062c76b

Simplify `getTitle` and rename it to `listHeader`

view details

Mislav Marohnić

commit sha 9cd53b8f190af984a91b6343c6d090bae92570de

Simplify `listHeader` tests

view details

mingrammer

commit sha 0d38f1f6dce0fe9bbb5857d2aae3952dc3d6882b

fix: don't truncate field (tablewriter will do)

view details

push time in a month

startedcharmbracelet/glamour

started time in a month

issue openedrista404/test-repo

test

b

created time in a month

issue openedrista404/test-repo

Test

created time in a month

issue openedrista404/test-repo

title and body

body

created time in a month

issue openedrista404/test-repo

only title

created time in a month

issue openedrista404/test-repo

only title

created time in a month

PR opened cli/cli

Show "Awaiting triage" for empty project state

I added tests, but let me know if you want a separate test case for that.

@doi-t I hope it's okay I jumped on this one!

Closes #818

+28 -4

0 comment

6 changed files

pr created time in a month

create barnchrista404/cli

branch : project-state-empty-818

created branch time in a month

pull request commentcli/cli

Disable interactive mode for `issue create` if all flags are passed

@mislav so just to confirm:

gh issue create # interactive
gh issue create -t title # not interactive
gh issue create -t title -b "" # not interactive
gh issue create -t title -b "body foo bar" # not interactive
gh issue create -b "body foo bar" # error, title is required
rista404

comment created time in a month

Pull request review commentcli/cli

Disable interactive mode for `issue create` if all flags are passed

 func issueCreate(cmd *cobra.Command, args []string) error {  	action := SubmitAction -	interactive := title == "" || body == ""+	interactive := !cmd.Flags().Changed("title") || !cmd.Flags().Changed("body")

Yes, that’s exactly how it works. Even if value passed matches the default, Changed will be true.

rista404

comment created time in a month

PR opened cli/cli

Disable interactive mode for `issue create` if all flags are passed

Another possibility is to not prompt the user interactively if title is passed. See @mislav comment in the issue.

Closes #807

+1 -1

0 comment

1 changed file

pr created time in a month

issue openedrista404/test-repo

title

created time in a month

push eventrista404/cli

rista404

commit sha fc071531658402849869e23410d2d1f1b89d1851

Enable interactive mode only if flags aren't passed

view details

push time in a month

create barnchrista404/cli

branch : interactive-when-defaults-807

created branch time in a month

issue openedrista404/test-repo

title

created time in a month

issue openedrista404/test-repo

title

created time in a month

issue openedrista404/test-repo

title

created time in a month

push eventrista404/cli

Mislav Marohnić

commit sha aa07c5366eebc5498f4993afda7e6a26ebb5545f

Add support for PowerShell completion

view details

Mislav Marohnić

commit sha fa595596de2bd4f3fcb1cd51a029dff6311150eb

Improve `completion` docs

view details

Mislav Marohnić

commit sha f9c32654e9c2c0195a8b93b506822a18a9413988

Fix setting homepage URL in `repo create`

view details

Mislav Marohnić

commit sha 7777307588a0a952c4188ea687d0a620091d3dc3

Avoid forking/pushing until `pr create` inputs have been processed This avoids fork or push operation if there were errors processing the input arguments or if the operation has been cancelled during interactive survey.

view details

Mislav Marohnić

commit sha d584a9692c68a7e9ad711614eb906efab137669b

Raise error if `--draft` was used in `pr create --web` Since we cannot pass the "draft" option as query parameter, this raises an error instead of proceeding to open the browser and potentially confuse the user as to why `--draft` wasn't respected.

view details

rista404

commit sha e739d95c933067ba93d111183b75cd851f29187d

Show state instead of checks for closed/merged PRs

view details

Eddú Meléndez

commit sha 8e7ba907b195bf03f8ccb0ecb4d0595a740c93be

Add filter issues by author

view details

Joe Previte

commit sha a6f06f80847cc084f863bc5f135fac93412ffdb2

feat: update README

view details

Mislav Marohnić

commit sha 42b40b11791e552d4b465a02fd44f1c759ea2f57

No longer need to opt into `pe_mobile` API flag `pe_mobile` was required to get access to `reviewDecision` and `statusCheckRollup`, but both are now public in GitHub API.

view details

Mislav Marohnić

commit sha 7c11f7655a2ac4349e765e671216f2e984e3e5af

No need to opt in to `shadow-cat` API preview This was needed for draft pull requests, but these APIs were public since Feburary 2020.

view details

Eddú Meléndez

commit sha 2a87dabf59498c12030413d61d784446f5a71f4b

Remove unused fields

view details

Amanda Pinsker

commit sha 7f9cceccbd98116b899d2bb836ec5e176182b8b6

Make the README title a little less verbose

view details

Billy Griffin

commit sha f32235aa08df21aa74f2c0a3c4d6f6cc40ea0ca1

Move docs to docs folder The docs were just hanging out in the top level repo and we thought it'd be nicer to start to organize them together.

view details

Billy Griffin

commit sha 159a697159f5a4f0b7e1e5d68d55d779d24994b0

Add README to docs folder

view details

sibis

commit sha 0cef66dc674bd9324e51176b197dc36d9603380d

Verify repo before viewing in the browser

view details

rista404

commit sha e803470b03318758b9bf8aa37198f786bc998659

Print merged/closed in the same line as PR title

view details

Billy Griffin

commit sha 601a934a996ee3edd5636672e004b3baa28ddf94

Merge pull request #630 from cli/create-docs Move docs to docs folder

view details

Billy Griffin

commit sha a00a48d0b6cedd9d85b65f6dfa1c5149d19b978f

Document comparison with hub

view details

Billy Griffin

commit sha 12ba3f6389821c58c85fd43395315c9e4449bed0

Add reference to hub comp in README

view details

Billy Griffin

commit sha 21419531e37d522b03024a5ab4977293e239a79c

Add links to docs

view details

push time in a month

startedmaxchehab/phelia

started time in a month

create barnchrista404/sizes

branch : master

created branch time in a month

created repositoryrista404/sizes

created time in a month

startedcloudfoundry/bytefmt

started time in a month

startedAssemblyScript/assemblyscript

started time in a month

startedtinygo-org/tinygo

started time in a month

startedaletheia-icu/broccoli

started time in a month

push eventrista404/dotfiles

rista404

commit sha 44dc7bcdf992b46f4b7159283e6a27b590fc1463

Updates

view details

push time in 2 months

startedgraphql-nexus/nexus

started time in 2 months

startedzeit/swr

started time in 2 months

pull request commentcli/cli

Show state instead of checks/reviews for closed/merged PRs

Looks neat 👌

image

rista404

comment created time in 3 months

push eventrista404/cli

rista404

commit sha e803470b03318758b9bf8aa37198f786bc998659

Print merged/closed in the same line as PR title

view details

push time in 3 months

PR opened cli/cli

Show state instead of checks/reviews for closed/merged PRs

Hey! I tried to follow conventions for adding tests, but let me know if you need anything changed!

image

Closes #613

+127 -25

0 comment

4 changed files

pr created time in 3 months

create barnchrista404/cli

branch : pr-state-merged-closed-613

created branch time in 3 months

PR opened rista404/test-repo

Test 4
+0 -0

0 comment

2 changed files

pr created time in 3 months

create barnchrista404/test-repo

branch : test-2

created branch time in 3 months

delete branch rista404/test-repo

delete branch : test-2

delete time in 3 months

push eventrista404/test-repo

Nikola Ristic

commit sha d3fefb4ebec1ffff400b74e300b31bf492c82e42

Test 3 (#5)

view details

push time in 3 months

PR merged rista404/test-repo

Test 3
+0 -0

0 comment

1 changed file

rista404

pr closed time in 3 months

PR opened rista404/test-repo

Test 3
+0 -0

0 comment

1 changed file

pr created time in 3 months

PR closed rista404/test-repo

Test 2
+0 -0

0 comment

1 changed file

rista404

pr closed time in 3 months

push eventrista404/cli

Mislav Marohnić

commit sha 9175fc06d40d8cea9a03a60750e59828ecb36267

Add preliminary `repo create` command

view details

vilmibm

commit sha 6eaab2562fe2b9ce27daad250cccf3b3667c28c1

add repo fork command

view details

vilmibm

commit sha 99ac0cb87df6e2b8e4d7db6bc2e49be42f9b6eb3

add StubWithFixture helper

view details

vilmibm

commit sha 4f25d06c1e2818c71841b9cabfdf5f560496e041

add repo fork tests

view details

vilmibm

commit sha ded870714f0c4ef3364926863f82ff980b135373

add SetAuthLogin helper to blank context

view details

vilmibm

commit sha 8a3337ca66d819e723f42fddadc87f3dc9b0b8e9

switch default to Y

view details

vilmibm

commit sha 1217bfce0917a5a0b2d3db76a112b95d39ecdc6a

add spinner helper

view details

Mislav Marohnić

commit sha b02dac8f0bb53e596c4e88be21ff43867e031892

Accept more repo fields via flags to `repo create`

view details

vilmibm

commit sha 6371864835c6943df149c3e9c4d1fa39768a2045

spruce up UX

view details

vilmibm

commit sha e38c15e2c9dd00ee6a2f9cc88df721cdb1add427

fix ellipsis color

view details

Mislav Marohnić

commit sha 4a56280ab5366b61c2ec3679cad1771dc5399256

Automatically add `origin` remote after `repo create`

view details

Mislav Marohnić

commit sha 4e97a0e05d6032c1e8771d513392dd67b206896f

Have correct command be run in `repo clone` test

view details

vilmibm

commit sha 256bdabf03576e4f5a9998a2fb6d2f117042e2a5

slight refactor I didn't initially use GitHubRepo because it had the weird error wrapping. I poked around and I think this function is leftover from a vestigial GitHubRepoID function that used to be more single-purpose. I took out the weird error handling so it could be reused and then used it from the new GitHubRepoExists.

view details

vilmibm

commit sha 115bf37bbd119c61e77637b86ffb2528d333e972

switch to --clone/--remote

view details

vilmibm

commit sha 7fad2d05fb43dc03cb195580c44aee91a5acb111

switch to alternate method for determining if repo already forked

view details

vilmibm

commit sha 8c473a27799ad46817bb357ae0506c213619ef86

shorten some english

view details

vilmibm

commit sha 3019137133a8d3d57f9fab0a10a06ef5512157f8

no longer needed

view details

vilmibm

commit sha 5d44d9f483ce48b3b758be1a9533e7d7f9ecc3e5

tweak flag settings

view details

vilmibm

commit sha bb65bda62f69100473079a0db0db29a993dc67fe

escape codes in errors render v poorly in windows

view details

Mislav Marohnić

commit sha 201217d88ab075eb92482a61649865d822cde365

Fix detecting PR for current branch pushed to fork Now passing base repo as reference to `prSelectorForCurrentBranch()` so that it doesn't have to (inexactly) determine the base repo itself and risk it being different than the base repo determined during `pr status/view`.

view details

push time in 3 months

issue openedrista404/test-repo

Issue 2

created time in 3 months

issue openedrista404/test-repo

Issue 1

created time in 3 months

push eventrista404/cli

Toshiya Doi

commit sha b7893b1fd3f13a16ece16bd0c9bbda59c0a41918

Query pullRequests of the current branch regardless of its state

view details

Toshiya Doi

commit sha b9656835944f22b2deb22d797ec2a79fbd8b3119

Append a pull request status for the current branch

view details

Toshiya Doi

commit sha 28460e4b7e5048430fb92457380d1d8a92a943d3

Change a PR state color

view details

Toshiya Doi

commit sha 9c44eaeb6ec93937b8b62fd74e9954557c5f2aa6

Define an order clause to sort PRs newest first

view details

Dasio

commit sha 8aa46c236e4ae29adb493164c69456f196dd157e

Init slice with provided capacity if it's known in advance

view details

Dasio

commit sha 9289ab99f2ce79d1d1640a555a186f02a26209f6

Use var syntax when empty struct is initialized

view details

Toshiya Doi

commit sha 957adc1cff90e0b6c6be4aaa6b068530871db6e1

Change a PR number's color based on its PR status

view details

Mislav Marohnić

commit sha d25ec726adec3bc5b3112233103eb44bebd7051b

Add `repo clone <repo>` command

view details

Nate Smith

commit sha d4012b1312073289c2723d0ad074eb522295794d

Merge pull request #545 from cli/repo-clone Add `repo clone <repo>` command

view details

rista404

commit sha 2a42f61d8d676c84acd5ab008efed9b9eeada8d1

Use gray color for PR number if PR is a draft

view details

Nate Smith

commit sha 39bdeee13b7a36be24d12ddc6a88f4ab8e2f6923

Merge pull request #550 from rista404/draft-pr-212 Use gray color for PR number if PR is a draft

view details

Toshiya Doi

commit sha 8b31b283f53b103cd3f231b592462e0838c19df2

Merge branch 'master' into issue-467

view details

Dasio

commit sha 19cc79cac89304bef3dfece1fdf7c564c0ce453a

Removed explicit capacity in slice initialization

view details

Micheal Looney

commit sha a0cb79af41a0b6e5a5a05de79e443decc033881c

Print details of authentication workaround to terminal Mitigates https://github.com/cli/cli/issues/297 This adds some more information to the output when authentication fails due to `gh` being unable to open a browser. It communicates the details of the workaround without the user having to search issues on the `gh` repo to see how to get around it.

view details

Toshiya Doi

commit sha 5f152a349dff5617a51638d352f7c7ad8596503d

Print merged and closed PRs of the current branch along with an opening PR

view details

Nate Smith

commit sha 714266d91e3adb574c5b1e3229bf1fd7cd026f42

Merge pull request #553 from looneym/ml/output-workaround Print details of authentication workaround to terminal

view details

Mislav Marohnić

commit sha 55b66feb423019879fa1ce6a7718a79b6b7ff0c0

Merge pull request #542 from Dasio/slice-initialization Slice initialization

view details

Myk

commit sha 038e5e534221e6d9d1ad7c9b76bc389b45bb4671

Accept `#<num>` syntax as issue/PR number

view details

Mislav Marohnić

commit sha f5b0354ae3bc5bf62aa6a9308a0cea2f12653bf4

Fix tests

view details

Mislav Marohnić

commit sha adf2177a2443417eb443f6fdc8a776f8db33bf5c

Merge pull request #474 from politas/fix/StripHash Handle properly passed #<num> as equivalent to <num> for PRs and Issues

view details

push time in 3 months

pull request commentcli/cli

Fix detecting PR for current branch pushed to fork

@mislav this doesn't work for my test forked repo, the currentPRHeadRef doesn't have the OWNER bit.

Actually in my testing the other day, I've found that git.ReadBranchConfig() would return empty RemoteURL and RemoteName, because running git config --get-regexp '^branch.test-branch.*$' would return nothing (pattern '^branch.*.*$' wouldn't include that branch). It would only work after doing:

git remote add upstream git://github.com/username/base-repo.git
git branch -u upstream/test-branch

Since I'm not an expert in working with forked repos, I just assumed this was expected. Because RemoteURL and RemoteName were both empty, prSelectorForCurrentBranch wouldn't define branchOwner and that // prepend OWNER: would never run.

Hope this helps!

mislav

comment created time in 3 months

pull request commentcli/cli

Compare full head label for determining current PR

@mislav thanks for the review/explanation! I'll jump on #567 👍

rista404

comment created time in 3 months

more