profile
viewpoint

rfermann/eslint-plugin-import 0

ESLint plugin with rules that help validate proper imports.

rfermann/mui-datatables 0

Datatables for React using Material-UI - https://www.material-ui-datatables.com

rfermann/next.js 0

The React Framework

rfermann/type-graphql 0

Create GraphQL schema and resolvers with TypeScript, using classes and decorators!

Pull request review commentalexcanessa/typescript-coverage-report

Add support for `--ignore-catch` and fix multi-word CLI flag bug

 export default async function generateCoverageReport(   const data = await getCoverage({     strict: options.strict,     debug: options.debug,-    ignoreFiles: options["ignore-files"],-    ignoreCatch: options["ignore-catch"],-    ignoreUnread: options["ignore-unread"],+    ignoreFiles: options.ignoreFiles,+    ignoreCatch: options.ignoreCatch,+    ignoreUnread: options.ignoreUnread,     cache: options.cache

True, good future improvement

dignite

comment created time in 2 hours

push eventalexcanessa/typescript-coverage-report

allcontributors[bot]

commit sha 888771b450044ecd44c5283e4686bc9d106ec4b7

docs: update README.md [skip ci]

view details

allcontributors[bot]

commit sha bc861fd215a1ebb86807f797a94facf28037c86c

docs: update .all-contributorsrc [skip ci]

view details

Alex Canessa

commit sha 633f5c769209048472d0c887adc7d69fd097daa3

Merge pull request #42 from alexcanessa/all-contributors/add-dignite docs: add dignite as a contributor

view details

push time in 5 hours

delete branch alexcanessa/typescript-coverage-report

delete branch : all-contributors/add-dignite

delete time in 5 hours

PR merged alexcanessa/typescript-coverage-report

docs: add dignite as a contributor

Adds @dignite as a contributor for code.

This was requested by alexcanessa in this comment

+11 -1

0 comment

2 changed files

allcontributors[bot]

pr closed time in 5 hours

push eventalexcanessa/typescript-coverage-report

Daniel Edholm Ignat

commit sha c84c92cb5e3233b5f8667d95a74bc76adde400ca

feat: use typeCoverage.ignoreCatch from package.json

view details

Daniel Edholm Ignat

commit sha b9d3e7aa7802b24d38f0a23b319414381939bb19

fix: respect multi-word cli flags commander.js converts to camelCase, meaning we picked the wrong value (always defaultValue). Fixed by manually picking options and keeping camelCase throughout.

view details

Alex Canessa

commit sha 99a0aa5b921ffa61957ece844584c3d27988d955

Merge pull request #41 from dignite/ignore-catch Add support for `--ignore-catch` and fix multi-word CLI flag bug

view details

push time in 5 hours

PR merged alexcanessa/typescript-coverage-report

Add support for `--ignore-catch` and fix multi-word CLI flag bug

Fixes #40

Also fixes bug where multi-word command line options were not working. Options ignore-files and ignore-unread were read correctly from package.json but could not be set with cli flags.

+26 -67

2 comments

6 changed files

dignite

pr closed time in 5 hours

issue closedalexcanessa/typescript-coverage-report

Suggestion: Use ignoreCatch option from type-coverage

Is your feature request related to a problem? Please describe. The ignoreCatch option is not currently implemented.

Describe the solution you'd like Enable the option.

Additional context This feature was missing from #33 and reported by https://github.com/alexcanessa/typescript-coverage-report/issues/33#issuecomment-729946011

closed time in 5 hours

alexcanessa

pull request commentalexcanessa/typescript-coverage-report

Add support for `--ignore-catch` and fix multi-word CLI flag bug

@alexcanessa

I've put up a pull request to add @dignite! :tada:

dignite

comment created time in 5 hours

PR opened alexcanessa/typescript-coverage-report

docs: add dignite as a contributor

Adds @dignite as a contributor for code.

This was requested by alexcanessa in this comment

+11 -1

0 comment

2 changed files

pr created time in 5 hours

push eventalexcanessa/typescript-coverage-report

allcontributors[bot]

commit sha bc861fd215a1ebb86807f797a94facf28037c86c

docs: update .all-contributorsrc [skip ci]

view details

push time in 5 hours

push eventalexcanessa/typescript-coverage-report

allcontributors[bot]

commit sha 888771b450044ecd44c5283e4686bc9d106ec4b7

docs: update README.md [skip ci]

view details

push time in 5 hours

pull request commentalexcanessa/typescript-coverage-report

Add support for `--ignore-catch` and fix multi-word CLI flag bug

@all-contributors add @dignite for code

dignite

comment created time in 5 hours

Pull request review commentalexcanessa/typescript-coverage-report

Add support for `--ignore-catch` and fix multi-word CLI flag bug

 export default async function generateCoverageReport(   const data = await getCoverage({     strict: options.strict,     debug: options.debug,-    ignoreFiles: options["ignore-files"],-    ignoreCatch: options["ignore-catch"],-    ignoreUnread: options["ignore-unread"],+    ignoreFiles: options.ignoreFiles,+    ignoreCatch: options.ignoreCatch,+    ignoreUnread: options.ignoreUnread,     cache: options.cache

Not a show blocker anyway

dignite

comment created time in 5 hours

Pull request review commentalexcanessa/typescript-coverage-report

Add support for `--ignore-catch` and fix multi-word CLI flag bug

 export default async function generateCoverageReport(   const data = await getCoverage({     strict: options.strict,     debug: options.debug,-    ignoreFiles: options["ignore-files"],-    ignoreCatch: options["ignore-catch"],-    ignoreUnread: options["ignore-unread"],+    ignoreFiles: options.ignoreFiles,+    ignoreCatch: options.ignoreCatch,+    ignoreUnread: options.ignoreUnread,     cache: options.cache

At this point might as well pass option to getCoverage

dignite

comment created time in 5 hours

Pull request review commentalexcanessa/typescript-coverage-report

Add support for `--ignore-catch` and fix multi-word CLI flag bug

 program   )   .parse(argvWithVersion(process.argv)); -const options = getOptions(program);

I'm ok to remove the getOptions function if you want. The limit of commander is that unfortunately doesn't give you the defaultValue when you try to access it.

dignite

comment created time in 5 hours

issue commentalexcanessa/typescript-coverage-report

Suggestion: Use ignoreCatch option from type-coverage

Correction: ignoreCatch not ignoreCache ❤️

Oops.

alexcanessa

comment created time in 8 hours

PR opened alexcanessa/typescript-coverage-report

Add support for `--ignore-catch` and fix multi-word CLI flag bug

Fixes #40

Also fixes bug where multi-word command line options were not working. Options ignore-files and ignore-unread were read correctly from package.json but could not be set with cli flags.

+26 -67

0 comment

6 changed files

pr created time in a day

issue commentalexcanessa/typescript-coverage-report

Suggestion: Use ignoreCache option from type-coverage

Correction: ignoreCatch not ignoreCache ❤️

alexcanessa

comment created time in a day

issue commentalexcanessa/typescript-coverage-report

Suggestion: Use all options from type-coverage package

@dignite ok great!

I've created an issue #40, it should be pretty straight forward to implement.

alexcanessa

comment created time in a day

issue openedalexcanessa/typescript-coverage-report

Suggestion: Use ignoreCache option from type-coverage

Is your feature request related to a problem? Please describe. The ignoreCache option is not currently implemented.

Describe the solution you'd like Enable the option.

Additional context This feature was missing from #33 and reported by https://github.com/alexcanessa/typescript-coverage-report/issues/33#issuecomment-729946011

created time in a day

issue openedgregnb/mui-datatables

OnRowClick show modal (NextJS)

I am using MUI Datatables onRowClick:

onRowClick: rowData => Testing(rowData),

Which should output the following with the function and show a modal with the data:

function Testing(rowData) {
    console.log(rowData)
    return (
       <div className="modal-popup">
        <div className="modal-popup--inner is-flex">
          <h2>Modal content</h2>
          <ul>
            {rowData.map(item => {
              return <li key={item}>{item}</li>
            }
            )}
          </ul>
          </div>
        </div>
    )
  }

The data runs in console showing the json but unfortunately no modal is shown. How could this be improved and how could this be implemented correctly so that onrowclick a modal with the row data is shown?

created time in a day

issue closedgregnb/mui-datatables

Applying object type values ​​to dropdown filters

<!--- Provide a general summary of the issue in the Title above --> image image <!-- Thank you very much for contributing to MUI-datatables by creating an issue! ❤️ -->

Expected Behavior

{"pipeline":{"$skip":0,"$limit":10,"$match":{"$and":[{"paid_method":{"$regex":"^.⏲가상계좌.$"}}]}}}

When a filter is selected and confirmed, the filter list is fetched and parameters are sent to the server. However, the item “⏲가상계좌” is stored as “a” in the actual database. Can I work this way?

Code to dynamically generate columns

`setHeaderColumns ( metaData.viewListMeta.items.map(($meta, index) => {

      let obj = {
        name: $meta.id, // field name in the row object
        label: $meta.name, // column title that will be shown in table
        options: {
          filter: searchList.includes($meta.id),
          filterType: searchType($meta.lego?.name ? $meta.lego?.name : 'text')
        }
      }

      if(searchType($meta.lego?.name ? $meta.lego?.name : 'text') == "dropdown"){
        let codeItem = [];
        let nameItem = [];

        if($meta.hasOwnProperty('dataCode') && $meta.hasOwnProperty('dataCodes')){
          $meta.dataCodes.map((dataCode, index) => {
            //codeItem.push(`${dataCode._name} : <div>${dataCode._code}</div>`);
            codeItem.push(dataCode._code);
            nameItem.push(dataCode._name);
          })
        }
        obj.options.customFilterListOptions = { render: v => `${$meta.name} : ${v}` };
        obj.options.filterOptions = { 
          names: nameItem
         };
        //
      }

      return obj;
    })
  )`

click the confirm button

` onFilterConfirm: (filterList) => { handleMatchParamMapping(filterList); }

const handleMatchParamMapping = (filterList) => { filterColumn = [];

for(let i in filterList) {
  if(filterList[i].length > 0) {
    let mappingObject = {};
    
    mappingObject[headerColumns[i].name] = filterList[i].toString();
    filterColumn.push(mappingObject);
  }
}

};

`

closed time in 2 days

developergunny

issue commentalexcanessa/typescript-coverage-report

Suggestion: Use all options from type-coverage package

@dignite you're right, I think I thought that enableCache = false would be the same as ignoreCache. Is it not?

Hi! Sorry for the short answer that follows, busy day :(

The flag I'm talking about is ignore catch, which ignores type coverage on the error parameter in catch clauses, which has to be any by design.

alexcanessa

comment created time in 2 days

issue commentalexcanessa/typescript-coverage-report

Suggestion: Use all options from type-coverage package

@dignite you're right, I think I thought that enableCache = false would be the same as ignoreCache. Is it not?

alexcanessa

comment created time in 2 days

issue openedalexcanessa/typescript-coverage-report

Suggestion: Support TypeScript 4.x

Is your feature request related to a problem? Please describe.

package.json requires a version of typescript compatible with 3.8: https://github.com/alexcanessa/typescript-coverage-report/blob/d4c6dd04baa0499ba709f5922cb1711b4aa7252f/package.json#L23

TypeScript doesn't really do semver, so I'd be surprised if this package isn't compatible with TS 4.x. I think it should allow it!

Describe the solution you'd like

Change this line to allow either ^3.8.3 or ^4.0.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context

I've run into a few symbols that typescript-coverage-report flags as any that are not any when using the latest version of TS.

created time in 3 days

issue commentgregnb/mui-datatables

How to disable 'Sort' tooltip / hint?

Hi, Is there a way to display a custom tooltip with { hint : "my tooltip" } instead of displaying "sort" even if sorting is enabled ?

andygock

comment created time in 3 days

IssuesEvent

issue closedgregnb/mui-datatables

Localize to jumpToPage

Hello, thank you for great material table! Please add localization for "jumpToPage" image

closed time in 4 days

nospoon27

issue commentgregnb/mui-datatables

Localize to jumpToPage

@noobtiger

https://codesandbox.io/s/muidatatables-custom-toolbar-forked-ioesi?file=/index.js

  const options = {
    jumpToPage: true,
    textLabels: {
    pagination: {
      jumpToPage: 'Jump To Page Text~~'
    },
    }
  };

Has already been added. It's missing in readme.md. It seems that only needs to be modified.

nospoon27

comment created time in 4 days

more