Latest master.

[----------] 3 tests from rpc
[ RUN      ] rpc.CheckBlockToJSONReturnsMinifiedSolution
Assertion failed: lock cs_main not held in rpc/blockchain.cpp:224; locks held:
Process 67111 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = breakpoint 10.4
    frame #0: 0x00007fff2037c389 libsystem_c.dylib`abort
libsystem_c.dylib`abort:
->  0x7fff2037c389 <+0>: pushq  %rbp
    0x7fff2037c38a <+1>: movq   %rsp, %rbp
    0x7fff2037c38d <+4>: pushq  %r15
    0x7fff2037c38f <+6>: pushq  %r14
Target 0: (zcash-gtest) stopped.
(lldb) bt
warning: could not execute support code to read Objective-C class data in the process. This may reduce the quality of type information available.
* thread #1, queue = 'com.apple.main-thread', stop reason = breakpoint 10.4
  * frame #0: 0x00007fff2037c389 libsystem_c.dylib`abort
    frame #1: 0x0000000100e69f37 zcash-gtest`AssertLockHeldInternal(pszName="cs_main", pszFile="rpc/blockchain.cpp", nLine=224, cs=0x0000000101759520) at sync.cpp:188:5
    frame #2: 0x0000000100821558 zcash-gtest`blockToJSON(block=0x00007ffeefbfe7b0, blockindex=0x00007ffeefbfe5b0, txDetails=false) at blockchain.cpp:224:5
    frame #3: 0x0000000100393bfb zcash-gtest`rpc_CheckBlockToJSONReturnsMinifiedSolution_Test::TestBody(this=0x000000010470a510) at test_rpc.cpp:26:20
    frame #4: 0x000000010050031b zcash-gtest`void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) + 123
    frame #5: 0x00000001004d760a zcash-gtest`void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) + 106
    frame #6: 0x00000001004d7556 zcash-gtest`testing::Test::Run() + 182
    frame #7: 0x00000001004d8377 zcash-gtest`testing::TestInfo::Run() + 199
    frame #8: 0x00000001004d9103 zcash-gtest`testing::TestCase::Run() + 227
    frame #9: 0x00000001004e45f7 zcash-gtest`testing::internal::UnitTestImpl::RunAllTests() + 647
    frame #10: 0x0000000100503a1b zcash-gtest`bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) + 123
    frame #11: 0x00000001004e410a zcash-gtest`bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) + 106
    frame #12: 0x00000001004e3feb zcash-gtest`testing::UnitTest::Run() + 203
    frame #13: 0x0000000100002ba3 zcash-gtest`RUN_ALL_TESTS() at gtest.h:2341:46
    frame #14: 0x0000000100002799 zcash-gtest`main(argc=1, argv=0x00007ffeefbfef00) at main.cpp:48:14
    frame #15: 0x00007fff20442f3d libdyld.dylib`start + 1
(lldb) disass
libsystem_c.dylib`abort:
->  0x7fff2037c389 <+0>:   pushq  %rbp
    0x7fff2037c38a <+1>:   movq   %rsp, %rbp
    0x7fff2037c38d <+4>:   pushq  %r15
    0x7fff2037c38f <+6>:   pushq  %r14
    0x7fff2037c391 <+8>:   pushq  %rbx
    0x7fff2037c392 <+9>:   subq   $0x18, %rsp
    0x7fff2037c396 <+13>:  cmpq   $0x0, 0x603d70fa(%rip)    ; gCRAnnotations + 7
    0x7fff2037c39e <+21>:  jne    0x7fff2037c3ae            ; <+37>
    0x7fff2037c3a0 <+23>:  leaq   0x6ca9(%rip), %rax        ; "abort() called"
    0x7fff2037c3a7 <+30>:  movq   %rax, 0x603d70ea(%rip)    ; gCRAnnotations + 8
    0x7fff2037c3ae <+37>:  callq  0x7fff2037d088            ; symbol stub for: pthread_self
    0x7fff2037c3b3 <+42>:  movq   %rax, %r14
    0x7fff2037c3b6 <+45>:  leaq   0x603a49f3(%rip), %rax    ; __cleanup
    0x7fff2037c3bd <+52>:  movq   (%rax), %rcx
    0x7fff2037c3c0 <+55>:  testq  %rcx, %rcx
    0x7fff2037c3c3 <+58>:  je     0x7fff2037c3c9            ; <+64>
    0x7fff2037c3c5 <+60>:  xorl   %eax, %eax
    0x7fff2037c3c7 <+62>:  callq  *%rcx
    0x7fff2037c3c9 <+64>:  leaq   -0x28(%rbp), %r15
    0x7fff2037c3cd <+68>:  movl   $0xfffff9df, (%r15)       ; imm = 0xFFFFF9DF 
    0x7fff2037c3d4 <+75>:  leaq   -0x1c(%rbp), %rsi
    0x7fff2037c3d8 <+79>:  orl    $-0x1, (%rsi)
    0x7fff2037c3db <+82>:  pushq  $0x3
    0x7fff2037c3dd <+84>:  popq   %rbx
    0x7fff2037c3de <+85>:  movl   %ebx, %edi
    0x7fff2037c3e0 <+87>:  xorl   %edx, %edx
    0x7fff2037c3e2 <+89>:  callq  0x7fff2037d10c            ; symbol stub for: sigprocmask
    0x7fff2037c3e7 <+94>:  pushq  $0x1
    0x7fff2037c3e9 <+96>:  popq   %rdi
    0x7fff2037c3ea <+97>:  callq  0x7fff2037cc08            ; symbol stub for: __pthread_workqueue_setkill
    0x7fff2037c3ef <+102>: movl   %ebx, %edi
    0x7fff2037c3f1 <+104>: movq   %r15, %rsi
    0x7fff2037c3f4 <+107>: xorl   %edx, %edx
    0x7fff2037c3f6 <+109>: callq  0x7fff2037d094            ; symbol stub for: pthread_sigmask
    0x7fff2037c3fb <+114>: pushq  $0x6
    0x7fff2037c3fd <+116>: popq   %rsi
    0x7fff2037c3fe <+117>: movq   %r14, %rdi
    0x7fff2037c401 <+120>: callq  0x7fff2037d046            ; symbol stub for: pthread_kill
    0x7fff2037c406 <+125>: movl   $0x2710, %edi             ; imm = 0x2710 
    0x7fff2037c40b <+130>: callq  0x7fff20329414            ; usleep$NOCANCEL
    0x7fff2037c410 <+135>: callq  0x7fff2037c415            ; __abort

Upgraded from 1.6.3 without ever running any BlazeSync betas.

Steps: Upgrade to 1.7.0

What happened:

Expected result: Wallet syncs from where it left off last time.

Notes: Restore from seed worked afterwards.

https://yewtu.be/watch?v=XzgDiyD4pU0

Title: Missing hash key: "adaptiveFormats" (KeyError) Date: 2021-06-29T20:16:17Z Route: /watch?v=XzgDiyD4pU0 Version: 2021.06.27-bfc5500 @ master <details> <summary>Backtrace</summary> <p>

Missing hash key: "adaptiveFormats" (KeyError)
  from /usr/share/crystal/src/hash.cr:1027:11 in '[]'
  from /usr/share/crystal/src/json/any.cr:102:7 in '[]'
  from src/invidious/videos.cr:769:34 in 'is_vr'
  from src/invidious/views/watch.ecr:61:13 in 'handle'
  from src/invidious.cr:299:1 in '->'
  from /usr/share/crystal/src/primitives.cr:255:3 in '->'
  from /usr/share/crystal/src/primitives.cr:255:3 in 'process_request'
  from lib/kemal/src/kemal/route_handler.cr:17:7 in 'call'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call_next'
  from lib/kemal/src/kemal/websocket_handler.cr:13:14 in 'call'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call_next'
  from lib/kemal/src/kemal/filter_handler.cr:21:7 in 'call'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call_next'
  from src/invidious/helpers/handlers.cr:212:5 in 'call'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call_next'
  from src/invidious/helpers/handlers.cr:94:12 in 'call'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call_next'
  from src/invidious/helpers/handlers.cr:145:12 in 'call'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call_next'
  from src/invidious/helpers/handlers.cr:70:5 in 'call'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call_next'
  from src/invidious/helpers/static_file_handler.cr:189:11 in 'call'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call_next'
  from lib/kemal/src/kemal/exception_handler.cr:8:7 in 'call'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call_next'
  from src/invidious/helpers/logger.cr:17:35 in 'call'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call_next'
  from lib/kemal/src/kemal/init_handler.cr:12:7 in 'call'
  from /usr/share/crystal/src/http/server/request_processor.cr:51:11 in 'process'
  from /usr/share/crystal/src/http/server.cr:513:5 in 'handle_client'
  from /usr/share/crystal/src/http/server.cr:468:13 in '->'
  from /usr/share/crystal/src/primitives.cr:255:3 in 'run'
  from /usr/share/crystal/src/fiber.cr:92:34 in '->'
  from ???

</p> </details>