profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/rebornix/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Peng Lyu rebornix Microsoft Seattle https://rebornix.com @Microsoft developer on Visual Studio Code

octref/polacode 6458

📸 Polaroid for your code

auchenberg/vscode-browser-preview 4395

A real browser preview inside your editor that you can debug.

Chillee/VSCodeNeovim 321

A rewrite of VSCodeVim, backed by neovim. Still in development, not meant for use.

microsoft/vscode-sublime-keybindings 223

Sublime Text Keymap extension for VS Code

microsoft/vscode-atom-keybindings 130

Port of Atom Keybindings for VS Code.

rebornix/DotBadge 22

C# port of Shields-style badge library.

rebornix/debugger.html 6

The Firefox debugger that works anywhere :boom:

rebornix/docker-guillotine-sample 3

Docker sample for guillotine, which is currently used by GitHub to shorten URLs

push eventmicrosoft/vscode

rebornix

commit sha 6dbf7a16057fa929008effce400420bc459762eb

show folding indicator always when it is collapsed.

view details

push time in 7 hours

push eventmicrosoft/vscode

rebornix

commit sha a5832d17f9bc7888ea49a4d1ce84c58fced13163

fix #132306.

view details

push time in 9 hours

issue closedmicrosoft/vscode

Opening an existing notebook marks it dirty unnecessarily

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions --> <!-- 🔎 Search existing issues to avoid creating duplicates. --> <!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ --> <!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --> <!-- 🔧 Launch with code --disable-extensions to check. --> Does this issue occur when all extensions are disabled?: Yes

<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --> <!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->

  • VS Code Version: Stable 1.60
  • OS Version: Mac

Steps to Reproduce:

  1. Open the following ipynb file (with all extensions disabled)
  2. The file is marked dirty
{
 "cells": [
  {
   "cell_type": "code",
   "execution_count": 1,
   "source": [
    "# for i in range(0,100000):\n",
    "#     print(i)   \n",
    "ls"
   ],
   "outputs": [
    {
     "output_type": "stream",
     "name": "stdout",
     "text": [
      "debugxxx.py\t\tone.three copy 4.ipynb\tsimplePrint.py\n",
      "matplotSample.py\tone.three copy.ipynb\tsmpleWidget.py\n",
      "one.three copy 2.ipynb\tone.three.ipynb\t\tvarViewer.py\n",
      "one.three copy 3.ipynb\tprogressSmaple.py\n"
     ]
    }
   ],
   "metadata": {}
  }
 ],
 "metadata": {
  "orig_nbformat": 4,
  "language_info": {
   "name": "bash",
   "codemirror_mode": "shell",
   "mimetype": "text/x-sh",
   "file_extension": ".sh"
  },
  "kernelspec": {
   "name": "bash",
   "display_name": "Bash",
   "language": "bash"
  },
  "interpreter": {
   "hash": "f18a24808323baba3f9918eb0e4209d5af5f08701b6de1422ac2b2f2ac830fb7"
  }
 },
 "nbformat": 4,
 "nbformat_minor": 2
}

closed time in 9 hours

DonJayamanne

issue closedmicrosoft/vscode

Can't set text focus in first line of first cell

Really strange bug.

  • VS Code Version: Version: 1.61.0-insider (user setup) Commit: 53aff5e347865fe22f9487ebd54dec9db23773b2 Date: 2021-09-23T13:51:38.771Z Electron: 13.4.0 Chrome: 91.0.4472.164 Node.js: 14.16.0 V8: 9.1.269.39-electron.0 OS: Windows_NT x64 10.0.22458

  • OS Version: Windows 11

Steps to Reproduce:

  1. Open any notebook. (I've reprod with github-issues and .ipynb files)
  2. Add a single cell to the notebook with a single line
  3. Try to click in the text of the first line to set the caret.

Doesn't take. It will if you click just slightly below the bottom of the text. recording (8)

closed time in 11 hours

greazer

issue commentmicrosoft/vscode

Can't set text focus in first line of first cell

Fixed via e5346784113c927ee03b4df9ced8e7c49a77215f

greazer

comment created time in 11 hours

push eventmicrosoft/vscode

rebornix

commit sha e5346784113c927ee03b4df9ced8e7c49a77215f

update insert toolbar position.

view details

push time in 11 hours

issue commentmicrosoft/vscode

Can't drag cells over pandas report output

Trying to fix this issue and ended up with calculating the real clientY by e.clientY + e.view.frameElement.getBoundingClientRect().y. It works with the pandas output in the test notebook but I don't have confidence that it will always work, especially when the iframe's origin is unique (then e.view.frameElement would be undefined) or the output is a nested iframe (it makes the offset check diffcult).

I wonder if we should do something similar as how we handle scrollbar dragging for notebook. When we are dragging the vertical scrollbar, we will add a transparent div on top of the webview, to ensure that the drag event is not stolen by the webview (which will break the scrollbar smooth scrolling). Maybe we can do the same for markdown dragging.

roblourens

comment created time in a day

issue closedmicrosoft/vscode

Native Notebooks - Undo Not Working

  • VS Code Version: 1.58.0-insider

Steps to Reproduce:

  1. Put code in cell 1
  2. Put code in a cell that is off screen, requires scrolling to see it (let's call this cell x)
  3. Scroll back up such that cell 1 is back in sight and try to undo using ctrl z
  4. Scroll back down to cell x and try to undo using ctrl z

Actual Behavior: Undo doesn't work the first time and requires some scroll trial and error before it works

undo broken

closed time in a day

claudiaregio

issue commentmicrosoft/vscode

Native Notebooks - Undo Not Working

I seem to be unable to undo a cell that got scrolled out of view.

This is actually a side effect of us changing the default value of notebook.undoRedoPerCell. When it's set to true (the default value), to undo a change in a cell out of viewport, users need to scroll to the cell and focus in the editor and then perform undo. When it's set to false (a window reload is required after changing the setting), the undo/redo of cells is on the same undo stack so you can still perform undo when the focus is on another cell.

claudiaregio

comment created time in a day

issue commentmicrosoft/vscode

Shift+click highlights wrong cell range after rearranging cells

@roblourens I can't reproduce this with the steps you provided in latest OSS, can you help confirm?

roblourens

comment created time in a day

push eventmicrosoft/vscode

rebornix

commit sha 2069b19ee6b9dba891e57e221af0c27203811083

fix #132457.

view details

push time in a day

issue closedmicrosoft/vscode

Native Notebooks - Editor + Output font style do not match

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions --> <!-- 🔎 Search existing issues to avoid creating duplicates. --> <!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ --> <!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --> <!-- 🔧 Launch with code --disable-extensions to check. --> Does this issue occur when all extensions are disabled?: Yes

<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --> <!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->

  • VS Code Version: 1.59.1
  • OS Version: macOS 11.3.1

Steps to Reproduce:

Create a Jupyter notebook with "Hello world" as content execute it and look at the rendered output:

image

This was reported previously in the now locked https://github.com/microsoft/vscode/issues/119214. It seems to have been fixed a few months ago but the fix is obviously not working for me. Even the font face is different, let alone its size.

closed time in a day

memeplex

push eventmicrosoft/vscode

rebornix

commit sha c8b2adbb1e8f824f7e08164bf88b31a659717bd9

fix #132314.

view details

push time in a day

issue closedmicrosoft/vscode

Cannot select & copy text on hover boxes

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions --> <!-- 🔎 Search existing issues to avoid creating duplicates. --> <!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ --> <!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --> <!-- 🔧 Launch with code --disable-extensions to check. --> Does this issue occur when all extensions are disabled?: unknown

<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --> <!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->

  • VS Code Version:
  • OS Version:
Version: 1.60.0
Commit: e7d7e9a9348e6a8cc8c03f877d39cb72e5dfb1ff
Date: 2021-09-01T10:54:53.442Z
Electron: 13.1.8
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Darwin x64 20.6.0

Steps to Reproduce:

  1. Open a Python notebook in VSCode
  2. Hover over the code till a box shows up, and select and ctrl+c the text and paste into another place. It copies all the code in the cell instead of the selected text inside the hover box.

https://user-images.githubusercontent.com/5494367/132078448-c5a382aa-af48-41df-b6e3-316e70b23517.mov

closed time in a day

jingw222

push eventmicrosoft/vscode

rebornix

commit sha 1ca0acfeff29666436d487bfd0f19905b479b920

fix #131996

view details

push time in a day

issue closedmicrosoft/vscode

Ctrl+H in interactive window input box results in warning popup

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions --> <!-- 🔎 Search existing issues to avoid creating duplicates. --> <!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ --> <!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --> <!-- 🔧 Launch with code --disable-extensions to check. --> Does this issue occur when all extensions are disabled?: Yes/No

<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --> <!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->

  • VS Code Version: 1.60-insider
  • OS Version: Windows 10

Steps to Reproduce:

  1. Jupyter: Create Interactive Window
  2. Place cursor in input box, hit Ctrl+H
  3. 🐛 Popup appears with message 'cannot read property replace of null'

image

closed time in a day

joyceerhl

push eventmicrosoft/vscode

rebornix

commit sha 40c787fcc55784b8a50bd54cf3e3f7cdb7e9a34c

:lipstick:

view details

push time in a day

push eventmicrosoft/vscode

rebornix

commit sha 24eebe98875a16a388d574815414865da4001e65

fix #130790.

view details

push time in a day

issue closedmicrosoft/vscode

Notebook UI not updated with changes to the model

Please use

  • Latest VS Code Insiders
  • Custom branch of Jupyter extension (se below) PR in Jupyter extension https://github.com/microsoft/vscode-jupyter/pull/7100
    • Use the VSIX generated in the above PR (one of the assets in the CI is the Jupyter VSIX)
    • Or use the corresponding branch of the above PR

Please note: As we're no longer awaiting on the promises, any errors thrown will be ignored completely. We don't even await on <Execution Task>.end

Steps to repro Create first cell with the following code:

from IPython.display import Markdown
dh = display(display_id=True)

Run the above cell, then run the following cell:

dh.update(Markdown("foo"))

After you run the second cell, the first cell should have an output foo. Collapse the first cell & expand it, and you'll see foo appear, basically its a refresh issue.

closed time in a day

DonJayamanne

issue openedmicrosoft/vscode

Support color customization for session restore hint

Issue Type: <b>Bug</b>

We may want to allow color customization for the foregroud/background for the session restore hint message

VS Code version: Code - Insiders 1.61.0-insider (53aff5e347865fe22f9487ebd54dec9db23773b2, 2021-09-23T13:51:38.771Z) OS version: Windows_NT x64 10.0.19043 Restricted Mode: No

<details> <summary>System Info</summary>

Item Value
CPUs Intel(R) Core(TM) i7-9700K CPU @ 3.60GHz (8 x 3600)
GPU Status 2d_canvas: enabled<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>oop_rasterization: enabled<br>opengl: enabled_on<br>rasterization: enabled<br>skia_renderer: enabled_on<br>video_decode: enabled<br>vulkan: disabled_off<br>webgl: enabled<br>webgl2: enabled
Load (avg) undefined
Memory (System) 31.93GB (12.48GB free)
Process Argv --enable-proposed-api joyceerhl.vscode-pyolite --enable-proposed-api rebornix.better-jupyter-errors --enable-proposed-api donjayamanne.kusto --crash-reporter-id e73ca734-e67c-473d-8c47-80c5407fc859
Screen Reader no
VM 0%

</details> <!-- generated by issue reporter -->

created time in a day

issue closedmicrosoft/vscode

Notebook with large outputs do not render properly

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- 🕮 Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions --> <!-- 🔎 Search existing issues to avoid creating duplicates. --> <!-- 🧪 Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ --> <!-- 💡 Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --> <!-- 🔧 Launch with code --disable-extensions to check. --> Does this issue occur when all extensions are disabled?: Yes

<!-- 🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --> <!-- 📣 Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->

  • VS Code Version: 1.60 (user setup)
    • and Version: 1.61.0-insider (user setup) with command Code - Insiders.exe --disable-extension
  • OS Version: Windows_NT x64 10.0.19043

Steps to Reproduce:

  1. Load a .ipynb file with large outputs. An example file: https://github.com/isshiki/MLnotebooks/blob/master/v06_ohe-hyperparam-tuning.ipynb
  2. The rendering process with large outputs keeps looping and does not render outputs, as shown below 2021-09-07_19h17_37

This happens only in 1.60 and not when reverting to 1.59. Therefore, I think it may be due to the following improvement.

closed time in 2 days

isshiki

issue commentmicrosoft/vscode

Notebook with large outputs do not render properly

As confirmed it's fixed.

isshiki

comment created time in 2 days

issue commentmicrosoft/vscode

Notebook diff shows false information

@claudiaregio I lableled https://github.com/microsoft/vscode/issues/133554 as nb-golden

jrieken

comment created time in 2 days

push eventmicrosoft/vscode

rebornix

commit sha be2e900ee686ed0e5e25cc771155d3ddd3b989de

batch dom read and write

view details

rebornix

commit sha 6bcabc86eaf81f60f4bb268f873113d07a1dd6a0

only check offsetheight for output rendered in main frame.

view details

rebornix

commit sha de7d0b420d7cb41e29df77307c929019ebb04eec

avoid output height check during rendering.

view details

rebornix

commit sha 0f82c57ee5a7673233090144535a8f57fdc4dbf0

FastDomNode.

view details

rebornix

commit sha 2073adb1a49911be7c0a68a200b29e0a671b7f42

:lipstick:

view details

rebornix

commit sha c1021e21df3795ff5e172cba3bbf03fc2b78c87d

transform>setTop

view details

rebornix

commit sha 9dd29a9d5fde12d2294ec5341a17d2688e6481f2

last rendered height can be used as init height.

view details

Peng Lyu

commit sha b5a259b715b688b2b1ee6230b9110ecd7514b2bf

Merge pull request #133571 from microsoft/rebornix/batch-dom-read Notebook scrolling perf improvement

view details

push time in 2 days

delete branch microsoft/vscode

delete branch : rebornix/batch-dom-read

delete time in 2 days

PR merged microsoft/vscode

Notebook scrolling perf improvement

When scrolling a notebook, the notebook list view is creating cells, relayouting them and deleting them in a short period of time. Though we are using the same list view as the file explorer or settings editor, rendering a single notebook cell is much more costly. One typical improvement we can do is postponing rendering of costly component but it might harm the perceived experience (e.g. more flickering).

This PR tries to improvement the smoothness of scrolling by:

  • Batch DOM write and read
    • When rendering the viewport, the list view will try to render all possible visible cells, insert their DOM nodes into the DOM tree
    • It will then check each one's dynamic height
    • In this PR, we will only check offsetHeight/clientHeight of output elements after all cells are initially rendered, to ensure that the layout is invalidated only once
  • FastDomNode to avoid redundant DOM style updates
  • transfom: translateY for updating top properties for focus indicator.
+216 -100

0 comment

13 changed files

rebornix

pr closed time in 2 days

issue commentmicrosoft/vscode

Notebook slow scrolling caused by update layer tree

Reduced forced reflow after changes in https://github.com/microsoft/vscode/pull/133571

image

image

rebornix

comment created time in 2 days

push eventmicrosoft/vscode

rebornix

commit sha 9dd29a9d5fde12d2294ec5341a17d2688e6481f2

last rendered height can be used as init height.

view details

push time in 2 days

push eventmicrosoft/vscode

rebornix

commit sha 2073adb1a49911be7c0a68a200b29e0a671b7f42

:lipstick:

view details

rebornix

commit sha c1021e21df3795ff5e172cba3bbf03fc2b78c87d

transform>setTop

view details

push time in 2 days

PR opened microsoft/vscode

Notebook scrolling perf improvement

When scrolling a notebook, the notebook list view is creating cells, relayouting them and deleting them in a short period of time. Though we are using the same list view as the file explorer or settings editor, rendering a single notebook cell is much more costly. One typical improvement we can do is postponing rendering of costly component but it might harm the perceived experience (e.g. more flickering).

This PR tries to improvement the smoothness of scrolling by:

  • Batch DOM write and read
    • When rendering the viewport, the list view will try to render all possible visible cells, insert their DOM nodes into the DOM tree
    • It will then check each one's dynamic height
    • In this PR, we will only check offsetHeight/clientHeight of output elements after all cells are initially rendered, to ensure that the layout is invalidated only once
  • FastDomNode to avoid redundant DOM style updates
+195 -96

0 comment

12 changed files

pr created time in 3 days